April 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/4] ASoC: imx-sgtl5000: Do not enter the error path on success
by Fabio Estevam 19 Apr '13

19 Apr '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> Return on success instead of entering the error path. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/fsl/imx-sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 9584e78..88fc02c 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -174,6 +174,9 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, data); + + return 0; + clk_fail: clk_put(data->codec_clk); fail: -- 1.7.9.5

2 10

Re: [alsa-devel] [PATCH 26/28] proc: Supply a function to remove a proc entry by PDE [RFC]
by Bjorn Helgaas 18 Apr '13

18 Apr '13

On Tue, Apr 16, 2013 at 12:27 PM, David Howells <dhowells(a)redhat.com> wrote: > Supply a function (proc_remove()) to remove a proc entry (and any subtree > rooted there) by proc_dir_entry pointer rather than by name and (optionally) > root dir entry pointer. This allows us to eliminate all remaining pde->name > accesses outside of procfs. > > Signed-off-by: David Howells <dhowells(a)redhat.com> > cc: linux-acpi(a)vger.kernel.org > cc: openipmi-developer(a)lists.sourceforge.net > cc: devicetree-discuss(a)lists.ozlabs.org > cc: linux-pci(a)vger.kernel.org > cc: netdev(a)vger.kernel.org > cc: netfilter-devel(a)vger.kernel.org > cc: alsa-devel(a)alsa-project.org > --- > > drivers/acpi/sbs.c | 21 ++++----------------- > drivers/char/ipmi/ipmi_msghandler.c | 2 +- > drivers/misc/sgi-gru/gruprocfs.c | 2 +- > drivers/of/base.c | 11 +---------- > drivers/pci/proc.c | 12 +++--------- For the drivers/pci part: Acked-by: Bjorn Helgaas <bhelgaas(a)google.com> I assume you'll merge this via something other than my tree. > fs/proc/generic.c | 7 +++++++ > fs/proc/vmcore.c | 2 +- > include/linux/proc_fs.h | 2 ++ > kernel/irq/proc.c | 6 +----- > net/8021q/vlanproc.c | 9 ++------- > net/core/pktgen.c | 6 ++---- > net/ipv4/netfilter/ipt_CLUSTERIP.c | 4 ++-- > net/ipv6/proc.c | 3 +-- > net/netfilter/xt_hashlimit.c | 4 ++-- > sound/core/info.c | 19 +++++-------------- > 15 files changed, 35 insertions(+), 75 deletions(-) > > diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c > index a296e08..b6241ee 100644 > --- a/drivers/acpi/sbs.c > +++ b/drivers/acpi/sbs.c > @@ -521,19 +521,6 @@ acpi_sbs_add_fs(struct proc_dir_entry **dir, > return 0; > } > > -static void > -acpi_sbs_remove_fs(struct proc_dir_entry **dir, > - struct proc_dir_entry *parent_dir) > -{ > - if (*dir) { > - remove_proc_entry(ACPI_SBS_FILE_INFO, *dir); > - remove_proc_entry(ACPI_SBS_FILE_STATE, *dir); > - remove_proc_entry(ACPI_SBS_FILE_ALARM, *dir); > - remove_proc_entry((*dir)->name, parent_dir); > - *dir = NULL; > - } > -} > - > /* Smart Battery Interface */ > static struct proc_dir_entry *acpi_battery_dir = NULL; > > @@ -836,8 +823,8 @@ static void acpi_battery_remove(struct acpi_sbs *sbs, int id) > power_supply_unregister(&battery->bat); > } > #ifdef CONFIG_ACPI_PROCFS_POWER > - if (battery->proc_entry) > - acpi_sbs_remove_fs(&battery->proc_entry, acpi_battery_dir); > + proc_remove(battery->proc_entry); > + battery->proc_entry = NULL; > #endif > } > > @@ -873,8 +860,8 @@ static void acpi_charger_remove(struct acpi_sbs *sbs) > if (sbs->charger.dev) > power_supply_unregister(&sbs->charger); > #ifdef CONFIG_ACPI_PROCFS_POWER > - if (sbs->charger_entry) > - acpi_sbs_remove_fs(&sbs->charger_entry, acpi_ac_dir); > + proc_remove(sbs->charger_entry); > + sbs->charger_entry = NULL; > #endif > } > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 1420bbb..4d439d2 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -4541,7 +4541,7 @@ static void __exit cleanup_ipmi(void) > del_timer_sync(&ipmi_timer); > > #ifdef CONFIG_PROC_FS > - remove_proc_entry(proc_ipmi_root->name, NULL); > + proc_remove(proc_ipmi_root); > #endif /* CONFIG_PROC_FS */ > > driver_unregister(&ipmidriver.driver); > diff --git a/drivers/misc/sgi-gru/gruprocfs.c b/drivers/misc/sgi-gru/gruprocfs.c > index 950dbe9..797d796 100644 > --- a/drivers/misc/sgi-gru/gruprocfs.c > +++ b/drivers/misc/sgi-gru/gruprocfs.c > @@ -355,7 +355,7 @@ static void delete_proc_files(void) > for (p = proc_files; p->name; p++) > if (p->entry) > remove_proc_entry(p->name, proc_gru); > - remove_proc_entry("gru", proc_gru->parent); > + proc_remove(proc_gru); > } > } > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 321d3ef..9c70436 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1452,16 +1452,7 @@ int of_attach_node(struct device_node *np) > #ifdef CONFIG_PROC_DEVICETREE > static void of_remove_proc_dt_entry(struct device_node *dn) > { > - struct device_node *parent = dn->parent; > - struct property *prop = dn->properties; > - > - while (prop) { > - remove_proc_entry(prop->name, dn->pde); > - prop = prop->next; > - } > - > - if (dn->pde) > - remove_proc_entry(dn->pde->name, parent->pde); > + proc_remove(dn->pde); > } > #else > static void of_remove_proc_dt_entry(struct device_node *dn) > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 7cde7c1..0812608 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -427,20 +427,14 @@ int pci_proc_attach_device(struct pci_dev *dev) > > int pci_proc_detach_device(struct pci_dev *dev) > { > - struct proc_dir_entry *e; > - > - if ((e = dev->procent)) { > - remove_proc_entry(e->name, dev->bus->procdir); > - dev->procent = NULL; > - } > + proc_remove(dev->procent); > + dev->procent = NULL; > return 0; > } > > int pci_proc_detach_bus(struct pci_bus* bus) > { > - struct proc_dir_entry *de = bus->procdir; > - if (de) > - remove_proc_entry(de->name, proc_bus_pci_dir); > + proc_remove(bus->procdir); > return 0; > } > > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > index 2c6d6be..4b48033 100644 > --- a/fs/proc/generic.c > +++ b/fs/proc/generic.c > @@ -630,3 +630,10 @@ const char *get_proc_name(const struct proc_dir_entry *de) > return de->name; > } > EXPORT_SYMBOL_GPL(get_proc_name); > + > +void proc_remove(struct proc_dir_entry *de) > +{ > + if (de) > + remove_proc_subtree(de->name, de->parent); > +} > +EXPORT_SYMBOL(proc_remove); > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 38edddc..17f7e08 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -699,7 +699,7 @@ void vmcore_cleanup(void) > struct list_head *pos, *next; > > if (proc_vmcore) { > - remove_proc_entry(proc_vmcore->name, proc_vmcore->parent); > + proc_remove(proc_vmcore); > proc_vmcore = NULL; > } > > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 7abc72a..b8949b1 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -67,6 +67,7 @@ struct proc_dir_entry *proc_create_data(const char *name, umode_t mode, > struct proc_dir_entry *parent, > const struct file_operations *proc_fops, > void *data); > +extern void proc_remove(struct proc_dir_entry *); > extern void remove_proc_entry(const char *name, struct proc_dir_entry *parent); > extern int remove_proc_subtree(const char *name, struct proc_dir_entry *parent); > > @@ -103,6 +104,7 @@ static inline struct proc_dir_entry *proc_create_data(const char *name, > { > return NULL; > } > +static inline void proc_remove(struct proc_dir_entry *de) {} > #define remove_proc_entry(name, parent) do {} while (0) > #define remove_proc_subtree(name, parent) do {} while (0) > > diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c > index d59ae37..19ed5c4 100644 > --- a/kernel/irq/proc.c > +++ b/kernel/irq/proc.c > @@ -366,11 +366,7 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc) > > void unregister_handler_proc(unsigned int irq, struct irqaction *action) > { > - if (action->dir) { > - struct irq_desc *desc = irq_to_desc(irq); > - > - remove_proc_entry(action->dir->name, desc->dir); > - } > + proc_remove(action->dir); > } > > static void register_default_affinity_proc(void) > diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c > index 959ddbb..1d0e8921 100644 > --- a/net/8021q/vlanproc.c > +++ b/net/8021q/vlanproc.c > @@ -184,14 +184,9 @@ int vlan_proc_add_dev(struct net_device *vlandev) > */ > int vlan_proc_rem_dev(struct net_device *vlandev) > { > - struct vlan_net *vn = net_generic(dev_net(vlandev), vlan_net_id); > - > /** NOTE: This will consume the memory pointed to by dent, it seems. */ > - if (vlan_dev_priv(vlandev)->dent) { > - remove_proc_entry(vlan_dev_priv(vlandev)->dent->name, > - vn->proc_vlan_dir); > - vlan_dev_priv(vlandev)->dent = NULL; > - } > + proc_remove(vlan_dev_priv(vlandev)->dent); > + vlan_dev_priv(vlandev)->dent = NULL; > return 0; > } > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index f6af4fe..6c41e97 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -1904,7 +1904,7 @@ static void pktgen_change_name(const struct pktgen_net *pn, struct net_device *d > if (pkt_dev->odev != dev) > continue; > > - remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); > + proc_remove(pkt_dev->entry); > > pkt_dev->entry = proc_create_data(dev->name, 0600, > pn->proc_dir, > @@ -3576,8 +3576,6 @@ static void _rem_dev_from_if_list(struct pktgen_thread *t, > static int pktgen_remove_device(struct pktgen_thread *t, > struct pktgen_dev *pkt_dev) > { > - struct pktgen_net *pn = t->net; > - > pr_debug("remove_device pkt_dev=%p\n", pkt_dev); > > if (pkt_dev->running) { > @@ -3597,7 +3595,7 @@ static int pktgen_remove_device(struct pktgen_thread *t, > _rem_dev_from_if_list(t, pkt_dev); > > if (pkt_dev->entry) > - remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); > + proc_remove(pkt_dev->entry); > > #ifdef CONFIG_XFRM > free_SAs(pkt_dev); > diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c > index e4738fe..0b732ef 100644 > --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c > +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c > @@ -105,7 +105,7 @@ clusterip_config_entry_put(struct clusterip_config *c) > * functions are also incrementing the refcount on their own, > * so it's safe to remove the entry even if it's in use. */ > #ifdef CONFIG_PROC_FS > - remove_proc_entry(c->pde->name, c->pde->parent); > + proc_remove(c->pde); > #endif > return; > } > @@ -736,7 +736,7 @@ static void __exit clusterip_tg_exit(void) > { > pr_info("ClusterIP Version %s unloading\n", CLUSTERIP_VERSION); > #ifdef CONFIG_PROC_FS > - remove_proc_entry(clusterip_procdir->name, clusterip_procdir->parent); > + proc_remove(clusterip_procdir); > #endif > nf_unregister_hook(&cip_arp_ops); > xt_unregister_target(&clusterip_tg_reg); > diff --git a/net/ipv6/proc.c b/net/ipv6/proc.c > index 7ea6e18..537d9ee 100644 > --- a/net/ipv6/proc.c > +++ b/net/ipv6/proc.c > @@ -287,8 +287,7 @@ int snmp6_unregister_dev(struct inet6_dev *idev) > return -ENOENT; > if (!idev->stats.proc_dir_entry) > return -EINVAL; > - remove_proc_entry(idev->stats.proc_dir_entry->name, > - net->mib.proc_net_devsnmp6); > + proc_remove(idev->stats.proc_dir_entry); > idev->stats.proc_dir_entry = NULL; > return 0; > } > diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c > index d2fd53b..40002ef 100644 > --- a/net/netfilter/xt_hashlimit.c > +++ b/net/netfilter/xt_hashlimit.c > @@ -330,7 +330,7 @@ static void htable_destroy(struct xt_hashlimit_htable *hinfo) > parent = hashlimit_net->ip6t_hashlimit; > > if(parent != NULL) > - remove_proc_entry(hinfo->pde->name, parent); > + proc_remove(hinfo->pde); > > htable_selective_cleanup(hinfo, select_all); > vfree(hinfo); > @@ -887,7 +887,7 @@ static void __net_exit hashlimit_proc_net_exit(struct net *net) > pde = hashlimit_net->ip6t_hashlimit; > > hlist_for_each_entry(hinfo, &hashlimit_net->htables, node) > - remove_proc_entry(hinfo->pde->name, pde); > + proc_remove(hinfo->pde); > > hashlimit_net->ipt_hashlimit = NULL; > hashlimit_net->ip6t_hashlimit = NULL; > diff --git a/sound/core/info.c b/sound/core/info.c > index c7f41c3..3c9bd6b 100644 > --- a/sound/core/info.c > +++ b/sound/core/info.c > @@ -153,13 +153,6 @@ EXPORT_SYMBOL(snd_seq_root); > struct snd_info_entry *snd_oss_root; > #endif > > -static void snd_remove_proc_entry(struct proc_dir_entry *parent, > - struct proc_dir_entry *de) > -{ > - if (de) > - remove_proc_entry(de->name, parent); > -} > - > static loff_t snd_info_entry_llseek(struct file *file, loff_t offset, int orig) > { > struct snd_info_private_data *data; > @@ -580,7 +573,7 @@ int __exit snd_info_done(void) > #ifdef CONFIG_SND_OSSEMUL > snd_info_free_entry(snd_oss_root); > #endif > - snd_remove_proc_entry(NULL, snd_proc_root); > + proc_remove(snd_proc_root); > } > return 0; > } > @@ -642,7 +635,7 @@ void snd_info_card_id_change(struct snd_card *card) > { > mutex_lock(&info_mutex); > if (card->proc_root_link) { > - snd_remove_proc_entry(snd_proc_root, card->proc_root_link); > + proc_remove(card->proc_root_link); > card->proc_root_link = NULL; > } > if (strcmp(card->id, card->proc_root->name)) > @@ -661,10 +654,8 @@ void snd_info_card_disconnect(struct snd_card *card) > if (!card) > return; > mutex_lock(&info_mutex); > - if (card->proc_root_link) { > - snd_remove_proc_entry(snd_proc_root, card->proc_root_link); > - card->proc_root_link = NULL; > - } > + proc_remove(card->proc_root_link); > + card->proc_root_link = NULL; > if (card->proc_root) > snd_info_disconnect(card->proc_root); > mutex_unlock(&info_mutex); > @@ -856,7 +847,7 @@ static void snd_info_disconnect(struct snd_info_entry *entry) > list_del_init(&entry->list); > root = entry->parent == NULL ? snd_proc_root : entry->parent->p; > snd_BUG_ON(!root); > - snd_remove_proc_entry(root, entry->p); > + proc_remove(entry->p); > entry->p = NULL; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

2 1

[alsa-devel] [PATCH 00/17] ASoC: Towards a generic dmaengine PCM driver
by Lars-Peter Clausen 18 Apr '13

18 Apr '13

Hi, This series adds a (almost) generic dmaengine PCM driver for ASoC. The tegra, spear, omap, imx, mxs, ep93xx and ux500 platforms are converted to use the generic driver instead of their own custom implementation. The driver builds on top of the dmaengine PCM library and adds the missing bits. The driver was primarily built for handling devicetree based platforms, but the series also adds support for compat platforms which don't use devicetree yet or have to support non-devicetree instantiation for backwards compatibility. Since non of the converted platforms have devicetree support yet (at least not using the generic DMA bindings) this series doesn't enable devicetree support for them either. But enabling support for them is very easy and can be done by removing the SND_DMAENGINE_PCM_NO_DT flag for these platforms. For platforms using devicetree the DMA channels are requested early on before the ASoC platform driver is registered. This allows us, at least in theory, to use probe deferral if the DMA driver hasn't been probed yet. Unfortunately of_dma_request_slave_channel either returns a valid channel or NULL, so we can't distinguish between the case where there is no DMA channel assigned and the case where the DMA driver hasn't been probed yet. I plan to submit a patch which lets of_dma_request_slave_channel return a ERR_PTR, but for now the generic PCM dmaengine driver assumes that the DMA driver will always be probed before it. For the compat case the DMA channel gets requested from within the PCM driver's pcm_new callback. This requires some minor changes to some of the DAI drivers moving the initialization of the DAI DMA data pointer from the DAI startup callback to the DAI probe callback. Unfortunately the driver is not fully generic yet and we still need some platform specific data to make it work, but the plan is to eventually make the driver fully generic in the future. The platform specific bits currently are: * The snd_pcm_hardware struct which contains device specific parameters like the maximum period size and maximum number of periods as well as whether the driver supports pause and resume. The idea is to get rid of the per platform snd_pcm_hardware struct by extending the dmaengine API to a point where we can query all necessary information from the dmaengine driver to fill in the snd_pcm_hardware struct at runtime. * The size of the pre-allocated audio buffer. All platforms seem use different sizes and since some of them might be sensitive to changes to the buffer size this series keeps the original size for now. But we should probably try to decide on a sane default for this and maybe allow ASoC board drivers to overwrite it somehow. * A callback to fill in the dma_slave_config. Currently this is either NULL (for platforms which don't need to configure the DMA channel at runtime) or uses the generic snd_dmaengine_pcm_prepare_slave_config(), which uses snd_hwparams_to_dma_slave_config() and snd_dmaengine_pcm_set_config_from_dai_data(). The later requires the platform to use the generic DMA DAI data struct though, hopefully we'll be able to convert all platforms to use this generic struct, and once that's done we can always use snd_dmaengine_pcm_prepare_slave_config() unconditionally. * For platforms not using devicetree platforms a callback to request the dma channel. This can either be a completely custom function which returns the channel or a filter function which will be passed to dma_request_channel. The route forward here probably is to let the DAI driver provide the filter function or implement a table based DMA channel lookup like we have for other subsystems (like clk or regulator) where the board file provides a mapping based on the device name. Platforms which use the dmaengine pcm library but are not converted to the generic driver yet are atmel and mmp. mmp use a custom genalloc based memory allocator, we may add support for this to the generic driver at a later point. The atmel PCM driver is very interlocked with atmel SSC DAI driver, it'll probably require some serious refactoring before it can use the generic dmaengine PCM driver. The driver uses snd_pcm_lib_preallocate_pages to preallocate the memory buffer. snd_pcm_lib_preallocate_pages internally uses dma_alloc_coherent, while most of the platforms converted in this series use dma_alloc_writecombine. Laxman Dewangan submitted a patch[1] a couple of months ago to add support for dma_alloc_writecombine to snd_pcm_lib_preallocate_pages, I always thought the patch had been merged, but it looks like I was mistaken. So if there are concerns about performance regression due to using coherent instead of writecombine mappings we'll have to postpone converting these platforms until Laxman's patch has been merged. The compat path of this series hasn't been runtime tested yet and neither have the platforms which are converted in this series. I probably broke one or two of them by accident, so please test the patches. Thanks, - Lars [1] https://lkml.org/lkml/2012/7/2/94 Lars-Peter Clausen (17): ASoC: dmaengine-pcm: Make requesting the DMA channel at PCM open optional ASoC: Add snd_soc_{add,remove}_platform ASoC: Add a generic dmaengine_pcm driver ASoC: dmaengine_pcm: Add support for compat platforms ASoC: tegra: Use generic dmaengine PCM ASoC: spear: Setup dma data in DAI probe ASoC: spear: Use generic dmaengine PCM ASoC: dmaengine-pcm: Add support for platforms which can't report residue ASoC: mxs: Setup dma data in DAI probe ASoC: mxs: Use generic dmaengine PCM ASoC: imx: Setup dma data in DAI probe ASoC: imx: Use generic dmaengine PCM ASoC: omap: Setup dma data in DAI probe ASoC: omap: Use generic dmaengine PCM ASoC: ep93xx: Setup dma data in DAI probe ASoC: ep93xx: Use generic dmaengine PCM ASoC: ux500: Use generic dmaengine PCM include/sound/dmaengine_pcm.h | 65 +++++++- include/sound/soc.h | 4 + sound/soc/Kconfig | 4 + sound/soc/Makefile | 4 + sound/soc/atmel/atmel-pcm-dma.c | 6 +- sound/soc/cirrus/Kconfig | 2 +- sound/soc/cirrus/ep93xx-ac97.c | 14 +- sound/soc/cirrus/ep93xx-i2s.c | 14 +- sound/soc/cirrus/ep93xx-pcm.c | 137 ++-------------- sound/soc/fsl/Kconfig | 2 +- sound/soc/fsl/fsl_ssi.c | 19 ++- sound/soc/fsl/imx-pcm-dma.c | 76 ++------- sound/soc/fsl/imx-pcm.c | 6 +- sound/soc/fsl/imx-pcm.h | 5 + sound/soc/fsl/imx-ssi.c | 22 +-- sound/soc/mxs/Kconfig | 2 +- sound/soc/mxs/mxs-pcm.c | 135 ++-------------- sound/soc/mxs/mxs-saif.c | 3 +- sound/soc/omap/Kconfig | 2 +- sound/soc/omap/omap-dmic.c | 4 +- sound/soc/omap/omap-hdmi.c | 12 +- sound/soc/omap/omap-mcbsp.c | 6 +- sound/soc/omap/omap-mcpdm.c | 7 +- sound/soc/omap/omap-pcm.c | 186 ++-------------------- sound/soc/pxa/mmp-pcm.c | 5 +- sound/soc/soc-core.c | 85 +++++++--- sound/soc/soc-dmaengine-pcm.c | 82 +++++++--- sound/soc/soc-generic-dmaengine-pcm.c | 284 ++++++++++++++++++++++++++++++++++ sound/soc/spear/spdif_in.c | 12 +- sound/soc/spear/spdif_out.c | 7 +- sound/soc/spear/spear_pcm.c | 151 ++---------------- sound/soc/tegra/Kconfig | 2 +- sound/soc/tegra/tegra_pcm.c | 171 ++------------------ sound/soc/ux500/Kconfig | 2 +- sound/soc/ux500/ux500_pcm.c | 159 ++----------------- 35 files changed, 651 insertions(+), 1046 deletions(-) create mode 100644 sound/soc/soc-generic-dmaengine-pcm.c -- 1.8.0

7 48

Re: [alsa-devel] [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC]
by Bjorn Helgaas 18 Apr '13

18 Apr '13

On Tue, Apr 16, 2013 at 12:26 PM, David Howells <dhowells(a)redhat.com> wrote: > Supply accessor functions to set attributes in proc_dir_entry structs. > > The following are supplied: proc_set_size() and proc_set_user(). > > Signed-off-by: David Howells <dhowells(a)redhat.com> > cc: linuxppc-dev(a)lists.ozlabs.org > cc: linux-media(a)vger.kernel.org > cc: netdev(a)vger.kernel.org > cc: linux-wireless(a)vger.kernel.org > cc: linux-pci(a)vger.kernel.org > cc: netfilter-devel(a)vger.kernel.org > cc: alsa-devel(a)alsa-project.org > --- > > arch/powerpc/kernel/proc_powerpc.c | 2 +- > arch/powerpc/platforms/pseries/reconfig.c | 2 +- > drivers/media/pci/ttpci/av7110_ir.c | 2 +- > drivers/net/irda/vlsi_ir.c | 2 +- > drivers/net/wireless/airo.c | 34 +++++++++-------------------- > drivers/pci/proc.c | 2 +- For the drivers/pci part: Acked-by: Bjorn Helgaas <bhelgaas(a)google.com> > fs/proc/generic.c | 13 +++++++++++ > include/linux/proc_fs.h | 5 ++++ > kernel/configs.c | 2 +- > kernel/profile.c | 2 +- > net/netfilter/xt_recent.c | 3 +-- > sound/core/info.c | 2 +- > 12 files changed, 38 insertions(+), 33 deletions(-) > > diff --git a/arch/powerpc/kernel/proc_powerpc.c b/arch/powerpc/kernel/proc_powerpc.c > index 41d8ee9..feb8580 100644 > --- a/arch/powerpc/kernel/proc_powerpc.c > +++ b/arch/powerpc/kernel/proc_powerpc.c > @@ -83,7 +83,7 @@ static int __init proc_ppc64_init(void) > &page_map_fops, vdso_data); > if (!pde) > return 1; > - pde->size = PAGE_SIZE; > + proc_set_size(pde, PAGE_SIZE); > > return 0; > } > diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c > index d6491bd..f93cdf5 100644 > --- a/arch/powerpc/platforms/pseries/reconfig.c > +++ b/arch/powerpc/platforms/pseries/reconfig.c > @@ -452,7 +452,7 @@ static int proc_ppc64_create_ofdt(void) > > ent = proc_create("powerpc/ofdt", S_IWUSR, NULL, &ofdt_fops); > if (ent) > - ent->size = 0; > + proc_set_size(ent, 0); > > return 0; > } > diff --git a/drivers/media/pci/ttpci/av7110_ir.c b/drivers/media/pci/ttpci/av7110_ir.c > index eb82286..0e763a7 100644 > --- a/drivers/media/pci/ttpci/av7110_ir.c > +++ b/drivers/media/pci/ttpci/av7110_ir.c > @@ -375,7 +375,7 @@ int av7110_ir_init(struct av7110 *av7110) > if (av_cnt == 1) { > e = proc_create("av7110_ir", S_IWUSR, NULL, &av7110_ir_proc_fops); > if (e) > - e->size = 4 + 256 * sizeof(u16); > + proc_set_size(e, 4 + 256 * sizeof(u16)); > } > > tasklet_init(&av7110->ir.ir_tasklet, av7110_emit_key, (unsigned long) &av7110->ir); > diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c > index e22cd4e..5f47584 100644 > --- a/drivers/net/irda/vlsi_ir.c > +++ b/drivers/net/irda/vlsi_ir.c > @@ -1678,7 +1678,7 @@ vlsi_irda_probe(struct pci_dev *pdev, const struct pci_device_id *id) > IRDA_WARNING("%s: failed to create proc entry\n", > __func__); > } else { > - ent->size = 0; > + proc_set_size(ent, 0); > } > idev->proc_entry = ent; > } > diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c > index 66e398d..21d0233 100644 > --- a/drivers/net/wireless/airo.c > +++ b/drivers/net/wireless/airo.c > @@ -4507,73 +4507,63 @@ static int setup_proc_entry( struct net_device *dev, > airo_entry); > if (!apriv->proc_entry) > goto fail; > - apriv->proc_entry->uid = proc_kuid; > - apriv->proc_entry->gid = proc_kgid; > + proc_set_user(apriv->proc_entry, proc_kuid, proc_kgid); > > /* Setup the StatsDelta */ > entry = proc_create_data("StatsDelta", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_statsdelta_ops, dev); > if (!entry) > goto fail_stats_delta; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Stats */ > entry = proc_create_data("Stats", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_stats_ops, dev); > if (!entry) > goto fail_stats; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Status */ > entry = proc_create_data("Status", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_status_ops, dev); > if (!entry) > goto fail_status; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Config */ > entry = proc_create_data("Config", proc_perm, > apriv->proc_entry, &proc_config_ops, dev); > if (!entry) > goto fail_config; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the SSID */ > entry = proc_create_data("SSID", proc_perm, > apriv->proc_entry, &proc_SSID_ops, dev); > if (!entry) > goto fail_ssid; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the APList */ > entry = proc_create_data("APList", proc_perm, > apriv->proc_entry, &proc_APList_ops, dev); > if (!entry) > goto fail_aplist; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the BSSList */ > entry = proc_create_data("BSSList", proc_perm, > apriv->proc_entry, &proc_BSSList_ops, dev); > if (!entry) > goto fail_bsslist; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the WepKey */ > entry = proc_create_data("WepKey", proc_perm, > apriv->proc_entry, &proc_wepkey_ops, dev); > if (!entry) > goto fail_wepkey; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > - > + proc_set_user(entry, proc_kuid, proc_kgid); > return 0; > > fail_wepkey: > @@ -5695,10 +5685,8 @@ static int __init airo_init_module( void ) > > airo_entry = proc_mkdir_mode("driver/aironet", airo_perm, NULL); > > - if (airo_entry) { > - airo_entry->uid = proc_kuid; > - airo_entry->gid = proc_kgid; > - } > + if (airo_entry) > + proc_set_user(airo_entry, proc_kuid, proc_kgid); > > for (i = 0; i < 4 && io[i] && irq[i]; i++) { > airo_print_info("", "Trying to configure ISA adapter at irq=%d " > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 12e4fb5..7cde7c1 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -419,7 +419,7 @@ int pci_proc_attach_device(struct pci_dev *dev) > &proc_bus_pci_operations, dev); > if (!e) > return -ENOMEM; > - e->size = dev->cfg_size; > + proc_set_size(e, dev->cfg_size); > dev->procent = e; > > return 0; > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > index 1c07cad..5f6f6c3 100644 > --- a/fs/proc/generic.c > +++ b/fs/proc/generic.c > @@ -498,6 +498,19 @@ out: > return NULL; > } > EXPORT_SYMBOL(proc_create_data); > + > +void proc_set_size(struct proc_dir_entry *de, loff_t size) > +{ > + de->size = size; > +} > +EXPORT_SYMBOL(proc_set_size); > + > +void proc_set_user(struct proc_dir_entry *de, kuid_t uid, kgid_t gid) > +{ > + de->uid = uid; > + de->gid = gid; > +} > +EXPORT_SYMBOL(proc_set_user); > > static void free_proc_entry(struct proc_dir_entry *de) > { > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 805edac..28a4d7e 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -130,6 +130,9 @@ static inline struct proc_dir_entry *proc_create(const char *name, umode_t mode, > extern struct proc_dir_entry *proc_net_mkdir(struct net *net, const char *name, > struct proc_dir_entry *parent); > > +extern void proc_set_size(struct proc_dir_entry *, loff_t); > +extern void proc_set_user(struct proc_dir_entry *, kuid_t, kgid_t); > + > extern struct file *proc_ns_fget(int fd); > extern bool proc_ns_inode(struct inode *inode); > > @@ -158,6 +161,8 @@ static inline struct proc_dir_entry *proc_mkdir(const char *name, > struct proc_dir_entry *parent) {return NULL;} > static inline struct proc_dir_entry *proc_mkdir_mode(const char *name, > umode_t mode, struct proc_dir_entry *parent) { return NULL; } > +static inline void proc_set_size(struct proc_dir_entry *de, loff_t size) {} > +static inline void proc_set_user(struct proc_dir_entry *de, kuid_t uid, kgid_t gid) {} > > struct tty_driver; > static inline void proc_tty_register_driver(struct tty_driver *driver) {}; > diff --git a/kernel/configs.c b/kernel/configs.c > index 42e8fa0..c18b1f1 100644 > --- a/kernel/configs.c > +++ b/kernel/configs.c > @@ -79,7 +79,7 @@ static int __init ikconfig_init(void) > if (!entry) > return -ENOMEM; > > - entry->size = kernel_config_data_size; > + proc_set_size(entry, kernel_config_data_size); > > return 0; > } > diff --git a/kernel/profile.c b/kernel/profile.c > index 524ce5e..0bf4007 100644 > --- a/kernel/profile.c > +++ b/kernel/profile.c > @@ -600,7 +600,7 @@ int __ref create_proc_profile(void) /* false positive from hotcpu_notifier */ > NULL, &proc_profile_operations); > if (!entry) > return 0; > - entry->size = (1+prof_len) * sizeof(atomic_t); > + proc_set_size(entry, (1 + prof_len) * sizeof(atomic_t)); > hotcpu_notifier(profile_cpu_callback, 0); > return 0; > } > diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c > index 3db2d38..1e657cf 100644 > --- a/net/netfilter/xt_recent.c > +++ b/net/netfilter/xt_recent.c > @@ -401,8 +401,7 @@ static int recent_mt_check(const struct xt_mtchk_param *par, > ret = -ENOMEM; > goto out; > } > - pde->uid = uid; > - pde->gid = gid; > + proc_set_user(pde, uid, gid); > #endif > spin_lock_bh(&recent_lock); > list_add_tail(&t->list, &recent_net->tables); > diff --git a/sound/core/info.c b/sound/core/info.c > index 3aa8864..c7f41c3 100644 > --- a/sound/core/info.c > +++ b/sound/core/info.c > @@ -970,7 +970,7 @@ int snd_info_register(struct snd_info_entry * entry) > mutex_unlock(&info_mutex); > return -ENOMEM; > } > - p->size = entry->size; > + proc_set_size(p, entry->size); > } > entry->p = p; > if (entry->parent) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

1 0

[alsa-devel] [PATCH v4 00/10] ASoC: fsl-ssi: ac97-slave support
by Markus Pargmann 18 Apr '13

18 Apr '13

Hi, This series adds DT support for phycore-ac97. It is now based on the pcm dma cleanups from Lars. Beside ac97 support, the series adds fsl-ssi imx-pcm-fiq and generic DMA binding handling. Regards, Markus Changes in v4: - phycore-ac97 uses the iomux functions based on audmux phandle now. - fsl-ssi imx-pcm-fiq got some new comments about problems with imx-ssi and incompatible codecs Changes in v3: - Rebased onto pcm dma cleanup patches - A lot of cleanups for the fsl-ssi ac97 integration - Some small changes which are listed in the notes of the patches. Markus Pargmann (10): ASoC: phycore-ac97: Add DT support ASoC: imx-pcm-dma: DT support ASoC: imx-pcm-fiq: Introduce pcm-fiq-params ASoC: fsl-ssi: Add support for imx-pcm-fiq ASoC: fsl-ssi: Use generic DMA bindings if possible ARM: imx: Export ac97 reset functions ASoC: fsl-ssi: imx ac97 support ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 ASoC: fsl: Move fsl-ssi binding doc to sound/ ASoC: fsl: Update fsl-ssi binding doc Documentation/devicetree/bindings/{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} | 10 ++ Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt | 14 ++ arch/arm/mach-imx/mach-pca100.c | 7 +- arch/arm/mach-imx/mach-pcm043.c | 7 +- sound/soc/fsl/Kconfig | 2 +- sound/soc/fsl/fsl_ssi.c | 512 ++++++++++++++++++++++++++++++++++++++++++++++++---------- sound/soc/fsl/imx-pcm-dma.c | 4 +- sound/soc/fsl/imx-pcm-fiq.c | 16 +- sound/soc/fsl/imx-pcm.h | 9 ++ sound/soc/fsl/imx-ssi.c | 7 +- sound/soc/fsl/imx-ssi.h | 1 + sound/soc/fsl/phycore-ac97.c | 166 ++++++++++++++++--- 12 files changed, 633 insertions(+), 122 deletions(-) rename Documentation/devicetree/bindings/{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} (88%) create mode 100644 Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt

3 13

[alsa-devel] More ASoC updates for v3.10
by Mark Brown 18 Apr '13

18 Apr '13

The following changes since commit b02e48f2f8755e51fe8ce246988a29bd96f6b85e: MAINTAINERS: Update e-mail address (2013-04-12 11:53:41 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next for you to fetch changes up to 24568ea4bef5ab8106206eddf5512434421c00ed: Merge remote-tracking branch 'asoc/topic/max98088' into asoc-next (2013-04-18 15:05:35 +0100) There's a bunch of extra stuff in the diffstat/log since your for-next is further behind Linus' tree than one of my branches. ---------------------------------------------------------------- ASoC: More updates for v3.10 The main additional change here is Lars-Peter's DMA work plus the platform conversions which have been tested - getting this in mainline will make life easier for development after the merge window. These factor a large chunk of code out of the drivers for the platforms using dmaengine, greatly simplifying development. ---------------------------------------------------------------- Al Viro (3): ecryptfs: close rmmod race procfs: add proc_remove_subtree() palinfo fixes Alex Williamson (1): vfio-pci: Fix possible integer overflow Alexandre Belloni (1): gpio: pca953x: fix irq_domain_add_simple usage Alexey Khoroshilov (1): tty: mxser: fix cycle termination condition in mxser_probe() and mxser_module_init() Alexey Pelykh (1): OMAP/serial: Revert bad fix of Rx FIFO threshold granularity Andrea Arcangeli (2): x86/mm/cpa: Convert noop to functional fix x86/mm/cpa/selftest: Fix false positive in CPA self test Andrey Vagin (1): mnt: release locks on error path in do_loopback Arnd Bergmann (5): block: avoid using uninitialized value in from queue_var_store Merge tag 'mxs-fixes-3.9-4' of git://git.linaro.org/people/shawnguo/linux-2.6 into fixes Merge tag 'imx-fixes-3.9-5' of git://git.linaro.org/people/shawnguo/linux-2.6 into fixes Merge tag 'samsung-fixes-for-v3.9' of git://git.kernel.org/.../kgene/linux-samsung into fixes Merge tag 'mvebu_fixes_for_v3.9_round3' of git://git.infradead.org/users/jcooper/linux into fixes Artem Savkov (1): cfg80211: sched_scan_mtx lock in cfg80211_conn_work() Arun Easi (1): [SCSI] qla2xxx: Fix crash during firmware dump procedure. Asai Thambi S P (3): mtip32xx: recovery from command timeout mtip32xx: return 0 from pci probe in case of rebuild mtip32xx: Add debugfs entry device_status Asias He (7): tcm_vhost: Use ACCESS_ONCE for vs->vs_tpg[target] access tcm_vhost: Use vq->private_data to indicate if the endpoint is setup tcm_vhost: Initialize vq->last_used_idx when set endpoint tcm_vhost: Remove double check of response tcm_vhost: Fix tv_cmd leak in vhost_scsi_handle_vq tcm_vhost: Add vhost_scsi_send_bad_target() helper tcm_vhost: Send bad target to guest when cmd fails Bing Zhao (1): mwifiex: complete last internal scan Boris Ostrovsky (2): x86, mm: Patch out arch_flush_lazy_mmu_mode() when running on bare metal x86/mm: Flush lazy MMU when DEBUG_PAGEALLOC is set Brian King (1): [SCSI] ibmvscsi: Fix slave_configure deadlock Calvin Owens (1): drm/nouveau: fix unconditional return waiting on memory Chen Gang (3): perf: Fix strncpy() use, always make sure it's NUL terminated perf: Fix strncpy() use, use strlcpy() instead of strncpy() ftrace: Fix strncpy() use, use strlcpy() instead of strncpy() Chris Metcalf (1): tile: comment assumption about __insn_mtspr for <asm/irqflags.h> Christian Ruppert (1): ARC: Add implicit compiler barrier to raw_local_irq* functions Christoph Paasch (1): ipv6/tcp: Stop processing ICMPv6 redirect messages Christopher Harvey (1): drm/mgag200: Index 24 in extended CRTC registers is 24 in hex, not decimal. Chuck Lever (1): SUNRPC: Remove extra xprt_put() Daniel Vetter (1): drm/fb-helper: Fix locking in drm_fb_helper_hotplug_event Dave Airlie (2): Merge branch 'drm-nouveau-fixes-3.9' of git://anongit.freedesktop.org/git/nouveau/linux-2.6 into drm-fixes udl: handle EDID failure properly. Dave Hansen (1): x86-32: Fix possible incomplete TLB invalidate with PAE pagetables David S. Miller (3): Merge branch 'infoleaks' Merge branch 'wireless' Merge branch 'fixes-for-3.9' of git://gitorious.org/linux-can/linux-can David Woodhouse (1): libata: fix DMA to stack in reading devslp_timing parameters Dirk Behme (1): ARM i.MX6: Fix ldb_di clock selection Dirk Brandewie (1): cpufreq / intel_pstate: Set timer timeout correctly Dmitry Tarnyagin (1): remoteproc/ste: fix memory leak on shutdown Dylan Reid (1): ASoC: max98088: Fix logging of hardware revision. Eldad Zack (1): ALSA: usb-audio: fix endianness bug in snd_nativeinstruments_* Eric Dumazet (1): selinux: add a skb_owned_by() hook Franky Lin (1): brcmfmac: do not proceed if fail to download nvram to dongle Gabor Juhos (1): rt2x00: rt2x00pci: fix build error on Ralink RT3x5x SoCs Greg Ungerer (1): m68k: define a local gpio_request_one() function Gregory CLEMENT (1): arm: mvebu: Fix the irq map function in SMP mode Guennadi Liakhovetski (1): tty: Documentation: fix a path in a DocBook template Guenter Roeck (1): misc/vmw_vmci: Add dependency on CONFIG_NET Haiyang Zhang (2): hyperv: Fix a kernel warning from netvsc_linkstatus_callback() hyperv: Fix RNDIS send_completion code path Hante Meuleman (3): brcmfmac: fix tkip mic tx/rx ap swap bug. brcmfmac: fix stopping AP. brcmfmac: fix returning cipher_suite for get_key operation. Huacai Chen (1): PM / reboot: call syscore_shutdown() after disable_nonboot_cpus() Jan Kiszka (1): ftrace: Consistently restore trace function on sysctl enabling Jens Axboe (2): mtip32xx: fix two smatch warnings Revert "loop: cleanup partitions when detaching loop device" Jiri Pirko (2): net: ipv4: reset check_lifetime_work after changing lifetime net: ipv4: fix schedule while atomic bug in check_lifetime() Joe Carnuccio (1): [SCSI] Revert "qla2xxx: Add setting of driver version string for vendor application." Joe Lawrence (1): [SCSI] st: Take additional queue ref in st_probe John Gong (1): [SCSI] libsas: use right function to alloc smp response John W. Linville (2): Merge branch 'for-john' of git://git.kernel.org/.../jberg/mac80211 Merge branch 'master' of git://git.kernel.org/.../linville/wireless into for-davem Josef Bacik (1): Btrfs: make sure nbytes are right after log replay Jussi Kivilinna (1): crypto: gcm - fix assumption that assoc has one segment Keir Fraser (1): xen/events: Handle VIRQ_TIMER before any other hardirq in event loop. Kleber Sacilotto de Souza (1): [SCSI] ipr: fix addition of abort command to HRRQ free queue Konrad Rzeszutek Wilk (1): xen/mmu: On early bootup, flush the TLB when changing RO->RW bits Xen provided pagetables. Krzysztof Mazur (1): [libata] Fix HDIO_DRIVE_* ioctl() Linux 3.9 regression Lars-Peter Clausen (9): ASoC: dmaengine-pcm: Make requesting the DMA channel at PCM open optional ASoC: Add snd_soc_{add, remove}_platform ASoC: Add a generic dmaengine_pcm driver ASoC: dmaengine_pcm: Add support for compat platforms ASoC: tegra: Use generic dmaengine PCM ASoC: dmaengine-pcm: Add support for platforms which can't report residue ASoC: imx: Setup dma data in DAI probe ASoC: imx: Use generic dmaengine PCM ASoC: ux500: Use generic dmaengine PCM Li Fei (1): hwspinlock: fix __hwspin_lock_request error path Linus Torvalds (39): Merge tag 'trace-fixes-3.9-rc6' of git://git.kernel.org/.../rostedt/linux-trace Merge tag 'upstream-linus' of git://git.kernel.org/.../jgarzik/libata-dev Merge tag 'for-linus' of git://git.kernel.org/.../sfr/next-fixes Merge tag 'remoteproc-3.9-fixes' of git://git.kernel.org/.../ohad/remoteproc Merge tag 'hwspinlock-3.9-fix' of git://git.kernel.org/.../ohad/hwspinlock spinlocks and preemption points need to be at least compiler barriers Merge tag 'for-linus-20130409' of git://git.kernel.dk/linux-block Merge tag 'vfio-v3.9-rc7' of git://github.com/awilliam/linux-vfio Merge branch 'for-linus' of git://git.kernel.org/.../viro/vfs Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux Merge git://git.kernel.org/.../herbert/crypto-2.6 Merge tag 'nfs-for-3.9-4' of git://git.linux-nfs.org/projects/trondmy/linux-nfs Merge tag 'nfs-for-3.9-5' of git://git.linux-nfs.org/projects/trondmy/linux-nfs Merge tag 'for-linus' of git://linux-c6x.org/git/projects/linux-c6x-upstreaming Merge git://git.kernel.org/.../davem/net Merge tag 'trace-fixes-3.9-rc-v2' of git://git.kernel.org/.../rostedt/linux-trace Merge tag 'stable/for-linus-3.9-rc6-tag' of git://git.kernel.org/.../konrad/xen Merge tag 'tty-3.9-rc6' of git://git.kernel.org/.../gregkh/tty Merge tag 'char-misc-3.9-rc6' of git://git.kernel.org/.../gregkh/char-misc Merge tag 'arm-soc-fixes' of git://git.kernel.org/.../arm/arm-soc Merge tag 'gpio-fixes-v3.9-rc6' of git://git.kernel.org/.../linusw/linux-gpio Merge tag 'regmap-v3.9-rc6' of git://git.kernel.org/.../broonie/regmap Merge tag 'pm-3.9-rc7' of git://git.kernel.org/.../rafael/linux-pm Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma Merge tag 'sound-3.9' of git://git.kernel.org/.../tiwai/sound Merge branch 'for-next' of git://git.samba.org/sfrench/cifs-2.6 Merge tag 'scsi-fixes' of git://git.kernel.org/.../jejb/scsi Merge git://git.kernel.org/.../nab/target-pending kobject: fix kset_find_obj() race with concurrent last kobject_put() Add file_ns_capable() helper function for open-time capability checking Merge tag 'trace-fixes-v3.9-rc-v3' of git://git.kernel.org/.../rostedt/linux-trace Merge branch 'for-linus' of git://git.kernel.org/.../mason/linux-btrfs Merge git://www.linux-watchdog.org/linux-watchdog Merge branch 'for-linus' of git://git.kernel.org/.../gerg/m68knommu Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/.../tip/tip Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/.../tip/tip Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/.../tip/tip Linux 3.9-rc7 Linus Walleij (1): crypto: ux500 - add missing comma Lukasz Dorau (1): [SCSI] libsas: fix handling vacant phy in sas_set_ex_phy() Marek Vasut (1): ARM: mxs: Slow down the I2C clock speed Mark Brown (13): regmap: Back out work buffer fix Merge remote-tracking branch 'asoc/fix/compress' into tmp Merge remote-tracking branch 'asoc/fix/core' into tmp Merge remote-tracking branch 'asoc/fix/samsung' into tmp Merge remote-tracking branch 'asoc/fix/tegra' into tmp Merge remote-tracking branch 'asoc/fix/wm8903' into tmp Merge branch 'topic/core' of git://git.kernel.org/.../broonie/sound into asoc-dma Merge tag 'v3.9-rc7' into asoc-dma Merge remote-tracking branch 'asoc/topic/core' into asoc-next Merge remote-tracking branch 'asoc/topic/cs4271' into asoc-next Merge remote-tracking branch 'asoc/topic/dma' into asoc-next Merge remote-tracking branch 'asoc/topic/fsl' into asoc-next Merge remote-tracking branch 'asoc/topic/max98088' into asoc-next Mark Salter (1): add memory barrier to arch_local_irq_restore Markus Pargmann (3): ARM: clk-imx35: Bugfix iomux clock ARM: imx35 Bugfix admux clock ASoC: fsl-ssi: Add SACNT definitions Mathias Krause (16): atm: update msg_namelen in vcc_recvmsg() ax25: fix info leak via msg_name in ax25_recvmsg() Bluetooth: fix possible info leak in bt_sock_recvmsg() Bluetooth: RFCOMM - Fix missing msg_namelen update in rfcomm_sock_recvmsg() Bluetooth: SCO - Fix missing msg_namelen update in sco_sock_recvmsg() caif: Fix missing msg_namelen update in caif_seqpkt_recvmsg() irda: Fix missing msg_namelen update in irda_recvmsg_dgram() iucv: Fix missing msg_namelen update in iucv_sock_recvmsg() l2tp: fix info leak in l2tp_ip6_recvmsg() llc: Fix missing msg_namelen update in llc_ui_recvmsg() netrom: fix info leak via msg_name in nr_recvmsg() NFC: llcp: fix info leaks via msg_name in llcp_sock_recvmsg() rose: fix info leak via msg_name in rose_recvmsg() tipc: fix info leaks via msg_name in recv_msg/recv_stream VSOCK: vmci - fix possible info leak in vmci_transport_dgram_dequeue() VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg() Michael Riesch (1): rtnetlink: Call nlmsg_parse() with correct header length Michael Wolf (1): powerpc: pSeries_lpar_hpte_remove fails from Adjunct partition being performed before the ANDCOND test Namhyung Kim (2): tracing: Fix double free when function profile init failed tracing: Fix possible NULL pointer dereferences Neil Horman (1): e100: Add dma mapping error check Nicholas Bellinger (1): target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs Nicolas Ferre (1): watchdog: Revert the AT91RM9200_WATCHDOG dependency Nigel Roberts (2): ARM: Kirkwood: Fix typo in the definition of ix2-200 rebuild LED Fix GE0/GE1 init on ix2-200 as GE0 has no PHY Padmavathi Venna (1): DMA: PL330: Add check if device tree compatible Paul Moore (1): lsm: add the missing documentation for the security_skb_owned_by() hook Peter Ujfalusi (1): dmaengine: omap-dma: Start DMA without delay for cyclic channels Robert Shade (1): ath9k: Re-enable interrupts after a channel change failure Robert Tivy (1): remoteproc: fix FW_CONFIG typo Roland Stigge (1): MAINTAINERS: Add maintainer for LPC32xx Sachin Prabhu (1): cifs: Allow passwords which begin with a delimitor Samu Kallio (1): x86, mm, paravirt: Fix vmalloc_fault oops during lazy MMU updates Saurav Kashyap (3): [SCSI] qla2xxx: Update copyright dates information in LICENSE.qla2xxx file. [SCSI] qla2xxx: Remove debug code that msleeps for random duration. [SCSI] qla2xxx: Update the driver version to 8.04.00.13-k. Sean Young (1): Revert "tty/8250_pnp: serial port detection regression since v3.7" Shan Hai (2): libata: Use integer return value for atapi_command_packet_set libata: Set max sector to 65535 for Slimtype DVD A DS8A8SH drive Shawn Guo (1): ARM: imx: provide twd clock lookup from device tree Sjur Brændeland (1): remoteproc: fix error path of handle_vdev Sridhar Samudrala (1): sctp: remove 'sridhar' from maintainers list Stanislaw Gruszka (1): sched/cputime: Fix accounting on multi-threaded processes Stas Sergeev (1): ASoC: define playback and capture streams in dummy codec Stefan Raspl (1): qeth: fix qeth_wait_for_threads() deadlock for OSN devices Stephane Eranian (2): perf/x86: Fix uninitialized pt_regs in intel_pmu_drain_bts_buffer() perf: Fix ring_buffer perf_output_space() boundary calculation Steven Rostedt (Red Hat) (3): tracing: Fix race with update_max_tr_single and changing tracers ftrace: Do not call stub functions in control loop ftrace: Move ftrace_filter_lseek out of CONFIG_DYNAMIC_FTRACE section Suleiman Souhlal (1): vfs: Revert spurious fix to spinning prevention in prune_icache_sb Suman Anna (1): remoteproc: fix the error check for idr_alloc Sylwester Nawrocki (2): ARM: S3C24XX: Correct NR_IRQS definition for s3c2440 ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller Takashi Iwai (2): Merge tag 'asoc-v3.9-rc6' of git://git.kernel.org/.../broonie/sound into for-linus Merge tag 'asoc-maintainers-v3.9-rc6' of git://git.kernel.org/.../broonie/sound into for-linus Tejun Heo (1): sched: Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s Thomas Gleixner (1): sched_clock: Prevent 64bit inatomicity on 32bit systems Tim Gardner (1): rt2x00: rt2x00pci_regbusy_read() - only print register access failure once Trond Myklebust (5): NFSv4: Fix a memory leak in nfs4_discover_server_trunking NFSv4/4.1: Fix bugs in nfs4[01]_walk_client_list SUNRPC: Fix a potential memory leak in rpc_new_client NFSv4: Fix another potential state manager deadlock NFSv4: Doh! Typo in the fix to nfs41_walk_client_list Ursula Braun (1): af_iucv: fix recvmsg by replacing skb_pull() function Wei Yongjun (4): netrom: fix invalid use of sizeof in nr_recvmsg() can: gw: use kmem_cache_free() instead of kfree() [SCSI] lpfc: fix potential NULL pointer dereference in lpfc_sli4_rq_put() perf: Fix error return code Yaniv Rosner (1): bnx2x: Fix KR2 rapid link flap Youquan Song (1): ata_piix: Fix DVD not dectected at some Haswell platforms Yuval Mintz (1): bnx2x: Prevent null pointer dereference in AFEX mode libin (1): sched/debug: Fix sd->*_idx limit range avoiding overflow nikolay(a)redhat.com (2): Revert "bonding: remove sysfs before removing devices" bonding: fix bonding_masters race condition in bond unloading wenxiong(a)linux.vnet.ibm.com (2): [SCSI] ipr: ipr_test_msi() fails when running with msi-x enabled adapter [SCSI] ipr: dlpar failed when adding an adapter back willy tarreau (1): net: mvneta: enable features before registering the driver Documentation/DocBook/device-drivers.tmpl | 2 +- Documentation/scsi/LICENSE.qla2xxx | 2 +- MAINTAINERS | 7 +- Makefile | 2 +- arch/arc/include/asm/irqflags.h | 12 +- arch/arm/boot/dts/imx28-m28evk.dts | 1 - arch/arm/boot/dts/imx28-sps1.dts | 1 - arch/arm/boot/dts/imx6qdl.dtsi | 1 + arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts | 14 +- arch/arm/mach-imx/clk-imx35.c | 2 + arch/arm/mach-imx/clk-imx6q.c | 3 +- arch/arm/mach-kirkwood/board-iomega_ix2_200.c | 7 +- arch/arm/mach-mvebu/irq-armada-370-xp.c | 16 +- arch/arm/mach-s3c24xx/include/mach/irqs.h | 4 +- arch/arm/mach-s3c24xx/irq.c | 2 +- arch/c6x/include/asm/irqflags.h | 2 +- arch/ia64/kernel/palinfo.c | 77 +---- arch/m68k/include/asm/gpio.h | 20 ++ arch/powerpc/platforms/pseries/lpar.c | 8 +- arch/tile/include/asm/irqflags.h | 10 +- arch/x86/include/asm/paravirt.h | 5 +- arch/x86/include/asm/paravirt_types.h | 2 + arch/x86/include/asm/tlb.h | 2 +- arch/x86/kernel/cpu/perf_event_intel_ds.c | 3 +- arch/x86/kernel/paravirt.c | 25 +- arch/x86/lguest/boot.c | 1 + arch/x86/mm/fault.c | 6 +- arch/x86/mm/pageattr-test.c | 2 +- arch/x86/mm/pageattr.c | 12 +- arch/x86/mm/pgtable.c | 7 + arch/x86/xen/mmu.c | 13 +- block/blk-sysfs.c | 2 + block/partition-generic.c | 1 - crypto/gcm.c | 17 +- drivers/ata/ata_piix.c | 14 +- drivers/ata/libata-core.c | 6 +- drivers/ata/libata-scsi.c | 8 +- drivers/base/regmap/regmap.c | 3 +- drivers/block/loop.c | 21 +- drivers/block/mtip32xx/mtip32xx.c | 327 ++++++++++++++------ drivers/block/mtip32xx/mtip32xx.h | 18 +- drivers/cpufreq/intel_pstate.c | 1 - drivers/crypto/ux500/cryp/cryp_core.c | 2 +- drivers/dma/omap-dma.c | 20 +- drivers/dma/pl330.c | 38 ++- drivers/gpio/gpio-pca953x.c | 2 +- drivers/gpu/drm/drm_fb_helper.c | 8 +- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +- drivers/gpu/drm/nouveau/nv50_display.c | 2 +- drivers/gpu/drm/udl/udl_connector.c | 4 + drivers/hwspinlock/hwspinlock_core.c | 2 + drivers/misc/vmw_vmci/Kconfig | 2 +- drivers/net/bonding/bond_main.c | 11 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 18 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +- drivers/net/ethernet/intel/e100.c | 36 ++- drivers/net/ethernet/marvell/mvneta.c | 9 +- drivers/net/hyperv/netvsc.c | 17 +- drivers/net/hyperv/netvsc_drv.c | 2 - drivers/net/hyperv/rndis_filter.c | 14 +- drivers/net/wireless/ath/ath9k/main.c | 4 + drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 6 +- .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 46 +-- drivers/net/wireless/mwifiex/scan.c | 11 +- drivers/net/wireless/rt2x00/Kconfig | 7 + drivers/net/wireless/rt2x00/Makefile | 1 + drivers/net/wireless/rt2x00/rt2400pci.c | 1 + drivers/net/wireless/rt2x00/rt2500pci.c | 1 + drivers/net/wireless/rt2x00/rt2800pci.c | 1 + drivers/net/wireless/rt2x00/rt2x00mmio.c | 216 +++++++++++++ drivers/net/wireless/rt2x00/rt2x00mmio.h | 119 +++++++ drivers/net/wireless/rt2x00/rt2x00pci.c | 176 ----------- drivers/net/wireless/rt2x00/rt2x00pci.h | 88 ------ drivers/net/wireless/rt2x00/rt61pci.c | 1 + drivers/remoteproc/Kconfig | 2 +- drivers/remoteproc/remoteproc_core.c | 6 +- drivers/remoteproc/ste_modem_rproc.c | 7 +- drivers/s390/net/qeth_core.h | 3 + drivers/s390/net/qeth_core_main.c | 19 ++ drivers/s390/net/qeth_l2_main.c | 2 + drivers/s390/net/qeth_l3_main.c | 2 + drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +- drivers/scsi/ipr.c | 13 +- drivers/scsi/libsas/sas_expander.c | 14 +- drivers/scsi/lpfc/lpfc_sli.c | 3 +- drivers/scsi/qla2xxx/qla_attr.c | 5 - drivers/scsi/qla2xxx/qla_dbg.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 3 - drivers/scsi/qla2xxx/qla_init.c | 4 +- drivers/scsi/qla2xxx/qla_mbx.c | 58 ---- drivers/scsi/qla2xxx/qla_version.h | 2 +- drivers/scsi/st.c | 8 +- drivers/target/target_core_alua.c | 3 + drivers/tty/mxser.c | 8 +- drivers/tty/serial/8250/8250_pnp.c | 12 +- drivers/tty/serial/omap-serial.c | 11 + drivers/vfio/pci/vfio_pci.c | 3 +- drivers/vhost/tcm_vhost.c | 198 ++++++++---- drivers/watchdog/Kconfig | 2 +- drivers/xen/events.c | 19 +- fs/btrfs/tree-log.c | 48 ++- fs/cifs/connect.c | 16 +- fs/ecryptfs/miscdev.c | 14 +- fs/inode.c | 2 +- fs/namespace.c | 2 +- fs/nfs/nfs4client.c | 45 ++- fs/nfs/nfs4proc.c | 1 + fs/nfs/nfs4state.c | 8 +- fs/proc/generic.c | 119 +++++-- include/asm-generic/tlb.h | 7 +- include/linux/ata.h | 2 +- include/linux/capability.h | 2 + include/linux/ftrace.h | 5 +- include/linux/libata.h | 1 + include/linux/preempt.h | 22 +- include/linux/proc_fs.h | 2 + include/linux/security.h | 12 + include/linux/spinlock_up.h | 29 +- include/net/iucv/af_iucv.h | 8 + include/sound/dmaengine_pcm.h | 92 +++++- include/sound/soc-dapm.h | 1 - include/sound/soc.h | 13 +- kernel/capability.c | 24 ++ kernel/events/core.c | 4 +- kernel/events/internal.h | 2 +- kernel/events/ring_buffer.c | 22 +- kernel/sched/clock.c | 26 ++ kernel/sched/core.c | 8 +- kernel/sched/cputime.c | 2 +- kernel/sys.c | 3 +- kernel/trace/ftrace.c | 54 ++-- kernel/trace/trace.c | 9 +- kernel/trace/trace_stack.c | 2 +- lib/kobject.c | 9 +- mm/memory.c | 1 + net/atm/common.c | 2 + net/ax25/af_ax25.c | 1 + net/bluetooth/af_bluetooth.c | 4 +- net/bluetooth/rfcomm/sock.c | 1 + net/bluetooth/sco.c | 1 + net/caif/caif_socket.c | 2 + net/can/gw.c | 6 +- net/core/rtnetlink.c | 4 +- net/ipv4/devinet.c | 60 +++- net/ipv4/tcp_output.c | 1 + net/ipv6/tcp_ipv6.c | 1 + net/irda/af_irda.c | 2 + net/iucv/af_iucv.c | 36 +-- net/l2tp/l2tp_ip6.c | 1 + net/llc/af_llc.c | 2 + net/netrom/af_netrom.c | 1 + net/nfc/llcp/sock.c | 3 + net/rose/af_rose.c | 1 + net/sunrpc/clnt.c | 11 +- net/tipc/socket.c | 7 + net/vmw_vsock/af_vsock.c | 2 + net/vmw_vsock/vmci_transport.c | 3 +- net/wireless/sme.c | 2 + security/capability.c | 6 + security/security.c | 5 + security/selinux/hooks.c | 7 + sound/soc/Kconfig | 4 + sound/soc/Makefile | 4 + sound/soc/atmel/atmel-pcm-dma.c | 29 +- sound/soc/cirrus/edb93xx.c | 1 - sound/soc/cirrus/ep93xx-ac97.c | 9 +- sound/soc/cirrus/ep93xx-i2s.c | 16 +- sound/soc/cirrus/ep93xx-pcm.c | 38 +-- sound/soc/cirrus/ep93xx-pcm.h | 20 -- sound/soc/cirrus/simone.c | 2 - sound/soc/cirrus/snappercl15.c | 1 - sound/soc/codecs/Kconfig | 2 +- sound/soc/codecs/cs4271.c | 166 +++++----- sound/soc/codecs/max98088.c | 32 +- sound/soc/codecs/wm5102.c | 2 +- sound/soc/codecs/wm8903.c | 2 + sound/soc/fsl/Kconfig | 2 +- sound/soc/fsl/fsl_ssi.c | 55 ++-- sound/soc/fsl/fsl_ssi.h | 8 + sound/soc/fsl/imx-audmux.c | 3 +- sound/soc/fsl/imx-pcm-dma.c | 120 +------ sound/soc/fsl/imx-pcm-fiq.c | 6 +- sound/soc/fsl/imx-pcm.c | 6 +- sound/soc/fsl/imx-pcm.h | 24 +- sound/soc/fsl/imx-sgtl5000.c | 2 +- sound/soc/fsl/imx-ssi.c | 51 ++- sound/soc/fsl/imx-ssi.h | 7 +- sound/soc/mxs/mxs-pcm.c | 43 +-- sound/soc/mxs/mxs-pcm.h | 4 +- sound/soc/mxs/mxs-saif.c | 6 +- sound/soc/omap/am3517evm.c | 1 - sound/soc/omap/ams-delta.c | 1 - sound/soc/omap/mcbsp.c | 14 +- sound/soc/omap/mcbsp.h | 7 +- sound/soc/omap/n810.c | 1 - sound/soc/omap/omap-abe-twl6040.c | 1 - sound/soc/omap/omap-dmic.c | 38 +-- sound/soc/omap/omap-hdmi.c | 24 +- sound/soc/omap/omap-mcbsp.c | 18 +- sound/soc/omap/omap-mcpdm.c | 109 ++++--- sound/soc/omap/omap-pcm.c | 86 +---- sound/soc/omap/omap-pcm.h | 40 --- sound/soc/omap/omap-twl4030.c | 1 - sound/soc/omap/omap3pandora.c | 9 +- sound/soc/omap/osk5912.c | 1 - sound/soc/omap/rx51.c | 1 - sound/soc/pxa/mmp-pcm.c | 34 +- sound/soc/samsung/i2s.c | 17 +- sound/soc/soc-compress.c | 14 +- sound/soc/soc-core.c | 116 ++++--- sound/soc/soc-dapm.c | 1 - sound/soc/soc-dmaengine-pcm.c | 150 +++++---- sound/soc/soc-generic-dmaengine-pcm.c | 284 +++++++++++++++++ sound/soc/soc-io.c | 5 +- sound/soc/soc-utils.c | 25 ++ sound/soc/spear/spear_pcm.c | 19 +- sound/soc/tegra/Kconfig | 2 +- sound/soc/tegra/tegra20_ac97.c | 13 +- sound/soc/tegra/tegra20_ac97.h | 4 +- sound/soc/tegra/tegra20_i2s.c | 13 +- sound/soc/tegra/tegra20_i2s.h | 4 +- sound/soc/tegra/tegra20_spdif.c | 7 +- sound/soc/tegra/tegra20_spdif.h | 4 +- sound/soc/tegra/tegra30_ahub.c | 8 +- sound/soc/tegra/tegra30_ahub.h | 8 +- sound/soc/tegra/tegra30_i2s.c | 13 +- sound/soc/tegra/tegra30_i2s.h | 4 +- sound/soc/tegra/tegra_pcm.c | 209 +------------ sound/soc/tegra/tegra_pcm.h | 7 - sound/soc/ux500/Kconfig | 2 +- sound/soc/ux500/ux500_pcm.c | 229 ++------------ sound/soc/ux500/ux500_pcm.h | 14 - sound/usb/mixer_quirks.c | 4 +- sound/usb/quirks.c | 2 +- 235 files changed, 2790 insertions(+), 2211 deletions(-) create mode 100644 drivers/net/wireless/rt2x00/rt2x00mmio.c create mode 100644 drivers/net/wireless/rt2x00/rt2x00mmio.h delete mode 100644 sound/soc/cirrus/ep93xx-pcm.h delete mode 100644 sound/soc/omap/omap-pcm.h create mode 100644 sound/soc/soc-generic-dmaengine-pcm.c

3 4

[alsa-devel] [PATCH] sgtl5000.txt: Include supplies as required properties
by Fabio Estevam 18 Apr '13

18 Apr '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> sgtl5000 driver cannot probe succesfully if VDDA and VDDIO regulators are not provided. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- .../devicetree/bindings/sound/sgtl5000.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/sgtl5000.txt b/Documentation/devicetree/bindings/sound/sgtl5000.txt index 9cc4444..520eb98 100644 --- a/Documentation/devicetree/bindings/sound/sgtl5000.txt +++ b/Documentation/devicetree/bindings/sound/sgtl5000.txt @@ -5,9 +5,15 @@ Required properties: - reg : the I2C address of the device +- VDDA-supply: regulator that provides VDDA voltage + +- VDDIO-supply: regulator that provides VDDIO voltage + Example: codec: sgtl5000@0a { compatible = "fsl,sgtl5000"; reg = <0x0a>; + VDDA-supply = <&reg_2p5v>; + VDDIO-supply = <&reg_3p3v>; }; -- 1.7.9.5

2 1

[alsa-devel] [PATCH 1/2] alsa-lib: pcm.c: fix indentation
by Daniel Mack 18 Apr '13

18 Apr '13

Signed-off-by: Daniel Mack <zonque(a)gmail.com> --- src/pcm/pcm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index 05737d9..2963711 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -1634,11 +1634,11 @@ static const char *const snd_pcm_type_names[] = { PCMTYPE(LADSPA), PCMTYPE(DMIX), PCMTYPE(JACK), - PCMTYPE(DSNOOP), - PCMTYPE(IEC958), + PCMTYPE(DSNOOP), + PCMTYPE(IEC958), PCMTYPE(SOFTVOL), - PCMTYPE(IOPLUG), - PCMTYPE(EXTPLUG), + PCMTYPE(IOPLUG), + PCMTYPE(EXTPLUG), PCMTYPE(MMAP_EMUL), }; -- 1.8.1.4

2 2

[alsa-devel] [PATCH v3 0/5] ALSA: snd-usb: add support for DSD
by Daniel Mack 18 Apr '13

18 Apr '13

In contrast to the first two approaches, this one keeps the userspace unaware of the actual transport on the bus. More specifically, the DSD_U16_LE format may be implemented to actually send DOP samples to the device, depending on the quirks entries. Also, as there is quite some confusion in both data file formats as well as hardware sample formats about whether to stuff the oldest bit in the MSB or the LSB of a byte, ALSA defines that now to be in the MSB, as far as the ALSA userspace layer is concerned. The driver learned functions to re-encode the bytes according to what the hardware supports. I also wrote a very basic test tool which I published here: https://github.com/zonque/alsa-dsd-player Thanks, Daniel Daniel Mack (5): ALSA: add DSD formats ALSA: snd-usb: use ep->stride from urb callbacks ALSA: snd-usb: add support for DSD DOP stream transport ALSA: snd-usb: add support for bit-reversed byte formats ALSA: snd-usb: add quirks handler for DSD streams include/sound/pcm.h | 2 + include/uapi/sound/asound.h | 4 +- sound/core/pcm.c | 2 + sound/core/pcm_misc.c | 8 +++ sound/usb/card.h | 8 +++ sound/usb/endpoint.c | 9 ++++ sound/usb/format.c | 3 ++ sound/usb/pcm.c | 118 ++++++++++++++++++++++++++++++++++++------- sound/usb/quirks.c | 28 ++++++++++ sound/usb/quirks.h | 4 ++ 10 files changed, 167 insertions(+), 19 deletions(-) -- 1.7.10.4

3 12

Re: [alsa-devel] [PATCH -next] ALSA: hda - fix error return code in patch_alc662()
by Takashi Iwai 18 Apr '13

18 Apr '13

At Thu, 18 Apr 2013 11:12:59 +0800, Wei Yongjun wrote: > > From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> > > Fix to return a negative error code from the error handling > case instead of 0, as returned elsewhere in this function. > > Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> Thanks, applied. Takashi > --- > sound/pci/hda/patch_realtek.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index f15c36b..a3965b0 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) > if ((alc_get_coef0(codec) & (1 << 14)) && > codec->bus->pci->subsystem_vendor == 0x1025 && > spec->cdefine.platform_type == 1) { > - if (alc_codec_rename(codec, "ALC272X") < 0) > + err = alc_codec_rename(codec, "ALC272X"); > + if (err < 0) > goto error; > } > >

1 0

Re: [alsa-devel] [PATCH] ASoC: add RT5640 CODEC driver
by Mark Brown 17 Apr '13

17 Apr '13

On Tue, Apr 16, 2013 at 04:29:40PM -0600, Stephen Warren wrote: > a) There are many different VDD inputs to the chip. I imagine that some > of these only need to be enabled/active under certain conditions. For > example, perhaps the SPKVDD or MICVDD inputs are only required if > actively using the speakers or microphones, and could be disabled at > other times? If so, all of these "optional" or "part-time" VDD inputs > should be represented as regulators, and retrieved/manipulated using > Linux APIs such as regulator_get(), regulator_enable(), etc. There's framework support for regulator supplies in ASoC so you just need to specify the name and the core will do the rest. > b) Some VDD inputs are optional; for example, either I believe that a > board should either provide DCVDD, or provide LDO1_IN and assert the > LDO1_EN input signal. Similarly, I think that either MICVDD should be > provided, or SPKVDDL be provided, coupled with LDO2_EN register bit > being set. This may require the RT5640 driver to provide two regulator > objects (LDO1, LDO2), which the board file or device tree can connect > back to the DCVDD and MICVDD inputs if appropriate for the board's HW > configuration. In the case where LDO1 is used, a separate fixed > regulator with GPIO should be used to control the LDO1_EN GPIO input. That said if boards generally don't use external supplies and use the built in regulators then it's probably best to at least have the driver assume that by default. > > Bard: You are right. The mic type should be defined according to circuit. > > And it should be change in run time. > > So, should we just remove this control in codec driver? > Mark's point is that the driver should either/both accept some platform > data structure, or parse device tree, to configure the input pins. I > don't think completely removing all mechanisms to configure this would > be a good idea, since then how would the board/device-tree author > configure the CODEC? Indeed, there definitely should be configuration - however what I was commenting on there was a user-visible ALSA control which should definitely go.

3 6

Re: [alsa-devel] [PATCH 26/28] proc: Supply a function to remove a proc entry by PDE [RFC]
by Grant Likely 17 Apr '13

17 Apr '13

On Tue, 16 Apr 2013 19:27:34 +0100, David Howells <dhowells(a)redhat.com> wrote: > Supply a function (proc_remove()) to remove a proc entry (and any subtree > rooted there) by proc_dir_entry pointer rather than by name and (optionally) > root dir entry pointer. This allows us to eliminate all remaining pde->name > accesses outside of procfs. > > Signed-off-by: David Howells <dhowells(a)redhat.com> > cc: linux-acpi(a)vger.kernel.org > cc: openipmi-developer(a)lists.sourceforge.net > cc: devicetree-discuss(a)lists.ozlabs.org > cc: linux-pci(a)vger.kernel.org > cc: netdev(a)vger.kernel.org > cc: netfilter-devel(a)vger.kernel.org > cc: alsa-devel(a)alsa-project.org Looks okay to me. For the OF portion: Acked-by: Grant Likely <grant.likely(a)linaro.or> > --- > > drivers/acpi/sbs.c | 21 ++++----------------- > drivers/char/ipmi/ipmi_msghandler.c | 2 +- > drivers/misc/sgi-gru/gruprocfs.c | 2 +- > drivers/of/base.c | 11 +---------- > drivers/pci/proc.c | 12 +++--------- > fs/proc/generic.c | 7 +++++++ > fs/proc/vmcore.c | 2 +- > include/linux/proc_fs.h | 2 ++ > kernel/irq/proc.c | 6 +----- > net/8021q/vlanproc.c | 9 ++------- > net/core/pktgen.c | 6 ++---- > net/ipv4/netfilter/ipt_CLUSTERIP.c | 4 ++-- > net/ipv6/proc.c | 3 +-- > net/netfilter/xt_hashlimit.c | 4 ++-- > sound/core/info.c | 19 +++++-------------- > 15 files changed, 35 insertions(+), 75 deletions(-) > > diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c > index a296e08..b6241ee 100644 > --- a/drivers/acpi/sbs.c > +++ b/drivers/acpi/sbs.c > @@ -521,19 +521,6 @@ acpi_sbs_add_fs(struct proc_dir_entry **dir, > return 0; > } > > -static void > -acpi_sbs_remove_fs(struct proc_dir_entry **dir, > - struct proc_dir_entry *parent_dir) > -{ > - if (*dir) { > - remove_proc_entry(ACPI_SBS_FILE_INFO, *dir); > - remove_proc_entry(ACPI_SBS_FILE_STATE, *dir); > - remove_proc_entry(ACPI_SBS_FILE_ALARM, *dir); > - remove_proc_entry((*dir)->name, parent_dir); > - *dir = NULL; > - } > -} > - > /* Smart Battery Interface */ > static struct proc_dir_entry *acpi_battery_dir = NULL; > > @@ -836,8 +823,8 @@ static void acpi_battery_remove(struct acpi_sbs *sbs, int id) > power_supply_unregister(&battery->bat); > } > #ifdef CONFIG_ACPI_PROCFS_POWER > - if (battery->proc_entry) > - acpi_sbs_remove_fs(&battery->proc_entry, acpi_battery_dir); > + proc_remove(battery->proc_entry); > + battery->proc_entry = NULL; > #endif > } > > @@ -873,8 +860,8 @@ static void acpi_charger_remove(struct acpi_sbs *sbs) > if (sbs->charger.dev) > power_supply_unregister(&sbs->charger); > #ifdef CONFIG_ACPI_PROCFS_POWER > - if (sbs->charger_entry) > - acpi_sbs_remove_fs(&sbs->charger_entry, acpi_ac_dir); > + proc_remove(sbs->charger_entry); > + sbs->charger_entry = NULL; > #endif > } > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 1420bbb..4d439d2 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -4541,7 +4541,7 @@ static void __exit cleanup_ipmi(void) > del_timer_sync(&ipmi_timer); > > #ifdef CONFIG_PROC_FS > - remove_proc_entry(proc_ipmi_root->name, NULL); > + proc_remove(proc_ipmi_root); > #endif /* CONFIG_PROC_FS */ > > driver_unregister(&ipmidriver.driver); > diff --git a/drivers/misc/sgi-gru/gruprocfs.c b/drivers/misc/sgi-gru/gruprocfs.c > index 950dbe9..797d796 100644 > --- a/drivers/misc/sgi-gru/gruprocfs.c > +++ b/drivers/misc/sgi-gru/gruprocfs.c > @@ -355,7 +355,7 @@ static void delete_proc_files(void) > for (p = proc_files; p->name; p++) > if (p->entry) > remove_proc_entry(p->name, proc_gru); > - remove_proc_entry("gru", proc_gru->parent); > + proc_remove(proc_gru); > } > } > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 321d3ef..9c70436 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -1452,16 +1452,7 @@ int of_attach_node(struct device_node *np) > #ifdef CONFIG_PROC_DEVICETREE > static void of_remove_proc_dt_entry(struct device_node *dn) > { > - struct device_node *parent = dn->parent; > - struct property *prop = dn->properties; > - > - while (prop) { > - remove_proc_entry(prop->name, dn->pde); > - prop = prop->next; > - } > - > - if (dn->pde) > - remove_proc_entry(dn->pde->name, parent->pde); > + proc_remove(dn->pde); > } > #else > static void of_remove_proc_dt_entry(struct device_node *dn) > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 7cde7c1..0812608 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -427,20 +427,14 @@ int pci_proc_attach_device(struct pci_dev *dev) > > int pci_proc_detach_device(struct pci_dev *dev) > { > - struct proc_dir_entry *e; > - > - if ((e = dev->procent)) { > - remove_proc_entry(e->name, dev->bus->procdir); > - dev->procent = NULL; > - } > + proc_remove(dev->procent); > + dev->procent = NULL; > return 0; > } > > int pci_proc_detach_bus(struct pci_bus* bus) > { > - struct proc_dir_entry *de = bus->procdir; > - if (de) > - remove_proc_entry(de->name, proc_bus_pci_dir); > + proc_remove(bus->procdir); > return 0; > } > > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > index 2c6d6be..4b48033 100644 > --- a/fs/proc/generic.c > +++ b/fs/proc/generic.c > @@ -630,3 +630,10 @@ const char *get_proc_name(const struct proc_dir_entry *de) > return de->name; > } > EXPORT_SYMBOL_GPL(get_proc_name); > + > +void proc_remove(struct proc_dir_entry *de) > +{ > + if (de) > + remove_proc_subtree(de->name, de->parent); > +} > +EXPORT_SYMBOL(proc_remove); > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 38edddc..17f7e08 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -699,7 +699,7 @@ void vmcore_cleanup(void) > struct list_head *pos, *next; > > if (proc_vmcore) { > - remove_proc_entry(proc_vmcore->name, proc_vmcore->parent); > + proc_remove(proc_vmcore); > proc_vmcore = NULL; > } > > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 7abc72a..b8949b1 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -67,6 +67,7 @@ struct proc_dir_entry *proc_create_data(const char *name, umode_t mode, > struct proc_dir_entry *parent, > const struct file_operations *proc_fops, > void *data); > +extern void proc_remove(struct proc_dir_entry *); > extern void remove_proc_entry(const char *name, struct proc_dir_entry *parent); > extern int remove_proc_subtree(const char *name, struct proc_dir_entry *parent); > > @@ -103,6 +104,7 @@ static inline struct proc_dir_entry *proc_create_data(const char *name, > { > return NULL; > } > +static inline void proc_remove(struct proc_dir_entry *de) {} > #define remove_proc_entry(name, parent) do {} while (0) > #define remove_proc_subtree(name, parent) do {} while (0) > > diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c > index d59ae37..19ed5c4 100644 > --- a/kernel/irq/proc.c > +++ b/kernel/irq/proc.c > @@ -366,11 +366,7 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc) > > void unregister_handler_proc(unsigned int irq, struct irqaction *action) > { > - if (action->dir) { > - struct irq_desc *desc = irq_to_desc(irq); > - > - remove_proc_entry(action->dir->name, desc->dir); > - } > + proc_remove(action->dir); > } > > static void register_default_affinity_proc(void) > diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c > index 959ddbb..1d0e8921 100644 > --- a/net/8021q/vlanproc.c > +++ b/net/8021q/vlanproc.c > @@ -184,14 +184,9 @@ int vlan_proc_add_dev(struct net_device *vlandev) > */ > int vlan_proc_rem_dev(struct net_device *vlandev) > { > - struct vlan_net *vn = net_generic(dev_net(vlandev), vlan_net_id); > - > /** NOTE: This will consume the memory pointed to by dent, it seems. */ > - if (vlan_dev_priv(vlandev)->dent) { > - remove_proc_entry(vlan_dev_priv(vlandev)->dent->name, > - vn->proc_vlan_dir); > - vlan_dev_priv(vlandev)->dent = NULL; > - } > + proc_remove(vlan_dev_priv(vlandev)->dent); > + vlan_dev_priv(vlandev)->dent = NULL; > return 0; > } > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index f6af4fe..6c41e97 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -1904,7 +1904,7 @@ static void pktgen_change_name(const struct pktgen_net *pn, struct net_device *d > if (pkt_dev->odev != dev) > continue; > > - remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); > + proc_remove(pkt_dev->entry); > > pkt_dev->entry = proc_create_data(dev->name, 0600, > pn->proc_dir, > @@ -3576,8 +3576,6 @@ static void _rem_dev_from_if_list(struct pktgen_thread *t, > static int pktgen_remove_device(struct pktgen_thread *t, > struct pktgen_dev *pkt_dev) > { > - struct pktgen_net *pn = t->net; > - > pr_debug("remove_device pkt_dev=%p\n", pkt_dev); > > if (pkt_dev->running) { > @@ -3597,7 +3595,7 @@ static int pktgen_remove_device(struct pktgen_thread *t, > _rem_dev_from_if_list(t, pkt_dev); > > if (pkt_dev->entry) > - remove_proc_entry(pkt_dev->entry->name, pn->proc_dir); > + proc_remove(pkt_dev->entry); > > #ifdef CONFIG_XFRM > free_SAs(pkt_dev); > diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c > index e4738fe..0b732ef 100644 > --- a/net/ipv4/netfilter/ipt_CLUSTERIP.c > +++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c > @@ -105,7 +105,7 @@ clusterip_config_entry_put(struct clusterip_config *c) > * functions are also incrementing the refcount on their own, > * so it's safe to remove the entry even if it's in use. */ > #ifdef CONFIG_PROC_FS > - remove_proc_entry(c->pde->name, c->pde->parent); > + proc_remove(c->pde); > #endif > return; > } > @@ -736,7 +736,7 @@ static void __exit clusterip_tg_exit(void) > { > pr_info("ClusterIP Version %s unloading\n", CLUSTERIP_VERSION); > #ifdef CONFIG_PROC_FS > - remove_proc_entry(clusterip_procdir->name, clusterip_procdir->parent); > + proc_remove(clusterip_procdir); > #endif > nf_unregister_hook(&cip_arp_ops); > xt_unregister_target(&clusterip_tg_reg); > diff --git a/net/ipv6/proc.c b/net/ipv6/proc.c > index 7ea6e18..537d9ee 100644 > --- a/net/ipv6/proc.c > +++ b/net/ipv6/proc.c > @@ -287,8 +287,7 @@ int snmp6_unregister_dev(struct inet6_dev *idev) > return -ENOENT; > if (!idev->stats.proc_dir_entry) > return -EINVAL; > - remove_proc_entry(idev->stats.proc_dir_entry->name, > - net->mib.proc_net_devsnmp6); > + proc_remove(idev->stats.proc_dir_entry); > idev->stats.proc_dir_entry = NULL; > return 0; > } > diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c > index d2fd53b..40002ef 100644 > --- a/net/netfilter/xt_hashlimit.c > +++ b/net/netfilter/xt_hashlimit.c > @@ -330,7 +330,7 @@ static void htable_destroy(struct xt_hashlimit_htable *hinfo) > parent = hashlimit_net->ip6t_hashlimit; > > if(parent != NULL) > - remove_proc_entry(hinfo->pde->name, parent); > + proc_remove(hinfo->pde); > > htable_selective_cleanup(hinfo, select_all); > vfree(hinfo); > @@ -887,7 +887,7 @@ static void __net_exit hashlimit_proc_net_exit(struct net *net) > pde = hashlimit_net->ip6t_hashlimit; > > hlist_for_each_entry(hinfo, &hashlimit_net->htables, node) > - remove_proc_entry(hinfo->pde->name, pde); > + proc_remove(hinfo->pde); > > hashlimit_net->ipt_hashlimit = NULL; > hashlimit_net->ip6t_hashlimit = NULL; > diff --git a/sound/core/info.c b/sound/core/info.c > index c7f41c3..3c9bd6b 100644 > --- a/sound/core/info.c > +++ b/sound/core/info.c > @@ -153,13 +153,6 @@ EXPORT_SYMBOL(snd_seq_root); > struct snd_info_entry *snd_oss_root; > #endif > > -static void snd_remove_proc_entry(struct proc_dir_entry *parent, > - struct proc_dir_entry *de) > -{ > - if (de) > - remove_proc_entry(de->name, parent); > -} > - > static loff_t snd_info_entry_llseek(struct file *file, loff_t offset, int orig) > { > struct snd_info_private_data *data; > @@ -580,7 +573,7 @@ int __exit snd_info_done(void) > #ifdef CONFIG_SND_OSSEMUL > snd_info_free_entry(snd_oss_root); > #endif > - snd_remove_proc_entry(NULL, snd_proc_root); > + proc_remove(snd_proc_root); > } > return 0; > } > @@ -642,7 +635,7 @@ void snd_info_card_id_change(struct snd_card *card) > { > mutex_lock(&info_mutex); > if (card->proc_root_link) { > - snd_remove_proc_entry(snd_proc_root, card->proc_root_link); > + proc_remove(card->proc_root_link); > card->proc_root_link = NULL; > } > if (strcmp(card->id, card->proc_root->name)) > @@ -661,10 +654,8 @@ void snd_info_card_disconnect(struct snd_card *card) > if (!card) > return; > mutex_lock(&info_mutex); > - if (card->proc_root_link) { > - snd_remove_proc_entry(snd_proc_root, card->proc_root_link); > - card->proc_root_link = NULL; > - } > + proc_remove(card->proc_root_link); > + card->proc_root_link = NULL; > if (card->proc_root) > snd_info_disconnect(card->proc_root); > mutex_unlock(&info_mutex); > @@ -856,7 +847,7 @@ static void snd_info_disconnect(struct snd_info_entry *entry) > list_del_init(&entry->list); > root = entry->parent == NULL ? snd_proc_root : entry->parent->p; > snd_BUG_ON(!root); > - snd_remove_proc_entry(root, entry->p); > + proc_remove(entry->p); > entry->p = NULL; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.

1 0

[alsa-devel] [PATCH v2] ASoC: wm_adsp: Expose coefficient blocks as ALSA binary controls
by Dimitris Papastamos 17 Apr '13

17 Apr '13

Add initial support for runtime tuning for the ADSP cores. This is achieved by exposing the coefficient configuration blocks as ALSA binary controls. The current code assumes that no controls on the DSP are volatile. Signed-off-by: Dimitris Papastamos <dp(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm_adsp.c | 435 ++++++++++++++++++++++++++++++++++++++++++++- sound/soc/codecs/wm_adsp.h | 3 + 2 files changed, 431 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 3470b64..080d05f 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -215,6 +215,36 @@ static struct { [WM_ADSP_FW_RX_ANC] = { .file = "rx-anc" }, }; +struct wm_coeff_ctl_ops { + int (*xget)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol); + int (*xput)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol); + int (*xinfo)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo); +}; + +struct wm_coeff { + struct device *dev; + struct list_head ctl_list; + struct regmap *regmap; +}; + +struct wm_coeff_ctl { + const char *name; + struct snd_card *card; + struct wm_adsp_alg_region region; + struct wm_coeff_ctl_ops ops; + struct wm_adsp *adsp; + void *private; + unsigned int enabled:1; + struct list_head list; + void *cache; + size_t len; + unsigned int dirty:1; + struct snd_kcontrol *kcontrol; +}; + static int wm_adsp_fw_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -334,6 +364,175 @@ static unsigned int wm_adsp_region_to_reg(struct wm_adsp_region const *region, } } +static int wm_coeff_info(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + + uinfo->type = SNDRV_CTL_ELEM_TYPE_BYTES; + uinfo->count = ctl->len; + return 0; +} + +static int wm_coeff_write_control(struct snd_kcontrol *kcontrol, + const void *buf, size_t len) +{ + struct wm_coeff *wm_coeff= snd_kcontrol_chip(kcontrol); + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + struct wm_adsp_alg_region *region = &ctl->region; + const struct wm_adsp_region *mem; + struct wm_adsp *adsp = ctl->adsp; + void *scratch; + int ret; + unsigned int reg; + + mem = wm_adsp_find_region(adsp, region->type); + if (!mem) { + adsp_err(adsp, "No base for region %x\n", + region->type); + return -EINVAL; + } + + reg = ctl->region.base; + reg = wm_adsp_region_to_reg(mem, reg); + + scratch = kmemdup(buf, ctl->len, GFP_KERNEL | GFP_DMA); + if (!scratch) + return -ENOMEM; + + ret = regmap_raw_write(wm_coeff->regmap, reg, scratch, + ctl->len); + if (ret) { + adsp_err(adsp, "Failed to write %zu bytes to %x\n", + ctl->len, reg); + kfree(scratch); + return ret; + } + + kfree(scratch); + + return 0; +} + +static int wm_coeff_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + char *p = ucontrol->value.bytes.data; + + memcpy(ctl->cache, p, ctl->len); + + if (!ctl->enabled) { + ctl->dirty = 1; + return 0; + } + + return wm_coeff_write_control(kcontrol, p, ctl->len); +} + +static int wm_coeff_read_control(struct snd_kcontrol *kcontrol, + void *buf, size_t len) +{ + struct wm_coeff *wm_coeff= snd_kcontrol_chip(kcontrol); + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + struct wm_adsp_alg_region *region = &ctl->region; + const struct wm_adsp_region *mem; + struct wm_adsp *adsp = ctl->adsp; + void *scratch; + int ret; + unsigned int reg; + + mem = wm_adsp_find_region(adsp, region->type); + if (!mem) { + adsp_err(adsp, "No base for region %x\n", + region->type); + return -EINVAL; + } + + reg = ctl->region.base; + reg = wm_adsp_region_to_reg(mem, reg); + + scratch = kmalloc(ctl->len, GFP_KERNEL | GFP_DMA); + if (!scratch) + return -ENOMEM; + + ret = regmap_raw_read(wm_coeff->regmap, reg, scratch, ctl->len); + if (ret) { + adsp_err(adsp, "Failed to read %zu bytes from %x\n", + ctl->len, reg); + kfree(scratch); + return ret; + } + + memcpy(buf, scratch, ctl->len); + kfree(scratch); + + return 0; +} + +static int wm_coeff_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + char *p = ucontrol->value.bytes.data; + + memcpy(p, ctl->cache, ctl->len); + return 0; +} + +static int wm_coeff_add_kcontrol(struct wm_coeff *wm_coeff, + struct wm_coeff_ctl *ctl, + const struct snd_kcontrol_new *kctl) +{ + int ret; + struct snd_kcontrol *kcontrol; + + kcontrol = snd_ctl_new1(kctl, wm_coeff); + ret = snd_ctl_add(ctl->card, kcontrol); + if (ret < 0) { + dev_err(wm_coeff->dev, "Failed to add %s: %d\n", + kctl->name, ret); + return ret; + } + ctl->kcontrol = kcontrol; + return 0; +} + +static int wmfw_add_ctl(struct wm_coeff *wm_coeff, + struct wm_coeff_ctl *ctl) +{ + struct snd_kcontrol_new *kcontrol; + int ret; + + if (!wm_coeff || !ctl || !ctl->name || !ctl->card) + return -EINVAL; + + kcontrol = kzalloc(sizeof(*kcontrol), GFP_KERNEL); + if (!kcontrol) + return -ENOMEM; + kcontrol->iface = SNDRV_CTL_ELEM_IFACE_MIXER; + + kcontrol->name = ctl->name; + kcontrol->info = wm_coeff_info; + kcontrol->get = wm_coeff_get; + kcontrol->put = wm_coeff_put; + kcontrol->private_value = (unsigned long)ctl; + + ret = wm_coeff_add_kcontrol(wm_coeff, + ctl, kcontrol); + if (ret < 0) + goto err_kcontrol; + + kfree(kcontrol); + + list_add(&ctl->list, &wm_coeff->ctl_list); + return 0; + +err_kcontrol: + kfree(kcontrol); + return ret; +} + static int wm_adsp_load(struct wm_adsp *dsp) { LIST_HEAD(buf_list); @@ -547,7 +746,140 @@ out: return ret; } -static int wm_adsp_setup_algs(struct wm_adsp *dsp) +static int wm_coeff_init_control_caches(struct wm_coeff *wm_coeff) +{ + struct wm_coeff_ctl *ctl; + int ret; + + list_for_each_entry(ctl, &wm_coeff->ctl_list, + list) { + if (!ctl->enabled || ctl->dirty) + continue; + ret = wm_coeff_read_control(ctl->kcontrol, + ctl->cache, + ctl->len); + if (ret < 0) + return ret; + } + + return 0; +} + +static int wm_coeff_sync_controls(struct wm_coeff *wm_coeff) +{ + struct wm_coeff_ctl *ctl; + int ret; + + list_for_each_entry(ctl, &wm_coeff->ctl_list, + list) { + if (!ctl->enabled) + continue; + if (ctl->dirty) { + ret = wm_coeff_write_control(ctl->kcontrol, + ctl->cache, + ctl->len); + if (ret < 0) + return ret; + ctl->dirty = 0; + } + } + + return 0; +} + +static int wm_adsp_create_control(struct snd_soc_codec *codec, + const struct wm_adsp_alg_region *region) + +{ + struct wm_adsp *dsp = snd_soc_codec_get_drvdata(codec); + struct wm_coeff_ctl *ctl; + char *name; + char *region_name; + int ret; + + name = kmalloc(PAGE_SIZE, GFP_KERNEL); + if (!name) + return -ENOMEM; + + switch (region->type) { + case WMFW_ADSP1_PM: + region_name = "PM"; + break; + case WMFW_ADSP1_DM: + region_name = "DM"; + break; + case WMFW_ADSP2_XM: + region_name = "XM"; + break; + case WMFW_ADSP2_YM: + region_name = "YM"; + break; + case WMFW_ADSP1_ZM: + region_name = "ZM"; + break; + default: + return -EINVAL; + } + + snprintf(name, PAGE_SIZE, "DSP%d %s %x", + dsp->num, region_name, region->alg); + + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + if (!strcmp(ctl->name, name)) { + if (!ctl->enabled) + ctl->enabled = 1; + return 0; + } + } + + ctl = kzalloc(sizeof(*ctl), GFP_KERNEL); + if (!ctl) { + ret = -ENOMEM; + goto err_name; + } + ctl->region = *region; + ctl->name = kmemdup(name, strlen(name) + 1, GFP_KERNEL); + if (!ctl->name) { + ret = -ENOMEM; + goto err_ctl; + } + ctl->enabled = 1; + ctl->dirty = 0; + ctl->ops.xget = wm_coeff_get; + ctl->ops.xput = wm_coeff_put; + ctl->card = codec->card->snd_card; + ctl->adsp = dsp; + + ctl->len = region->len; + ctl->cache = kzalloc(ctl->len, GFP_KERNEL); + if (!ctl->cache) { + ret = -ENOMEM; + goto err_ctl_name; + } + + ret = wmfw_add_ctl(dsp->wm_coeff, ctl); + if (ret < 0) { + ret = -ENOMEM; + goto err_ctl_cache; + } + + kfree(name); + + return 0; + +err_ctl_cache: + kfree(ctl->cache); +err_ctl_name: + kfree(ctl->name); +err_ctl: + kfree(ctl); +err_name: + kfree(name); + return ret; +} + +static int wm_adsp_setup_algs(struct wm_adsp *dsp, struct snd_soc_codec *codec) { struct regmap *regmap = dsp->regmap; struct wmfw_adsp1_id_hdr adsp1_id; @@ -730,7 +1062,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP1_DM; region->alg = be32_to_cpu(adsp1_alg[i].alg.id); region->base = be32_to_cpu(adsp1_alg[i].dm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp1_alg[i + 1].dm); + region->len -= be32_to_cpu(adsp1_alg[i].dm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region DM with ID %x\n", + be32_to_cpu(adsp1_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -738,7 +1079,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP1_ZM; region->alg = be32_to_cpu(adsp1_alg[i].alg.id); region->base = be32_to_cpu(adsp1_alg[i].zm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp1_alg[i + 1].zm); + region->len -= be32_to_cpu(adsp1_alg[i].zm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region ZM with ID %x\n", + be32_to_cpu(adsp1_alg[i].alg.id)); + } break; case WMFW_ADSP2: @@ -758,7 +1108,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_XM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].xm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].xm); + region->len -= be32_to_cpu(adsp2_alg[i].xm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region XM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -766,7 +1125,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_YM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].ym); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].ym); + region->len -= be32_to_cpu(adsp2_alg[i].ym); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region YM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -774,7 +1142,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_ZM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].zm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].zm); + region->len -= be32_to_cpu(adsp2_alg[i].zm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region ZM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } break; } } @@ -986,6 +1363,7 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, struct snd_soc_codec *codec = w->codec; struct wm_adsp *dsps = snd_soc_codec_get_drvdata(codec); struct wm_adsp *dsp = &dsps[w->shift]; + struct wm_coeff_ctl *ctl; int ret; int val; @@ -1023,7 +1401,7 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; - ret = wm_adsp_setup_algs(dsp); + ret = wm_adsp_setup_algs(dsp, codec); if (ret != 0) goto err; @@ -1031,6 +1409,16 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; + /* Initialize caches for enabled and non-dirty controls */ + ret = wm_coeff_init_control_caches(dsp->wm_coeff); + if (ret != 0) + goto err; + + /* Sync dirty controls */ + ret = wm_coeff_sync_controls(dsp->wm_coeff); + if (ret != 0) + goto err; + /* Start the core running */ regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30, ADSP1_CORE_ENA | ADSP1_START, @@ -1047,6 +1435,11 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30, ADSP1_SYS_ENA, 0); + + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + ctl->enabled = 0; + } break; default: @@ -1099,6 +1492,7 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, struct wm_adsp *dsps = snd_soc_codec_get_drvdata(codec); struct wm_adsp *dsp = &dsps[w->shift]; struct wm_adsp_alg_region *alg_region; + struct wm_coeff_ctl *ctl; unsigned int val; int ret; @@ -1164,7 +1558,7 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; - ret = wm_adsp_setup_algs(dsp); + ret = wm_adsp_setup_algs(dsp, codec); if (ret != 0) goto err; @@ -1172,6 +1566,16 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; + /* Initialize caches for enabled and non-dirty controls */ + ret = wm_coeff_init_control_caches(dsp->wm_coeff); + if (ret != 0) + goto err; + + /* Sync dirty controls */ + ret = wm_coeff_sync_controls(dsp->wm_coeff); + if (ret != 0) + goto err; + ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL, ADSP2_CORE_ENA | ADSP2_START, @@ -1209,6 +1613,11 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, ret); } + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + ctl->enabled = 0; + } + while (!list_empty(&dsp->alg_regions)) { alg_region = list_first_entry(&dsp->alg_regions, struct wm_adsp_alg_region, @@ -1247,36 +1656,48 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) INIT_LIST_HEAD(&adsp->alg_regions); + adsp->wm_coeff = kzalloc(sizeof(*adsp->wm_coeff), + GFP_KERNEL); + if (!adsp->wm_coeff) + return -ENOMEM; + adsp->wm_coeff->regmap = adsp->regmap; + adsp->wm_coeff->dev = adsp->dev; + INIT_LIST_HEAD(&adsp->wm_coeff->ctl_list); + if (dvfs) { adsp->dvfs = devm_regulator_get(adsp->dev, "DCVDD"); if (IS_ERR(adsp->dvfs)) { ret = PTR_ERR(adsp->dvfs); dev_err(adsp->dev, "Failed to get DCVDD: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_enable(adsp->dvfs); if (ret != 0) { dev_err(adsp->dev, "Failed to enable DCVDD: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_set_voltage(adsp->dvfs, 1200000, 1800000); if (ret != 0) { dev_err(adsp->dev, "Failed to initialise DVFS: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_disable(adsp->dvfs); if (ret != 0) { dev_err(adsp->dev, "Failed to disable DCVDD: %d\n", ret); - return ret; + goto out_coeff; } } return 0; + +out_coeff: + kfree(adsp->wm_coeff); + return ret; } EXPORT_SYMBOL_GPL(wm_adsp2_init); diff --git a/sound/soc/codecs/wm_adsp.h b/sound/soc/codecs/wm_adsp.h index fea5146..6e890b9 100644 --- a/sound/soc/codecs/wm_adsp.h +++ b/sound/soc/codecs/wm_adsp.h @@ -30,6 +30,7 @@ struct wm_adsp_alg_region { unsigned int alg; int type; unsigned int base; + size_t len; }; struct wm_adsp { @@ -55,6 +56,8 @@ struct wm_adsp { bool running; struct regulator *dvfs; + + struct wm_coeff *wm_coeff; }; #define WM_ADSP1(wname, num) \ -- 1.8.2.1

2 1

[alsa-devel] [PATCH 0/7] Add capture support to compress API
by Charles Keepax 17 Apr '13

17 Apr '13

This chain of patches does some clearing up and add capture support to the compressed API. Missing is support for capture streams that don't use the copy callback. Also I have included two patches at the end of the chain that remove the buffer pointers and just use the cumulative values however as our setup uses the copy callback these are untested past build so should be taken with caution. Thanks, Charles Charles Keepax (7): ALSA: compress_core: Update calc_avail to use cumulative values ALSA: compress_core: Calculate avail correctly for capture streams ALSA: compress_core: Deconstify copy callback buffer ALSA: compress_core: Add support for capture streams ASoC: soc-compress: Deduce stream direction ALSA: compress_core: Remove unused hw_pointer ALSA: compress_core: Rework writes to use cumulative values include/sound/compress_driver.h | 4 +- sound/core/compress_offload.c | 117 +++++++++++++++++++++++++------------- sound/soc/soc-compress.c | 11 +++- 3 files changed, 87 insertions(+), 45 deletions(-) -- 1.7.2.5

4 10

Re: [alsa-devel] [RFC] sound: ASoC: multiple DAIs/codecs on single audio stream
by Mark Brown 17 Apr '13

17 Apr '13

On Tue, Apr 16, 2013 at 07:45:08PM +0200, Sebastian Hesselbarth wrote: > The controller has a dma controller for one playback buffer. It can > play the stream to both I2S and SPDIF interfaces with independent mute. > Now, for example, I have a board with i2s codec and spdif tx diode > connected to the above controller: > DMA (platform) -+-> I2S (dai) ----> I2S_Codec (codec) > | > +-> SPDIF (dai) --> SPDIF_TX (codec) > Is there any way in the current ASoC API to have the above setup? As discussed on IRC this is probably best represented using soc-pcm at the minute.

1 0

[alsa-devel] [PATCH v3 00/15] ASoC: fsl-ssi: ac97-slave support
by Markus Pargmann 17 Apr '13

17 Apr '13

Hi, This series adds DT support for phycore-ac97. It is now based on the pcm dma cleanups from Lars. Beside ac97 support, the series adds fsl-ssi imx-pcm-fiq and generic DMA binding handling. @Lars: There are 4 new patches at the beginning of the series that fix some problems of your cleanups. I think they were in the changes you posted. If not, could you please add them to your branch? Regards, Markus Changes in v3: - Rebased onto pcm dma cleanup patches - A lot of cleanups for the fsl-ssi ac97 integration - Some small changes which are listed in the notes of the patches. Markus Pargmann (15): ASoC: imx-ssi: Fix includes ASoC: dmaengine-pcm: Replace of specific helper function ASoC: dmaengine-pcm: Fix function name ASoC: dmaengine-pcm: Fix pcm_request_chan function name ASoC: phycore-ac97: Add DT support ASoC: imx-pcm-dma: DT support ASoC: imx-pcm-fiq: Introduce pcm-fiq-params ASoC: fsl-ssi: Add SACNT definitions ASoC: fsl-ssi: Add support for imx-pcm-fiq ASoC: fsl-ssi: Use generic DMA bindings if possible ARM: imx: Export ac97 reset functions ASoC: fsl-ssi: imx ac97 support ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 ASoC: fsl: Move fsl-ssi binding doc to sound/ ASoC: fsl: Update fsl-ssi binding doc Documentation/devicetree/bindings/{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} | 7 + Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt | 12 ++ arch/arm/mach-imx/mach-pca100.c | 7 +- arch/arm/mach-imx/mach-pcm043.c | 7 +- include/sound/dmaengine_pcm.h | 2 +- sound/soc/fsl/Kconfig | 2 +- sound/soc/fsl/fsl_ssi.c | 484 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------- sound/soc/fsl/fsl_ssi.h | 8 ++ sound/soc/fsl/imx-pcm-dma.c | 4 +- sound/soc/fsl/imx-pcm-fiq.c | 16 ++- sound/soc/fsl/imx-pcm.h | 9 ++ sound/soc/fsl/imx-ssi.c | 7 +- sound/soc/fsl/imx-ssi.h | 2 + sound/soc/fsl/phycore-ac97.c | 184 +++++++++++++++++++++++---- sound/soc/soc-generic-dmaengine-pcm.c | 9 +- sound/soc/spear/spear_pcm.c | 2 +- 16 files changed, 634 insertions(+), 128 deletions(-) rename Documentation/devicetree/bindings/{powerpc/fsl/ssi.txt => sound/fsl,ssi.txt} (92%) create mode 100644 Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt

4 22

[alsa-devel] Fwd: Solved Hercules RMX2
by Daniel Schürmann 17 Apr '13

17 Apr '13

Hi Daniel, thank your advice! I am not a Hercules developer, I am developer of the Mixxx DJ Software and I am just trying to make the thing work! I have just read within the USB 2.0 speck to find out if there are specific timeouts to deal with. I have found: § 9.2.6.4 Standard Device Requests If I understand it correct, there is a 5-second limit for storing data into the device. I think changing the sample rate is such a operation. So what about changing the Limit to 5000 ms for all "Set requests" bmRequest = 21. See Audio20 § 5.2.2 All other timeouts might be reduced to 500 ms but I would leave them untouched at 1000 ms , just in case. I would prefer this general solution over a device specific one. What do you think? Kind regards, Daniel 2013/4/16 Daniel Mack <zonque(a)gmail.com> > On 16.04.2013 21:23, Daniel Mack wrote: > > On 16.04.2013 21:14, Daniel Schürmann wrote: > > >> Against which Kernel should I patch? > > > > > https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/log/?h=for-n… > > Eh, sorry. This one: > > https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/ for-next > >

2 1

[alsa-devel] [PATCH] ASoC: max98088: Fix logging of hardware revision.
by Dylan Reid 17 Apr '13

17 Apr '13

The hardware revision of the codec is based at 0x40. Subtract that before convering to ASCII. The same as it is done for 98095. Signed-off-by: Dylan Reid <dgreid(a)chromium.org> --- sound/soc/codecs/max98088.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 3a7b7fd..3eeada5 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -2024,7 +2024,7 @@ static int max98088_probe(struct snd_soc_codec *codec) ret); goto err_access; } - dev_info(codec->dev, "revision %c\n", ret + 'A'); + dev_info(codec->dev, "revision %c\n", ret - 0x40 + 'A'); snd_soc_write(codec, M98088_REG_51_PWR_SYS, M98088_PWRSV); -- 1.8.1.3.605.g02339dd

2 1

[alsa-devel] [PATCH] ASoC: define playback and capture streams in dummy codec
by Stas Sergeev 17 Apr '13

17 Apr '13

Hi. This patch adds a playback and capture streams to the dummy codec DAI configuration. Most permissive set of sampling rates and formats is used. Signed-off-by: Stas Sergeev <stsp(a)users.sourceforge.net>

5 12

Re: [alsa-devel] hda: sink info in case of AMD Radeon GPU card (no ELD?)
by Rafał Miłecki 17 Apr '13

17 Apr '13

2013/1/19 Rafał Miłecki <zajec5(a)gmail.com>: > Hello, > > I'm interested in polishing HDMI audio support for Radeon cards and I > hope to get some help here. One of the current problems is that hda > has no information about TV audio capabilities. It results in a well > known: > ALSA sound/pci/hda/hda_eld.c:337 HDMI: ELD buf size is 0, force 128 > ALSA sound/pci/hda/hda_eld.c:356 HDMI: invalid ELD data byte 0 > It's expected, as radeon (GPU driver) doesn't pass ELD struct anywhere > to the GPU and it's not done automatically neither. > > Unfortunately it doesn't seem to be trivial to solve. You may be > familiar with other GPUs like Nvidia or Intel, where it's done in a > pretty simple way, for example: >> for (i = 0; i < len; i++) >> I915_WRITE(hdmiw_hdmiedid, *((uint32_t *)eld + i)); > but it can't be handled that way on Radeon cards. > > If you take a look at evergreend.h [0] you can see we can't simply > write ELD to the GPU buffer, but we have to fill specific registers > which look more like SADs (Short Audio Descriptors). > > My question is how to handle this on the alsa side. We can't just read > ELD, we probably have to read some registers from the audio card. Is > something like that implemented anywhere else? Did anyone started > working on it? Anyone interested in it? > > [0] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drive… I tried hacking this sink info problem again. I've installed "fglrx" on my AMD Radeon HD 6970M (BARTS == DCE5) and verified it sets SAD registers: 5f84 7f077f07 5f88 00500705 5f8c 00000001 5f90 00000001 5f94 00000001 5f98 00000001 5f9c 00c01e05 5fa0 00000001 5fa4 00000001 5fa8 00000607 5fac 00017e07 5fb0 00007e07 5fb4 00000001 5fb8 00000001 Reading ELD of course doesn't work (that's why we get warning in dmesg) and I did some manual confirmation with hda-verb (reading ELD length): $ sudo ./hda-verb /dev/snd/hwC1D0 3 0xf2e 0x8 nid = 0x3, verb = 0xf2e, param = 0x8 value = 0x0 Plus (just for sure) reading first byte of ELD (in case length is always zero, but data is available): $ sudo ./hda-verb /dev/snd/hwC1D0 3 0xf2f 0 | grep val value = 0x0 $ sudo ./hda-verb /dev/snd/hwC1D0 3 0xf2f 1 | grep val value = 0x0 $ sudo ./hda-verb /dev/snd/hwC1D0 3 0xf2f 2 | grep val value = 0x0 So it seems ELD is really not available in this configuration. I thought about vendor specific verbs. Maybe values from the GPU registers are just copied to the audio? I've tried reading every possible vendor specific verb with the attached script (verbs.php). Unfortunately any verb didn't return anything interesting :( > grep value verbs.txt | sort | uniq -c 9336832 value = 0x0 18432 value = 0x1 6144 value = 0x40 2048 value = 0x415f 55296 value = 0x86 2048 value = 0xa6 16384 value = 0xb6 Does anyone have any idea how we can/should read that values from GPU in the audio driver? :| I guess the must be copied somewhere, but can't find the correct place. -- Rafał

1 0

Re: [alsa-devel] Enhance support for SigmaDSP chips
by Lars-Peter Clausen 17 Apr '13

17 Apr '13

On 04/11/2013 11:56 AM, Daniel Mack wrote: > Hi Lars, > Hi Cliff, > > I'm looking into the SigmaDSP AD1701 support, as a new prospective > project will use it. What's going to be used on this chip is not the > DAC/ADC features though, but the internal, programmable DSP things, and > designers will use the SigmaStudio IDE to generate the firmware. > > So I'm wondering how to support this kind of chip properly in ALSA, > which is not straight-forward, as the controls exported by it are > specific to the loaded firmware of course. Also, the IDE is free to > re-allocate every sub-addresses of its controls when something changes > in the layout of the building blocks. > > One idea I have in mind is to have a little parser script that reads the > generated sources of the IDE and dump a device-tree node snippet which > can then be put into the final DT. The driver would need to learn about > how to interpret that DT nodes, which will most likely just contain a > name, a sub-address, along with some mask and shift values. > > I wanted to ask for your opinion on that before I start. Have you ever > used any of the DSP features from ALSA/ASoC? Are there any pitfalls I > should be aware of? Is anyone actively working on improvements on the > driver? > > An alternative approach is to write a userspace library of course, but > that's going to be problematic once anybody wants to use the DSP > features in parallel to the DAC/ADC. Hi, I just yesterday wrote a small post how you can program the DSP registers. http://ez.analog.com/message/83094#83094 I'd like to be able to put the information about the different algorithms into the DSP firmware file itself, so we can auto instantiate the controls from the driver. The problem is that it is not so easy to generalize the export of the algorithms from SigmaStudio. Another problem is that you don't know how to calculate the algorithm parameters at runtime for some of the more complex algorithms. I don't think it's a good idea to put the control info into the devicetree and would rather prefer to see them go into the firmware. But as I said auto-generating this from exported SigmaStudio files is not so easy. So maybe manually creating the control info table might be an option. Btw. in case you haven't seen it the SigmaTcp tools is quite useful during the development of the firmware since it allows you to connect SigmaStudio directly to the DSP on the board. http://wiki.analog.com/resources/tools-software/linux-software/sigmatcp - Lars

3 4

[alsa-devel] [PATCH] ASoC: wm_adsp: Expose coefficient blocks as ALSA binary controls
by Dimitris Papastamos 17 Apr '13

17 Apr '13

Add initial support for runtime tuning for the ADSP cores. This is achieved by exposing the coefficient configuration blocks as ALSA binary controls. The current code assumes that no controls on the DSP are volatile. Change-Id: I9cd57efabe6c195c731f5a17f53617a99d2f09da Signed-off-by: Dimitris Papastamos <dp(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm_adsp.c | 435 ++++++++++++++++++++++++++++++++++++++++++++- sound/soc/codecs/wm_adsp.h | 3 + 2 files changed, 431 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 3470b64..080d05f 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -215,6 +215,36 @@ static struct { [WM_ADSP_FW_RX_ANC] = { .file = "rx-anc" }, }; +struct wm_coeff_ctl_ops { + int (*xget)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol); + int (*xput)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol); + int (*xinfo)(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo); +}; + +struct wm_coeff { + struct device *dev; + struct list_head ctl_list; + struct regmap *regmap; +}; + +struct wm_coeff_ctl { + const char *name; + struct snd_card *card; + struct wm_adsp_alg_region region; + struct wm_coeff_ctl_ops ops; + struct wm_adsp *adsp; + void *private; + unsigned int enabled:1; + struct list_head list; + void *cache; + size_t len; + unsigned int dirty:1; + struct snd_kcontrol *kcontrol; +}; + static int wm_adsp_fw_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { @@ -334,6 +364,175 @@ static unsigned int wm_adsp_region_to_reg(struct wm_adsp_region const *region, } } +static int wm_coeff_info(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + + uinfo->type = SNDRV_CTL_ELEM_TYPE_BYTES; + uinfo->count = ctl->len; + return 0; +} + +static int wm_coeff_write_control(struct snd_kcontrol *kcontrol, + const void *buf, size_t len) +{ + struct wm_coeff *wm_coeff= snd_kcontrol_chip(kcontrol); + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + struct wm_adsp_alg_region *region = &ctl->region; + const struct wm_adsp_region *mem; + struct wm_adsp *adsp = ctl->adsp; + void *scratch; + int ret; + unsigned int reg; + + mem = wm_adsp_find_region(adsp, region->type); + if (!mem) { + adsp_err(adsp, "No base for region %x\n", + region->type); + return -EINVAL; + } + + reg = ctl->region.base; + reg = wm_adsp_region_to_reg(mem, reg); + + scratch = kmemdup(buf, ctl->len, GFP_KERNEL | GFP_DMA); + if (!scratch) + return -ENOMEM; + + ret = regmap_raw_write(wm_coeff->regmap, reg, scratch, + ctl->len); + if (ret) { + adsp_err(adsp, "Failed to write %zu bytes to %x\n", + ctl->len, reg); + kfree(scratch); + return ret; + } + + kfree(scratch); + + return 0; +} + +static int wm_coeff_put(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + char *p = ucontrol->value.bytes.data; + + memcpy(ctl->cache, p, ctl->len); + + if (!ctl->enabled) { + ctl->dirty = 1; + return 0; + } + + return wm_coeff_write_control(kcontrol, p, ctl->len); +} + +static int wm_coeff_read_control(struct snd_kcontrol *kcontrol, + void *buf, size_t len) +{ + struct wm_coeff *wm_coeff= snd_kcontrol_chip(kcontrol); + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + struct wm_adsp_alg_region *region = &ctl->region; + const struct wm_adsp_region *mem; + struct wm_adsp *adsp = ctl->adsp; + void *scratch; + int ret; + unsigned int reg; + + mem = wm_adsp_find_region(adsp, region->type); + if (!mem) { + adsp_err(adsp, "No base for region %x\n", + region->type); + return -EINVAL; + } + + reg = ctl->region.base; + reg = wm_adsp_region_to_reg(mem, reg); + + scratch = kmalloc(ctl->len, GFP_KERNEL | GFP_DMA); + if (!scratch) + return -ENOMEM; + + ret = regmap_raw_read(wm_coeff->regmap, reg, scratch, ctl->len); + if (ret) { + adsp_err(adsp, "Failed to read %zu bytes from %x\n", + ctl->len, reg); + kfree(scratch); + return ret; + } + + memcpy(buf, scratch, ctl->len); + kfree(scratch); + + return 0; +} + +static int wm_coeff_get(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_value *ucontrol) +{ + struct wm_coeff_ctl *ctl = (struct wm_coeff_ctl *)kcontrol->private_value; + char *p = ucontrol->value.bytes.data; + + memcpy(p, ctl->cache, ctl->len); + return 0; +} + +static int wm_coeff_add_kcontrol(struct wm_coeff *wm_coeff, + struct wm_coeff_ctl *ctl, + const struct snd_kcontrol_new *kctl) +{ + int ret; + struct snd_kcontrol *kcontrol; + + kcontrol = snd_ctl_new1(kctl, wm_coeff); + ret = snd_ctl_add(ctl->card, kcontrol); + if (ret < 0) { + dev_err(wm_coeff->dev, "Failed to add %s: %d\n", + kctl->name, ret); + return ret; + } + ctl->kcontrol = kcontrol; + return 0; +} + +static int wmfw_add_ctl(struct wm_coeff *wm_coeff, + struct wm_coeff_ctl *ctl) +{ + struct snd_kcontrol_new *kcontrol; + int ret; + + if (!wm_coeff || !ctl || !ctl->name || !ctl->card) + return -EINVAL; + + kcontrol = kzalloc(sizeof(*kcontrol), GFP_KERNEL); + if (!kcontrol) + return -ENOMEM; + kcontrol->iface = SNDRV_CTL_ELEM_IFACE_MIXER; + + kcontrol->name = ctl->name; + kcontrol->info = wm_coeff_info; + kcontrol->get = wm_coeff_get; + kcontrol->put = wm_coeff_put; + kcontrol->private_value = (unsigned long)ctl; + + ret = wm_coeff_add_kcontrol(wm_coeff, + ctl, kcontrol); + if (ret < 0) + goto err_kcontrol; + + kfree(kcontrol); + + list_add(&ctl->list, &wm_coeff->ctl_list); + return 0; + +err_kcontrol: + kfree(kcontrol); + return ret; +} + static int wm_adsp_load(struct wm_adsp *dsp) { LIST_HEAD(buf_list); @@ -547,7 +746,140 @@ out: return ret; } -static int wm_adsp_setup_algs(struct wm_adsp *dsp) +static int wm_coeff_init_control_caches(struct wm_coeff *wm_coeff) +{ + struct wm_coeff_ctl *ctl; + int ret; + + list_for_each_entry(ctl, &wm_coeff->ctl_list, + list) { + if (!ctl->enabled || ctl->dirty) + continue; + ret = wm_coeff_read_control(ctl->kcontrol, + ctl->cache, + ctl->len); + if (ret < 0) + return ret; + } + + return 0; +} + +static int wm_coeff_sync_controls(struct wm_coeff *wm_coeff) +{ + struct wm_coeff_ctl *ctl; + int ret; + + list_for_each_entry(ctl, &wm_coeff->ctl_list, + list) { + if (!ctl->enabled) + continue; + if (ctl->dirty) { + ret = wm_coeff_write_control(ctl->kcontrol, + ctl->cache, + ctl->len); + if (ret < 0) + return ret; + ctl->dirty = 0; + } + } + + return 0; +} + +static int wm_adsp_create_control(struct snd_soc_codec *codec, + const struct wm_adsp_alg_region *region) + +{ + struct wm_adsp *dsp = snd_soc_codec_get_drvdata(codec); + struct wm_coeff_ctl *ctl; + char *name; + char *region_name; + int ret; + + name = kmalloc(PAGE_SIZE, GFP_KERNEL); + if (!name) + return -ENOMEM; + + switch (region->type) { + case WMFW_ADSP1_PM: + region_name = "PM"; + break; + case WMFW_ADSP1_DM: + region_name = "DM"; + break; + case WMFW_ADSP2_XM: + region_name = "XM"; + break; + case WMFW_ADSP2_YM: + region_name = "YM"; + break; + case WMFW_ADSP1_ZM: + region_name = "ZM"; + break; + default: + return -EINVAL; + } + + snprintf(name, PAGE_SIZE, "DSP%d %s %x", + dsp->num, region_name, region->alg); + + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + if (!strcmp(ctl->name, name)) { + if (!ctl->enabled) + ctl->enabled = 1; + return 0; + } + } + + ctl = kzalloc(sizeof(*ctl), GFP_KERNEL); + if (!ctl) { + ret = -ENOMEM; + goto err_name; + } + ctl->region = *region; + ctl->name = kmemdup(name, strlen(name) + 1, GFP_KERNEL); + if (!ctl->name) { + ret = -ENOMEM; + goto err_ctl; + } + ctl->enabled = 1; + ctl->dirty = 0; + ctl->ops.xget = wm_coeff_get; + ctl->ops.xput = wm_coeff_put; + ctl->card = codec->card->snd_card; + ctl->adsp = dsp; + + ctl->len = region->len; + ctl->cache = kzalloc(ctl->len, GFP_KERNEL); + if (!ctl->cache) { + ret = -ENOMEM; + goto err_ctl_name; + } + + ret = wmfw_add_ctl(dsp->wm_coeff, ctl); + if (ret < 0) { + ret = -ENOMEM; + goto err_ctl_cache; + } + + kfree(name); + + return 0; + +err_ctl_cache: + kfree(ctl->cache); +err_ctl_name: + kfree(ctl->name); +err_ctl: + kfree(ctl); +err_name: + kfree(name); + return ret; +} + +static int wm_adsp_setup_algs(struct wm_adsp *dsp, struct snd_soc_codec *codec) { struct regmap *regmap = dsp->regmap; struct wmfw_adsp1_id_hdr adsp1_id; @@ -730,7 +1062,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP1_DM; region->alg = be32_to_cpu(adsp1_alg[i].alg.id); region->base = be32_to_cpu(adsp1_alg[i].dm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp1_alg[i + 1].dm); + region->len -= be32_to_cpu(adsp1_alg[i].dm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region DM with ID %x\n", + be32_to_cpu(adsp1_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -738,7 +1079,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP1_ZM; region->alg = be32_to_cpu(adsp1_alg[i].alg.id); region->base = be32_to_cpu(adsp1_alg[i].zm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp1_alg[i + 1].zm); + region->len -= be32_to_cpu(adsp1_alg[i].zm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region ZM with ID %x\n", + be32_to_cpu(adsp1_alg[i].alg.id)); + } break; case WMFW_ADSP2: @@ -758,7 +1108,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_XM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].xm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].xm); + region->len -= be32_to_cpu(adsp2_alg[i].xm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region XM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -766,7 +1125,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_YM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].ym); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].ym); + region->len -= be32_to_cpu(adsp2_alg[i].ym); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region YM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } region = kzalloc(sizeof(*region), GFP_KERNEL); if (!region) @@ -774,7 +1142,16 @@ static int wm_adsp_setup_algs(struct wm_adsp *dsp) region->type = WMFW_ADSP2_ZM; region->alg = be32_to_cpu(adsp2_alg[i].alg.id); region->base = be32_to_cpu(adsp2_alg[i].zm); + region->len = 0; list_add_tail(&region->list, &dsp->alg_regions); + if (i + 1 < algs) { + region->len = be32_to_cpu(adsp2_alg[i + 1].zm); + region->len -= be32_to_cpu(adsp2_alg[i].zm); + wm_adsp_create_control(codec, region); + } else { + adsp_warn(dsp, "Missing length info for region ZM with ID %x\n", + be32_to_cpu(adsp2_alg[i].alg.id)); + } break; } } @@ -986,6 +1363,7 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, struct snd_soc_codec *codec = w->codec; struct wm_adsp *dsps = snd_soc_codec_get_drvdata(codec); struct wm_adsp *dsp = &dsps[w->shift]; + struct wm_coeff_ctl *ctl; int ret; int val; @@ -1023,7 +1401,7 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; - ret = wm_adsp_setup_algs(dsp); + ret = wm_adsp_setup_algs(dsp, codec); if (ret != 0) goto err; @@ -1031,6 +1409,16 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; + /* Initialize caches for enabled and non-dirty controls */ + ret = wm_coeff_init_control_caches(dsp->wm_coeff); + if (ret != 0) + goto err; + + /* Sync dirty controls */ + ret = wm_coeff_sync_controls(dsp->wm_coeff); + if (ret != 0) + goto err; + /* Start the core running */ regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30, ADSP1_CORE_ENA | ADSP1_START, @@ -1047,6 +1435,11 @@ int wm_adsp1_event(struct snd_soc_dapm_widget *w, regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30, ADSP1_SYS_ENA, 0); + + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + ctl->enabled = 0; + } break; default: @@ -1099,6 +1492,7 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, struct wm_adsp *dsps = snd_soc_codec_get_drvdata(codec); struct wm_adsp *dsp = &dsps[w->shift]; struct wm_adsp_alg_region *alg_region; + struct wm_coeff_ctl *ctl; unsigned int val; int ret; @@ -1164,7 +1558,7 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; - ret = wm_adsp_setup_algs(dsp); + ret = wm_adsp_setup_algs(dsp, codec); if (ret != 0) goto err; @@ -1172,6 +1566,16 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, if (ret != 0) goto err; + /* Initialize caches for enabled and non-dirty controls */ + ret = wm_coeff_init_control_caches(dsp->wm_coeff); + if (ret != 0) + goto err; + + /* Sync dirty controls */ + ret = wm_coeff_sync_controls(dsp->wm_coeff); + if (ret != 0) + goto err; + ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL, ADSP2_CORE_ENA | ADSP2_START, @@ -1209,6 +1613,11 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w, ret); } + list_for_each_entry(ctl, &dsp->wm_coeff->ctl_list, + list) { + ctl->enabled = 0; + } + while (!list_empty(&dsp->alg_regions)) { alg_region = list_first_entry(&dsp->alg_regions, struct wm_adsp_alg_region, @@ -1247,36 +1656,48 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) INIT_LIST_HEAD(&adsp->alg_regions); + adsp->wm_coeff = kzalloc(sizeof(*adsp->wm_coeff), + GFP_KERNEL); + if (!adsp->wm_coeff) + return -ENOMEM; + adsp->wm_coeff->regmap = adsp->regmap; + adsp->wm_coeff->dev = adsp->dev; + INIT_LIST_HEAD(&adsp->wm_coeff->ctl_list); + if (dvfs) { adsp->dvfs = devm_regulator_get(adsp->dev, "DCVDD"); if (IS_ERR(adsp->dvfs)) { ret = PTR_ERR(adsp->dvfs); dev_err(adsp->dev, "Failed to get DCVDD: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_enable(adsp->dvfs); if (ret != 0) { dev_err(adsp->dev, "Failed to enable DCVDD: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_set_voltage(adsp->dvfs, 1200000, 1800000); if (ret != 0) { dev_err(adsp->dev, "Failed to initialise DVFS: %d\n", ret); - return ret; + goto out_coeff; } ret = regulator_disable(adsp->dvfs); if (ret != 0) { dev_err(adsp->dev, "Failed to disable DCVDD: %d\n", ret); - return ret; + goto out_coeff; } } return 0; + +out_coeff: + kfree(adsp->wm_coeff); + return ret; } EXPORT_SYMBOL_GPL(wm_adsp2_init); diff --git a/sound/soc/codecs/wm_adsp.h b/sound/soc/codecs/wm_adsp.h index fea5146..6e890b9 100644 --- a/sound/soc/codecs/wm_adsp.h +++ b/sound/soc/codecs/wm_adsp.h @@ -30,6 +30,7 @@ struct wm_adsp_alg_region { unsigned int alg; int type; unsigned int base; + size_t len; }; struct wm_adsp { @@ -55,6 +56,8 @@ struct wm_adsp { bool running; struct regulator *dvfs; + + struct wm_coeff *wm_coeff; }; #define WM_ADSP1(wname, num) \ -- 1.8.2.1

1 0

[alsa-devel] Can Realtek HD-A codec ALC282 support D3cold?
by Lin, Mengdong 17 Apr '13

17 Apr '13

Hi, (Sorry to post this message again) We want to put an idle HD-A codec into D3cold for more power saving and preparation for being power gated. The Realtek ALC282 is used in our test. Could anyone help to confirm whether ALC282 can support D3cold or not? I'm told that ALC282 can support D3cold. But my test shows it cannot. At first, ALC282 HW does not report that it can support D3cold. Its parameter "Supported Power States" returns 0xc000000f, means it only supports: EPSS, CLKSTOP, D3hot, D2, D1 and D0. Is this a just mistake in reporting the bit, or D3cold is not supported all? Then when I explicitly set the audio function group to D3cold by verb 0x705, and then get its power state after 200ms by verb 0xf05, The codec response is 0x00000000: No PS-Error, both PS-Act and PS-set is D0. So it seems codec HW does not process the set power state command at all. Is there someone from Realtek or familiar with ALC282 here can share some information about this issue? Many thanks Mengdong

2 1

Re: [alsa-devel] [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC]
by Mauro Carvalho Chehab 16 Apr '13

16 Apr '13

Em 16-04-2013 15:26, David Howells escreveu: > Supply accessor functions to set attributes in proc_dir_entry structs. > > The following are supplied: proc_set_size() and proc_set_user(). > > Signed-off-by: David Howells <dhowells(a)redhat.com> > cc: linuxppc-dev(a)lists.ozlabs.org > cc: linux-media(a)vger.kernel.org > cc: netdev(a)vger.kernel.org > cc: linux-wireless(a)vger.kernel.org > cc: linux-pci(a)vger.kernel.org > cc: netfilter-devel(a)vger.kernel.org > cc: alsa-devel(a)alsa-project.org > --- > > arch/powerpc/kernel/proc_powerpc.c | 2 +- > arch/powerpc/platforms/pseries/reconfig.c | 2 +- > drivers/media/pci/ttpci/av7110_ir.c | 2 +- Weird that av7110 IR uses /proc... Well, this is an old, obsolete driver for hardware that is not sold anymore for a long time... So, be it. Acked-by: Mauro Carvalho Chehab <mchehab(a)redhat.com> > drivers/net/irda/vlsi_ir.c | 2 +- > drivers/net/wireless/airo.c | 34 +++++++++-------------------- > drivers/pci/proc.c | 2 +- > fs/proc/generic.c | 13 +++++++++++ > include/linux/proc_fs.h | 5 ++++ > kernel/configs.c | 2 +- > kernel/profile.c | 2 +- > net/netfilter/xt_recent.c | 3 +-- > sound/core/info.c | 2 +- > 12 files changed, 38 insertions(+), 33 deletions(-) > > diff --git a/arch/powerpc/kernel/proc_powerpc.c b/arch/powerpc/kernel/proc_powerpc.c > index 41d8ee9..feb8580 100644 > --- a/arch/powerpc/kernel/proc_powerpc.c > +++ b/arch/powerpc/kernel/proc_powerpc.c > @@ -83,7 +83,7 @@ static int __init proc_ppc64_init(void) > &page_map_fops, vdso_data); > if (!pde) > return 1; > - pde->size = PAGE_SIZE; > + proc_set_size(pde, PAGE_SIZE); > > return 0; > } > diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c > index d6491bd..f93cdf5 100644 > --- a/arch/powerpc/platforms/pseries/reconfig.c > +++ b/arch/powerpc/platforms/pseries/reconfig.c > @@ -452,7 +452,7 @@ static int proc_ppc64_create_ofdt(void) > > ent = proc_create("powerpc/ofdt", S_IWUSR, NULL, &ofdt_fops); > if (ent) > - ent->size = 0; > + proc_set_size(ent, 0); > > return 0; > } > diff --git a/drivers/media/pci/ttpci/av7110_ir.c b/drivers/media/pci/ttpci/av7110_ir.c > index eb82286..0e763a7 100644 > --- a/drivers/media/pci/ttpci/av7110_ir.c > +++ b/drivers/media/pci/ttpci/av7110_ir.c > @@ -375,7 +375,7 @@ int av7110_ir_init(struct av7110 *av7110) > if (av_cnt == 1) { > e = proc_create("av7110_ir", S_IWUSR, NULL, &av7110_ir_proc_fops); > if (e) > - e->size = 4 + 256 * sizeof(u16); > + proc_set_size(e, 4 + 256 * sizeof(u16)); > } > > tasklet_init(&av7110->ir.ir_tasklet, av7110_emit_key, (unsigned long) &av7110->ir); > diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c > index e22cd4e..5f47584 100644 > --- a/drivers/net/irda/vlsi_ir.c > +++ b/drivers/net/irda/vlsi_ir.c > @@ -1678,7 +1678,7 @@ vlsi_irda_probe(struct pci_dev *pdev, const struct pci_device_id *id) > IRDA_WARNING("%s: failed to create proc entry\n", > __func__); > } else { > - ent->size = 0; > + proc_set_size(ent, 0); > } > idev->proc_entry = ent; > } > diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c > index 66e398d..21d0233 100644 > --- a/drivers/net/wireless/airo.c > +++ b/drivers/net/wireless/airo.c > @@ -4507,73 +4507,63 @@ static int setup_proc_entry( struct net_device *dev, > airo_entry); > if (!apriv->proc_entry) > goto fail; > - apriv->proc_entry->uid = proc_kuid; > - apriv->proc_entry->gid = proc_kgid; > + proc_set_user(apriv->proc_entry, proc_kuid, proc_kgid); > > /* Setup the StatsDelta */ > entry = proc_create_data("StatsDelta", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_statsdelta_ops, dev); > if (!entry) > goto fail_stats_delta; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Stats */ > entry = proc_create_data("Stats", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_stats_ops, dev); > if (!entry) > goto fail_stats; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Status */ > entry = proc_create_data("Status", S_IRUGO & proc_perm, > apriv->proc_entry, &proc_status_ops, dev); > if (!entry) > goto fail_status; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the Config */ > entry = proc_create_data("Config", proc_perm, > apriv->proc_entry, &proc_config_ops, dev); > if (!entry) > goto fail_config; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the SSID */ > entry = proc_create_data("SSID", proc_perm, > apriv->proc_entry, &proc_SSID_ops, dev); > if (!entry) > goto fail_ssid; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the APList */ > entry = proc_create_data("APList", proc_perm, > apriv->proc_entry, &proc_APList_ops, dev); > if (!entry) > goto fail_aplist; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the BSSList */ > entry = proc_create_data("BSSList", proc_perm, > apriv->proc_entry, &proc_BSSList_ops, dev); > if (!entry) > goto fail_bsslist; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > + proc_set_user(entry, proc_kuid, proc_kgid); > > /* Setup the WepKey */ > entry = proc_create_data("WepKey", proc_perm, > apriv->proc_entry, &proc_wepkey_ops, dev); > if (!entry) > goto fail_wepkey; > - entry->uid = proc_kuid; > - entry->gid = proc_kgid; > - > + proc_set_user(entry, proc_kuid, proc_kgid); > return 0; > > fail_wepkey: > @@ -5695,10 +5685,8 @@ static int __init airo_init_module( void ) > > airo_entry = proc_mkdir_mode("driver/aironet", airo_perm, NULL); > > - if (airo_entry) { > - airo_entry->uid = proc_kuid; > - airo_entry->gid = proc_kgid; > - } > + if (airo_entry) > + proc_set_user(airo_entry, proc_kuid, proc_kgid); > > for (i = 0; i < 4 && io[i] && irq[i]; i++) { > airo_print_info("", "Trying to configure ISA adapter at irq=%d " > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 12e4fb5..7cde7c1 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -419,7 +419,7 @@ int pci_proc_attach_device(struct pci_dev *dev) > &proc_bus_pci_operations, dev); > if (!e) > return -ENOMEM; > - e->size = dev->cfg_size; > + proc_set_size(e, dev->cfg_size); > dev->procent = e; > > return 0; > diff --git a/fs/proc/generic.c b/fs/proc/generic.c > index 1c07cad..5f6f6c3 100644 > --- a/fs/proc/generic.c > +++ b/fs/proc/generic.c > @@ -498,6 +498,19 @@ out: > return NULL; > } > EXPORT_SYMBOL(proc_create_data); > + > +void proc_set_size(struct proc_dir_entry *de, loff_t size) > +{ > + de->size = size; > +} > +EXPORT_SYMBOL(proc_set_size); > + > +void proc_set_user(struct proc_dir_entry *de, kuid_t uid, kgid_t gid) > +{ > + de->uid = uid; > + de->gid = gid; > +} > +EXPORT_SYMBOL(proc_set_user); > > static void free_proc_entry(struct proc_dir_entry *de) > { > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index 805edac..28a4d7e 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -130,6 +130,9 @@ static inline struct proc_dir_entry *proc_create(const char *name, umode_t mode, > extern struct proc_dir_entry *proc_net_mkdir(struct net *net, const char *name, > struct proc_dir_entry *parent); > > +extern void proc_set_size(struct proc_dir_entry *, loff_t); > +extern void proc_set_user(struct proc_dir_entry *, kuid_t, kgid_t); > + > extern struct file *proc_ns_fget(int fd); > extern bool proc_ns_inode(struct inode *inode); > > @@ -158,6 +161,8 @@ static inline struct proc_dir_entry *proc_mkdir(const char *name, > struct proc_dir_entry *parent) {return NULL;} > static inline struct proc_dir_entry *proc_mkdir_mode(const char *name, > umode_t mode, struct proc_dir_entry *parent) { return NULL; } > +static inline void proc_set_size(struct proc_dir_entry *de, loff_t size) {} > +static inline void proc_set_user(struct proc_dir_entry *de, kuid_t uid, kgid_t gid) {} > > struct tty_driver; > static inline void proc_tty_register_driver(struct tty_driver *driver) {}; > diff --git a/kernel/configs.c b/kernel/configs.c > index 42e8fa0..c18b1f1 100644 > --- a/kernel/configs.c > +++ b/kernel/configs.c > @@ -79,7 +79,7 @@ static int __init ikconfig_init(void) > if (!entry) > return -ENOMEM; > > - entry->size = kernel_config_data_size; > + proc_set_size(entry, kernel_config_data_size); > > return 0; > } > diff --git a/kernel/profile.c b/kernel/profile.c > index 524ce5e..0bf4007 100644 > --- a/kernel/profile.c > +++ b/kernel/profile.c > @@ -600,7 +600,7 @@ int __ref create_proc_profile(void) /* false positive from hotcpu_notifier */ > NULL, &proc_profile_operations); > if (!entry) > return 0; > - entry->size = (1+prof_len) * sizeof(atomic_t); > + proc_set_size(entry, (1 + prof_len) * sizeof(atomic_t)); > hotcpu_notifier(profile_cpu_callback, 0); > return 0; > } > diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c > index 3db2d38..1e657cf 100644 > --- a/net/netfilter/xt_recent.c > +++ b/net/netfilter/xt_recent.c > @@ -401,8 +401,7 @@ static int recent_mt_check(const struct xt_mtchk_param *par, > ret = -ENOMEM; > goto out; > } > - pde->uid = uid; > - pde->gid = gid; > + proc_set_user(pde, uid, gid); > #endif > spin_lock_bh(&recent_lock); > list_add_tail(&t->list, &recent_net->tables); > diff --git a/sound/core/info.c b/sound/core/info.c > index 3aa8864..c7f41c3 100644 > --- a/sound/core/info.c > +++ b/sound/core/info.c > @@ -970,7 +970,7 @@ int snd_info_register(struct snd_info_entry * entry) > mutex_unlock(&info_mutex); > return -ENOMEM; > } > - p->size = entry->size; > + proc_set_size(p, entry->size); > } > entry->p = p; > if (entry->parent) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >

1 0

[alsa-devel] [PATCH] tinycompress: cplay: Correct a couple of small message typos
by Richard Fitzgerald 16 Apr '13

16 Apr '13

Change-Id: I2b25d006328f1a9458f232f77c61e509c9b54d3c Signed-off-by: Charles Keepax <ckeepax(a)opensource.wolfsonmicro.com> --- cplay.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cplay.c b/cplay.c index 60995a4..d9364f4 100644 --- a/cplay.c +++ b/cplay.c @@ -337,7 +337,7 @@ void play_samples(char *name, unsigned int card, unsigned int device, goto BUF_EXIT; } if (wrote != num_read) { - /* TODO: Buufer pointer needs to be set here */ + /* TODO: Buffer pointer needs to be set here */ fprintf(stderr, "We wrote %d, DSP accepted %d\n", num_read, wrote); } if (verbose) { @@ -348,7 +348,7 @@ void play_samples(char *name, unsigned int card, unsigned int device, } while (num_read > 0); if (verbose) - printf("%s: exit sucess\n", __func__); + printf("%s: exit success\n", __func__); /* issue drain if it supports */ compress_drain(compress); free(buffer); -- 1.7.2.5

2 1

[alsa-devel] [PATCH] ASoC: fsi: fixup sparse errors
by Kuninori Morimoto 16 Apr '13

16 Apr '13

This patch fixup below sparse errors ${LINUX}/sound/soc/sh/fsi.c:1459:9: \ error: incompatible types in conditional expression (different base types) ${LINUX}/sound/soc/sh/fsi.c:1634:25: \ error: incompatible types in conditional expression (different base types) ${LINUX}/sound/soc/sh/fsi.c:1639:17: \ error: incompatible types in conditional expression (different base types) ${LINUX}/sound/soc/sh/fsi.c:2093:9: \ error: incompatible types in conditional expression (different base types) ${LINUX}/sound/soc/sh/fsi.c:2105:9: \ error: incompatible types in conditional expression (different base types) Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/fsi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index c724026a..7bc767b 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -276,7 +276,7 @@ struct fsi_stream_handler { int (*probe)(struct fsi_priv *fsi, struct fsi_stream *io, struct device *dev); int (*transfer)(struct fsi_priv *fsi, struct fsi_stream *io); int (*remove)(struct fsi_priv *fsi, struct fsi_stream *io); - void (*start_stop)(struct fsi_priv *fsi, struct fsi_stream *io, + int (*start_stop)(struct fsi_priv *fsi, struct fsi_stream *io, int enable); }; #define fsi_stream_handler_call(io, func, args...) \ @@ -1189,7 +1189,7 @@ static int fsi_pio_push(struct fsi_priv *fsi, struct fsi_stream *io) samples); } -static void fsi_pio_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, +static int fsi_pio_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, int enable) { struct fsi_master *master = fsi_get_master(fsi); @@ -1202,6 +1202,8 @@ static void fsi_pio_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, if (fsi_is_clk_master(fsi)) fsi_master_mask_set(master, CLK_RST, clk, (enable) ? clk : 0); + + return 0; } static int fsi_pio_push_init(struct fsi_priv *fsi, struct fsi_stream *io) @@ -1410,7 +1412,7 @@ static int fsi_dma_transfer(struct fsi_priv *fsi, struct fsi_stream *io) return 0; } -static void fsi_dma_push_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, +static int fsi_dma_push_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, int start) { struct fsi_master *master = fsi_get_master(fsi); @@ -1423,6 +1425,8 @@ static void fsi_dma_push_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, if (fsi_is_clk_master(fsi)) fsi_master_mask_set(master, CLK_RST, clk, (enable) ? clk : 0); + + return 0; } static int fsi_dma_probe(struct fsi_priv *fsi, struct fsi_stream *io, struct device *dev) -- 1.7.9.5

1 0

[alsa-devel] about snd_pcm_writei() parameter
by Zhang wei 16 Apr '13

16 Apr '13

hi all. Is there have some limitation on the parameter size of the interface: snd_pcm_sframes_t snd_pcm_readi(snd_pcm_t *pcm, void *buffer, snd_pcm_uframes_t size)? should be the SIZE as any value ? For example, set the size < period_size, ok? does the parameter depend on the period_size? Thanks a lot. ---- BR zw

1 0

Re: [alsa-devel] [PATCH 01/17] ASoC: dmaengine-pcm: Make requesting the DMA channel at PCM open optional
by Lars-Peter Clausen 16 Apr '13

16 Apr '13

On 04/16/2013 01:28 AM, Ryan Mallon wrote: > On 16/04/13 03:19, Lars-Peter Clausen wrote: >> Refactor the dmaengine PCM library to allow the DMA channel to be requested >> before opening a PCM substream. snd_dmaengine_pcm_open() now expects a DMA >> channel instead of a filter function and filter parameter as its parameters. >> snd_dmaengine_pcm_close() is updated to not release the DMA channel. This allows >> a dmaengine based PCM driver to request its channels before the substream is >> opened. >> >> The patch also introduces two new functions, snd_dmaengine_pcm_open_request_chan() >> and snd_dmaengine_pcm_close_release_chan(), which have the same signature and >> behaviour of the old snd_dmaengine_pcm_{open,close}() and internally use the new >> variants of these functions. All users of snd_dmaengine_pcm_{open,close}() are >> updated to use snd_dmaengine_pcm_open_request_chan() and >> snd_dmaengine_pcm_close_release_chan(). >> >> Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> > > <snip> > >> --- a/sound/soc/cirrus/ep93xx-pcm.c >> +++ b/sound/soc/cirrus/ep93xx-pcm.c >> @@ -69,7 +69,8 @@ static int ep93xx_pcm_open(struct snd_pcm_substream *substream) >> >> snd_soc_set_runtime_hwparams(substream, &ep93xx_pcm_hardware); >> >> - return snd_dmaengine_pcm_open(substream, ep93xx_pcm_dma_filter, >> + return snd_dmaengine_pcm_open_request_chan(substream, >> + ep93xx_pcm_dma_filter, >> snd_soc_dai_get_dma_data(rtd->cpu_dai, substream)); > > ep93xx_pcm_dma_filter is now unused and can be removed? It's still used in the same way as before. - Lars

1 0

Re: [alsa-devel] [PATCH 16/17] ASoC: ep93xx: Use generic dmaengine PCM
by Lars-Peter Clausen 16 Apr '13

16 Apr '13

On 04/16/2013 01:48 AM, Ryan Mallon wrote: > On 16/04/13 03:20, Lars-Peter Clausen wrote: >> Use the generic dmaengine PCM driver instead of a custom implementation. >> >> Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> >> --- >> sound/soc/cirrus/Kconfig | 2 +- >> sound/soc/cirrus/ep93xx-i2s.c | 4 +- >> sound/soc/cirrus/ep93xx-pcm.c | 138 ++++-------------------------------------- >> 3 files changed, 14 insertions(+), 130 deletions(-) >> >> diff --git a/sound/soc/cirrus/Kconfig b/sound/soc/cirrus/Kconfig >> index 88143db..2c20f01 100644 >> --- a/sound/soc/cirrus/Kconfig >> +++ b/sound/soc/cirrus/Kconfig >> @@ -1,7 +1,7 @@ >> config SND_EP93XX_SOC >> tristate "SoC Audio support for the Cirrus Logic EP93xx series" >> depends on ARCH_EP93XX && SND_SOC >> - select SND_SOC_DMAENGINE_PCM >> + select SND_SOC_GENERIC_DMAENGINE_PCM >> help >> Say Y or M if you want to add support for codecs attached to >> the EP93xx I2S or AC97 interfaces. >> diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c >> index 453a89c..ef731e6 100644 >> --- a/sound/soc/cirrus/ep93xx-i2s.c >> +++ b/sound/soc/cirrus/ep93xx-i2s.c >> @@ -140,8 +140,8 @@ static void ep93xx_i2s_disable(struct ep93xx_i2s_info *info, int stream) >> >> static int ep93xx_i2s_dai_probe(struct snd_soc_dai *dai) >> { >> - dai->playback_dma_data = ep93xx_i2s_dma_data[SNDRV_PCM_STREAM_PLAYBACK]; >> - dai->capute_dma_data = ep93xx_i2s_dma_data[SNDRV_PCM_STREAM_CAPTURE] >> + dai->playback_dma_data = &ep93xx_i2s_dma_data[SNDRV_PCM_STREAM_PLAYBACK]; >> + dai->capture_dma_data = &ep93xx_i2s_dma_data[SNDRV_PCM_STREAM_CAPTURE]; > > Why did this change? I can't see a change to ep93xx_i2s_dma_data. Was > this just incorrect in the previous patch? All patches in a series > should be buildable/runnable to assist things like git bisect. > Yes, that part belongs to the previous patch and only ended up here by accident. >> >> return 0; >> } >> diff --git a/sound/soc/cirrus/ep93xx-pcm.c b/sound/soc/cirrus/ep93xx-pcm.c >> index 4880326..0e9f56e 100644 >> --- a/sound/soc/cirrus/ep93xx-pcm.c >> +++ b/sound/soc/cirrus/ep93xx-pcm.c >> @@ -14,20 +14,14 @@ >> >> #include <linux/module.h> >> #include <linux/init.h> >> -#include <linux/device.h> >> -#include <linux/slab.h> >> +#include <linux/platform_device.h> >> #include <linux/dmaengine.h> >> -#include <linux/dma-mapping.h> >> >> -#include <sound/core.h> >> #include <sound/pcm.h> >> -#include <sound/pcm_params.h> >> #include <sound/soc.h> >> #include <sound/dmaengine_pcm.h> >> >> #include <linux/platform_data/dma-ep93xx.h> >> -#include <mach/hardware.h> >> -#include <mach/ep93xx-regs.h> > > Awesome. It looks like this header can also be removed from ep93xx-i2s.c > also, which gets us a step closer to making this header private to the > ep93xx soc code in arch/arm. > > ~Ryan >

1 0

[alsa-devel] [PATCH] ALSA: hda - Add codec delay to the capture time stamp.
by Dylan Reid 16 Apr '13

16 Apr '13

For capture, the delay through the codec contributes to the time stamp of the sample recorded at the A to D. Rename the codec time stamp function appropriately. Signed-off-by: Dylan Reid <dgreid(a)chromium.org> --- sound/pci/hda/hda_intel.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 63734b5..7b213d5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1889,7 +1889,7 @@ static void azx_timecounter_init(struct snd_pcm_substream *substream, tc->cycle_last = last; } -static u64 azx_subtract_codec_delay(struct snd_pcm_substream *substream, +static u64 azx_adjust_codec_delay(struct snd_pcm_substream *substream, u64 nsec) { struct azx_pcm *apcm = snd_pcm_substream_chip(substream); @@ -1903,6 +1903,9 @@ static u64 azx_subtract_codec_delay(struct snd_pcm_substream *substream, codec_nsecs = div_u64(codec_frames * 1000000000LL, substream->runtime->rate); + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) + return nsec + codec_nsecs; + return (nsec > codec_nsecs) ? nsec - codec_nsecs : 0; } @@ -1914,7 +1917,7 @@ static int azx_get_wallclock_tstamp(struct snd_pcm_substream *substream, nsec = timecounter_read(&azx_dev->azx_tc); nsec = div_u64(nsec, 3); /* can be optimized */ - nsec = azx_subtract_codec_delay(substream, nsec); + nsec = azx_adjust_codec_delay(substream, nsec); *ts = ns_to_timespec(nsec); -- 1.8.1.3.605.g02339dd

2 1

[alsa-devel] ASoC updates for v3.10
by Mark Brown 15 Apr '13

15 Apr '13

The following changes since commit b02e48f2f8755e51fe8ce246988a29bd96f6b85e: MAINTAINERS: Update e-mail address (2013-04-12 11:53:41 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v3.10 for you to fetch changes up to 5cbad7d39ad229c68a724e5e139fd845b93766b2: Merge remote-tracking branch 'asoc/topic/wm8994' into asoc-next (2013-04-12 13:57:31 +0100) ---------------------------------------------------------------- ASoC: Updates for v3.10 A bunch of changes here, the most interesting one subsystem wise being Morimoto-san's work to create snd_soc_component which doesn't do much for now but will be pretty important going forwards: - Add a new component object type which will form the basis of moving to a more generic handling of SoC and off-SoC components, contributed by Kuninori Morimoto. - A fairly large set of cleanups for the dmaengine integration from Lars-Peter Clausen, starting to move towards being able to have a generic driver based on the library. - Performance optimisations to DAPM from Ryo Tsutsui. - Support for mixer control sharing in DAPM from Stephen Warren. - Multiplatform ARM cleanups from Arnd Bergmann. - New CODEC drivers for AK5385 and TAS5086 from Daniel Mack. ---------------------------------------------------------------- Alban Bedel (1): ASoC: wm8903: Add the DAC boost control Alexandru Gheorghiu (1): ASoC: core: Use PTR_RET function Andrey Smirnov (2): ASoC: si476x: Convert SI476X codec to use regmap ASoC: si476x: Cosmetic changes to SI476X codec driver Arnd Bergmann (4): ASoC: samsung: use irq resource for idma ASoC: samsung: fix module_device_table ASoC: samsung: export idma_reg_addr_init ASoC: samsung: move plat/ headers to local directory Charles Keepax (12): ASoC: arizona: Move selection of FLL REFCLK into init ASoC: arizona: Tidy up SYNCCLK selection and cache values ASoC: arizona: Factor out check for enabled FLL ASoC: arizona: Factor out FLL disable ASoC: arizona: Factor out FLL enable ASoC: arizona: Improve suppression of noop FLL updates ASoC: arizona: Add support for directly setting the FLL REFCLK ASoC: arizona: Add convience define for clearing SYNCCLK ASoC: arizona: Don't enable FLL on REFCLK configuration ASoC: wm5102: Correctly use SOC_VALUE_ENUM for ISRC FSL controls ASoC: wm0010: Constify usage of firmware filenames ASoC: wm0010: Report filename when we fail to load firmware Dan Carpenter (1): ASoC: tas5086: signedness bug in tas5086_hw_params() Daniel Mack (7): ASoC: ak4104: convert to direct regmap API usage ASoC: ak4104: correct tranceiver enable handling ASoC: Add codec driver for AK5386 ALSA: ASoC: add codec driver for TI TAS5086 ASoC: davinci-mcasp: clean up davinci_hw_common_param() ASoC: cs4271: convert to direct regmap API usage ASoC: cs4271: switch to mute_stream Dylan Reid (1): ASoC: max98088: Add TLV data for volume controls. Fabio Estevam (2): ASoC: fsl: imx-audmux: Use devm_clk_get() ASoC: fsl: imx-pcm-fiq: Use 'unsigned int' for period Heiko Stübner (1): ASoC: samsung: fix neo1973-wm8753 compilation Jeeja KP (1): ASoC: compress - add support for metadata apis Kuninori Morimoto (61): ASoC: core: tidyup snd_soc_register_codec() fail case ASoC: core: use snd_soc_register_dais() on codec ASoC: core: remove codec from list if registration failed ASoC: fsi: remove unused irq ASoC: add snd_soc_register_component() ASoC: add .name for snd_soc_component_driver ASoC: fsi: use snd_soc_register_component() instead of snd_soc_register_dais() ASoC: pxa2xx-ac97: move EXPORT_SYMBOL_GPL() next to definition ASoC: snd_soc_register_component() uses properly snd_soc_register_dai[s]() ASoC: switch over to use snd_soc_register_component() on davinci i2s ASoC: switch over to use snd_soc_register_component() on davinci vcif ASoC: switch over to use snd_soc_register_component() on davinci mcasp ASoC: switch over to use snd_soc_register_component() on dw i2s ASoC: switch over to use snd_soc_register_component() on mpc5200 ac97 ASoC: switch over to use snd_soc_register_component() on atmel ssc ASoC: switch over to use snd_soc_register_component() on au1x i2sc ASoC: switch over to use snd_soc_register_component() on au1x psc-ac97 ASoC: switch over to use snd_soc_register_component() on au1x psc-i2s ASoC: switch over to use snd_soc_register_component() on au1x ac97c ASoC: switch over to use snd_soc_register_component() on bf6xx i2s ASoC: switch over to use snd_soc_register_component() on bf5xx ac97 ASoC: switch over to use snd_soc_register_component() on bf5xx i2s ASoC: switch over to use snd_soc_register_component() on bf5xx tdm ASoC: switch over to use snd_soc_register_component() on ep93xx ac97 ASoC: switch over to use snd_soc_register_component() on ep93xx i2s ASoC: switch over to use snd_soc_register_component() on mpc5200 i2s ASoC: switch over to use snd_soc_register_component() on fsl ssi ASoC: switch over to use snd_soc_register_component() on imx ssi ASoC: switch over to use snd_soc_register_component() on jz4740 i2s ASoC: switch over to use snd_soc_register_component() on kirkwood i2s ASoC: switch over to use snd_soc_register_component() on sst ASoC: switch over to use snd_soc_register_component() on mxs saif ASoC: switch over to use snd_soc_register_component() on nuc900 ac97 ASoC: switch over to use snd_soc_register_component() on omap mcbsp ASoC: switch over to use snd_soc_register_component() on omap mcpdm ASoC: switch over to use snd_soc_register_component() on omap dmic ASoC: switch over to use snd_soc_register_component() on omap hdmi ASoC: switch over to use snd_soc_register_component() on pxa ssp ASoC: switch over to use snd_soc_register_component() on pxa2xx ac97 ASoC: switch over to use snd_soc_register_component() on pxa2xx i2s ASoC: switch over to use snd_soc_register_component() on mmp sspa ASoC: switch over to use snd_soc_register_component() on s6000 i2s ASoC: switch over to use snd_soc_register_component() on s3c24xx i2s ASoC: switch over to use snd_soc_register_component() on s3c i2s ASoC: switch over to use snd_soc_register_component() on s3c ac97 ASoC: switch over to use snd_soc_register_component() on samsung spdif ASoC: switch over to use snd_soc_register_component() on samsung i2s ASoC: switch over to use snd_soc_register_component() on samsung pcm ASoC: switch over to use snd_soc_register_component() on goni_wm8994 ASoC: switch over to use snd_soc_register_component() on sh4 ssi ASoC: switch over to use snd_soc_register_component() on sh4 hac ASoC: switch over to use snd_soc_register_component() on spear spdif out ASoC: switch over to use snd_soc_register_component() on spear spdif in ASoC: switch over to use snd_soc_register_component() on tegra30 i2s ASoC: switch over to use snd_soc_register_component() on tegra20 spdif ASoC: switch over to use snd_soc_register_component() on tegra20 ac97 ASoC: switch over to use snd_soc_register_component() on tegra20 i2s ASoC: switch over to use snd_soc_register_component() on txx9aclc ac97 ASoC: switch over to use snd_soc_register_component() on ux500 msp ASoC: snd_soc_[un]register_dai[s]() become non global function ASoC: switch over to use snd_soc_register_component() on sh4 siu Lars-Peter Clausen (28): ASoC: core: Drop unused "dapm" field form soc_enum struct ASoC: core: Remove unused "n_widgets" field from snd_soc_dapm struct ASoC: spear_pcm: Staticize non-exported structs ASoC: omap: Call omap_mcbsp_set_threshold() from mcbsp hw_params ASoC: ux500_pcm: Remove duplicated SNDRV_PCM_HW_PARAM_PERIODS constraint ASoC: spear_pcm: No need to wrap snd_dmaengine_pcm_close() ASoC: omap-pcm: No need to wrap snd_dmaengine_pcm_close() ASoC: tegra_pcm: No need to wrap snd_dmaengine_pcm_close() ASoC: ux500_pcm: No need to wrap snd_dmaengine_pcm_close() ASoC: atmel-pcm-dma: No need to wrap snd_dmaengine_pcm_close() ASoC: ux500_pcm: No need to use snd_dmaengine_pcm_set_data() ASoC: speaer_pcm: No need to use snd_dmaengine_pcm_set_data() ASoC: atmel-pcm-dma: Do not use snd_dmaengine_pcm_{set,get}_data() ASoC: ep93xx: Use ep93xx_dma_params instead of ep93xx_pcm_dma_params ASoC: mmp-pcm: Allocate dma filter parameters on the stack ASoC: imx-pcm: Embed the imx_dma_data struct in the dma_params struct ASoC: mxs: Embed the mxs_dma_data struct in the mxs_pcm_dma_params struct ASoC: dmaengine-pcm: Remove snd_dmaengine_pcm_{set,get}_data ASoC: Constify the 'driver' field of snd_soc_platform ASoC: Constify the 'ops' field of snd_soc_platform_driver ASoC: Constify the 'compr_ops' field of snd_soc_platform_driver ASoC: dmaengine_pcm: Setup device_fc in snd_hwparams_to_dma_slave_config ASoC: dmaengine-pcm: Add a common DAI DMA data struct ASoC: omap: Use common DAI DMA data ASoC: tegra: Use common DAI DMA data struct ASoC: fsl: Use common DAI DMA data struct ASoC: ep93xx_pcm: Fix compile error ASoC: ux500_pcm: Use the same snd_pcm_hardware for playback and capture Mark Brown (72): ASoC: arizona: Only allow input volume updates when inputs are enabled ASoC: wm8960: Add input boost volume control ASoC: omap: Check regulator enable for DAC on Pandora ASoC: arizona: If we only have a clock to synchronise with make it REFCLK mfd: arizona: Define additional FLL control registers mfd: wm5102: Map in additional FLL control registers ASoC: arizona: Increase FLL synchroniser bandwidth for high frequencies ASoC: arizona: Optimise FLL loop gains ASoC: arizona: Ensure synchroniser is disabled when not needed ASoC: arizona: Suppress reference calculations when setting REFCLK to 0 Merge tag 'v3.9-rc2' into asoc-core ASoC: arizona: Provide defines for the clock rates ASoC: wm_adsp: Handle old .bin files ASoC: arizona: Ensure we clock two channels for I2S mode ASoC: wm8994: Support constraining the maximum number of channels clocked mfd: wm5102: Add additional speaker control registers ASoC: arizona: Factor out speaker widgets from CODEC drivers ASoC: arizona: Log thermal events ASoC: arizona: Suppress speaker enable if thermal shutdown is flagged ASoC: arizona: Basic support for ISRC rate selection ASoC: wm8994: Restore AIFnCLK after reducing it for low clock rates extcon: arizona: Factor out magic application ASoC: arizona: Fix interaction between headphone outputs and identification extcon: arizona: Fix interaction between headphone outputs and identification Merge tag 'arizona-extcon-asoc' of git://git.kernel.org/.../broonie/misc into asoc-arizona ASoC: arizona: Add delay after powering up line level outputs Merge branch 'topic/pxa' of git://git.kernel.org/.../broonie/sound into asoc-component ASoC: wm5102: Implement OSR support ASoC: wm2000: Expose some more registers for diagnostics ASoC: wm_adsp: Provide defines for firmwares ASoC: wm_adsp: Split ADSP1 and ADSP2 firmware controls Merge branch 'topic/omap' of git://git.kernel.org/.../broonie/sound into HEAD Merge branch 'fix/samsung' of git://git.kernel.org/.../broonie/sound into asoc-samsung ASoC: core: Merge Samsung fixes to avoid trivial context conflict ASoC: wm8994: Remove duplicate revision cache ASoC: wm_adsp: Add support for firmware wide coefficient blocks Merge remote-tracking branch 'asoc/fix/compress' into asoc-next Merge remote-tracking branch 'asoc/fix/core' into asoc-next Merge remote-tracking branch 'asoc/fix/samsung' into asoc-next Merge remote-tracking branch 'asoc/fix/tegra' into asoc-next Merge remote-tracking branch 'asoc/fix/wm8903' into asoc-next Merge remote-tracking branch 'asoc/topic/adau1373' into asoc-next Merge remote-tracking branch 'asoc/topic/adsp' into asoc-next Merge remote-tracking branch 'asoc/topic/ak4104' into asoc-next Merge remote-tracking branch 'asoc/topic/ak5386' into asoc-next Merge remote-tracking branch 'asoc/topic/arizona' into asoc-next Merge remote-tracking branch 'asoc/topic/atmel' into asoc-next Merge remote-tracking branch 'asoc/topic/component' into asoc-next Merge remote-tracking branch 'asoc/topic/compress' into asoc-next Merge remote-tracking branch 'asoc/topic/core' into asoc-next Merge remote-tracking branch 'asoc/topic/cs4271' into asoc-next Merge remote-tracking branch 'asoc/topic/cs42l73' into asoc-next Merge remote-tracking branch 'asoc/topic/dapm' into asoc-next Merge remote-tracking branch 'asoc/topic/davinci' into asoc-next Merge remote-tracking branch 'asoc/topic/dma' into asoc-next Merge remote-tracking branch 'asoc/topic/fsi' into asoc-next Merge remote-tracking branch 'asoc/topic/fsl' into asoc-next Merge remote-tracking branch 'asoc/topic/maintainers' into asoc-next Merge remote-tracking branch 'asoc/topic/max98088' into asoc-next Merge remote-tracking branch 'asoc/topic/max98090' into asoc-next Merge remote-tracking branch 'asoc/topic/samsung' into asoc-next Merge remote-tracking branch 'asoc/topic/si476x' into asoc-next Merge remote-tracking branch 'asoc/topic/spear' into asoc-next Merge remote-tracking branch 'asoc/topic/tas5086' into asoc-next Merge remote-tracking branch 'asoc/topic/tegra' into asoc-next Merge remote-tracking branch 'asoc/topic/ux500' into asoc-next Merge remote-tracking branch 'asoc/topic/wm-hubs' into asoc-next Merge remote-tracking branch 'asoc/topic/wm0010' into asoc-next Merge remote-tracking branch 'asoc/topic/wm2000' into asoc-next Merge remote-tracking branch 'asoc/topic/wm8903' into asoc-next Merge remote-tracking branch 'asoc/topic/wm8960' into asoc-next Merge remote-tracking branch 'asoc/topic/wm8994' into asoc-next Michal Bachraty (1): ASoC: davinci-mcasp: Add support for multichannel playback Paul Bolle (3): ASoC: samsung: remove last traces of neo1973-gta01 ASoC: codecs: remove hidden prompt ASoC: Ux500: remove test for undefined Kconfig macro Paul Handrigan (1): ASoC: cs42l73: If Internal MCLK is >= 6.4MHz, then set SCLK to 64*Fs. Peter Ujfalusi (4): ASoC: omap3pandora: Fix compilation error ASoC: omap-mcpdm: Collect link direction configuration under a struct ASoC: omap-mcpdm: Fix for full duplex audio use case ASoC: omap-mcpdm: Remove leftower define for IO address Ryo Tsutsui (2): ASoC: dapm: Remove redundant clear_walk() for supply widgets ASoC: dapm: Only clear paths we've walked Sachin Kamat (5): ASoC: max98090: Remove unneeded version.h header include ASoC: max98090: Convert to devm_regmap_init_i2c() ASoC: max98090: Make struct dev_pm_ops const ASoC: max98090: Fix checkpatch errors related to spacing ASoC: max98090: Remove unnecessary braces Sascha Hauer (1): ASoC: imx-ssi: Fix AC97 rates Sebastien Guiriec (2): ASoC: omap-mcpdm: Clean up with devm_* function ASoC: omap-dmic: Clean up with devm_request_and_ioremap Shawn Guo (1): ASoC: imx-sgtl5000: use of_node to match cpu dai Silviu-Mihai Popescu (1): ASoC: omap: convert to devm_ioremap_resource() Stephen Warren (10): ASoC: tegra: assume CONFIG_OF in tegra_asoc_utils_init ASoC: tegra_wm8753: minor cleanup ASoC: tegra_wm9712: assume CONFIG_OF ASoC: tegra_alc5632: assume CONFIG_OF, and other cleanup ASoC: tegra trimslice: assume CONFIG_OF, and other cleanup ASoC: tegra_wm8903: assume CONFIG_OF, remove platform data ASoC: tegra: add Tegra114 support to the AHUB driver ASoC: tegra: add Tegra114 support to tegra_asoc_utils.c ASoC: export snd_soc_register_component ASoC: dapm: Implement mixer control sharing Tim Gardner (2): ASoC: adau1373: adau1373_hw_params: Silence overflow warning ASoC: wm_hubs: Silence reg_r and reg_l 'may be used uninitialized' warnings Vinod Koul (1): ASoC: mid-x86 - add support for meaadata apis Wei Yongjun (2): ASoC: tas5086: use module_i2c_driver to simplify the code ASoC: arizona: remove duplicated include from arizona.c Yegor Yefremov (2): ASoC: davinci-mcasp: don't configure AFSX direction in DIT mode ASoC: davinci-mcasp: don't overwrite DIT settings Zoltan Puskas (1): ASoC: atmel: Add slave mode support to SSC in DSP Mode A Documentation/devicetree/bindings/sound/ak5386.txt | 19 + .../bindings/sound/nvidia,tegra30-ahub.txt | 26 +- .../devicetree/bindings/sound/ti,tas5086.txt | 32 ++ arch/arm/mach-s3c24xx/dma-s3c2410.c | 2 - arch/arm/mach-s3c24xx/dma-s3c2412.c | 2 - arch/arm/mach-s3c24xx/dma-s3c2440.c | 2 - arch/arm/mach-s3c24xx/dma-s3c2443.c | 2 - arch/arm/plat-samsung/devs.c | 6 + drivers/extcon/extcon-arizona.c | 107 ++-- drivers/mfd/wm5102-tables.c | 10 + include/linux/mfd/arizona/core.h | 3 + include/linux/mfd/arizona/registers.h | 42 ++ include/linux/mfd/wm8994/pdata.h | 8 + include/sound/dmaengine_pcm.h | 27 +- include/sound/soc-dai.h | 8 - include/sound/soc-dapm.h | 1 - include/sound/soc.h | 29 +- include/sound/tas5086.h | 7 + include/sound/tegra_wm8903.h | 26 - sound/soc/atmel/atmel-pcm-dma.c | 25 +- sound/soc/atmel/atmel_ssc_dai.c | 54 +- sound/soc/au1x/ac97c.c | 9 +- sound/soc/au1x/i2sc.c | 9 +- sound/soc/au1x/psc-ac97.c | 9 +- sound/soc/au1x/psc-i2s.c | 9 +- sound/soc/blackfin/bf5xx-ac97.c | 9 +- sound/soc/blackfin/bf5xx-i2s.c | 9 +- sound/soc/blackfin/bf5xx-tdm.c | 9 +- sound/soc/blackfin/bf6xx-i2s.c | 9 +- sound/soc/cirrus/edb93xx.c | 1 - sound/soc/cirrus/ep93xx-ac97.c | 18 +- sound/soc/cirrus/ep93xx-i2s.c | 25 +- sound/soc/cirrus/ep93xx-pcm.c | 37 +- sound/soc/cirrus/ep93xx-pcm.h | 20 - sound/soc/cirrus/simone.c | 2 - sound/soc/cirrus/snappercl15.c | 1 - sound/soc/codecs/Kconfig | 10 +- sound/soc/codecs/Makefile | 4 + sound/soc/codecs/adau1373.c | 5 +- sound/soc/codecs/ak4104.c | 55 +- sound/soc/codecs/ak5386.c | 152 +++++ sound/soc/codecs/arizona.c | 530 +++++++++++++++--- sound/soc/codecs/arizona.h | 34 +- sound/soc/codecs/cs4271.c | 166 +++--- sound/soc/codecs/cs42l73.c | 6 +- sound/soc/codecs/max98088.c | 30 +- sound/soc/codecs/max98090.c | 45 +- sound/soc/codecs/si476x.c | 47 +- sound/soc/codecs/tas5086.c | 591 ++++++++++++++++++++ sound/soc/codecs/wm0010.c | 6 +- sound/soc/codecs/wm2000.c | 4 +- sound/soc/codecs/wm2000.h | 2 + sound/soc/codecs/wm2200.c | 2 +- sound/soc/codecs/wm5102.c | 131 ++--- sound/soc/codecs/wm5102.h | 6 +- sound/soc/codecs/wm5110.c | 54 +- sound/soc/codecs/wm5110.h | 6 +- sound/soc/codecs/wm8903.c | 6 + sound/soc/codecs/wm8960.c | 10 + sound/soc/codecs/wm8994.c | 68 ++- sound/soc/codecs/wm8994.h | 3 +- sound/soc/codecs/wm_adsp.c | 124 +++- sound/soc/codecs/wm_adsp.h | 5 +- sound/soc/codecs/wm_hubs.c | 9 +- sound/soc/davinci/davinci-i2s.c | 15 +- sound/soc/davinci/davinci-mcasp.c | 97 +++- sound/soc/davinci/davinci-pcm.c | 16 +- sound/soc/davinci/davinci-pcm.h | 1 + sound/soc/davinci/davinci-vcif.c | 11 +- sound/soc/dwc/designware_i2s.c | 9 +- sound/soc/fsl/fsl_ssi.c | 45 +- sound/soc/fsl/imx-audmux.c | 3 +- sound/soc/fsl/imx-pcm-dma.c | 58 +- sound/soc/fsl/imx-pcm-fiq.c | 6 +- sound/soc/fsl/imx-pcm.h | 19 +- sound/soc/fsl/imx-sgtl5000.c | 2 +- sound/soc/fsl/imx-ssi.c | 42 +- sound/soc/fsl/imx-ssi.h | 7 +- sound/soc/fsl/mpc5200_psc_ac97.c | 8 +- sound/soc/fsl/mpc5200_psc_i2s.c | 9 +- sound/soc/jz4740/jz4740-i2s.c | 9 +- sound/soc/kirkwood/kirkwood-i2s.c | 11 +- sound/soc/mid-x86/sst_platform.c | 20 +- sound/soc/mid-x86/sst_platform.h | 2 + sound/soc/mxs/mxs-pcm.c | 43 +- sound/soc/mxs/mxs-pcm.h | 4 +- sound/soc/mxs/mxs-saif.c | 17 +- sound/soc/nuc900/nuc900-ac97.c | 9 +- sound/soc/omap/am3517evm.c | 1 - sound/soc/omap/ams-delta.c | 1 - sound/soc/omap/mcbsp.c | 14 +- sound/soc/omap/mcbsp.h | 7 +- sound/soc/omap/n810.c | 1 - sound/soc/omap/omap-abe-twl6040.c | 1 - sound/soc/omap/omap-dmic.c | 47 +- sound/soc/omap/omap-hdmi.c | 33 +- sound/soc/omap/omap-mcbsp.c | 27 +- sound/soc/omap/omap-mcpdm.c | 118 ++-- sound/soc/omap/omap-pcm.c | 83 +-- sound/soc/omap/omap-pcm.h | 40 -- sound/soc/omap/omap-twl4030.c | 1 - sound/soc/omap/omap3pandora.c | 9 +- sound/soc/omap/osk5912.c | 1 - sound/soc/omap/rx51.c | 1 - sound/soc/pxa/mmp-pcm.c | 33 +- sound/soc/pxa/mmp-sspa.c | 9 +- sound/soc/pxa/pxa-ssp.c | 9 +- sound/soc/pxa/pxa2xx-ac97.c | 11 +- sound/soc/pxa/pxa2xx-i2s.c | 9 +- sound/soc/s6000/s6000-i2s.c | 9 +- sound/soc/samsung/Kconfig | 5 +- sound/soc/samsung/ac97.c | 14 +- sound/soc/samsung/goni_wm8994.c | 11 +- sound/soc/samsung/h1940_uda1380.c | 2 +- sound/soc/samsung/i2s.c | 33 +- sound/soc/samsung/idma.c | 11 +- sound/soc/samsung/neo1973_wm8753.c | 3 +- sound/soc/samsung/pcm.c | 11 +- .../include/plat => sound/soc/samsung}/regs-ac97.h | 0 .../include/plat => sound/soc/samsung}/regs-iis.h | 0 sound/soc/samsung/rx1950_uda1380.c | 2 +- sound/soc/samsung/s3c-i2s-v2.c | 9 +- sound/soc/samsung/s3c-i2s-v2.h | 7 +- sound/soc/samsung/s3c2412-i2s.c | 12 +- sound/soc/samsung/s3c24xx-i2s.c | 13 +- sound/soc/samsung/s3c24xx_uda134x.c | 2 +- sound/soc/samsung/spdif.c | 11 +- sound/soc/sh/fsi.c | 14 +- sound/soc/sh/hac.c | 10 +- sound/soc/sh/migor.c | 2 +- sound/soc/sh/siu_dai.c | 11 +- sound/soc/sh/ssi.c | 10 +- sound/soc/soc-compress.c | 41 +- sound/soc/soc-core.c | 130 ++++- sound/soc/soc-dapm.c | 320 ++++++----- sound/soc/soc-dmaengine-pcm.c | 68 ++- sound/soc/soc-io.c | 5 +- sound/soc/spear/spdif_in.c | 9 +- sound/soc/spear/spdif_out.c | 9 +- sound/soc/spear/spear_pcm.c | 22 +- sound/soc/tegra/tegra20_ac97.c | 28 +- sound/soc/tegra/tegra20_ac97.h | 4 +- sound/soc/tegra/tegra20_i2s.c | 28 +- sound/soc/tegra/tegra20_i2s.h | 4 +- sound/soc/tegra/tegra20_spdif.c | 22 +- sound/soc/tegra/tegra20_spdif.h | 4 +- sound/soc/tegra/tegra30_ahub.c | 72 ++- sound/soc/tegra/tegra30_ahub.h | 24 +- sound/soc/tegra/tegra30_i2s.c | 28 +- sound/soc/tegra/tegra30_i2s.h | 4 +- sound/soc/tegra/tegra_alc5632.c | 15 +- sound/soc/tegra/tegra_asoc_utils.c | 34 +- sound/soc/tegra/tegra_asoc_utils.h | 1 + sound/soc/tegra/tegra_pcm.c | 48 +- sound/soc/tegra/tegra_pcm.h | 7 - sound/soc/tegra/tegra_wm8753.c | 15 +- sound/soc/tegra/tegra_wm8903.c | 179 +++--- sound/soc/tegra/tegra_wm9712.c | 7 +- sound/soc/tegra/trimslice.c | 56 +- sound/soc/txx9/txx9aclc-ac97.c | 9 +- sound/soc/ux500/ux500_msp_dai.c | 13 +- sound/soc/ux500/ux500_msp_dai.h | 5 - sound/soc/ux500/ux500_pcm.c | 76 +-- sound/soc/ux500/ux500_pcm.h | 14 - 164 files changed, 3437 insertions(+), 1710 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/ak5386.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,tas5086.txt create mode 100644 include/sound/tas5086.h delete mode 100644 include/sound/tegra_wm8903.h delete mode 100644 sound/soc/cirrus/ep93xx-pcm.h create mode 100644 sound/soc/codecs/ak5386.c create mode 100644 sound/soc/codecs/tas5086.c delete mode 100644 sound/soc/omap/omap-pcm.h rename {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-ac97.h (100%) rename {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-iis.h (100%)

2 1

[alsa-devel] [PATCH] ALSA: hda - Fix headset mic support for Asus X101CH
by David Henningsson 15 Apr '13

15 Apr '13

With this patch, a TRRS headset mic cannot be successfully detected on the Asus X101CH, and we can also distinguish between headphone and headset automatically. Buglink: https://bugs.launchpad.net/bugs/1169138 Co-authored-by: Kailang <kailang(a)realtek.com> Tested-by: Luis Henriques <luis.henriques(a)canonical.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- Now that we have better headset mic support infrastructure, I remembered I forgot to upstream this patch. It was originally provided by Realtek (therefore, I cannot answer for the msleeps and exactly why this is needed). I just rewrote it for the current kernel version. sound/pci/hda/patch_realtek.c | 56 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6cf27f5..1b7aed5 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2680,6 +2680,34 @@ static void alc269_fixup_quanta_mute(struct hda_codec *codec, spec->gen.automute_hook = alc269_quanta_automute; } +static void alc269_x101_hp_automute_hook(struct hda_codec *codec, + struct hda_jack_tbl *jack) +{ + struct alc_spec *spec = codec->spec; + int vref; + msleep(200); + snd_hda_gen_hp_automute(codec, jack); + + vref = spec->gen.hp_jack_present ? PIN_VREF80 : 0; + msleep(100); + snd_hda_codec_write(codec, 0x18, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, + vref); + msleep(500); + snd_hda_codec_write(codec, 0x18, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, + vref); +} + +static void alc269_fixup_x101_headset_mic(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; + spec->gen.hp_automute_hook = alc269_x101_hp_automute_hook; + } +} + + /* update mute-LED according to the speaker mute state via mic VREF pin */ static void alc269_fixup_mic_mute_hook(void *private_data, int enabled) { @@ -2837,6 +2865,9 @@ enum { ALC269_FIXUP_INV_DMIC, ALC269_FIXUP_LENOVO_DOCK, ALC269_FIXUP_PINCFG_NO_HP_TO_LINEOUT, + ALC269_FIXUP_ASUS_X101_FUNC, + ALC269_FIXUP_ASUS_X101_VERB, + ALC269_FIXUP_ASUS_X101, ALC271_FIXUP_AMIC_MIC2, ALC271_FIXUP_HP_GATE_MIC_JACK, ALC269_FIXUP_ACER_AC700, @@ -2996,6 +3027,30 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc269_fixup_pincfg_no_hp_to_lineout, }, + [ALC269_FIXUP_ASUS_X101_FUNC] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc269_fixup_x101_headset_mic, + }, + [ALC269_FIXUP_ASUS_X101_VERB] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + {0x18, AC_VERB_SET_PIN_WIDGET_CONTROL, 0}, + {0x20, AC_VERB_SET_COEF_INDEX, 0x08}, + {0x20, AC_VERB_SET_PROC_COEF, 0x0310}, + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_ASUS_X101_FUNC + }, + [ALC269_FIXUP_ASUS_X101] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x18, 0x04a1182c }, /* Headset mic */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_ASUS_X101_VERB + }, [ALC271_FIXUP_AMIC_MIC2] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -3044,6 +3099,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC), + SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101), SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2), SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ), SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ), -- 1.7.9.5

2 2

[alsa-devel] [PATCH v2 00/11] ASoC: fsl-ssi: ac97-slave support
by Markus Pargmann 15 Apr '13

15 Apr '13

Hi, This series adds DT support for phycore-ac97 using the fsl-ssi driver. In version 2 I discarded most of the imx-ssi work and integrated the ac97-slave support in fsl-ssi, including support for imx-pcm-fiq as alternative to dma. There are some other changes to get phycore-ac97 working. The first two patches have notes about the detailed changes since version 1. The rest of the patches is new and necessary for the ac97-slave support. Regards, Markus Markus Pargmann (11): ASoC: phycore-ac97: Add DT support ASoC: imx-pcm-dma: Add support for DMA init by ASoC: imx-pcm-fiq: Introduce pcm-fiq-params ASoC: fsl-ssi: Add SACNT definitions ASoC: fsl-ssi: Add support for imx-pcm-fiq ASoC: fsl-ssi: Setup generic imx dma params ARM: imx: Export ac97 reset functions ASoC: fsl-ssi: imx ac97 support ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 ASoC: fsl: Move fsl-ssi binding doc to sound/ ASoC: fsl: Update fsl-ssi binding doc Documentation/devicetree/bindings/powerpc/fsl/ssi.txt | 73 - Documentation/devicetree/bindings/sound/fsl,ssi.txt | 13 b/Documentation/devicetree/bindings/sound/fsl,ssi.txt | 73 + b/Documentation/devicetree/bindings/sound/phytec,phycore-ac97.txt | 12 b/arch/arm/mach-imx/mach-pca100.c | 7 b/arch/arm/mach-imx/mach-pcm043.c | 7 b/sound/soc/fsl/Kconfig | 2 b/sound/soc/fsl/fsl_ssi.c | 70 + b/sound/soc/fsl/fsl_ssi.h | 8 b/sound/soc/fsl/imx-pcm-dma.c | 31 b/sound/soc/fsl/imx-pcm-fiq.c | 14 b/sound/soc/fsl/imx-pcm.h | 6 b/sound/soc/fsl/imx-ssi.c | 7 b/sound/soc/fsl/imx-ssi.h | 1 b/sound/soc/fsl/phycore-ac97.c | 185 ++++ sound/soc/fsl/fsl_ssi.c | 379 +++++++--- sound/soc/fsl/imx-pcm.h | 9 17 files changed, 664 insertions(+), 233 deletions(-)

4 34

[alsa-devel] Stupid question #1 of many -- unit test harness?
by TJ Olaes 15 Apr '13

15 Apr '13

Hi. So, I'm attempting to write the driver for the eClaro card for a couple of reasons, one of which is that I currently don't have sound on mine. So... is there some kind of test harness framework for new drivers? I have no prior idea how to move forward to build this thing, so I'm snooping around in the oxygen source files and trying to copy things that look like they make sense. For instance, I noted that there's mention of an "AK4396" related to output. I assume this is some kind of chip, and I saw in the Claro code that something called "ak4396_init(...)" is called, so I just copied that line and pasted it into the eclaro_init(...) function I'm writing. I have no idea how I'm going to test this short of just compiling the kernel and booting into it. I feel like that's the brute-force, non-smart way to do it, and that you guys who've been doing this for a while might have ideas and recommendations on how to better test my code so I'm not rebooting my machine each time I change a line and recompile. I'd appreciate your guidance, community. Thanks. -TJ

2 1

[alsa-devel] [PATCH] ALSA: usb-audio: disable autopm for MIDI devices
by Clemens Ladisch 15 Apr '13

15 Apr '13

Commit 88a8516a2128 (ALSA: usbaudio: implement USB autosuspend) introduced autopm for all USB audio/MIDI devices. However, many MIDI devices, such as synthesizers, do not merely transmit MIDI messages but use their MIDI inputs to control other functions. With autopm, these devices would get powered down as soon as the last MIDI port device is closed on the host. Even some plain MIDI interfaces could get broken: they automatically send Active Sensing messages while powered up, but as soon as these messages cease, the receiving device would interpret this as an accidental disconnection. Commit f5f165418cab (ALSA: usb-audio: Fix missing autopm for MIDI input) introduced another regression: some devices (e.g. the Roland GAIA SH-01) are self-powered but do a reset whenever the USB interface's power state changes. To work around all this, just disable autopm for all USB MIDI devices. Reported-by: Laurens Holst Cc: <stable(a)vger.kernel.org> Signed-off-by: Clemens Ladisch <clemens(a)ladisch.de> --- sound/usb/midi.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index 34b9bb7..e5fee18 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -126,7 +126,6 @@ struct snd_usb_midi { struct snd_usb_midi_in_endpoint *in; } endpoints[MIDI_MAX_ENDPOINTS]; unsigned long input_triggered; - bool autopm_reference; unsigned int opened[2]; unsigned char disconnected; unsigned char input_running; @@ -1040,7 +1039,6 @@ static int substream_open(struct snd_rawmidi_substream *substream, int dir, { struct snd_usb_midi* umidi = substream->rmidi->private_data; struct snd_kcontrol *ctl; - int err; down_read(&umidi->disc_rwsem); if (umidi->disconnected) { @@ -1051,13 +1049,6 @@ static int substream_open(struct snd_rawmidi_substream *substream, int dir, mutex_lock(&umidi->mutex); if (open) { if (!umidi->opened[0] && !umidi->opened[1]) { - err = usb_autopm_get_interface(umidi->iface); - umidi->autopm_reference = err >= 0; - if (err < 0 && err != -EACCES) { - mutex_unlock(&umidi->mutex); - up_read(&umidi->disc_rwsem); - return -EIO; - } if (umidi->roland_load_ctl) { ctl = umidi->roland_load_ctl; ctl->vd[0].access |= SNDRV_CTL_ELEM_ACCESS_INACTIVE; @@ -1080,8 +1071,6 @@ static int substream_open(struct snd_rawmidi_substream *substream, int dir, snd_ctl_notify(umidi->card, SNDRV_CTL_EVENT_MASK_INFO, &ctl->id); } - if (umidi->autopm_reference) - usb_autopm_put_interface(umidi->iface); } } mutex_unlock(&umidi->mutex); @@ -2256,6 +2245,8 @@ int snd_usbmidi_create(struct snd_card *card, return err; } + usb_autopm_get_interface_no_resume(umidi->iface); + list_add_tail(&umidi->list, midi_list); return 0; }

2 1

[alsa-devel] [PATCH] ALSA: hda - Implement headset jack functionality for some Dell hw
by David Henningsson 15 Apr '13

15 Apr '13

On some machines, there is a headset jack that can support both headphone, headsets (of both CTIA and OMTP type) and mic-in. On other machines, the headset jack supports headphone, headsets (both CTIA and OMTP), but not mic-in. This patch implements that functionality as different capture sources. Buglink: https://bugs.launchpad.net/bugs/1169143 Tested-by: David Chen <david.chen(a)canonical.com> Co-authored-by: Kailang <kailang(a)realtek.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 386 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 386 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6cf27f5..f3307eb 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -52,6 +52,20 @@ enum { ALC_INIT_GPIO3, }; +enum { + ALC_HEADSET_MODE_UNKNOWN, + ALC_HEADSET_MODE_UNPLUGGED, + ALC_HEADSET_MODE_HEADSET, + ALC_HEADSET_MODE_MIC, + ALC_HEADSET_MODE_HEADPHONE, +}; + +enum { + ALC_HEADSET_TYPE_UNKNOWN, + ALC_HEADSET_TYPE_CTIA, + ALC_HEADSET_TYPE_OMTP, +}; + struct alc_customize_define { unsigned int sku_cfg; unsigned char port_connectivity; @@ -87,6 +101,11 @@ struct alc_spec { unsigned int gpio_led; /* used for alc269_fixup_hp_gpio_led() */ + hda_nid_t headset_mic_pin; + hda_nid_t headphone_mic_pin; + int current_headset_mode; + int current_headset_type; + /* hooks */ void (*init_hook)(struct hda_codec *codec); #ifdef CONFIG_PM @@ -2798,6 +2817,302 @@ static void alc269_fixup_hp_gpio_led(struct hda_codec *codec, } } +static void alc_headset_mode_unplugged(struct hda_codec *codec) +{ + int val; + + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x1b, 0x0c0b); + alc_write_coef_idx(codec, 0x45, 0xc429); + val = alc_read_coef_idx(codec, 0x35); + alc_write_coef_idx(codec, 0x35, val & 0xbfff); + alc_write_coef_idx(codec, 0x06, 0x2104); + alc_write_coef_idx(codec, 0x1a, 0x0001); + alc_write_coef_idx(codec, 0x26, 0x0004); + alc_write_coef_idx(codec, 0x32, 0x42a3); + break; + case 0x10ec0292: + alc_write_coef_idx(codec, 0x76, 0x000e); + alc_write_coef_idx(codec, 0x6c, 0x2400); + alc_write_coef_idx(codec, 0x18, 0x7308); + alc_write_coef_idx(codec, 0x6b, 0xc429); + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x15, 0x0d40); + alc_write_coef_idx(codec, 0xb7, 0x802b); + break; + } + snd_printdd("Headset jack set to unplugged mode.\n"); +} + + +static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin, + hda_nid_t mic_pin) +{ + int val; + + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x45, 0xc429); + snd_hda_set_pin_ctl_cache(codec, hp_pin, 0); + val = alc_read_coef_idx(codec, 0x35); + alc_write_coef_idx(codec, 0x35, val | 1<<14); + alc_write_coef_idx(codec, 0x06, 0x2100); + alc_write_coef_idx(codec, 0x1a, 0x0021); + alc_write_coef_idx(codec, 0x26, 0x008c); + snd_hda_set_pin_ctl_cache(codec, mic_pin, PIN_VREF50); + break; + case 0x10ec0292: + snd_hda_set_pin_ctl_cache(codec, hp_pin, 0); + alc_write_coef_idx(codec, 0x19, 0xa208); + alc_write_coef_idx(codec, 0x2e, 0xacf0); + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x11, 0x0001); + snd_hda_set_pin_ctl_cache(codec, hp_pin, 0); + alc_write_coef_idx(codec, 0xb7, 0x802b); + alc_write_coef_idx(codec, 0xb5, 0x1040); + val = alc_read_coef_idx(codec, 0xc3); + alc_write_coef_idx(codec, 0xc3, val | 1<<12); + snd_hda_set_pin_ctl_cache(codec, mic_pin, PIN_VREF50); + break; + } + snd_printdd("Headset jack set to mic-in mode.\n"); +} + +static void alc_headset_mode_default(struct hda_codec *codec) +{ + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x06, 0x2100); + alc_write_coef_idx(codec, 0x32, 0x4ea3); + break; + case 0x10ec0292: + alc_write_coef_idx(codec, 0x76, 0x000e); + alc_write_coef_idx(codec, 0x6c, 0x2400); + alc_write_coef_idx(codec, 0x6b, 0xc429); + alc_write_coef_idx(codec, 0x18, 0x7308); + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x11, 0x0041); + alc_write_coef_idx(codec, 0x15, 0x0d40); + alc_write_coef_idx(codec, 0xb7, 0x802b); + break; + } + snd_printdd("Headset jack set to headphone (default) mode.\n"); +} + +/* Iphone type */ +static void alc_headset_mode_ctia(struct hda_codec *codec) +{ + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x45, 0xd429); + alc_write_coef_idx(codec, 0x1b, 0x0c2b); + alc_write_coef_idx(codec, 0x32, 0x4ea3); + break; + case 0x10ec0292: + alc_write_coef_idx(codec, 0x6b, 0xd429); + alc_write_coef_idx(codec, 0x76, 0x0008); + alc_write_coef_idx(codec, 0x18, 0x7388); + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x15, 0x0d60); + alc_write_coef_idx(codec, 0xc3, 0x0000); + break; + } + snd_printdd("Headset jack set to iPhone-style headset mode.\n"); +} + +/* Nokia type */ +static void alc_headset_mode_omtp(struct hda_codec *codec) +{ + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x45, 0xe429); + alc_write_coef_idx(codec, 0x1b, 0x0c2b); + alc_write_coef_idx(codec, 0x32, 0x4ea3); + break; + case 0x10ec0292: + alc_write_coef_idx(codec, 0x6b, 0xe429); + alc_write_coef_idx(codec, 0x76, 0x0008); + alc_write_coef_idx(codec, 0x18, 0x7388); + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x15, 0x0d50); + alc_write_coef_idx(codec, 0xc3, 0x0000); + break; + } + snd_printdd("Headset jack set to Nokia-style headset mode.\n"); +} + +static void alc_determine_headset_type(struct hda_codec *codec) +{ + int val; + bool is_ctia = false; + struct alc_spec *spec = codec->spec; + + switch (codec->vendor_id) { + case 0x10ec0283: + alc_write_coef_idx(codec, 0x45, 0xd029); + msleep(300); + val = alc_read_coef_idx(codec, 0x46); + is_ctia = (val & 0x0070) == 0x0070; + break; + case 0x10ec0292: + alc_write_coef_idx(codec, 0x6b, 0xd429); + msleep(300); + val = alc_read_coef_idx(codec, 0x6c); + is_ctia = (val & 0x001c) == 0x001c; + break; + case 0x10ec0668: + alc_write_coef_idx(codec, 0x11, 0x0001); + alc_write_coef_idx(codec, 0xb7, 0x802b); + alc_write_coef_idx(codec, 0x15, 0x0d60); + alc_write_coef_idx(codec, 0xc3, 0x0c00); + msleep(300); + val = alc_read_coef_idx(codec, 0xbe); + is_ctia = (val & 0x1c02) == 0x1c02; + break; + } + + snd_printdd("Headset jack detected iPhone-style headset: %s\n", + is_ctia ? "yes" : "no"); + spec->current_headset_type = is_ctia ? ALC_HEADSET_TYPE_CTIA : ALC_HEADSET_TYPE_OMTP; +} + +static void alc_update_headset_mode(struct hda_codec *codec) +{ + struct alc_spec *spec = codec->spec; + + hda_nid_t mux_pin = spec->gen.imux_pins[spec->gen.cur_mux[0]]; + hda_nid_t hp_pin = spec->gen.autocfg.hp_pins[0]; + + int new_headset_mode; + + if (!snd_hda_jack_detect(codec, hp_pin)) + new_headset_mode = ALC_HEADSET_MODE_UNPLUGGED; + else if (mux_pin == spec->headset_mic_pin) + new_headset_mode = ALC_HEADSET_MODE_HEADSET; + else if (mux_pin == spec->headphone_mic_pin) + new_headset_mode = ALC_HEADSET_MODE_MIC; + else + new_headset_mode = ALC_HEADSET_MODE_HEADPHONE; + + if (new_headset_mode == spec->current_headset_mode) + return; + + switch (new_headset_mode) { + case ALC_HEADSET_MODE_UNPLUGGED: + alc_headset_mode_unplugged(codec); + spec->gen.hp_jack_present = false; + break; + case ALC_HEADSET_MODE_HEADSET: + if (spec->current_headset_type == ALC_HEADSET_TYPE_UNKNOWN) + alc_determine_headset_type(codec); + if (spec->current_headset_type == ALC_HEADSET_TYPE_CTIA) + alc_headset_mode_ctia(codec); + else if (spec->current_headset_type == ALC_HEADSET_TYPE_OMTP) + alc_headset_mode_omtp(codec); + spec->gen.hp_jack_present = true; + break; + case ALC_HEADSET_MODE_MIC: + alc_headset_mode_mic_in(codec, hp_pin, spec->headphone_mic_pin); + spec->gen.hp_jack_present = false; + break; + case ALC_HEADSET_MODE_HEADPHONE: + alc_headset_mode_default(codec); + spec->gen.hp_jack_present = true; + break; + } + if (new_headset_mode != ALC_HEADSET_MODE_MIC) { + snd_hda_set_pin_ctl_cache(codec, hp_pin, + AC_PINCTL_OUT_EN | AC_PINCTL_HP_EN); + if (spec->headphone_mic_pin) + snd_hda_set_pin_ctl_cache(codec, spec->headphone_mic_pin, + PIN_VREFHIZ); + } + spec->current_headset_mode = new_headset_mode; + + snd_hda_gen_update_outputs(codec); +} + +static void alc_update_headset_mode_hook(struct hda_codec *codec, + struct snd_ctl_elem_value *ucontrol) +{ + alc_update_headset_mode(codec); +} + +static void alc_update_headset_jack_cb(struct hda_codec *codec, struct hda_jack_tbl *jack) +{ + struct alc_spec *spec = codec->spec; + spec->current_headset_type = ALC_HEADSET_MODE_UNKNOWN; + snd_hda_gen_hp_automute(codec, jack); +} + +static void alc_probe_headset_mode(struct hda_codec *codec) +{ + int i; + struct alc_spec *spec = codec->spec; + struct auto_pin_cfg *cfg = &spec->gen.autocfg; + + /* Find mic pins */ + for (i = 0; i < cfg->num_inputs; i++) { + if (cfg->inputs[i].is_headset_mic && !spec->headset_mic_pin) + spec->headset_mic_pin = cfg->inputs[i].pin; + if (cfg->inputs[i].is_headphone_mic && !spec->headphone_mic_pin) + spec->headphone_mic_pin = cfg->inputs[i].pin; + } + + spec->gen.cap_sync_hook = alc_update_headset_mode_hook; + spec->gen.automute_hook = alc_update_headset_mode; + spec->gen.hp_automute_hook = alc_update_headset_jack_cb; +} + +static void alc_fixup_headset_mode(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->parse_flags |= HDA_PINCFG_HEADSET_MIC | HDA_PINCFG_HEADPHONE_MIC; + break; + case HDA_FIXUP_ACT_PROBE: + alc_probe_headset_mode(codec); + break; + case HDA_FIXUP_ACT_INIT: + spec->current_headset_mode = 0; + alc_update_headset_mode(codec); + break; + } +} + +static void alc_fixup_headset_mode_no_hp_mic(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + struct alc_spec *spec = codec->spec; + spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; + } + else + alc_fixup_headset_mode(codec, fix, action); +} + +static void alc_fixup_headset_mode_alc668(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + int val; + alc_write_coef_idx(codec, 0xc4, 0x8000); + val = alc_read_coef_idx(codec, 0xc2); + alc_write_coef_idx(codec, 0xc2, val & 0xfe); + snd_hda_set_pin_ctl_cache(codec, 0x18, 0); + } + alc_fixup_headset_mode(codec, fix, action); +} + static void alc271_hp_gate_mic_jack(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -2837,6 +3152,10 @@ enum { ALC269_FIXUP_INV_DMIC, ALC269_FIXUP_LENOVO_DOCK, ALC269_FIXUP_PINCFG_NO_HP_TO_LINEOUT, + ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, + ALC269_FIXUP_HEADSET_MODE, + ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC, ALC271_FIXUP_AMIC_MIC2, ALC271_FIXUP_HP_GATE_MIC_JACK, ALC269_FIXUP_ACER_AC700, @@ -2996,6 +3315,35 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc269_fixup_pincfg_no_hp_to_lineout, }, + [ALC269_FIXUP_DELL1_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { 0x1a, 0x01a1913d }, /* use as headphone mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE + }, + [ALC269_FIXUP_DELL2_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x16, 0x21014020 }, /* dock line out */ + { 0x19, 0x21a19030 }, /* dock mic */ + { 0x1a, 0x01a1913c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC + }, + [ALC269_FIXUP_HEADSET_MODE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_headset_mode, + }, + [ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_headset_mode_no_hp_mic, + }, [ALC271_FIXUP_AMIC_MIC2] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -3030,6 +3378,26 @@ static const struct hda_fixup alc269_fixups[] = { static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x029b, "Acer 1810TZ", ALC269_FIXUP_INV_DMIC), SND_PCI_QUIRK(0x1025, 0x0349, "Acer AOD260", ALC269_FIXUP_INV_DMIC), + SND_PCI_QUIRK(0x1028, 0x05bd, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05be, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c4, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c5, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c6, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c7, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c8, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05c9, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05ca, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05cb, "Dell", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05e9, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05ea, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05eb, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05ec, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05ed, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05ee, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05f3, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05f4, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05f5, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05f6, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x1973, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1), @@ -3536,6 +3904,8 @@ enum { ALC662_FIXUP_NO_JACK_DETECT, ALC662_FIXUP_ZOTAC_Z68, ALC662_FIXUP_INV_DMIC, + ALC668_FIXUP_DELL_MIC_NO_PRESENCE, + ALC668_FIXUP_HEADSET_MODE, }; static const struct hda_fixup alc662_fixups[] = { @@ -3696,6 +4066,20 @@ static const struct hda_fixup alc662_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_inv_dmic_0x12, }, + [ALC668_FIXUP_DELL_MIC_NO_PRESENCE] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x19, 0x03a1913d }, /* use as headphone mic, without its own jack detect */ + { 0x1b, 0x03a1113c }, /* use as headset mic, without its own jack detect */ + { } + }, + .chained = true, + .chain_id = ALC668_FIXUP_HEADSET_MODE + }, + [ALC668_FIXUP_HEADSET_MODE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc_fixup_headset_mode_alc668, + }, }; static const struct snd_pci_quirk alc662_fixup_tbl[] = { @@ -3704,6 +4088,8 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x031c, "Gateway NV79", ALC662_FIXUP_SKU_IGNORE), SND_PCI_QUIRK(0x1025, 0x0349, "eMachines eM250", ALC662_FIXUP_INV_DMIC), SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE), + SND_PCI_QUIRK(0x1028, 0x05d8, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x05db, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), SND_PCI_QUIRK(0x1043, 0x8469, "ASUS mobo", ALC662_FIXUP_NO_JACK_DETECT), SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_FIXUP_ASUS_MODE2), -- 1.7.9.5

2 1

[alsa-devel] PROBLEM: iMX6 SSI - set up as a master of external audio codec
by Andrey Gelman 15 Apr '13

15 Apr '13

Hi, everyone ! I'm bringing up a wm8731 audio codec on an iMX6 based board. I use the slave mode, i.e. SSI outputs all the clocks towards the codec IC. I work with 3.0.35 Android kernel provided by freescale. While, generally, the playback is Ok, I face 2 issues: - cannot play back mono streams (too high rate, one speaker produces only noise) - cannot play back streams with sampling rate as low as 8kHz (the sound is accompanied by high distortion) In the mainline kernel (commits to v3.6), there is a workaround to the 1-st issue by simply removing mono support from imx-ssi.c. Similar approach would fix the 2-nd issue as well - SSI would report it does not support 8kHz sampling rate. In a later commit, this workaround has been reverted, enabling mono support back. My question is this: Is this a real limitation of SSI ? Does it support mono playback or not ? Does SSI support 8kHz sampling rate ? If yes, what could be possible reason to the distortions I get, while higher rates are played back well ? Is there a real fix to these issues, or only workarounds are available ? Thanks, Andrey Gelman

1 0

[alsa-devel] [PATCH 20/30] ASoC: samsung: convert to dmaengine API
by Arnd Bergmann 15 Apr '13

15 Apr '13

In order to build the exynos kernel with CONFIG_ARCH_MULTIPLATFORM, we must convert all users of the Samsung private DMA interface to the generic dmaengine API. This version of the patch adds the generic dmaengine API as an alternative to the existing samsung specific one. Once all the older platforms provide support for the common dmaengine interfaces, we can remove the old code. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Cc: alsa-devel(a)alsa-project.org Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> --- sound/soc/samsung/dma.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++ sound/soc/samsung/dma.h | 15 +++- sound/soc/samsung/i2s.c | 2 - sound/soc/samsung/pcm.c | 1 - sound/soc/samsung/spdif.c | 1 - 5 files changed, 232 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c index 21b7926..9fd53df 100644 --- a/sound/soc/samsung/dma.c +++ b/sound/soc/samsung/dma.c @@ -22,8 +22,14 @@ #include <sound/pcm_params.h> #include <asm/dma.h> + +#ifdef CONFIG_SAMSUNG_DMADEV #include <mach/hardware.h> #include <mach/dma.h> +#else +#include <linux/dmaengine.h> +#include <linux/amba/pl330.h> +#endif #include "dma.h" @@ -62,11 +68,13 @@ struct runtime_data { static void audio_buffdone(void *data); +#ifdef CONFIG_SAMSUNG_DMADEV /* dma_enqueue * * place a dma buffer onto the queue for the dma system * to handle. */ + static void dma_enqueue(struct snd_pcm_substream *substream) { struct runtime_data *prtd = substream->runtime->private_data; @@ -265,6 +273,217 @@ static int dma_trigger(struct snd_pcm_substream *substream, int cmd) return ret; } +#else +/* dma_enqueue + * + * place a dma buffer onto the queue for the dma system + * to handle. + */ + +static void dma_enqueue(struct snd_pcm_substream *substream) +{ + struct runtime_data *prtd = substream->runtime->private_data; + dma_addr_t pos = prtd->dma_pos; + unsigned long period = prtd->dma_period; + unsigned int limit; + enum dma_transfer_direction direction; + struct dma_chan *chan = prtd->params->ch; + struct dma_async_tx_descriptor *desc; + + pr_debug("Entered %s\n", __func__); + + limit = (prtd->dma_end - prtd->dma_start) / prtd->dma_period; + + pr_debug("%s: loaded %d, limit %d\n", + __func__, prtd->dma_loaded, limit); + + direction = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK + ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM); + + while (prtd->dma_loaded < limit) { + pr_debug("dma_loaded: %d\n", prtd->dma_loaded); + + if ((pos + period) > prtd->dma_end) { + period = prtd->dma_end - pos; + pr_debug("%s: corrected dma len %ld\n", + __func__, period); + } + + desc = dmaengine_prep_dma_cyclic(chan, pos, + prtd->dma_period*limit, period, direction, + DMA_PREP_INTERRUPT | DMA_CTRL_ACK); + + if (desc) { + desc->callback = audio_buffdone; + desc->callback_param = substream; + dmaengine_submit(desc); + } + + prtd->dma_loaded++; + pos += period; + if (pos >= prtd->dma_end) + pos = prtd->dma_start; + } + + prtd->dma_pos = pos; +} + +static void audio_buffdone(void *data) +{ + struct snd_pcm_substream *substream = data; + struct runtime_data *prtd = substream->runtime->private_data; + + pr_debug("Entered %s\n", __func__); + + if (prtd->state & ST_RUNNING) { + prtd->dma_pos += prtd->dma_period; + if (prtd->dma_pos >= prtd->dma_end) + prtd->dma_pos = prtd->dma_start; + + if (substream) + snd_pcm_period_elapsed(substream); + } +} + +static int dma_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params) +{ + struct snd_pcm_runtime *runtime = substream->runtime; + struct runtime_data *prtd = runtime->private_data; + struct snd_soc_pcm_runtime *rtd = substream->private_data; + unsigned long totbytes = params_buffer_bytes(params); + struct s3c_dma_params *dma = + snd_soc_dai_get_dma_data(rtd->cpu_dai, substream); + + pr_debug("Entered %s\n", __func__); + + /* return if this is a bufferless transfer e.g. + * codec <--> BT codec or GSM modem -- lg FIXME */ + if (!dma) + return 0; + + /* this may get called several times by oss emulation + * with different params -HW */ + if (prtd->params == NULL) { + struct dma_slave_config config; + dma_cap_mask_t mask; + + /* prepare DMA */ + prtd->params = dma; + + pr_debug("params %p, channel %d\n", prtd->params, + prtd->params->channel); + + dma_cap_zero(mask); + dma_cap_set(DMA_CYCLIC, mask); + + prtd->params->ch = dma_request_slave_channel_compat(mask, + pl330_filter, (void *)prtd->params->channel, + rtd->cpu_dai->dev, prtd->params->ch_name); + + memset(&config, 0, sizeof(struct dma_slave_config)); + + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + config.direction = DMA_MEM_TO_DEV; + config.dst_addr = prtd->params->dma_addr; + config.dst_addr_width = prtd->params->dma_size; + config.dst_maxburst = 1; + dmaengine_slave_config(prtd->params->ch, &config); + } else { + config.direction = DMA_DEV_TO_MEM; + config.src_addr = prtd->params->dma_addr; + config.src_addr_width = prtd->params->dma_size; + config.src_maxburst = 1; + dmaengine_slave_config(prtd->params->ch, &config); + } + } + + snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); + + runtime->dma_bytes = totbytes; + + spin_lock_irq(&prtd->lock); + prtd->dma_loaded = 0; + prtd->dma_period = params_period_bytes(params); + prtd->dma_start = runtime->dma_addr; + prtd->dma_pos = prtd->dma_start; + prtd->dma_end = prtd->dma_start + totbytes; + spin_unlock_irq(&prtd->lock); + + return 0; +} + +static int dma_hw_free(struct snd_pcm_substream *substream) +{ + struct runtime_data *prtd = substream->runtime->private_data; + + pr_debug("Entered %s\n", __func__); + + snd_pcm_set_runtime_buffer(substream, NULL); + + if (prtd->params) { + dmaengine_terminate_all(prtd->params->ch); + dma_release_channel(prtd->params->ch); + prtd->params = NULL; + } + + return 0; +} + +static int dma_prepare(struct snd_pcm_substream *substream) +{ + struct runtime_data *prtd = substream->runtime->private_data; + int ret = 0; + + pr_debug("Entered %s\n", __func__); + + /* return if this is a bufferless transfer e.g. + * codec <--> BT codec or GSM modem -- lg FIXME */ + if (!prtd->params) + return 0; + + /* flush the DMA channel */ + dmaengine_terminate_all(prtd->params->ch); + + prtd->dma_loaded = 0; + prtd->dma_pos = prtd->dma_start; + + /* enqueue dma buffers */ + dma_enqueue(substream); + + return ret; +} + +static int dma_trigger(struct snd_pcm_substream *substream, int cmd) +{ + struct runtime_data *prtd = substream->runtime->private_data; + int ret = 0; + + pr_debug("Entered %s\n", __func__); + + spin_lock(&prtd->lock); + + switch (cmd) { + case SNDRV_PCM_TRIGGER_START: + prtd->state |= ST_RUNNING; + dma_async_issue_pending(prtd->params->ch); + break; + + case SNDRV_PCM_TRIGGER_STOP: + prtd->state &= ~ST_RUNNING; + dmaengine_terminate_all(prtd->params->ch); + break; + + default: + ret = -EINVAL; + break; + } + + spin_unlock(&prtd->lock); + + return ret; +} +#endif static snd_pcm_uframes_t dma_pointer(struct snd_pcm_substream *substream) diff --git a/sound/soc/samsung/dma.h b/sound/soc/samsung/dma.h index 189a7a6..6bd1857 100644 --- a/sound/soc/samsung/dma.h +++ b/sound/soc/samsung/dma.h @@ -12,13 +12,24 @@ #ifndef _S3C_AUDIO_H #define _S3C_AUDIO_H +#ifdef CONFIG_SAMSUNG_DMADEV +#include <mach/dma.h> +#endif + struct s3c_dma_params { +#ifdef CONFIG_SAMSUNG_DMADEV struct s3c2410_dma_client *client; /* stream identifier */ + unsigned ch; + struct samsung_dma_ops *ops; +#else + struct s3c2410_dma_client { + char *name; /* unused */ + } *client; + struct dma_chan *ch; +#endif int channel; /* Channel ID */ dma_addr_t dma_addr; int dma_size; /* Size of the DMA transfer */ - unsigned ch; - struct samsung_dma_ops *ops; char *ch_name; }; diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index d7231e3..61f2622 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -22,8 +22,6 @@ #include <sound/soc.h> #include <sound/pcm_params.h> -#include <mach/dma.h> - #include <linux/platform_data/asoc-s3c.h> #include "dma.h" diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index 13bab79..b5f267c 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -20,7 +20,6 @@ #include <sound/pcm_params.h> #include <linux/platform_data/asoc-s3c.h> -#include <mach/dma.h> #include "dma.h" #include "pcm.h" diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index 5008e5b..ee792aa 100644 --- a/sound/soc/samsung/spdif.c +++ b/sound/soc/samsung/spdif.c @@ -18,7 +18,6 @@ #include <sound/pcm_params.h> #include <linux/platform_data/asoc-s3c.h> -#include <mach/dma.h> #include "dma.h" #include "spdif.h" -- 1.8.1.2

4 5

[alsa-devel] [PATCH v2] ALSA: hda - Apply codec delay to wallclock.
by Dylan Reid 15 Apr '13

15 Apr '13

For playback add the codec-side delay to the timestamp, for capture subtract it. This brings the timestamps in line with the time that was recently added to the delay reporting. Signed-off-by: Dylan Reid <dgreid(a)chromium.org> --- Changes since v1: Calculate nsec from frames, subtract delay for playback as well as capture. sound/pci/hda/hda_intel.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 735567e..3e6f2c6 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1889,6 +1889,23 @@ static void azx_timecounter_init(struct snd_pcm_substream *substream, tc->cycle_last = last; } +static u64 azx_subtract_codec_delay(struct snd_pcm_substream *substream, + u64 nsec) +{ + struct azx_pcm *apcm = snd_pcm_substream_chip(substream); + struct hda_pcm_stream *hinfo = apcm->hinfo[substream->stream]; + u64 codec_frames, codec_nsecs; + + if (!hinfo->ops.get_delay) + return nsec; + + codec_frames = hinfo->ops.get_delay(hinfo, apcm->codec, substream); + codec_nsecs = div_u64(codec_frames * 1000000000LL, + substream->runtime->rate); + + return (nsec > codec_nsecs) ? nsec - codec_nsecs : 0; +} + static int azx_get_wallclock_tstamp(struct snd_pcm_substream *substream, struct timespec *ts) { @@ -1897,6 +1914,7 @@ static int azx_get_wallclock_tstamp(struct snd_pcm_substream *substream, nsec = timecounter_read(&azx_dev->azx_tc); nsec = div_u64(nsec, 3); /* can be optimized */ + nsec = azx_subtract_codec_delay(substream, nsec); *ts = ns_to_timespec(nsec); -- 1.8.1.3.605.g02339dd

3 9

[alsa-devel] Can Realtek HD-A codec ALC282 support D3cold?
by Lin, Mengdong 15 Apr '13

15 Apr '13

Hi, We want to put an idle HD-A codec into D3cold for more power saving and preparation for being power gated. The Realtek ALC282 is used in our test. Could anyone help to confirm whether ALC282 can support D3cold or not? I'm told that ALC282 can support D3cold. But my test shows it cannot. At first, ALC282 HW does not report that it can support D3cold. Its parameter "Supported Power States" returns 0xc000000f, means it only supports: EPSS, CLKSTOP, D3hot, D2, D1 and D0. Is this a just mistake in reporting the bit, or D3cold is not supported all? Then when I explicitly set the audio function group to D3cold by verb 0x705, and then get its power state after 200ms by verb 0xf05, The codec response is 0x00000000: No PS-Error, both PS-Act and PS-set is D0. So it seems the command to D3cold is not processed by codec HW at all. Is there someone from Realtek or with experience on ALC282 here can share some information about this issue? Many thanks Mengdong

1 0

[alsa-devel] M-Audio Delta 1010LT: S/PDIF clock source not working
by Jonas Petersen 15 Apr '13

15 Apr '13

Hi, I am trying to capture from S/PDIF. I get a signal but the clocking is broken somehow. I have 'Multi Track Internal Clock' on 'ICE958 Input'. 'Word Clock Status' and 'Word Clock Sync' are 'Off'. What happens is the following: It captures what comes in on S/PDIF but it seems it will always use the internal clock with the setting from 'Multi Track Internal Clock Default'. So even though 'Multi Track Internal Clock' is on 'ICE958 Input', the setting of 'Multi Track Internal Clock Default' will clock the signal. A 1 kHz sine wave at 48 kHz samplerate captured with 'Multi Track Internal Clock Default' on 96 kHz will result in a 2 kHz sine. When the sample frequency rates are matched, it will capture at correct rate but with hiccups due to the rates not perfectly aligned. What can I do narrow down the cause? Reards Jonas

4 8

[alsa-devel] USB Quirks for Boss JS-8
by Keith A. Milner 15 Apr '13

15 Apr '13

Hi, I'm looking at developing a quirk for the Boss JS-8. The lsusb is as follows: Bus 001 Device 003: ID 0582:0109 Roland Corp. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 255 Vendor Specific Class bDeviceSubClass 0 bDeviceProtocol 255 bMaxPacketSize0 64 idVendor 0x0582 Roland Corp. idProduct 0x0109 bcdDevice 0.01 iManufacturer 1 BOSS iProduct 2 JS-8 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 167 bNumInterfaces 3 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xc0 Self Powered MaxPower 0mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 06 24 f1 01 00 00 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 07 24 01 01 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 04 18 01 44 ac 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x05 EP 5 OUT bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0070 1x 112 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 ** UNRECOGNIZED: 07 24 01 07 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 04 18 01 44 ac 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 37 Transfer Type Isochronous Synch Type Asynchronous Usage Type Implicit feedback Data wMaxPacketSize 0x0070 1x 112 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 06 24 f1 02 02 02 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x82 EP 2 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 1 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 1 Device Qualifier (for other device speed): bLength 10 bDescriptorType 6 bcdUSB 2.00 bDeviceClass 8 Mass Storage bDeviceSubClass 6 SCSI bDeviceProtocol 80 Bulk (Zip) bMaxPacketSize0 64 bNumConfigurations 0 Device Status: 0x0001 Self Powered I wasn't entirely sure about the quirk syntax as the two interfaces are at EP 4 and EP5. Does this mean I need to ignore the (non-existant) lower interfaces? Here's what I came up with: { /* Boss JS-8 Jam Station */ USB_DEVICE(0x0582, 0x0109), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { /* .vendor_name = "BOSS", */ /* .product_name = "JS-8", */ .ifnum = QUIRK_ANY_INTERFACE, .type = QUIRK_COMPOSITE, .data = (const struct snd_usb_audio_quirk[]) { { .ifnum = 0, .type = QUIRK_IGNORE_INTERFACE }, { .ifnum = 1, .type = QUIRK_IGNORE_INTERFACE }, { .ifnum = 2, .type = QUIRK_IGNORE_INTERFACE }, { .ifnum = 3, .type = QUIRK_IGNORE_INTERFACE }, { .ifnum = 4, .type = QUIRK_AUDIO_STANDARD_INTERFACE }, { .ifnum = 5, .type = QUIRK_AUDIO_STANDARD_INTERFACE }, { .ifnum = -1 } } } }, regards, -- Keith A. Milner

5 9

[alsa-devel] alsa-project.org access, I want to tackle building an eClaro driver
by TJ Olaes 13 Apr '13

13 Apr '13

Hello. I hate to post to this mailing list regarding access to the alsa-project.org wiki, but I've gone through the site and can't, for the life of me, seem to find an admin email or something like it on the wiki. I'm trying to sign up to the wiki and am having trouble with the Captcha. I put in different version numbers of linux kernels but all my attempts to register seem to be thwarted because I'm not putting in the correct info. I have no idea what I'm doing wrong. What I'm really trying to do is get involved in alsa driver development... I think this would be an appropriate place for me to attempt to address my issue, which is the lack of an HT Omega eClaro card driver. I really, really want to contribute but it seems I'm being thwarted by the developer website. If I could get contact info for an admin or something, I would go bug them, but it seems that info isn't posted on the wiki. Sorry to bug y'all. Thanks. -TJ

3 3

Re: [alsa-devel] [PATCH] alsa/usb: Add quirk for 192KHz recording on E-Mu devices
by Takashi Iwai 13 Apr '13

13 Apr '13

At Fri, 12 Apr 2013 22:33:59 -0500, Calvin Owens wrote: > > When recording at 176.2KHz or 192Khz, the device adds a 32-bit length > header to the capture packets, which obviously needs to be ignored for > recording to work properly. > > Userspace expected: L0 L1 L2 R0 R1 R2 > ...but actually got: R2 L0 L1 L2 R0 R1 > > Also, the last byte of the length header being interpreted as L0 of > the first sample caused spikes every 0.5ms, resulting in a loud 16KHz > tone (about the highest 'B' on a piano) being present throughout > captures. > > Tested at all sample rates on an E-Mu 0404USB, and tested for > regressions on a generic USB headset. > > Signed-off-by: Calvin Owens <jcalvinowens(a)gmail.com> Thanks, applied for 3.10 kernel (but with Cc to stable) now. Takashi > --- > sound/usb/card.h | 1 + > sound/usb/pcm.c | 2 +- > sound/usb/quirks.c | 1 + > sound/usb/stream.c | 1 + > 4 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/card.h b/sound/usb/card.h > index 8a751b4..d32ea41 100644 > --- a/sound/usb/card.h > +++ b/sound/usb/card.h > @@ -116,6 +116,7 @@ struct snd_usb_substream { > unsigned int altset_idx; /* USB data format: index of alternate setting */ > unsigned int txfr_quirk:1; /* allow sub-frame alignment */ > unsigned int fmt_type; /* USB audio format type (1-3) */ > + unsigned int pkt_offset_adj; /* Bytes to drop from beginning of packets (for non-compliant devices) */ > > unsigned int running: 1; /* running status */ > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index f94397b..a481fea 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -1170,7 +1170,7 @@ static void retire_capture_urb(struct snd_usb_substream *subs, > stride = runtime->frame_bits >> 3; > > for (i = 0; i < urb->number_of_packets; i++) { > - cp = (unsigned char *)urb->transfer_buffer + urb->iso_frame_desc[i].offset; > + cp = (unsigned char *)urb->transfer_buffer + urb->iso_frame_desc[i].offset + subs->pkt_offset_adj; > if (urb->iso_frame_desc[i].status && printk_ratelimit()) { > snd_printdd(KERN_ERR "frame %d active: %d\n", i, urb->iso_frame_desc[i].status); > // continue; > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 5325a38..7e292b9 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -837,6 +837,7 @@ static void set_format_emu_quirk(struct snd_usb_substream *subs, > break; > } > snd_emuusb_set_samplerate(subs->stream->chip, emu_samplerate_id); > + subs->pkt_offset_adj = (emu_samplerate_id >= EMU_QUIRK_SR_176400HZ) ? 4 : 0; > } > > void snd_usb_set_format_quirk(struct snd_usb_substream *subs, > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > index ad181d5..0927cc6 100644 > --- a/sound/usb/stream.c > +++ b/sound/usb/stream.c > @@ -94,6 +94,7 @@ static void snd_usb_init_substream(struct snd_usb_stream *as, > subs->dev = as->chip->dev; > subs->txfr_quirk = as->chip->txfr_quirk; > subs->speed = snd_usb_get_speed(subs->dev); > + subs->pkt_offset_adj = 0; > > snd_usb_set_pcm_ops(as->pcm, stream); > > -- > 1.8.1.5 >

1 0

Re: [alsa-devel] [PATCH] ASoC: samsung: fix neo1973-wm8753 compilation
by Mark Brown 12 Apr '13

12 Apr '13

On Thu, Apr 11, 2013 at 09:02:43PM +0200, Heiko Stübner wrote: > Commit b2ca78717cea (ARM: S3C24XX: make gta02.h local) already replaced > the GTA02_GPIO_* constants in neo1973-wm8753.c but forgot to remove the > inclusion of mach/gta02.h before moving the file out of mach/. Applied, thanks.

1 0

[alsa-devel] ASoC update for v3.9-rc6
by Mark Brown 12 Apr '13

12 Apr '13

The following changes since commit 31880c37c11e28cb81c70757e38392b42e695dc6: Linux 3.9-rc6 (2013-04-07 20:49:54 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-maintainers-v3.9-rc6 for you to fetch changes up to b02e48f2f8755e51fe8ce246988a29bd96f6b85e: MAINTAINERS: Update e-mail address (2013-04-12 11:53:41 +0100) May as well go along with the other sound updates. ---------------------------------------------------------------- MAINTAINERS: Update e-mail address Update the e-mail address I use for subsystems. ---------------------------------------------------------------- Mark Brown (1): MAINTAINERS: Update e-mail address MAINTAINERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

2 1

[alsa-devel] [PATCH 18/30] ASoC: samsung: move plat/ headers to local directory
by Arnd Bergmann 12 Apr '13

12 Apr '13

The plat/iis.h and plat/ac97.h files in the samsung platform are only needed by the ASoC drivers, so they can be moved into the same directory, as one more step towards a multiplatform build. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Cc: alsa-devel(a)alsa-project.org Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> --- arch/arm/mach-s3c24xx/dma-s3c2410.c | 2 -- arch/arm/mach-s3c24xx/dma-s3c2412.c | 2 -- arch/arm/mach-s3c24xx/dma-s3c2440.c | 2 -- arch/arm/mach-s3c24xx/dma-s3c2443.c | 2 -- sound/soc/samsung/ac97.c | 2 +- sound/soc/samsung/h1940_uda1380.c | 2 +- sound/soc/samsung/neo1973_wm8753.c | 2 +- {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-ac97.h | 0 {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-iis.h | 0 sound/soc/samsung/rx1950_uda1380.c | 2 +- sound/soc/samsung/s3c24xx-i2s.c | 2 +- sound/soc/samsung/s3c24xx_uda134x.c | 2 +- 12 files changed, 6 insertions(+), 14 deletions(-) rename {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-ac97.h (100%) rename {arch/arm/plat-samsung/include/plat => sound/soc/samsung}/regs-iis.h (100%) diff --git a/arch/arm/mach-s3c24xx/dma-s3c2410.c b/arch/arm/mach-s3c24xx/dma-s3c2410.c index a6c94b8..30aa53f 100644 --- a/arch/arm/mach-s3c24xx/dma-s3c2410.c +++ b/arch/arm/mach-s3c24xx/dma-s3c2410.c @@ -25,10 +25,8 @@ #include <plat/regs-serial.h> #include <mach/regs-gpio.h> -#include <plat/regs-ac97.h> #include <plat/regs-dma.h> #include <mach/regs-lcd.h> -#include <plat/regs-iis.h> #include <plat/regs-spi.h> static struct s3c24xx_dma_map __initdata s3c2410_dma_mappings[] = { diff --git a/arch/arm/mach-s3c24xx/dma-s3c2412.c b/arch/arm/mach-s3c24xx/dma-s3c2412.c index c0e8c3f..ab1700e 100644 --- a/arch/arm/mach-s3c24xx/dma-s3c2412.c +++ b/arch/arm/mach-s3c24xx/dma-s3c2412.c @@ -25,10 +25,8 @@ #include <plat/regs-serial.h> #include <mach/regs-gpio.h> -#include <plat/regs-ac97.h> #include <plat/regs-dma.h> #include <mach/regs-lcd.h> -#include <plat/regs-iis.h> #include <plat/regs-spi.h> #define MAP(x) { (x)| DMA_CH_VALID, (x)| DMA_CH_VALID, (x)| DMA_CH_VALID, (x)| DMA_CH_VALID } diff --git a/arch/arm/mach-s3c24xx/dma-s3c2440.c b/arch/arm/mach-s3c24xx/dma-s3c2440.c index 1c08eccd..cd25de2 100644 --- a/arch/arm/mach-s3c24xx/dma-s3c2440.c +++ b/arch/arm/mach-s3c24xx/dma-s3c2440.c @@ -25,10 +25,8 @@ #include <plat/regs-serial.h> #include <mach/regs-gpio.h> -#include <plat/regs-ac97.h> #include <plat/regs-dma.h> #include <mach/regs-lcd.h> -#include <plat/regs-iis.h> #include <plat/regs-spi.h> static struct s3c24xx_dma_map __initdata s3c2440_dma_mappings[] = { diff --git a/arch/arm/mach-s3c24xx/dma-s3c2443.c b/arch/arm/mach-s3c24xx/dma-s3c2443.c index 000e4c6..5fe3539 100644 --- a/arch/arm/mach-s3c24xx/dma-s3c2443.c +++ b/arch/arm/mach-s3c24xx/dma-s3c2443.c @@ -25,10 +25,8 @@ #include <plat/regs-serial.h> #include <mach/regs-gpio.h> -#include <plat/regs-ac97.h> #include <plat/regs-dma.h> #include <mach/regs-lcd.h> -#include <plat/regs-iis.h> #include <plat/regs-spi.h> #define MAP(x) { \ diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c index 0df3c56..c76abdf 100644 --- a/sound/soc/samsung/ac97.c +++ b/sound/soc/samsung/ac97.c @@ -20,7 +20,7 @@ #include <sound/soc.h> #include <mach/dma.h> -#include <plat/regs-ac97.h> +#include "regs-ac97.h" #include <linux/platform_data/asoc-s3c.h> #include "dma.h" diff --git a/sound/soc/samsung/h1940_uda1380.c b/sound/soc/samsung/h1940_uda1380.c index 15a3817..fa91376 100644 --- a/sound/soc/samsung/h1940_uda1380.c +++ b/sound/soc/samsung/h1940_uda1380.c @@ -20,7 +20,7 @@ #include <sound/soc.h> #include <sound/jack.h> -#include <plat/regs-iis.h> +#include "regs-iis.h" #include <asm/mach-types.h> #include "s3c24xx-i2s.h" diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c index a301d8c..ccc601d 100644 --- a/sound/soc/samsung/neo1973_wm8753.c +++ b/sound/soc/samsung/neo1973_wm8753.c @@ -21,7 +21,7 @@ #include <sound/soc.h> #include <asm/mach-types.h> -#include <plat/regs-iis.h> +#include "regs-iis.h" #include <mach/gta02.h> #include "../codecs/wm8753.h" diff --git a/arch/arm/plat-samsung/include/plat/regs-ac97.h b/sound/soc/samsung/regs-ac97.h similarity index 100% rename from arch/arm/plat-samsung/include/plat/regs-ac97.h rename to sound/soc/samsung/regs-ac97.h diff --git a/arch/arm/plat-samsung/include/plat/regs-iis.h b/sound/soc/samsung/regs-iis.h similarity index 100% rename from arch/arm/plat-samsung/include/plat/regs-iis.h rename to sound/soc/samsung/regs-iis.h diff --git a/sound/soc/samsung/rx1950_uda1380.c b/sound/soc/samsung/rx1950_uda1380.c index a5826ea..704460a 100644 --- a/sound/soc/samsung/rx1950_uda1380.c +++ b/sound/soc/samsung/rx1950_uda1380.c @@ -24,7 +24,7 @@ #include <sound/soc.h> #include <sound/jack.h> -#include <plat/regs-iis.h> +#include "regs-iis.h" #include <asm/mach-types.h> #include "s3c24xx-i2s.h" diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c index 13f6dd1..a7b17c1 100644 --- a/sound/soc/samsung/s3c24xx-i2s.c +++ b/sound/soc/samsung/s3c24xx-i2s.c @@ -24,7 +24,7 @@ #include <sound/pcm_params.h> #include <mach/dma.h> -#include <plat/regs-iis.h> +#include "regs-iis.h" #include "dma.h" #include "s3c24xx-i2s.h" diff --git a/sound/soc/samsung/s3c24xx_uda134x.c b/sound/soc/samsung/s3c24xx_uda134x.c index 333e1b7..1b7b52b 100644 --- a/sound/soc/samsung/s3c24xx_uda134x.c +++ b/sound/soc/samsung/s3c24xx_uda134x.c @@ -18,7 +18,7 @@ #include <sound/soc.h> #include <sound/s3c24xx_uda134x.h> -#include <plat/regs-iis.h> +#include "regs-iis.h" #include "s3c24xx-i2s.h" -- 1.8.1.2

3 5

[alsa-devel] [PATCH] MAINTAINERS: Update e-mail address
by Mark Brown 12 Apr '13

12 Apr '13

Update the e-mail address I use for subsystems. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- MAINTAINERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 836a618..c6108c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6625,7 +6625,7 @@ S: Supported F: fs/reiserfs/ REGISTER MAP ABSTRACTION -M: Mark Brown <broonie(a)opensource.wolfsonmicro.com> +M: Mark Brown <broonie(a)kernel.org> T: git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git S: Supported F: drivers/base/regmap/ @@ -7374,7 +7374,7 @@ F: sound/ SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC) M: Liam Girdwood <lgirdwood(a)gmail.com> -M: Mark Brown <broonie(a)opensource.wolfsonmicro.com> +M: Mark Brown <broonie(a)kernel.org> T: git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) W: http://alsa-project.org/main/index.php/ASoC @@ -7463,7 +7463,7 @@ F: drivers/clk/spear/ SPI SUBSYSTEM M: Grant Likely <grant.likely(a)secretlab.ca> -M: Mark Brown <broonie(a)opensource.wolfsonmicro.com> +M: Mark Brown <broonie(a)kernel.org> L: spi-devel-general(a)lists.sourceforge.net Q: http://patchwork.kernel.org/project/spi-devel-general/list/ T: git git://git.secretlab.ca/git/linux-2.6.git @@ -8708,7 +8708,7 @@ F: drivers/scsi/vmw_pvscsi.h VOLTAGE AND CURRENT REGULATOR FRAMEWORK M: Liam Girdwood <lrg(a)ti.com> -M: Mark Brown <broonie(a)opensource.wolfsonmicro.com> +M: Mark Brown <broonie(a)kernel.org> W: http://opensource.wolfsonmicro.com/node/15 W: http://www.slimlogic.co.uk/?p=48 T: git git://git.kernel.org/pub/scm/linux/kernel/git/lrg/regulator.git -- 1.7.10.4

1 0

[alsa-devel] alsa 1.0.27 release
by Jaroslav Kysela 12 Apr '13

12 Apr '13

Hello all, the alsa 1.0.27 packages were released. You may download these packages from the main ALSA page: http://www.alsa-project.org . There are no updates for pyalsa and alsa-oss. The full changelog is provided here: http://www.alsa-project.org/main/index.php/Changes_v1.0.26_v1.0.27 Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Kernel Sound Maintainer ALSA Project; Red Hat, Inc.

1 0

[alsa-devel] [PATCH] asoc: add dummy codec
by Stas Sergeev 12 Apr '13

12 Apr '13

Hi. The attached patch adds a dummy codec for the asoc subsystem. I use it with the driver that programs the soc to drive I2S from an internal PLLs, and the audio then goes to HDMI, so no external codec is used. I've found spdif_transciever.c, which exactly is such a dummy driver, but it is bound to the particular plat device, so I made the device name a config option, and if not set, the plat device is created with the default name. It may be possible to avoid the usage of the codec driver at all, but I haven't succeeded with this, and the existance of spdif_transciever.c suggests there is no such way. Thoughts? Signed-off-by: Stas Sergeev <stsp(a)users.sourceforge.net>

3 14