March 2013 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH 04/10] ASoC: Kconfig: imx-ssi needs imx-fiq and imx-dma
by Mark Brown 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 07:33:05PM +0100, Markus Pargmann wrote: > config SND_SOC_IMX_SSI > + select SND_SOC_IMX_PCM_DMA > + select SND_SOC_IMX_PCM_FIQ > tristate Really? I'd expect this to be an or, if we've got DMA I can't see any reason why we'd want to use the FIQ.

1 0

Re: [alsa-devel] [PATCH 03/10] mx-ssi: flush fifos
by Mark Brown 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 07:33:04PM +0100, Markus Pargmann wrote: > From: Sascha Hauer <s.hauer(a)pengutronix.de> > > Signed-off-by: Sascha Hauer <s.hauer(a)pengutronix.de> > Signed-off-by: Markus Pargmann <mpa(a)pengutronix.de> Why? Is this a bug fix? I'm guessing it is but...

1 0

Re: [alsa-devel] [PATCH 02/10] imx-ssi: Fix occasional AC97 reset failure
by Mark Brown 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 07:33:03PM +0100, Markus Pargmann wrote: > From: Sascha Hauer <s.hauer(a)pengutronix.de> > > Signed-off-by: Sascha Hauer <s.hauer(a)pengutronix.de> > Signed-off-by: Markus Pargmann <mpa(a)pengutronix.de> Applied but *always* use subject lines appropriate to the subsystem and bugfixes like this should be pulled to the front of the series as they should be sent to mainline earlier.

1 0

Re: [alsa-devel] [PATCH 01/10] imx-ssi: Fix AC97 rates
by Mark Brown 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 07:33:02PM +0100, Markus Pargmann wrote: > From: Sascha Hauer <s.hauer(a)pengutronix.de> > > This device supports multiple rates as described in later AC97 > standards. This patch allows playback of different sample frequencies > without conversion. Applied, but some notes about why this is already supported would be useful and *always* use subject lines appropriate for the subsystem.

1 0

Re: [alsa-devel] [PATCH linux-next] ASoC: wm_hubs: Silence reg_r and reg_l 'may be used uninitialized' warnings
by Mark Brown 12 Mar '13

12 Mar '13

On Sun, Mar 10, 2013 at 10:58:21AM -0600, Tim Gardner wrote: > Return an error from wm_hubs_read_dc_servo() if hubs->dcs_readback_mode is not > correctly initialized. You might as well bail out since nothing is likely to > work correctly afterwards. Applied, thanks.

1 0

Re: [alsa-devel] [PATCH linux-next v2] ASoC: adau1373: adau1373_hw_params: Silence overflow warning
by Mark Brown 12 Mar '13

12 Mar '13

On Mon, Mar 11, 2013 at 01:18:23PM -0600, Tim Gardner wrote: > ADAU1373_BCLKDIV_SOURCE is defined as BIT(5) which uses UL constants. On > amd64 the result of the ones complement operator is then truncated to Applied, but please don't bury patches in the middle of e-mail threads (I nearly deleted this unread) and avoid including > Cc: Lars-Peter Clausen <lars(a)metafoo.de> > Cc: Liam Girdwood <lgirdwood(a)gmail.com> > Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > Cc: Jaroslav Kysela <perex(a)perex.cz> > Cc: Takashi Iwai <tiwai(a)suse.de> > Cc: device-drivers-devel(a)blackfin.uclinux.org > Cc: alsa-devel(a)alsa-project.org > Signed-off-by: Tim Gardner <tim.gardner(a)canonical.com> enormous CC lists like this in the body of the mail.

1 0

Re: [alsa-devel] [PATCH] omap: convert to devm_ioremap_resource()
by Mark Brown 12 Mar '13

12 Mar '13

On Mon, Mar 11, 2013 at 05:58:57PM +0200, Silviu-Mihai Popescu wrote: > Convert all uses of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages so all explicit > error messages can be removed from the failure code paths. Applied, thanks. Please use subject lines appropriate to the subsystem.

1 0

Re: [alsa-devel] [PATCH] ASoC: core: fix possible memory leak in snd_soc_bytes_put()
by Mark Brown 12 Mar '13

12 Mar '13

On Tue, Mar 12, 2013 at 12:35:14AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> > > 'data' is malloced in snd_soc_bytes_put() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. Applied, thanks.

1 0

Re: [alsa-devel] [PATCH] ASoC: wm_adsp: fix possible memory leak in wm_adsp_load_coeff()
by Mark Brown 12 Mar '13

12 Mar '13

On Tue, Mar 12, 2013 at 12:23:15AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> > > 'file' is malloced in wm_adsp_load_coeff() and should be freed > before leaving from the error handling cases, otherwise it will cause > memory leak. Applied, thanks.

1 0

[alsa-devel] [RFC][PATCH] ASoC: remove codec from list if registration failed
by Kuninori Morimoto 12 Mar '13

12 Mar '13

Current snd_soc_register_codec() adds codec to list, and calls snd_soc_register_dais(). But, this listed codec should be removed if dais registration was failed. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- If my understanding is correct... sound/soc/soc-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 1ac96df..38d6182 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -4097,6 +4097,10 @@ int snd_soc_register_codec(struct device *dev, return 0; fail_codec_name: + mutex_lock(&client_mutex); + list_del(&codec->list); + mutex_unlock(&client_mutex); + kfree(codec->name); fail_codec: kfree(codec); -- 1.7.9.5

2 1