December 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] sound: memalloc.h - fix wrong truncation of dma_addr_t
by Stefano Panella 10 Dec '13

10 Dec '13

When running a 32bit kernel the hda_intel driver is still reporting a 64bit dma_mask if the HW supports it. >From sound/pci/hda/hda_intel.c: /* allow 64bit DMA address if supported by H/W */ if ((gcap & ICH6_GCAP_64OK) && !pci_set_dma_mask(pci, DMA_BIT_MASK(64))) pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(64)); else { pci_set_dma_mask(pci, DMA_BIT_MASK(32)); pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32)); } which means when there is a call to dma_alloc_coherent from snd_malloc_dev_pages a machine address bigger than 32bit can be returned. This can be true in particular if running the 32bit kernel as a pv dom0 under the Xen Hypervisor or PAE on bare metal. The problem is that when calling setup_bdle to program the BLE the dma_addr_t returned from the dma_alloc_coherent is wrongly truncated from snd_sgbuf_get_addr if running a 32bit kernel: static inline dma_addr_t snd_sgbuf_get_addr(struct snd_dma_buffer *dmab, size_t offset) { struct snd_sg_buf *sgbuf = dmab->private_data; dma_addr_t addr = sgbuf->table[offset >> PAGE_SHIFT].addr; addr &= PAGE_MASK; return addr + offset % PAGE_SIZE; } where PAGE_MASK in a 32bit kernel is zeroing the upper 32bit af addr. Without this patch the HW will fetch the 32bit truncated address, which is not the one obtained from dma_alloc_coherent and will result to a non working audio but can corrupt host memory at a random location. The current patch apply to v3.13-rc3-74-g6c843f5 Signed-off-by: Stefano Panella <stefano.panella(a)citrix.com> Reviewed-by: Frediano Ziglio <frediano.ziglio(a)citrix.com> --- include/sound/memalloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sound/memalloc.h b/include/sound/memalloc.h index af99839..5f73785 100644 --- a/include/sound/memalloc.h +++ b/include/sound/memalloc.h @@ -108,7 +108,7 @@ static inline dma_addr_t snd_sgbuf_get_addr(struct snd_dma_buffer *dmab, { struct snd_sg_buf *sgbuf = dmab->private_data; dma_addr_t addr = sgbuf->table[offset >> PAGE_SHIFT].addr; - addr &= PAGE_MASK; + addr &= ~((dma_addr_t)PAGE_SIZE - 1); return addr + offset % PAGE_SIZE; } -- 1.7.9.5

2 1

[alsa-devel] [PATCHv8][ 1/5] ASoC: eukrea-tlv320: Add DT support.
by Denis Carikli 10 Dec '13

10 Dec '13

Cc: Rob Herring <rob.herring(a)calxeda.com> Cc: Pawel Moll <pawel.moll(a)arm.com> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Stephen Warren <swarren(a)wwwdotorg.org> Cc: Ian Campbell <ijc+devicetree(a)hellion.org.uk> Cc: devicetree(a)vger.kernel.org Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: alsa-devel(a)alsa-project.org Cc: Sascha Hauer <kernel(a)pengutronix.de> Cc: linux-arm-kernel(a)lists.infradead.org Cc: Eric Bénard <eric(a)eukrea.com> Signed-off-by: Denis Carikli <denis(a)eukrea.com> --- ChangeLog v7->v8: - fixed the vendor prefixes in the dts bindings. - updated the code and the documentation accordingly. - removed the need of an audio-codec property, since it's available in the ssi bindings. - the dai codec is now retrived trough the dt in order to support machines that have its codec on another i2c bus number. - driver compatible is now similar to the ones of the other drivers. ChangeLog v6->v7: - The cleanups went into another patch. - The support for fsl_ssi doesn't depend on dt anymore. - platform_name = "imx-ssi.0" is still set when in non-dt mode. --- .../devicetree/bindings/sound/eukrea-tlv320.txt | 21 ++++ sound/soc/fsl/Kconfig | 5 +- sound/soc/fsl/eukrea-tlv320.c | 108 +++++++++++++++++--- 3 files changed, 121 insertions(+), 13 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/eukrea-tlv320.txt diff --git a/Documentation/devicetree/bindings/sound/eukrea-tlv320.txt b/Documentation/devicetree/bindings/sound/eukrea-tlv320.txt new file mode 100644 index 0000000..0d7985c --- /dev/null +++ b/Documentation/devicetree/bindings/sound/eukrea-tlv320.txt @@ -0,0 +1,21 @@ +Audio complex for Eukrea boards with tlv320aic23 codec. + +Required properties: +- compatible : "eukrea,asoc-tlv320" +- eukrea,model : The user-visible name of this sound complex. +- ssi-controller : The phandle of the SSI controller. +- fsl,mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). +- fsl,mux-ext-port : The external port of the i.MX audio muxer. + +Note: The AUDMUX port numbering should start at 1, which is consistent with +hardware manual. + +Example: + + sound { + compatible = "eukrea,asoc-tlv320"; + eukrea,model = "imx51-eukrea-tlv320aic23"; + ssi-controller = <&ssi2>; + fsl,mux-int-port = <2>; + fsl,mux-ext-port = <3>; + }; diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index b7ab71f..9c3cd64 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -161,12 +161,15 @@ config SND_SOC_EUKREA_TLV320 depends on MACH_EUKREA_MBIMX27_BASEBOARD \ || MACH_EUKREA_MBIMXSD25_BASEBOARD \ || MACH_EUKREA_MBIMXSD35_BASEBOARD \ - || MACH_EUKREA_MBIMXSD51_BASEBOARD + || MACH_EUKREA_MBIMXSD51_BASEBOARD \ + || OF depends on I2C select SND_SOC_TLV320AIC23 select SND_SOC_IMX_PCM_FIQ select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_SSI + select SND_SOC_FSL_SSI + select SND_SOC_IMX_PCM_DMA help Enable I2S based access to the TLV320AIC23B codec attached to the SSI interface diff --git a/sound/soc/fsl/eukrea-tlv320.c b/sound/soc/fsl/eukrea-tlv320.c index 5983740..eb093d5 100644 --- a/sound/soc/fsl/eukrea-tlv320.c +++ b/sound/soc/fsl/eukrea-tlv320.c @@ -15,8 +15,11 @@ * */ +#include <linux/errno.h> #include <linux/module.h> #include <linux/moduleparam.h> +#include <linux/of.h> +#include <linux/of_platform.h> #include <linux/device.h> #include <linux/i2c.h> #include <sound/core.h> @@ -26,6 +29,7 @@ #include "../codecs/tlv320aic23.h" #include "imx-ssi.h" +#include "fsl_ssi.h" #include "imx-audmux.h" #define CODEC_CLOCK 12000000 @@ -41,7 +45,8 @@ static int eukrea_tlv320_hw_params(struct snd_pcm_substream *substream, ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBM_CFM); - if (ret) { + /* fsl_ssi lacks the set_fmt ops. */ + if (ret && ret != -ENOTSUPP) { dev_err(cpu_dai->dev, "Failed to set the cpu dai format.\n"); return ret; @@ -63,11 +68,13 @@ static int eukrea_tlv320_hw_params(struct snd_pcm_substream *substream, "Failed to set the codec sysclk.\n"); return ret; } + snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffc, 0xffffffc, 2, 0); ret = snd_soc_dai_set_sysclk(cpu_dai, IMX_SSP_SYS_CLK, 0, SND_SOC_CLOCK_IN); - if (ret) { + /* fsl_ssi lacks the set_sysclk ops */ + if (ret && ret != -EINVAL) { dev_err(cpu_dai->dev, "Can't set the IMX_SSP_SYS_CLK CPU system clock.\n"); return ret; @@ -84,14 +91,10 @@ static struct snd_soc_dai_link eukrea_tlv320_dai = { .name = "tlv320aic23", .stream_name = "TLV320AIC23", .codec_dai_name = "tlv320aic23-hifi", - .platform_name = "imx-ssi.0", - .codec_name = "tlv320aic23-codec.0-001a", - .cpu_dai_name = "imx-ssi.0", .ops = &eukrea_tlv320_snd_ops, }; static struct snd_soc_card eukrea_tlv320 = { - .name = "cpuimx-audio", .owner = THIS_MODULE, .dai_link = &eukrea_tlv320_dai, .num_links = 1, @@ -101,8 +104,65 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) { int ret; int int_port = 0, ext_port; + struct device_node *np = pdev->dev.of_node; + struct device_node *ssi_np, *codec_np; - if (machine_is_eukrea_cpuimx27()) { + eukrea_tlv320.dev = &pdev->dev; + if (np) { + ret = snd_soc_of_parse_card_name(&eukrea_tlv320, + "eukrea,model"); + if (ret) { + dev_err(&pdev->dev, + "eukrea,model node missing or invalid.\n"); + goto err; + } + + ssi_np = of_parse_phandle(pdev->dev.of_node, + "ssi-controller", 0); + if (!ssi_np) { + dev_err(&pdev->dev, + "ssi-controller missing or invalid.\n"); + ret = -ENODEV; + goto err; + } + + codec_np = of_parse_phandle(ssi_np, "codec-handle", 0); + if (codec_np) + eukrea_tlv320_dai.codec_of_node = codec_np; + else + dev_err(&pdev->dev, "codec-handle node missing or invalid.\n"); + + ret = of_property_read_u32(np, "fsl,mux-int-port", &int_port); + if (ret) { + dev_err(&pdev->dev, + "fsl,mux-int-port node missing or invalid.\n"); + return ret; + } + ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port); + if (ret) { + dev_err(&pdev->dev, + "fsl,mux-ext-port node missing or invalid.\n"); + return ret; + } + + /* + * The port numbering in the hardware manual starts at 1, while + * the audmux API expects it starts at 0. + */ + int_port--; + ext_port--; + + eukrea_tlv320_dai.cpu_of_node = ssi_np; + eukrea_tlv320_dai.platform_of_node = ssi_np; + } else { + eukrea_tlv320_dai.cpu_dai_name = "imx-ssi.0"; + eukrea_tlv320_dai.platform_name = "imx-ssi.0"; + eukrea_tlv320_dai.codec_name = "tlv320aic23-codec.0-001a"; + eukrea_tlv320.name = "cpuimx-audio"; + } + + if (machine_is_eukrea_cpuimx27() || + of_find_compatible_node(NULL, NULL, "fsl,imx21-audmux")) { imx_audmux_v1_configure_port(MX27_AUDMUX_HPCR1_SSI0, IMX_AUDMUX_V1_PCR_SYN | IMX_AUDMUX_V1_PCR_TFSDIR | @@ -119,8 +179,12 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) ); } else if (machine_is_eukrea_cpuimx25sd() || machine_is_eukrea_cpuimx35sd() || - machine_is_eukrea_cpuimx51sd()) { - ext_port = machine_is_eukrea_cpuimx25sd() ? 4 : 3; + machine_is_eukrea_cpuimx51sd() || + of_find_compatible_node(NULL, NULL, "fsl,imx31-audmux")) { + if (!np) + ext_port = machine_is_eukrea_cpuimx25sd() ? + 4 : 3; + imx_audmux_v2_configure_port(int_port, IMX_AUDMUX_V2_PTCR_SYN | IMX_AUDMUX_V2_PTCR_TFSDIR | @@ -134,14 +198,27 @@ static int eukrea_tlv320_probe(struct platform_device *pdev) IMX_AUDMUX_V2_PDCR_RXDSEL(int_port) ); } else { - /* return happy. We might run on a totally different machine */ - return 0; + if (np) { + /* The eukrea,asoc-tlv320 driver was explicitely + * requested (through the device tree). + */ + dev_err(&pdev->dev, + "Missing or invalid audmux DT node.\n"); + return -ENODEV; + } else { + /* Return happy. + * We might run on a totally different machine. + */ + return 0; + } } - eukrea_tlv320.dev = &pdev->dev; ret = snd_soc_register_card(&eukrea_tlv320); +err: if (ret) dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); + if (np) + of_node_put(ssi_np); return ret; } @@ -153,10 +230,17 @@ static int eukrea_tlv320_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id imx_tlv320_dt_ids[] = { + { .compatible = "eukrea,asoc-tlv320"}, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, imx_tlv320_dt_ids); + static struct platform_driver eukrea_tlv320_driver = { .driver = { .name = "eukrea_tlv320", .owner = THIS_MODULE, + .of_match_table = imx_tlv320_dt_ids, }, .probe = eukrea_tlv320_probe, .remove = eukrea_tlv320_remove, -- 1.7.9.5

3 6

[alsa-devel] [PATCH v2 0/2] Enhance imx-wm8962 machine driver
by Nicolin Chen 10 Dec '13

10 Dec '13

Although there's no direct relationship between any of these two patches, I recommend to apply them in order so as to circumvent merging conflicts. Changlog: v2: * Nothing changed for PATCH-1. * Added spinlock potection for boolean fll_locked in PATCH-2 * Dropped PATCH-3, will try to revise it next time. Nicolin Chen (2): ASoC: fsl: imx-wm8962: Don't update bias_level in machine driver ASoC: fsl: imx-wm8962: Grant hw_params/free() permission to control FLL sound/soc/fsl/imx-wm8962.c | 152 +++++++++++++++++++++++++++++---------------- 1 file changed, 99 insertions(+), 53 deletions(-) -- 1.8.4

3 10

[alsa-devel] caiaq driver: audio 4 dj and jackd
by Gabriel M. Beddingfield 10 Dec '13

10 Dec '13

Is it possible to make all 4 ins/outs in the Audio 4 DJ available through the first substream device? A user was having trouble using the NI Audio 4 DJ device with jackd. When jack connected, this 4-in/4-out device would appear as 2-in/2-out. This was the result of the fact that the channels are split up into stereo substreams. I.e. the first two channels are found in hw:x,0,0 and the last two channels are in hw:x,0,1. The work-around was to use the `multi' plug-in to make these 2 PCM's appear as a single PCM. There's several situations where this is a Good Thing, because it makes it easy for the user to treat the streams independently. BUT... in the pro-audio case this is not a good thing at all. Ideally, substream 0 would support 1, 2, or 4 channels (for both playback and capture). When substream 0 is using more than 2 channels, then substream 1 would return EBUSY when in use. So... would it be possible to do this in the caiaq driver? -gabriel

3 9

[alsa-devel] [PATCH] ASoC: rsnd: gen: fixup Gen2 channel size
by Kuninori Morimoto 10 Dec '13

10 Dec '13

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Gen2 has 0 - 9, total 10 channels, not 9 channels. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/gen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c index bf066f7..d0ab203 100644 --- a/sound/soc/sh/rcar/gen.c +++ b/sound/soc/sh/rcar/gen.c @@ -217,11 +217,11 @@ int rsnd_gen_path_exit(struct rsnd_priv *priv, /* single address mapping */ #define RSND_GEN2_S_REG(gen, reg, id, offset) \ - RSND_REG_SET(gen, RSND_REG_##id, RSND_GEN2_##reg, offset, 0, 9) + RSND_REG_SET(gen, RSND_REG_##id, RSND_GEN2_##reg, offset, 0, 10) /* multi address mapping */ #define RSND_GEN2_M_REG(gen, reg, id, offset, _id_offset) \ - RSND_REG_SET(gen, RSND_REG_##id, RSND_GEN2_##reg, offset, _id_offset, 9) + RSND_REG_SET(gen, RSND_REG_##id, RSND_GEN2_##reg, offset, _id_offset, 10) static int rsnd_gen2_regmap_init(struct rsnd_priv *priv, struct rsnd_gen *gen) { -- 1.7.9.5

2 1

[alsa-devel] [PATCH 1/2] ALSA: hda - A Dell headset detection quirk
by Hui Wang 10 Dec '13

10 Dec '13

On the Dell Optiplex 3030 machine (codec Subsystem Id: 0x10280623), no external microphone can be detected when plugging a 3-ring headset. If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the problem will disappear. BugLink: https://bugs.launchpad.net/hwe-somerville/+bug/1259435 CC: David Henningsson <david.henningsson(a)canonical.com> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c5ea483..7122f2c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5034,6 +5034,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE), SND_PCI_QUIRK(0x1028, 0x05d8, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x05db, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1028, 0x0623, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0625, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0626, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), -- 1.8.1.2

2 2

[alsa-devel] [PATCH] ALSA: atmel_abdac: clk_round_rate() can return a zero upon error
by Paul Walmsley 10 Dec '13

10 Dec '13

Treat both negative and zero return values from clk_round_rate() as errors. This is needed since subsequent patches will convert clk_round_rate()'s return value to be an unsigned type, rather than a signed type, since some clock sources can generate rates higher than (2^31)-1 Hz. Eventually, when calling clk_round_rate(), only a return value of zero will be considered a error; all other values will be considered valid rates. The comparison against values less than 0 is kept to preserve the correct behavior in the meantime. Signed-off-by: Paul Walmsley <pwalmsley(a)nvidia.com> Cc: Hans-Christian Egtvedt <egtvedt(a)samfundet.no> Cc: Nicolas Ferre <nicolas.ferre(a)atmel.com> Cc: Takashi Iwai <tiwai(a)suse.de> Cc: Jaroslav Kysela <perex(a)perex.cz> --- Applies on v3.13-rc3. See also: http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2 sound/atmel/abdac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 721d8fd..3519518 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -354,7 +354,7 @@ static int set_sample_rates(struct atmel_abdac *dac) /* we start at 192 kHz and work our way down to 5112 Hz */ while (new_rate >= RATE_MIN && index < (MAX_NUM_RATES + 1)) { new_rate = clk_round_rate(dac->sample_clk, 256 * new_rate); - if (new_rate < 0) + if (new_rate <= 0) break; /* make sure we are below the ABDAC clock */ if (index < MAX_NUM_RATES &&

2 1

Re: [alsa-devel] [PATCH V2] ASoC: add RT286 CODEC driver
by Bard Liao 10 Dec '13

10 Dec '13

> -----Original Message----- > From: Leon Romanovsky [mailto:leon@leon.nu] > Sent: Wednesday, December 04, 2013 10:37 PM > To: Bard Liao > Cc: Mark Brown; Liam Girdwood; Oder Chiou; alsa-devel(a)alsa-project.org; > Flove > Subject: Re: [alsa-devel] [PATCH V2] ASoC: add RT286 CODEC driver > > On Wed, Dec 4, 2013 at 3:41 PM, <bardliao(a)realtek.com> wrote: > > From: Bard Liao <bardliao(a)realtek.com> > > > > This patch adds the ALC286 codec driver. > > > > Signed-off-by: Bard Liao <bardliao(a)realtek.com> > > > > Please add change log while you are sending verX patch. Please see the change log as below. * Add platform data to determine if combo jack and/or IRQ is using or not. * Implement rt286_hw_read/write in regmap. * Configure codec in runtime instead of in probe. * Other minor changes (coding style, remove version control, remove empty functions, share code ...) Should I send another patch with these change log? > > > > + > > +static unsigned int rt286_reg_cache[TOTAL_NODE_ID + 1] = { > You don't need TOTAL_NODE_ID + 1 in array declaration. Without "TOTAL_NODE_ID + 1", I should always set [NODE_ID_MIXER_IN2] = 0x0000, right? Ie. Assign the latest array item a value. > > > + [NODE_ID_DAC_OUT1] = 0x7f7f, > > + [NODE_ID_DAC_OUT2] = 0x7f7f, > > + [NODE_ID_SPDIF] = 0x0000, > > + [NODE_ID_ADC_IN1] = 0x4343, > > + [NODE_ID_ADC_IN2] = 0x4343, > > + [NODE_ID_MIC1] = 0x0000, > > + [NODE_ID_MIXER_IN] = 0x000b, > > + [NODE_ID_MIXER_OUT1] = 0x0002, > > + [NODE_ID_MIXER_OUT2] = 0x0000, > > + [NODE_ID_SPK_OUT] = 0x0000, > > + [NODE_ID_HP_OUT] = 0x0000, > > + [NODE_ID_MIXER_IN1] = 0x0000, > > + [NODE_ID_MIXER_IN2] = 0x0000, > > +}; Thanks.

2 1

Re: [alsa-devel] [pulseaudio-discuss] Issue with multiple hdmi codecs in radeonhd, hacked to work
by Raymond Yau 10 Dec '13

10 Dec '13

2013/12/9 John Ettedgui <john.ettedgui(a)gmail.com> > > I am using the gitcompile script to configure, compile... > There is no configure by default, I was able to autogen it, but then I had > issues while building so I reverted back to gitcompile > [ 4.841881] ALSA hda_intel.c:3170 0000:01:00.1: Handle VGA-switcheroo audio client [ 4.841885] ALSA hda_intel.c:3364 0000:01:00.1: Using LPIB position fix [ 4.841886] ALSA hda_intel.c:3510 0000:01:00.1: Force to non-snoop mode [ 4.841920] snd_hda_intel 0000:01:00.1: irq 47 for MSI/MSI-X [ 4.841940] ALSA hda_intel.c:3635 0000:01:00.1: chipset global capabilities = 0x0 seem the max number of playback streams is hardcoded in the driver [ 4.842211] [drm] radeon kernel modesetting enabled. [ 4.844508] ALSA hda_intel.c:1244 0000:01:00.1: codec_mask = 0x1 [ 4.844630] ALSA hda_intel.c:1716 0000:01:00.1: codec #0 probed OK [ 4.844632] ALSA hda_intel.c:1837 0000:01:00.1: Enable sync_write for stable communication [ 4.851623] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=3 Presence_Detect=0 ELD_Valid=0 [ 4.851654] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=5 Presence_Detect=0 ELD_Valid=0 [ 4.851685] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=7 Presence_Detect=0 ELD_Valid=0 [ 4.851717] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=9 Presence_Detect=0 ELD_Valid=0 [ 4.851751] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=11 Presence_Detect=0 ELD_Valid=0 [ 4.851787] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=13 Presence_Detect=0 ELD_Valid=0 [ 4.851839] input: HDA ATI HDMI HDMI/DP,pcm=11 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input12 [ 4.851898] input: HDA ATI HDMI HDMI/DP,pcm=10 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input11 [ 4.851948] input: HDA ATI HDMI HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input10 [ 4.852014] input: HDA ATI HDMI HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input9 [ 4.852075] input: HDA ATI HDMI HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input8 [ 4.852129] input: HDA ATI HDMI HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:03.0/0000:01:00.1/sound/card0/input7 Does this mean monitor is plugged and graphic driver is requesting monitor to provide EDID ? 5.340797] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=3 Presence_Detect=1 ELD_Valid=0 [ 5.340812] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=3 Presence_Detect=1 ELD_Valid=1 [ 5.340825] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.340838] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.340844] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=5 Presence_Detect=1 ELD_Valid=0 [ 5.340857] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=5 Presence_Detect=1 ELD_Valid=1 [ 5.340870] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.340882] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.340885] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=7 Presence_Detect=1 ELD_Valid=0 [ 5.340898] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=7 Presence_Detect=1 ELD_Valid=1 [ 5.340911] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.340923] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.340926] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=9 Presence_Detect=1 ELD_Valid=0 [ 5.340939] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=9 Presence_Detect=1 ELD_Valid=1 [ 5.340952] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.340965] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.340967] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=11 Presence_Detect=1 ELD_Valid=0 [ 5.340980] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=11 Presence_Detect=1 ELD_Valid=1 [ 5.340993] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.341005] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.341008] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=13 Presence_Detect=1 ELD_Valid=0 [ 5.341021] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=13 Presence_Detect=1 ELD_Valid=1 [ 5.341034] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.341046] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.504525] [drm] Radeon Display Connectors [ 5.504527] [drm] Connector 0: [ 5.504528] [drm] DP-1 [ 5.504529] [drm] HPD4 [ 5.504530] [drm] DDC: 0x6530 0x6530 0x6534 0x6534 0x6538 0x6538 0x653c 0x653c [ 5.504531] [drm] Encoders: [ 5.504532] [drm] DFP1: INTERNAL_UNIPHY2 [ 5.504533] [drm] Connector 1: [ 5.504534] [drm] DP-2 [ 5.504535] [drm] HPD5 [ 5.504536] [drm] DDC: 0x6540 0x6540 0x6544 0x6544 0x6548 0x6548 0x654c 0x654c [ 5.504537] [drm] Encoders: [ 5.504538] [drm] DFP2: INTERNAL_UNIPHY2 [ 5.504538] [drm] Connector 2: [ 5.504539] [drm] HDMI-A-1 [ 5.504540] [drm] HPD1 [ 5.504541] [drm] DDC: 0x6550 0x6550 0x6554 0x6554 0x6558 0x6558 0x655c 0x655c [ 5.504542] [drm] Encoders: [ 5.504543] [drm] DFP3: INTERNAL_UNIPHY1 [ 5.504544] [drm] Connector 3: [ 5.504545] [drm] DVI-I-1 [ 5.504545] [drm] HPD6 [ 5.504547] [drm] DDC: 0x6580 0x6580 0x6584 0x6584 0x6588 0x6588 0x658c 0x658c [ 5.504547] [drm] Encoders: [ 5.504548] [drm] DFP4: INTERNAL_UNIPHY [ 5.504549] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [ 5.640237] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=3 Presence_Detect=1 ELD_Valid=1 [ 5.640254] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640267] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.640270] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=5 Presence_Detect=1 ELD_Valid=1 [ 5.640282] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640295] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.640297] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=7 Presence_Detect=1 ELD_Valid=1 [ 5.640310] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640322] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.640324] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=9 Presence_Detect=1 ELD_Valid=1 [ 5.640336] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640349] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.640351] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=11 Presence_Detect=1 ELD_Valid=1 [ 5.640363] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640376] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 5.640378] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=13 Presence_Detect=1 ELD_Valid=1 [ 5.640390] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 5.640403] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 7.906] (II) RADEON(0): EDID for output DisplayPort-0 [ 7.920] (II) RADEON(0): EDID for output DisplayPort-1 [ 7.983] (II) RADEON(0): EDID for output HDMI-0 [ 7.983] (II) RADEON(0): Manufacturer: DON Model: 26 Serial#: 16843009 [ 7.983] (II) RADEON(0): Year: 2011 Week: 0 [ 7.983] (II) RADEON(0): EDID Version: 1.3 [ 7.983] (II) RADEON(0): Monitor name: DENON-AVAMP [ 7.983] (II) RADEON(0): Number of EDID sections to follow: 1 [ 7.983] (II) RADEON(0): EDID (in hex): [ 7.983] (II) RADEON(0): 00ffffffffffff0011ee260001010101 [ 7.983] (II) RADEON(0): 00150103800000780adaffa3584aa229 [ 7.983] (II) RADEON(0): 17494b00000001010101010101010101 [ 7.983] (II) RADEON(0): 010101010101023a801871382d40582c [ 7.983] (II) RADEON(0): 4500ba882100001e011d8018711c1620 [ 7.983] (II) RADEON(0): 582c2500ba882100009e000000fc0044 [ 7.983] (II) RADEON(0): 454e4f4e2d4156414d500a20000000fd [ 7.983] (II) RADEON(0): 00173d0f440f000a202020202020010d [ 7.983] (II) RADEON(0): 020335714d9005200403020706010e23 [ 7.983] (II) RADEON(0): 0f24320f7f073d1ec01507505f7e0157 [ 7.983] (II) RADEON(0): 0600677e00835f0000e305030167030c [ 7.983] (II) RADEON(0): 001500b82d011d007251d01e206e2855 [ 7.983] (II) RADEON(0): 00ba882100001e8c0ad08a20e02d1010 [ 7.983] (II) RADEON(0): 3e9600ba88210000188c0ad08a20e02d [ 7.983] (II) RADEON(0): 10103e96000b88210000188c0aa01451 [ 7.983] (II) RADEON(0): f01600267c4300ba88210000980000e7 [ 8.003] (II) RADEON(0): EDID for output DVI-0 [ 8.003] (II) RADEON(0): Output DisplayPort-0 disconnected [ 8.003] (II) RADEON(0): Output DisplayPort-1 disconnected [ 8.003] (II) RADEON(0): Output HDMI-0 connected [ 8.003] (II) RADEON(0): Output DVI-0 disconnected Does this mean the graphic driver received EDID from DENON-AVAMP and pass ELD to audio driver ? [ 8.228364] ALSA patch_hdmi.c:972 HDMI hot plug event: Codec=0 Pin=3 Presence_Detect=0 ELD_Valid=1 [ 8.228380] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=3 Presence_Detect=1 ELD_Valid=1 [ 8.228393] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 8.228406] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 8.377652] type=1006 audit(1386558737.773:2): pid=515 uid=0 old auid=4294967295 new auid=1000 old ses=4294967295 new ses=1 res=1 [ 8.520795] ALSA hda_codec.c:1633 hda_codec_cleanup_stream: NID=0x2 [ 8.521113] ALSA hda_codec.c:1633 hda_codec_cleanup_stream: NID=0x2 [ 8.521434] ALSA hda_codec.c:1633 hda_codec_cleanup_stream: NID=0x2 [ 8.521727] ALSA hda_codec.c:1633 hda_codec_cleanup_stream: NID=0x2 [ 8.526625] ALSA patch_hdmi.c:1301 HDMI status: Codec=0 Pin=3 Presence_Detect=1 ELD_Valid=1 [ 8.526640] ALSA hda_eld.c:334 HDMI: ELD buf size is 0, force 128 [ 8.526652] ALSA hda_eld.c:351 HDMI: invalid ELD data byte 0 [ 8.261] (II) config/udev: Adding drm device (/dev/dri/card0) [ 8.262] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=9 (/dev/input/event8) [ 8.262] (II) No input driver specified, ignoring this device. [ 8.262] (II) This device may have been added with another device file. [ 8.262] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=10 (/dev/input/event7) [ 8.262] (II) No input driver specified, ignoring this device. [ 8.262] (II) This device may have been added with another device file. [ 8.262] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=11 (/dev/input/event6) [ 8.262] (II) No input driver specified, ignoring this device. [ 8.262] (II) This device may have been added with another device file. [ 8.262] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=3 (/dev/input/event11) [ 8.262] (II) No input driver specified, ignoring this device. [ 8.262] (II) This device may have been added with another device file. [ 8.262] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=7 (/dev/input/event10) [ 8.262] (II) No input driver specified, ignoring this device. [ 8.262] (II) This device may have been added with another device file. [ 8.263] (II) config/udev: Adding input device HDA ATI HDMI HDMI/DP,pcm=8 (/dev/input/event9) [ 8.263] (II) No input driver specified, ignoring this device. [ 8.263] (II) This device may have been added with another device file. [ 8.263] (II) config/udev: Adding input device Logitech USB Receiver (/dev/input/event0)

5 6

[alsa-devel] [PATCH V2 1/3] ASoC: restructure dmaengine_pcm_request_chan_of()
by Stephen Warren 09 Dec '13

09 Dec '13

From: Stephen Warren <swarren(a)nvidia.com> Restructure the internals of dmaengine_pcm_request_chan_of() as a loop over all channels to be allocated. This makes it easier to add logic that applies to all allocated channels, without having to duplicate that logic in each of the half-duplex/full-duplex paths. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- v2 (new as a separate patch): * Re-ordered patches, so that patch 3/3 in this series could be available in the ASoC tree without having to wait for the patches to the DMA tree the implement deferred probe during channel allocation. This whole series is a dependency for some patches that will go through the Tegra tree. If it could be applied to a topic branch in the ASoC tree that would be great. the overall dependency structure will be: a) This series. Can be applied on top of e.g. v3.13-rc1. b) Patches to the DMA tree, which implement deferred probe. Can be applied on top of e.g. v3.13-rc1. c) ASoC modifications to support deferred probe during DMA ch allocation This will depend on both (a) and (b). d) Tegra modifications that depend on (c). --- sound/soc/soc-generic-dmaengine-pcm.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index cbc9c96ce1f4..88b011b80058 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -288,21 +288,26 @@ static void dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm, struct device *dev) { unsigned int i; + const char *name; if ((pcm->flags & (SND_DMAENGINE_PCM_FLAG_NO_DT | SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME)) || !dev->of_node) return; - if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) { - pcm->chan[0] = dma_request_slave_channel(dev, "rx-tx"); - pcm->chan[1] = pcm->chan[0]; - } else { - for (i = SNDRV_PCM_STREAM_PLAYBACK; i <= SNDRV_PCM_STREAM_CAPTURE; i++) { - pcm->chan[i] = dma_request_slave_channel(dev, - dmaengine_pcm_dma_channel_names[i]); - } + for (i = SNDRV_PCM_STREAM_PLAYBACK; i <= SNDRV_PCM_STREAM_CAPTURE; + i++) { + if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) + name = "rx-tx"; + else + name = dmaengine_pcm_dma_channel_names[i]; + pcm->chan[i] = dma_request_slave_channel(dev, name); + if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) + break; } + + if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) + pcm->chan[1] = pcm->chan[0]; } /** -- 1.8.1.5

3 7