October 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: kirkwood: fix compilation warning in kirkwood_dma_open
by Vladimir Murzin 01 Oct '13

01 Oct '13

writel() supposes the first argument of type unsigned int. This fix the warning: sound/soc/kirkwood/kirkwood-dma.c: In function 'kirkwood_dma_open': sound/soc/kirkwood/kirkwood-dma.c:164:3: warning: large integer implicitly truncated to unsigned type [-Woverflow] Signed-off-by: Vladimir Murzin <murzin.v(a)gmail.com> --- sound/soc/kirkwood/kirkwood-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c index b238434..1135c30 100644 --- a/sound/soc/kirkwood/kirkwood-dma.c +++ b/sound/soc/kirkwood/kirkwood-dma.c @@ -161,7 +161,7 @@ static int kirkwood_dma_open(struct snd_pcm_substream *substream) * Enable Error interrupts. We're only ack'ing them but * it's useful for diagnostics */ - writel((unsigned long)-1, priv->io + KIRKWOOD_ERR_MASK); + writel((unsigned int)-1, priv->io + KIRKWOOD_ERR_MASK); } dram = mv_mbus_dram_info(); -- 1.8.1.5

2 1

[alsa-devel] [PATCH] ASoC: fsl: imx-sgtl5000: Add .remove back
by Fabio Estevam 01 Oct '13

01 Oct '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> Commit e8f00c1b01 (Merge remote-tracking branch 'asoc/fix/fsl' into asoc-devm) fixed a conflict, but missed to add the .remove function back,which causes the following build warning: sound/soc/fsl/imx-sgtl5000.c:185:12: warning: 'imx_sgtl5000_remove' defined but not used [-Wunused-function] Fix the warning by adding the .remove function back. Reported-by: Olof Johansson <olof(a)lixom.net> Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/fsl/imx-sgtl5000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 6f4bdc8..ed6ba1e 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -204,6 +204,7 @@ static struct platform_driver imx_sgtl5000_driver = { .of_match_table = imx_sgtl5000_dt_ids, }, .probe = imx_sgtl5000_probe, + .remove = imx_sgtl5000_remove, }; module_platform_driver(imx_sgtl5000_driver); -- 1.8.1.2

2 1

[alsa-devel] [PATCH] snd_tlv_convert_from_dB: fix decreasing gain across entries
by Stephen Warren 01 Oct '13

01 Oct '13

From: Stephen Warren <swarren(a)nvidia.com> Currently, for a TLV consisting of TLV_DB_SCALE_ITEMs, if e.g. alsamixer calls snd_mixer_selem_set_playback_dB() with a value that is in-between two TLV_DB_SCALE_ITEMs, and xdir is negative, the selected raw hardware value is the minimum in the first range above that value, rather than the maximum in the last range below that value. The user-visible symptom is that in alsamixer, pressing the down key to reduce the value sticks at certain points, and cannot be incrementally reduced any further, although directly selecting a much lower value (e.g. by pressing 0..9) works as expected. This is triggered e.g. by sound/soc/codec/max98090.c's max98090_hp_tlv[]. Fix this by checking whether xdir is positive or not, rather than checking whether it has a non-zero value. The code to select the previous range's max value is already present. This matches how xdir is used in other parts of the code. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- src/control/tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/control/tlv.c b/src/control/tlv.c index 6b0b9f4..b08d887 100644 --- a/src/control/tlv.c +++ b/src/control/tlv.c @@ -312,7 +312,7 @@ int snd_tlv_convert_from_dB(unsigned int *tlv, long rangemin, long rangemax, submin, submax, db_gain, value, xdir); else if (db_gain < dbmin) { - *value = xdir || pos == 2 ? submin : prev_submax; + *value = xdir > 0 || pos == 2 ? submin : prev_submax; return 0; } prev_submax = submax; -- 1.8.1.5

2 1

[alsa-devel] [PATCH] amixer: actually print all TLVs in a container TLV
by Anssi Hannula 01 Oct '13

01 Oct '13

Due to a wrong indexing of tlv[] decode_tlv() always skips to the end of the container TLV since the used tlv[1] contains the container TLV size instead of the intended element size. This causes, for example, only the first HDMI channel map TLV to be shown. Fix the indexing to actually use the element size. Signed-off-by: Anssi Hannula <anssi.hannula(a)iki.fi> --- amixer/amixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amixer/amixer.c b/amixer/amixer.c index 7727943..b83b0c3 100644 --- a/amixer/amixer.c +++ b/amixer/amixer.c @@ -468,7 +468,7 @@ static void decode_tlv(unsigned int spaces, unsigned int *tlv, unsigned int tlv_ return; } decode_tlv(spaces + 2, tlv + idx, tlv[idx+1] + 8); - idx += 2 + (tlv[1] + sizeof(unsigned int) - 1) / sizeof(unsigned int); + idx += 2 + (tlv[idx+1] + sizeof(unsigned int) - 1) / sizeof(unsigned int); } break; case SND_CTL_TLVT_DB_SCALE: -- 1.8.1.5

2 1

Re: [alsa-devel] Bug: Conexant CX20588, Kernel 3.11, Win8 changes GPIO settings
by Takashi Iwai 01 Oct '13

01 Oct '13

At Mon, 30 Sep 2013 21:00:38 +0200, Christopher K. wrote: > > Works fine. Thanks for your support. I will now dive into the code to > be able to send you a patch the next time something is wrong :) OK, applied it now. thanks, Takashi > > > Chris > > On Mon, Sep 30, 2013 at 12:19 PM, Takashi Iwai <tiwai(a)suse.de> wrote: > > At Fri, 27 Sep 2013 22:38:22 +0200, > > Christopher wrote: > >> > >> I attached the alsa-info. This issue seems to be specific to the driver > >> provided by Acer (with thx, equalizer etc.) > >> Thanks for your help. > > > > Thanks. Could you check whether the patch below works? > > > > > > Takashi > > > > --- > > From: Takashi Iwai <tiwai(a)suse.de> > > Subject: [PATCH] ALSA: hda - Fix GPIO for Acer Aspire 3830TG > > > > Acer Aspire 3830TG seems requiring GPIO bit 0 as the primary mute > > control. When a machine is booted after Windows 8, the GPIO pin is > > turned off and it results in the silent output. > > > > This patch adds the manual fixup of GPIO bit 0 for this model. > > > > Reported-by: Christopher <DIDI2002(a)web.de> > > Cc: <stable(a)vger.kernel.org> > > Signed-off-by: Takashi Iwai <tiwai(a)suse.de> > > --- > > sound/pci/hda/patch_conexant.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > > index 4edd2d0..ec68eae 100644 > > --- a/sound/pci/hda/patch_conexant.c > > +++ b/sound/pci/hda/patch_conexant.c > > @@ -3231,6 +3231,7 @@ enum { > > CXT_FIXUP_INC_MIC_BOOST, > > CXT_FIXUP_HEADPHONE_MIC_PIN, > > CXT_FIXUP_HEADPHONE_MIC, > > + CXT_FIXUP_GPIO1, > > }; > > > > static void cxt_fixup_stereo_dmic(struct hda_codec *codec, > > @@ -3375,6 +3376,15 @@ static const struct hda_fixup cxt_fixups[] = { > > .type = HDA_FIXUP_FUNC, > > .v.func = cxt_fixup_headphone_mic, > > }, > > + [CXT_FIXUP_GPIO1] = { > > + .type = HDA_FIXUP_VERBS, > > + .v.verbs = (const struct hda_verb[]) { > > + { 0x01, AC_VERB_SET_GPIO_MASK, 0x01 }, > > + { 0x01, AC_VERB_SET_GPIO_DIRECTION, 0x01 }, > > + { 0x01, AC_VERB_SET_GPIO_DATA, 0x01 }, > > + { } > > + }, > > + }, > > }; > > > > static const struct snd_pci_quirk cxt5051_fixups[] = { > > @@ -3384,6 +3394,7 @@ static const struct snd_pci_quirk cxt5051_fixups[] = { > > > > static const struct snd_pci_quirk cxt5066_fixups[] = { > > SND_PCI_QUIRK(0x1025, 0x0543, "Acer Aspire One 522", CXT_FIXUP_STEREO_DMIC), > > + SND_PCI_QUIRK(0x1025, 0x054c, "Acer Aspire 3830TG", CXT_FIXUP_GPIO1), > > SND_PCI_QUIRK(0x1043, 0x138d, "Asus", CXT_FIXUP_HEADPHONE_MIC_PIN), > > SND_PCI_QUIRK(0x17aa, 0x20f2, "Lenovo T400", CXT_PINCFG_LENOVO_TP410), > > SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo T410", CXT_PINCFG_LENOVO_TP410), > > -- > > 1.8.4 > > >

1 0

Re: [alsa-devel] Realtek ALC286 SONY Vaio Pro 13 Ubuntu 13.10
by David Henningsson 01 Oct '13

01 Oct '13

On 10/01/2013 08:13 AM, Yuval Levy wrote: > Thank you for the quick reply. > > On 09/30/2013 03:50 AM, David Henningsson wrote: >> An important distinction is here: to they work in Windows without >> specific Realtek drivers installed, or do you require Realtek's Windows >> drivers for this support? > > I am 99% certain that yes. I am no Windows expert. After taking > delivery of the laptop and ascertaining that the functionality that I > need works, I have backed up SONY's original stuff and stored it away. > Far away. I have reformatted the SDD, leaving 30 GB for a Windows > install (because unfortunately, the law school's exam system requires > either Windows or Mac). I reinstalled Windows from Microsoft's media. > I have not installed any other driver myself, but I am not sure if > Windows downloads drivers from the internet. It definitely did download > drivers for my Brother printer, automatically and without asking for > permission, after it discovered it on the network. I booted into > Windows before writing this email and looked in the Control Panel. It > says the driver for the two microsoft and for the loudspeakers is Microsoft. Ok. If things work without extra drivers from Sony or Realtek, then it should be possible to get things working in Linux too without extra information from these parties... >> Second, to do some actual triaging. I see you have been running >> hda-jack-sense-test. Could you run it all three scenarios: >> 1) nothing connected >> 2) headphone (without mic) connected >> 3) headset (heaphone + mic combo) connected > > Done and added to the bug report. 0x21 works as you expected. 0x18 not. > > As you suggested I installed alsa-tools-gui and did the advance override > with hdajackretask: > * selected codec Realtek ALC286 > * clicked Advance override in the Options on the right hand side > * clicked Override under pins 0x18 and 0x21 > * changed Jack detection from Present to Not present for both pins Ok - given that 0x21 works as expected you should only need to do this for pin 0x18. > * clicked Apply now > > An error message appeared: Failed to create file > '/home/yuv/.pulse/client.conf.3K083W': No such file or directory > > maybe it should save to /home/yuv/.config/pulse/client.conf.3K083W? > ^^^^^^^ > I am sorry I do not know how to fix this, can you help? Oh. That's fixed upstream [1], but apparently not in Ubuntu yet. Any of these workarounds should do it: 1) use the "boot override" instead (and reboot your computer to test) 2) create a symlink from .pulse to .config/pulse 3) or copy everything from .config/pulse to .pulse (but then you have to restart your computer afterwards, so PulseAudio will look in .pulse instead). -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic [1] http://git.alsa-project.org/?p=alsa-tools.git;a=commitdiff;h=772fbde91c00c8…

1 0

[alsa-devel] [PATCH v2] ASoC: imx-sgtl5000: do not use devres on a foreign device
by Philipp Zabel 01 Oct '13

01 Oct '13

Calling devm_clk_get with any device pointer other than our own confuses devres. Use clk_get instead. This avoids hitting the following warning in the imx-sgtl5000 error path: imx-sgtl5000 sound.12: snd_soc_register_card failed (-517) platform sound.12: Driver imx-sgtl5000 requests probe deferral ------------[ cut here ]------------ WARNING: CPU: 0 PID: 75 at drivers/base/dd.c:272 driver_probe_device+0x194/0x218() Modules linked in: snd_soc_sgtl5000(+) snd_soc_imx_sgtl5000 coda snd_soc_imx_audmux imx_sdma snd_soc_fsl_spdif snd_soc_fsl_ssi CPU: 0 PID: 75 Comm: udevd Not tainted 3.11.0-rc6+ #4682 Backtrace: [<80010bc4>] (dump_backtrace+0x0/0x10c) from [<80010d60>] (show_stack+0x18/0x1c) r6:00000110 r5:00000009 r4:00000000 r3:00000000 [<80010d48>] (show_stack+0x0/0x1c) from [<804f0764>] (dump_stack+0x20/0x28) [<804f0744>] (dump_stack+0x0/0x28) from [<8001a4a4>] (warn_slowpath_common+0x6c/0x8c) [<8001a438>] (warn_slowpath_common+0x0/0x8c) from [<8001a4e8>] (warn_slowpath_null+0x24/0x2c) r8:7f032000 r7:7f02f93c r6:cf8eaa54 r5:cf8eaa20 r4:80728a0c [<8001a4c4>] (warn_slowpath_null+0x0/0x2c) from [<80286bdc>] (driver_probe_device+0x194/0x218) [<80286a48>] (driver_probe_device+0x0/0x218) from [<80286cf4>] (__driver_attach+0x94/0x98) r7:00000000 r6:cf8eaa54 r5:7f02f93c r4:cf8eaa20 [<80286c60>] (__driver_attach+0x0/0x98) from [<802851c8>] (bus_for_each_dev+0x5c/0x90) r6:80286c60 r5:7f02f93c r4:00000000 r3:cf8ef03c [<8028516c>] (bus_for_each_dev+0x0/0x90) from [<80286654>] (driver_attach+0x24/0x28) r6:806d0424 r5:cf16a580 r4:7f02f93c [<80286630>] (driver_attach+0x0/0x28) from [<802861e4>] (bus_add_driver+0xdc/0x234) [<80286108>] (bus_add_driver+0x0/0x234) from [<802871d4>] (driver_register+0x80/0x154) r8:7f032000 r7:00000001 r6:7f02fa68 r5:7f02fa74 r4:7f02f93c [<80287154>] (driver_register+0x0/0x154) from [<8033c278>] (i2c_register_driver+0x34/0xbc) [<8033c244>] (i2c_register_driver+0x0/0xbc) from [<7f032018>] (sgtl5000_i2c_driver_init+0x18/0x24 [snd_soc_sgtl5000]) r5:7f02fa74 r4:cfb7ff48 [<7f032000>] (sgtl5000_i2c_driver_init+0x0/0x24 [snd_soc_sgtl5000]) from [<80008738>] (do_one_initcall+0xf4/0x150) [<80008644>] (do_one_initcall+0x0/0x150) from [<80053f64>] (load_module+0x174c/0x1db4) [<80052818>] (load_module+0x0/0x1db4) from [<800546ac>] (SyS_init_module+0xe0/0xf4) [<800545cc>] (SyS_init_module+0x0/0xf4) from [<8000e540>] (ret_fast_syscall+0x0/0x30) r6:00005b22 r5:00afed68 r4:00000000 ---[ end trace b24c5c3bb145dbdd ]--- Signed-off-by: Philipp Zabel <p.zabel(a)pengutronix.de> Acked-by: Shawn Guo <shawn.guo(a)linaro.org> Reviewed-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- Changes since v1: - Rebased onto asoc/for-next, adding back imx_sgtl5000_remove. --- sound/soc/fsl/imx-sgtl5000.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 78f86d8..c49e4cb 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -128,7 +128,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) goto fail; } - data->codec_clk = devm_clk_get(&codec_dev->dev, NULL); + data->codec_clk = clk_get(&codec_dev->dev, NULL); if (IS_ERR(data->codec_clk)) { ret = PTR_ERR(data->codec_clk); goto fail; @@ -172,6 +172,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) return 0; fail: + if (!IS_ERR(data->codec_clk)) + clk_put(data->codec_clk); if (ssi_np) of_node_put(ssi_np); if (codec_np) @@ -180,6 +182,15 @@ fail: return ret; } +static int imx_sgtl5000_remove(struct platform_device *pdev) +{ + struct imx_sgtl5000_data *data = platform_get_drvdata(pdev); + + clk_put(data->codec_clk); + + return 0; +} + static const struct of_device_id imx_sgtl5000_dt_ids[] = { { .compatible = "fsl,imx-audio-sgtl5000", }, { /* sentinel */ } -- 1.8.4.rc3

3 2