January 2013 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH V6 10/10] dmaengine: Fix compilation error in non-DT case
by Vinod Koul 29 Jan '13

29 Jan '13

On Fri, Jan 18, 2013 at 05:17:09PM +0530, Padmavathi Venna wrote: > Signed-off-by: Padmavathi Venna <padma.v(a)samsung.com> > --- > include/linux/dmaengine.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 8cd0e25..c88f302 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -992,7 +992,7 @@ static inline struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, > static inline struct dma_chan *dma_request_slave_channel(struct device *dev, > char *name) > { > - return NULL > + return NULL; what tree was this generated against? this was fixed by 678bd8 -- ~Vinod

2 1

Re: [alsa-devel] [PATCH V6 09/10] ASoC: Samsung: Update Kconfig for I2S, SPDIF and PCM audio
by Mark Brown 29 Jan '13

29 Jan '13

On Fri, Jan 18, 2013 at 05:17:08PM +0530, Padmavathi Venna wrote: > Update Kconfig file to enable I2S,PCM audio for wm8994 and spdif on all > samsung platforms. Applied, thanks.

1 0

Re: [alsa-devel] [PATCH V6 08/10] ARM: dts: Modify SPI nodes according generic DMA DT bindings
by Mark Brown 29 Jan '13

29 Jan '13

On Fri, Jan 18, 2013 at 05:17:07PM +0530, Padmavathi Venna wrote: > This patch removes custom way of adding spi dma channels and > adds according to new generic DMA DT bindings. Applied, thanks.

1 0

Re: [alsa-devel] [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers
by Arnd Bergmann 28 Jan '13

28 Jan '13

On Monday 28 January 2013, Jon Hunter wrote: > On 01/28/2013 08:51 AM, Arnd Bergmann wrote: > > On Friday 18 January 2013, Padmavathi Venna wrote: > >> + pfi = devm_kzalloc(&adev->dev, sizeof(*pfi), GFP_KERNEL); > >> + if (!pfi) { > >> + dev_err(&adev->dev, "unable to allocate mem\n"); > >> + return -ENOMEM; > >> + } > >> + > >> + pfi->dma_cap = pd->cap_mask; > >> + pfi->filter_fn = pl330_filter; > >> + > >> + ret = of_dma_controller_register(adev->dev.of_node, > >> + of_dma_pl330_xlate, pfi); > > > > Why do you pass a 'struct of_dma_filter_info' here? I would > > expect that you pass the pdmac object as the third argument. > > I believe it is because that is the data that the xlate function is > using. Are you suggesting the data should be stored in the pdmac object > and extracted from there? That could be done too given that this > controller has its own xlate. It just seems weird that we are passing a constant cap_mask in a data structure, and that we need our own filter function still, but don't pass the pointer to the data structure that we actually need in the filter function (the dma_device *). Arnd

1 0

Re: [alsa-devel] [PATCH 0/4] Add generic DMA DT binding support
by Vinod Koul 28 Jan '13

28 Jan '13

On Fri, Jan 18, 2013 at 05:03:40PM +0530, Padmavathi Venna wrote: > This patch set adds support for generic dma device tree bindings for > Samsung platforms and is dependent on the following patches from > Vinod Koul next branch > 1)of: Add generic device tree DMA helpers > 2)dmaengine: add helper function to request a slave DMA channel Changes look fairly decent. I need somone with better knowldge of DT to akc this before this is applied. Arnd...? > > This patch set is made based Kukjin Kim for-next branch > > Padmavathi Venna (4): > DMA: PL330: Add xlate function > DMA: PL330: Register the DMA controller with the generic DMA helpers > ARM: dts: Add #dma-cells for generic dma binding support > DMA: PL330: Modify pl330 filter based on new generic dma dt bindings. > > .../devicetree/bindings/dma/arm-pl330.txt | 9 +++- > arch/arm/boot/dts/exynos5250.dtsi | 4 ++ > drivers/dma/pl330.c | 48 ++++++++++++++++---- > 3 files changed, 49 insertions(+), 12 deletions(-) > > -- > 1.7.4.4 >

2 1

Re: [alsa-devel] [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers
by Arnd Bergmann 28 Jan '13

28 Jan '13

On Friday 18 January 2013, Padmavathi Venna wrote: > + pfi = devm_kzalloc(&adev->dev, sizeof(*pfi), GFP_KERNEL); > + if (!pfi) { > + dev_err(&adev->dev, "unable to allocate mem\n"); > + return -ENOMEM; > + } > + > + pfi->dma_cap = pd->cap_mask; > + pfi->filter_fn = pl330_filter; > + > + ret = of_dma_controller_register(adev->dev.of_node, > + of_dma_pl330_xlate, pfi); Why do you pass a 'struct of_dma_filter_info' here? I would expect that you pass the pdmac object as the third argument. Arnd

1 0

[alsa-devel] Some information about UsbPre2 UAC2 support
by shal＠free.fr 28 Jan '13

28 Jan '13

Hi all, The Sound Devices USBPre2 is an UAC2 device but recognized as a UAC1 device by Linux. I have spend some time in order to found a solution. I have successfully setup my sound card as a UAC2 mode and I can play/record a 24/192khz without problem. But my solution is very ugly and cannot be considered as a real solution. Perhaps alsa developers have an idea to integrated UAC2 support for the USBPRe2 in the standard stack.... There is two distinct problems: - The sound card recognizes Linux as a Windows OS and send a incorrect device descriptor. - The USB stack choose the bad configuration descriptor. More details on first problem: For some compatibility raison, Sound device developer want only send a UAC1 configuration when the Operating system is Windows. The used method is based on the length of the setup packet during the device get_descriptor function. If the length is 64, the OS is considered as Windows. Linux have choosen also this value. Extract of kernel source code: " NOTE: If USE_NEW_SCHEME() is true we will start by issuing a 64-byte GET_DESCRIPTOR request. This is what Windows does, so it may help with some non-standards-compliant devices." So I have patched my kernel. In driver/usb/core/hub.c: #define GET_DESCRIPTOR_BUFSIZE 65 (instead 64) This solve the first problem. More details on the second problem: Now, the USB device descriptor has two configuration descriptors :the first is a UAC1 and the second is a UAC2. My "lsusb -v -d 0926:" can be view at: http://pastebin.com/nFTN2E04 As UAC1 is a valid configuration descriptor, the usb stack choose this configuration. I have patched the usb_choose_configuration() function in file driver/usb/core/generic.c for overwrite the value with the good one. That all, no other problem was detected. The Linux UAC2 stack seems to be OK with this sound card. I joined (ugly) patches , built on linux 3.7.1. If you have an idea about how have a standard support of UAC2 for the Sound Devices USBPRe2, I (and a lot of people) will be happy. Thanks Olivier PS: A thread exists on LAU : http://lists.linuxaudio.org/pipermail/linux-audio-user/2013-January/089199.…

2 5

[alsa-devel] [PATCH] ALSA: hda - Fix powermap for external mics on IDT codecs
by David Henningsson 28 Jan '13

28 Jan '13

This patch fixes a regression of the external mic not working on HP Probook 4520s. Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_sigmatel.c | 8 ++++++++ 1 file changed, 8 insertions(+) This is why my external mic stopped working; I now had some time to track it down. Alsa-info at http://paste.ubuntu.com/1579993/ diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 1c49861..951fc0d 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -502,6 +502,13 @@ static void stac_line_automute(struct hda_codec *codec, jack_update_power(codec, jack); } +static void stac_mic_autoswitch(struct hda_codec *codec, + struct hda_jack_tbl *jack) +{ + snd_hda_gen_mic_autoswitch(codec, jack); + jack_update_power(codec, jack); +} + static void stac_vref_event(struct hda_codec *codec, struct hda_jack_tbl *event) { unsigned int data; @@ -3509,6 +3516,7 @@ static int stac_parse_auto_config(struct hda_codec *codec) spec->gen.automute_hook = stac_update_outputs; spec->gen.hp_automute_hook = stac_hp_automute; spec->gen.line_automute_hook = stac_line_automute; + spec->gen.mic_autoswitch_hook = stac_mic_autoswitch; err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) -- 1.7.9.5

2 1

[alsa-devel] [PATCH] ucm: Set uc_mgr->ctl to NULL after closing it.
by Tanu Kaskinen 28 Jan '13

28 Jan '13

Fixes a double-free bug. Signed-off-by: Tanu Kaskinen <tanuk(a)iki.fi> --- src/ucm/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ucm/main.c b/src/ucm/main.c index 0d7d841..d8b8ada 100644 --- a/src/ucm/main.c +++ b/src/ucm/main.c @@ -145,6 +145,7 @@ static int open_ctl(snd_use_case_mgr_t *uc_mgr, free(uc_mgr->ctl_dev); uc_mgr->ctl_dev = NULL; snd_ctl_close(uc_mgr->ctl); + uc_mgr->ctl = NULL; } err = snd_ctl_open(ctl, ctl_dev, 0); -- 1.7.10.4

3 2

Re: [alsa-devel] 3.7 HDMI channel map regression
by Takashi Iwai 28 Jan '13

28 Jan '13

At Sun, 27 Jan 2013 19:18:27 -0600, Shawn Bohrer wrote: > > Hi Takashi, > > I recently updated my HTPC from 3.6.11 to 3.7.2 and this caused my RL > and FC channels to swap, and my RR and LFE channels to swap for PCM > audio. Doing a git bisect identified > d45e6889ee69456a4d5b1bbb32252f460cd48fa9 "ALSA: hda - Provide the > proper channel mapping for generic HDMI driver" as the commit that > caused my channels to swap. The commit doesn't revert cleanly on > 3.7.4, and I haven't really looked to see what the correct fix might > be. > > Some info that may be relevant, the sound card is a: > > 00:1b.0 Audio device: Intel Corporation 7 Series/C210 Series Chipset > Family High Definition Audio Controller (rev 04) > > The machine is running Fedora 18 and audio goes over HDMI to a 5.1 > receiver. I'm not really sure what other info you might need, but > let me know if you need something else or have any patches you would > like me to test. OK, it's the first time to get a bug report about this. Could you tell me how did you test it (i.e. which application, which sound backend)? Can you confirm that it's reproduced via speaker-test program in alsa-utils package? For further debugging, please give the following: - alsa-info.sh output while playing 5.1 sound - /proc/asound/card*/eld* contents while playing 5.1 sound Also, try to update alsa-lib and alsa-utils from alsa-project.org git tree, and build alsa-lib/test/chmap program. % cd alsa-lib/test % make chmap and run like ./chmap -Dhdmi:1 query (-Dhdmi:1 might be different depending on the system setup) thanks, Takashi

1 0