January 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 0/8] ASoC: OMAP-twl4030: Add support for more3 boards
by Peter Ujfalusi 02 Jan '13

02 Jan '13

Hello, This series will update the omap-twl4030 machine driver and the twl4030 codec driver to enable support for more boards. With this change we can remove two more machine drivers: zoom2 and sdp3430 since they will be supported by the common omap-twl4030 machine driver. The arch/arm/mach-omap2/ patches will go as a separate series to avoid cross tree issues. Regards, Peter --- Peter Ujfalusi (8): ASoC: twl4030: Correct the support for Voice port ASoC: zoom2: No need to configure the Voice port anymore ASoC: sdp3430: No need to configure the Voice port anymore ASoC: twl4030: Convert MICBIAS to SUPPLY widget ASoC: twl4030: Configure extmute pinmux when the dedicated pin is in use ASoC: sdp3430: No need to configure pin mux for extmute ASoC: omap-twl4030: Add support for routing, voice port and jack detect ASoC: OMAP: Remove obsolete machine drivers for Zoom2 and SDP3430 .../devicetree/bindings/sound/omap-twl4030.txt | 46 ++++ sound/soc/codecs/twl4030.c | 71 ++++-- sound/soc/omap/Kconfig | 19 +- sound/soc/omap/Makefile | 4 - sound/soc/omap/omap-twl4030.c | 204 ++++++++++++++- sound/soc/omap/omap3pandora.c | 8 +- sound/soc/omap/sdp3430.c | 278 --------------------- sound/soc/omap/zoom2.c | 207 --------------- 8 files changed, 304 insertions(+), 533 deletions(-) delete mode 100644 sound/soc/omap/sdp3430.c delete mode 100644 sound/soc/omap/zoom2.c -- 1.8.0.2

2 9

[alsa-devel] [PATCH] ASoC: pxa2xx-ac97: fix oops when codec_driver probe runs
by Mike Dunn 02 Jan '13

02 Jan '13

This patch fixes a kernel oops that occurs when the snd_soc_codec_driver probe function runs. The exception occurs when the codec calls soc_ac97_ops.reset(). The pxa2xx-ac97's clocks have not been initialized at this point, but the cpu's reset function (pxa_ac97_cold_pxa27x()) expects them to be, resulting in a NULL pointer dereference in the pxa's clk_enable(). The pxa2xx-ac97's clocks are initialized in pxa2xx_ac97_hw_probe(). To ensure that the clocks are initialized when the codec_driver probe runs, the calls to pxa2xx_ac97_hw_{probe,remove}() are moved from the cpu's dai_driver probe/remove functions to those of its platform_driver. This is necessary because snd_soc_instantiate_card() always calls the codec_driver probe before any of the dai_drivers' probes. This change leaves nothing in the cpu's dai_driver probe/remove functions, so those functions are eliminated. Tested on the pxa27x; palmtreo680 machine using the wm9712 codec. Signed-off-by: Mike Dunn <mikedunn(a)newsguy.com> --- I'm new to the ASoC code. Experts, please have a look. Thanks! sound/soc/pxa/pxa2xx-ac97.c | 38 +++++++++++++++++++------------------- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/sound/soc/pxa/pxa2xx-ac97.c b/sound/soc/pxa/pxa2xx-ac97.c index 4b0a009..940e9f4 100644 --- a/sound/soc/pxa/pxa2xx-ac97.c +++ b/sound/soc/pxa/pxa2xx-ac97.c @@ -104,17 +104,6 @@ static int pxa2xx_ac97_resume(struct snd_soc_dai *dai) #define pxa2xx_ac97_resume NULL #endif -static int pxa2xx_ac97_probe(struct snd_soc_dai *dai) -{ - return pxa2xx_ac97_hw_probe(to_platform_device(dai->dev)); -} - -static int pxa2xx_ac97_remove(struct snd_soc_dai *dai) -{ - pxa2xx_ac97_hw_remove(to_platform_device(dai->dev)); - return 0; -} - static int pxa2xx_ac97_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *cpu_dai) @@ -184,8 +173,6 @@ static struct snd_soc_dai_driver pxa_ac97_dai_driver[] = { { .name = "pxa2xx-ac97", .ac97_control = 1, - .probe = pxa2xx_ac97_probe, - .remove = pxa2xx_ac97_remove, .suspend = pxa2xx_ac97_suspend, .resume = pxa2xx_ac97_resume, .playback = { @@ -236,21 +223,34 @@ EXPORT_SYMBOL_GPL(soc_ac97_ops); static int pxa2xx_ac97_dev_probe(struct platform_device *pdev) { + int ret; + if (pdev->id != -1) { dev_err(&pdev->dev, "PXA2xx has only one AC97 port.\n"); return -ENXIO; } - /* Punt most of the init to the SoC probe; we may need the machine - * driver to do interesting things with the clocking to get us up - * and running. - */ - return snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver, - ARRAY_SIZE(pxa_ac97_dai_driver)); + ret = snd_soc_register_dais(&pdev->dev, pxa_ac97_dai_driver, + ARRAY_SIZE(pxa_ac97_dai_driver)); + if (ret < 0) { + dev_err(&pdev->dev, "snd_soc_register_dais failed with %d\n", + ret); + return ret; + } + + ret = pxa2xx_ac97_hw_probe(pdev); + if (ret < 0) { + dev_err(&pdev->dev, "pxa2xx_ac97_hw_probe failed with %d\n", + ret); + snd_soc_unregister_dais(&pdev->dev, + ARRAY_SIZE(pxa_ac97_dai_driver)); + } + return ret; } static int pxa2xx_ac97_dev_remove(struct platform_device *pdev) { + pxa2xx_ac97_hw_remove(pdev); snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(pxa_ac97_dai_driver)); return 0; } -- 1.7.8.6

2 1

[alsa-devel] Looking for ALSA developer
by Eben Upton 01 Jan '13

01 Jan '13

We're looking for someone to do some contract development on the ALSA driver for the Raspberry Pi. Would anyone here be interested in taking this on? A little background: Our driver is architecturally fairly similar to a USB sound card driver, sitting on top of a stream-like connection to a remote entity implemented in software on an internal DSP. Due to our limited understanding of ALSA internals, there are a number of bugs which lead to underrun conditions in common audio applications, and we'd like to pay someone on and hourly basis to go through the failing cases, root cause them, and propose patches. Eben Upton Executive Director, Raspberry Pi Foundation

1 0