January 2013 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] hda-emu: Make it work with sound-unstable.git
by David Henningsson 15 Jan '13

15 Jan '13

To be able to build the new code (so we can run aggregate tests on it) the following patch needs to be applied. Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- configure.ac | 8 +++++++ hda-ctlsh.c | 5 ++++ include/linux/ctype.h | 64 +++++++++++++++++++++++++++++++++++++++++++++++++ snd-wrapper.c | 32 +++++++++++++++++++++++++ 4 files changed, 109 insertions(+) create mode 100644 include/linux/ctype.h diff --git a/configure.ac b/configure.ac index 3103eb5..80b68a6 100644 --- a/configure.ac +++ b/configure.ac @@ -182,6 +182,14 @@ if test "$OLD_HDA_CMD" = "1"; then AC_DEFINE(OLD_HDA_CMD) fi +AC_MSG_CHECKING(for user_mutex) +if grep -q 'struct mutex user_mutex' hda/hda_codec.h; then + AC_DEFINE(HAVE_USER_MUTEX) + AC_MSG_RESULT(yes) +else + AC_MSG_RESULT(no) +fi + AC_MSG_CHECKING(for new pm_notify callback) ac_save_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -Iinclude" diff --git a/hda-ctlsh.c b/hda-ctlsh.c index 5ad95fc..04fc318 100644 --- a/hda-ctlsh.c +++ b/hda-ctlsh.c @@ -537,6 +537,11 @@ int snd_hda_get_bool_hint(struct hda_codec *codec, const char *key) return -ENOENT; } +int snd_hda_get_int_hint(struct hda_codec *codec, const char *key, int *valp) +{ + return -ENOENT; +} + #ifdef HAVE_USER_PINCFGS static void get_drv_pincfgs(void) { diff --git a/include/linux/ctype.h b/include/linux/ctype.h new file mode 100644 index 0000000..8acfe31 --- /dev/null +++ b/include/linux/ctype.h @@ -0,0 +1,64 @@ +#ifndef _LINUX_CTYPE_H +#define _LINUX_CTYPE_H + +/* + * NOTE! This ctype does not handle EOF like the standard C + * library is required to. + */ + +#define _U 0x01 /* upper */ +#define _L 0x02 /* lower */ +#define _D 0x04 /* digit */ +#define _C 0x08 /* cntrl */ +#define _P 0x10 /* punct */ +#define _S 0x20 /* white space (space/lf/tab) */ +#define _X 0x40 /* hex digit */ +#define _SP 0x80 /* hard space (0x20) */ + +extern const unsigned char _ctype[]; + +#define __ismask(x) (_ctype[(int)(unsigned char)(x)]) + +#define isalnum(c) ((__ismask(c)&(_U|_L|_D)) != 0) +#define isalpha(c) ((__ismask(c)&(_U|_L)) != 0) +#define iscntrl(c) ((__ismask(c)&(_C)) != 0) +#define isdigit(c) ((__ismask(c)&(_D)) != 0) +#define isgraph(c) ((__ismask(c)&(_P|_U|_L|_D)) != 0) +#define islower(c) ((__ismask(c)&(_L)) != 0) +#define isprint(c) ((__ismask(c)&(_P|_U|_L|_D|_SP)) != 0) +#define ispunct(c) ((__ismask(c)&(_P)) != 0) +/* Note: isspace() must return false for %NUL-terminator */ +#define isspace(c) ((__ismask(c)&(_S)) != 0) +#define isupper(c) ((__ismask(c)&(_U)) != 0) +#define isxdigit(c) ((__ismask(c)&(_D|_X)) != 0) + +#define isascii(c) (((unsigned char)(c))<=0x7f) +#define toascii(c) (((unsigned char)(c))&0x7f) + +static inline unsigned char __tolower(unsigned char c) +{ + if (isupper(c)) + c -= 'A'-'a'; + return c; +} + +static inline unsigned char __toupper(unsigned char c) +{ + if (islower(c)) + c -= 'a'-'A'; + return c; +} + +#define tolower(c) __tolower(c) +#define toupper(c) __toupper(c) + +/* + * Fast implementation of tolower() for internal usage. Do not use in your + * code. + */ +static inline char _tolower(const char c) +{ + return c | 0x20; +} + +#endif diff --git a/snd-wrapper.c b/snd-wrapper.c index 69cd19c..c2649d9 100644 --- a/snd-wrapper.c +++ b/snd-wrapper.c @@ -27,6 +27,35 @@ #include "hda/hda_codec.h" #include "hda-types.h" #include "hda-log.h" +#include <linux/ctype.h> + +/* Copied from lib/ctype.c */ +const unsigned char _ctype[] = { +_C,_C,_C,_C,_C,_C,_C,_C, /* 0-7 */ +_C,_C|_S,_C|_S,_C|_S,_C|_S,_C|_S,_C,_C, /* 8-15 */ +_C,_C,_C,_C,_C,_C,_C,_C, /* 16-23 */ +_C,_C,_C,_C,_C,_C,_C,_C, /* 24-31 */ +_S|_SP,_P,_P,_P,_P,_P,_P,_P, /* 32-39 */ +_P,_P,_P,_P,_P,_P,_P,_P, /* 40-47 */ +_D,_D,_D,_D,_D,_D,_D,_D, /* 48-55 */ +_D,_D,_P,_P,_P,_P,_P,_P, /* 56-63 */ +_P,_U|_X,_U|_X,_U|_X,_U|_X,_U|_X,_U|_X,_U, /* 64-71 */ +_U,_U,_U,_U,_U,_U,_U,_U, /* 72-79 */ +_U,_U,_U,_U,_U,_U,_U,_U, /* 80-87 */ +_U,_U,_U,_P,_P,_P,_P,_P, /* 88-95 */ +_P,_L|_X,_L|_X,_L|_X,_L|_X,_L|_X,_L|_X,_L, /* 96-103 */ +_L,_L,_L,_L,_L,_L,_L,_L, /* 104-111 */ +_L,_L,_L,_L,_L,_L,_L,_L, /* 112-119 */ +_L,_L,_L,_P,_P,_P,_P,_C, /* 120-127 */ +0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 128-143 */ +0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 144-159 */ +_S|_SP,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P, /* 160-175 */ +_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P,_P, /* 176-191 */ +_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U,_U, /* 192-207 */ +_U,_U,_U,_U,_U,_U,_U,_P,_U,_U,_U,_U,_U,_U,_U,_L, /* 208-223 */ +_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L,_L, /* 224-239 */ +_L,_L,_L,_L,_L,_L,_L,_P,_L,_L,_L,_L,_L,_L,_L,_L}; /* 240-255 */ + int snd_pcm_format_width(int format) { @@ -46,6 +75,9 @@ int snd_pcm_format_width(int format) int snd_hda_create_hwdep(struct hda_codec *codec) { +#ifdef HAVE_USER_MUTEX + mutex_init(&codec->user_mutex); +#endif return 0; } -- 1.7.9.5

2 1

[alsa-devel] [PATCH 0/2] A couple of pending HD-audio patches
by Takashi Iwai 15 Jan '13

15 Jan '13

Hi, these are yet another couple of HD-audio patches, one for merging to 3.8, and another an enhancement for 3.9. Takashi

1 2

[alsa-devel] [PATCH 00/12] Use standard fixup table for STAC/IDT codecs
by Takashi Iwai 15 Jan '13

15 Jan '13

Hi, this is a series of patches to convert the STAC/IDT codec parser to use the standard fixup table. Obviously it's a step forward for the migration of patch_sigmatel.c to the generic parser. Takashi

1 13

[alsa-devel] [PATCH RFC 0/2] Yet more patches for HD-audio generic parser
by Takashi Iwai 15 Jan '13

15 Jan '13

Hi, these two patches have slipped from the previous patch series. Takashi

1 2

[alsa-devel] sound/pci/hda/patch_sigmatel.c:2219:24: warning: unused variable 'spec'
by Fengguang Wu 15 Jan '13

15 Jan '13

Hi Takashi, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master head: 629965377895ebe6a546184911d588fd29596dc8 commit: 8018ee4e722f6c408d475262b54dc8a73fdd349f ALSA: hda - Use standard fixup table for IDT92HD71Bxx date: 2 hours ago config: make ARCH=i386 defconfig All warnings: sound/pci/hda/patch_sigmatel.c: In function 'stac92hd71bxx_fixup_hp': >> sound/pci/hda/patch_sigmatel.c:2219:24: warning: unused variable 'spec' [-Wunused-variable] vim +/spec +2219 sound/pci/hda/patch_sigmatel.c 8018ee4e Takashi Iwai 2013-01-14 2216 static void stac92hd71bxx_fixup_hp(struct hda_codec *codec, 8018ee4e Takashi Iwai 2013-01-14 2217 const struct hda_fixup *fix, int action) 8018ee4e Takashi Iwai 2013-01-14 2218 { 8018ee4e Takashi Iwai 2013-01-14 @2219 struct sigmatel_spec *spec = codec->spec; 8018ee4e Takashi Iwai 2013-01-14 2220 8018ee4e Takashi Iwai 2013-01-14 2221 if (action != HDA_FIXUP_ACT_PRE_PROBE) 8018ee4e Takashi Iwai 2013-01-14 2222 return; 8018ee4e Takashi Iwai 2013-01-14 2223 8018ee4e Takashi Iwai 2013-01-14 2224 if (hp_blike_system(codec->subsystem_id)) { 8018ee4e Takashi Iwai 2013-01-14 2225 unsigned int pin_cfg = snd_hda_codec_get_pincfg(codec, 0x0f); 8018ee4e Takashi Iwai 2013-01-14 2226 if (get_defcfg_device(pin_cfg) == AC_JACK_LINE_OUT || 8018ee4e Takashi Iwai 2013-01-14 2227 get_defcfg_device(pin_cfg) == AC_JACK_SPEAKER || --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

2 1

[alsa-devel] sound/pci/hda/patch_sigmatel.c:2260:26: sparse: obsolete array initializer, use C99 syntax
by Fengguang Wu 15 Jan '13

15 Jan '13

Hi Takashi, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git master head: 629965377895ebe6a546184911d588fd29596dc8 commit: 8018ee4e722f6c408d475262b54dc8a73fdd349f ALSA: hda - Use standard fixup table for IDT92HD71Bxx date: 2 hours ago >> sound/pci/hda/patch_sigmatel.c:2260:26: sparse: obsolete array initializer, use C99 syntax sound/pci/hda/patch_sigmatel.c:2266:26: sparse: obsolete array initializer, use C99 syntax vim +2260 sound/pci/hda/patch_sigmatel.c 8018ee4e Takashi Iwai 2013-01-14 2249 static const struct hda_fixup stac92hd71bxx_fixups[] = { 8018ee4e Takashi Iwai 2013-01-14 2250 [STAC_92HD71BXX_REF] = { 8018ee4e Takashi Iwai 2013-01-14 2251 .type = HDA_FIXUP_FUNC, 8018ee4e Takashi Iwai 2013-01-14 2252 .v.func = stac92hd71bxx_fixup_ref, 8018ee4e Takashi Iwai 2013-01-14 2253 }, 8018ee4e Takashi Iwai 2013-01-14 2254 [STAC_DELL_M4_1] = { 8018ee4e Takashi Iwai 2013-01-14 2255 .type = HDA_FIXUP_PINS, 8018ee4e Takashi Iwai 2013-01-14 2256 .v.pins = dell_m4_1_pin_configs, 8018ee4e Takashi Iwai 2013-01-14 2257 .chained = true, 8018ee4e Takashi Iwai 2013-01-14 2258 .chain_id = STAC_92HD71BXX_NO_SMUX, 8018ee4e Takashi Iwai 2013-01-14 2259 }, 8018ee4e Takashi Iwai 2013-01-14 @2260 [STAC_DELL_M4_2] { 8018ee4e Takashi Iwai 2013-01-14 2261 .type = HDA_FIXUP_PINS, 8018ee4e Takashi Iwai 2013-01-14 2262 .v.pins = dell_m4_2_pin_configs, 8018ee4e Takashi Iwai 2013-01-14 2263 .chained = true, 8018ee4e Takashi Iwai 2013-01-14 2264 .chain_id = STAC_92HD71BXX_NO_DMIC, 8018ee4e Takashi Iwai 2013-01-14 2265 }, 8018ee4e Takashi Iwai 2013-01-14 2266 [STAC_DELL_M4_3] { 8018ee4e Takashi Iwai 2013-01-14 2267 .type = HDA_FIXUP_PINS, 8018ee4e Takashi Iwai 2013-01-14 2268 .v.pins = dell_m4_3_pin_configs, --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

2 1

[alsa-devel] [PATCH 1/4] ALSA: hdsp - Fix detection for RME RPM/Multiface/Digiface ioboxes
by Adrian Knoth 15 Jan '13

15 Jan '13

The current iobox detection code reportedly fails for various users, so simply do what the Win32 driver does instead. Patch originally by Karl Grill <kgrill(a)chello.at> and then modified to comply with kernel coding guidelines + current HEAD. Signed-off-by: Karl Grill <kgrill(a)chello.at> Signed-off-by: Adrian Knoth <adi(a)drcomp.erfurt.thur.de> diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 4fae81f..bcad9ba 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -154,10 +154,11 @@ MODULE_FIRMWARE("digiface_firmware_rev11.bin"); #define HDSP_BIGENDIAN_MODE 0x200 #define HDSP_RD_MULTIPLE 0x400 #define HDSP_9652_ENABLE_MIXER 0x800 +#define HDSP_DUNNO 0x1000 #define HDSP_TDO 0x10000000 -#define HDSP_S_PROGRAM (HDSP_PROGRAM|HDSP_CONFIG_MODE_0) -#define HDSP_S_LOAD (HDSP_PROGRAM|HDSP_CONFIG_MODE_1) +#define HDSP_S_PROGRAM (HDSP_DUNNO|HDSP_PROGRAM|HDSP_CONFIG_MODE_0) +#define HDSP_S_LOAD (HDSP_DUNNO|HDSP_PROGRAM|HDSP_CONFIG_MODE_1) /* Control Register bits */ @@ -671,13 +672,23 @@ static unsigned int hdsp_read(struct hdsp *hdsp, int reg) static int hdsp_check_for_iobox (struct hdsp *hdsp) { + int i; + if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return 0; - if (hdsp_read (hdsp, HDSP_statusRegister) & HDSP_ConfigError) { - snd_printk("Hammerfall-DSP: no IO box connected!\n"); - hdsp->state &= ~HDSP_FirmwareLoaded; - return -EIO; + for (i = 0; i < 500; i++) { + if (0 == (hdsp_read(hdsp, HDSP_statusRegister) & + HDSP_ConfigError)) { + if (i) { + snd_printk("Hammerfall-DSP: IO box found after %d ms\n", + i); + } + return 0; + } + msleep(20); } - return 0; + snd_printk("Hammerfall-DSP: no IO box connected!\n"); + hdsp->state &= ~HDSP_FirmwareLoaded; + return -EIO; } static int hdsp_wait_for_iobox(struct hdsp *hdsp, unsigned int loops, @@ -728,6 +739,7 @@ static int snd_hdsp_load_firmware_from_cache(struct hdsp *hdsp) { if (hdsp_fifo_wait (hdsp, 0, HDSP_LONG_WAIT)) { snd_printk ("Hammerfall-DSP: timeout waiting for download preparation\n"); + hdsp_write(hdsp, HDSP_control2Reg, 0x800); return -EIO; } @@ -737,17 +749,15 @@ static int snd_hdsp_load_firmware_from_cache(struct hdsp *hdsp) { hdsp_write(hdsp, HDSP_fifoData, cache[i]); if (hdsp_fifo_wait (hdsp, 127, HDSP_LONG_WAIT)) { snd_printk ("Hammerfall-DSP: timeout during firmware loading\n"); + hdsp_write(hdsp, HDSP_control2Reg, 0x800); return -EIO; } } - ssleep(3); - - if (hdsp_fifo_wait (hdsp, 0, HDSP_LONG_WAIT)) { - snd_printk ("Hammerfall-DSP: timeout at end of firmware loading\n"); - return -EIO; - } + hdsp_fifo_wait(hdsp, 3, HDSP_LONG_WAIT); + hdsp_write(hdsp, HDSP_control2Reg, 0x800); + ssleep(3); #ifdef SNDRV_BIG_ENDIAN hdsp->control2_register = HDSP_BIGENDIAN_MODE; #else @@ -773,24 +783,51 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp) { if ((hdsp_read (hdsp, HDSP_statusRegister) & HDSP_DllError) != 0) { - hdsp_write (hdsp, HDSP_control2Reg, HDSP_PROGRAM); - hdsp_write (hdsp, HDSP_fifoData, 0); - if (hdsp_fifo_wait (hdsp, 0, HDSP_SHORT_WAIT) < 0) - return -EIO; + hdsp_write(hdsp, HDSP_control2Reg, 0x10a0); + hdsp_write(hdsp, HDSP_fifoData, 0); - hdsp_write (hdsp, HDSP_control2Reg, HDSP_S_LOAD); + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) { + hdsp_write(hdsp, HDSP_control2Reg, 0x900); + hdsp_write(hdsp, HDSP_control2Reg, 0x10a0); + } + + hdsp_write(hdsp, HDSP_control2Reg, 0x820); hdsp_write (hdsp, HDSP_fifoData, 0); + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) { + hdsp->io_type = Multiface; + snd_printk("Hammerfall-DSP: Multiface found\n"); + return 0; + } - if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT)) { - hdsp_write(hdsp, HDSP_control2Reg, HDSP_VERSION_BIT); - hdsp_write(hdsp, HDSP_control2Reg, HDSP_S_LOAD); - if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT)) - hdsp->io_type = RPM; - else - hdsp->io_type = Multiface; - } else { + hdsp_write(hdsp, HDSP_control2Reg, 0x10a0); + hdsp_write(hdsp, HDSP_fifoData, 0); + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) == 0) { hdsp->io_type = Digiface; + snd_printk("Hammerfall-DSP: Digiface found\n"); + return 0; } + + hdsp_write(hdsp, HDSP_control2Reg, 0x900); + hdsp_write(hdsp, HDSP_control2Reg, 0x10a0); + hdsp_write(hdsp, HDSP_fifoData, 0); + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) == 0) { + hdsp->io_type = Multiface; + snd_printk("Hammerfall-DSP: Multiface found\n"); + return 0; + } + + hdsp_write(hdsp, HDSP_control2Reg, 0x900); + hdsp_write(hdsp, HDSP_control2Reg, 0x10a0); + hdsp_write(hdsp, HDSP_fifoData, 0); + if (hdsp_fifo_wait(hdsp, 0, HDSP_SHORT_WAIT) < 0) { + hdsp->io_type = Multiface; + snd_printk("Hammerfall-DSP: Multiface found\n"); + return 0; + } + + hdsp->io_type = RPM; + snd_printk("Hammerfall-DSP: RPM found\n"); + return 0; } else { /* firmware was already loaded, get iobox type */ if (hdsp_read(hdsp, HDSP_status2Register) & HDSP_version2) -- 1.7.10.4

2 6

[alsa-devel] ASoC fixes for atmel
by Mark Brown 15 Jan '13

15 Jan '13

The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-atmel-pinctrl for you to fetch changes up to ea03c81521bde526570e1dec96eaa21fe5ac84a2: ASoC: atmel-ssc: add pinctrl selection to driver (2013-01-12 00:00:33 +0000) ---------------------------------------------------------------- ASoC: atmel: Fixes for pinctrl Due to a series of problems with the handling of Atmel, a combination of making changes that make other branches instantly buggy and a general failure to deal with the resulting issues effectively, v3.8 Atmel audio currently won't work at all for DT boards without adding pinctrl definitions and a request for those. ---------------------------------------------------------------- Bo Shen (2): ARM: at91/dts: add pinctrl support for SSC peripheral ASoC: atmel-ssc: add pinctrl selection to driver arch/arm/boot/dts/at91sam9260.dtsi | 18 ++++++++++++++++++ arch/arm/boot/dts/at91sam9263.dtsi | 36 ++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/at91sam9g45.dtsi | 36 ++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/at91sam9n12.dtsi | 26 ++++++++++++++++++++++++++ arch/arm/boot/dts/at91sam9x5.dtsi | 32 +++++++++++++++++++++++++------- drivers/misc/atmel-ssc.c | 8 ++++++++ 6 files changed, 149 insertions(+), 7 deletions(-)

2 1

[alsa-devel] [PATCH] ALSA: hda - mute LEDs on HP: also check PCI SSID
by David Henningsson 14 Jan '13

14 Jan '13

If the codec subvendor is not set to HP, maybe the PCI SSID is set to HP. If so, there might still be a valid mute LED string in BIOS/UEFI. Cc: stable(a)vger.kernel.org Buglink: https://bugs.launchpad.net/bugs/1099372 Reported-and-tested-by: Tammy Yang <tammy.yang(a)canonical.com> Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_sigmatel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index a86547c..40c74a2 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -4948,7 +4948,8 @@ static int find_mute_led_cfg(struct hda_codec *codec, int default_polarity) &spec->gpio_led_polarity); return 1; } - if ((codec->subsystem_id >> 16) == PCI_VENDOR_ID_HP) { + if ((codec->subsystem_id >> 16) == PCI_VENDOR_ID_HP || + codec->bus->pci->subsystem_vendor == PCI_VENDOR_ID_HP) { while ((dev = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, NULL, dev))) { if (sscanf(dev->name, "HP_Mute_LED_%d_%x", -- 1.7.9.5

2 3

[alsa-devel] [RFC PATCH] ALSA: usb - fix race in creation of M-Audio Fast track pro driver
by David Henningsson 14 Jan '13

14 Jan '13

A patch in the 3.2 kernel caused regression with hotplugging the M-Audio Fast track pro, or sound after suspend. I don't have the device so I haven't done a full analysis, but it seems userspace (both udev and pulseaudio) got confused when a card was created, immediately destroyed, and then created again. However, at least one person in the bug report (martin djfun) reports that this patch resolves the issue for him. It also leaves a message in the log: "snd-usb-audio: probe of 1-1.1:1.1 failed with error -5" which is a bit misleading. It is better than non-working audio, but maybe there's a more elegant solution? BugLink: https://bugs.launchpad.net/bugs/1095315 Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/usb/quirks.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ...oh, and if you end up taking this patch as it is, you should probably add cc to stable (3.2+). diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index acc12f0..e71fc8b 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -387,11 +387,13 @@ static int snd_usb_fasttrackpro_boot_quirk(struct usb_device *dev) * rules */ err = usb_driver_set_configuration(dev, 2); - if (err < 0) { + if (err < 0) snd_printdd("error usb_driver_set_configuration: %d\n", err); - return -ENODEV; - } + /* Always return an error, so that we stop creating a device + that will just be destroyed and recreated with a new + configuration */ + return -ENODEV; } else snd_printk(KERN_INFO "usb-audio: Fast Track Pro config OK\n"); -- 1.7.9.5

3 4