September 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/3] ASoC: Revert "ASoC: mc13783: Provide codec->control_data"
by Fabio Estevam 11 Sep '12

11 Sep '12

Since commit 98d3088e5 (SoC: core: Fix check before defaulting to regmap) , it is not necessary to provide codec->control_data anymore. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- sound/soc/codecs/mc13783.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c index 8def29a..bc95599 100644 --- a/sound/soc/codecs/mc13783.c +++ b/sound/soc/codecs/mc13783.c @@ -585,8 +585,6 @@ static int mc13783_probe(struct snd_soc_codec *codec) { struct mc13783_priv *priv = snd_soc_codec_get_drvdata(codec); - codec->control_data = priv->mc13xxx; - mc13xxx_lock(priv->mc13xxx); /* these are the reset values */ -- 1.7.9.5

2 3

[alsa-devel] [PATCH] ASoC: am3517evm: Remove unused cpu_dai from hw_params
by Peter Ujfalusi 11 Sep '12

11 Sep '12

cpu_dai is not in use in this function and just generates warning at compile time. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)ti.com> --- Hi, Commit: fca04ae ASoC: am3517evm: Do not configure McBSP1 CLKR/FSR signal muxing left this line in the code which generates now warning. This patch is on top of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/omap Regards, Peter sound/soc/omap/am3517evm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/omap/am3517evm.c b/sound/soc/omap/am3517evm.c index a997988..77a8701 100644 --- a/sound/soc/omap/am3517evm.c +++ b/sound/soc/omap/am3517evm.c @@ -41,7 +41,6 @@ static int am3517evm_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_dai *codec_dai = rtd->codec_dai; - struct snd_soc_dai *cpu_dai = rtd->cpu_dai; int ret; /* Set the codec system clock for DAC and ADC */ -- 1.7.12

2 1

[alsa-devel] [PATCH] ASoC: tegra: fix maxburst settings in dmaengine code
by Stephen Warren 11 Sep '12

11 Sep '12

From: Stephen Warren <swarren(a)nvidia.com> The I2S controllers are programmed with an "attention" level of 4 DWORDs. This must match the configuration passed to the DMA driver, so that when they burst in data, they don't overflow the available FIFO space. Also, the burst size is relevant to the destination for playback, and source for capture, not vice-versa as originally written. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- Mark, I'd like to take this patch through the Tegra tree, since it's a dependency for the series that converts Tegra to dmaengine. Thanks. sound/soc/tegra/tegra_pcm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/tegra/tegra_pcm.c b/sound/soc/tegra/tegra_pcm.c index 5658bce..8d6900c 100644 --- a/sound/soc/tegra/tegra_pcm.c +++ b/sound/soc/tegra/tegra_pcm.c @@ -334,11 +334,11 @@ static int tegra_pcm_hw_params(struct snd_pcm_substream *substream, if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { slave_config.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; slave_config.dst_addr = dmap->addr; - slave_config.src_maxburst = 0; + slave_config.dst_maxburst = 4; } else { slave_config.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; slave_config.src_addr = dmap->addr; - slave_config.dst_maxburst = 0; + slave_config.src_maxburst = 4; } slave_config.slave_id = dmap->req_sel; -- 1.7.0.4

2 5

[alsa-devel] snd-intel-hda: screaming IRQ with 3.5.3 kernel (HDMI)
by Chris Rankin 10 Sep '12

10 Sep '12

Hi, I have recently added a Radeon HD4670 to one of my older PCs, and have noticed that it has IRQ trouble when I try to enable the HDMI audio: irq 17: nobody cared (try booting with the "irqpoll" option) Pid: 0, comm: swapper/0 Not tainted 3.5.3 #2 Call Trace: [<c1063806>] ? __report_bad_irq+0x11/0x94 [<c1063a2d>] ? note_interrupt+0x120/0x19b [<c1062325>] ? handle_irq_event_percpu+0xe8/0xfb [<c1062361>] ? handle_irq_event+0x29/0x40 [<c10640fc>] ? handle_level_irq+0x93/0x93 [<c1064163>] ? handle_fasteoi_irq+0x67/0x90 <IRQ> [<c1003625>] ? do_IRQ+0x2e/0x83 [<c1229829>] ? common_interrupt+0x29/0x30 [<c106007b>] ? audit_update_watch+0x59/0x285 [<c1007479>] ? default_idle+0x23/0x3b [<c1007b38>] ? cpu_idle+0x4b/0x7e [<c1314877>] ? start_kernel+0x2a4/0x2a7 handlers: [<f8c97b75>] azx_interrupt [snd_hda_intel] Disabling IRQ #17 This is frequently followed by KMS trouble too: irq 16: nobody cared (try booting with the "irqpoll" option) Pid: 0, comm: swapper/0 Not tainted 3.5.3 #2 Call Trace: [<c1063806>] ? __report_bad_irq+0x11/0x94 [<c1063a2d>] ? note_interrupt+0x120/0x19b [<c1062325>] ? handle_irq_event_percpu+0xe8/0xfb [<c1062361>] ? handle_irq_event+0x29/0x40 [<c10640fc>] ? handle_level_irq+0x93/0x93 [<c1064163>] ? handle_fasteoi_irq+0x67/0x90 <IRQ> [<c1003625>] ? do_IRQ+0x2e/0x83 [<c1229829>] ? common_interrupt+0x29/0x30 [<c106007b>] ? audit_update_watch+0x59/0x285 [<c1007479>] ? default_idle+0x23/0x3b [<c1007b38>] ? cpu_idle+0x4b/0x7e [<c1314877>] ? start_kernel+0x2a4/0x2a7 handlers: [<f818bfb3>] radeon_driver_irq_handler_kms [radeon] [<f81fe55f>] usb_hcd_irq [usbcore] Disabling IRQ #16 The PCI entries are: 01:00.1 Audio device: ATI Technologies Inc RV710/730 Subsystem: ATI Technologies Inc RV710/730 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (2000ns min), Cache Line Size: 64 bytes Interrupt: pin B routed to IRQ 17 Region 0: Memory at ff8ec000 (32-bit, non-prefetchable) [size=16K] Capabilities: [50] Power Management version 3 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: snd_hda_intel and: 01:00.0 VGA compatible controller: ATI Technologies Inc RV730 Pro AGP [Radeon HD 4600 Series] (prog-if 00 [VGA controller]) Subsystem: ATI Technologies Inc Device 0028 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx+ Latency: 64 (2000ns min), Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 16 Region 0: Memory at e0000000 (32-bit, prefetchable) [size=256M] Region 1: I/O ports at ec00 [size=256] Region 2: Memory at ff8f0000 (32-bit, non-prefetchable) [size=64K] Expansion ROM at ff800000 [disabled] [size=128K] Capabilities: [50] Power Management version 3 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [58] AGP version 3.0 Status: RQ=256 Iso- ArqSz=0 Cal=0 SBA+ ITACoh- GART64- HTrans- 64bit- FW+ AGP3+ Rate=x4,x8 Command: RQ=32 ArqSz=2 Cal=0 SBA+ AGP+ GART64- 64bit- FW- Rate=x8 Kernel driver in use: radeon Does anyone have any suggestions, please? Thanks, Chris

2 5

[alsa-devel] [PATCH 1/3] ASoC: cs4270: Conver to data based control init
by Mark Brown 10 Sep '12

10 Sep '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/cs4270.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 44a176f..c6e5a73 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -521,14 +521,6 @@ static int cs4270_probe(struct snd_soc_codec *codec) return ret; } - /* Add the non-DAPM controls */ - ret = snd_soc_add_codec_controls(codec, cs4270_snd_controls, - ARRAY_SIZE(cs4270_snd_controls)); - if (ret < 0) { - dev_err(codec->dev, "failed to add controls\n"); - return ret; - } - /* get the power supply regulators */ for (i = 0; i < ARRAY_SIZE(supply_names); i++) cs4270->supplies[i].supply = supply_names[i]; @@ -634,6 +626,9 @@ static const struct snd_soc_codec_driver soc_codec_device_cs4270 = { .remove = cs4270_remove, .suspend = cs4270_soc_suspend, .resume = cs4270_soc_resume, + + .controls = cs4270_snd_controls, + .num_controls = ARRAY_SIZE(cs4270_snd_controls), .volatile_register = cs4270_reg_is_volatile, .readable_register = cs4270_reg_is_readable, .reg_cache_size = CS4270_LASTREG + 1, -- 1.7.10.4

2 4

Re: [alsa-devel] 3.6-rc Cirrus HDA reconfig oops...
by Takashi Iwai 10 Sep '12

10 Sep '12

At Mon, 10 Sep 2012 23:00:39 +0800, Daniel J Blueman wrote: > > On 10 September 2012 16:29, Takashi Iwai <tiwai(a)suse.de> wrote: > > At Mon, 10 Sep 2012 09:46:43 +0200, > > Takashi Iwai wrote: > >> > >> At Sun, 9 Sep 2012 13:02:16 +0800, > >> Daniel J Blueman wrote: > >> > > >> > With a non-specialised Cirrus HDA codec, it's readily possible to > >> > cause a kernel oops as root with 3.6-rc kernels [1]. > >> > > >> > patch_cirrus.c: > >> > > >> > static int cs_init(struct hda_codec *codec) > >> > { > >> > struct cs_spec *spec = codec->spec; > >> > > >> > /* init_verb sequence for C0/C1/C2 errata*/ > >> > snd_hda_sequence_write(codec, cs_errata_init_verbs); > >> > > >> > snd_hda_sequence_write(codec, cs_coef_init_verbs); > >> > > >> > if (spec->gpio_mask) { > >> > snd_hda_codec_write(codec, 0x01, 0, AC_VERB_SET_GPIO_MASK, > >> > spec->gpio_mask); > >> > > >> > Here, spec is NULL, so loading spec->gpio_mask causes a fatal > >> > pagefault at address 0x180 (ie the offset of gpio_mask in the struct). > >> > I was going to prepare a patch to guard for this, but since spec is > >> > expected in so many places, there is a likely a behavioural issue > >> > preventing a spec struct being generated. > >> > > >> > Let me know for further testing and debug. > >> > >> It's because of calling a leftover callback. > >> The patch below should fix the issue. I'll queue it up to for-linus > >> branch. > > > > Oops, a wrong patch. The corrected one below. > > [...] > > Superb; this fixes the issue nicely. > > Thanks Takashi! OK, thanks for confirmation! Takashi

1 0

Re: [alsa-devel] UAC2 clock selector for AudioBox 1818VSL
by Daniel Mack 10 Sep '12

10 Sep '12

On 07.09.2012 19:57, louis(a)museresearch.com wrote: > Hi Daniel, > Thanks for the quick reply. I am able to set the clock on my Mac, though > I do need to do further tests and make sure that the sync is actually > reliable there. The setting is available from the built-in, standard OS > X audio setup application "Audio MIDI Setup". > > There should be a S/PDIF clock signal going to the digital inputs on the > device. Some of the other controls such as per-channel mute also appear to > work. I've also attached the lsusb output. > > There are some other details that may be relevant, but I didn't want to > make my initial post too long/confusing because these extra details may > end up just being a red herring: Each mixer element name (as seen in > amixer) is prefixed with "AudioBox 1818 VSL Clock Selector" even if it is > not a clock selector. That strange but I believe not related. We should still fix that :) > I am confident though that the control I've been > playing with is the clock selector because it lists the different clock > types as options. I also see this when I plug the device in or load the > ALSA driver: > > ALSA sound/usb/mixer.c:342 cannot get ctl value: req = 0x83, wValue = > 0x201, wIndex = 0xa00, type = 4 > ALSA sound/usb/mixer.c:846 10:0: cannot get min/max values for control 2 > (id 10) > ALSA sound/usb/mixer.c:342 cannot get ctl value: req = 0x83, wValue = > 0x200, wIndex = 0xa00, type = 4 > ALSA sound/usb/mixer.c:846 10:0: cannot get min/max values for control 2 > (id 10) > ALSA sound/usb/mixer.c:342 cannot get ctl value: req = 0x83, wValue = > 0x201, wIndex = 0xb00, type = 4 > ALSA sound/usb/mixer.c:846 11:0: cannot get min/max values for control 2 > (id 11) > ALSA sound/usb/mixer.c:342 cannot get ctl value: req = 0x83, wValue = > 0x200, wIndex = 0xb00, type = 4 > ALSA sound/usb/mixer.c:846 11:0: cannot get min/max values for control 2 > (id 11) Do you see any messages when you try to set the clock selector with amixer? If you're running a recent kernel, try the following patch. That will produce log messages for each mixer related control packet that is sent out to the device. Thanks, Daniel

2 1

[alsa-devel] Invitation to connect on LinkedIn
by harsha priya gupta via LinkedIn 10 Sep '12

10 Sep '12

LinkedIn ------------ harsha priya gupta requested to add you as a connection on LinkedIn: ------------------------------------------ abdul, I'd like to add you to my professional network on LinkedIn. - harsha priya Accept invitation from harsha priya gupta http://www.linkedin.com/e/jpxkk3-h6xtnnj8-6b/uii-rtptP1H4ViCg9YiBUOvto1r4_5… View profile of harsha priya gupta http://www.linkedin.com/e/jpxkk3-h6xtnnj8-6b/rso/147246195/LJfd/name/138036… ------------------------------------------ You are receiving Invitation emails. This email was intended for abdul moiz. Learn why this is included: http://www.linkedin.com/e/jpxkk3-h6xtnnj8-6b/plh/http%3A%2F%2Fhelp%2Elinked… (c) 2012, LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA.

1 0

[alsa-devel] [PATCH 05/22] ASoC: Ux500: Enable MOP500 driver for Device Tree
by Lee Jones 10 Sep '12

10 Sep '12

Here we ensure that the MOP500 audio driver will be probed during a Device Tree boot. We also parse the sound node to link together the codec, dma and the CPU-side Digital Audio Interface. CC: alsa-devel(a)alsa-project.org Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- sound/soc/ux500/mop500.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index 31c4d26..6840df7 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -16,6 +16,7 @@ #include <linux/module.h> #include <linux/io.h> #include <linux/spi/spi.h> +#include <linux/of.h> #include <sound/soc.h> #include <sound/initval.h> @@ -56,8 +57,35 @@ static struct snd_soc_card mop500_card = { .num_links = ARRAY_SIZE(mop500_dai_links), }; +static int __devinit mop500_of_probe(struct platform_device *pdev, + struct device_node *np) +{ + struct device_node *codec_np, *msp_np[2]; + int i; + + msp_np[0] = of_parse_phandle(np, "stericsson,cpu-dai", 0); + msp_np[1] = of_parse_phandle(np, "stericsson,cpu-dai", 1); + codec_np = of_parse_phandle(np, "stericsson,audio-codec", 0); + + if (!(msp_np[0] && msp_np[1] && codec_np)) { + dev_err(&pdev->dev, "Phandle missing or invalid\n"); + return -EINVAL; + } + + for (i = 0; i < 2; i++) { + mop500_dai_links[i].cpu_of_node = msp_np[i]; + mop500_dai_links[i].cpu_dai_name = NULL; + mop500_dai_links[i].codec_of_node = codec_np; + mop500_dai_links[i].codec_name = NULL; + } + + snd_soc_of_parse_card_name(&mop500_card, "stericsson,card-name"); + + return 0; +} static int __devinit mop500_probe(struct platform_device *pdev) { + struct device_node *np = pdev->dev.of_node; int ret; pr_debug("%s: Enter.\n", __func__); @@ -66,6 +94,12 @@ static int __devinit mop500_probe(struct platform_device *pdev) mop500_card.dev = &pdev->dev; + if (np) { + ret = mop500_of_probe(pdev, np); + if (ret) + return ret; + } + dev_dbg(&pdev->dev, "%s: Card %s: Set platform drvdata.\n", __func__, mop500_card.name); platform_set_drvdata(pdev, &mop500_card); @@ -101,10 +135,16 @@ static int __devexit mop500_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id snd_soc_mop500_match[] = { + { .compatible = "stericsson,snd-soc-mop500", }, + {}, +}; + static struct platform_driver snd_soc_mop500_driver = { .driver = { .owner = THIS_MODULE, .name = "snd-soc-mop500", + .of_match_table = snd_soc_mop500_match, }, .probe = mop500_probe, .remove = __devexit_p(mop500_remove), -- 1.7.9.5

2 2

[alsa-devel] [PATCH 06/22] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
by Lee Jones 10 Sep '12

10 Sep '12

Register both parts of the MSP driver from Device Tree so that they are probed when Device Tree is enabled. Also, as there is platform data involved, we ensure that there is allocated memory to place the configuration into and that the correct information is extracted from the DT binary. CC: alsa-devel(a)alsa-project.org Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- sound/soc/ux500/ux500_msp_dai.c | 6 ++++++ sound/soc/ux500/ux500_msp_i2s.c | 22 +++++++++++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c index 772cb19..0f7dd49 100644 --- a/sound/soc/ux500/ux500_msp_dai.c +++ b/sound/soc/ux500/ux500_msp_dai.c @@ -833,10 +833,16 @@ static int __devexit ux500_msp_drv_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id ux500_msp_i2c_match[] = { + { .compatible = "stericsson,ux500-msp-i2s", }, + {}, +}; + static struct platform_driver msp_i2s_driver = { .driver = { .name = "ux500-msp-i2s", .owner = THIS_MODULE, + .of_match_table = ux500_msp_i2c_match, }, .probe = ux500_msp_drv_probe, .remove = ux500_msp_drv_remove, diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c index 2cbfc54..5e0bf8c 100644 --- a/sound/soc/ux500/ux500_msp_i2s.c +++ b/sound/soc/ux500/ux500_msp_i2s.c @@ -18,6 +18,7 @@ #include <linux/pinctrl/consumer.h> #include <linux/delay.h> #include <linux/slab.h> +#include <linux/of.h> #include <mach/hardware.h> #include <mach/msp.h> @@ -692,16 +693,31 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev, int ret = 0; struct resource *res = NULL; struct i2s_controller *i2s_cont; + struct device_node *np = pdev->dev.of_node; struct ux500_msp *msp; - dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__, - pdev->name, platform_data->id); - *msp_p = devm_kzalloc(&pdev->dev, sizeof(struct ux500_msp), GFP_KERNEL); msp = *msp_p; if (!msp) return -ENOMEM; + if (np) { + if (!platform_data) { + platform_data = devm_kzalloc(&pdev->dev, + sizeof(struct msp_i2s_platform_data), GFP_KERNEL); + if (!platform_data) + ret = -ENOMEM; + } + } else + if (!platform_data) + ret = -EINVAL; + + if (ret) + goto err_res; + + dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__, + pdev->name, platform_data->id); + msp->id = platform_data->id; msp->dev = &pdev->dev; msp->dma_cfg_rx = platform_data->msp_i2s_dma_rx; -- 1.7.9.5

2 2