July 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v2] ASoC: tlv320aic3x: add missing registers and bits
by Prchal Jiří 03 Jul '12

03 Jul '12

Second version of patch keeping formatting. Adds missing register default values to cache. Adds register and bits definitions in header file. Changes are for TLV320AIC310x based on data sheet. Signed-off-by: Jiri Prchal <jiri.prchal(a)aksignal.cz> --- /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.c.orig +++ /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.c.new @@ -122,7 +122,9 @@ 0x00, 0x00, 0x00, 0x00, /* 88 */ 0x00, 0x00, 0x00, 0x00, /* 92 */ 0x00, 0x00, 0x00, 0x00, /* 96 */ - 0x00, 0x00, 0x02, /* 100 */ + 0x00, 0x00, 0x02, 0x00, /* 100 */ + 0x00, 0x00, 0x00, 0x00, /* 104 */ + 0x00, 0x00, /* 108 */ }; --- /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.h +++ /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.h.new @@ -13,7 +13,7 @@ #define _AIC3X_H /* AIC3X register space */ -#define AIC3X_CACHEREGNUM 103 +#define AIC3X_CACHEREGNUM 110 /* Page select register */ #define AIC3X_PAGE_SELECT 0 @@ -74,6 +74,8 @@ #define HPLCOM_CFG 37 /* Right High Power Output control registers */ #define HPRCOM_CFG 38 +/* High Power Output Stage Control Register */ +#define HPOUT_SC 40 /* DAC Output Switching control registers */ #define DAC_LINE_MUX 41 /* High Power Output Driver Pop Reduction registers */ @@ -148,6 +150,17 @@ #define AIC3X_GPIOB_REG 101 /* Clock generation control register */ #define AIC3X_CLKGEN_CTRL_REG 102 +/* New AGC registers */ +#define LAGCN_ATTACK 103 +#define LAGCN_DECAY 104 +#define RAGCN_ATTACK 105 +#define RAGCN_DECAY 106 +/* New Programmable ADC Digital Path and I2C Bus Condition Register */ +#define NEW_ADC_DIGITALPATH 107 +/* Passive Analog Signal Bypass Selection During Powerdown Register */ +#define PASSIVE_BYPASS 108 +/* DAC Quiescent Current Adjustment Register */ +#define DAC_ICC_ADJ 109 /* Page select register bits */ #define PAGE0_SELECT 0 @@ -163,6 +176,10 @@ #define DUAL_RATE_MODE ((1 << 5) | (1 << 6)) #define LDAC2LCH (0x1 << 3) #define RDAC2RCH (0x1 << 1) +#define LDAC2RCH (0x2 << 3) +#define RDAC2LCH (0x2 << 1) +#define LDAC2MONOMIX (0x3 << 3) +#define RDAC2MONOMIX (0x3 << 1) /* PLL registers bitfields */ #define PLLP_SHIFT 0

2 5

Re: [alsa-devel] [PATCH 1/1] ASoC: Samsung: Convert to use snd_soc_register_card()
by Mark Brown 03 Jul '12

03 Jul '12

On Tue, Jul 03, 2012 at 02:04:04PM +0530, Sachin Kamat wrote: > Current method for machine driver to register with the ASoC core is to use > snd_soc_register_card() instead of creating a "soc-audio" platform device. Applied, thanks (it's not a generic Samsung patch, it's just for the one board BTW).

1 0

Re: [alsa-devel] [PATCH 1/1] ASoC: Samsung: Convert to use snd_soc_register_card()
by Sangbeom Kim 03 Jul '12

03 Jul '12

Hi! On Tuesday, Jul 03, 2012 at 05:34PM, Sachin Kamat wrote: > Current method for machine driver to register with the ASoC core is to use > snd_soc_register_card() instead of creating a "soc-audio" platform device. It looks better to include reason of using snd_soc_register_card instead of creating "soc-audio" or warning message. Acked-by: Sangbeom Kim <sbkim73(a)samsung.com>

1 0

Re: [alsa-devel] [PATCH] ASoC: tegra: use dmaengine based dma driver
by Mark Brown 03 Jul '12

03 Jul '12

On Tue, Jul 03, 2012 at 11:59:31AM +0530, Laxman Dewangan wrote: > Are you taking this patch? > I have other independent patch for the writecombine dma support in > pcm memory library and wanted to avoid any merge conflicts. > So if it goes in your tree then the other patch also need to go in > your tree. You've not even left 24 hours for me to respond!

1 0

Re: [alsa-devel] Regression in sound/usb/
by Takashi Iwai 03 Jul '12

03 Jul '12

At Tue, 3 Jul 2012 10:20:13 +0200, Philipp Dreimann wrote: > > On 3 July 2012 10:00, Takashi Iwai <tiwai(a)suse.de> wrote: > > At Tue, 3 Jul 2012 09:41:09 +0200, > > Philipp Dreimann wrote: > >> > >> On 2 July 2012 14:10, Daniel Mack <zonque(a)gmail.com> wrote: > >> > On 01.07.2012 13:40, Philipp Dreimann wrote: > >> >> Hello, > >> >> > >> >> my usb webcam, which happens to have a microphone too, stopped working > >> >> using usb2 since I tried kernel 3.5-rc2. (It works using usb3.) > >> > > >> > Please try 3.5-rc5. A number of regressions were fixed just recently. > >> > > >> > Let me know if that version still causes problems. > >> > >> It still does. > > > > Try to pass ignore_ctl_error=1 to snd-usb-audio module. > > If this works and no other problem happens, we can add a similar quirk > > like some Logitech webcams. > > This does not seem to help. And webcam itself is working with our without snd-usb-audio module? Which device at all? Too little information to analyze. Takashi

1 0

Re: [alsa-devel] Regression in sound/usb/
by Takashi Iwai 03 Jul '12

03 Jul '12

At Tue, 3 Jul 2012 09:41:09 +0200, Philipp Dreimann wrote: > > On 2 July 2012 14:10, Daniel Mack <zonque(a)gmail.com> wrote: > > On 01.07.2012 13:40, Philipp Dreimann wrote: > >> Hello, > >> > >> my usb webcam, which happens to have a microphone too, stopped working > >> using usb2 since I tried kernel 3.5-rc2. (It works using usb3.) > > > > Please try 3.5-rc5. A number of regressions were fixed just recently. > > > > Let me know if that version still causes problems. > > It still does. Try to pass ignore_ctl_error=1 to snd-usb-audio module. If this works and no other problem happens, we can add a similar quirk like some Logitech webcams. Takashi

1 0

[alsa-devel] [PATCH] ASoC: wm8962: Log AIF configuration requested by hw_params()
by Mark Brown 02 Jul '12

02 Jul '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8962.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index aa5839c..5781581 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -2582,6 +2582,9 @@ static int wm8962_hw_params(struct snd_pcm_substream *substream, WM8962_SAMPLE_RATE_INT_MODE | WM8962_SAMPLE_RATE_MASK, adctl3); + dev_dbg(codec->dev, "hw_params set BCLK %dHz LRCLK %dHz\n", + wm8962->bclk, wm8962->lrclk); + if (codec->dapm.bias_level == SND_SOC_BIAS_ON) wm8962_configure_bclk(codec); -- 1.7.10

1 0

Re: [alsa-devel] [PATCH] ASoC: tegra: use dmaengine based dma driver
by Stephen Warren 02 Jul '12

02 Jul '12

On 07/02/2012 02:25 AM, Laxman Dewangan wrote: > On Saturday 30 June 2012 08:38 PM, Laxman Dewangan wrote: >> On Friday 29 June 2012 10:32 PM, Stephen Warren wrote: >>> On 06/29/2012 05:34 AM, Laxman Dewangan wrote: >>>> Use the dmaengine based Tegra APB DMA driver for >>>> data transfer between SPI fifo and memory in >>>> place of legacy Tegra APB DMA. >>>> >>>> Because generic soc-dmaengine-pcm uses the DMAs API >>>> based on dmaengine, using the exported APIs provided >>>> by this generic driver. >>>> >>>> The new driver is selected if legacy driver is not >>>> selected and new dma driver is enabled through config >>>> file. >>> >>> This works just fine with the existing non-dmaengine DMA driver enabled. >>> >>> However, I can't get it to work with dmaengine: ... >> I think I should send that patches so that you can test it by: >> - Taking already applied dma driver change in linux-next. >> - Apply my new patches which I am going to send. >> >> And do local change in the tegra_defconfig to disable SYSTEM_DMA and >> enable dmaengine based dma driver. > > The new dma patches are: > > dma: tegra: fix residual calculation for cyclic case > dma: tegra: rename driver and compatible to match with dts > ... OK, with those two patches plus this one, everything works on Cardhu/Tegra30 using dmaengine. However, on Tegra20 DMA doesn't appear to work. No audio is heard, and aplay eventually exits with the following error message: aplay: pcm_write:1603: write error: Input/output error I believe this means that the DMA simply isn't operating. I'll assume this is a Tegra20-specific issue in the dmaengine driver itself, and hence not a problem with this patch, so I'll ack this patch.

2 1

Re: [alsa-devel] [PATCH] ASoC: tegra: use dmaengine based dma driver
by Stephen Warren 02 Jul '12

02 Jul '12

On 06/29/2012 05:34 AM, Laxman Dewangan wrote: > Use the dmaengine based Tegra APB DMA driver for > data transfer between SPI fifo and memory in > place of legacy Tegra APB DMA. > > Because generic soc-dmaengine-pcm uses the DMAs API > based on dmaengine, using the exported APIs provided > by this generic driver. > > The new driver is selected if legacy driver is not > selected and new dma driver is enabled through config > file. > > Signed-off-by: Laxman Dewangan <ldewangan(a)nvidia.com> Acked-by: Stephen Warren <swarren(a)wwwdotorg.org> Tested-by: Stephen Warren <swarren(a)wwwdotorg.org> (Tested on Cardhu/Tegra30. It fails on Whistler/Tegra20, but I assume that's due to a bug in the dmaengine driver not this patch. There won't be a regression when applying this patch since we haven't switched to dmaengine as the default yet).

1 0

Re: [alsa-devel] Regression in sound/usb/
by Daniel Mack 02 Jul '12

02 Jul '12

On 01.07.2012 13:40, Philipp Dreimann wrote: > Hello, > > my usb webcam, which happens to have a microphone too, stopped working > using usb2 since I tried kernel 3.5-rc2. (It works using usb3.) Please try 3.5-rc5. A number of regressions were fixed just recently. Let me know if that version still causes problems. Daniel

1 0