July 2012 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] How to handle parameter variation across different boards but same platform
by Arnd Bergmann 05 Jul '12

05 Jul '12

On Thursday 05 July 2012, Vaibhav Hiremath wrote: > On 7/4/2012 7:57 PM, Mark Brown wrote: > > On Wed, Jul 04, 2012 at 02:17:48PM +0000, Hebbar, Gururaja wrote: > >> On Wed, Jul 04, 2012 at 19:31:18, Mark Brown wrote: > > > >>> If these are totally different boards they should have different machine > >>> IDs set so machine_is_() should identify. If that isn't there then you > >>> need to do something custom to your products to identify the boards > >>> further. > > > >> They are different boards with same SoC (AM33xx). So they both are true for > >> machine_is_am33xx(). > > > > What if the device only supports Linux boot from DT, where we set > machine_desc.nr = ~0 ?? > > Does machine ID still gets set? May be I am missing something... No, it doesn't. > As part of my debugging, on AM335xEVM platform machine_is_am33xx() > returns false, since the value of machine_desc.nr is set to ~0. Correct. However, when you are booting using the device tree, parameters such as the clock frequency of a device should be encoded in the device tree itself, so you don't need to know which machine you are on. Arnd

2 1

[alsa-devel] [PATCH] Removing an assert
by Martin Sandsmark 05 Jul '12

05 Jul '12

Hi! There is an assert in snd_hctl_handle_event in alsa-lib that gets triggered on every login for many KDE users. From what I can see it is superflous, and gets triggered because the device in an event has gone away. This case is handled just beneath the assert as well, and I therefore don't see the reason for this assert at all. Entry in bug tracker: https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5471 -- Martin Sandsmark

2 1

[PATCH] Remove a useless assert.
by Martin Sandsmark 05 Jul '12

05 Jul '12

The case where the element is unavailable (for example gone away since the event was created) is handled beneath. See also bug 5471. --- src/control/hcontrol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/control/hcontrol.c b/src/control/hcontrol.c index 8ffc434..ee1d907 100644 --- a/src/control/hcontrol.c +++ b/src/control/hcontrol.c @@ -761,7 +761,6 @@ static int snd_hctl_handle_event(snd_hctl_t *hctl, snd_ctl_event_t *event) if (event->data.elem.mask & (SNDRV_CTL_EVENT_MASK_VALUE | SNDRV_CTL_EVENT_MASK_INFO)) { elem = snd_hctl_find_elem(hctl, &event->data.elem.id); - assert(elem); if (!elem) return -ENOENT; res = snd_hctl_elem_throw_event(elem, event->data.elem.mask & -- 1.7.11.1 --nextPart21993734.SHAHOXH9Wi--

1 0

Re: [alsa-devel] [PATCH] ASoC: fsl: remove unneeded AUDMUX register setting from imx-sgtl5000
by Shawn Guo 05 Jul '12

05 Jul '12

On Wed, Jul 04, 2012 at 03:38:27PM +0800, Hui Wang wrote: > If we don't set IMX_AUDMUX_V2_PTCR_TCLKDIR in the AUDMUX PTCR > register (means Tx clock pin is input), we don't need to set > IMX_AUDMUX_V2_PTCR_TCSEL as well. Since both i.MX35, i.MX51 and > i.MX6 datasheet says "When Tx clock pin set as an input, the TCSEL > settings are ignored". > > Signed-off-by: Hui Wang <jason77.wang(a)gmail.com> Acked-by: Shawn Guo <shawn.guo(a)linaro.org> > --- > sound/soc/fsl/imx-sgtl5000.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c > index 3a729ca..fb21b17 100644 > --- a/sound/soc/fsl/imx-sgtl5000.c > +++ b/sound/soc/fsl/imx-sgtl5000.c > @@ -95,8 +95,7 @@ static int __devinit imx_sgtl5000_probe(struct platform_device *pdev) > return ret; > } > imx_audmux_v2_configure_port(ext_port, > - IMX_AUDMUX_V2_PTCR_SYN | > - IMX_AUDMUX_V2_PTCR_TCSEL(int_port), > + IMX_AUDMUX_V2_PTCR_SYN, > IMX_AUDMUX_V2_PDCR_RXDSEL(int_port)); > if (ret) { > dev_err(&pdev->dev, "audmux external port setup failed\n"); > -- > 1.7.6 >

1 0

[alsa-devel] [PATCH 1/3] ASoC: arizona: Rename current rates tables to bclk_rates
by Mark Brown 04 Jul '12

04 Jul '12

They're the rates for the BCLK, not for the sample rate, so rename so that we don't confuse ourselves. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/arizona.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c index 3b5730b..67760b4 100644 --- a/sound/soc/codecs/arizona.c +++ b/sound/soc/codecs/arizona.c @@ -363,7 +363,7 @@ static int arizona_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) return 0; } -static const int arizona_48k_rates[] = { +static const int arizona_48k_bclk_rates[] = { -1, 48000, 64000, @@ -385,7 +385,7 @@ static const int arizona_48k_rates[] = { 24576000, }; -static const int arizona_44k1_rates[] = { +static const int arizona_44k1_bclk_rates[] = { -1, 44100, 58800, @@ -445,17 +445,17 @@ static int arizona_hw_params(struct snd_pcm_substream *substream, int bclk, lrclk, wl, frame, sr_val; if (params_rate(params) % 8000) - rates = &arizona_44k1_rates[0]; + rates = &arizona_44k1_bclk_rates[0]; else - rates = &arizona_48k_rates[0]; + rates = &arizona_48k_bclk_rates[0]; - for (i = 0; i < ARRAY_SIZE(arizona_44k1_rates); i++) { + for (i = 0; i < ARRAY_SIZE(arizona_44k1_bclk_rates); i++) { if (rates[i] == snd_soc_params_to_bclk(params)) { bclk = i; break; } } - if (i == ARRAY_SIZE(arizona_44k1_rates)) { + if (i == ARRAY_SIZE(arizona_44k1_bclk_rates)) { arizona_aif_err(dai, "Unsupported sample rate %dHz\n", params_rate(params)); return -EINVAL; -- 1.7.10

1 2

[alsa-devel] [PATCH] ASoC: dwc: Staticise non-exported i2s_start()
by Mark Brown 04 Jul '12

04 Jul '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/dwc/designware_i2s.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index 1bd042b..1aa5130 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/designware_i2s.c @@ -107,7 +107,8 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev *dev, u32 stream) } } -void i2s_start(struct dw_i2s_dev *dev, struct snd_pcm_substream *substream) +static void i2s_start(struct dw_i2s_dev *dev, + struct snd_pcm_substream *substream) { i2s_write_reg(dev->i2s_base, IER, 1); -- 1.7.10

1 0

[alsa-devel] How to handle parameter variation across different boards but same platform
by Hebbar, Gururaja 04 Jul '12

04 Jul '12

hi, Currently on Davinci platform, codec system clock & snd_soc_card parameter is decided using machine_is_xxxx() api. sound/soc/Davinci/davinci-evm.c, inside evm_hw_params() & evm_init(), We have an upcoming board based on TI AM335x soc which has both codec system clock And the codec name (because of i2c bus difference) different from previous am335x based boards. Using machine_is_xxx() is not sufficient because there are 2 other boards on same Platform/machine but with different values. So, how to specify these parameters for the new board? Regards Gururaja

2 5

[alsa-devel] A problem with USB audio devices and the UHCI scheduler
by Monty Montgomery 04 Jul '12

04 Jul '12

A question for Clemens et al... Background: I can run a USB audio device at 6ch/24 bit single duplex, but I cannot run the same device at 16 bit stereo full duplex. UHCI and EHCI both say 'not enough bandwidth' (OHCI works). EHCI's scheduling issues are well known, but I was surprised UHCI could not schedule this either. The cause is simple; UHCI (and EHCI) use the endpoint's wMaxPacketSize for all bandwidth allocation. My device supports all of its sample rates on the same altset, with a wMaxPacketSize matching the highest (96kHz) rate. So, the HCD is reserving most of the USB bus's bandwidth regardless of the actual requirements. How should I approach fixing this in the driver? There's currently no means to communicate a desired bandwidth reservation to the HCD from USB audio, so I'd have to extend even the quirks. I was considering shadowing the endpoint's original wMaxPacketSize in the substream struct, and replacing the value in the endpoint's native descriptor while the stream is running. I have no idea how much trouble that would cause (eg, corruption elsewhere, or middle finger from Linus). Suggestions? For now I have things working by disabling UHCI's initial bandwidth checks (as there is in fact more than enough bandwidth to schedule what I'm doing) but I'd like a more permanent solution. Monty

2 3

[alsa-devel] static build on two machine
by Mohsen Pahlevanzadeh 04 Jul '12

04 Jul '12

Dear all, My co-worker built alsa-lib-1.0.25 and now, i should work on this project, So i get it and compile and compile with the following commands: libtoolize --force --copy --automake aclocal autoheader automake --foreign --copy --add-missing autoconf ./configure --enable-shared=no --enable-static=yes --prefix=/usr/i686 ;make install Now, When i compile my own software, i get two warning however my co-worker doesn't get them: /////////////////////// /usr/i686/lib/libasound.a(pcm_dmix.o):-1: In function `snd_pcm_dmix_sync_ptr': pcm_dmix.c:-1: warning: Warning: snd_pcm_hwsync() is deprecated, consider to use snd_pcm_avail() ///////////////////////// When i run my program my program that my co-worker wrote, crashed, But when he run it, it's crashed. How can i solve this problem? --Best regards Mohsen.

2 1

[alsa-devel] [asoc:for-next 99/101] sound/soc/codecs/sta529.c:400:10: warning: 'ret' may be used uninitialized in this function
by wfg＠linux.intel.com 04 Jul '12

04 Jul '12

Hi Rajeev, There are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next head: 5a6bb2006960eab999dc7023b344bfdbb82e3059 commit: 3be58dbb92871442191188ae51b449e1a9f0fe64 [99/101] ASoC: STA529: Add support for STA529 Audio Codec All warnings: sound/soc/codecs/sta529.c: In function 'sta529_i2c_probe': sound/soc/codecs/sta529.c:400:10: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] vim +400 sound/soc/codecs/sta529.c 397 398 sta529->regmap = devm_regmap_init_i2c(i2c, &sta529_regmap); 399 if (IS_ERR(sta529->regmap)) { > 400 dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret); 401 return PTR_ERR(sta529->regmap); 402 } 403 --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu <wfg(a)linux.intel.com> Intel Corporation

1 0