July 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [alsa-lib] Assorted patches for building on Android
by Arun Raghavan 17 Jul '12

17 Jul '12

Hello, This patch series is required for building alsa-lib on Android (I'm using this for my current PulseAudio-on-Android work). None of these changes introduce anything Android-specific, though. These could likely also be useful for other, non-GNU userspace implementations. I'll eventually clean up and send in the build-system changes that I have, but this will likely need some more dialogue, since the CyanogenMod folks have a completely different approach from what we've taken (and I believe their solution, while simpler, is less complete). Regards, Arun

2 5

Re: [alsa-devel] 3.4.4: Oops in snd_hda_codec_realtek (alc_auto_create_multi_out_ctls)
by Takashi Iwai 17 Jul '12

17 Jul '12

At Mon, 9 Jul 2012 13:40:09 -0600, Robert Hancock wrote: > > I've got a sort of industrial portable PC that uses a Supermicro C2SBX > motherboard. Running an RHEL6 kernel (2.6.32-ish) it works fine, but > if I run a 3.4.4 kernel (using the kernel-ml builds provided by ELRepo > for RHEL6) it blows up on boot inside snd_hda_codec_realtek. Below is > the dmesg output from bootup up to the oops, after I blacklisted > snd_hda_intel from auto-loading and then manually modprobed it. Is > this a known problem? I don't know of this issue, so need to check more. Could you load snd-hda-intel module with probe_only=1 option, and run alsa-info.sh with --no-upload option and give the output? Then I can try the emulator to see what's wrong. Also, of course, testing a newer kernel like 3.5-rc7 would be helpful, too. thanks, Takashi

1 0

Re: [alsa-devel] [sound:for-next 37/38] WARNING: Section mismatches on snd_opti9xx_resume()/snd_opti9xx_configure()
by Takashi Iwai 17 Jul '12

17 Jul '12

At Tue, 17 Jul 2012 18:12:38 +0800, Fengguang Wu wrote: > > Hi Ondrej, > > There are new compile warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > head: 0c7293b6ea0b363c6715c6f0b2894fa63b8e9053 > commit: 5dd250728aa4cad49cfa18eb8ed11ba470ce382a [37/38] ALSA: snd-opti9xx: Implement suspend/resume > config: i386-allmodconfig (attached as .config) > > All warnings: > > > WARNING: sound/isa/opti9xx/snd-opti92x-ad1848.o(.text+0x1b2): Section mismatch in reference from the function snd_opti9xx_resume() to the function .devinit.text:snd_opti9xx_configure.isra.2() > The function snd_opti9xx_resume() references > the function __devinit snd_opti9xx_configure.isra.2(). > This is often because snd_opti9xx_resume lacks a __devinit > annotation or the annotation of snd_opti9xx_configure.isra.2 is wrong. > > WARNING: sound/isa/opti9xx/snd-opti92x-cs4231.o(.text+0xb6): Section mismatch in reference from the function snd_opti9xx_resume() to the function .devinit.text:snd_opti9xx_configure() > The function snd_opti9xx_resume() references > the function __devinit snd_opti9xx_configure(). > This is often because snd_opti9xx_resume lacks a __devinit > annotation or the annotation of snd_opti9xx_configure is wrong. > > WARNING: sound/isa/opti9xx/snd-opti93x.o(.text+0x1ea): Section mismatch in reference from the function snd_opti9xx_resume() to the function .devinit.text:snd_opti9xx_configure() > The function snd_opti9xx_resume() references > the function __devinit snd_opti9xx_configure(). > This is often because snd_opti9xx_resume lacks a __devinit > annotation or the annotation of snd_opti9xx_configure is wrong. Fixed now with the patch below. Thanks. Takashi --- From: Takashi Iwai <tiwai(a)suse.de> Subject: [PATCH] ALSA: opti9xx: Fix section mismatch by PM support In the previous commit, snd_opti9xx_configure() is called from the resume handler but it's still marked as __devinit. Fix it. Reported-by: Fengguang Wu <fengguang.wu(a)intel.com> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/isa/opti9xx/opti92x-ad1848.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c index d7ce012..f8fbe22 100644 --- a/sound/isa/opti9xx/opti92x-ad1848.c +++ b/sound/isa/opti9xx/opti92x-ad1848.c @@ -348,7 +348,7 @@ static void snd_opti9xx_write(struct snd_opti9xx *chip, unsigned char reg, (snd_opti9xx_read(chip, reg) & ~(mask)) | ((value) & (mask))) -static int __devinit snd_opti9xx_configure(struct snd_opti9xx *chip, +static int snd_opti9xx_configure(struct snd_opti9xx *chip, long port, int irq, int dma1, int dma2, long mpu_port, int mpu_irq) -- 1.7.10.4

1 0

[alsa-devel] [PATCH] snd-opti9xx: Implement suspend/resume
by Ondrej Zary 17 Jul '12

17 Jul '12

Implement suspend/resume support for Opti 92x and 93x chips. Tested with Opti 929A+AD1848 and Opti 931. Signed-off-by: Ondrej Zary <linux(a)rainbow-software.org> --- a/sound/isa/opti9xx/opti92x-ad1848.c +++ b/sound/isa/opti9xx/opti92x-ad1848.c @@ -136,8 +136,8 @@ struct snd_opti9xx { #ifdef OPTi93X unsigned long mc_indir_index; struct resource *res_mc_indir; - struct snd_wss *codec; #endif /* OPTi93X */ + struct snd_wss *codec; unsigned long pwd_reg; spinlock_t lock; @@ -870,9 +870,7 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card) &codec); if (error < 0) return error; -#ifdef OPTi93X chip->codec = codec; -#endif error = snd_wss_pcm(codec, 0, &pcm); if (error < 0) return error; @@ -1053,11 +1051,55 @@ static int __devexit snd_opti9xx_isa_remove(struct device *devptr, return 0; } +#ifdef CONFIG_PM +static int snd_opti9xx_suspend(struct snd_card *card) +{ + struct snd_opti9xx *chip = card->private_data; + + snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); + chip->codec->suspend(chip->codec); + return 0; +} + +static int snd_opti9xx_resume(struct snd_card *card) +{ + struct snd_opti9xx *chip = card->private_data; + int error, xdma2; +#if defined(CS4231) || defined(OPTi93X) + xdma2 = dma2; +#else + xdma2 = -1; +#endif + + error = snd_opti9xx_configure(chip, port, irq, dma1, xdma2, + mpu_port, mpu_irq); + if (error) + return error; + chip->codec->resume(chip->codec); + snd_power_change_state(card, SNDRV_CTL_POWER_D0); + return 0; +} + +static int snd_opti9xx_isa_suspend(struct device *dev, unsigned int n, + pm_message_t state) +{ + return snd_opti9xx_suspend(dev_get_drvdata(dev)); +} + +static int snd_opti9xx_isa_resume(struct device *dev, unsigned int n) +{ + return snd_opti9xx_resume(dev_get_drvdata(dev)); +} +#endif + static struct isa_driver snd_opti9xx_driver = { .match = snd_opti9xx_isa_match, .probe = snd_opti9xx_isa_probe, .remove = __devexit_p(snd_opti9xx_isa_remove), - /* FIXME: suspend/resume */ +#ifdef CONFIG_PM + .suspend = snd_opti9xx_isa_suspend, + .resume = snd_opti9xx_isa_resume, +#endif .driver = { .name = DEV_NAME }, @@ -1123,12 +1165,29 @@ static void __devexit snd_opti9xx_pnp_remove(struct pnp_card_link * pcard) snd_opti9xx_pnp_is_probed = 0; } +#ifdef CONFIG_PM +static int snd_opti9xx_pnp_suspend(struct pnp_card_link *pcard, + pm_message_t state) +{ + return snd_opti9xx_suspend(pnp_get_card_drvdata(pcard)); +} + +static int snd_opti9xx_pnp_resume(struct pnp_card_link *pcard) +{ + return snd_opti9xx_resume(pnp_get_card_drvdata(pcard)); +} +#endif + static struct pnp_card_driver opti9xx_pnpc_driver = { .flags = PNP_DRIVER_RES_DISABLE, .name = "opti9xx", .id_table = snd_opti9xx_pnpids, .probe = snd_opti9xx_pnp_probe, .remove = __devexit_p(snd_opti9xx_pnp_remove), +#ifdef CONFIG_PM + .suspend = snd_opti9xx_pnp_suspend, + .resume = snd_opti9xx_pnp_resume, +#endif }; #endif -- Ondrej Zary

3 4

Re: [alsa-devel] [PATCH] ALSA: hda - Add new GPU codec ID to snd-hda
by Takashi Iwai 17 Jul '12

17 Jul '12

At Mon, 16 Jul 2012 17:10:04 -0700, Aaron Plattner wrote: > > Vendor ID 0x10de0051 is used by a yet-to-be-named GPU chip. > > Signed-off-by: Aaron Plattner <aplattner(a)nvidia.com> > Acked-by: Andy Ritger <aritger(a)nvidia.com> > Reviewed-by: Daniel Dadap <ddadap(a)nvidia.com> Applied now. Thanks. Takashi > --- > sound/pci/hda/patch_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index ad319d4..4efe741 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1902,6 +1902,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = { > { .id = 0x10de0042, .name = "GPU 42 HDMI/DP", .patch = patch_generic_hdmi }, > { .id = 0x10de0043, .name = "GPU 43 HDMI/DP", .patch = patch_generic_hdmi }, > { .id = 0x10de0044, .name = "GPU 44 HDMI/DP", .patch = patch_generic_hdmi }, > +{ .id = 0x10de0051, .name = "GPU 51 HDMI/DP", .patch = patch_generic_hdmi }, > { .id = 0x10de0067, .name = "MCP67 HDMI", .patch = patch_nvhdmi_2ch }, > { .id = 0x10de8001, .name = "MCP73 HDMI", .patch = patch_nvhdmi_2ch }, > { .id = 0x80860054, .name = "IbexPeak HDMI", .patch = patch_generic_hdmi }, > @@ -1948,6 +1949,7 @@ MODULE_ALIAS("snd-hda-codec-id:10de0041"); > MODULE_ALIAS("snd-hda-codec-id:10de0042"); > MODULE_ALIAS("snd-hda-codec-id:10de0043"); > MODULE_ALIAS("snd-hda-codec-id:10de0044"); > +MODULE_ALIAS("snd-hda-codec-id:10de0051"); > MODULE_ALIAS("snd-hda-codec-id:10de0067"); > MODULE_ALIAS("snd-hda-codec-id:10de8001"); > MODULE_ALIAS("snd-hda-codec-id:17e80047"); > -- > 1.7.9.5 >

1 0

Re: [alsa-devel] [regression] ALSA: hda - Handle open while transitioning to D3.
by Dylan Reid 17 Jul '12

17 Jul '12

On Sat, Jul 14, 2012 at 6:36 AM, Oleksij Rempel (fishor) <bug-track(a)fisher-privat.net> wrote: > dmesg is in attachment Thanks Oleksij, I didn't get much from that though. What is your powersave timeout set to? If you have time could you try adding the following and send me the output, I have two guesses about where it is spending it's time (no guesses about why yet though). I've got a couple of systems with a 269, I'll try to get some tests run on those tomorrow. diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 20580bf..fd8ce9e 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -4383,9 +4383,11 @@ static void hda_power_work(struct work_struct *work) } spin_unlock(&codec->power_lock); + snd_printd("power_work start %p\n", codec);; hda_call_codec_suspend(codec); if (bus->ops.pm_notify) bus->ops.pm_notify(bus); + snd_printd("power_work done %p\n", codec);; } static void hda_keep_power_on(struct hda_codec *codec) @@ -4426,7 +4428,9 @@ static void __snd_hda_power_up(struct hda_codec *codec, bool wait_power_down) } spin_unlock(&codec->power_lock); + snd_printd("power_up cancel sync start %p\n", codec); cancel_delayed_work_sync(&codec->power_work); + snd_printd("power_up cancel sync done %p\n", codec); spin_lock(&codec->power_lock); /* If the power down delayed work was cancelled above before starting, > > > On 14.07.2012 11:21, Dylan Reid wrote: >> >> On Jul 13, 2012 11:01 PM, "Oleksij Rempel (fishor)" >> <bug-track(a)fisher-privat.net <mailto:bug-track@fisher-privat.net>> wrote: >> > >> > Hallo Dylan, Takashi, >> > >> > I have regression after patch b4a91cf05c3 "ALSA: hda - Handle open >> while transitioning to D3." >> > >> > This regression i can reproduce only if my laptop works on batteries. >> After this patch it needs almost 1 minute more to start. The login >> screen usually plays start sound, but after this patch it wait until >> sound card is ready. >> > >> > My hardware: asus zenbook ux31e. >> > >> > Codec: Realtek ALC269VB >> > >> > 00:1b.0 0403: 8086:1c20 (rev 05) >> > Subsystem: 1043:1427 >> > Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- >> ParErr- Stepping- SERR- FastB2B- DisINTx+ >> > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >> >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- >> > Latency: 0, Cache Line Size: 64 bytes >> > Interrupt: pin A routed to IRQ 50 >> > Region 0: Memory at dfe00000 (64-bit, non-prefetchable) >> [size=16K] >> > Capabilities: <access denied> >> > Kernel driver in use: snd_hda_intel >> > Kernel modules: snd-hda-intel >> > >> >> Could you enable config_snd_debug and send the output during startup? >> I'm actually using the same codec on one of our systems. >> >> Thanks for testing. >> >> Dylan >> > >

1 0

[alsa-devel] [PATCH] ALSA: hda - Add DeviceID for Haswell HDA
by Wang Xingchao 16 Jul '12

16 Jul '12

this patch add proper id for Haswell HDA Controller. Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_intel.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 2b6392b..f530c40 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -151,6 +151,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6}," "{Intel, CPT}," "{Intel, PPT}," "{Intel, LPT}," + "{Intel, HPT}," "{Intel, PBG}," "{Intel, SCH}," "{ATI, SB450}," @@ -3253,6 +3254,10 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = { { PCI_DEVICE(0x8086, 0x8c20), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP | AZX_DCAPS_BUFSIZE}, + /* Haswell */ + { PCI_DEVICE(0x8086, 0x0c0c), + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_SCH_SNOOP | + AZX_DCAPS_BUFSIZE}, /* SCH */ { PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP | -- 1.7.9.5

5 15

[alsa-devel] Kernel 3.2, and "speaker" controlling headphone path
by David Henningsson 16 Jul '12

16 Jul '12

It seems like on one machine the "Speaker Playback Volume" was part of the headphone path, in combination with PulseAudio this is leading to muted headphones. One of my colleagues wrote a workaround for that specific machine - I'm providing links in case you're interested: The patch: https://launchpadlibrarian.net/109499922/restrict_bass.patch Alsa-info: https://launchpadlibrarian.net/109251353/bad-kernel-yes-headphones.txt Bug link: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/994685 -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic

2 2

[alsa-devel] When will Realtek High-Defintion audio codec ALC282 be supported?
by Lin, Mengdong 16 Jul '12

16 Jul '12

Hi, I'm going to have a platform with Realtek HDA ALC282 codec. But the driver has no support for ALC282 now. Does anybody know when ALC282 will be supported? I saw that another Realtek ALC280 is supported by just adding the codec id and still using 'patch_alc269'. I wonder if ALC282 can also be supported in this way if it's similar enough to other ALC2XX codecs. Could anyone share some idea about this? Thanks Mengdong

3 5

[alsa-devel] [PATCH] wss_lib: Fix resume on Yamaha OPL3-SAx
by Ondrej Zary 16 Jul '12

16 Jul '12

Yamaha OPL3-SAx chips don't resume properly when playback is running - garbage is played after resume. Restoring the CS4231_PLAYBK_FORMAT register last fixes the problem. Signed-off-by: Ondrej Zary <linux(a)rainbow-software.org> --- a/sound/isa/wss/wss_lib.c +++ b/sound/isa/wss/wss_lib.c @@ -1656,6 +1656,10 @@ static void snd_wss_resume(struct snd_wss *chip) break; } } + /* Yamaha needs this to resume properly */ + if (chip->hardware == WSS_HW_OPL3SA2) + snd_wss_out(chip, CS4231_PLAYBK_FORMAT, + chip->image[CS4231_PLAYBK_FORMAT]); spin_unlock_irqrestore(&chip->reg_lock, flags); #if 1 snd_wss_mce_down(chip); -- Ondrej Zary

2 1