June 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: hda - power setting error check
by Wang Xingchao 07 Jun '12

07 Jun '12

codec may reject power state transition requests(reporting PS-ERROR set), in that case we re-issue a power state setting and check error bit again. Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_codec.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index d0ca370..bb64eba 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3526,6 +3526,7 @@ static bool snd_hda_codec_get_supported_ps(struct hda_codec *codec, hda_nid_t fg static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg, unsigned int power_state) { + int state, count = 0; if (codec->patch_ops.set_power_state) { codec->patch_ops.set_power_state(codec, fg, power_state); return; @@ -3537,9 +3538,19 @@ static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg, bool epss = snd_hda_codec_get_supported_ps(codec, fg, AC_PWRST_EPSS); msleep(epss? 10:100); } +again: snd_hda_codec_read(codec, fg, 0, AC_VERB_SET_POWER_STATE, power_state); snd_hda_codec_set_power_to_all(codec, fg, power_state, true); + state = snd_hda_codec_read(codec, fg, 0, + AC_VERB_GET_POWER_STATE, 0); + if (state & AC_PWRST_ERROR) { + /* repeat power states setting at most 10 times*/ + if (count++ > 10) + snd_printk(KERN_WARNING "Power states transition reject!\n"); + else + goto again; + } } /* modem wake on ring: transition from D2 to D0 in less than 2ms. For modems, -- 1.7.9.5

3 2

[alsa-devel] [PATCH] ALSA: hda - modem function group wake on ring support
by Wang Xingchao 07 Jun '12

07 Jun '12

D2 allows for the lowest possible power consuming state from which it can return to "fully on" state D0 within 2ms. For modems, it's the "wake on ring" power state. Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_codec.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 2737fe7..d0ca370 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3542,6 +3542,18 @@ static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg, snd_hda_codec_set_power_to_all(codec, fg, power_state, true); } +/* modem wake on ring: transition from D2 to D0 in less than 2ms. For modems, + * this is the wake-on-ring power state */ +static void hda_modem_wake_on_ring(struct hda_codec *codec, bool enter) +{ + if (codec->mfg) { + if (enter) + hda_set_power_state(codec, codec->mfg, AC_PWRST_D2); + else + hda_set_power_state(codec, codec->mfg, AC_PWRST_D0); + } +} + #ifdef CONFIG_SND_HDA_HWDEP /* execute additional init verbs */ static void hda_exec_init_verbs(struct hda_codec *codec) -- 1.7.9.5

3 3

Re: [alsa-devel] [PATCH] ALSA: hda - HDMI Audio init all connectors
by Takashi Iwai 07 Jun '12

07 Jun '12

At Thu, 07 Jun 2012 10:00:24 +0100, Steven Newbury wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 07/06/12 09:47, Takashi Iwai wrote: > > At the next time you submit a patch, please add Cc to maintainer > > and subsystem ML. Otherwise it'd be easily overlooked. > > > I meant to, somehow I managed to send it off before adding the CC, > probably too early in the morning! > > > At Thu, 07 Jun 2012 06:52:59 +0100, Steven Newbury wrote: > >> > >> When VGA_SWITCHEROO support is enabled hda_intel initialises the > >> HDMI audio device on the current VGA device. When it's not > >> enabled it only initialises the HDMI device on the default VGA > >> adaptor, this means secondary cards get no audio support which is > >> very unhelpful for multi-seat! > >> > >> With this patch, when SUPPORT_VGA_SWITCHEROO is disabled > >> hda_intel initialises all HDMI audio devices, not just the > >> default VGA. > >> > >> Signed-off-by: Steven Newbury <steve(a)snewbury.org.uk> > > > > OK, it must be fixed indeed. The bug was introduced due to the > > change in VGA-switcheroo side -- originally check_hdmi_disabled() > > really checked the VGA-switcheroo state, so it returned the correct > > value in the earlier version. > > > > In anyway, your patch looks almost OK, but it'd be better to move > > ifdef and simplify like below. Could you check whether it works > > for you? > > > Looks better, saves the pointless function call. I'll give it spin on > my next boot. Thanks! Meanwhile I found that the current version is also buggy for some setups with VGA-switcheroo. The current version won't work, for example, when VGA-switcheroo is built-in for systems without switcheroo. I'll need to cook up the fix for 3.5-rc2 in addition to your fix. Takashi

1 0

[alsa-devel] [PATCH] ALSA: hda - check proper return value
by Wang Xingchao 07 Jun '12

07 Jun '12

snd_hda_param_read() return value -1 means error, others are responses Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c index 79d0188..99316a7 100644 --- a/sound/pci/hda/hda_proc.c +++ b/sound/pci/hda/hda_proc.c @@ -451,7 +451,7 @@ static void print_power_state(struct snd_info_buffer *buffer, int sup = snd_hda_param_read(codec, nid, AC_PAR_POWER_STATE); int pwr = snd_hda_codec_read(codec, nid, 0, AC_VERB_GET_POWER_STATE, 0); - if (sup) + if (sup != -1) snd_iprintf(buffer, " Power states: %s\n", bits_names(sup, names, ARRAY_SIZE(names))); -- 1.7.9.5

2 1

[alsa-devel] [PATCH 1/2] ALSA: hda - check supported power states
by Wang Xingchao 07 Jun '12

07 Jun '12

Add function to check whether power states supported by specific codec node. Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_codec.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 41ca803..b89c8ec 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3505,6 +3505,22 @@ void snd_hda_codec_set_power_to_all(struct hda_codec *codec, hda_nid_t fg, EXPORT_SYMBOL_HDA(snd_hda_codec_set_power_to_all); /* + * supported power states check + */ +static bool snd_hda_codec_get_supported_ps(struct hda_codec *codec, hda_nid_t fg, + unsigned int power_state) +{ + int sup = snd_hda_param_read(codec, fg, AC_PAR_POWER_STATE); + + if (sup < 0) + return false; + if (sup & power_state) + return true; + else + return false; +} + +/* * set power state of the codec */ static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg, -- 1.7.9.5

4 4

[alsa-devel] [PATCH V2] ALSA: hda - reduce msleep time if EPSS power states supported
by Wang Xingchao 07 Jun '12

07 Jun '12

if EPSS supported, transition from D3 state to D0 state in less than 10ms Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_codec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index b89c8ec..2737fe7 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3532,8 +3532,11 @@ static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg, } /* this delay seems necessary to avoid click noise at power-down */ - if (power_state == AC_PWRST_D3) - msleep(100); + if (power_state == AC_PWRST_D3) { + /* transition time less than 10ms for power down */ + bool epss = snd_hda_codec_get_supported_ps(codec, fg, AC_PWRST_EPSS); + msleep(epss ? 10 : 100); + } snd_hda_codec_read(codec, fg, 0, AC_VERB_SET_POWER_STATE, power_state); snd_hda_codec_set_power_to_all(codec, fg, power_state, true); -- 1.7.9.5

1 0

Re: [alsa-devel] [PATCH] ALSA: hda - HDMI Audio init all connectors
by Takashi Iwai 07 Jun '12

07 Jun '12

At the next time you submit a patch, please add Cc to maintainer and subsystem ML. Otherwise it'd be easily overlooked. At Thu, 07 Jun 2012 06:52:59 +0100, Steven Newbury wrote: > > When VGA_SWITCHEROO support is enabled hda_intel initialises the HDMI audio device on the current VGA device. When it's not enabled it only initialises the HDMI device on the default VGA adaptor, this means secondary cards get no audio support which is very unhelpful for multi-seat! > > With this patch, when SUPPORT_VGA_SWITCHEROO is disabled hda_intel initialises all HDMI audio devices, not just the default VGA. > > Signed-off-by: Steven Newbury <steve(a)snewbury.org.uk> OK, it must be fixed indeed. The bug was introduced due to the change in VGA-switcheroo side -- originally check_hdmi_disabled() really checked the VGA-switcheroo state, so it returned the correct value in the earlier version. In anyway, your patch looks almost OK, but it'd be better to move ifdef and simplify like below. Could you check whether it works for you? Also, please give a patch that is applicable directly via git-am. Apparently you created it via git show. Instead, use git-format-patch or use --pretty=email for git-show. Or, send the patch directly via git-send-email. thanks, Takashi --- diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 2b6392b..2eb1b47 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2484,9 +2484,9 @@ static void azx_notifier_unregister(struct azx *chip) static int DELAYED_INIT_MARK azx_first_init(struct azx *chip); static int DELAYED_INIT_MARK azx_probe_continue(struct azx *chip); +#ifdef SUPPORT_VGA_SWITCHEROO static struct pci_dev __devinit *get_bound_vga(struct pci_dev *pci); -#ifdef SUPPORT_VGA_SWITCHEROO static void azx_vs_set_state(struct pci_dev *pci, enum vga_switcheroo_state state) { @@ -2578,6 +2578,7 @@ static int __devinit register_vga_switcheroo(struct azx *chip) #else #define init_vga_switcheroo(chip) /* NOP */ #define register_vga_switcheroo(chip) 0 +#define check_hdmi_disabled(pci) false #endif /* SUPPORT_VGA_SWITCHER */ /* @@ -2638,6 +2639,7 @@ static int azx_dev_free(struct snd_device *device) return azx_free(device->device_data); } +#ifdef SUPPORT_VGA_SWITCHEROO /* * Check of disabled HDMI controller by vga-switcheroo */ @@ -2676,6 +2678,7 @@ static bool __devinit check_hdmi_disabled(struct pci_dev *pci) } return vga_inactive; } +#endif /* SUPPORT_VGA_SWITCHEROO */ /* * white/black-listing for position_fix

1 0

Re: [alsa-devel] 3.5-rc1 snd_usb_audio stream format breakage
by Takashi Iwai 07 Jun '12

07 Jun '12

At Thu, 7 Jun 2012 03:38:30 +0000, Jamie Heilman wrote: > > With the USB audio streaming logic changes, my HeadRoom Bithead > (08bb:2902 Burr-Brown PCM2902) no longer works. Symptoms include the > loss of most of the normally available formats leaving only: > > root@cucamonga:~# cat /proc/asound/bithead/stream0 > Burr-Brown from TI USB Audio CODEC at usb-0000:00:1a.7-1.1.4, full speed : USB Audio > > Playback: > Status: Stop > Interface 1 > Altset 6 > Format: U8 > Channels: 1 > Endpoint: 2 OUT (ADAPTIVE) > Rates: 32000, 44100, 48000 > > Capture: > Status: Stop > Interface 2 > Altset 18 > Format: S8 > Channels: 1 > Endpoint: 4 IN (SYNC) > Rates: 11025 > > (normally 2 channel S16_LE is available, with capture rates up to > 48kHz ... only the last altset's are being reported now) and a slew of > proc registration warnings logged: > > ------------[ cut here ]------------ > WARNING: at fs/proc/generic.c:586 proc_register+0x169/0x1a6() > Hardware name: Precision WorkStation T3400 > proc_dir_entry 'card1/pcm0p' already registered > Modules linked in: snd_usb_audio(+) snd_usbmidi_lib snd_hda_intel(+) snd_hda_codec snd_hwdep snd_seq_midi snd_seq_midi_event snd_pcm snd_page_alloc snd_rawmidi snd_seq snd_seq_device snd_timer snd soundcore dcdbas floppy sr_mod usb_storage cdrom kvm_intel psmouse kvm tg3 evdev xfs dm_mod raid1 md_mod > Pid: 1152, comm: modprobe Not tainted 3.5.0-rc1-00110-g71fae7e #2 > Call Trace: > [<ffffffff8102a400>] warn_slowpath_common+0x83/0x9c > [<ffffffff8102a4bc>] warn_slowpath_fmt+0x46/0x48 > [<ffffffff813829ad>] ? add_preempt_count+0x39/0x3b > [<ffffffff811292f0>] proc_register+0x169/0x1a6 > [<ffffffff8112962e>] create_proc_entry+0x74/0x8c > [<ffffffffa018eb63>] snd_info_register+0x3e/0xc3 [snd] > [<ffffffffa01fde2e>] snd_pcm_new_stream+0xb1/0x404 [snd_pcm] > [<ffffffffa024861f>] snd_usb_add_audio_stream+0xd2/0x230 [snd_usb_audio] > [<ffffffffa0241d33>] ? snd_usb_parse_audio_format+0x252/0x34f [snd_usb_audio] > [<ffffffff810d6b17>] ? kmem_cache_alloc_trace+0xab/0xbb > [<ffffffffa0248c29>] snd_usb_parse_audio_interface+0x4ac/0x567 [snd_usb_audio] > [<ffffffffa023f0ff>] snd_usb_create_stream+0xe9/0x125 [snd_usb_audio] > [<ffffffffa023f9b1>] usb_audio_probe+0x62a/0x72c [snd_usb_audio] > [<ffffffff812c49f5>] usb_probe_interface+0x136/0x1b1 > [<ffffffff81287e66>] ? driver_probe_device+0x1d3/0x1d3 > [<ffffffff81287d43>] driver_probe_device+0xb0/0x1d3 > [<ffffffff81287ec5>] __driver_attach+0x5f/0x83 > [<ffffffff812863a2>] bus_for_each_dev+0x54/0x86 > [<ffffffff81287730>] driver_attach+0x1e/0x20 > [<ffffffff8128747f>] bus_add_driver+0xfd/0x23a > [<ffffffff812882e8>] driver_register+0x93/0x10e > [<ffffffff812c383f>] usb_register_driver+0x7e/0x12a > [<ffffffffa0257000>] ? 0xffffffffa0256fff > [<ffffffffa0257000>] ? 0xffffffffa0256fff > [<ffffffffa0257040>] snd_usb_audio_init+0x40/0x1000 [snd_usb_audio] > [<ffffffff810001ff>] do_one_initcall+0x7f/0x134 > [<ffffffffa0257000>] ? 0xffffffffa0256fff > [<ffffffff810688d4>] sys_init_module+0x16cf/0x195e > [<ffffffff8106516c>] ? free_notes_attrs+0x4d/0x4d > [<ffffffff810c38cb>] ? mmap_region+0x1c7/0x469 > [<ffffffff813856d2>] system_call_fastpath+0x16/0x1b > ---[ end trace c1baea1a25a91564 ]--- Looks like the PCM substream assignment is buggy. Does the patch (untested at all) below help? thanks, Takashi --- diff --git a/sound/usb/card.h b/sound/usb/card.h index 0d37238..2b9ffff 100644 --- a/sound/usb/card.h +++ b/sound/usb/card.h @@ -119,6 +119,7 @@ struct snd_usb_substream { unsigned long unlink_mask; /* bitmask of unlinked urbs */ /* data and sync endpoints for this stream */ + unsigned int ep_num; /* the endpoint number */ struct snd_usb_endpoint *data_endpoint; struct snd_usb_endpoint *sync_endpoint; unsigned long flags; diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 6b7d7a2..083ed81 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -97,6 +97,7 @@ static void snd_usb_init_substream(struct snd_usb_stream *as, subs->formats |= fp->formats; subs->num_formats++; subs->fmt_type = fp->fmt_type; + subs->ep_num = fp->endpoint; } /* @@ -119,9 +120,7 @@ int snd_usb_add_audio_stream(struct snd_usb_audio *chip, if (as->fmt_type != fp->fmt_type) continue; subs = &as->substream[stream]; - if (!subs->data_endpoint) - continue; - if (subs->data_endpoint->ep_num == fp->endpoint) { + if (subs->ep_num == fp->endpoint) { list_add_tail(&fp->list, &subs->fmt_list); subs->num_formats++; subs->formats |= fp->formats; @@ -134,7 +133,7 @@ int snd_usb_add_audio_stream(struct snd_usb_audio *chip, if (as->fmt_type != fp->fmt_type) continue; subs = &as->substream[stream]; - if (subs->data_endpoint) + if (subs->ep_num) continue; err = snd_pcm_new_stream(as->pcm, stream, 1); if (err < 0)

1 0

[alsa-devel] [PATCH V2] ALSA: hda - add power states information in proc
by Wang Xingchao 06 Jun '12

06 Jun '12

add more power states information: - reset status - clock stop ok - power states error Output like: Power: setting=D0, actual=D0, Error, Clock-stop-OK, Setting-reset Signed-off-by: Wang Xingchao <xingchao.wang(a)intel.com> --- sound/pci/hda/hda_codec.h | 3 +++ sound/pci/hda/hda_proc.c | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h index 4fc3960..71864cdd 100644 --- a/sound/pci/hda/hda_codec.h +++ b/sound/pci/hda/hda_codec.h @@ -323,6 +323,9 @@ enum { #define AC_PWRST_D1 0x01 #define AC_PWRST_D2 0x02 #define AC_PWRST_D3 0x03 +#define AC_PWRST_ERROR (1<<8) +#define AC_PWRST_CLK_STOP_OK (1<<9) +#define AC_PWRST_SETTING_RESET (1<<10) /* Processing capabilies */ #define AC_PCAP_BENIGN (1<<0) diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c index e59e2f0..79d0188 100644 --- a/sound/pci/hda/hda_proc.c +++ b/sound/pci/hda/hda_proc.c @@ -455,10 +455,17 @@ static void print_power_state(struct snd_info_buffer *buffer, snd_iprintf(buffer, " Power states: %s\n", bits_names(sup, names, ARRAY_SIZE(names))); - snd_iprintf(buffer, " Power: setting=%s, actual=%s\n", + snd_iprintf(buffer, " Power: setting=%s, actual=%s", get_pwr_state(pwr & AC_PWRST_SETTING), get_pwr_state((pwr & AC_PWRST_ACTUAL) >> AC_PWRST_ACTUAL_SHIFT)); + if (pwr & AC_PWRST_ERROR) + snd_iprintf(buffer, " , Error"); + if (pwr & AC_PWRST_CLK_STOP_OK) + snd_iprintf(buffer, " , Clock-stop-OK"); + if (pwr & AC_PWRST_SETTING_RESET) + snd_iprintf(buffer, " , Setting-reset"); + snd_iprintf(buffer, "\n"); } static void print_unsol_cap(struct snd_info_buffer *buffer, -- 1.7.9.5

2 1

Re: [alsa-devel] [PATCH v2 2/2] ASoC: codecs: Add DA732x codec driver
by Adam Thomson 06 Jun '12

06 Jun '12

On Wed, June 4, 2012 at 15:31, Mark Brown wrote: > A few small things below, very minor and easy to correct though. > > > + { DA732X_REG_STATUS_EXT , 0x00 }, > > + { DA732X_REG_STATUS , 0x00 }, > > > + { DA732X_REG_MBOX0 , 0x00 }, > > + { DA732X_REG_MBOX1 , 0x00 }, > > + { DA732X_REG_MBOX2 , 0x00 }, > > + { DA732X_REG_MBOX_STATUS , 0x00 }, > > > + { DA732X_REG_ID , 0x00 }, > > > + { DA732X_REG_DMA_STATUS , 0x00 }, > > + { DA732X_REG_BROWNOUT , 0x00 }, > > I would be very surprised if some or all of the above regsters aren't > volatile and therefore shouldn't have default specified. Correct. Will remove those from the cache. > > +static int da732x_hpf_set(struct snd_kcontrol *kcontrol, > > + struct snd_ctl_elem_value *ucontrol) > > Why doesn't a standard enum work for this? This is because the two bits that are required for this are not adjacent in the register, so we use our own get/set methods to control them. > > + /* High Pass Filters */ > > + SOC_ENUM_EXT("DAC1 High Pass Filter Mode Switch", > > + da732x_dac1_hpf_mode_enum, da732x_hpf_get, da732x_hpf_set), > > This shouldn't be a Switch, it's an enumeration. Switches are plain > boolean controls. Ok, fair point. Will rename accordingly. > > + SOC_SINGLE("ADC1 Equalizer Switch", DA732X_REG_ADC1_EQ5, > > + DA732X_EQ_EN_SHIFT, DA732X_EQ_EN_MAX, DA732X_NO_INVERT), > > + SOC_SINGLE_TLV("ADC1 EQ Band 1 Volume", DA732X_REG_ADC1_EQ12, > > + DA732X_EQ_BAND1_SHIFT, DA732X_EQ_VOL_VAL_MAX, > > + DA732X_INVERT, eq_band_pga_tlv), > > I'd suggest calling the Switch "ADC1 EQ Switch" for consistency with the > gains for the bands (or expanding EQ in the gains but that'll make for a > lot of really long control names). Again, makes sense. Will update all the ADC & DAC instances to align. > > + case SND_SOC_DAPM_POST_PMU: > > + if (w->reg == DA732X_REG_ADC1_PD) > > + snd_soc_update_bits(codec, DA732X_REG_CLK_EN3, > > + DA732X_ADCA_BB_CLK_EN, > > + DA732X_ADCA_BB_CLK_EN); > > + else > > + snd_soc_update_bits(codec, DA732X_REG_CLK_EN3, > > + DA732X_ADCC_BB_CLK_EN, > > + DA732X_ADCC_BB_CLK_EN); > > This reads like it should be a switch statement. The effect will be the > same but it's a bit clearer. Ok, don't mind changing it if you think it's clearer. > > + da732x->regmap = devm_regmap_init_i2c(i2c, &da732x_regmap); > > + if (IS_ERR(da732x->regmap)) { > > + ret = PTR_ERR(da732x->regmap); > > + dev_err(&i2c->dev, "Failed to initialize regmap\n"); > > + goto err; > > + } > > + > > + ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_da732x, > > + da732x_dai, ARRAY_SIZE(da732x_dai)); > > The register cache defaults make it look like there's a device ID > (or possibly chip revision?) register - it'd be good practice to read it > here and either verify that it has the expected value or log it > depending on which it is. Is revision information. Will log this. > > +static const struct i2c_device_id da732x_i2c_id[] = { > > + { "da732x", 0}, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(i2c, da732x_i2c_id); > > Good practice would be to enumerate all the device IDs (so users can > just register devices) but it doesn't really matter. For now will stick with this.

1 0