May 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Multicasting transfer mode
by Patrick Lai 14 May '12

14 May '12

Hi, The hardware I am working on has CODEC transfer microphone signal to two SOCs simultaneously . In the machine driver, I have two dai-links defined for main SOC and secondary SOC. Both DAI-LINKs include same CODEC DAI. As long as only one dai-link is being accessed at a time, thing is fine. However, when two dai-links are accessed at the same time and one dai-link goes down, soc framework tears down the CODEC DAI as it does not take account of same CODEC DAI is being used by other dai-link. I see playback_active and capture_active being defined in struct snd_soc_dai. I am thinking about using these flags to address this problem. Is it the right approach? Is there precedence being addressed with different approach? Also, I am referring to kernel 3.4 rc7. In soc-dai.h, playback_active and capture active are defined as unsigned int capture_active:1; /* stream is in use */ unsigned int playback_active:1; /* stream is in use */ However, in soc-pcm.c, playback_active and capture_active are being incremented and decremented instead of set and clear. If I use these flags to address my problem, I am going to increase number of bits. Thanks Patrick -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

2 2

[alsa-devel] [PATCH alsa-lib] pcm_dsnoop: comment fall-through in next "case"
by Antonio Borneo 14 May '12

14 May '12

Signed-off-by: Antonio Borneo <borneo.antonio(a)gmail.com> --- src/pcm/pcm_dsnoop.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/pcm/pcm_dsnoop.c b/src/pcm/pcm_dsnoop.c index 988f1f4..bacb4ae 100644 --- a/src/pcm/pcm_dsnoop.c +++ b/src/pcm/pcm_dsnoop.c @@ -223,6 +223,7 @@ static int snd_pcm_dsnoop_delay(snd_pcm_t *pcm, snd_pcm_sframes_t *delayp) err = snd_pcm_dsnoop_sync_ptr(pcm); if (err < 0) return err; + /* Fall through */ case SNDRV_PCM_STATE_PREPARED: case SNDRV_PCM_STATE_SUSPENDED: *delayp = snd_pcm_mmap_capture_hw_avail(pcm); -- 1.7.3.4

2 1

[alsa-devel] [PATCH alsa-lib 0/1] bug fix and comment on "switch"
by Antonio Borneo 14 May '12

14 May '12

Hi, this is a very simple one line patch but the issue was driving me crazy for few days. After this finding, I have reviewed all the "switch" statements in alsa-lib. All well done with proper comment when a "case" falls through the next "case". But there is one "switch" that does not follow the usual scheme. In file src/pcm/pcm_dsnoop.c procedure snd_pcm_dsnoop_delay() following code fragment: switch(dsnoop->state) { case SNDRV_PCM_STATE_DRAINING: case SNDRV_PCM_STATE_RUNNING: err = snd_pcm_dsnoop_sync_ptr(pcm); if (err < 0) return err; case SNDRV_PCM_STATE_PREPARED: case SNDRV_PCM_STATE_SUSPENDED: *delayp = snd_pcm_mmap_capture_hw_avail(pcm); return 0; If snd_pcm_dsnoop_sync_ptr() returns no error, execution falls through next "case". It's missing the usual comment /* Fall through */ to highlight such code behavior. I think the code is correct, but I do not have enough experience on alsa-lib to be sure. Please confirm. In such case, I would suggest adding the comment above. Best Regards, Antonio Borneo

2 3

[alsa-devel] [PATCH 00/15] HD-audio updates for 3.5
by Takashi Iwai 14 May '12

14 May '12

Hi, this is a series of HD-audio patches for 3.5 kernel from topic/hda branch of sound git tree. One behavior change is about the suspend/resume. As seen in another thread, now the driver tries to resume immediately instead of delaying the initialization. This is because we found out that some hardware (more exactly BIOS) don't initialize the chips correctly, thus the driver _must_ initialize them properly even for the further sleep / shutdown. In the code organization side, I started moving some common codes into hda_auto_parser.[ch]. This will gather the codes commonly used for the BIOS auto-parser, and leave hda_codec.c a bit more cleaner. In addition to these commits, there are pending commits for VGA- switcheroo support in topic/hda-switcheroo branch. The changes in VGA side have been already merged in Dave's upstream tree, and the rest for HD-audio will be merged soon (once after the conflict in linux-next is resolved...) thanks, Takashi

1 15

[alsa-devel] [PATCH]: sound/usb/mixer.c: Volume quirks compare empty string kctl->id.name.
by Christian Melki 14 May '12

14 May '12

> > Hi, > > > > Sorry to mail you directly. But I have tried to mail several times to > > the mailing list but I don't get through. Everything checks out fine, > > no html etc, other mailing lists work fine, but not alsa devel. > > Anyway, could you please have a look at this? > > Could you resend the patch but just add me, Clemens and Daniel to Cc, so that it reaches to main developers for usb-audio? Even if we take your patch as is, it'd be needed to be applicable via git-am. > > > thanks, > > Takashi Hi. I noticied that volume quirks in usb-audio did not get applied. This is because kctl->id.name gets built properly _after_ calling the quirk adjustments. My solution is a bit ugly, but check_mapped_dB needs the adjustment before getting called. I split the call over the switch. If someone feels like writing something cleaner, please feel free. This works for me atleast. Regards, Christian Melki Signed-off-by: Christian Melki <christian.melki(a)ericsson.se> --- diff -urN linux-3.3.2.orig/sound/usb/mixer.c linux-3.3.2/sound/usb/mixer.c --- linux-3.3.2.orig//sound/usb/mixer.c 2012-04-30 09:08:29.000000000 +0200 +++ linux-3.3.2/sound/usb/mixer.c 2012-04-30 09:46:28.000000000 +0200 @@ -1121,9 +1121,6 @@ len = snd_usb_copy_string_desc(state, nameid, kctl->id.name, sizeof(kctl->id.name)); - /* get min/max values */ - get_min_max_with_quirks(cval, 0, kctl); - switch (control) { case UAC_FU_MUTE: case UAC_FU_VOLUME: @@ -1155,6 +1152,7 @@ } append_ctl_name(kctl, control == UAC_FU_MUTE ? " Switch" : " Volume"); + get_min_max_with_quirks(cval, 0, kctl); if (control == UAC_FU_VOLUME) { check_mapped_dB(map, cval); if (cval->dBmin < cval->dBmax || !cval->initialized) { @@ -1170,6 +1168,7 @@ if (! len) strlcpy(kctl->id.name, audio_feature_info[control-1].name, sizeof(kctl->id.name)); + get_min_max_with_quirks(cval, 0, kctl); break; }

2 1

[alsa-devel] [PATCH] ASoC: lm49453: Fix author e-mail address
by Mark Brown 14 May '12

14 May '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/lm49453.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c index 02a8179..802b9f1 100644 --- a/sound/soc/codecs/lm49453.c +++ b/sound/soc/codecs/lm49453.c @@ -1546,5 +1546,5 @@ static struct i2c_driver lm49453_i2c_driver = { module_i2c_driver(lm49453_i2c_driver); MODULE_DESCRIPTION("ASoC LM49453 driver"); -MODULE_AUTHOR("M R Swami Reddy <MR.Swami.Reddy(a)ti.com"); +MODULE_AUTHOR("M R Swami Reddy <MR.Swami.Reddy(a)ti.com>"); MODULE_LICENSE("GPL v2"); -- 1.7.10

2 1

[alsa-devel] what happened in this sound crackling log?
by Yang Liu 14 May '12

14 May '12

Hi, My sound get crackling after 3 days running. Here is the log I captured. What happened here? I appreciate any help. ====================================================== period_update: pcmC0D0p:0: pos=0x440/0x440/0x1540, hwptr=0x18b5f162, hw_base=0x18b5f140, hw_intr=0x18b5f140 hw_update: pcmC0D0p:0: pos=0x441/0x440/0x1540, hwptr=0x18b5f580, hw_base=0x18b5f140, hw_intr=0x18b5f580 hw_update: pcmC0D0p:0: pos=0x441/0x440/0x1540, hwptr=0x18b5f581, hw_base=0x18b5f140, hw_intr=0x18b5f580 May 14 05:19:04 172.25.18.160 last message repeated 2 times period_update: pcmC0D0p:0: pos=0x880/0x440/0x1540, hwptr=0x18b5f581, hw_base=0x18b5f140, hw_intr=0x18b5f580 period_update: pcmC0D0p:0: pos=0xcc0/0x440/0x1540, hwptr=0x18b5f9c0, hw_base=0x18b5f140, hw_intr=0x18b5f9c0 hw_update: pcmC0D0p:0: pos=0xe1a/0x440/0x1540, hwptr=0x18b5fe00, hw_base=0x18b5f140, hw_intr=0x18b5fe00 hw_update: pcmC0D0p:0: pos=0xe1a/0x440/0x1540, hwptr=0x18b5ff5a, hw_base=0x18b5f140, hw_intr=0x18b5fe00 hw_update: pcmC0D0p:0: pos=0xe1d/0x440/0x1540, hwptr=0x18b5ff5a, hw_base=0x18b5f140, hw_intr=0x18b5fe00 period_update: pcmC0D0p:0: pos=0x1100/0x440/0x1540, hwptr=0x18b5ff5d, hw_base=0x18b5f140, hw_intr=0x18b5fe00 hw_update: pcmC0D0p:0: pos=0x1290/0x440/0x1540, hwptr=0x18b60240, hw_base=0x18b5f140, hw_intr=0x18b60240 hw_update: pcmC0D0p:0: pos=0x1290/0x440/0x1540, hwptr=0x18b603d0, hw_base=0x18b5f140, hw_intr=0x18b60240 hw_update: pcmC0D0p:0: pos=0x1290/0x440/0x1540, hwptr=0x18b603d0, hw_base=0x18b5f140, hw_intr=0x18b60240 period_update: pcmC0D0p:0: pos=0x1/0x440/0x1540, hwptr=0x18b603d0, hw_base=0x18b5f140, hw_intr=0x18b60240 hw_update: pcmC0D0p:0: pos=0x1c0/0x440/0x1540, hwptr=0x18b60681, hw_base=0x18b60680, hw_intr=0x18b60680 hw_update: pcmC0D0p:0: pos=0x1c0/0x440/0x1540, hwptr=0x18b60840, hw_base=0x18b60680, hw_intr=0x18b60680 hw_update: pcmC0D0p:0: pos=0x1c0/0x440/0x1540, hwptr=0x18b60840, hw_base=0x18b60680, hw_intr=0x18b60680 period_update: pcmC0D0p:0: pos=0x440/0x440/0x1540, hwptr=0x18b60840, hw_base=0x18b60680, hw_intr=0x18b60680 hw_update: pcmC0D0p:0: pos=0x652/0x440/0x1540, hwptr=0x18b60ac0, hw_base=0x18b60680, hw_intr=0x18b60ac0 hw_update: pcmC0D0p:0: pos=0x652/0x440/0x1540, hwptr=0x18b60cd2, hw_base=0x18b60680, hw_intr=0x18b60ac0 hw_update: pcmC0D0p:0: pos=0x652/0x440/0x1540, hwptr=0x18b60cd2, hw_base=0x18b60680, hw_intr=0x18b60ac0 period_update: pcmC0D0p:0: pos=0x880/0x440/0x1540, hwptr=0x18b60cd2, hw_base=0x18b60680, hw_intr=0x18b60ac0 hw_update: pcmC0D0p:0: pos=0xaed/0x440/0x1540, hwptr=0x18b60f00, hw_base=0x18b60680, hw_intr=0x18b60f00 period_update: pcmC0D0p:0: pos=0xcc0/0x440/0x1540, hwptr=0x18b6116d, hw_base=0x18b60680, hw_intr=0x18b60f00 hw_update: pcmC0D0p:0: pos=0xfa5/0x440/0x1540, hwptr=0x18b61340, hw_base=0x18b60680, hw_intr=0x18b61340 period_update: pcmC0D0p:0: pos=0x1100/0x440/0x1540, hwptr=0x18b61625, hw_base=0x18b60680, hw_intr=0x18b61340 hw_update: pcmC0D0p:0: pos=0x14ea/0x440/0x1540, hwptr=0x18b61780, hw_base=0x18b60680, hw_intr=0x18b61780 period_update: pcmC0D0p:0: pos=0x0/0x440/0x1540, hwptr=0x18b61b6a, hw_base=0x18b60680, hw_intr=0x18b61780 period_update: pcmC0D0p:0: pos=0x440/0x440/0x1540, hwptr=0x18b61bc0, hw_base=0x18b61bc0, hw_intr=0x18b61bc0 hw_update: pcmC0D0p:0: pos=0x47d/0x440/0x1540, hwptr=0x18b62000, hw_base=0x18b61bc0, hw_intr=0x18b62000 period_update: pcmC0D0p:0: pos=0x881/0x440/0x1540, hwptr=0x18b6203d, hw_base=0x18b61bc0, hw_intr=0x18b62000 hw_update: pcmC0D0p:0: pos=0x935/0x440/0x1540, hwptr=0x18b62441, hw_base=0x18b61bc0, hw_intr=0x18b62440 period_update: pcmC0D0p:0: pos=0xcc0/0x440/0x1540, hwptr=0x18b624f5, hw_base=0x18b61bc0, hw_intr=0x18b62440 hw_update: pcmC0D0p:0: pos=0xddd/0x440/0x1540, hwptr=0x18b62880, hw_base=0x18b61bc0, hw_intr=0x18b62880 period_update: pcmC0D0p:0: pos=0x1100/0x440/0x1540, hwptr=0x18b6299d, hw_base=0x18b61bc0, hw_intr=0x18b62880 hw_update: pcmC0D0p:0: pos=0x128a/0x440/0x1540, hwptr=0x18b62cc0, hw_base=0x18b61bc0, hw_intr=0x18b62cc0 ======================================================= Below is a piece of normal log. I found there were some more hw_update between period_update. And the "pos" was a little bit different. ====================================================== period_update: pcmC0D0p:0: pos=0xcc1/0x440/0x1540, hwptr=0x3b69a355, hw_base=0x3b699ac0, hw_intr=0x3b69a3 40 hw_update: pcmC0D0p:0: pos=0xcc1/0x440/0x1540, hwptr=0x3b69a781, hw_base=0x3b699ac0, hw_intr=0x3b69a780 May 14 00:00:00 172.25.18.160 last message repeated 3 times hw_update: pcmC0D0p:0: pos=0xcca/0x440/0x1540, hwptr=0x3b69a781, hw_base=0x3b699ac0, hw_intr=0x3b69a780 hw_update: pcmC0D0p:0: pos=0xcca/0x440/0x1540, hwptr=0x3b69a78a, hw_base=0x3b699ac0, hw_intr=0x3b69a780 hw_update: pcmC0D0p:0: pos=0xcca/0x440/0x1540, hwptr=0x3b69a78a, hw_base=0x3b699ac0, hw_intr=0x3b69a780 hw_update: pcmC0D0p:0: pos=0xcd2/0x440/0x1540, hwptr=0x3b69a78a, hw_base=0x3b699ac0, hw_intr=0x3b69a780 hw_update: pcmC0D0p:0: pos=0xcd2/0x440/0x1540, hwptr=0x3b69a792, hw_base=0x3b699ac0, hw_intr=0x3b69a780 period_update: pcmC0D0p:0: pos=0x1100/0x440/0x1540, hwptr=0x3b69a792, hw_base=0x3b699ac0, hw_intr=0x3b69a 780 hw_update: pcmC0D0p:0: pos=0x1101/0x440/0x1540, hwptr=0x3b69abc0, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1101/0x440/0x1540, hwptr=0x3b69abc1, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1101/0x440/0x1540, hwptr=0x3b69abc1, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1103/0x440/0x1540, hwptr=0x3b69abc1, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x110a/0x440/0x1540, hwptr=0x3b69abc3, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x110a/0x440/0x1540, hwptr=0x3b69abca, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x110d/0x440/0x1540, hwptr=0x3b69abca, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1112/0x440/0x1540, hwptr=0x3b69abcd, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1112/0x440/0x1540, hwptr=0x3b69abd2, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 period_update: pcmC0D0p:0: pos=0x1/0x440/0x1540, hwptr=0x3b69abd2, hw_base=0x3b699ac0, hw_intr=0x3b69abc0 hw_update: pcmC0D0p:0: pos=0x1/0x440/0x1540, hwptr=0x3b69b001, hw_base=0x3b69b000, hw_intr=0x3b69b000 May 14 00:00:00 172.25.18.160 last message repeated 2 times hw_update: pcmC0D0p:0: pos=0x3/0x440/0x1540, hwptr=0x3b69b001, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0x6/0x440/0x1540, hwptr=0x3b69b003, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0xd/0x440/0x1540, hwptr=0x3b69b006, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0xd/0x440/0x1540, hwptr=0x3b69b00d, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0x10/0x440/0x1540, hwptr=0x3b69b00d, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0x15/0x440/0x1540, hwptr=0x3b69b010, hw_base=0x3b69b000, hw_intr=0x3b69b000 hw_update: pcmC0D0p:0: pos=0x15/0x440/0x1540, hwptr=0x3b69b015, hw_base=0x3b69b000, hw_intr=0x3b69b000 period_update: pcmC0D0p:0: pos=0x441/0x440/0x1540, hwptr=0x3b69b015, hw_base=0x3b69b000, hw_intr=0x3b69b0 00 hw_update: pcmC0D0p:0: pos=0x441/0x440/0x1540, hwptr=0x3b69b441, hw_base=0x3b69b000, hw_intr=0x3b69b440 May 14 00:00:00 172.25.18.160 last message repeated 2 times hw_update: pcmC0D0p:0: pos=0x443/0x440/0x1540, hwptr=0x3b69b441, hw_base=0x3b69b000, hw_intr=0x3b69b440 hw_update: pcmC0D0p:0: pos=0x44a/0x440/0x1540, hwptr=0x3b69b443, hw_base=0x3b69b000, hw_intr=0x3b69b440 hw_update: pcmC0D0p:0: pos=0x44a/0x440/0x1540, hwptr=0x3b69b44a, hw_base=0x3b69b000, hw_intr=0x3b69b440 hw_update: pcmC0D0p:0: pos=0x44d/0x440/0x1540, hwptr=0x3b69b44a, hw_base=0x3b69b000, hw_intr=0x3b69b440 hw_update: pcmC0D0p:0: pos=0x452/0x440/0x1540, hwptr=0x3b69b44d, hw_base=0x3b69b000, hw_intr=0x3b69b440 hw_update: pcmC0D0p:0: pos=0x452/0x440/0x1540, hwptr=0x3b69b452, hw_base=0x3b69b000, hw_intr=0x3b69b440 period_update: pcmC0D0p:0: pos=0x880/0x440/0x1540, hwptr=0x3b69b452, hw_base=0x3b69b000, hw_intr=0x3b69b4 40 hw_update: pcmC0D0p:0: pos=0x881/0x440/0x1540, hwptr=0x3b69b880, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x881/0x440/0x1540, hwptr=0x3b69b881, hw_base=0x3b69b000, hw_intr=0x3b69b880 May 14 00:00:00 172.25.18.160 last message repeated 2 times hw_update: pcmC0D0p:0: pos=0x886/0x440/0x1540, hwptr=0x3b69b881, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x886/0x440/0x1540, hwptr=0x3b69b886, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x889/0x440/0x1540, hwptr=0x3b69b886, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x88d/0x440/0x1540, hwptr=0x3b69b889, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x88d/0x440/0x1540, hwptr=0x3b69b88d, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x88d/0x440/0x1540, hwptr=0x3b69b88d, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x892/0x440/0x1540, hwptr=0x3b69b88d, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0x892/0x440/0x1540, hwptr=0x3b69b892, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0xa0d/0x440/0x1540, hwptr=0x3b69b892, hw_base=0x3b69b000, hw_intr=0x3b69b880 hw_update: pcmC0D0p:0: pos=0xa10/0x440/0x1540, hwptr=0x3b69ba0d, hw_base=0x3b69b000, hw_intr=0x3b69b880 ========================================================================================= I try to get some alsa information here. Sorry I can't use "alsa-info.sh" because my environment is a customized linux environment. =============================================== ./Intel/pcm0p/sub0/prealloc_max:32768 ./Intel/pcm0p/sub0/prealloc:64 ./Intel/pcm0p/sub0/status:state: RUNNING ./Intel/pcm0p/sub0/status:trigger_time: 139.020790344 ./Intel/pcm0p/sub0/status:tstamp : 273665.508245384 ./Intel/pcm0p/sub0/status:delay : -654836061 ./Intel/pcm0p/sub0/status:avail : 654841501 ./Intel/pcm0p/sub0/status:avail_max : 654841501 ./Intel/pcm0p/sub0/status:----- ./Intel/pcm0p/sub0/status:hw_ptr : 654836061 ./Intel/pcm0p/sub0/status:appl_ptr : 0 ./Intel/pcm0p/sub0/sw_params:tstamp_mode: ENABLE ./Intel/pcm0p/sub0/sw_params:period_step: 1 ./Intel/pcm0p/sub0/sw_params:avail_min: 1088 ./Intel/pcm0p/sub0/sw_params:start_threshold: 1 ./Intel/pcm0p/sub0/sw_params:stop_threshold: 1426063360 ./Intel/pcm0p/sub0/sw_params:silence_threshold: 0 ./Intel/pcm0p/sub0/sw_params:silence_size: 1426063360 ./Intel/pcm0p/sub0/sw_params:boundary: 1426063360 ./Intel/pcm0p/sub0/hw_params:access: MMAP_INTERLEAVED ./Intel/pcm0p/sub0/hw_params:format: S16_LE ./Intel/pcm0p/sub0/hw_params:subformat: STD ./Intel/pcm0p/sub0/hw_params:channels: 6 ./Intel/pcm0p/sub0/hw_params:rate: 44100 (44100/1) ./Intel/pcm0p/sub0/hw_params:period_size: 1088 ./Intel/pcm0p/sub0/hw_params:buffer_size: 5440 ./Intel/pcm0p/sub0/info:card: 0 ./Intel/pcm0p/sub0/info:device: 0 ./Intel/pcm0p/sub0/info:subdevice: 0 ./Intel/pcm0p/sub0/info:stream: PLAYBACK ./Intel/pcm0p/sub0/info:id: ALC883 Analog ./Intel/pcm0p/sub0/info:name: ALC883 Analog ./Intel/pcm0p/sub0/info:subname: subdevice #0 ./Intel/pcm0p/sub0/info:class: 0 ./Intel/pcm0p/sub0/info:subclass: 0 ./Intel/pcm0p/sub0/info:subdevices_count: 1 ./Intel/pcm0p/sub0/info:subdevices_avail: 0 ./Intel/pcm0p/xrun_debug:31 ./Intel/pcm0p/info:card: 0 ./Intel/pcm0p/info:device: 0 ./Intel/pcm0p/info:subdevice: 0 ./Intel/pcm0p/info:stream: PLAYBACK ./Intel/pcm0p/info:id: ALC883 Analog ./Intel/pcm0p/info:name: ALC883 Analog ./Intel/pcm0p/info:subname: subdevice #0 ./Intel/pcm0p/info:class: 0 ./Intel/pcm0p/info:subclass: 0 ./Intel/pcm0p/info:subdevices_count: 1 ./Intel/pcm0p/info:subdevices_avail: 0 ... ./card0/id:Intel ./card0/codec#0:Codec: Realtek ALC883 ./card0/codec#0:Address: 0 ./card0/codec#0:Function Id: 0x1 ./card0/codec#0:Vendor Id: 0x10ec0883 ./card0/codec#0:Subsystem Id: 0x10ec0883 ./card0/codec#0:Revision Id: 0x100002 ./card0/codec#0:No Modem Function Group found ./card0/codec#0:Default PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Default Amp-In caps: N/A ./card0/codec#0:Default Amp-Out caps: N/A ./card0/codec#0:GPIO: io=2, o=0, i=0, unsolicited=1, wake=0 ./card0/codec#0: IO[0]: enable=0, dir=0, wake=0, sticky=0, data=0, unsol=0 ./card0/codec#0: IO[1]: enable=0, dir=0, wake=0, sticky=0, data=0, unsol=0 ./card0/codec#0:Node 0x02 [Audio Output] wcaps 0x11: Stereo ./card0/codec#0: Converter: stream=5, channel=0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x03 [Audio Output] wcaps 0x11: Stereo ./card0/codec#0: Converter: stream=5, channel=4 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x04 [Audio Output] wcaps 0x11: Stereo ./card0/codec#0: Converter: stream=5, channel=2 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x05 [Audio Output] wcaps 0x11: Stereo ./card0/codec#0: Converter: stream=5, channel=0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x06 [Audio Output] wcaps 0x211: Stereo Digital ./card0/codec#0: Converter: stream=0, channel=0 ./card0/codec#0: Digital: ./card0/codec#0: Digital category: 0x0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0x1e]: 16 20 24 32 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x07 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x08 [Audio Input] wcaps 0x10011b: Stereo Amp-In ./card0/codec#0: Amp-In caps: ofs=0x08, nsteps=0x1f, stepsize=0x05, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Converter: stream=0, channel=0 ./card0/codec#0: SDI-Select: 0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x160]: 44100 48000 96000 ./card0/codec#0: bits [0x6]: 16 20 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0: Connection: 1 ./card0/codec#0: 0x23 ./card0/codec#0:Node 0x09 [Audio Input] wcaps 0x10011b: Stereo Amp-In ./card0/codec#0: Amp-In caps: ofs=0x08, nsteps=0x1f, stepsize=0x05, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Converter: stream=0, channel=0 ./card0/codec#0: SDI-Select: 0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x160]: 44100 48000 96000 ./card0/codec#0: bits [0x6]: 16 20 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0: Connection: 1 ./card0/codec#0: 0x22 ./card0/codec#0:Node 0x0a [Audio Input] wcaps 0x100391: Stereo Digital ./card0/codec#0: Converter: stream=0, channel=0 ./card0/codec#0: SDI-Select: 0 ./card0/codec#0: Digital: ./card0/codec#0: Digital category: 0x0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0x1e]: 16 20 24 32 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 1 ./card0/codec#0: 0x1f ./card0/codec#0:Node 0x0b [Audio Mixer] wcaps 0x20010b: Stereo Amp-In ./card0/codec#0: Amp-In caps: ofs=0x17, nsteps=0x1f, stepsize=0x05, mute=1 ./card0/codec#0: Amp-In vals: [0x9f 0x9f] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] ./card0/codec#0: Connection: 10 ./card0/codec#0: 0x18 0x19 0x1a 0x1b 0x1c 0x1d 0x14 0x15 0x16 0x17 ./card0/codec#0:Node 0x0c [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=0 ./card0/codec#0: Amp-Out vals: [0x1f 0x1f] ./card0/codec#0: Connection: 2 ./card0/codec#0: 0x02 0x0b ./card0/codec#0:Node 0x0d [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=0 ./card0/codec#0: Amp-Out vals: [0x1f 0x1f] ./card0/codec#0: Connection: 2 ./card0/codec#0: 0x03 0x0b ./card0/codec#0:Node 0x0e [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=0 ./card0/codec#0: Amp-Out vals: [0x1f 0x1f] ./card0/codec#0: Connection: 2 ./card0/codec#0: 0x04 0x0b ./card0/codec#0:Node 0x0f [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=0 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Connection: 2 ./card0/codec#0: 0x05 0x0b ./card0/codec#0:Node 0x10 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x11 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x12 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x13 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x14 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Pincap 0x0000003e: IN OUT HP Detect Trigger ./card0/codec#0: Pin Default 0x01014030: [Jack] Line Out at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Green ./card0/codec#0: DefAssociation = 0x3, Sequence = 0x0 ./card0/codec#0: Pin-ctls: 0x40: OUT ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c* 0x0d 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x15 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Pincap 0x0000003e: IN OUT HP Detect Trigger ./card0/codec#0: Pin Default 0x01011031: [Jack] Line Out at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Black ./card0/codec#0: DefAssociation = 0x3, Sequence = 0x1 ./card0/codec#0: Pin-ctls: 0x40: OUT ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c 0x0d* 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x16 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Pincap 0x0000003e: IN OUT HP Detect Trigger ./card0/codec#0: Pin Default 0x01016032: [Jack] Line Out at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Orange ./card0/codec#0: DefAssociation = 0x3, Sequence = 0x2 ./card0/codec#0: Pin-ctls: 0x40: OUT ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c 0x0d 0x0e* 0x0f 0x26 ./card0/codec#0:Node 0x17 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Pincap 0x0000003e: IN OUT HP Detect Trigger ./card0/codec#0: Pin Default 0x01012033: [Jack] Line Out at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Grey ./card0/codec#0: DefAssociation = 0x3, Sequence = 0x3 ./card0/codec#0: Pin-ctls: 0x40: OUT ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c 0x0d 0x0e 0x0f* 0x26 ./card0/codec#0:Node 0x18 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x80 0x80] ./card0/codec#0: Pincap 0x0000173e: IN OUT HP Detect Trigger ./card0/codec#0: Vref caps: HIZ 50 GRD 80 ./card0/codec#0: Pin Default 0x01a19850: [Jack] Mic at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Pink ./card0/codec#0: DefAssociation = 0x5, Sequence = 0x0 ./card0/codec#0: Pin-ctls: 0x24: IN VREF_80 ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c* 0x0d 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x19 [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x80 0x80] ./card0/codec#0: Pincap 0x0000173e: IN OUT HP Detect Trigger ./card0/codec#0: Vref caps: HIZ 50 GRD 80 ./card0/codec#0: Pin Default 0x02a19c80: [Jack] Mic at Ext Front ./card0/codec#0: Conn = 1/8, Color = Pink ./card0/codec#0: DefAssociation = 0x8, Sequence = 0x0 ./card0/codec#0: Pin-ctls: 0x24: IN VREF_80 ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c* 0x0d 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x1a [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x80 0x80] ./card0/codec#0: Pincap 0x0000173e: IN OUT HP Detect Trigger ./card0/codec#0: Vref caps: HIZ 50 GRD 80 ./card0/codec#0: Pin Default 0x01813050: [Jack] Line In at Ext Rear ./card0/codec#0: Conn = 1/8, Color = Blue ./card0/codec#0: DefAssociation = 0x5, Sequence = 0x0 ./card0/codec#0: Pin-ctls: 0x20: IN VREF_HIZ ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c* 0x0d 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x1b [Pin Complex] wcaps 0x40018f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 ./card0/codec#0: Amp-In vals: [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Pincap 0x0000173e: IN OUT HP Detect Trigger ./card0/codec#0: Vref caps: HIZ 50 GRD 80 ./card0/codec#0: Pin Default 0x02214c40: [Jack] HP Out at Ext Front ./card0/codec#0: Conn = 1/8, Color = Green ./card0/codec#0: DefAssociation = 0x4, Sequence = 0x0 ./card0/codec#0: Pin-ctls: 0xc0: OUT HP VREF_HIZ ./card0/codec#0: Unsolicited: tag=00, enabled=0 ./card0/codec#0: Connection: 5 ./card0/codec#0: 0x0c* 0x0d 0x0e 0x0f 0x26 ./card0/codec#0:Node 0x1c [Pin Complex] wcaps 0x400001: Stereo ./card0/codec#0: Pincap 0x00000020: IN ./card0/codec#0: Pin Default 0x99331150: [Fixed] CD at Int ATAPI ./card0/codec#0: Conn = ATAPI, Color = Black ./card0/codec#0: DefAssociation = 0x5, Sequence = 0x0 ./card0/codec#0: Misc = NO_PRESENCE ./card0/codec#0: Pin-ctls: 0x00: ./card0/codec#0:Node 0x1d [Pin Complex] wcaps 0x400000: Mono ./card0/codec#0: Pincap 0x00000020: IN ./card0/codec#0: Pin Default 0x00000100: [Jack] Line Out at Ext N/A ./card0/codec#0: Conn = Unknown, Color = Unknown ./card0/codec#0: DefAssociation = 0x0, Sequence = 0x0 ./card0/codec#0: Misc = NO_PRESENCE ./card0/codec#0: Pin-ctls: 0x00: ./card0/codec#0:Node 0x1e [Pin Complex] wcaps 0x400300: Mono Digital ./card0/codec#0: Pincap 0x00000010: OUT ./card0/codec#0: Pin Default 0x01441170: [Jack] SPDIF Out at Ext Rear ./card0/codec#0: Conn = RCA, Color = Black ./card0/codec#0: DefAssociation = 0x7, Sequence = 0x0 ./card0/codec#0: Misc = NO_PRESENCE ./card0/codec#0: Pin-ctls: 0x00: ./card0/codec#0: Connection: 1 ./card0/codec#0: 0x06 ./card0/codec#0:Node 0x1f [Pin Complex] wcaps 0x400200: Mono Digital ./card0/codec#0: Pincap 0x00000020: IN ./card0/codec#0: Pin Default 0x01c46160: [Jack] SPDIF In at Ext Rear ./card0/codec#0: Conn = RCA, Color = Orange ./card0/codec#0: DefAssociation = 0x6, Sequence = 0x0 ./card0/codec#0: Misc = NO_PRESENCE ./card0/codec#0: Pin-ctls: 0x00: ./card0/codec#0:Node 0x20 [Vendor Defined Widget] wcaps 0xf00040: Mono ./card0/codec#0: Processing caps: benign=0, ncoeff=17 ./card0/codec#0: Processing Coefficient: 0xcccc ./card0/codec#0: Coefficient Index: 0x10 ./card0/codec#0:Node 0x21 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x22 [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] ./card0/codec#0: Amp-Out caps: N/A ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Connection: 11 ./card0/codec#0: 0x18 0x19 0x1a 0x1b 0x1c 0x1d 0x14 0x15 0x16 0x17 0x0b ./card0/codec#0:Node 0x23 [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] [0x80 0x80] ./card0/codec#0: Amp-Out caps: N/A ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Connection: 11 ./card0/codec#0: 0x18 0x19 0x1a 0x1b 0x1c 0x1d 0x14 0x15 0x16 0x17 0x0b ./card0/codec#0:Node 0x24 [Vendor Defined Widget] wcaps 0xf00000: Mono ./card0/codec#0:Node 0x25 [Audio Output] wcaps 0x11: Stereo ./card0/codec#0: Converter: stream=0, channel=0 ./card0/codec#0: PCM: ./card0/codec#0: rates [0x560]: 44100 48000 96000 192000 ./card0/codec#0: bits [0xe]: 16 20 24 ./card0/codec#0: formats [0x1]: PCM ./card0/codec#0:Node 0x26 [Audio Mixer] wcaps 0x20010f: Stereo Amp-In Amp-Out ./card0/codec#0: Amp-In caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 ./card0/codec#0: Amp-In vals: [0x00 0x00] [0x00 0x00] ./card0/codec#0: Amp-Out caps: ofs=0x1f, nsteps=0x1f, stepsize=0x05, mute=0 ./card0/codec#0: Amp-Out vals: [0x00 0x00] ./card0/codec#0: Connection: 2 ./card0/codec#0: 0x25 0x0b =============================================== Thanks, Fred

1 0

[alsa-devel] [PATCH] ASoC: wm8350: Don't use irq_base
by Mark Brown 14 May '12

14 May '12

In preparation for irq_domain support change the code to the not switch based on the irq number. This actually makes things simpler, if slightly repetitive. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8350.c | 46 ++++++++++++++++++++++++++------------------- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/sound/soc/codecs/wm8350.c b/sound/soc/codecs/wm8350.c index 8006149..8cee548 100644 --- a/sound/soc/codecs/wm8350.c +++ b/sound/soc/codecs/wm8350.c @@ -1291,35 +1291,36 @@ static void wm8350_hpr_work(struct work_struct *work) wm8350_hp_work(priv, &priv->hpr, WM8350_JACK_R_LVL); } -static irqreturn_t wm8350_hp_jack_handler(int irq, void *data) +static irqreturn_t wm8350_hpl_jack_handler(int irq, void *data) { struct wm8350_data *priv = data; struct wm8350 *wm8350 = priv->wm8350; - struct wm8350_jack_data *jack = NULL; - switch (irq - wm8350->irq_base) { - case WM8350_IRQ_CODEC_JCK_DET_L: #ifndef CONFIG_SND_SOC_WM8350_MODULE - trace_snd_soc_jack_irq("WM8350 HPL"); + trace_snd_soc_jack_irq("WM8350 HPL"); #endif - jack = &priv->hpl; - break; - case WM8350_IRQ_CODEC_JCK_DET_R: + if (device_may_wakeup(wm8350->dev)) + pm_wakeup_event(wm8350->dev, 250); + + schedule_delayed_work(&priv->hpl.work, 200); + + return IRQ_HANDLED; +} + +static irqreturn_t wm8350_hpr_jack_handler(int irq, void *data) +{ + struct wm8350_data *priv = data; + struct wm8350 *wm8350 = priv->wm8350; + #ifndef CONFIG_SND_SOC_WM8350_MODULE - trace_snd_soc_jack_irq("WM8350 HPR"); + trace_snd_soc_jack_irq("WM8350 HPR"); #endif - jack = &priv->hpr; - break; - - default: - BUG(); - } if (device_may_wakeup(wm8350->dev)) pm_wakeup_event(wm8350->dev, 250); - schedule_delayed_work(&jack->work, 200); + schedule_delayed_work(&priv->hpr.work, 200); return IRQ_HANDLED; } @@ -1370,7 +1371,14 @@ int wm8350_hp_jack_detect(struct snd_soc_codec *codec, enum wm8350_jack which, } /* Sync status */ - wm8350_hp_jack_handler(irq + wm8350->irq_base, priv); + switch (which) { + case WM8350_JDL: + wm8350_hpl_jack_handler(0, priv); + break; + case WM8350_JDR: + wm8350_hpr_jack_handler(0, priv); + break; + } return 0; } @@ -1554,10 +1562,10 @@ static int wm8350_codec_probe(struct snd_soc_codec *codec) WM8350_JDL_ENA | WM8350_JDR_ENA); wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_L, - wm8350_hp_jack_handler, 0, "Left jack detect", + wm8350_hpl_jack_handler, 0, "Left jack detect", priv); wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_R, - wm8350_hp_jack_handler, 0, "Right jack detect", + wm8350_hpr_jack_handler, 0, "Right jack detect", priv); wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_MICSCD, wm8350_mic_handler, 0, "Microphone short", priv); -- 1.7.10

1 0

[alsa-devel] [PATCH] ASoC: max98095: Single bit bitfields should be unsigned
by Mark Brown 14 May '12

14 May '12

There's no space for the sign bit. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- include/sound/max98095.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sound/max98095.h b/include/sound/max98095.h index 65b1c90..e87ae67 100644 --- a/include/sound/max98095.h +++ b/include/sound/max98095.h @@ -55,7 +55,7 @@ struct max98095_pdata { * 0 = PIN5 not supported * 1 = PIN5 supported */ - int jack_detect_pin5en:1; + unsigned int jack_detect_pin5en:1; /* Slew amount for jack detection. Calculated as 4 * (delay + 1). * Default delay is 24 to get a time of 100ms. -- 1.7.10

1 0

[alsa-devel] [PATCH] ASoC: lm49453: Staticise non-exported symbol lm45453_dai
by Mark Brown 14 May '12

14 May '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/lm49453.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c index 5eb726b..02a8179 100644 --- a/sound/soc/codecs/lm49453.c +++ b/sound/soc/codecs/lm49453.c @@ -1358,7 +1358,7 @@ static struct snd_soc_dai_ops lm49453_lineout_dai_ops = { }; /* LM49453 dai structure. */ -struct snd_soc_dai_driver lm49453_dai[] = { +static const struct snd_soc_dai_driver lm49453_dai[] = { { .name = "LM49453 Headset", .playback = { -- 1.7.10

1 0