February 2012 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH v3 1/2] mxs-dma : move the mxs dma.h to a more common place
by Shawn Guo 11 Feb '12

11 Feb '12

On Sat, Feb 11, 2012 at 07:36:50AM +0800, Huang Shijie wrote: > hi, > > On Sat, Feb 11, 2012 at 12:21 AM, Shawn Guo <shawn.guo(a)linaro.org> wrote: > > On Tue, Feb 07, 2012 at 06:54:34PM +0800, Huang Shijie wrote: > >> Move the header to a more common place. > >> The mxs dma engine is not only used in mx23/mx28, but also used > >> in mx50/mx6q. It will also be used in the future chips. > >> > >> Rename it to mxs-dma.h > >> > >> change mxs-dma driver, mxs-mmc driver, gpmi-nand driver, mxs-saif driver > >> to the new header file. > >> > >> Signed-off-by: Huang Shijie <b32955(a)freescale.com> > >> --- > >> drivers/dma/mxs-dma.c | 2 +- > >> drivers/mmc/host/mxs-mmc.c | 2 +- > >> drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 2 +- > >> .../include/mach/dma.h => include/linux/mxs-dma.h | 0 > >> sound/soc/mxs/mxs-pcm.c | 2 +- > >> sound/soc/mxs/mxs-pcm.h | 2 +- > >> sound/soc/mxs/mxs-saif.c | 2 +- > >> 7 files changed, 6 insertions(+), 6 deletions(-) > >> rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%) > > > > I suggested you rename it include/linux/fsl/mxs-dma.h [1]. It seems > > you are ignoring the comment. Can you explain why it's not a > > reasonable suggestion? > > For gpmi-nand.h is placed in include/linux/mtd/ directory, so i think > it's better to place the mxs-dma.h > to similar include/linux/dma/ directory, but the directory does not exit. > Yes, from subsystem point of view, it makes sense too. > If i place it at include/linux/fsl/mxs-dma.h , i have to create a new > folder, I am not sure i have the right > to do so. But i can try it in the next version. > So either way works for me. But you need to create a folder anyway. So let's do it to test people. > thanks a lot. > > > > > > > And Wolfram and Mark told you that you need to Cc subsystem maintainers > > to collect their acks [2]. But you are still not Ccing Mark Brown and > > Chris Ball for sound/soc/ and drivers/mmc changes. So you are not > > listening. > > ok, i will CC them in next version. I　really did not know to whom I　should cc . > The file MAINTAINERS is created for this purpose. -- Regards, Shawn

1 0

[alsa-devel] [PATCH] ASoC: wm8993: Add register default for INPUTS_CLAMP
by Mark Brown 10 Feb '12

10 Feb '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8993.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c index acc39ea..1e69f63 100644 --- a/sound/soc/codecs/wm8993.c +++ b/sound/soc/codecs/wm8993.c @@ -61,6 +61,7 @@ static struct reg_default wm8993_reg_defaults[] = { { 18, 0x0000 }, /* R18 - GPIO CTRL 1 */ { 19, 0x0010 }, /* R19 - GPIO1 */ { 20, 0x0000 }, /* R20 - IRQ_DEBOUNCE */ + { 21, 0x0000 }, /* R21 - Inputs Clamp */ { 22, 0x8000 }, /* R22 - GPIOCTRL 2 */ { 23, 0x0800 }, /* R23 - GPIO_POL */ { 24, 0x008B }, /* R24 - Left Line Input 1&2 Volume */ -- 1.7.9.rc1

1 0

[alsa-devel] [PATCH] sound/soc/mxs/mxs-saif.c: use devm_ functions
by Julia Lawall 10 Feb '12

10 Feb '12

From: Julia Lawall <Julia.Lawall(a)lip6.fr> The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall <Julia.Lawall(a)lip6.fr> --- patch against git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git from the branch for-3.4 sound/soc/mxs/mxs-saif.c | 51 ++++++++++------------------------------------- 1 file changed, 11 insertions(+), 40 deletions(-) diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c index f204dba..12be05b 100644 --- a/sound/soc/mxs/mxs-saif.c +++ b/sound/soc/mxs/mxs-saif.c @@ -630,7 +630,7 @@ static int mxs_saif_probe(struct platform_device *pdev) if (pdev->id >= ARRAY_SIZE(mxs_saif)) return -EINVAL; - saif = kzalloc(sizeof(*saif), GFP_KERNEL); + saif = devm_kzalloc(&pdev->dev, sizeof(*saif), GFP_KERNEL); if (!saif) return -ENOMEM; @@ -655,29 +655,16 @@ static int mxs_saif_probe(struct platform_device *pdev) ret = PTR_ERR(saif->clk); dev_err(&pdev->dev, "Cannot get the clock: %d\n", ret); - goto failed_clk; + return ret; } iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!iores) { - ret = -ENODEV; - dev_err(&pdev->dev, "failed to get io resource: %d\n", - ret); - goto failed_get_resource; - } - if (!request_mem_region(iores->start, resource_size(iores), - "mxs-saif")) { - dev_err(&pdev->dev, "request_mem_region failed\n"); - ret = -EBUSY; - goto failed_get_resource; - } - - saif->base = ioremap(iores->start, resource_size(iores)); + saif->base = devm_request_and_ioremap(&pdev->dev, iores); if (!saif->base) { dev_err(&pdev->dev, "ioremap failed\n"); ret = -ENODEV; - goto failed_ioremap; + goto failed_get_resource; } dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0); @@ -685,7 +672,7 @@ static int mxs_saif_probe(struct platform_device *pdev) ret = -ENODEV; dev_err(&pdev->dev, "failed to get dma resource: %d\n", ret); - goto failed_ioremap; + goto failed_get_resource; } saif->dma_param.chan_num = dmares->start; @@ -694,14 +681,15 @@ static int mxs_saif_probe(struct platform_device *pdev) ret = saif->irq; dev_err(&pdev->dev, "failed to get irq resource: %d\n", ret); - goto failed_get_irq1; + goto failed_get_resource; } saif->dev = &pdev->dev; - ret = request_irq(saif->irq, mxs_saif_irq, 0, "mxs-saif", saif); + ret = devm_request_irq(&pdev->dev, saif->irq, mxs_saif_irq, 0, + "mxs-saif", saif); if (ret) { dev_err(&pdev->dev, "failed to request irq\n"); - goto failed_get_irq1; + goto failed_get_resource; } saif->dma_param.chan_irq = platform_get_irq(pdev, 1); @@ -709,7 +697,7 @@ static int mxs_saif_probe(struct platform_device *pdev) ret = saif->dma_param.chan_irq; dev_err(&pdev->dev, "failed to get dma irq resource: %d\n", ret); - goto failed_get_irq2; + goto failed_get_resource; } platform_set_drvdata(pdev, saif); @@ -717,7 +705,7 @@ static int mxs_saif_probe(struct platform_device *pdev) ret = snd_soc_register_dai(&pdev->dev, &mxs_saif_dai); if (ret) { dev_err(&pdev->dev, "register DAI failed\n"); - goto failed_register; + goto failed_get_resource; } saif->soc_platform_pdev = platform_device_alloc( @@ -740,36 +728,19 @@ failed_pdev_add: platform_device_put(saif->soc_platform_pdev); failed_pdev_alloc: snd_soc_unregister_dai(&pdev->dev); -failed_register: -failed_get_irq2: - free_irq(saif->irq, saif); -failed_get_irq1: - iounmap(saif->base); -failed_ioremap: - release_mem_region(iores->start, resource_size(iores)); failed_get_resource: clk_put(saif->clk); -failed_clk: - kfree(saif); return ret; } static int __devexit mxs_saif_remove(struct platform_device *pdev) { - struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0); struct mxs_saif *saif = platform_get_drvdata(pdev); platform_device_unregister(saif->soc_platform_pdev); - snd_soc_unregister_dai(&pdev->dev); - - iounmap(saif->base); - release_mem_region(res->start, resource_size(res)); - free_irq(saif->irq, saif); - clk_put(saif->clk); - kfree(saif); return 0; }

3 2

[alsa-devel] Regression 3.0 -> 3.1: no HDMI sound after suspend
by Mario 'BitKoenig' Holbe 10 Feb '12

10 Feb '12

Hello, since kernel 3.1 playing sound through HDMI via pulseaudio stopped working after suspend/resume on my Intel HDA (there is simply silence after resume). Same for 3.2. This worked up to 3.0 and it still works when I configure pulseaudio to play through Analog Stereo instead of HDMI, hence I guess the issue is more connected to ALSA than to pulseaudio. A work-around is to induce pulseaudio to re-open the underlying audio devices (`pasuspender true' does the trick). Here is the alsa-info.sh output for kernels 3.0 and 3.1 (no significant changes afaics): http://www.alsa-project.org/db/?f=67e9358c83963773f69905b12d7dba06c4c010ed http://www.alsa-project.org/db/?f=219dd70eee2160669f86c77c0585244b2decb5ef Please let me know if I can provide further information. Thanks for your work & best regards Mario -- We know that communication is a problem, but the company is not going to discuss it with the employees. -- Switching supervisor, AT&T Long Lines Division

1 0

[alsa-devel] [PATCH] ASoC: wm8993: Correct typos in regmap conversion
by Mark Brown 10 Feb '12

10 Feb '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8993.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c index f65339f..acc39ea 100644 --- a/sound/soc/codecs/wm8993.c +++ b/sound/soc/codecs/wm8993.c @@ -61,8 +61,8 @@ static struct reg_default wm8993_reg_defaults[] = { { 18, 0x0000 }, /* R18 - GPIO CTRL 1 */ { 19, 0x0010 }, /* R19 - GPIO1 */ { 20, 0x0000 }, /* R20 - IRQ_DEBOUNCE */ - { 21, 0x8000 }, /* R22 - GPIOCTRL 2 */ - { 22, 0x0800 }, /* R23 - GPIO_POL */ + { 22, 0x8000 }, /* R22 - GPIOCTRL 2 */ + { 23, 0x0800 }, /* R23 - GPIO_POL */ { 24, 0x008B }, /* R24 - Left Line Input 1&2 Volume */ { 25, 0x008B }, /* R25 - Left Line Input 3&4 Volume */ { 26, 0x008B }, /* R26 - Right Line Input 1&2 Volume */ -- 1.7.9.rc1

1 0

[alsa-devel] VT1705 : Mic not working with power_save
by Anisse Astier 10 Feb '12

10 Feb '12

Hi, On the hardware described in attached alsa-info (VT1705), I have the following problem: - mic doesn't work - if, while recording, we switch "input source", mic works during the recording session. Passing power_save=0 as a parameter to snd-hda-intel solves the problem. It was reproduced on linus' master branch, tiwai's for-next branch, and 3.2 branch. Regards, Anisse

1 0

[alsa-devel] system announce port documentation
by Lieven Moors 10 Feb '12

10 Feb '12

Hi, I have been searching in vain for info or examples on how to use the system announce port of alsa sequencer. Is there somebody who could help me with that? A simple example, or a reference to a simple program that uses this port, would also be of great help. Thanks for your help, Greetings, lieven

2 2

Re: [alsa-devel] [PATCH v3 1/2] mxs-dma : move the mxs dma.h to a more common place
by Shawn Guo 10 Feb '12

10 Feb '12

On Tue, Feb 07, 2012 at 06:54:34PM +0800, Huang Shijie wrote: > Move the header to a more common place. > The mxs dma engine is not only used in mx23/mx28, but also used > in mx50/mx6q. It will also be used in the future chips. > > Rename it to mxs-dma.h > > change mxs-dma driver, mxs-mmc driver, gpmi-nand driver, mxs-saif driver > to the new header file. > > Signed-off-by: Huang Shijie <b32955(a)freescale.com> > --- > drivers/dma/mxs-dma.c | 2 +- > drivers/mmc/host/mxs-mmc.c | 2 +- > drivers/mtd/nand/gpmi-nand/gpmi-nand.h | 2 +- > .../include/mach/dma.h => include/linux/mxs-dma.h | 0 > sound/soc/mxs/mxs-pcm.c | 2 +- > sound/soc/mxs/mxs-pcm.h | 2 +- > sound/soc/mxs/mxs-saif.c | 2 +- > 7 files changed, 6 insertions(+), 6 deletions(-) > rename arch/arm/mach-mxs/include/mach/dma.h => include/linux/mxs-dma.h (100%) I suggested you rename it include/linux/fsl/mxs-dma.h [1]. It seems you are ignoring the comment. Can you explain why it's not a reasonable suggestion? And Wolfram and Mark told you that you need to Cc subsystem maintainers to collect their acks [2]. But you are still not Ccing Mark Brown and Chris Ball for sound/soc/ and drivers/mmc changes. So you are not listening. Regards, Shawn [1] http://article.gmane.org/gmane.linux.kernel.mmc/12301 [2] http://article.gmane.org/gmane.linux.alsa.devel/93751

1 0

[alsa-devel] [PATCH] ASoC: Fix build error in sound/soc/omap/n810.c
by Axel Lin 10 Feb '12

10 Feb '12

Fix below build error which is introduced by commit 022658 "ASoC: core: Add support for DAI and machine kcontrols". CC [M] sound/soc/omap/n810.o sound/soc/omap/n810.c: In function 'n810_set_input': sound/soc/omap/n810.c:194: error: 'codec' undeclared (first use in this function) sound/soc/omap/n810.c:194: error: (Each undeclared identifier is reported only once sound/soc/omap/n810.c:194: error: for each function it appears in.) sound/soc/omap/n810.c:188: warning: unused variable 'card' make[3]: *** [sound/soc/omap/n810.o] Error 1 make[2]: *** [sound/soc/omap] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2 Signed-off-by: Axel Lin <axel.lin(a)gmail.com> --- sound/soc/omap/n810.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c index 1490227..c292bf0 100644 --- a/sound/soc/omap/n810.c +++ b/sound/soc/omap/n810.c @@ -191,7 +191,7 @@ static int n810_set_input(struct snd_kcontrol *kcontrol, return 0; n810_dmic_func = ucontrol->value.integer.value[0]; - n810_ext_control(codec); + n810_ext_control(&card->dapm); return 1; } -- 1.7.5.4

3 2

[alsa-devel] Multiple channels mapping
by Patrick Lai 10 Feb '12

10 Feb '12

Hi, The DSP I am working on supports channel assignments similar to ALSA route plug-in described in this link http://drona.csa.iisc.ernet.in /~uday/alsamch.shtml. I am currently looking a way to pass channel/speaker mapping information of PCM stream( i.c channel 0 -> Front Left speaker, channel 1 -> Front Right speaker) to ALSA driver. I looked at latest kernel tree and don't think there is already provision for my purpose. Can anyone confirm? If I were to improvise a way to pass channel/speaker mapping information, should I follow the same approach similar to how bits per sample and other hardware parameter is passed? Thanks Patrick -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

4 6