December 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [sound:topic/hda-ca0132-dsp 4/11] sound/pci/hda/patch_ca0132.c:714 dspio_send() warn: always true condition '(res >= 0) => (0-u32max >= 0)'
by Dan Carpenter 17 Dec '12

17 Dec '12

Hi Ian, FYI, there are new smatch warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/hda-ca0132-dsp head: cdc83c59e59d57b250be46c4b9d31e3b2b5ae589 commit: 01ef7dbffb411d9d78d1150b268d9c757f9f2f93 [4/11] ALSA: hda - Update CA0132 codec to load DSP firmware binary + sound/pci/hda/patch_ca0132.c:714 dspio_send() warn: always true condition '(res >= 0) => (0-u32max >= 0)' sound/pci/hda/patch_ca0132.c:1781 dspxfr_one_seg() info: why not … [View More]propagate 'status' from dsp_dma_stop() instead of (-5)? sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: potential null dereference 'dma_engine'. (kzalloc returns null) sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: we previously assumed 'dma_engine' could be null (see line 1857) git remote add sound git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git remote update sound git checkout 01ef7dbffb411d9d78d1150b268d9c757f9f2f93 vim +714 sound/pci/hda/patch_ca0132.c 01ef7dbf Ian Minett 2012-09-20 698 VENDOR_CHIPIO_PLL_PMU_WRITE, 0xff); 01ef7dbf Ian Minett 2012-09-20 699 mutex_unlock(&spec->chipio_mutex); 01ef7dbf Ian Minett 2012-09-20 700 } 01ef7dbf Ian Minett 2012-09-20 701 01ef7dbf Ian Minett 2012-09-20 702 /* 01ef7dbf Ian Minett 2012-09-20 703 * CA0132 DSP IO stuffs 01ef7dbf Ian Minett 2012-09-20 704 */ 01ef7dbf Ian Minett 2012-09-20 705 static int dspio_send(struct hda_codec *codec, unsigned int reg, 01ef7dbf Ian Minett 2012-09-20 706 unsigned int data) 01ef7dbf Ian Minett 2012-09-20 707 { 01ef7dbf Ian Minett 2012-09-20 708 unsigned int res; 01ef7dbf Ian Minett 2012-09-20 709 int retry = 50; 01ef7dbf Ian Minett 2012-09-20 710 01ef7dbf Ian Minett 2012-09-20 711 /* send bits of data specified by reg to dsp */ 01ef7dbf Ian Minett 2012-09-20 712 do { 01ef7dbf Ian Minett 2012-09-20 713 res = snd_hda_codec_read(codec, WIDGET_DSP_CTRL, 0, reg, data); 01ef7dbf Ian Minett 2012-09-20 @714 if ((res >= 0) && (res != VENDOR_STATUS_DSPIO_BUSY)) 01ef7dbf Ian Minett 2012-09-20 715 return res; 01ef7dbf Ian Minett 2012-09-20 716 } while (--retry); 01ef7dbf Ian Minett 2012-09-20 717 01ef7dbf Ian Minett 2012-09-20 718 return -EIO; 01ef7dbf Ian Minett 2012-09-20 719 } 01ef7dbf Ian Minett 2012-09-20 720 01ef7dbf Ian Minett 2012-09-20 721 static void dspio_write_wait(struct hda_codec *codec) 01ef7dbf Ian Minett 2012-09-20 722 { --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation [View Less]

1 0

[alsa-devel] The new alsa-driver repository
by Jaroslav Kysela 17 Dec '12

17 Dec '12

Hello all, the ALSA server has new alsa-driver repository which contains several branches for now: master - just empty one with README build - the previous master branch (but all was moved to the alsa/ subtree) mirror - mirrored code from upstream (ALSA parts only) release - merging branch for mirror/build trees to create a relationship between them All branches are ophan. It means that they have no common parent. I put some handy configuration hints to the ALSA WIKI: http://www.… [View More]

2 1

[alsa-devel] [PATCH] ALSA: hda - Fix clicking noise on Thinkpad T61/R61i
by David Henningsson 17 Dec '12

17 Dec '12

The bug reporter reports that setting the speaker pin to D3 before turning off its pinctl fixes the clicking noise on powersave for Thinkpad T61. Thanks to c4pp4 for doing most of the work with this bug, including reporting and testing, and writing preliminary patches. BugLink: https://bugs.launchpad.net/bugs/886975 Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/patch_conexant.c | 36 ++++++++++++++++++++++++++++++++---- 1 file changed, 32 … [View More]insertions(+), 4 deletions(-) Note: c4pp4 pointed out that in his case, only the speaker needed to go to D3 before pinctl, but noticed no regressions from the below implementation, so I made the fixup more generic (easier to reuse later). diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index a3a2263..27e6ca7 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -144,6 +144,7 @@ struct conexant_spec { unsigned int asus:1; unsigned int pin_eapd_ctrls:1; unsigned int fixup_stereo_dmic:1; + unsigned int d3_before_shutup:1; /* Needs speaker to go to D3 before pinctl */ unsigned int adc_switching:1; @@ -558,13 +559,22 @@ static int conexant_build_controls(struct hda_codec *codec) return 0; } -#ifdef CONFIG_PM static int conexant_suspend(struct hda_codec *codec) { + struct conexant_spec *spec = codec->spec; + + if (spec->d3_before_shutup) + snd_hda_codec_set_power_to_all(codec, codec->afg, AC_PWRST_D3, + false); snd_hda_shutup_pins(codec); return 0; } -#endif + +static void conexant_reboot_notify(struct hda_codec *codec) +{ + conexant_suspend(codec); +} + static const struct hda_codec_ops conexant_patch_ops = { .build_controls = conexant_build_controls, @@ -575,7 +585,7 @@ static const struct hda_codec_ops conexant_patch_ops = { #ifdef CONFIG_PM .suspend = conexant_suspend, #endif - .reboot_notify = snd_hda_shutup_pins, + .reboot_notify = conexant_reboot_notify, }; #ifdef CONFIG_SND_HDA_INPUT_BEEP @@ -4408,7 +4418,7 @@ static const struct hda_codec_ops cx_auto_patch_ops = { #ifdef CONFIG_PM .suspend = conexant_suspend, #endif - .reboot_notify = snd_hda_shutup_pins, + .reboot_notify = conexant_reboot_notify, }; /* @@ -4421,6 +4431,7 @@ enum { CXT_PINCFG_LEMOTE_A1205, CXT_FIXUP_STEREO_DMIC, CXT_FIXUP_INC_MIC_BOOST, + CXT_FIXUP_D3_BEFORE_SHUTUP, }; static void cxt_fixup_stereo_dmic(struct hda_codec *codec, @@ -4430,6 +4441,13 @@ static void cxt_fixup_stereo_dmic(struct hda_codec *codec, spec->fixup_stereo_dmic = 1; } +static void cxt_fixup_d3_before_shutup(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct conexant_spec *spec = codec->spec; + spec->d3_before_shutup = 1; +} + static void cxt5066_increase_mic_boost(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -4499,6 +4517,15 @@ static const struct hda_fixup cxt_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = cxt5066_increase_mic_boost, }, + [CXT_FIXUP_D3_BEFORE_SHUTUP] = { + .type = HDA_FIXUP_FUNC, + .v.func = cxt_fixup_d3_before_shutup, + }, +}; + +static const struct snd_pci_quirk cxt5045_fixups[] = { + SND_PCI_QUIRK(0x17aa, 0x20ac, "Lenovo T61/R61i", CXT_FIXUP_D3_BEFORE_SHUTUP), + {} }; static const struct snd_pci_quirk cxt5051_fixups[] = { @@ -4553,6 +4580,7 @@ static int patch_conexant_auto(struct hda_codec *codec) switch (codec->vendor_id) { case 0x14f15045: codec->single_adc_amp = 1; + snd_hda_pick_fixup(codec, NULL, cxt5045_fixups, cxt_fixups); break; case 0x14f15051: add_cx5051_fake_mutes(codec); -- 1.7.9.5 [View Less]

2 3

[alsa-devel] ASoC updates for v3.8
by Mark Brown 17 Dec '12

17 Dec '12

2 3

[alsa-devel] [PATCH 0/3] at91/ssc: fixes on ASoC tree for 3.8
by Nicolas Ferre 17 Dec '12

17 Dec '12

Hi Mark, This series goes on top of current Linus' git tree and fixes an error that we have while compiling DTBs for AT91: ERROR (phandle_references): Reference to non-existent node or label "pinctrl_ssc0_tx" ERROR: Input tree has errors, aborting (use -f to force output) make[3]: *** [arch/arm/boot/dts/at91sam9g20ek.dtb] Error 2 I have included pending material that is dealing with SSC and pinctrl. The pinctrl part can be merged more easily now that the big pinctrl update for AT91 has been … [View More]

2 4

Re: [alsa-devel] [Resend PATCH v6 1/4] pinctrl: atmel-ssc: add pinctrl support
by Nicolas Ferre 17 Dec '12

17 Dec '12

On 12/17/2012 10:39 AM, Jean-Christophe PLAGNIOL-VILLARD : > On 11:24 Wed 21 Nov , Mark Brown wrote: >> On Wed, Nov 21, 2012 at 10:17:09AM +0800, Bo Shen wrote: >>> Add pinctrl support for atmel ssc peripheral >>> >>> Signed-off-by: Bo Shen <voice.shen(a)atmel.com> >> >> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> > > you handle this one with scc Hold on Jean-Christophe, I made a little experiment this … [View More]

2 1

[alsa-devel] [PATCH] ASoC: atmel-ssc: change disable to disable in dts node
by Bo Shen 17 Dec '12

17 Dec '12

Change the value of status to disabled to keep the consistent Signed-off-by: Bo Shen <voice.shen(a)atmel.com> --- arch/arm/boot/dts/at91sam9260.dtsi | 2 +- arch/arm/boot/dts/at91sam9263.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9x5.dtsi | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi index aaa42d8..03c56cb 100644 --- a/arch/arm/boot/dts/… [View More]

3 2

[alsa-devel] "hda-intel: azx_get_response timeout"
by Mantas M. 17 Dec '12

17 Dec '12

After upgrading to Linux 3.7 (on Arch Linux, x86_64), I've been getting the following messages in dmesg: > [Dec11 21:52] hda-intel: azx_get_response timeout, switching to polling mode: last cmd=0x001f0500 > [ +1.006709] hda-intel: No response from codec, disabling MSI: last cmd=0x001f0500 > [ +1.006773] hda_intel: azx_get_response timeout, switching to single_cmd mode: last cmd=0x001f0500 This seems to happen when resuming from suspend-to-memory, and is new to v3.7 – I haven't seen … [View More]

2 1

Re: [alsa-devel] Could you help me about the ALSA?
by Zhang wei 17 Dec '12

17 Dec '12

> Yes,when buffer_size wraped the 'pos' is smallar than last one.If we > want to confirm the hw_base need to adjust there must be consider > another confidition: > > hdelta = jiffies - runtime->hw_ptr_jiffies; > > if (hdelta > runtime->hw_ptr_buffer_jiffies/2) > > how to connect this code with checking unnormal interrupt(lost or delayed)? This condition is for the double interrupt acknowledge problems (see comment). It makes sure,… [View More]

1 0

Re: [alsa-devel] Could you help me about the ALSA?
by Jaroslav Kysela 17 Dec '12

17 Dec '12

Date 14.12.2012 09:07, Zhang wei wrote: > Good afternoon . > > Excuse me if I disturb you, I found your contact information from the > alsa-devel > http://mailman.alsa-project.org/pipermail/alsa-devel/2010-August/030605.html > . > > Recently I am studying the alsa-driver and the code blocked me which > from the function snd_pcm_update_hw_ptr0inthe pcm_lib.c. > > =====================start==============================è > > if (in_interrupt) { … [View More]

3 6