October 2012 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] Silence playback during XRUN
by Babu, Ramesh 16 Oct '12

16 Oct '12

Hi I am trying to configure my application to use silence playback of ALSA in case XRUN. I am configuring the silence parameters as below: silence_threshold = 0 silence_size = boundary stop_threshold = bounday Using the above configuration I can see that ALSA sends silence during XRUN. But I am experiencing audio is jerky, when application starts sending the data after the XRUN. I noticed someone has met similar situation. http://mailman.alsa-project.org/pipermail/alsa-devel/2011-December/046894.h… Do I need to modify my silence settings? Anything that I need take care apart from the above mentioned parameters? Thanks Ramesh

1 1

[alsa-devel] [PATCH 1/2] ASoC: atmel-ssc: use devm_xxx() managed function
by Bo Shen 16 Oct '12

16 Oct '12

Using the devm_xxx() managed function to stripdown the error and remove code. Signed-off-by: Bo Shen <voice.shen(a)atmel.com> --- drivers/misc/atmel-ssc.c | 47 +++++++++++++++------------------------------- 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index 5bb1877..23dcb76 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -70,37 +70,33 @@ EXPORT_SYMBOL(ssc_free); static int __init ssc_probe(struct platform_device *pdev) { - int retval = 0; struct resource *regs; struct ssc_device *ssc; - ssc = kzalloc(sizeof(struct ssc_device), GFP_KERNEL); + ssc = devm_kzalloc(&pdev->dev, sizeof(struct ssc_device), GFP_KERNEL); if (!ssc) { dev_dbg(&pdev->dev, "out of memory\n"); - retval = -ENOMEM; - goto out; + return -ENOMEM; } + ssc->pdev = pdev; + regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!regs) { dev_dbg(&pdev->dev, "no mmio resource defined\n"); - retval = -ENXIO; - goto out_free; + return -ENXIO; } - ssc->clk = clk_get(&pdev->dev, "pclk"); - if (IS_ERR(ssc->clk)) { - dev_dbg(&pdev->dev, "no pclk clock defined\n"); - retval = -ENXIO; - goto out_free; - } - - ssc->pdev = pdev; - ssc->regs = ioremap(regs->start, resource_size(regs)); + ssc->regs = devm_request_and_ioremap(&pdev->dev, regs); if (!ssc->regs) { dev_dbg(&pdev->dev, "ioremap failed\n"); - retval = -EINVAL; - goto out_clk; + return -EINVAL; + } + + ssc->clk = devm_clk_get(&pdev->dev, "pclk"); + if (IS_ERR(ssc->clk)) { + dev_dbg(&pdev->dev, "no pclk clock defined\n"); + return -ENXIO; } /* disable all interrupts */ @@ -112,8 +108,7 @@ static int __init ssc_probe(struct platform_device *pdev) ssc->irq = platform_get_irq(pdev, 0); if (!ssc->irq) { dev_dbg(&pdev->dev, "could not get irq\n"); - retval = -ENXIO; - goto out_unmap; + return -ENXIO; } spin_lock(&user_lock); @@ -125,16 +120,7 @@ static int __init ssc_probe(struct platform_device *pdev) dev_info(&pdev->dev, "Atmel SSC device at 0x%p (irq %d)\n", ssc->regs, ssc->irq); - goto out; - -out_unmap: - iounmap(ssc->regs); -out_clk: - clk_put(ssc->clk); -out_free: - kfree(ssc); -out: - return retval; + return 0; } static int __devexit ssc_remove(struct platform_device *pdev) @@ -142,10 +128,7 @@ static int __devexit ssc_remove(struct platform_device *pdev) struct ssc_device *ssc = platform_get_drvdata(pdev); spin_lock(&user_lock); - iounmap(ssc->regs); - clk_put(ssc->clk); list_del(&ssc->list); - kfree(ssc); spin_unlock(&user_lock); return 0; -- 1.7.9.5

6 8

[alsa-devel] [PATCH 1/2] ASoC: Ux500: Dispose of device nodes correctly
by Lee Jones 16 Oct '12

16 Oct '12

When of_parse_phandle() is used to find a device node, its reference count is incremented by the helper. Once we're finished with them, it's our responsibly to ensure they are freed in the correct manor. Cc: alsa-devel(a)alsa-project.org Cc: Liam Girdwood <lrg(a)ti.com> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Acked-by: Linus Walleij <linus.walleij(a)linaro.org> Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- sound/soc/ux500/mop500.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index 6f67e6b..651a52a 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -57,6 +57,20 @@ static struct snd_soc_card mop500_card = { .num_links = ARRAY_SIZE(mop500_dai_links), }; +static void mop500_of_node_put(void) +{ + int i; + + for (i = 0; i < 2; i++) { + if (mop500_dai_links[i].cpu_of_node) + of_node_put((struct device_node *) + mop500_dai_links[i].cpu_of_node); + if (mop500_dai_links[i].codec_of_node) + of_node_put((struct device_node *) + mop500_dai_links[i].codec_of_node); + } +} + static int __devinit mop500_of_probe(struct platform_device *pdev, struct device_node *np) { @@ -69,6 +83,7 @@ static int __devinit mop500_of_probe(struct platform_device *pdev, if (!(msp_np[0] && msp_np[1] && codec_np)) { dev_err(&pdev->dev, "Phandle missing or invalid\n"); + mop500_of_node_put(); return -EINVAL; } @@ -83,6 +98,7 @@ static int __devinit mop500_of_probe(struct platform_device *pdev, return 0; } + static int __devinit mop500_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -128,6 +144,7 @@ static int __devexit mop500_remove(struct platform_device *pdev) snd_soc_unregister_card(mop500_card); mop500_ab8500_remove(mop500_card); + mop500_of_node_put(); return 0; } -- 1.7.9.5

2 2

[alsa-devel] [PATCH] ARM: tegra: remove <mach/dma.h>
by Stephen Warren 15 Oct '12

15 Oct '12

From: Stephen Warren <swarren(a)nvidia.com> Remove includes of <mach/dma.h> from sound/soc; nothing from it is used. Remove include of <mach/dma.h> from mach-tegra/apbio.c; since the DMA transfers made by this file don't need flow-control with any peripheral, there's no need to set any slave ID. Once those changes are made, there are no remaining users of <mach/dma.h> so remove it. Drivers should get this information from device tree. This removal is necessary for single zImage. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- Mark, I'd like to take this through the Tegra tree please, unless you want me to split out the ASoC parts of the patch, and have you apply them to 3.7. arch/arm/mach-tegra/apbio.c | 3 -- arch/arm/mach-tegra/include/mach/dma.h | 54 -------------------------------- sound/soc/tegra/tegra30_ahub.c | 1 - sound/soc/tegra/tegra_pcm.h | 2 - 4 files changed, 0 insertions(+), 60 deletions(-) delete mode 100644 arch/arm/mach-tegra/include/mach/dma.h diff --git a/arch/arm/mach-tegra/apbio.c b/arch/arm/mach-tegra/apbio.c index b5015d0..bc949fb 100644 --- a/arch/arm/mach-tegra/apbio.c +++ b/arch/arm/mach-tegra/apbio.c @@ -24,8 +24,6 @@ #include <linux/sched.h> #include <linux/mutex.h> -#include <mach/dma.h> - #include "apbio.h" #if defined(CONFIG_TEGRA20_APB_DMA) @@ -71,7 +69,6 @@ bool tegra_apb_dma_init(void) dma_sconfig.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; dma_sconfig.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; - dma_sconfig.slave_id = TEGRA_DMA_REQ_SEL_CNTR; dma_sconfig.src_maxburst = 1; dma_sconfig.dst_maxburst = 1; diff --git a/arch/arm/mach-tegra/include/mach/dma.h b/arch/arm/mach-tegra/include/mach/dma.h deleted file mode 100644 index 3081cc6..0000000 --- a/arch/arm/mach-tegra/include/mach/dma.h +++ /dev/null @@ -1,54 +0,0 @@ -/* - * arch/arm/mach-tegra/include/mach/dma.h - * - * Copyright (c) 2008-2009, NVIDIA Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - */ - -#ifndef __MACH_TEGRA_DMA_H -#define __MACH_TEGRA_DMA_H - -#include <linux/list.h> - -#define TEGRA_DMA_REQ_SEL_CNTR 0 -#define TEGRA_DMA_REQ_SEL_I2S_2 1 -#define TEGRA_DMA_REQ_SEL_I2S_1 2 -#define TEGRA_DMA_REQ_SEL_SPD_I 3 -#define TEGRA_DMA_REQ_SEL_UI_I 4 -#define TEGRA_DMA_REQ_SEL_MIPI 5 -#define TEGRA_DMA_REQ_SEL_I2S2_2 6 -#define TEGRA_DMA_REQ_SEL_I2S2_1 7 -#define TEGRA_DMA_REQ_SEL_UARTA 8 -#define TEGRA_DMA_REQ_SEL_UARTB 9 -#define TEGRA_DMA_REQ_SEL_UARTC 10 -#define TEGRA_DMA_REQ_SEL_SPI 11 -#define TEGRA_DMA_REQ_SEL_AC97 12 -#define TEGRA_DMA_REQ_SEL_ACMODEM 13 -#define TEGRA_DMA_REQ_SEL_SL4B 14 -#define TEGRA_DMA_REQ_SEL_SL2B1 15 -#define TEGRA_DMA_REQ_SEL_SL2B2 16 -#define TEGRA_DMA_REQ_SEL_SL2B3 17 -#define TEGRA_DMA_REQ_SEL_SL2B4 18 -#define TEGRA_DMA_REQ_SEL_UARTD 19 -#define TEGRA_DMA_REQ_SEL_UARTE 20 -#define TEGRA_DMA_REQ_SEL_I2C 21 -#define TEGRA_DMA_REQ_SEL_I2C2 22 -#define TEGRA_DMA_REQ_SEL_I2C3 23 -#define TEGRA_DMA_REQ_SEL_DVC_I2C 24 -#define TEGRA_DMA_REQ_SEL_OWR 25 -#define TEGRA_DMA_REQ_SEL_INVALID 31 - -#endif diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c index bf56101..64b67a3 100644 --- a/sound/soc/tegra/tegra30_ahub.c +++ b/sound/soc/tegra/tegra30_ahub.c @@ -26,7 +26,6 @@ #include <linux/regmap.h> #include <linux/slab.h> #include <mach/clk.h> -#include <mach/dma.h> #include <sound/soc.h> #include "tegra30_ahub.h" diff --git a/sound/soc/tegra/tegra_pcm.h b/sound/soc/tegra/tegra_pcm.h index b40279b..bc8b46a 100644 --- a/sound/soc/tegra/tegra_pcm.h +++ b/sound/soc/tegra/tegra_pcm.h @@ -31,8 +31,6 @@ #ifndef __TEGRA_PCM_H__ #define __TEGRA_PCM_H__ -#include <mach/dma.h> - struct tegra_pcm_dma_params { unsigned long addr; unsigned long wrap; -- 1.7.0.4

2 2

[alsa-devel] A question about speaker volume control of Creative Recon3D
by Ming Chen 15 Oct '12

15 Oct '12

Hello All, Recently I looked into the hda code for Creative sound cards, based on linux-3.6-rc3. I found that for Ca0110 (X-Fi), the patch (Patch_ca0110.c) would call add_out_volume() (and add_mono_volume()) for those DACs (refer to the ca0110_build_controls() function). While for ca0132 (Recon3D), its patch (Patch_ca0132.c) does not call add_out_volume() for any DAC (refer to the ca0132_build_controls() function). If I play a wav file under Ubuntu, it can adjust the speaker volume successfully with the Recon3D card. Can somebody kindly tell me how the speaker volume been controlled for this card? Thanks, Ming

1 0

Re: [alsa-devel] [RFC] Fix for conflict of HDMI and SPDIF IEC958 controls
by Raymond Yau 15 Oct '12

15 Oct '12

> > > > > > > > > > > > how about those hdmi jack and iec958 on ad1989b? > > > > > > > > > > On AD codecs, all digital outputs are exposed as a single cloned > > > > > device with HDA_PCM_TYPE_SPDIF. > > > > > > > > how about ad1988b with nvidia codec ? > > > > > > Nvidia codec provides devices only with HDA_PCM_TYPE_HDMI, of course. > > > > > > > from user point of view , how can they differenitate hdmi jack is > > digital > > > > ouput and hdmi output ? > > > > > > The device 1 is from AD and the device 3 is from Nvidia codec, as you > > > can see below. And this is exactly the case the conflict happens as I > > > mentioned in the original mail. > > > > will your fix change the spdif of those motherboard with ad1988b which > > have iec958 but no hdmi jack ? > > It won't change anything unless both SPDIF and HDMI *devices* are > actually created. > > > > > > Which is connected to what output, you can't know exactly unless you > > > compare the obtained ELD. The HD-audio spec isn't good enough to > > > identify the actual output. > > > > it seem that there is no presence detect on this codec > > ELD has nothing to do with the presence detect bit. > ftp://download.nvidia.com/XFree86/gpu-hdmi-audio-document/gpu-hdmi-audio.ht… 6.1.2. Chipset with 8-channel support, single stream This configuration is used in MCP77, MCP78, MCP79, MCP7A, and ION. In the case where multiple HDMI display connectors are present, the audio stream is broadcast to all HDMI connectors at once. A single ALSA device is exposed. ELD and PD information is not available on these chipsets. In these chipsets, the multiple 2-channel converters are aggregated by the ALSA driver and exposed as a single 8-channel device. Some chipsets support 2, or 8 channels (MCP77). Other chipsets support 2, 6, or 8 channels (MCP79). id = 0x10de0002, .name = "MCP77/78 HDMI", .patch = patch_nvhdmi_8ch_7x }, does it mean that this hdmi codec support 8 channels but no ELD info ? > > > Codec: Nvidia MCP77/78 HDMI > > Address: 3 > > AFG Function Id: 0x1 (unsol 0) > > Vendor Id: 0x10de0002 > > Subsystem Id: 0x10de0101 > > Revision Id: 0x100000 > > No Modem Function Group found > > Default PCM: > > rates [0x0]: > > bits [0x0]: > > formats [0x0]: > > Default Amp-In caps: N/A > > Default Amp-Out caps: N/A > > GPIO: io=0, o=0, i=0, unsolicited=0, wake=0 > > Node 0x04 [Audio Output] wcaps 0x211: Stereo Digital > > Control: name="IEC958 Playback Con Mask", index=1, device=0 > > Control: name="IEC958 Playback Pro Mask", index=1, device=0 > > Control: name="IEC958 Playback Default", index=1, device=0 > > Control: name="IEC958 Playback Switch", index=1, device=0 > > Device: name="HDMI 0", type="HDMI", device=3 > > Converter: stream=0, channel=0 > > Digital: > > Digital category: 0x0 > > PCM: > > rates [0xc0]: 48000 88200 > > bits [0xf]: 8 16 20 24 > > formats [0x1]: PCM > > Node 0x05 [Pin Complex] wcaps 0x400381: Stereo Digital > > Pincap 0x00000014: OUT Detect > > Pin Default 0x18560110: [Jack] Digital Out at Int HDMI > > Conn = Digital, Color = Unknown > > DefAssociation = 0x1, Sequence = 0x0 > > Misc = NO_PRESENCE > > Pin-ctls: 0x40: OUT > > Unsolicited: tag=00, enabled=0 > > Connection: 1 > > 0x04 > > > > > > > > > > > > https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/881826 > > > >

2 1

[alsa-devel] Invitation to connect on LinkedIn
by Hao Song via LinkedIn 15 Oct '12

15 Oct '12

LinkedIn ------------ Hao Song requested to add you as a connection on LinkedIn: ------------------------------------------ abdul, I'd like to add you to my professional network on LinkedIn. - Hao Accept invitation from Hao Song http://www.linkedin.com/e/jpxkk3-h8bk8zsc-2g/uii-rtptP1H4ViCg9YiBUOvto1r4_5… View profile of Hao Song http://www.linkedin.com/e/jpxkk3-h8bk8zsc-2g/rso/64047763/aTEQ/name/1380363… ------------------------------------------ You are receiving Invitation emails. This email was intended for abdul moiz. Learn why this is included: http://www.linkedin.com/e/jpxkk3-h8bk8zsc-2g/plh/http%3A%2F%2Fhelp%2Elinked… (c) 2012, LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA.

1 0

[alsa-devel] [asoc:topic/wm2200] sound/soc/codecs/wm2200.c:1033:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t'
by Yuanhan Liu 15 Oct '12

15 Oct '12

Hi Mark, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm2200 head: 9874482985fb26f90c3b2d8f1a82bd796d141304 commit: 6e87badd3f38e1a095d6e1b13828246c3e8486b5 ASoC: wm2200: Provide initial coefficient loading config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig All warnings: sound/soc/codecs/wm2200.c: In function 'wm2200_dsp_load': sound/soc/codecs/wm2200.c:1033:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat] sound/soc/codecs/wm2200.c:1145:5: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long unsigned int' [-Wformat] sound/soc/codecs/wm2200.c: In function 'wm2200_setup_algs': sound/soc/codecs/wm2200.c:1187:2: warning: format '%d' expects argument of type 'int', but argument 7 has type 'size_t' [-Wformat] sound/soc/codecs/wm2200.c:1207:5: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat] sound/soc/codecs/wm2200.c: In function 'wm2200_load_coeff': sound/soc/codecs/wm2200.c:1270:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat] sound/soc/codecs/wm2200.c:1334:5: warning: format '%d' expects argument of type 'int', but argument 5 has type 'long unsigned int' [-Wformat] vim +1033 sound/soc/codecs/wm2200.c e10f8711 Mark Brown 2012-10-04 1017 break; e10f8711 Mark Brown 2012-10-04 1018 default: e10f8711 Mark Brown 2012-10-04 1019 dev_err(codec->dev, "BASE %x\n", base); e10f8711 Mark Brown 2012-10-04 1020 BUG_ON(1); e10f8711 Mark Brown 2012-10-04 1021 return -EINVAL; e10f8711 Mark Brown 2012-10-04 1022 } e10f8711 Mark Brown 2012-10-04 1023 e10f8711 Mark Brown 2012-10-04 1024 ret = request_firmware(&firmware, file, codec->dev); e10f8711 Mark Brown 2012-10-04 1025 if (ret != 0) { e10f8711 Mark Brown 2012-10-04 1026 dev_err(codec->dev, "Failed to request '%s'\n", file); e10f8711 Mark Brown 2012-10-04 1027 return ret; e10f8711 Mark Brown 2012-10-04 1028 } e10f8711 Mark Brown 2012-10-04 1029 e10f8711 Mark Brown 2012-10-04 1030 pos = sizeof(*header) + sizeof(*adsp1_sizes) + sizeof(*footer); e10f8711 Mark Brown 2012-10-04 1031 if (pos >= firmware->size) { e10f8711 Mark Brown 2012-10-04 1032 dev_err(codec->dev, "%s: file too short, %d bytes\n", e10f8711 Mark Brown 2012-10-04 @1033 file, firmware->size); e10f8711 Mark Brown 2012-10-04 1034 return -EINVAL; e10f8711 Mark Brown 2012-10-04 1035 } e10f8711 Mark Brown 2012-10-04 1036 e10f8711 Mark Brown 2012-10-04 1037 header = (void*)&firmware->data[0]; e10f8711 Mark Brown 2012-10-04 1038 e10f8711 Mark Brown 2012-10-04 1039 if (memcmp(&header->magic[0], "WMFW", 4) != 0) { e10f8711 Mark Brown 2012-10-04 1040 dev_err(codec->dev, "%s: invalid magic\n", file); e10f8711 Mark Brown 2012-10-04 1041 return -EINVAL; --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation

1 0

[alsa-devel] snd_ctl_elem_list
by Paul 15 Oct '12

15 Oct '12

Newbie. Trying to discover information about the audio hardware. Specifically about a USB microphone ( Audio-Technia AT2020USB ) and whether it has a volume control. Writing in Ada just to be difficult. Not having any problems with that though. After doing a malloc and a snd_ctl_elem_list I can use ctl_elem_list_count to get the number of elements. This number is non-zero ( 2 for the AT2020, 34 for the on-board Intel audio chip ). Then I can use ctl_elem_to get the number of used. That number is zero and prevents me from trying to access the element list. How can I find out information about the elements in the list? How do these elements become used? Is this even the correct path to try to discover the volume control? Thanks, Paul I

1 0

Re: [alsa-devel] sound/pci/hda/hda_codec.c:1435:46: error: 'AC_VERB_GET_CON' undeclared
by Takashi Iwai 15 Oct '12

15 Oct '12

At Sat, 13 Oct 2012 01:01:09 +0800, Fengguang Wu wrote: > > Hi Takashi, > > FYI, kernel build failed on > > commit: 645cf3b5656e47fa9a46e2fbc8d212ab572ab05b Merge branch 'topic/3.8' > config: x86_64-allyesdebian (attached as .config) > > > All error/warnings: > > sound/pci/hda/hda_codec.c: In function 'update_pcm_stream_id': > sound/pci/hda/hda_codec.c:1435:46: error: 'AC_VERB_GET_CON' undeclared (first use in this function) > sound/pci/hda/hda_codec.c:1435:46: note: each undeclared identifier is reported only once for each function it appears in Thanks, this must be already fixed. It was a temporary merge error. (One shouldn't work during updating the system....) Takashi

3 4