October 2012 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 1/5] sound/isa/opti9xx/miro.c: eliminate possible double free
by Julia Lawall 21 Oct '12

21 Oct '12

From: Julia Lawall <Julia.Lawall(a)lip6.fr> snd_miro_probe is a static function that is only called twice in the file that defines it. At each call site, its argument is freed using snd_card_free. Thus, there is no need for snd_miro_probe to call snd_card_free on its argument on any of its error exit paths. Because snd_card_free both reads the fields of its argument and kfrees its argments, the results of the second snd_card_free should be unpredictable. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier f,free,a; parameter list[n] ps; type T; expression e; @@ f(ps,T a,...) { ... when any when != a = e if(...) { ... free(a); ... return ...; } ... when any } @@ identifier r.f,r.free; expression x,a; expression list[r.n] xs; @@ * x = f(xs,a,...); if (...) { ... free(a); ... return ...; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall(a)lip6.fr> --- Not tested. sound/isa/opti9xx/miro.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/isa/opti9xx/miro.c b/sound/isa/opti9xx/miro.c index 3d1afb6..4a7ff4e 100644 --- a/sound/isa/opti9xx/miro.c +++ b/sound/isa/opti9xx/miro.c @@ -1286,7 +1286,6 @@ static int __devinit snd_miro_probe(struct snd_card *card) error = snd_card_miro_aci_detect(card, miro); if (error < 0) { - snd_card_free(card); snd_printk(KERN_ERR "unable to detect aci chip\n"); return -ENODEV; }

2 1

[alsa-devel] [PATCH 1/1] Add USB audio quirk supporting Roland VG-99 advanced mode
by pete.leigh＠gmail.com 21 Oct '12

21 Oct '12

From: Pete Leigh <pete.leigh(a)gmail.com> Signed-off-by: Pete Leigh <pete.leigh(a)gmail.com> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 88d8ceb..ffeabf8 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, { + /* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1 + * kHz. In standard mode, the device has ID 0582:00b3, and offers + * 16-bit PCM at 44.1 kHz with no MIDI. + */ + USB_DEVICE(0x0582, 0x00b2), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Roland", + .product_name = "VG-99", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_MIDI_FIXED_ENDPOINT, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_cables = 0x0003, + .in_cables = 0x0003 + } + }, + { + .ifnum = -1 + } + } + } +}, +{ /* Roland SonicCell */ USB_DEVICE(0x0582, 0x00c2), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { -- 1.7.11.7

3 3

[alsa-devel] [PATCH 1/1] USB audio quirk for Roland VG-99 advanced mode
by pete.leigh＠gmail.com 21 Oct '12

21 Oct '12

From: Pete Leigh <pete.leigh(a)gmail.com> Without this quirk the VG-99 will work in standard mode (set under USB on System menu page 2) giving 16 bits at 44.1 Khz audio in/out but no midi, and is not recognised when set to advanced mode. After applying this, I can also use the VG-99 in advanced mode: 24 24 bits audio in/out at 44.1 Khz, and midi in/out. Sysex is so far untested. In standard mode, the device appears with ID 0x00b3, so the behaviour isn't affected by this quirk. Thanks to Clemens Ladisch for simplifying and correcting my initial attempt! Signed-off-by: Pete Leigh <pete.leigh(a)gmail.com> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 88d8ceb..ffeabf8 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, { + /* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1 + * kHz. In standard mode, the device has ID 0582:00b3, and offers + * 16-bit PCM at 44.1 kHz with no MIDI. + */ + USB_DEVICE(0x0582, 0x00b2), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Roland", + .product_name = "VG-99", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_MIDI_FIXED_ENDPOINT, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_cables = 0x0003, + .in_cables = 0x0003 + } + }, + { + .ifnum = -1 + } + } + } +}, +{ /* Roland SonicCell */ USB_DEVICE(0x0582, 0x00c2), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { -- 1.7.11.7

1 0

[alsa-devel] [PATCH - my module 1/1] USB audio quirk for Roland VG-99 advanced mode
by pete.leigh＠gmail.com 21 Oct '12

21 Oct '12

From: Pete Leigh <pete.leigh(a)gmail.com> Without this quirk the VG-99 will work in standard mode (set under USB on System menu page 2) giving 16 bits at 44.1 Khz audio in/out but no midi, and is not recognised when set to advanced mode. After applying this, I can also use the VG-99 in advanced mode: 24 24 bits audio in/out at 44.1 Khz, and midi in/out. Sysex is so far untested. In standard mode, the device appears with ID 0x00b3, so the behaviour isn't affected by this quirk. Thanks to Clemens Ladisch for simplifying and correcting my initial attempt! Signed-off-by: Pete Leigh <pete.leigh(a)gmail.com> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 88d8ceb..ffeabf8 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, { + /* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1 + * kHz. In standard mode, the device has ID 0582:00b3, and offers + * 16-bit PCM at 44.1 kHz with no MIDI. + */ + USB_DEVICE(0x0582, 0x00b2), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Roland", + .product_name = "VG-99", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_MIDI_FIXED_ENDPOINT, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_cables = 0x0003, + .in_cables = 0x0003 + } + }, + { + .ifnum = -1 + } + } + } +}, +{ /* Roland SonicCell */ USB_DEVICE(0x0582, 0x00c2), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { -- 1.7.11.7

2 1

[alsa-devel] [PATCH] ALSA: aloop - do not reschedule timer if deleted
by Omair Mohammed Abdullah 21 Oct '12

21 Oct '12

If the timer is deleted while the timer handler is running, it may get rescheduled and an unnecessary period elapsed will be sent. Add a flag to reschedule the timer only if it has not been stopped. Signed-off-by: Omair Mohammed Abdullah <omair.m.abdullah(a)linux.intel.com> Signed-off-by: Vinod Koul <vinod.koul(a)linux.intel.com> --- sound/drivers/aloop.c | 21 ++++++++++++++++++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c index 0fe6d64..fec4e17 100644 --- a/sound/drivers/aloop.c +++ b/sound/drivers/aloop.c @@ -121,6 +121,7 @@ struct loopback_pcm { unsigned long last_jiffies; struct timer_list timer; spinlock_t timer_lock; + bool timer_stopped; }; static struct platform_device *devices[SNDRV_CARDS]; @@ -166,12 +167,11 @@ static inline unsigned int get_rate_shift(struct loopback_pcm *dpcm) return get_setup(dpcm)->rate_shift; } -static void loopback_timer_start(struct loopback_pcm *dpcm) +static void do_timer_start(struct loopback_pcm *dpcm) { unsigned long tick; unsigned int rate_shift = get_rate_shift(dpcm); - spin_lock(&dpcm->timer_lock); if (rate_shift != dpcm->pcm_rate_shift) { dpcm->pcm_rate_shift = rate_shift; dpcm->period_size_frac = frac_pos(dpcm, dpcm->pcm_period_size); @@ -184,6 +184,13 @@ static void loopback_timer_start(struct loopback_pcm *dpcm) tick = (tick + dpcm->pcm_bps - 1) / dpcm->pcm_bps; dpcm->timer.expires = jiffies + tick; add_timer(&dpcm->timer); +} + +static inline void loopback_timer_start(struct loopback_pcm *dpcm) +{ + spin_lock(&dpcm->timer_lock); + dpcm->timer_stopped = false; + do_timer_start(dpcm); spin_unlock(&dpcm->timer_lock); } @@ -192,6 +199,7 @@ static inline void loopback_timer_stop(struct loopback_pcm *dpcm) spin_lock(&dpcm->timer_lock); del_timer(&dpcm->timer); dpcm->timer.expires = 0; + dpcm->timer_stopped = true; spin_unlock(&dpcm->timer_lock); } @@ -540,7 +548,13 @@ static void loopback_timer_function(unsigned long data) running = loopback_pos_update(dpcm->cable); if (running & (1 << dpcm->substream->stream)) { - loopback_timer_start(dpcm); + spin_lock(&dpcm->timer_lock); + if (dpcm->timer_stopped) { + spin_unlock(&dpcm->timer_lock); + return; + } + do_timer_start(dpcm); + spin_unlock(&dpcm->timer_lock); if (dpcm->period_update_pending) { dpcm->period_update_pending = 0; snd_pcm_period_elapsed(dpcm->substream); @@ -670,6 +684,7 @@ static int loopback_open(struct snd_pcm_substream *substream) } dpcm->loopback = loopback; dpcm->substream = substream; + dpcm->timer_stopped = true; setup_timer(&dpcm->timer, loopback_timer_function, (unsigned long)dpcm); spin_lock_init(&dpcm->timer_lock); -- 1.7.4.1

2 3

[alsa-devel] [PATCH] ALSA: snd-usb: remove unused variable in init_pitch_v2()
by Wei Yongjun 21 Oct '12

21 Oct '12

From: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> The variable ep is initialized but never used otherwise, so remove the unused variable. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun <yongjun_wei(a)trendmicro.com.cn> --- sound/usb/pcm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index 55e19e1..f77b87a 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -171,11 +171,8 @@ static int init_pitch_v2(struct snd_usb_audio *chip, int iface, { struct usb_device *dev = chip->dev; unsigned char data[1]; - unsigned int ep; int err; - ep = get_endpoint(alts, 0)->bEndpointAddress; - data[0] = 1; if ((err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), UAC2_CS_CUR, USB_TYPE_CLASS | USB_RECIP_ENDPOINT | USB_DIR_OUT,

2 1

[alsa-devel] calling snd_ctl_notify from mixer ctl_put
by Ondrej Zary 21 Oct '12

21 Oct '12

Hello, I want to enable/disable some mixer controls based on state of another control (switching between limiter and AGC mode). So I (re)set the SNDRV_CTL_ELEM_ACCESS_INACTIVE flag in kctl->vd[0].access and then call snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_INFO, &kctl->id); Everyting from ctl_put() mixer callback. When changing the control value in alsamixer, it crashes with: alsamixer: simple.c:948: snd_mixer_selem_get_enum_item: Assertion `(elem)->type == SND_MIXER_ELEM_SIMPLE' failed. When the snd_ctl_notify() call is commented-out, it does not crash. There is snd_ctl_activate_id() function in sound/core/control.c (not used by any driver, btw.) which does the same, protected by card->controls_rwsem. However, it locks up on that semaphore when called from the mixer callback. Oxygen/Xonar WM8776 driver is doing the same thing - I wonder if I'm doing something wrong or if that driver crashes alsamixer too? Is there any way to do this properly? -- Ondrej Zary

3 3

Re: [alsa-devel] usb-audio: Reloop Play support (TI TUSB3200AC)
by Daniel Mack 20 Oct '12

20 Oct '12

On 20.10.2012 16:24, Didier Villevalois wrote: > OK this quirk works perfectly! (hooray!!!) > > /* Reloop Play */ > { > USB_DEVICE(0x200c, 0x100b), > .bInterfaceClass = USB_CLASS_PER_INTERFACE, > .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { > .vendor_name = "Reloop", > .product_name = "Play", > .ifnum = QUIRK_ANY_INTERFACE, > .type = QUIRK_COMPOSITE, > .data = &(const struct snd_usb_audio_quirk[]) { > { > .ifnum = 0, > .type = QUIRK_AUDIO_STANDARD_MIXER, > }, > { > .ifnum = 1, > .type = QUIRK_AUDIO_FIXED_ENDPOINT, > .data = &(const struct audioformat) { > .formats = SNDRV_PCM_FMTBIT_S24_3LE, > .channels = 4, > .iface = 1, > .altsetting = 1, > .altset_idx = 1, > .attributes = UAC_EP_CS_ATTR_SAMPLE_RATE, > .endpoint = 0x01, > .rates = SNDRV_PCM_RATE_44100 | > SNDRV_PCM_RATE_48000, > .rate_min = 44100, > .rate_max = 48000, > .nr_rates = 2, > .rate_table = (unsigned int[]) { > 44100, 48000 > } > } > }, > { > .ifnum = -1 > } > } > } > }, > > Does anyone have additional comments to do before I make a patch ? Let's ask Clemens - the quirks master - for comments :) > Also are there some special ALSA rules or straight signed-off > git-formated patches over the kernel tree are OK ? That's ok. The patch should apply on top of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git though. > Thanks again for your help! I'm really happy to have a working > device! :D Good work! I just really wonder what that updated firmware is all about ... Daniel

1 0

[alsa-devel] [PATCH 0/9] Fixes for RME MADI cards
by Adrian Knoth 20 Oct '12

20 Oct '12

Hi! I've spent another afternoon at IOSONO to fix a series of bugs in the hdspm driver. Andre Schramm and me have tested almost all patches on a box with two PCIe MADI cards and one PCI MADI card. The DDS/Varispeed patch has only been tested on my RayDAT, the sync_in detection for AES32 has not been tested at all, though the documentation is pretty clear that the previous bit position was wrong. If there are AES(32) owners with two or more cards out there, please test and report back. The typo and the coding style patches have not been tested, since they're trivial. Cheers Adrian Knoth (9): ALSA: hdspm - Allow DDS/Varispeed to be set from userspace ALSA: hdspm - Report external rate in slave mode on PCI MADI ALSA: hdspm - Fix sync check reporting on all RME HDSPM cards ALSA: hdspm - Fix reported autosync_sample_rate ALSA: hdspm - Also report autosync_sample_rate on MADI and MADIface ALSA: hdspm - Fix sync_in reporting on RME MADI cards ALSA: hdspm - Fix sync_in detection on AES/AES32 ALSA: hdspm - Fix typo in kcontrol element on RME MADI cards ALSA: hdspm - Fix coding style in CTL_ELEM macros sound/pci/rme9652/hdspm.c | 232 ++++++++++++++++++++++++++------------------- 1 file changed, 137 insertions(+), 95 deletions(-) -- 1.7.10.4

2 13

[alsa-devel] Fwd: Support for Roland VG-99 (working code, but could use help)
by Pete Leigh 20 Oct '12

20 Oct '12

Hi, I tried posting this a couple of days ago, but no response... I'm wondering if the (text) attachment stopped people from seeing it, or if there's something else I missed? It's just a request to look over the lsusb output and new quirks-table entry included, with a view to getting this added to a release. Since the initial post, I've done more testing (I'm using a kernel based on 3.4.11-1.rt19.1.fc17.ccrma.x86_64.rt) and everything seems to work fine (including midi in, which I wasn't sure of at the time of posting) apart from one apparently cosmetic issue - the device name no longer shows up in lsusb output, though it did before applying the quirk. (?) I'll include the quirk entry as text rather than an attachment this time. If I actually need to go through the process of generating a patch and sending mail via git, as per the developer page on the alsa-project site, could someone let me know, and I'll give it a go (it's something I was hoping to avoid, I admit!) Thanks, - Pete. ---------- Forwarded message ---------- The VG-99 is a guitar processor with a usb interface which offers 2x16bit 44100 pcm in and out streams in its basic usb mode, and 2x24bit 44100 in/out + midi in the advanced mode connection mode. Basic mode works fine with usb snd driver, but the device isn't recognised when set to advanced mode (this is done under USB on page 2 of the "system" config menu) I've used the lsusb -v output (below) to guess at an addition to sound/usb/quirks-table.h to try and get this working. On initial (brief) testing, audio in/out at 24bits (as shown by jackd output) and midi (out, at least) are all working. I'll attach the quirk, and would be pleased if someone could look at it, and the lsusb output, and fix up any deficiencies (it's purely voodoo here :-D) and maybe get it or something like it into the official source... please let me know if changes need to be tested. Cheers, - Pete. Here's the lsusb output: Bus 001 Device 007: ID 0582:00b2 Roland Corp. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 1.10 bDeviceClass 255 Vendor Specific Class bDeviceSubClass 0 bDeviceProtocol 255 bMaxPacketSize0 8 idVendor 0x0582 Roland Corp. idProduct 0x00b2 bcdDevice 1.00 iManufacturer 1 Roland iProduct 2 VG-99 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 167 bNumInterfaces 3 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xc0 Self Powered MaxPower 2mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 06 24 f1 01 00 00 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 2 iInterface 0 ** UNRECOGNIZED: 07 24 01 01 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 03 18 01 44 ac 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x01 EP 1 OUT bmAttributes 9 Transfer Type Isochronous Synch Type Adaptive Usage Type Data wMaxPacketSize 0x0120 1x 288 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 0 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 1 bNumEndpoints 1 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 2 bInterfaceProtocol 1 iInterface 0 ** UNRECOGNIZED: 07 24 01 07 00 01 00 ** UNRECOGNIZED: 0b 24 02 01 02 03 18 01 44 ac 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x82 EP 2 IN bmAttributes 5 Transfer Type Isochronous Synch Type Asynchronous Usage Type Data wMaxPacketSize 0x0120 1x 288 bytes bInterval 1 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 06 24 f1 02 02 02 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0020 1x 32 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0020 1x 32 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 1 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 3 bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0020 1x 32 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0020 1x 32 bytes bInterval 1 Device Status: 0x0001 Self Powered ------------------------------------ And the quirk entry: { USB_DEVICE(0x0582, 0x00b2), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { .vendor_name = "Roland", .product_name = "VG-99", .ifnum = QUIRK_ANY_INTERFACE, .type = QUIRK_COMPOSITE, .data = (const struct snd_usb_audio_quirk[]) { { .ifnum = 0, .type = QUIRK_AUDIO_FIXED_ENDPOINT, .data = & (const struct audioformat) { .formats = SNDRV_PCM_FMTBIT_S24_3LE, .channels = 2, .iface = 0, .altsetting = 1, .altset_idx = 1, .attributes = 0, .endpoint = 0x01, .ep_attr = 0x09, .rates = SNDRV_PCM_RATE_CONTINUOUS, .rate_min = 44100, .rate_max = 44100, } }, { .ifnum = 1, .type = QUIRK_AUDIO_FIXED_ENDPOINT, .data = & (const struct audioformat) { .formats = SNDRV_PCM_FMTBIT_S24_3LE, .channels = 2, .iface = 1, .altsetting = 1, .altset_idx = 1, .attributes = UAC_EP_CS_ATTR_FILL_MAX, .endpoint = 0x82, .ep_attr = 0x05, .rates = SNDRV_PCM_RATE_CONTINUOUS, .rate_min = 44100, .rate_max = 44100, } }, { .ifnum = 2, .type = QUIRK_MIDI_FIXED_ENDPOINT, .data = & (const struct snd_usb_midi_endpoint_info) { .out_cables = 0x0007, .in_cables = 0x0007 } }, { .ifnum = -1 } } } },

3 18