January 2012 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Print revision number in hex
by Mark Brown 18 Jan '12

18 Jan '12

On Mon, Jan 16, 2012 at 05:32:21PM -0200, Fabio Estevam wrote: > Throughout the sgtl5000 driver source code and also in the sgtl5000 datasheet > the revision code is shown in hexadecimal. > > Print it hex format, for consistency. Applied, thanks.

1 0

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix wrong register name in restore
by Mark Brown 18 Jan '12

18 Jan '12

On Wed, Jan 18, 2012 at 01:58:07PM +0800, zengzm.kernel(a)gmail.com wrote: > From: Zeng Zhaoming <zengzm.kernel(a)gmail.com> > > Correct SGTL5000_CHIP_CLK_CTRL to SGTL5000_CHIP_REF_CTRL in > sgtl5000_restore_regs(), and add comment to explain the > restore order. Applied, thanks.

1 0

[alsa-devel] [PATCH v3 0/7] ASoC: Add support in core to set msbits constraint
by Peter Ujfalusi 18 Jan '12

18 Jan '12

Hi Mark, Changes from v2: - initialize ret to zero in soc_pcm_apply_msb I would prefer to have the msbits constraints to be applied to only sample sizes bigger than the requested msbits from dais. I'm resending your patch plus the modification which will make the possible. I have also converted the drivers I know have this constraint. If you prefer, you can squash the first two patch. Regards, Peter --- Mark Brown (2): ASoC: Allow drivers to specify how many bits are significant on a DAI ASoC: 24 bits are significant on the WM8996 audio interfaces Peter Ujfalusi (5): ASoC: Apply msbits constraint for sample size bigger than the msbits ASoC: omap-dmic: Use core to set the msbits constraint ASoC: omap-mcpdm: Set 24msbits constraint ASoC: tlv320dac33: Use core to set the msbits constraint ASoC: twl4030: Use core to set the msbits constraint include/sound/soc.h | 1 + sound/soc/codecs/tlv320dac33.c | 3 +-- sound/soc/codecs/twl4030.c | 7 ++++--- sound/soc/codecs/wm8996.c | 4 ++++ sound/soc/omap/omap-dmic.c | 7 +++---- sound/soc/omap/omap-mcpdm.c | 2 ++ sound/soc/soc-pcm.c | 39 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 54 insertions(+), 9 deletions(-) -- 1.7.8.3

2 8

[alsa-devel] [PATCH v2 0/7] ASoC: Add support in core to set msbits constraint
by Peter Ujfalusi 18 Jan '12

18 Jan '12

Hi Mark, I would prefer to have the msbits constraints to be applied to only sample sizes bigger than the requested msbits from dais. I'm resending your patch plus the modification which will make the possible. I have also converted the drivers I know have this constraint. If you prefer, you can squash the first two patch. Regards, Peter --- Mark Brown (2): ASoC: Allow drivers to specify how many bits are significant on a DAI ASoC: 24 bits are significant on the WM8996 audio interfaces Peter Ujfalusi (5): ASoC: Apply msbits constraint for sample size bigger than the msbits ASoC: omap-dmic: Use core to set the msbits constraint ASoC: omap-mcpdm: Set 24msbits constraint ASoC: tlv320dac33: Use core to set the msbits constraint ASoC: twl4030: Use core to set the msbits constraint include/sound/soc.h | 1 + sound/soc/codecs/tlv320dac33.c | 3 +-- sound/soc/codecs/twl4030.c | 7 ++++--- sound/soc/codecs/wm8996.c | 4 ++++ sound/soc/omap/omap-dmic.c | 7 +++---- sound/soc/omap/omap-mcpdm.c | 2 ++ sound/soc/soc-pcm.c | 38 ++++++++++++++++++++++++++++++++++++++ 7 files changed, 53 insertions(+), 9 deletions(-) -- 1.7.8.3

2 8

[alsa-devel] [PATCH 0/7] extract a simple dmaengine library from shdma.c
by Guennadi Liakhovetski 18 Jan '12

18 Jan '12

This patch series has been triggered by a recent series by Shimoda-san http://www.spinics.net/lists/linux-sh/index.html#09895 In a follow up to that thread it has been decided to extract a common library from the current shdma driver to be re-used by other dmaengine drivers. Primarily this library provides a flexible transfer descriptor management for hardware, that does not dupport scatter-gather lists natively. In such cases this library can be used to split transfer requests into smaller chunks, up to the size, supported by the specific hardware, enter them onto a linked list, thack their completion and call user callbacks. This is a first shot, aimed to be used by the SUDMAC driver. Once it is confirmed, that this version can be conveniently used with it, I'll do some cosmetic clean up, notably, add / improve documentation:-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/

1 1

Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix wrong register name in restore
by Dong Aisheng-B29396 18 Jan '12

18 Jan '12

> -----Original Message----- > From: zengzm.kernel(a)gmail.com [mailto:zengzm.kernel@gmail.com] > Sent: Wednesday, January 18, 2012 1:58 PM > To: alsa-devel(a)alsa-project.org > Cc: Dong Aisheng-B29396; broonie(a)opensource.wolfsonmicro.com; > julia.lawall(a)lip6.fr; festevam(a)gmail.com; w.sang(a)pengutronix.de; > shawn.guo(a)linaro.org; lrg(a)ti.com; zengzm.kernel(a)gmail.com > Subject: [PATCH v2] ASoC: sgtl5000: Fix wrong register name in restore > Importance: High > > From: Zeng Zhaoming <zengzm.kernel(a)gmail.com> > > Correct SGTL5000_CHIP_CLK_CTRL to SGTL5000_CHIP_REF_CTRL in > sgtl5000_restore_regs(), and add comment to explain the restore order. > > Reported-by: Julia Lawall <julia.lawall(a)lip6.fr> > Signed-off-by: Zeng Zhaoming <zengzm.kernel(a)gmail.com> > --- > sound/soc/codecs/sgtl5000.c | 17 +++++++++++++---- > 1 files changed, 13 insertions(+), 4 deletions(-) > Acked-by: Dong Aisheng <dong.aisheng(a)linaro.org> Regards Dong Aisheng

1 0

[alsa-devel] Hardware-specific IOCTLs
by Ivan Bublikov 17 Jan '12

17 Jan '12

Message body Hello All, My question is about how to allocate a new hardware-specific IOCTL code. For example, the HDA driver consists of common HDA code and vendor-specific codes for various HDA codecs. As an HDA codec vendor, I want to be able to control some functionality in my codec, that is not present in codecs from other vendors. For this, I want to implement a special IOCTL in my vendor-specific code. I understand that I can register an IOCTL handler using snd_ctl_register_ioctl. My difficulty is how to define a code for my IOCTL and avoid a conflict with the common code in the future. Looking at header files, I see common "ALSA" audio IOCTLs starting with letter 'A', and "HWDEP" IOCTLs starting with letter 'H'. Some of H-IOCTLs are defined in asound.h, starting at offset 0, and some in hda_hwdep.h and sb16_csp.h starting at offset 0x10. My guess is that the latter start at 0x10 to give some expansion room for H-IOCTLs in asound.h...? I think I need some offset range in H-IOCTLs or a new IOCTL family with another letter, officially reserved for such codec-specific IOCTLs. Any suggestions? Best regards, Ivan

2 3

[alsa-devel] ASoC updates for 3.3
by Mark Brown 17 Jan '12

17 Jan '12

The following changes since commit 29abceb67f8a230da806db4ed73899595bd2ae76: Merge branch 'for-3.3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into topic/asoc (2012-01-12 09:48:20 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.3 All small, easily reviewed fixes. Javier Martin (1): ASoC: Fix DMA channel leak in imx-pcm-dma-mx2 driver. Liam Girdwood (2): ASoC: dapm - Fix check for codec context in dapm_power_widgets(). ASoC: core - Free platform DAPM context at platform removal. Mark Brown (1): ASoC: Wait for WM8993 FLL to stabilise Zeng Zhaoming (1): ASoC: sgtl5000: update author email address sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/wm8993.c | 6 ++++++ sound/soc/imx/imx-pcm-dma-mx2.c | 12 +++++++----- sound/soc/soc-core.c | 4 ++++ sound/soc/soc-dapm.c | 2 +- 5 files changed, 19 insertions(+), 7 deletions(-)

2 1

[alsa-devel] [PATCH] ASoC: Say we can't read WM5100 ID register
by Mark Brown 17 Jan '12

17 Jan '12

Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm5100.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 0e38a24..fca7f0a 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2839,7 +2839,7 @@ static __devinit int wm5100_i2c_probe(struct i2c_client *i2c, ret = regmap_read(wm5100->regmap, WM5100_SOFTWARE_RESET, &reg); if (ret < 0) { - dev_err(&i2c->dev, "Failed to read ID register\n"); + dev_err(&i2c->dev, "Failed to read ID register: %d\n", ret); goto err_reset; } switch (reg) { -- 1.7.7.3

1 0

[alsa-devel] [PATCH] ASoC: When releasing WM5100 put /RESET into reset
by Mark Brown 17 Jan '12

17 Jan '12

Reset is active low, make sure we leave it asserted when release the device. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm5100.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 9995d14..0e38a24 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2901,7 +2901,7 @@ static __devinit int wm5100_i2c_probe(struct i2c_client *i2c, err_reset: wm5100_free_gpio(i2c); if (wm5100->pdata.reset) { - gpio_set_value_cansleep(wm5100->pdata.reset, 1); + gpio_set_value_cansleep(wm5100->pdata.reset, 0); gpio_free(wm5100->pdata.reset); } err_ldo: @@ -2934,7 +2934,7 @@ static __devexit int wm5100_i2c_remove(struct i2c_client *client) snd_soc_unregister_codec(&client->dev); wm5100_free_gpio(client); if (wm5100->pdata.reset) { - gpio_set_value_cansleep(wm5100->pdata.reset, 1); + gpio_set_value_cansleep(wm5100->pdata.reset, 0); gpio_free(wm5100->pdata.reset); } if (wm5100->pdata.ldo_ena) { -- 1.7.7.3

1 0