March 2011 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] sound/core: merge list_del()/list_add_tail() to list_move_tail()
by Nicolas Kaiser 16 Mar '11

16 Mar '11

Merge list_del() + list_add_tail() to list_move_tail(). Signed-off-by: Nicolas Kaiser <nikai(a)nikai.net> --- sound/core/timer.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index ed01632..7c1cbf0 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -186,9 +186,8 @@ static void snd_timer_check_slave(struct snd_timer_instance *slave) list_for_each_entry(master, &timer->open_list_head, open_list) { if (slave->slave_class == master->slave_class && slave->slave_id == master->slave_id) { - list_del(&slave->open_list); - list_add_tail(&slave->open_list, - &master->slave_list_head); + list_move_tail(&slave->open_list, + &master->slave_list_head); spin_lock_irq(&slave_active_lock); slave->master = master; slave->timer = master->timer; @@ -414,8 +413,7 @@ static void snd_timer_notify1(struct snd_timer_instance *ti, int event) static int snd_timer_start1(struct snd_timer *timer, struct snd_timer_instance *timeri, unsigned long sticks) { - list_del(&timeri->active_list); - list_add_tail(&timeri->active_list, &timer->active_list_head); + list_move_tail(&timeri->active_list, &timer->active_list_head); if (timer->running) { if (timer->hw.flags & SNDRV_TIMER_HW_SLAVE) goto __start_now; -- 1.7.3.4

1 0

[alsa-devel] [PATCH] ASoC: Add National Semiconductor LM49352 Audio Codec support
by Reddy, MR Swami 16 Mar '11

16 Mar '11

Hello, Patch for adding National Semiconductor LM49352 Audio Codec (http://www.national.com/ds/LM/LM49352.pdf) support along with Samsung_6410 (i.e. SMDK6410) platform support for LM49352. [Tested this patch on SMDK6410 platform with Kernel- 2.6.24 and ALSA version is - 1.0.15]. Please review and let me know the comments/suggestion on this patch. And also let me know the forward-porting (to the latest ALSA version APIs) steps/process. Thanks in advance. Thanks Swami

2 6

[alsa-devel] aseqnet ipv6 and embedded clients
by errordeveloper＠gmail.com 16 Mar '11

16 Mar '11

Hi, I am looking at implementing wireless MIDI network using Contiki OS. I would run it on relativelly powerfull microcontroller (Freescale MC13224). I looked at sourcode of aseqnet command and it does look fairly small. Contiki has uIP 6loWPAN for networking and it connects to linux using SLIP-like 'tun' virtual userspace interface. I wonder if there could be any potential issues in terms of IPv6 compatibility, would aseqnet on Linux work with IPv6 or I will certainly need a tunnel ? Would be greate to hear _ANY_ concerns, of course I do imagine there will be a latency (hopefully not too huge) and I hope to work on this further. I also though of MIDI RTP, but that seems quite a bit bigger thing .. Could anyone give a little insight on what aseqnet really does? I would imagine it is quite plain, am I wrong ? Well, I could perhaps implement some very simplistic netcat/telnet kind of data dumping, but would be greate to get working smothly end- to-end, i.e. all the way from my wireless node (which will have a MIDI din5 connector) to an app on Linux, even amidi --dump ..hm Also would be greate to get some idea how clocking works w/ aseqnet. Cheers, -- Ilya

1 0

[alsa-devel] Wrong email in author-tag.
by Peter Rosin 16 Mar '11

16 Mar '11

Hi Takashi, This is not really important to /me/, on /this/ occation. But I thought I'd ask anyway as it seems strange that the author tag ended up wrong. If it is a symptom of more errors, others may care more. Personally I'm mainly wondering how it could happen, and would like for it to not happen again (especially if I ever send more substantial patches). The commit e2e9566230 ALSA: AT73C213: Rectify misleading comment. was first sent as a git patch [1] and then again amended with a pair of other (seemingly) trivial comment fixes [2] (the amended fixes were not commited for some reason). Both patches were sent from my axentia account and both carried signed-off-by tags using the axentia account. Yet the commit is made naming my lysator account as author (the sign-off is still intact). The patch that seems to have ended up being commited is [1], and what I think has happened is that I used the lysator account in the discussion following the 2nd patch, but I fail to understand how the sender of that one message (or was it a few?) could "leak" into the author tag. I'm assuming it was just a silly mistake, I'm mearly pointing out the mishap and understand that there is little one can do to fix this buglet this late. Cheers, Peter [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2010-November/033550.h… [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2010-November/033645.h…

2 1

[alsa-devel] [GIT PULL] Updates for 2.6.39
by Liam Girdwood 16 Mar '11

16 Mar '11

These should be the last updates for 2.6.39. Thanks Liam --- The following changes since commit 273de37655369e57919f19e157fafb2b4b1e4472: Merge branch 'for-2.6.39' of git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6 into for-2.6.39 (2011-02-01 14:55:10 +0000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lrg/asoc-2.6.git for-2.6.39 Jarkko Nikula (5): ASoC: omap: rx51: Use gpio_request_one to configure tvout_sel gpio ASoC: omap: rx51: Add headset support ASoC: omap: rx51: Report headset insertion instead of video out cable ASoC: omap: rx51: Add FM transmitter support ASoC: omap: rx51: Enable McBSP2 sidetone sound/soc/omap/rx51.c | 42 ++++++++++++++++++++++++++++++++++++------ 1 files changed, 36 insertions(+), 6 deletions(-)

2 1

[alsa-devel] [PATCH 1/2 v3] ALSA: Add snd_ctl_update() to dynamically update a control
by Dimitris Papastamos 16 Mar '11

16 Mar '11

Add a function to dynamically update a given control. If the control does not already exist, a third parameter is used to determine whether to actually add that control. This is useful in cases where downloadable firmware at runtime can add or update existing controls. A separate patch needs to be made to allow ALSA Mixer to update the controls dynamically. Signed-off-by: Dimitris Papastamos <dp(a)opensource.wolfsonmicro.com> --- Hi, Any potentially locking related issues have been fixed now. Any comments on whether it would be advisable to use the same `numid' when I update an existing control? Thanks, Dimitris include/sound/control.h | 1 + sound/core/control.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 0 deletions(-) diff --git a/include/sound/control.h b/include/sound/control.h index e67db28..2a2fd82 100644 --- a/include/sound/control.h +++ b/include/sound/control.h @@ -113,6 +113,7 @@ struct snd_kcontrol *snd_ctl_new1(const struct snd_kcontrol_new * kcontrolnew, v void snd_ctl_free_one(struct snd_kcontrol * kcontrol); int snd_ctl_add(struct snd_card * card, struct snd_kcontrol * kcontrol); int snd_ctl_remove(struct snd_card * card, struct snd_kcontrol * kcontrol); +int snd_ctl_update(struct snd_card * card, struct snd_kcontrol * kcontrol, bool add_on_update); int snd_ctl_remove_id(struct snd_card * card, struct snd_ctl_elem_id *id); int snd_ctl_rename_id(struct snd_card * card, struct snd_ctl_elem_id *src_id, struct snd_ctl_elem_id *dst_id); int snd_ctl_activate_id(struct snd_card *card, struct snd_ctl_elem_id *id, diff --git a/sound/core/control.c b/sound/core/control.c index db51e4e..1d2b524 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -368,6 +368,71 @@ int snd_ctl_add(struct snd_card *card, struct snd_kcontrol *kcontrol) EXPORT_SYMBOL(snd_ctl_add); /** + * snd_ctl_update - update the control instance of the card + * @card: the card instance + * @kcontrol: the control instance to update + * @add_on_update: add the control if not already added + * + * Updates the given control. If the given control does not exist + * and the add_on_update flag is set, the control is added. If the + * control exists, it is destroyed first. + * + * Returns zero if successful, or a negative error code on failure. + * + * It frees automatically the control which cannot be added or updated. + */ +int snd_ctl_update(struct snd_card *card, struct snd_kcontrol *kcontrol, + bool add_on_update) +{ + struct snd_ctl_elem_id id; + unsigned int idx; + struct snd_kcontrol *old; + int ret; + + if (!kcontrol) + return -EINVAL; + if (snd_BUG_ON(!card || !kcontrol->info)) { + ret = -EINVAL; + goto error; + } + id = kcontrol->id; + down_write(&card->controls_rwsem); + old = snd_ctl_find_id(card, &id); + if (!old) { + if (add_on_update) + goto add; + up_write(&card->controls_rwsem); + ret = -EINVAL; + goto error; + } + ret = snd_ctl_remove(card, old); + if (ret < 0) { + up_write(&card->controls_rwsem); + goto error; + } +add: + if (snd_ctl_find_hole(card, kcontrol->count) < 0) { + up_write(&card->controls_rwsem); + ret = -ENOMEM; + goto error; + } + list_add_tail(&kcontrol->list, &card->controls); + card->controls_count += kcontrol->count; + kcontrol->id.numid = card->last_numid + 1; + card->last_numid += kcontrol->count; + up_write(&card->controls_rwsem); + for (idx = 0; idx < kcontrol->count; idx++, id.index++, id.numid++) + snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_ADD, &id); + return 0; + +error: + snd_ctl_free_one(kcontrol); + return ret; +} + +EXPORT_SYMBOL(snd_ctl_update); + +/** * snd_ctl_remove - remove the control from the card and release it * @card: the card instance * @kcontrol: the control instance to remove -- 1.7.4.1

2 2

[alsa-devel] [PATCH] ALSA: HDA: Correct address for SSYNC register
by David Henningsson 16 Mar '11

16 Mar '11

Here's something I stumbled upon, while debugging something probably unrelated. I don't exactly know the implications of failing multiple stream synchronisation (is that something we commonly use?), or the implications of writing to a register that is "Reserved" in the HDA Spec (can there be crazy vendor magic in there we're unwillingly messing with?). Perhaps someone else knows more and can tell if this is something that is actually important. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic

2 1

[alsa-devel] RFC: ST specific ASoC sound driver
by rajeev 16 Mar '11

16 Mar '11

Hi, I have developed a ASoC sound driver for a ST specific platform (SPEAr). This module actually uses the Designware (Synopsys) "dw_apb_i2s_db" IP + some ST specific glue logic on top of it. Now I am confused as to whether I should submit a single patch for the SPEAr ASoC driver or should I try to break the driver such that the Designware and glue logic parts are handled separately (which given the current shape of design seems improbable) Any pointers on the same will be highly appreciated. Best Regards Rajeev

2 1

[PATCH] ALSA: HDA: Correct address for SYNC register
by David Henningsson 16 Mar '11

16 Mar '11

The SSYNC register is located at address 0x38 according to the HDA specification. Cc: stable(a)kernel.org Signed-off-by: David Henningsson <david.henningsson(a)canonical.com> --- sound/pci/hda/hda_intel.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 70a9d32..ab3f654 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -176,7 +176,7 @@ MODULE_DESCRIPTION("Intel HDA driver"); #define ICH6_REG_INTCTL 0x20 #define ICH6_REG_INTSTS 0x24 #define ICH6_REG_WALLCLK 0x30 /* 24Mhz source */ -#define ICH6_REG_SYNC 0x34 +#define ICH6_REG_SYNC 0x38 #define ICH6_REG_CORBLBASE 0x40 #define ICH6_REG_CORBUBASE 0x44 #define ICH6_REG_CORBWP 0x48 -- 1.7.1 --------------050206000100040505070002--

1 0

[alsa-devel] ASoC updates for 2.6.39
by Mark Brown 16 Mar '11

16 Mar '11

The following changes since commit 80e1b84ffe1354f314fd85c939900b816f394e5a: Merge branch 'for-2.6.38' into for-2.6.39 (2011-03-10 14:16:35 +0000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.39 A final batch of updates for 2.6.39 - these have been sitting in my -next tree for several days now. Christian Glindkamp (1): ASoC: Add MAX9850 codec driver Mark Brown (1): ASoC: Fix spacing in MAX8950 Takashi Iwai (1): ALSA: Add snd_ctl_activate_id() Vasily Khoruzhick (2): ASoC: PXA: z2: Mute internal speaker when headphones are connected ASoC: PXA: Z2: Fix codec pin name include/sound/control.h | 2 + sound/core/control.c | 46 +++++ sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/max9850.c | 389 ++++++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/max9850.h | 38 +++++ sound/soc/pxa/z2.c | 7 +- 7 files changed, 487 insertions(+), 1 deletions(-) create mode 100644 sound/soc/codecs/max9850.c create mode 100644 sound/soc/codecs/max9850.h

3 3