December 2011 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [RFC PATCH 0/1] ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec
by Michael Williamson 16 Dec '11

16 Dec '11

The following patch is an introduction of a codec driver for the TI DSD1791 audio part. This patch adds basic support and has been tested using a MityDSP-L138F SOM sitting on a Critical Link Industrial I/O evaluation board in 16 bit and 24 bit I2S mode. This is an RFC, as I'm still wandering around the ALSA framework a bit. Comments and guidance greatly appreciated. I can follow with control registers (gain, etc.) if this stuff looks OK. Thanks. -Mike Michael Williamson (1): ASoC: dsd1791: Introduce driver for TI DSD1791 stereo codec sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/dsd1791.c | 282 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 288 insertions(+), 0 deletions(-) create mode 100644 sound/soc/codecs/dsd1791.c -- 1.7.5.4

4 7

[alsa-devel] [PATCH] ASoC: Fix build error in sst_platform.c
by Axel Lin 16 Dec '11

16 Dec '11

Fix below build error: CC sound/soc/mid-x86/sst_platform.o sound/soc/mid-x86/sst_platform.c: In function 'sst_platform_open': sound/soc/mid-x86/sst_platform.c:274:2: error: 'ret_val' undeclared (first use in this function) sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [sound/soc/mid-x86/sst_platform.o] Error 1 make[2]: *** [sound/soc/mid-x86] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2 Signed-off-by: Axel Lin <axel.lin(a)gmail.com> --- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c index 24f9471..11c39c5 100644 --- a/sound/soc/mid-x86/sst_platform.c +++ b/sound/soc/mid-x86/sst_platform.c @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; struct sst_runtime_stream *stream; + int ret_val; pr_debug("sst_platform_open called\n"); -- 1.7.5.4

1 0

Re: [alsa-devel] [PATCH 2/15] module_param: avoid bool abuse, add bint for special cases.
by Guenter Roeck 15 Dec '11

15 Dec '11

On Wed, Dec 14, 2011 at 10:02:26PM -0500, Rusty Russell wrote: > For historical reasons, we allow module_param(bool) to take an int (or > an unsigned int). That's going away. > > A few drivers really want an int: they set it to -1 and a parameter > will set it to 0 or 1. This sucks: reading them from sysfs will give > 'Y' for both -1 and 1, but if we change it to an int, then the users > might be broken (if they did "param" instead of "param=1"). > > Use a new 'bint' parser for them. > > (ntfs has a different problem: it needs an int for debug_msgs because > it's also exposed via sysctl.) > > Cc: Steve Glendinning <steve.glendinning(a)smsc.com> > Cc: Jean Delvare <khali(a)linux-fr.org> > Cc: Guenter Roeck <guenter.roeck(a)ericsson.com> > Cc: Hoang-Nam Nguyen <hnguyen(a)de.ibm.com> > Cc: Christoph Raisch <raisch(a)de.ibm.com> > Cc: Roland Dreier <roland(a)kernel.org> > Cc: Sean Hefty <sean.hefty(a)intel.com> > Cc: Hal Rosenstock <hal.rosenstock(a)gmail.com> > Cc: linux390(a)de.ibm.com > Cc: Anton Altaparmakov <anton(a)tuxera.com> > Cc: Jaroslav Kysela <perex(a)perex.cz> > Cc: Takashi Iwai <tiwai(a)suse.de> > Cc: lm-sensors(a)lm-sensors.org > Cc: linux-rdma(a)vger.kernel.org > Cc: linux-s390(a)vger.kernel.org > Cc: linux-ntfs-dev(a)lists.sourceforge.net > Cc: alsa-devel(a)alsa-project.org > Signed-off-by: Rusty Russell <rusty(a)rustcorp.com.au> > --- > drivers/hwmon/emc2103.c | 2 +- For the hwmon driver: Acked-by: Guenter Roeck <guenter.roeck(a)ericsson.com> > drivers/infiniband/hw/ehca/ehca_main.c | 2 +- > drivers/s390/cio/cmf.c | 2 +- > fs/ntfs/super.c | 2 +- > include/linux/moduleparam.h | 6 ++++++ > kernel/params.c | 24 ++++++++++++++++++++++++ > sound/pci/intel8x0.c | 4 ++-- > 7 files changed, 36 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c > --- a/drivers/hwmon/emc2103.c > +++ b/drivers/hwmon/emc2103.c > @@ -55,7 +55,7 @@ static const u8 REG_TEMP_MAX[4] = { 0x34 > * it. Default is to leave the device in the state it's already in (-1). > * This parameter allows APD mode to be optionally forced on or off */ > static int apd = -1; > -module_param(apd, bool, 0); > +module_param(apd, bint, 0); > MODULE_PARM_DESC(init, "Set to zero to disable anti-parallel diode mode"); > > struct temperature { > diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c > --- a/drivers/infiniband/hw/ehca/ehca_main.c > +++ b/drivers/infiniband/hw/ehca/ehca_main.c > @@ -82,7 +82,7 @@ module_param_named(port_act_time, ehca_p > module_param_named(poll_all_eqs, ehca_poll_all_eqs, bool, S_IRUGO); > module_param_named(static_rate, ehca_static_rate, int, S_IRUGO); > module_param_named(scaling_code, ehca_scaling_code, bool, S_IRUGO); > -module_param_named(lock_hcalls, ehca_lock_hcalls, bool, S_IRUGO); > +module_param_named(lock_hcalls, ehca_lock_hcalls, bint, S_IRUGO); > module_param_named(number_of_cqs, ehca_max_cq, int, S_IRUGO); > module_param_named(number_of_qps, ehca_max_qp, int, S_IRUGO); > > diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c > --- a/drivers/s390/cio/cmf.c > +++ b/drivers/s390/cio/cmf.c > @@ -98,7 +98,7 @@ enum cmb_format { > * enum cmb_format. > */ > static int format = CMF_AUTODETECT; > -module_param(format, bool, 0444); > +module_param(format, bint, 0444); > > /** > * struct cmb_operations - functions to use depending on cmb_format > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c > --- a/fs/ntfs/super.c > +++ b/fs/ntfs/super.c > @@ -3198,7 +3198,7 @@ MODULE_DESCRIPTION("NTFS 1.2/3.x driver > MODULE_VERSION(NTFS_VERSION); > MODULE_LICENSE("GPL"); > #ifdef DEBUG > -module_param(debug_msgs, bool, 0); > +module_param(debug_msgs, bint, 0); > MODULE_PARM_DESC(debug_msgs, "Enable debug messages."); > #endif > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > @@ -367,6 +367,12 @@ extern int param_set_invbool(const char > extern int param_get_invbool(char *buffer, const struct kernel_param *kp); > #define param_check_invbool(name, p) __param_check(name, p, bool) > > +/* An int, which can only be set like a bool (though it shows as an int). */ > +extern struct kernel_param_ops param_ops_bint; > +extern int param_set_bint(const char *val, const struct kernel_param *kp); > +#define param_get_bint param_get_int > +#define param_check_bint param_check_int > + > /** > * module_param_array - a parameter which is an array of some type > * @name: the name of the array variable > diff --git a/kernel/params.c b/kernel/params.c > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -369,6 +369,30 @@ struct kernel_param_ops param_ops_invboo > }; > EXPORT_SYMBOL(param_ops_invbool); > > +int param_set_bint(const char *val, const struct kernel_param *kp) > +{ > + struct kernel_param boolkp; > + bool v; > + int ret; > + > + /* Match bool exactly, by re-using it. */ > + boolkp = *kp; > + boolkp.arg = &v; > + boolkp.flags |= KPARAM_ISBOOL; > + > + ret = param_set_bool(val, &boolkp); > + if (ret == 0) > + *(int *)kp->arg = v; > + return ret; > +} > +EXPORT_SYMBOL(param_set_bint); > + > +struct kernel_param_ops param_ops_bint = { > + .set = param_set_bint, > + .get = param_get_int, > +}; > +EXPORT_SYMBOL(param_ops_bint); > + > /* We break the rule and mangle the string. */ > static int param_array(const char *name, > const char *val, > diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c > --- a/sound/pci/intel8x0.c > +++ b/sound/pci/intel8x0.c > @@ -95,13 +95,13 @@ module_param(ac97_quirk, charp, 0444); > MODULE_PARM_DESC(ac97_quirk, "AC'97 workaround for strange hardware."); > module_param(buggy_semaphore, bool, 0444); > MODULE_PARM_DESC(buggy_semaphore, "Enable workaround for hardwares with problematic codec semaphores."); > -module_param(buggy_irq, bool, 0444); > +module_param(buggy_irq, bint, 0444); > MODULE_PARM_DESC(buggy_irq, "Enable workaround for buggy interrupts on some motherboards."); > module_param(xbox, bool, 0444); > MODULE_PARM_DESC(xbox, "Set to 1 for Xbox, if you have problems with the AC'97 codec detection."); > module_param(spdif_aclink, int, 0444); > MODULE_PARM_DESC(spdif_aclink, "S/PDIF over AC-link."); > -module_param(inside_vm, bool, 0444); > +module_param(inside_vm, bint, 0444); > MODULE_PARM_DESC(inside_vm, "KVM/Parallels optimization."); > > /* just for backward compatibility */ -- Guenter Roeck Distinguished Engineer PDU IP Systems

1 0

[PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
by Joerg Roedel 15 Dec '11

15 Dec '11

The variable ret_val is used but not declared. This causes the following compile error: sound/soc/mid-x86/sst_platform.c: In function =E2=80=98sst_platform_open=E2= =80=99: sound/soc/mid-x86/sst_platform.c:274:2: error: =E2=80=98ret_val=E2=80=99 = undeclared (first use in this function) sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier = is reported only once for each function it appears in make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1 Fix this. Signed-off-by: Joerg Roedel <joerg.roedel(a)amd.com> --- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_pla= tform.c index 24f9471..11c39c5 100644 --- a/sound/soc/mid-x86/sst_platform.c +++ b/sound/soc/mid-x86/sst_platform.c @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream= *substream) { struct snd_pcm_runtime *runtime =3D substream->runtime; struct sst_runtime_stream *stream; + int ret_val; =20 pr_debug("sst_platform_open called\n"); =20 --=20 1.7.5.4 --=20 AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 4= 3632

1 0

[PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
by Joerg Roedel 15 Dec '11

15 Dec '11

The variable ret_val is used but not declared. Fix this. Signed-off-by: Joerg Roedel <joerg.roedel(a)amd.com> --- sound/soc/mid-x86/sst_platform.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c index 24f9471..11c39c5 100644 --- a/sound/soc/mid-x86/sst_platform.c +++ b/sound/soc/mid-x86/sst_platform.c @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; struct sst_runtime_stream *stream; + int ret_val; pr_debug("sst_platform_open called\n"); -- 1.7.5.4 -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

1 0

[alsa-devel] [PATCH] ALSA: hda: invert mute led polarity for HP laptops
by Gustavo Maciel Dias Vieira 15 Dec '11

15 Dec '11

At least two HP laptop models with the IDT 92HD81B1X5 codec have the polarity of the mute led inverted with respect to the current driver default. Change the polarity for these machines only. Signed-off-by: Gustavo Maciel Dias Vieira <gustavo(a)sagui.org> --- sound/pci/hda/patch_sigmatel.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index d8d2f9d..c920a27 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -5601,6 +5601,16 @@ static void stac92hd8x_fill_auto_spec(struct hda_codec *codec) spec->num_dmics = spec->auto_dmic_cnt; } +static int stac92hd8x_hp_mute_led_polarity(struct hda_codec *codec) +{ + switch (codec->subsystem_id) { + case 0x103c1650: + return 1; + } + return 0; +} + + static int patch_stac92hd83xxx(struct hda_codec *codec) { struct sigmatel_spec *spec; @@ -5642,7 +5652,7 @@ again: codec->patch_ops = stac92xx_patch_ops; - if (find_mute_led_gpio(codec, 0)) + if (find_mute_led_gpio(codec, stac92hd8x_hp_mute_led_polarity(codec))) snd_printd("mute LED gpio %d polarity %d\n", spec->gpio_led, spec->gpio_led_polarity); -- 1.7.7.3

2 6

Re: [alsa-devel] [PATCH 2/15] module_param: avoid bool abuse, add bint for special cases.
by Takashi Iwai 15 Dec '11

15 Dec '11

At Thu, 15 Dec 2011 13:32:26 +1030, Rusty Russell wrote: > > For historical reasons, we allow module_param(bool) to take an int (or > an unsigned int). That's going away. > > A few drivers really want an int: they set it to -1 and a parameter > will set it to 0 or 1. This sucks: reading them from sysfs will give > 'Y' for both -1 and 1, but if we change it to an int, then the users > might be broken (if they did "param" instead of "param=1"). > > Use a new 'bint' parser for them. > > (ntfs has a different problem: it needs an int for debug_msgs because > it's also exposed via sysctl.) > > Cc: Steve Glendinning <steve.glendinning(a)smsc.com> > Cc: Jean Delvare <khali(a)linux-fr.org> > Cc: Guenter Roeck <guenter.roeck(a)ericsson.com> > Cc: Hoang-Nam Nguyen <hnguyen(a)de.ibm.com> > Cc: Christoph Raisch <raisch(a)de.ibm.com> > Cc: Roland Dreier <roland(a)kernel.org> > Cc: Sean Hefty <sean.hefty(a)intel.com> > Cc: Hal Rosenstock <hal.rosenstock(a)gmail.com> > Cc: linux390(a)de.ibm.com > Cc: Anton Altaparmakov <anton(a)tuxera.com> > Cc: Jaroslav Kysela <perex(a)perex.cz> > Cc: Takashi Iwai <tiwai(a)suse.de> For the sound part, Acked-by: Takashi Iwai <tiwai(a)suse.de> It's a nice feature. I know many drivers can be replaced with bint gracefully now (e.g. i915 driver). thanks, Takashi > Cc: lm-sensors(a)lm-sensors.org > Cc: linux-rdma(a)vger.kernel.org > Cc: linux-s390(a)vger.kernel.org > Cc: linux-ntfs-dev(a)lists.sourceforge.net > Cc: alsa-devel(a)alsa-project.org > Signed-off-by: Rusty Russell <rusty(a)rustcorp.com.au> > --- > drivers/hwmon/emc2103.c | 2 +- > drivers/infiniband/hw/ehca/ehca_main.c | 2 +- > drivers/s390/cio/cmf.c | 2 +- > fs/ntfs/super.c | 2 +- > include/linux/moduleparam.h | 6 ++++++ > kernel/params.c | 24 ++++++++++++++++++++++++ > sound/pci/intel8x0.c | 4 ++-- > 7 files changed, 36 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c > --- a/drivers/hwmon/emc2103.c > +++ b/drivers/hwmon/emc2103.c > @@ -55,7 +55,7 @@ static const u8 REG_TEMP_MAX[4] = { 0x34 > * it. Default is to leave the device in the state it's already in (-1). > * This parameter allows APD mode to be optionally forced on or off */ > static int apd = -1; > -module_param(apd, bool, 0); > +module_param(apd, bint, 0); > MODULE_PARM_DESC(init, "Set to zero to disable anti-parallel diode mode"); > > struct temperature { > diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/infiniband/hw/ehca/ehca_main.c > --- a/drivers/infiniband/hw/ehca/ehca_main.c > +++ b/drivers/infiniband/hw/ehca/ehca_main.c > @@ -82,7 +82,7 @@ module_param_named(port_act_time, ehca_p > module_param_named(poll_all_eqs, ehca_poll_all_eqs, bool, S_IRUGO); > module_param_named(static_rate, ehca_static_rate, int, S_IRUGO); > module_param_named(scaling_code, ehca_scaling_code, bool, S_IRUGO); > -module_param_named(lock_hcalls, ehca_lock_hcalls, bool, S_IRUGO); > +module_param_named(lock_hcalls, ehca_lock_hcalls, bint, S_IRUGO); > module_param_named(number_of_cqs, ehca_max_cq, int, S_IRUGO); > module_param_named(number_of_qps, ehca_max_qp, int, S_IRUGO); > > diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c > --- a/drivers/s390/cio/cmf.c > +++ b/drivers/s390/cio/cmf.c > @@ -98,7 +98,7 @@ enum cmb_format { > * enum cmb_format. > */ > static int format = CMF_AUTODETECT; > -module_param(format, bool, 0444); > +module_param(format, bint, 0444); > > /** > * struct cmb_operations - functions to use depending on cmb_format > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c > --- a/fs/ntfs/super.c > +++ b/fs/ntfs/super.c > @@ -3198,7 +3198,7 @@ MODULE_DESCRIPTION("NTFS 1.2/3.x driver > MODULE_VERSION(NTFS_VERSION); > MODULE_LICENSE("GPL"); > #ifdef DEBUG > -module_param(debug_msgs, bool, 0); > +module_param(debug_msgs, bint, 0); > MODULE_PARM_DESC(debug_msgs, "Enable debug messages."); > #endif > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > @@ -367,6 +367,12 @@ extern int param_set_invbool(const char > extern int param_get_invbool(char *buffer, const struct kernel_param *kp); > #define param_check_invbool(name, p) __param_check(name, p, bool) > > +/* An int, which can only be set like a bool (though it shows as an int). */ > +extern struct kernel_param_ops param_ops_bint; > +extern int param_set_bint(const char *val, const struct kernel_param *kp); > +#define param_get_bint param_get_int > +#define param_check_bint param_check_int > + > /** > * module_param_array - a parameter which is an array of some type > * @name: the name of the array variable > diff --git a/kernel/params.c b/kernel/params.c > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -369,6 +369,30 @@ struct kernel_param_ops param_ops_invboo > }; > EXPORT_SYMBOL(param_ops_invbool); > > +int param_set_bint(const char *val, const struct kernel_param *kp) > +{ > + struct kernel_param boolkp; > + bool v; > + int ret; > + > + /* Match bool exactly, by re-using it. */ > + boolkp = *kp; > + boolkp.arg = &v; > + boolkp.flags |= KPARAM_ISBOOL; > + > + ret = param_set_bool(val, &boolkp); > + if (ret == 0) > + *(int *)kp->arg = v; > + return ret; > +} > +EXPORT_SYMBOL(param_set_bint); > + > +struct kernel_param_ops param_ops_bint = { > + .set = param_set_bint, > + .get = param_get_int, > +}; > +EXPORT_SYMBOL(param_ops_bint); > + > /* We break the rule and mangle the string. */ > static int param_array(const char *name, > const char *val, > diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c > --- a/sound/pci/intel8x0.c > +++ b/sound/pci/intel8x0.c > @@ -95,13 +95,13 @@ module_param(ac97_quirk, charp, 0444); > MODULE_PARM_DESC(ac97_quirk, "AC'97 workaround for strange hardware."); > module_param(buggy_semaphore, bool, 0444); > MODULE_PARM_DESC(buggy_semaphore, "Enable workaround for hardwares with problematic codec semaphores."); > -module_param(buggy_irq, bool, 0444); > +module_param(buggy_irq, bint, 0444); > MODULE_PARM_DESC(buggy_irq, "Enable workaround for buggy interrupts on some motherboards."); > module_param(xbox, bool, 0444); > MODULE_PARM_DESC(xbox, "Set to 1 for Xbox, if you have problems with the AC'97 codec detection."); > module_param(spdif_aclink, int, 0444); > MODULE_PARM_DESC(spdif_aclink, "S/PDIF over AC-link."); > -module_param(inside_vm, bool, 0444); > +module_param(inside_vm, bint, 0444); > MODULE_PARM_DESC(inside_vm, "KVM/Parallels optimization."); > > /* just for backward compatibility */ >

1 0

[alsa-devel] [PATCH] ASoC: Staticise mfld_msic_dailink
by Axel Lin 15 Dec '11

15 Dec '11

Signed-off-by: Axel Lin <axel.lin(a)gmail.com> --- sound/soc/mid-x86/mfld_machine.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/mid-x86/mfld_machine.c b/sound/soc/mid-x86/mfld_machine.c index e53f8e4..8ae0574 100644 --- a/sound/soc/mid-x86/mfld_machine.c +++ b/sound/soc/mid-x86/mfld_machine.c @@ -281,7 +281,7 @@ static int mfld_init(struct snd_soc_pcm_runtime *runtime) return ret_val; } -struct snd_soc_dai_link mfld_msic_dailink[] = { +static struct snd_soc_dai_link mfld_msic_dailink[] = { { .name = "Medfield Headset", .stream_name = "Headset", -- 1.7.5.4

3 2

Re: [alsa-devel] bugs in "ASoC: core - Optimise and refactor pcm_new() to pass only rtd"?
by Mark Brown 14 Dec '11

14 Dec '11

On Wed, Dec 14, 2011 at 12:43:50PM +0000, James Hogan wrote: > I've bisected a problem with an out of tree set of asoc drivers down to commit > 552d1ef6b5a98d7b95959d5b139071e3c90cebf1 ("ASoC: core - Optimise and refactor > pcm_new() to pass only rtd"). By the looks of it this change was intended not > to change the workings of the code, however the dai parameter of pcm_new used > to be passed codec_dai in soc_new_pcm() (initialised from rtd->codec_dai), but > each driver now sets it's dai to rtd->cpu_dai instead. This seems to make the > driver check the wrong dai's driver->capture.channels_min in the pcm_new > callback, which makes it dereference > pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream in the driver's > preallocate_dma_buffer() function which can be NULL. Is this a bug (in every > pcm asoc driver) that just happens not to have been noticed, or have I > misunderstood it? Your drivers should never have beenn relying on this behaviour of the core - see changes in the pxa and fsl drivers which remove similar assumptions. The CPU driver should be checking for the substream if it's looking to see if a particular substream is present, not peering inside the DAI for a random parameter.

1 0

[alsa-devel] [PATCH] ASoC: Tune the accessory detection rates for WM8996
by Mark Brown 14 Dec '11

14 Dec '11

Use longer intervals when the microphone is not inserted to increase robustness against leisurely insertion. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8996.c | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 8f88f5a..da7acae 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2572,8 +2572,10 @@ static void wm8996_micd(struct snd_soc_codec *codec) SND_JACK_BTN_0); snd_soc_update_bits(codec, WM8996_MIC_DETECT_1, - WM8996_MICD_RATE_MASK, - WM8996_MICD_RATE_MASK); + WM8996_MICD_RATE_MASK | + WM8996_MICD_BIAS_STARTTIME_MASK, + WM8996_MICD_RATE_MASK | + 9 << WM8996_MICD_BIAS_STARTTIME_SHIFT); return; } @@ -2590,8 +2592,10 @@ static void wm8996_micd(struct snd_soc_codec *codec) /* Increase poll rate to give better responsiveness * for buttons */ snd_soc_update_bits(codec, WM8996_MIC_DETECT_1, - WM8996_MICD_RATE_MASK, - 5 << WM8996_MICD_RATE_SHIFT); + WM8996_MICD_RATE_MASK | + WM8996_MICD_BIAS_STARTTIME_MASK, + 5 << WM8996_MICD_RATE_SHIFT | + 7 << WM8996_MICD_BIAS_STARTTIME_SHIFT); } else { dev_dbg(codec->dev, "Mic button up\n"); snd_soc_jack_report(wm8996->jack, 0, SND_JACK_BTN_0); @@ -2639,8 +2643,10 @@ static void wm8996_micd(struct snd_soc_codec *codec) * responsiveness. */ snd_soc_update_bits(codec, WM8996_MIC_DETECT_1, - WM8996_MICD_RATE_MASK, - 7 << WM8996_MICD_RATE_SHIFT); + WM8996_MICD_RATE_MASK | + WM8996_MICD_BIAS_STARTTIME_MASK, + 7 << WM8996_MICD_RATE_SHIFT | + 7 << WM8996_MICD_BIAS_STARTTIME_SHIFT); } } } -- 1.7.7.3

1 0