September 2010 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [patch] sound/oss: potential integer overflow
by Dan Carpenter 08 Sep '10

08 Sep '10

We don't want "pre_event_timeout" to be negative because that would result in a stack traces in dmesg when we schedule a negative timeout. In the original code "HZ * val" could overflow so I just moved the check for negative below the multiply. Also the code in snd_seq_oss_ioctl() deliberately set the timeout to -1 which is wrong. Signed-off-by: Dan Carpenter <error27(a)gmail.com> diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c index e85789e..de61295 100644 --- a/sound/oss/sequencer.c +++ b/sound/oss/sequencer.c @@ -1507,9 +1507,9 @@ int sequencer_ioctl(int dev, struct file *file, unsigned int cmd, void __user *a case SNDCTL_MIDI_PRETIME: if (get_user(val, p)) return -EFAULT; + val = (HZ * val) / 10; if (val < 0) val = 0; - val = (HZ * val) / 10; pre_event_timeout = val; break; diff --git a/sound/oss/midibuf.c b/sound/oss/midibuf.c index 782b3b8..73acacd 100644 --- a/sound/oss/midibuf.c +++ b/sound/oss/midibuf.c @@ -380,9 +380,9 @@ int MIDIbuf_ioctl(int dev, struct file *file, case SNDCTL_MIDI_PRETIME: if (get_user(val, (int __user *)arg)) return -EFAULT; + val = (HZ * val) / 10; if (val < 0) val = 0; - val = (HZ * val) / 10; parms[dev].prech_timeout = val; return put_user(val, (int __user *)arg); diff --git a/sound/core/seq/oss/seq_oss_ioctl.c b/sound/core/seq/oss/seq_oss_ioctl.c index 5ac701c..ae2a39f 100644 --- a/sound/core/seq/oss/seq_oss_ioctl.c +++ b/sound/core/seq/oss/seq_oss_ioctl.c @@ -191,10 +191,9 @@ snd_seq_oss_ioctl(struct seq_oss_devinfo *dp, unsigned int cmd, unsigned long ca return 0; if (get_user(val, p)) return -EFAULT; - if (val <= 0) - val = -1; - else - val = (HZ * val) / 10; + val = (HZ * val) / 10; + if (val < 0) + val = 0; dp->readq->pre_event_timeout = val; return put_user(val, p) ? -EFAULT : 0;

3 2

[alsa-devel] [PATCH 1/1] SOUND: wm8753, remove dead code
by Jiri Slaby 08 Sep '10

08 Sep '10

There is adangling code in wm8753_probe which is never executed. Remove it. Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> Cc: Liam Girdwood <lg(a)opensource.wolfsonmicro.com> Cc: Takashi Iwai <tiwai(a)suse.de> Cc: Jaroslav Kysela <perex(a)suse.cz> --- sound/soc/codecs/wm8753.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index 4844232..4a945d3 100644 --- a/sound/soc/codecs/wm8753.c +++ b/sound/soc/codecs/wm8753.c @@ -1600,9 +1600,6 @@ static int wm8753_probe(struct snd_soc_codec *codec) wm8753_add_widgets(codec); return 0; - - run_delayed_work(&codec->delayed_work); - return ret; } /* power down chip */ -- 1.7.2.2

5 4

[alsa-devel] ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin]
by asim khan 08 Sep '10

08 Sep '10

Hi, ..soory in my previous posting i missed the subject :-) Iam using alsa lib version 1.0.22..and Iam running an alsa capture application. if Iam running this standalone application on my arm11 target ..it runs fine but when iam runnig this with my complete BD player integrated application it gives an error ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin] cannot open audio device plughw:0,0 (No such device or address). I googled Which explained the errors meant I didn't have the Alsa plugins set via ALSA_PCM_PLUGINS in make.conf I have enabled --with-pcm-plugins option in my configure script which will select all pcm-plugins #!/bin/sh ./configure CC=arm_v7_vfp_le-gcc --target=arm-linux --host=i386-linux --build=$BUILD --enable-static --enable-pcm --with-pcm-plugins --disable-debug --disable-python --prefix=/mtd_rwarea I have checked using pcm plugins the created library(.so,.a) size is reduced... but still Iam getting above same error ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin] Please let me know is there any other thing i can check to solve this problem ---Thanks Asim

2 1

[alsa-devel] (no subject)
by asim khan 08 Sep '10

08 Sep '10

Hi, Iam using alsa lib version 1.0.22..and Iam running an alsa capture application. if Iam running this standalone application on my arm11 target ..it runs fine but when iam runnig this with my complete BD player integrated application it gives an error ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin] cannot open audio device plughw:0,0 (No such device or address). I googled Which explained the errors meant I didn't have the Alsa plugins set via ALSA_PCM_PLUGINS in make.conf I have enabled --with-pcm-plugins option in my configure script which will select all pcm-plugins #!/bin/sh ./configure CC=arm_v7_vfp_le-gcc --target=arm-linux --host=i386-linux --build=$BUILD --enable-static --enable-pcm --with-pcm-plugins --disable-debug --disable-python --prefix=/mtd_rwarea I have checked using pcm plugins the created library(.so,.a) size is reduced... but still Iam getting above same error *ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin]* ** Please let me know is there any other thing i can check to solve this problem ---Thanks Asim * *

1 0

Re: [alsa-devel] ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin]
by Clemens Ladisch 08 Sep '10

08 Sep '10

(please don't top-post) asim khan wrote: > ./configure CC=arm_v7_vfp_le-gcc --target=arm-linux --host=i386-linux > --with-pcm-plugins=dmix --with-pcm-plugins=dsnoop --with-pcm-plugins=plug > --with-pcm-plugins=softvol --with-pcm-plugins=asym --build=$BUILD > --enable-static --enable-static --disable-debug --disable-python > --prefix=/mtd_rwarea. --with-pcm-plugins=dmix,dsnoop,plug,softvol,asym Regards, Clemens

1 0

Re: [alsa-devel] commit 7b2bfdb broke sound card detection on my Lenovo T400s
by Takashi Iwai 07 Sep '10

07 Sep '10

At Tue, 7 Sep 2010 00:45:48 +0200, Jens Taprogge wrote: > > On Mon, Sep 06, 2010 at 07:04:21PM +0200, Frank Becker wrote: > > Hi, > > > > Please always CC me since I'm not subscribed to the mailing lists. > > > > I have a problem since commit id 7b2bfdb (about 2.6.35-rc2) up to the > > latest HEAD on my Lenovo T400s laptop. Just found out while testing Ubuntu > > 10.10. > > > > Problem is: Headphones don't work any more, internal Microphone doesn't > > work any more. However, if I load snd-hda-intel with the option > > model=ideapad the mic and the headphones work perfectly well again. For now > > that is an acceptable work around. However, before the aforementioned > > commit I didn't have to provide any module parameters. > > > > Before rev 7b2bfdb I had: > > └[a8@t4]-~→find /proc/asound/card* -type f | grep codec | xargs grep \ > > "^Codec\|^Vendor Id\|^Subsystem Id\|^Revision Id" > > Codec: Conexant ID 5069 > > Vendor Id: 0x14f15069 > > Subsystem Id: 0x17aa2132 > > Revision Id: 0x100300 > > > > Starting with rev 7b2bfdb I get: > > └[a8@t4]-~→find /proc/asound/card* -type f | grep codec | xargs grep \ > > "^Codec\|^Vendor Id\|^Subsystem Id\|^Revision Id" > > Codec: Conexant CX20585 > > Vendor Id: 0x14f15069 > > Subsystem Id: 0x17aa2132 > > Revision Id: 0x100300 > > > > BTW, all the bisecting is done out of the linus.git tree. > > > > Thank you for looking into that. I'm happy to provide more information or test > > patches. > > > > Thanks, > > > > Frank > > > > > > -- > > Frank Becker <fb(a)alien8.de> (jabber|mail) | http://twitter.com/41i3n8 > > GnuPG: 0xADC29ECD | F01B 5E9C 1D09 981B 5B40 50D3 C80F 7459 ADC2 9ECD > > SILC-Net: a8 | Home: http://www.alien8.de | <<</>> http://www.c3d2.de > > "> Freedom is just chaos, with better lighting. <" Alan Dean Foster > > Hello Frank, > > apparently the devices are wired differently on the T410s (which works > here) and the T400s. > > Have you tried playing with the mixers? There might be additional ones > present after the patch. > > Also when you say things work perfectly when specifying "model=ideapad", > does that include automatic switching between internal and external > microphones? Have you attached your T410 to a docking station? Also, it'd be helpful if alsa-info.sh output is given. Jens, Frank, could you guys run it with --no-upload option and attach the output for comparison? thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe alsa-devel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

3 8

[alsa-devel] [PATCH] ASoC: Remove export of CS4270 DAI
by Mark Brown 07 Sep '10

07 Sep '10

Not needed with multi-component. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/cs4270.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 6542dc0..5fd8e0d 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -540,7 +540,6 @@ struct snd_soc_dai_driver cs4270_dai = { }, .ops = &cs4270_dai_ops, }; -EXPORT_SYMBOL_GPL(cs4270_dai); /** * cs4270_probe - ASoC probe function -- 1.7.1

3 2

[alsa-devel] Since kernel-2.6.32 alsactl thinks my sound card is "Unknown"
by Pacho Ramos 07 Sep '10

07 Sep '10

This is an old problem I am suffering since kernel-2.6.32 and that is still unresolved even with 2.6.35 and alsa-utils-1.0.23: http://www.spinics.net/lists/alsa-devel/msg31422.html If you follow the thread, it got stalled in: http://www.spinics.net/lists/alsa-devel/msg31433.html In summary, I get the following: # alsactl -f /etc/asound.state restore /dev/snd/controlC0 Unknown hardware: "VIA8237" "Realtek ALC658D" "AC97a:414c4781" "0x147b" "0x1415" Hardware is initialized using a guess method # echo $? 99 As you can see, the exit code was solved, but I don't know why my hardware is still shown as "Unknown" even if via82xx.c clearly has some lines for my device: SND_PCI_QUIRK(0x147b, 0x1415, "ABIT AV8", VIA_DXS_NO_VRA), Thanks a lot for your help

5 12

[alsa-devel] No jack sense Acer Aspire 7736ZG laptop
by Hans Lövhaga 07 Sep '10

07 Sep '10

Hello Headphones doesn't cut front speakers. Have tried adding this line to alsa-base.conf options snd-hda-intel model=? enable=1 index=0 (alsa-info script ran with above line commented out) Havent tried all available models for ALC888 but 3stack-dig and acer didn't change anything. acer-aspire gave no sound at all. Ubuntu 10.04 Acer Aspire 7736ZG New install, problem was there from first boot. Regards, Hans

2 1

[alsa-devel] ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin]
by asim khan 07 Sep '10

07 Sep '10

Hi, Iam using alsa lib version 1.0.22..and Iam running an alsa capture application. if Iam running this standalone application on my arm11 target ..it runs fine but when iam runnig this with my complete BD player integrated application it gives an error *ALSA lib pcm.c:2175 snd_pcm_open_conf) symbol _snd_pcm_plug_open is not defined inside [builtin] cannot open audio device plughw:0,0 (No such device or address).* ** I googled* *Which explained the errors meant I didn't have the Alsa plugins set via ALSA_PCM_PLUGINS in make.conf. I checked on target and x86 but there is no make.conf. Please let me know what is the problem and what can I do to get rid of this problem...its bit urgent plz let me know as soon as possible. --Thanks Asim

2 1