October 2010 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] RME HDSP9632, mute headphones
by Matthew Robbetts 11 Oct '10

11 Oct '10

hi Flo, Thanks for your reply. On 10/11/10 15:28, Florian Faber wrote: > Matthew, > >> Of course, you can adjust the volume digitally (though since hdspmixer overwrites all your routing every time you open it, it's a bit annoying to use). However, the card appears to have a dedicated a analogue gain stage just for the headphones. It's not a full PGA, but can be set to 0db, -6db, -12dB and mute - under windows. The ALSA driver only gives the first 3 options as controls. > > Ah, yes, that is something special with that old cards. I actually had > to look it up in the manual. Are you sure? I don't have one, but it looks like the AIO is very similar: http://www.rme-audio.de/images/products/aio_set.gif Anyhow - hardly important! :) > >> I had a quick look in the code, and it seems there's a 2-bit field in the 9632 control register for controlling this. Sounds neat, as we have 4 possible values. Can anyone confirm that the unused value (0x10, IIRC) in the ALSA driver is used to mute the headphones? > > I only have the sources for the newer cards, sorry. Just try it out, > nothing bad should happen there. > Hmmm, is there any advice you can give me on what might be affected or need modifying to stay in sync? I've not contributed to a project like this before... The obvious ones to me are of course the driver itself, and adding a new radio button to hdspconf. Is there anything else? Thanks a lot, Matt

1 0

[alsa-devel] Alsamixer-Qt4 0.5.0 released
by Sebastian H. 11 Oct '10

11 Oct '10

Hello again After an almost complete rewrite to support separate channels views in the main sliders and switches areas, Alsamixer-Qt4 0.5.0 is now available. http://xwmw.org/alsamixer-qt4/ http://sourceforge.net/projects/alsamixer-qt4/files/ This is a snapshot from the CHANGELOG file. * The channels mixer dialog is gone * Mixer elements can be toggled between joined and channels view * Automated switch from joined to channels view if channels values differ for a certain time * New context menus for mixer elements * New dynamic support for the Alsa is_active element flag * New command line arguments similar to the console alsamixer ones * The card selection widget got basic support for Alsa plugins * GUI cleanups and slight style changes * Reduced CPU usage by showing QSpinBox widgets only on demand (mouse over) * Fixed a forgotten debug timer that was always running in 0.4.1 (constant 1% CPU usage) I ran several tests but since a lot of code has been rewritten there still may be regressions or even new bugs. There're also some implemented features I couldn't test at all because my rather basic hardware doesn't support it. - Mixer elements with more than two channels. If the sliders arrangement or some graphics for your card with 32 channels per element look weird, please drop me a note and/or a screenshot. - Is-active flag In theory the mixer should support dynamic hiding and revealing of elements whose is-active flag changes. If it doesn't or even crashes, please tell. Any comments are welcome. Best, Sebastian H.

3 3

Re: [alsa-devel] [PATCH] ASoC: wm8804: fix error handling code
by Mark Brown 11 Oct '10

11 Oct '10

On Mon, Oct 11, 2010 at 04:50:56PM +0400, Vasiliy Kulikov wrote: > It is not greppable situation to simply change the behavior of all > drivers. I was looking for memory leak bugs in drivers/net/ and fixed > some of them. Manual looking through _all_ drivers takes much more > time. In general I try to search for repeatable bugs with coccinelle, > but it is rare case. The method you're using to generate the patches is pretty much orthogonal to anything else, except of course in the case where you're also submitting the automation for checking (which is useful where possible).

1 0

Re: [alsa-devel] [PATCH] ASoC: wm8804: fix error handling code
by Mark Brown 11 Oct '10

11 Oct '10

On Mon, Oct 11, 2010 at 04:15:55PM +0400, Vasiliy Kulikov wrote: > On Mon, Oct 11, 2010 at 13:00 +0100, Mark Brown wrote: > > ...it's not clear to me that this change is an improvement - it'll make > > the driver more fragile in the face of errors, I don't see a benefit in > > refusing to register the variant for one bus if the other fails? > I tried to implement your variant with depca driver in past, but it was > rejected by David Miller: > http://lists.openwall.net/netdev/2010/07/12/9 I disagree with David here, and in any case if you're going to make a style change like this they really ought to be applied over all drivers rather than just a few individual ones.

1 0

[alsa-devel] ASoC updates for 2.6.37
by Mark Brown 11 Oct '10

11 Oct '10

The following changes since commit 9d9641ec891a53ef93a8972c7913605aeb8127c7: Merge branch 'for-2.6.36' into for-2.6.37 (2010-10-07 13:44:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.37 Dan Carpenter (1): ASoC: checking kzalloc() for IS_ERR() instead of NULL Mark Brown (2): ASoC: Shrink code size for WM8962 register defaults table ASoC: Compress WM8962 register access map sound/soc/codecs/Makefile | 2 +- sound/soc/codecs/wm8804.c | 8 +- sound/soc/codecs/wm8962-tables.c |42299 -------------------------------------- sound/soc/codecs/wm8962.c | 1834 ++ sound/soc/codecs/wm8962.h | 11 - sound/soc/codecs/wm8985.c | 8 +- 6 files changed, 1843 insertions(+), 42319 deletions(-) delete mode 100644 sound/soc/codecs/wm8962-tables.c

2 3

[alsa-devel] [PATCH 0/4] ASoC AC97 audio support for ep93xx
by Mika Westerberg 11 Oct '10

11 Oct '10

Hello, This series adds AC97 audio support for Cirrus Logic EP93xx family SoCs. Example machine driver is for Simplemachines Sim.One (which is the only hardware that I have which has AC97 codec). The first patch is a bugfix for the DMA code. Without the patch audio DMA transfers may corrupt if playing application is killed while playing. This results weird noise playback when application is started again. I would like Ryan Mallon to confirm that this is indeed correct fix and if possible to check that I2S transfers still work after this patch is applied. Please review. Thanks, MW Mika Westerberg (4): ARM: ep93xx: DMA: fix channel_disable ASoC: add ep93xx AC97 audio driver ARM: ep93xx: add AC97 platform support ASoC: ep93xx: add Simplemachines Sim.One AC97 audio support arch/arm/mach-ep93xx/core.c | 32 ++ arch/arm/mach-ep93xx/dma-m2p.c | 2 +- arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h | 1 + arch/arm/mach-ep93xx/include/mach/platform.h | 1 + arch/arm/mach-ep93xx/simone.c | 1 + sound/soc/ep93xx/Kconfig | 17 +- sound/soc/ep93xx/Makefile | 4 + sound/soc/ep93xx/ep93xx-ac97.c | 476 +++++++++++++++++++++++ sound/soc/ep93xx/ep93xx-ac97.h | 17 + sound/soc/ep93xx/simone.c | 80 ++++ 10 files changed, 629 insertions(+), 2 deletions(-) create mode 100644 sound/soc/ep93xx/ep93xx-ac97.c create mode 100644 sound/soc/ep93xx/ep93xx-ac97.h create mode 100644 sound/soc/ep93xx/simone.c

4 15

[alsa-devel] [PATCH] ALSA: hda - Add another HP DV6 quirk
by Luke Yelavich 11 Oct '10

11 Oct '10

From: Luke Yelavich <luke.yelavich(a)canonical.com> BugLink: https://bugs.launchpad.net/bugs/653420 Add another HP DV6 notebook (103c:363e) to use STAC_HP_DV5. Signed-off-by: Luke Yelavich <luke.yelavich(a)canonical.com> --- sound/pci/hda/patch_sigmatel.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index d8dfafe..f3577ed 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1750,6 +1750,8 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = { "HP dv6", STAC_HP_DV5), /* HP dv6-1110ax */ SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xfff0, 0x7010, "HP", STAC_HP_DV5), + SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x363e, + "HP DV6", STAC_HP_DV5), SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0233, "unknown Dell", STAC_DELL_M4_1), SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0234, -- 1.7.1

2 1

[alsa-devel] [PATCH] sound/usb/usx2y: simplify conditional
by Nicolas Kaiser 11 Oct '10

11 Oct '10

Simplify conditional: (a || (!a && b)) => (a || b) Signed-off-by: Nicolas Kaiser <nikai(a)nikai.net> --- sound/usb/usx2y/usx2yhwdeppcm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/usb/usx2y/usx2yhwdeppcm.c b/sound/usb/usx2y/usx2yhwdeppcm.c index 2a528e5..3146a81 100644 --- a/sound/usb/usx2y/usx2yhwdeppcm.c +++ b/sound/usb/usx2y/usx2yhwdeppcm.c @@ -54,7 +54,7 @@ #include <linux/gfp.h> #include "usbusx2yaudio.c" -#if defined(USX2Y_NRPACKS_VARIABLE) || (!defined(USX2Y_NRPACKS_VARIABLE) && USX2Y_NRPACKS == 1) +#if defined(USX2Y_NRPACKS_VARIABLE) || USX2Y_NRPACKS == 1 #include <sound/hwdep.h> -- 1.7.2.2

2 1

[alsa-devel] [PATCH] ASoC: wm8804: fix error handling code
by Vasiliy Kulikov 11 Oct '10

11 Oct '10

kzalloc() returns NULL on error, not ERR_PTR(). Also wm8804_modinit() didn't called i2c_del_driver() if spi_register_driver() failed. Signed-off-by: Vasiliy Kulikov <segooon(a)gmail.com> --- Compile tested. sound/soc/codecs/wm8804.c | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c index 642b07c..ff4dffd 100644 --- a/sound/soc/codecs/wm8804.c +++ b/sound/soc/codecs/wm8804.c @@ -720,8 +720,8 @@ static int __devinit wm8804_spi_probe(struct spi_device *spi) int ret; wm8804 = kzalloc(sizeof *wm8804, GFP_KERNEL); - if (IS_ERR(wm8804)) - return PTR_ERR(wm8804); + if (!wm8804) + return -ENOMEM; wm8804->control_type = SND_SOC_SPI; spi_set_drvdata(spi, wm8804); @@ -758,8 +758,8 @@ static __devinit int wm8804_i2c_probe(struct i2c_client *i2c, int ret; wm8804 = kzalloc(sizeof *wm8804, GFP_KERNEL); - if (IS_ERR(wm8804)) - return PTR_ERR(wm8804); + if (!wm8804) + return -ENOMEM; wm8804->control_type = SND_SOC_I2C; i2c_set_clientdata(i2c, wm8804); @@ -804,6 +804,7 @@ static int __init wm8804_modinit(void) if (ret) { printk(KERN_ERR "Failed to register wm8804 I2C driver: %d\n", ret); + goto err; } #endif #if defined(CONFIG_SPI_MASTER) @@ -811,7 +812,13 @@ static int __init wm8804_modinit(void) if (ret != 0) { printk(KERN_ERR "Failed to register wm8804 SPI driver: %d\n", ret); + goto err_i2c; } +err_i2c: +#endif +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) + i2c_del_driver(&wm8804_i2c_driver); +err: #endif return ret; } -- 1.7.0.4

2 1

[alsa-devel] [patch 2/2] OSS: soundcard: fix return value of sound_open()
by Dan Carpenter 11 Oct '10

11 Oct '10

Signed-off-by: Dan Carpenter <error27(a)gmail.com> diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c index a5ab61e..46c0d03 100644 --- a/sound/oss/soundcard.c +++ b/sound/oss/soundcard.c @@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file) } mutex_unlock(&soundcard_mutex); - return 0; + return retval; } static int sound_release(struct inode *inode, struct file *file)

2 1