August 2009 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Problems with snd-hda-intel ALC1200 on msi gt725-212us laptop Only one speaker works and headphones do not mute laptop sound
by Tony Rao 31 Aug '09

31 Aug '09

msi gt725-212us Codec: Realtek ALC1200 This laptop has 4.1 sound. Sound is only coming out of subwoofer. When I plug in headphones sounds still comes out of subwoofer, but headphones work perfectly. http://www.alsa-project.org/db/?f=e95a9401ebfa6cb0133b11fc1482ea115f766d5e Thanks, Tony R

1 0

[alsa-devel] Error enabling dmix with ALSA
by ruchi sirauthiya 30 Aug '09

30 Aug '09

Hi, I am trying to enable a software mixer (using ALSA and dmix) on an OMAP3 based embedded target board using the twl4030 codec. When I try to play audio using the command, # aplay -D playback rec.wav I am getting the following error: ALSA lib pcm_direct.c:1098:(snd_pcm_direct_initialize_poll_fd) unable to open timer 'hw:CLASS=3,SCLASS=0,CARD=0,DEV=0,SUBDEV=0' ALSA lib pcm_dmix.c:943:(snd_pcm_dmix_open) unable to initialize poll_fd aplay: main:546: audio open error: No such file or directory The contents of my /etc/asound.conf is given below. pcm.playback { type dmix ipc_key 2048 ipc_key_add_uid true ipc_gid 1 slave { rate 44100 pcm hw:0 } } I have tested it on two kernel versions, 2.6.22 and 2.6.29, but it fails on both. Playback and recording works fine if -D option is not provided. I also tried configuring ALSA (dmix) with a different configuration file which is given in the following link: http://amarok.kde.org/wiki/Setting_up_Dmix_for_ALSA # aplay -D plug:ossmix /mnt/Audio1_1.wav ALSA lib pcm_direct.c:1098:(snd_pcm_direct_initialize_poll_fd) unable to open timer 'hw:CLASS=3,SCLASS=0,CARD=0,DEV=0,SUBDEV=0' ALSA lib pcm_dmix.c:943:(snd_pcm_dmix_open) unable to initialize poll_fd aplay: main:546: audio open error: No such file or directory But as you can see the same error turns up again. The topic discussed in the following link (a similar issue) suggests that it is unable to open a second timer. http://osdir.com/ml/linux.distributions.crux.general/2005-11/msg00134.html What could be the cause of this error? Is the above error related to my ALSA configuration (for dmix) or is it related to the sound hardware (or driver)? Do I need to patch the kernel or ALSA for using dmix? Please help me resolve this issue. Let me know if any more setup info is required. Thanks and Regards, Ruchi Sirauthiya. Some information I obtained from the proc filesystem is given below for your reference. ----------------------- For Linux kernel 2.6.29 ----------------------- [root@OMAP3 tests]# cat /proc/asound/version Advanced Linux Sound Architecture Driver Version 1.0.19 [root@OMAP3 tests]# cat /proc/asound/cards 0 [omap3evm ]: twl4030 - omap3evm omap3evm (twl4030) [root@OMAP3 tests]# omap-dss: Could not find exact pixel clock. Requested 25188 kHz, got 25187 kHz [root@OMAP3 tests]# cat /proc/asound/devices 2: : timer 3: [ 0- 0]: digital audio playback 4: [ 0- 0]: digital audio capture 5: [ 0] : control [root@OMAP3 tests]# cat /proc/asound/timers G0: system timer : 7812.500us (10000000 ticks) P0-0-0: PCM playback 0-0-0 : SLAVE P0-0-1: PCM capture 0-0-1 : SLAVE [root@OMAP3 tests]# cat /proc/asound/pcm 00-00: TWL4030 twl4030-0 : : playback 1 : capture 1 [root@OMAP3 tests]# cat /proc/asound/devices 2: : timer 3: [ 0- 0]: digital audio playback 4: [ 0- 0]: digital audio capture 5: [ 0] : control [root@OMAP3 tests]# cat /proc/asound/pcm 00-00: TWL4030 twl4030-0 : : playback 1 : capture 1 [root@OMAP3 tests]# cat /proc/asound/oss/devices 3: [0- 0]: digital audio 4: [0- 0]: digital audio [root@OMAP3 tests]# cat /proc/asound/oss/sndstat Sound Driver:3.8.1a-980706 (ALSA v1.0.19 emulation code) Kernel: Linux OMAP3 2.6.29-rc3-omap1 #1 Fri Jul 24 14:45:37 IST 2009 armv7l Config options: 0 Installed drivers: Type 10: ALSA emulation Card config: omap3evm (twl4030) Audio devices: 0: (DUPLEX) Synth devices: NOT ENABLED IN CONFIG Midi devices: NOT ENABLED IN CONFIG Timers: 31: system timer Mixers: NOT ENABLED IN CONFIG [root@OMAP3 tests]# aplay -D playback /mnt/Audio1_1.wav ALSA lib pcm_direct.c:1098:(snd_pcm_direct_initialize_poll_fd) unable to open timer 'hw:CLASS=3,SCLASS=0,CARD=0,DEV=0,SUBDEV=0' ALSA lib pcm_dmix.c:943:(snd_pcm_dmix_open) unable to initialize poll_fd aplay: main:546: audio open error: No such file or directory ----------------------- For Linux kernel 2.6.22 ----------------------- [root@OMAP3 tests]# cat /proc/asound/devices 2: : timer 3: [ 0- 0]: digital audio playback 4: [ 0- 0]: digital audio capture 5: [ 0] : control [root@OMAP3 tests]# cat /proc/asound/pcm 00-00: OMAP PCM : omap alsa pcm : playback 1 : capture 1 [root@OMAP3 tests]# cat /proc/asound/timers G0: system timer : 7812.500us (10000000 ticks) P0-0-0: PCM playback 0-0-0 : SLAVE P0-0-1: PCM capture 0-0-1 : SLAVE [root@OMAP3 tests]# cat /proc/asound/ /proc/asound/TWL4030/ /proc/asound/devices /proc/asound/timers /proc/asound/card0/ /proc/asound/hwdep /proc/asound/version /proc/asound/cards /proc/asound/pcm [root@OMAP3 tests]# cat /proc/asound/cards 0 [TWL4030 ]: OMAP_ALSA - TWL4030 TWL4030 /proc/asound/oss was not found in the proc file system when booted with kernel 2.6.22.

2 4

[alsa-devel] ASoC DAI on Atmel AT32AP7000
by Christos Nikolaou 30 Aug '09

30 Aug '09

Hi, Up to 2.6.28 the ASoC framework was working on AT32AP7000 Atmel platform. Now I try to recompile it on 2.6.31-rc8 and I get Advance Linux Sound Architecture Driver Version 1.0.20. No device for DAI atmel-ssc0 No device for DAI atmel-ssc1 No device for DAI atmel-ssc2 whereas the ssc devices are properly (as in 2.6.28) initialized ssc ssc.0: Atmel SSC device at 0xffe1c00 (irq 10) ssc ssc.1: Atmel SSC device at 0xffe2000 (irq 11) ssc ssc.2: Atmel SSC device at 0xffe2400 (irq 12) It looks that this message comes from snd_soc_register_dai in soc-core.c if (!dai->dev) printk(KERN_WARNING "No device for DAI %s\n", dai->name); it seems for some reason it thinks there is no device in dai->dev Unless I'm mistaken, that is being called from sound/soc/atmel/atmel_ssc_dai.c after some modifications done by broonie on these files according to http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=history;… . Is there anything that can be done to rectify this? Regards, Christos

2 3

[alsa-devel] ASoC updates for 2.6.32
by Mark Brown 30 Aug '09

30 Aug '09

The following changes since commit a0a499c5792b8656cd51e11d5e0db9fb21640f58: Eduardo Valentin (1): ASoC: OMAP: Use DMA operating mode of McBSP are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.32 Ben Dooks (4): ASoC: S3C24XX: Add audio core and tlv320aic23 for Simtec boards ASoC: tlv320aic3x: Change to use device model ASoC: tlv320aic3x: fixup board device changes ASoC: S3C24XX: Support for Simtec Hermes boards Kuninori Morimoto (2): ASoC: Add ak4642/ak4643 codec support ASoC: Add FSI-AK4642 sound support for SuperH Marek Vasut (5): power_supply: Make wm97xx-core pass platform_data to battery, ts power_supply: Convert WM97xx battery to use platform_data power_supply: Let wm97xx-battery use irq to detect charger state [ARM] pxa: Convert all platforms to pass platform_data to wm97xx battery ASoC: Pass correct platform data from pxa2xx-ac97 Mark Brown (1): ASoC: Add DAPM widget power decision debugfs files Roel Kluin (1): ASoC: free socdev if init_card() fails in wm9705_soc_probe() arch/arm/mach-pxa/mioa701.c | 10 +- arch/arm/mach-pxa/palmld.c | 19 +- arch/arm/mach-pxa/palmt5.c | 19 +- arch/arm/mach-pxa/palmte2.c | 20 +- arch/arm/mach-pxa/palmtx.c | 19 +- arch/arm/mach-pxa/palmz72.c | 20 +- arch/arm/mach-pxa/treo680.c | 1 - arch/arm/plat-s3c/include/plat/audio-simtec.h | 37 ++ drivers/input/touchscreen/wm97xx-core.c | 3 + drivers/power/wm97xx_battery.c | 56 ++- include/linux/wm97xx.h | 18 + include/linux/wm97xx_batt.h | 26 -- include/sound/soc-dapm.h | 1 + include/sound/soc.h | 1 + sound/arm/pxa2xx-ac97.c | 4 +- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak4642.c | 502 ++++++++++++++++++++++++ sound/soc/codecs/ak4642.h | 20 + sound/soc/codecs/tlv320aic3x.c | 221 ++++++----- sound/soc/codecs/tlv320aic3x.h | 2 - sound/soc/codecs/wm9705.c | 2 +- sound/soc/davinci/davinci-evm.c | 12 +- sound/soc/omap/n810.c | 12 +- sound/soc/pxa/pxa2xx-ac97.c | 4 +- sound/soc/s3c24xx/Kconfig | 19 + sound/soc/s3c24xx/Makefile | 7 + sound/soc/s3c24xx/s3c24xx_simtec.c | 394 +++++++++++++++++++ sound/soc/s3c24xx/s3c24xx_simtec.h | 22 + sound/soc/s3c24xx/s3c24xx_simtec_hermes.c | 153 +++++++ sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c | 137 +++++++ sound/soc/s6000/s6105-ipcam.c | 12 +- sound/soc/sh/Kconfig | 8 + sound/soc/sh/Makefile | 2 + sound/soc/sh/fsi-ak4642.c | 107 +++++ sound/soc/soc-core.c | 8 + sound/soc/soc-dapm.c | 86 ++++ 37 files changed, 1784 insertions(+), 206 deletions(-) create mode 100644 arch/arm/plat-s3c/include/plat/audio-simtec.h delete mode 100644 include/linux/wm97xx_batt.h create mode 100644 sound/soc/codecs/ak4642.c create mode 100644 sound/soc/codecs/ak4642.h create mode 100644 sound/soc/s3c24xx/s3c24xx_simtec.c create mode 100644 sound/soc/s3c24xx/s3c24xx_simtec.h create mode 100644 sound/soc/s3c24xx/s3c24xx_simtec_hermes.c create mode 100644 sound/soc/s3c24xx/s3c24xx_simtec_tlv320aic23.c create mode 100644 sound/soc/sh/fsi-ak4642.c

3 8

[alsa-devel] [PATCH 4/4] ASoC: Davinci: Add audio codec support for DM365 EVM
by miguel.aguilar＠ridgerun.com 29 Aug '09

29 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> 1) Enables tlv320aic3101 support on DM365 EVM. 2) Set tlv320aic3x i2c setup into DM365 EVM board file. This patch was tested on DM365 EVM rev c. Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- arch/arm/mach-davinci/board-dm365-evm.c | 3 +++ sound/soc/davinci/Kconfig | 9 +++++++++ sound/soc/davinci/Makefile | 1 + sound/soc/davinci/davinci-evm.c | 29 +++++++++++++++++++++++++++-- 4 files changed, 40 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index fd2db78..cff68e1 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -187,6 +187,9 @@ static struct i2c_board_info i2c_info[] = { I2C_BOARD_INFO("24c256", 0x50), .platform_data = &eeprom_info, }, + { + I2C_BOARD_INFO("tlv320aic3x", 0x18), + }, }; static struct davinci_i2c_platform_data i2c_pdata = { diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig index 6802dd5..b78b882 100644 --- a/sound/soc/davinci/Kconfig +++ b/sound/soc/davinci/Kconfig @@ -32,6 +32,15 @@ config SND_DM6467_SOC_EVM help Say Y if you want to add support for SoC audio on TI +config SND_DM365_SOC_EVM + tristate "SoC Audio support for DaVinci DM365 EVM" + depends on SND_DAVINCI_SOC && MACH_DAVINCI_DM365_EVM + select SND_DAVINCI_SOC_I2S + select SND_SOC_TLV320AIC3X + + help + Say Y if you want to add support for SoC audio on TI + config SND_DAVINCI_SOC_SFFSDR tristate "SoC Audio support for SFFSDR" depends on SND_DAVINCI_SOC && MACH_SFFSDR diff --git a/sound/soc/davinci/Makefile b/sound/soc/davinci/Makefile index 67be54f..8238612 100644 --- a/sound/soc/davinci/Makefile +++ b/sound/soc/davinci/Makefile @@ -13,4 +13,5 @@ snd-soc-sffsdr-objs := davinci-sffsdr.o obj-$(CONFIG_SND_DAVINCI_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DM6467_SOC_EVM) += snd-soc-evm.o +obj-$(CONFIG_SND_DM365_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DAVINCI_SOC_SFFSDR) += snd-soc-sffsdr.o diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c index f3bb6f6..a859208 100644 --- a/sound/soc/davinci/davinci-evm.c +++ b/sound/soc/davinci/davinci-evm.c @@ -44,7 +44,8 @@ static int evm_hw_params(struct snd_pcm_substream *substream, unsigned sysclk; /* ASP1 on DM355 EVM is clocked by an external oscillator */ - if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm()) + if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm() + || machine_is_davinci_dm365_evm()) sysclk = 27000000; /* ASP0 in DM6446 EVM is clocked by U55, as configured by @@ -179,6 +180,14 @@ static struct snd_soc_card dm6467_snd_soc_card_evm = { .num_links = ARRAY_SIZE(dm6467_evm_dai), }; +/* davinci dm365 evm audio machine driver */ +static struct snd_soc_card dm365_snd_soc_card_evm = { + .name = "DaVinci DM365 EVM", + .platform = &davinci_soc_platform, + .dai_link = &evm_dai, + .num_links = 1, +}; + /* evm audio private data */ static struct aic3x_setup_data evm_aic3x_setup = { .i2c_bus = 1, @@ -191,6 +200,12 @@ static struct aic3x_setup_data dm6467_evm_aic3x_setup = { .i2c_address = 0x18, }; +/* dm365 evm audio private data */ +static struct aic3x_setup_data dm365_evm_aic3x_setup = { + .i2c_bus = 1, + .i2c_address = 0x18, +}; + /* evm audio subsystem */ static struct snd_soc_device evm_snd_devdata = { .card = &snd_soc_card_evm, @@ -198,13 +213,20 @@ static struct snd_soc_device evm_snd_devdata = { .codec_data = &evm_aic3x_setup, }; -/* evm audio subsystem */ +/* dm6467 evm audio subsystem */ static struct snd_soc_device dm6467_evm_snd_devdata = { .card = &dm6467_snd_soc_card_evm, .codec_dev = &soc_codec_dev_aic3x, .codec_data = &dm6467_evm_aic3x_setup, }; +/* dm365 evm audio subsystem */ +static struct snd_soc_device dm365_evm_snd_devdata = { + .card = &dm365_snd_soc_card_evm, + .codec_dev = &soc_codec_dev_aic3x, + .codec_data = &dm365_evm_aic3x_setup, +}; + static struct platform_device *evm_snd_device; static int __init evm_init(void) @@ -222,6 +244,9 @@ static int __init evm_init(void) } else if (machine_is_davinci_dm6467_evm()) { evm_snd_dev_data = &dm6467_evm_snd_devdata; index = 0; + }else if (machine_is_davinci_dm365_evm()) { + evm_snd_dev_data = &dm365_evm_snd_devdata; + index = 0; } else return -EINVAL; -- 1.6.0.4

2 1

[alsa-devel] [PATCH 3/4] Davinci: DM365: Add platform device for McBSP
by miguel.aguilar＠ridgerun.com 29 Aug '09

29 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> 1) Registers the platform device for McBSP on DM365. 2) Add platform data to DM365 EVM board file. Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- arch/arm/mach-davinci/board-dm365-evm.c | 4 ++ arch/arm/mach-davinci/dm365.c | 42 +++++++++++++++++++++++++++- arch/arm/mach-davinci/include/mach/asp.h | 3 ++ arch/arm/mach-davinci/include/mach/dm365.h | 2 + 4 files changed, 50 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index f6adf79..fd2db78 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -177,6 +177,8 @@ static struct at24_platform_data eeprom_info = { .context = (void *)0x7f00, }; +static struct snd_platform_data dm365_evm_snd_data; + static struct i2c_board_info i2c_info[] = { { I2C_BOARD_INFO("dm365evm_keys", 0x25), @@ -476,6 +478,8 @@ static __init void dm365_evm_init(void) /* maybe setup mmc1/etc ... _after_ mmc0 */ evm_init_cpld(); + + dm365_init_asp(&dm365_evm_snd_data); } static __init void dm365_evm_irq_init(void) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index e815174..cba09b0 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -32,6 +32,7 @@ #include <mach/time.h> #include <mach/serial.h> #include <mach/common.h> +#include <mach/asp.h> #include "clock.h" #include "mux.h" @@ -456,7 +457,7 @@ static struct davinci_clk dm365_clks[] = { CLK(NULL, "usb", &usb_clk), CLK("davinci_emac.1", NULL, &emac_clk), CLK("voice_codec", NULL, &voicecodec_clk), - CLK("soc-audio.0", NULL, &asp0_clk), + CLK("davinci-asp.0", NULL, &asp0_clk), CLK(NULL, "rto", &rto_clk), CLK(NULL, "mjcp", &mjcp_clk), CLK(NULL, NULL, NULL), @@ -806,6 +807,31 @@ static struct platform_device dm365_edma_device = { .resource = edma_resources, }; +static struct resource dm365_asp_resources[] = { + { + .start = DAVINCI_DM365_ASP0_BASE, + .end = DAVINCI_DM365_ASP0_BASE + SZ_8K - 1, + .flags = IORESOURCE_MEM, + }, + { + .start = DAVINCI_DMA_ASP0_TX, + .end = DAVINCI_DMA_ASP0_TX, + .flags = IORESOURCE_DMA, + }, + { + .start = DAVINCI_DMA_ASP0_RX, + .end = DAVINCI_DMA_ASP0_RX, + .flags = IORESOURCE_DMA, + }, +}; + +static struct platform_device dm365_asp_device = { + .name = "davinci-asp", + .id = 0, + .num_resources = ARRAY_SIZE(dm365_asp_resources), + .resource = dm365_asp_resources, +}; + static struct map_desc dm365_io_desc[] = { { .virtual = IO_VIRT, @@ -907,6 +933,20 @@ static struct davinci_soc_info davinci_soc_info_dm365 = { .sram_len = SZ_32K, }; +void __init dm365_init_asp(struct snd_platform_data *pdata) +{ + davinci_cfg_reg(DM365_MCBSP0_BDX); + davinci_cfg_reg(DM365_MCBSP0_X); + davinci_cfg_reg(DM365_MCBSP0_BFSX); + davinci_cfg_reg(DM365_MCBSP0_BDR); + davinci_cfg_reg(DM365_MCBSP0_R); + davinci_cfg_reg(DM365_MCBSP0_BFSR); + davinci_cfg_reg(DM365_EVT2_ASP_TX); + davinci_cfg_reg(DM365_EVT3_ASP_RX); + dm365_asp_device.dev.platform_data = pdata; + platform_device_register(&dm365_asp_device); +} + void __init dm365_init(void) { davinci_common_init(&davinci_soc_info_dm365); diff --git a/arch/arm/mach-davinci/include/mach/asp.h b/arch/arm/mach-davinci/include/mach/asp.h index 18e4ce3..fbcbed0 100644 --- a/arch/arm/mach-davinci/include/mach/asp.h +++ b/arch/arm/mach-davinci/include/mach/asp.h @@ -15,6 +15,9 @@ #define DAVINCI_DM646X_MCASP0_REG_BASE 0x01D01000 #define DAVINCI_DM646X_MCASP1_REG_BASE 0x01D01800 +/* Bases of dm365 register banks */ +#define DAVINCI_DM365_ASP0_BASE 0x01D02000 + /* Bases of da850/da830 McASP0 register banks */ #define DAVINCI_DA8XX_MCASP0_REG_BASE 0x01D00000 diff --git a/arch/arm/mach-davinci/include/mach/dm365.h b/arch/arm/mach-davinci/include/mach/dm365.h index 09db434..2291c0d 100644 --- a/arch/arm/mach-davinci/include/mach/dm365.h +++ b/arch/arm/mach-davinci/include/mach/dm365.h @@ -16,6 +16,7 @@ #include <linux/platform_device.h> #include <mach/hardware.h> #include <mach/emac.h> +#include <mach/asp.h> #define DM365_EMAC_BASE (0x01D07000) #define DM365_EMAC_CNTRL_OFFSET (0x0000) @@ -25,5 +26,6 @@ #define DM365_EMAC_CNTRL_RAM_SIZE (0x2000) void __init dm365_init(void); +void __init dm365_init_asp(struct snd_platform_data *pdata); #endif /* __ASM_ARCH_DM365_H */ -- 1.6.0.4

2 1

[alsa-devel] [PATCH v2 2/2] ASoC: Davinci: Add audio codec support for DM365 EVM
by miguel.aguilar＠ridgerun.com 29 Aug '09

29 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> This patch enables tlv320aic3101 support on DM365 EVM and it was tested on DM365 EVM rev c. Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- sound/soc/davinci/Kconfig | 9 +++++++++ sound/soc/davinci/Makefile | 1 + sound/soc/davinci/davinci-evm.c | 29 +++++++++++++++++++++++++++-- 3 files changed, 37 insertions(+), 2 deletions(-) diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig index 6802dd5..b78b882 100644 --- a/sound/soc/davinci/Kconfig +++ b/sound/soc/davinci/Kconfig @@ -32,6 +32,15 @@ config SND_DM6467_SOC_EVM help Say Y if you want to add support for SoC audio on TI +config SND_DM365_SOC_EVM + tristate "SoC Audio support for DaVinci DM365 EVM" + depends on SND_DAVINCI_SOC && MACH_DAVINCI_DM365_EVM + select SND_DAVINCI_SOC_I2S + select SND_SOC_TLV320AIC3X + + help + Say Y if you want to add support for SoC audio on TI + config SND_DAVINCI_SOC_SFFSDR tristate "SoC Audio support for SFFSDR" depends on SND_DAVINCI_SOC && MACH_SFFSDR diff --git a/sound/soc/davinci/Makefile b/sound/soc/davinci/Makefile index 67be54f..8238612 100644 --- a/sound/soc/davinci/Makefile +++ b/sound/soc/davinci/Makefile @@ -13,4 +13,5 @@ snd-soc-sffsdr-objs := davinci-sffsdr.o obj-$(CONFIG_SND_DAVINCI_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DM6467_SOC_EVM) += snd-soc-evm.o +obj-$(CONFIG_SND_DM365_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DAVINCI_SOC_SFFSDR) += snd-soc-sffsdr.o diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c index f3bb6f6..a859208 100644 --- a/sound/soc/davinci/davinci-evm.c +++ b/sound/soc/davinci/davinci-evm.c @@ -44,7 +44,8 @@ static int evm_hw_params(struct snd_pcm_substream *substream, unsigned sysclk; /* ASP1 on DM355 EVM is clocked by an external oscillator */ - if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm()) + if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm() + || machine_is_davinci_dm365_evm()) sysclk = 27000000; /* ASP0 in DM6446 EVM is clocked by U55, as configured by @@ -179,6 +180,14 @@ static struct snd_soc_card dm6467_snd_soc_card_evm = { .num_links = ARRAY_SIZE(dm6467_evm_dai), }; +/* davinci dm365 evm audio machine driver */ +static struct snd_soc_card dm365_snd_soc_card_evm = { + .name = "DaVinci DM365 EVM", + .platform = &davinci_soc_platform, + .dai_link = &evm_dai, + .num_links = 1, +}; + /* evm audio private data */ static struct aic3x_setup_data evm_aic3x_setup = { .i2c_bus = 1, @@ -191,6 +200,12 @@ static struct aic3x_setup_data dm6467_evm_aic3x_setup = { .i2c_address = 0x18, }; +/* dm365 evm audio private data */ +static struct aic3x_setup_data dm365_evm_aic3x_setup = { + .i2c_bus = 1, + .i2c_address = 0x18, +}; + /* evm audio subsystem */ static struct snd_soc_device evm_snd_devdata = { .card = &snd_soc_card_evm, @@ -198,13 +213,20 @@ static struct snd_soc_device evm_snd_devdata = { .codec_data = &evm_aic3x_setup, }; -/* evm audio subsystem */ +/* dm6467 evm audio subsystem */ static struct snd_soc_device dm6467_evm_snd_devdata = { .card = &dm6467_snd_soc_card_evm, .codec_dev = &soc_codec_dev_aic3x, .codec_data = &dm6467_evm_aic3x_setup, }; +/* dm365 evm audio subsystem */ +static struct snd_soc_device dm365_evm_snd_devdata = { + .card = &dm365_snd_soc_card_evm, + .codec_dev = &soc_codec_dev_aic3x, + .codec_data = &dm365_evm_aic3x_setup, +}; + static struct platform_device *evm_snd_device; static int __init evm_init(void) @@ -222,6 +244,9 @@ static int __init evm_init(void) } else if (machine_is_davinci_dm6467_evm()) { evm_snd_dev_data = &dm6467_evm_snd_devdata; index = 0; + }else if (machine_is_davinci_dm365_evm()) { + evm_snd_dev_data = &dm365_evm_snd_devdata; + index = 0; } else return -EINVAL; -- 1.6.0.4

1 0

[alsa-devel] ASoC: at91sam9260-PCM1808/TAS5709-based board driver
by Pedro Sanchez 29 Aug '09

29 Aug '09

Hello, I have to develop a driver for a custom board based on the at91sam9260 with a PCM1808/TAS5709 chipset combo. I am addressing the PCM1808 first because it is a simpler device. Since I'm new to ASoC I'm looking for some help in this list on how to go about writing this driver. So far I have identified two files that I need to work on (other than the needed kconfig modifications). First is the codec driver at sound/soc/codecs/PCM1808.[c|h] which is based on the existent pcm3008 driver; I believe I'm fine with this. The second file is the machine driver at sound/soc/atmel/myBoard.c. I'm using sam9g20_wm8731.c as reference, on which I believe I found a typo which I reported in a separated e-mail. So my first question is, is this two-files step the right approach? am I in the right track? I'm using the 2.6.30 kernel. Other questions will come and I hope I will get some cycles from you to help me direct my work. Of course I'll be glad to submit my driver work for inclusion in the kernel if it proves useful. Regards, -- Pedro

5 16

[alsa-devel] [PATCH 1/2] Davinci: DM365: Add platform device for McBSP
by miguel.aguilar＠ridgerun.com 28 Aug '09

28 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> 1) Registers the platform device for McBSP on DM365. 2) Add platform data to DM365 EVM board file. Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- arch/arm/mach-davinci/board-dm365-evm.c | 4 ++ arch/arm/mach-davinci/dm365.c | 42 +++++++++++++++++++++++++++- arch/arm/mach-davinci/include/mach/asp.h | 3 ++ arch/arm/mach-davinci/include/mach/dm365.h | 2 + 4 files changed, 50 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index f6adf79..fd2db78 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -177,6 +177,8 @@ static struct at24_platform_data eeprom_info = { .context = (void *)0x7f00, }; +static struct snd_platform_data dm365_evm_snd_data; + static struct i2c_board_info i2c_info[] = { { I2C_BOARD_INFO("dm365evm_keys", 0x25), @@ -476,6 +478,8 @@ static __init void dm365_evm_init(void) /* maybe setup mmc1/etc ... _after_ mmc0 */ evm_init_cpld(); + + dm365_init_asp(&dm365_evm_snd_data); } static __init void dm365_evm_irq_init(void) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index e815174..cba09b0 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -32,6 +32,7 @@ #include <mach/time.h> #include <mach/serial.h> #include <mach/common.h> +#include <mach/asp.h> #include "clock.h" #include "mux.h" @@ -456,7 +457,7 @@ static struct davinci_clk dm365_clks[] = { CLK(NULL, "usb", &usb_clk), CLK("davinci_emac.1", NULL, &emac_clk), CLK("voice_codec", NULL, &voicecodec_clk), - CLK("soc-audio.0", NULL, &asp0_clk), + CLK("davinci-asp.0", NULL, &asp0_clk), CLK(NULL, "rto", &rto_clk), CLK(NULL, "mjcp", &mjcp_clk), CLK(NULL, NULL, NULL), @@ -806,6 +807,31 @@ static struct platform_device dm365_edma_device = { .resource = edma_resources, }; +static struct resource dm365_asp_resources[] = { + { + .start = DAVINCI_DM365_ASP0_BASE, + .end = DAVINCI_DM365_ASP0_BASE + SZ_8K - 1, + .flags = IORESOURCE_MEM, + }, + { + .start = DAVINCI_DMA_ASP0_TX, + .end = DAVINCI_DMA_ASP0_TX, + .flags = IORESOURCE_DMA, + }, + { + .start = DAVINCI_DMA_ASP0_RX, + .end = DAVINCI_DMA_ASP0_RX, + .flags = IORESOURCE_DMA, + }, +}; + +static struct platform_device dm365_asp_device = { + .name = "davinci-asp", + .id = 0, + .num_resources = ARRAY_SIZE(dm365_asp_resources), + .resource = dm365_asp_resources, +}; + static struct map_desc dm365_io_desc[] = { { .virtual = IO_VIRT, @@ -907,6 +933,20 @@ static struct davinci_soc_info davinci_soc_info_dm365 = { .sram_len = SZ_32K, }; +void __init dm365_init_asp(struct snd_platform_data *pdata) +{ + davinci_cfg_reg(DM365_MCBSP0_BDX); + davinci_cfg_reg(DM365_MCBSP0_X); + davinci_cfg_reg(DM365_MCBSP0_BFSX); + davinci_cfg_reg(DM365_MCBSP0_BDR); + davinci_cfg_reg(DM365_MCBSP0_R); + davinci_cfg_reg(DM365_MCBSP0_BFSR); + davinci_cfg_reg(DM365_EVT2_ASP_TX); + davinci_cfg_reg(DM365_EVT3_ASP_RX); + dm365_asp_device.dev.platform_data = pdata; + platform_device_register(&dm365_asp_device); +} + void __init dm365_init(void) { davinci_common_init(&davinci_soc_info_dm365); diff --git a/arch/arm/mach-davinci/include/mach/asp.h b/arch/arm/mach-davinci/include/mach/asp.h index 18e4ce3..fbcbed0 100644 --- a/arch/arm/mach-davinci/include/mach/asp.h +++ b/arch/arm/mach-davinci/include/mach/asp.h @@ -15,6 +15,9 @@ #define DAVINCI_DM646X_MCASP0_REG_BASE 0x01D01000 #define DAVINCI_DM646X_MCASP1_REG_BASE 0x01D01800 +/* Bases of dm365 register banks */ +#define DAVINCI_DM365_ASP0_BASE 0x01D02000 + /* Bases of da850/da830 McASP0 register banks */ #define DAVINCI_DA8XX_MCASP0_REG_BASE 0x01D00000 diff --git a/arch/arm/mach-davinci/include/mach/dm365.h b/arch/arm/mach-davinci/include/mach/dm365.h index 09db434..2291c0d 100644 --- a/arch/arm/mach-davinci/include/mach/dm365.h +++ b/arch/arm/mach-davinci/include/mach/dm365.h @@ -16,6 +16,7 @@ #include <linux/platform_device.h> #include <mach/hardware.h> #include <mach/emac.h> +#include <mach/asp.h> #define DM365_EMAC_BASE (0x01D07000) #define DM365_EMAC_CNTRL_OFFSET (0x0000) @@ -25,5 +26,6 @@ #define DM365_EMAC_CNTRL_RAM_SIZE (0x2000) void __init dm365_init(void); +void __init dm365_init_asp(struct snd_platform_data *pdata); #endif /* __ASM_ARCH_DM365_H */ -- 1.6.0.4

2 1

[alsa-devel] [PATCH 2/2] ASoC: Davinci: Add audio codec support for DM365 EVM
by miguel.aguilar＠ridgerun.com 28 Aug '09

28 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> 1) Enables tlv320aic3101 support on DM365 EVM. 2) Set tlv320aic3x i2c setup into DM365 EVM board file. This patch was tested on DM365 EVM rev c. Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- arch/arm/mach-davinci/board-dm365-evm.c | 3 +++ sound/soc/davinci/Kconfig | 9 +++++++++ sound/soc/davinci/Makefile | 1 + sound/soc/davinci/davinci-evm.c | 29 +++++++++++++++++++++++++++-- 4 files changed, 40 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index fd2db78..cff68e1 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c @@ -187,6 +187,9 @@ static struct i2c_board_info i2c_info[] = { I2C_BOARD_INFO("24c256", 0x50), .platform_data = &eeprom_info, }, + { + I2C_BOARD_INFO("tlv320aic3x", 0x18), + }, }; static struct davinci_i2c_platform_data i2c_pdata = { diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig index 6802dd5..b78b882 100644 --- a/sound/soc/davinci/Kconfig +++ b/sound/soc/davinci/Kconfig @@ -32,6 +32,15 @@ config SND_DM6467_SOC_EVM help Say Y if you want to add support for SoC audio on TI +config SND_DM365_SOC_EVM + tristate "SoC Audio support for DaVinci DM365 EVM" + depends on SND_DAVINCI_SOC && MACH_DAVINCI_DM365_EVM + select SND_DAVINCI_SOC_I2S + select SND_SOC_TLV320AIC3X + + help + Say Y if you want to add support for SoC audio on TI + config SND_DAVINCI_SOC_SFFSDR tristate "SoC Audio support for SFFSDR" depends on SND_DAVINCI_SOC && MACH_SFFSDR diff --git a/sound/soc/davinci/Makefile b/sound/soc/davinci/Makefile index 67be54f..8238612 100644 --- a/sound/soc/davinci/Makefile +++ b/sound/soc/davinci/Makefile @@ -13,4 +13,5 @@ snd-soc-sffsdr-objs := davinci-sffsdr.o obj-$(CONFIG_SND_DAVINCI_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DM6467_SOC_EVM) += snd-soc-evm.o +obj-$(CONFIG_SND_DM365_SOC_EVM) += snd-soc-evm.o obj-$(CONFIG_SND_DAVINCI_SOC_SFFSDR) += snd-soc-sffsdr.o diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c index f3bb6f6..a859208 100644 --- a/sound/soc/davinci/davinci-evm.c +++ b/sound/soc/davinci/davinci-evm.c @@ -44,7 +44,8 @@ static int evm_hw_params(struct snd_pcm_substream *substream, unsigned sysclk; /* ASP1 on DM355 EVM is clocked by an external oscillator */ - if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm()) + if (machine_is_davinci_dm355_evm() || machine_is_davinci_dm6467_evm() + || machine_is_davinci_dm365_evm()) sysclk = 27000000; /* ASP0 in DM6446 EVM is clocked by U55, as configured by @@ -179,6 +180,14 @@ static struct snd_soc_card dm6467_snd_soc_card_evm = { .num_links = ARRAY_SIZE(dm6467_evm_dai), }; +/* davinci dm365 evm audio machine driver */ +static struct snd_soc_card dm365_snd_soc_card_evm = { + .name = "DaVinci DM365 EVM", + .platform = &davinci_soc_platform, + .dai_link = &evm_dai, + .num_links = 1, +}; + /* evm audio private data */ static struct aic3x_setup_data evm_aic3x_setup = { .i2c_bus = 1, @@ -191,6 +200,12 @@ static struct aic3x_setup_data dm6467_evm_aic3x_setup = { .i2c_address = 0x18, }; +/* dm365 evm audio private data */ +static struct aic3x_setup_data dm365_evm_aic3x_setup = { + .i2c_bus = 1, + .i2c_address = 0x18, +}; + /* evm audio subsystem */ static struct snd_soc_device evm_snd_devdata = { .card = &snd_soc_card_evm, @@ -198,13 +213,20 @@ static struct snd_soc_device evm_snd_devdata = { .codec_data = &evm_aic3x_setup, }; -/* evm audio subsystem */ +/* dm6467 evm audio subsystem */ static struct snd_soc_device dm6467_evm_snd_devdata = { .card = &dm6467_snd_soc_card_evm, .codec_dev = &soc_codec_dev_aic3x, .codec_data = &dm6467_evm_aic3x_setup, }; +/* dm365 evm audio subsystem */ +static struct snd_soc_device dm365_evm_snd_devdata = { + .card = &dm365_snd_soc_card_evm, + .codec_dev = &soc_codec_dev_aic3x, + .codec_data = &dm365_evm_aic3x_setup, +}; + static struct platform_device *evm_snd_device; static int __init evm_init(void) @@ -222,6 +244,9 @@ static int __init evm_init(void) } else if (machine_is_davinci_dm6467_evm()) { evm_snd_dev_data = &dm6467_evm_snd_devdata; index = 0; + }else if (machine_is_davinci_dm365_evm()) { + evm_snd_dev_data = &dm365_evm_snd_devdata; + index = 0; } else return -EINVAL; -- 1.6.0.4

2 1

[alsa-devel] [PATCH] Davinci: Enable ASoC support for DM365 EVM in defconfig
by miguel.aguilar＠ridgerun.com 28 Aug '09

28 Aug '09

From: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> Signed-off-by: Miguel Aguilar <miguel.aguilar(a)ridgerun.com> --- arch/arm/configs/davinci_all_defconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index ec63c15..cbe18b4 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -1099,6 +1099,7 @@ CONFIG_SND_DAVINCI_SOC_I2S=m CONFIG_SND_DAVINCI_SOC_MCASP=m CONFIG_SND_DAVINCI_SOC_EVM=m CONFIG_SND_DM6467_SOC_EVM=m +CONFIG_SND_DM365_SOC_EVM=m # CONFIG_SND_DAVINCI_SOC_SFFSDR is not set CONFIG_SND_SOC_I2C_AND_SPI=m # CONFIG_SND_SOC_ALL_CODECS is not set -- 1.6.0.4

1 0

[alsa-devel] ASoC updates for 2.6.32
by Mark Brown 28 Aug '09

28 Aug '09

The following changes since commit d09a2afc9359407114b7062519101f1ee2d05388: Jarkko Nikula (1): ARM: OMAP: McBSP: Merge two functions into omap_mcbsp_start/_stop are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.32 Candelaria Villareal, Jorge (1): ASoC: SDP3430: Fix TWL GPIO6 pin mux request Mark Brown (4): ASoC: Add S3C24xx dependencies for Simtec machines ASoC: Make platform data optional for TLV320AIC3x ASoC: Fix s3c-i2s-v2 build ASoC: Don't reconfigure WM8350 FLL if not needed Shine Liu (1): ASoC: S3C platform: Fix s3c2410_dma_started() called at improper time sound/soc/codecs/tlv320aic3x.c | 13 ++++++------- sound/soc/codecs/wm8350.c | 9 +++++++++ sound/soc/omap/sdp3430.c | 15 +++++++++++---- sound/soc/s3c24xx/Kconfig | 4 ++-- sound/soc/s3c24xx/s3c-i2s-v2.c | 11 +++++++++++ sound/soc/s3c24xx/s3c2443-ac97.c | 10 ++++++++++ sound/soc/s3c24xx/s3c24xx-i2s.c | 5 +++++ sound/soc/s3c24xx/s3c24xx-pcm.c | 1 - 8 files changed, 54 insertions(+), 14 deletions(-)

2 5

[alsa-devel] Audio capture not working with AIC23/McBSP1 on OMAP3517
by Aggarwal, Anuj 28 Aug '09

28 Aug '09

Hi, I am trying to capture audio through LineIn on my OMAP3517 EVM, using AIC23 codec and McBSP1, and getting the following error: arecord: pcm_read:1529: read error: Input/output error Playback is working fine using the same combination. I have tried using another instance of AIC23 codec which uses McBSP2 and both playback & capture works fine there. Has anyone faced this issue before? Any suggestions? Regards, Anuj Aggarwal

4 11

[alsa-devel] Skype beta better audio, but crashing after launch...
by jack craig 28 Aug '09

28 Aug '09

I thought i'd start a new thread given the progress the beta provides. now my test sound makes a noise and my test call lanuches and stops when i tell it to, BUT! it crashes with the below. pulseaudio[3400]: resampler.c: Using float32le as working format. pulseaudio[3400]: resampler.c: Choosing speex quality setting 3. pulseaudio[3400]: source-output.c: Created output 0 "Input" on alsa_input.pci_8086_24c5_sound_card_0 with sample spec s16le 1ch 16000Hz and channel map mono pulseaudio[3400]: protocol-native.c: Final latency 199.89 ms = 99.94 ms + 99.95 ms pulseaudio[3400]: source.c: Assertion 'pa_cvolume_compatible(volume, &s->sample_spec)' failed at pulsecore/source.c:666, function pa_source_set_volume(). Aborting. any suggestions on fixing this ? tia, jackc... -- jack craig jackc(a)LinuxLightHouse.com 831-684-1375 (Office) 831-596-6924 (cell) IM: jackcraigaptos (AIM) _________________________________ This email has been ClamScanned ! www.LinuxLightHouse.com

1 0

[alsa-devel] Any patches missing for 2.6.32?
by Takashi Iwai 28 Aug '09

28 Aug '09

Hi, now 2.6.31-rc8 came up, and we are pretty close to the next merge window. If you have any patches that should go into 2.6.32, please speak up, post them now. Otherwise it'll be postponed after 2.6.32. thanks, Takashi

1 0

[alsa-devel] SNDRV_PCM_TRIGGER_STOP and audio still queued in the driver
by Jon Smirl 28 Aug '09

28 Aug '09

In the mpc5200 driver I'm receiving SNDRV_PCM_TRIGGER_STOP with audio still queued. I noticed this in an app that uses a 2MB ALSA buffer. It is filling the 2MB buffer which starts playing. After the buffer is filled I receive the STOP. This STOP comes before the hardware has a chance to play all of the music. There is still about twenty seconds of music in the driver buffer waiting to be played. How is this supposed to work? -- Jon Smirl jonsmirl(a)gmail.com

2 11

[alsa-devel] [PATCH 1/1] sound: usb-audio: support for Digidesign Mbox 2
by Damien Zammit 27 Aug '09

27 Aug '09

Provides magic boot sequence which activates the device, must loop until device is ready, (returns status bytes). Provides extra magic to set the device into 24 bit mode. -Playback works @ 24-bit -MIDI I/O works -Capture is untested, but PCM stream is active -S/PDIF (RCA) I/O is untested, but lights activate on the device S/PDIF mode works by setting the required flag in usbaudio.c. I think the device can't do both simultaneously, since different altsettings are required to set it. Remaining issues: 1) Double check endianess of 24 bit capture. 2) Check duplex stability 3) Tell ALSA to correctly detect S24_3BE on the device. Currently, speaker-test assumes S16_LE and won't allow S24_3BE mode, but jackd 0.116-2 detects and plays S24_3BE ? 4) Create a kernel module switch to select spdif/analogue I/O Playback sample format : S24_3BE MIDI format : MIDIMAN protocol Signed-off-by: Damien Zammit <damien.zammit(a)gmail.com> diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index 43d7d88..3060941 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -943,7 +943,7 @@ static snd_pcm_uframes_t snd_usb_pcm_pointer(struct snd_pcm_substream *substream { struct snd_usb_substream *subs; snd_pcm_uframes_t hwptr_done; - + subs = (struct snd_usb_substream *)substream->runtime->private_data; spin_lock(&subs->lock); hwptr_done = subs->hwptr_done; @@ -2441,6 +2441,12 @@ static int parse_audio_format_i_type(struct snd_usb_audio *chip, struct audiofor fp->altsetting, sample_width, sample_bytes); break; } + + /* Digidesign Mbox 2 workaround: + * supports S24_3BE BIG ENDIAN */ + if (chip->usb_id == USB_ID(0x0dba, 0x3000)) + pcm_format = SNDRV_PCM_FORMAT_S24_3BE; + break; case USB_AUDIO_FORMAT_PCM8: pcm_format = SNDRV_PCM_FORMAT_U8; @@ -2550,13 +2556,20 @@ static int parse_audio_format_i(struct snd_usb_audio *chip, struct audioformat * switch (chip->usb_id) { case USB_ID(0x0763, 0x2003): /* M-Audio Audiophile USB */ - if (device_setup[chip->index] == 0x00 && + if (device_setup[chip->index] == 0x00 && fp->altsetting == 6) pcm_format = SNDRV_PCM_FORMAT_S16_BE; else pcm_format = SNDRV_PCM_FORMAT_S16_LE; break; - default: + + /* Digidesign Mbox 2 supports SPDIF 24 bit (havent tested endianess) */ + case USB_ID(0x0dba, 0x3000): + pcm_format = SNDRV_PCM_FORMAT_S24_3BE; + break; + + default: + snd_printdd("Format III detected, setting default S16_LE\n"); pcm_format = SNDRV_PCM_FORMAT_S16_LE; } } else { @@ -2655,6 +2668,8 @@ static unsigned char parse_datainterval(struct snd_usb_audio *chip, static int audiophile_skip_setting_quirk(struct snd_usb_audio *chip, int iface, int altno); +static int mbox2_skip_setting_quirk(struct snd_usb_audio *chip, + int iface, int altno); static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) { struct usb_device *dev; @@ -2700,13 +2715,19 @@ static int parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no) stream = (get_endpoint(alts, 0)->bEndpointAddress & USB_DIR_IN) ? SNDRV_PCM_STREAM_CAPTURE : SNDRV_PCM_STREAM_PLAYBACK; altno = altsd->bAlternateSetting; - + /* audiophile usb: skip altsets incompatible with device_setup */ - if (chip->usb_id == USB_ID(0x0763, 0x2003) && + if (chip->usb_id == USB_ID(0x0763, 0x2003) && audiophile_skip_setting_quirk(chip, iface_no, altno)) continue; + /* Digidesign Mbox 2: skip altsets incompatible with device_setup + */ + if (chip->usb_id == USB_ID(0x0dba, 0x3000) && + mbox2_skip_setting_quirk(chip, iface_no, altno)) + continue; + /* get audio formats */ fmt = snd_usb_find_csint_desc(alts->extra, alts->extralen, NULL, AS_GENERAL); if (!fmt) { @@ -2995,7 +3016,7 @@ static int create_standard_audio_quirk(struct snd_usb_audio *chip, } /* - * Create a stream for an Edirol UA-700/UA-25/UA-4FX interface. + * Create a stream for an Edirol UA-700/UA-25/UA-4FX interface. * The only way to detect the sample rate is by looking at wMaxPacketSize. */ static int create_uaxx_quirk(struct snd_usb_audio *chip, @@ -3264,6 +3285,97 @@ static int snd_usb_extigy_boot_quirk(struct usb_device *dev, struct usb_interfac return 0; } + +#define MBOX2_FIRMWARE_SIZE 646 +#define MBOX2_BOOT_LOADING 0x01 /* Hard coded into the device */ +#define MBOX2_BOOT_READY 0x02 /* Hard coded into the device */ + +static int snd_usb_mbox2_boot_quirk(struct usb_device *dev) +{ + struct usb_host_config *config = dev->actconfig; + int err; + u8 enablemagic[3]; + u8 bootresponse; + int fwsize; + + if ((fwsize = le16_to_cpu(get_cfg_desc(config)->wTotalLength)) == MBOX2_FIRMWARE_SIZE) { + snd_printdd("Sending Digidesign Mbox 2 boot sequence...\n"); + + /* From USB Snoop, + * + * SetupPacket = RT RQ VHVL INDX SIZE + * RT = 0xRT Request Type + * RQ = 0xRQ Request + * VHVL = 0xVLVH Value in reverse byte order + * INDX = 0xDXIN Index in reverse byte order + * SIZE = 0xZESI Size in reverse byte order + * + * Magic boot code setup packet: c0 85 01 00 00 00 12 00 + * RQ RT VLVH DXIN ZESI + * becomes 0x85, 0xc0, 0x0001, 0x0000, &RETURNDATA, 0x0012, TIMEOUT + * for snd_usb_ctl_msg() + */ + +mbox2_reboot: + snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), + 0x85, 0xc0, 0x0001, 0x0000, &bootresponse, 0x0012, 1000); + + if (bootresponse == MBOX2_BOOT_LOADING) { + snd_printdd("device not ready, resending boot sequence...\n"); + goto mbox2_reboot; + } + + if (bootresponse == MBOX2_BOOT_READY) { + snd_printdd("device initialised!\n"); + + err = usb_get_descriptor(dev, USB_DT_DEVICE, 0, + &dev->descriptor, sizeof(dev->descriptor)); + config = dev->actconfig; + if (err < 0) snd_printdd("error usb_get_descriptor: %d\n", err); + err = usb_reset_configuration(dev); + if (err < 0) snd_printdd("error usb_reset_configuration: %d\n", err); + snd_printdd("mbox2_boot: new boot length = %d\n", + le16_to_cpu(get_cfg_desc(config)->wTotalLength)); + + /* Successful boot, (should reset all altsettings to 0 like windows does, but works without it) + * but now we will try sending capture/playback enable magic + * + * 80 bb 00 = 24bit mode - S24_3BE + * 44 ac 00 = 16bit mode? + * + */ + //enablemagic[0]=0x44; + //enablemagic[1]=0xac; + //enablemagic[2]=0x00; + + /* We want 24 bit mode for now */ + enablemagic[0]=0x80; + enablemagic[1]=0xbb; + enablemagic[2]=0x00; + + /* Send the magic! */ + snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), + 0x01, 0x22, 0x0100, 0x0085, &enablemagic, 0x0003, 1000); + + snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), + 0x81, 0xa2, 0x0100, 0x0085, &enablemagic, 0x0003, 1000); + + snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), + 0x81, 0xa2, 0x0100, 0x0086, &enablemagic, 0x0003, 1000); + + snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), + 0x81, 0xa2, 0x0100, 0x0003, &enablemagic, 0x0003, 1000); + + return 0; /* Succesful boot */ + } + + snd_printdd("unknown bootresponse, ignoring device: %d\n",bootresponse); + return -ENODEV; + } + snd_printdd("Invalid firmware size: %d\n",fwsize); + return -ENODEV; +} + static int snd_usb_audigy2nx_boot_quirk(struct usb_device *dev) { u8 buf = 1; @@ -3366,10 +3478,79 @@ static int audiophile_skip_setting_quirk(struct snd_usb_audio *chip, if ((device_setup[chip->index] & AUDIOPHILE_SET_MASK) == AUDIOPHILE_SET_16B_48K_NOTDI && altno != 5) return 1; /* skip this altsetting */ - } + } return 0; /* keep this altsetting */ } +/* Digidesign Mbox 2 I/O selector + * Uncomment this line to enable SPDIF */ +//#define MBOX2_SPDIF_IO + +#define MBOX2_FIRMWARE_INTERFACE 0 +#define MBOX2_CONTROL_INTERFACE 1 +#define MBOX2_MIDI_INTERFACE 6 + +static int mbox2_skip_setting_quirk(struct snd_usb_audio *chip, + int iface, int altno) +{ + /* Reset ifaces 2-5 to 0 altsetting. */ + usb_set_interface(chip->dev, iface, 0); + +#ifdef MBOX2_SPDIF_IO + /* Enable SPDIF altsettings */ + switch (iface) { + case MBOX2_FIRMWARE_INTERFACE: + case MBOX2_CONTROL_INTERFACE: + return 0; /*keep*/ + break; + case 2: + if (altno == 2) return 0; else return 1; + break; + case 3: + return 1; + break; + case 4: + if (altno == 2) return 0; else return 1; + break; + case 5: + return 1; + break; + case MBOX2_MIDI_INTERFACE: + return 0; /*keep*/ + break; + default: + snd_printdd("Invalid interface for Mbox 2: %d\n",iface); + return 1; /* skip altsetting */ + } +#else + /* Use analogue I/O */ + switch (iface) { + case MBOX2_FIRMWARE_INTERFACE: + case MBOX2_CONTROL_INTERFACE: + return 0; + break; + case 2: + if (altno == 3) return 0; else return 1; + break; + case 3: + if (altno == 6) return 0; else return 1; + break; + case 4: + if (altno == 3) return 0; else return 1; + break; + case 5: + if (altno == 3) return 0; else return 1; + break; + case MBOX2_MIDI_INTERFACE: + return 0; + break; + default: + snd_printdd("Invalid interface for Mbox 2: %d\n",iface); + return 1; /* skip altsetting */ + } +#endif +} + /* * audio-interface quirks * @@ -3392,6 +3573,7 @@ static int snd_usb_create_quirk(struct snd_usb_audio *chip, [QUIRK_MIDI_YAMAHA] = snd_usb_create_midi_interface, [QUIRK_MIDI_MIDIMAN] = snd_usb_create_midi_interface, [QUIRK_MIDI_NOVATION] = snd_usb_create_midi_interface, + [QUIRK_MIDI_MBOX2] = snd_usb_create_midi_interface, [QUIRK_MIDI_FASTLANE] = snd_usb_create_midi_interface, [QUIRK_MIDI_EMAGIC] = snd_usb_create_midi_interface, [QUIRK_MIDI_CME] = snd_usb_create_midi_interface, @@ -3425,7 +3607,7 @@ static void proc_audio_usbid_read(struct snd_info_entry *entry, struct snd_info_ { struct snd_usb_audio *chip = entry->private_data; if (!chip->shutdown) - snd_iprintf(buffer, "%04x:%04x\n", + snd_iprintf(buffer, "%04x:%04x\n", USB_ID_VENDOR(chip->usb_id), USB_ID_PRODUCT(chip->usb_id)); } @@ -3616,6 +3798,12 @@ static void *snd_usb_audio_probe(struct usb_device *dev, goto __err_val; } + /* Digidesign Mbox 2 needs magic boot sequence */ + if (id == USB_ID(0x0dba, 0x3000)) { + if (snd_usb_mbox2_boot_quirk(dev) < 0) + goto __err_val; + } + /* * found a config. now register to ALSA */ diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h index 8e7f789..21aab48 100644 --- a/sound/usb/usbaudio.h +++ b/sound/usb/usbaudio.h @@ -157,6 +157,7 @@ enum quirk_type { QUIRK_MIDI_EMAGIC, QUIRK_MIDI_CME, QUIRK_MIDI_US122L, + QUIRK_MIDI_MBOX2, QUIRK_AUDIO_STANDARD_INTERFACE, QUIRK_AUDIO_FIXED_ENDPOINT, QUIRK_AUDIO_EDIROL_UA1000, diff --git a/sound/usb/usbmidi.c b/sound/usb/usbmidi.c index 0eff19c..bc11fe4 100644 --- a/sound/usb/usbmidi.c +++ b/sound/usb/usbmidi.c @@ -423,7 +423,7 @@ static void snd_usbmidi_maudio_broken_running_status_input( u8 cin = buffer[i] & 0x0f; struct usbmidi_in_port *port = &ep->ports[cable]; int length; - + length = snd_usbmidi_cin_length[cin]; if (cin == 0xf && buffer[i + 1] >= 0xf8) ; /* realtime msg: no running status change */ @@ -617,13 +617,13 @@ static struct usb_protocol_ops snd_usbmidi_standard_ops = { static struct usb_protocol_ops snd_usbmidi_midiman_ops = { .input = snd_usbmidi_midiman_input, - .output = snd_usbmidi_standard_output, + .output = snd_usbmidi_standard_output, .output_packet = snd_usbmidi_output_midiman_packet, }; static struct usb_protocol_ops snd_usbmidi_maudio_broken_running_status_ops = { .input = snd_usbmidi_maudio_broken_running_status_input, - .output = snd_usbmidi_standard_output, + .output = snd_usbmidi_standard_output, .output_packet = snd_usbmidi_output_standard_packet, }; @@ -1577,7 +1577,7 @@ static int snd_usbmidi_detect_endpoints(struct snd_usb_midi* umidi, snd_usbmidi_switch_roland_altsetting(umidi); if (endpoint[0].out_ep || endpoint[0].in_ep) - return 0; + return 0; intf = umidi->iface; if (!intf || intf->num_altsetting < 1) @@ -1615,7 +1615,7 @@ static int snd_usbmidi_detect_per_port_endpoints(struct snd_usb_midi* umidi, struct snd_usb_midi_endpoint_info* endpoints) { int err, i; - + err = snd_usbmidi_detect_endpoints(umidi, endpoints, MIDI_MAX_ENDPOINTS); for (i = 0; i < MIDI_MAX_ENDPOINTS; ++i) { if (endpoints[i].out_ep) @@ -1876,6 +1876,18 @@ int snd_usb_create_midi_interface(struct snd_usb_audio* chip, umidi->usb_protocol_ops = &snd_usbmidi_novation_ops; err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints); break; + case QUIRK_MIDI_MBOX2: + /* Digidesign Mbox 2 uses MIDIMAN MIDI protocol */ + umidi->usb_protocol_ops = &snd_usbmidi_midiman_ops; + /* + * We have to make sure that the USB core looks + * again at interface 6 by calling usb_set_interface() on it. + */ + usb_set_interface(umidi->chip->dev, 6, 0); + memcpy(&endpoints[0], quirk->data, + sizeof(struct snd_usb_midi_endpoint_info)); + err = 0; + break; case QUIRK_MIDI_FASTLANE: umidi->usb_protocol_ops = &snd_usbmidi_raw_ops; /* diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h index f6f201e..e961f5e 100644 --- a/sound/usb/usbquirks.h +++ b/sound/usb/usbquirks.h @@ -2082,6 +2082,60 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, +/* DIGIDESIGN MBOX 2 */ +{ + /* Damien Zammit <damien.zammit(a)gmail.com> */ + + USB_DEVICE(0x0dba, 0x3000), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "Digidesign", + .product_name = "Mbox 2", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = (const struct snd_usb_audio_quirk[]) { + { + .ifnum = 0, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 1, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 2, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 3, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 4, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 5, + .type = QUIRK_AUDIO_STANDARD_INTERFACE + }, + { + .ifnum = 6, + .type = QUIRK_MIDI_MBOX2, + .data = & (const struct snd_usb_midi_endpoint_info) { + .out_ep = 0x02, + .out_cables = 0x0001, + .in_ep = 0x81, + .in_interval = 0x01, + .in_cables = 0x0001 + } + + }, + { + .ifnum = -1 + } + } + } +}, + { /* * Some USB MIDI devices don't have an audio control interface, -- 1.5.4.3

2 3

[alsa-devel] ALSA default buffer sizes (recent now being subscribed with correct address... hopefully)
by Manuel Jander 26 Aug '09

26 Aug '09

Hi there, I'm somewhat upset because audacious does not work with my AU8830. The problem is that audacious never calls any function that would give any clue about the desired buffer size. So my AU8830 ends up with 32 periods, 1 byte each. Great ! I'm not going to blame the author of that driver :P ... but: The question is, who is the entity deciding those default values ? Other soundcards seem to get reasonable defaults, but the AU8830 does not. So I would like to fix that, but I want to do that at the right place. Best Regards, and many thanks for any hint.

3 4

[alsa-devel] [PATCH] vwsnd: Fix setting of cfgval and ctlval in li_setup_dma()
by Roel Kluin 26 Aug '09

26 Aug '09

Since !LI_CCFG_* evaluates to 0, this did not change anything to cfgval and ctlval. Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com> --- // vi sound/oss/vwsnd.c +392 # define LI_CCTL_RESET 0x80000000 ... # define LI_CCTL_DMA_ENABLE 0x08000000 ... # define LI_CCFG_LOCK 0x00008000 I am not sure this is what was intended, does anyone have the specs? diff --git a/sound/oss/vwsnd.c b/sound/oss/vwsnd.c index 187f727..6713110 100644 --- a/sound/oss/vwsnd.c +++ b/sound/oss/vwsnd.c @@ -628,7 +628,7 @@ static void li_setup_dma(dma_chan_t *chan, ASSERT(!(buffer_paddr & 0xFF)); chan->baseval = (buffer_paddr >> 8) | 1 << (37 - 8); - chan->cfgval = (!LI_CCFG_LOCK | + chan->cfgval = ((chan->cfgval & ~LI_CCFG_LOCK) | SHIFT_FIELD(desc->ad1843_slot, LI_CCFG_SLOT) | desc->direction | mode | @@ -638,9 +638,9 @@ static void li_setup_dma(dma_chan_t *chan, tmask = 13 - fragshift; /* See Lithium DMA Notes above. */ ASSERT(size >= 2 && size <= 7); ASSERT(tmask >= 1 && tmask <= 7); - chan->ctlval = (!LI_CCTL_RESET | + chan->ctlval = ((chan->ctlval & ~LI_CCTL_RESET) | SHIFT_FIELD(size, LI_CCTL_SIZE) | - !LI_CCTL_DMA_ENABLE | + (chan->ctlval & ~LI_CCTL_DMA_ENABLE) | SHIFT_FIELD(tmask, LI_CCTL_TMASK) | SHIFT_FIELD(0, LI_CCTL_TPTR));

2 1

[alsa-devel] [PATCH 1/4] SOUND: atiixp, use uninitialized_var(chip)
by Jiri Slaby 26 Aug '09

26 Aug '09

To avoid wrong compiler warnings, use unitialized_var(chip) in snd_atiixp_probe's from atiixp and atiixp_modem drivers. 'chip' is unused when unset due to retval being nonzero. Signed-off-by: Jiri Slaby <jirislaby(a)gmail.com> Cc: Takashi Iwai <tiwai(a)suse.de> Cc: Jaroslav Kysela <perex(a)perex.cz> --- sound/pci/atiixp.c | 2 +- sound/pci/atiixp_modem.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c index d6752df..436ffea 100644 --- a/sound/pci/atiixp.c +++ b/sound/pci/atiixp.c @@ -1648,7 +1648,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci, const struct pci_device_id *pci_id) { struct snd_card *card; - struct atiixp *chip; + struct atiixp *uninitialized_var(chip); int err; err = snd_card_create(index, id, THIS_MODULE, 0, &card); diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c index e7e147b..b6191f2 100644 --- a/sound/pci/atiixp_modem.c +++ b/sound/pci/atiixp_modem.c @@ -1285,7 +1285,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci, const struct pci_device_id *pci_id) { struct snd_card *card; - struct atiixp_modem *chip; + struct atiixp_modem *uninitialized_var(chip); int err; err = snd_card_create(index, id, THIS_MODULE, 0, &card); -- 1.6.3.3

2 4

[alsa-devel] alsa random crash
by some guy 26 Aug '09

26 Aug '09

Problem: Alsa randomly crashes after ~10 hours of use; this varies from 2 to 20 hours. Symptoms: Sound stops while media is playing (in web browser, or mplayer), or convulses sporatically. The issue is not always reproducible (i.e I can reproduce the result when I want), but it is perisistant. Info: http://www.alsa-project.org/db/?f=fe434884ea7a16b1ae7c06cfd282832971f41fd6 lspci erhttp://pastebin.ca/1542518 kernel version is gentoo-2.6.28-r5 I really appreciate it. -anonymous alsa'er. _________________________________________________________________ More storage. Better anti-spam and antivirus protection. Hotmail makes it simple. http://go.microsoft.com/?linkid=9671357

1 0

[alsa-devel] [PATCH] ASoC: SDP3430: Fix TWL GPIO6 pin mux request
by Candelaria Villareal, Jorge 25 Aug '09

25 Aug '09

Fix the write to PMBR1 register through I2C. Also, the constant which holds the value to write is now called TWL4030_GPIO6_PWM0_MUTE. This name is based on TRM to avoid confusion. Signed-off-by: Jorge Eduardo Candelaria <x0107209(a)ti.com> --- sound/soc/omap/sdp3430.c | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/soc/omap/sdp3430.c b/sound/soc/omap/sdp3430.c index f7e5b74..4a3f62d 100644 --- a/sound/soc/omap/sdp3430.c +++ b/sound/soc/omap/sdp3430.c @@ -40,8 +40,10 @@ #include "omap-pcm.h" #include "../codecs/twl4030.h" -#define TWL4030_INTBR_PMBR1 0x0D -#define EXTMUTE(value) (value << 2) +/* TWL4030 PMBR1 Register */ +#define TWL4030_INTBR_PMBR1 0x0D +/* TWL4030 PMBR1 Register GPIO6 mux bit */ +#define TWL4030_GPIO6_PWM0_MUTE(value) (value << 2) static struct snd_soc_card snd_soc_sdp3430; @@ -299,6 +301,7 @@ static struct platform_device *sdp3430_snd_device; static int __init sdp3430_soc_init(void) { int ret; + u8 pin_mux; if (!machine_is_omap_3430sdp()) { pr_debug("Not SDP3430!\n"); @@ -318,8 +321,12 @@ static int __init sdp3430_soc_init(void) *(unsigned int *)sdp3430_dai[1].cpu_dai->private_data = 2; /* McBSP3 */ /* Set TWL4030 GPIO6 as EXTMUTE signal */ - twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, EXTMUTE(0x02), - TWL4030_MODULE_INTBR); + twl4030_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux, + TWL4030_INTBR_PMBR1); + pin_mux &= ~TWL4030_GPIO6_PWM0_MUTE(0x03); + pin_mux |= TWL4030_GPIO6_PWM0_MUTE(0x02); + twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux, + TWL4030_INTBR_PMBR1); ret = platform_device_add(sdp3430_snd_device); if (ret) -- 1.6.0.4

2 1

Re: [alsa-devel] Acer Aspire 7730G support
by Denis Kup 25 Aug '09

25 Aug '09

2009/8/25 Takashi Iwai <tiwai(a)suse.de> > BTW, did you check, as I suggested, whether acer-aspire-6530g with > changing the channel mode from 2ch to 6ch works for 7730g? > I guess we can merge acer-aspire-* variants to one or two models. > Can you describe in details what I need to do, please?

1 0

Re: [alsa-devel] Acer Aspire 7730G support
by Takashi Iwai 25 Aug '09

25 Aug '09

At Mon, 24 Aug 2009 19:57:58 +0400, Denis Kup wrote: > > 2009/8/24 Takashi Iwai <tiwai(a)suse.de> > > > At Mon, 24 Aug 2009 17:10:10 +0400, > > Denis Kup wrote: > > > > > > Sorry, I was very busy last two months. We don't finish with this theme. > > > What about my patch? > > > > Please check with the latest sound GIT tree (or alsa-driver snapshot) > > whether it still work and repost the patch. There have been lots of > > changes in HD-audio driver code, so an old patch might not work any > > more. > > > > > > thanks, > > > > Takashi > > > I tested patch with alsa-driver-1.0.20.40.g13311.579.gcf341. All works as it > should. Try rather with the snapshot tarball in ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-sna… The version you tried isn't the latest one. > It's diff between patched version( patch_realtek_new.c ) and unpatched: Make a patch with diff -u option (and better with -p, too). thanks, Takashi

3 5

[alsa-devel] [PATCH] ASoC: SDP3430: Fix TWL GPIO6 pin mux request
by Candelaria Villareal, Jorge 25 Aug '09

25 Aug '09

Fix the write to PMBR1 register through I2C. Also, the constant which holds the value to write is now called TWL4030_GPIO6_PWM0_MUTE. This name is based on TRM to avoid confusion. Signed-off-by: Jorge Eduardo Candelaria <x0107209(a)ti.com> --- sound/soc/omap/sdp3430.c | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/soc/omap/sdp3430.c b/sound/soc/omap/sdp3430.c index f7e5b74..7ad99d2 100644 --- a/sound/soc/omap/sdp3430.c +++ b/sound/soc/omap/sdp3430.c @@ -40,8 +40,10 @@ #include "omap-pcm.h" #include "../codecs/twl4030.h" -#define TWL4030_INTBR_PMBR1 0x0D -#define EXTMUTE(value) (value << 2) +/* TWL4030 PMBR1 Register */ +#define TWL4030_INTBR_PMBR1 0x0D +/* TWL4030 PMBR1 Register GPIO6 mux bit */ +#define TWL4030_GPIO6_PWM0_MUTE(value) (value << 2) static struct snd_soc_card snd_soc_sdp3430; @@ -299,6 +301,7 @@ static struct platform_device *sdp3430_snd_device; static int __init sdp3430_soc_init(void) { int ret; + u8 pin_mux; if (!machine_is_omap_3430sdp()) { pr_debug("Not SDP3430!\n"); @@ -318,8 +321,12 @@ static int __init sdp3430_soc_init(void) *(unsigned int *)sdp3430_dai[1].cpu_dai->private_data = 2; /* McBSP3 */ /* Set TWL4030 GPIO6 as EXTMUTE signal */ - twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, EXTMUTE(0x02), - TWL4030_MODULE_INTBR); + twl4030_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux, + TWL4030_INTBR_PMBR1); + pin_mux &= ~TWL4030_GPIO6_PWM0_MUTE(0x3); + pin_mux |= TWL4030_GPIO6_PWM0_MUTE(0x2); + twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux, + TWL4030_INTBR_PMBR1); ret = platform_device_add(sdp3430_snd_device); if (ret) -- 1.6.0.4

3 4