March 2009 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] Soc-scenario API: news
by Robert Jarzmik 08 Mar '09

08 Mar '09

Hi Mark, I send an update of the proposition for the soc-scenario API 2 weeks ago and no news ... I was wondering if you had received that mail. Just in case, I'll make a copy in this one. Cheers. -- Robert From: Robert Jarzmik <robert.jarzmik(a)free.fr> Subject: Re: [alsa-devel] SoC scenarii API To: Mark Brown <broonie(a)sirena.org.uk> Cc: alsa-devel(a)alsa-project.org, lrg(a)kernel.org Date: Fri, 20 Feb 2009 20:04:24 +0100 X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.2.4 Message-ID: <87vdr5orpj.fsf(a)free.fr> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) Hi Mark, It's been a while since my last post. This is a new proposition for the API. I hope I have not forgotten what has been said previously. As a side note, I'm a bit bothered by your comment about using "snd_ctl_elem_value" instead of integers in structure soc_scen_setup_mix. My concern is about size : snd_ctl_elem_value is huge, and as there will be many mixes/muxes, the memory print will be huge. Can't we deal with only integers for mixers and muxes ? Cheers. -- Robert

1 0

[alsa-devel] [PATCH] CS4270: comments: slave mode is now supported
by Daniel Mack 08 Mar '09

08 Mar '09

Just a minor thing: make the comments reflect the new slave mode feature. Signed-off-by: Daniel Mack <daniel(a)caiaq.de> Cc: Timur Tabi <timur(a)freescale.com> --- sound/soc/codecs/cs4270.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 4c7e546..0558674 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -14,12 +14,11 @@ * * 1) Software mode is supported. Stand-alone mode is not supported. * 2) Only I2C is supported, not SPI - * 3) Only Master mode is supported, not Slave. - * 4) The machine driver's 'startup' function must call + * 3) The machine driver's 'startup' function must call * cs4270_set_dai_sysclk() with the value of MCLK. - * 5) Only I2S and left-justified modes are supported - * 6) Power management is not supported - * 7) The only supported control is volume and hardware mute (if enabled) + * 4) Only I2S and left-justified modes are supported + * 5) Power management is not supported + * 6) The only supported control is volume and hardware mute (if enabled) */ #include <linux/module.h> -- 1.6.1.3

2 4

[PATCH] CS4270: bring feature/limitations list in sync
by Daniel Mack 08 Mar '09

08 Mar '09

Removes numbers from the list of features/limitations and makes it reflect recent changes to the code. Signed-off-by: Daniel Mack <daniel(a)caiaq.de> --- sound/soc/codecs/cs4270.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 4c7e546..d16aa81 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -12,14 +12,13 @@ * * Current features/limitations: * - * 1) Software mode is supported. Stand-alone mode is not supported. - * 2) Only I2C is supported, not SPI - * 3) Only Master mode is supported, not Slave. - * 4) The machine driver's 'startup' function must call - * cs4270_set_dai_sysclk() with the value of MCLK. - * 5) Only I2S and left-justified modes are supported - * 6) Power management is not supported - * 7) The only supported control is volume and hardware mute (if enabled) + * - Software mode is supported. Stand-alone mode is not supported. + * - Only I2C is supported, not SPI + * - Support for master and slave mode + * - The machine driver's 'startup' function must call + * cs4270_set_dai_sysclk() with the value of MCLK. + * - Only I2S and left-justified modes are supported + * - Power management is not supported */ #include <linux/module.h> -- 1.6.1.3

1 0

Re: [alsa-devel] [PATCH 1/1] ALSA: ASoC: Davinci: Fix incorrect machine type for SFFSDR board
by Kevin Hilman 08 Mar '09

08 Mar '09

Hugo Villeneuve <hugo(a)hugovil.com> writes: > Signed-off-by: Hugo Villeneuve <hugo(a)hugovil.com> Signed-off-by: Kevin Hilman <khilman(a)deeprootsystems.com> This has also been pushed to DaVinci git until it get merged into the asoc base. Kevin > --- > sound/soc/davinci/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig > index 7d3a85d..411a710 100644 > --- a/sound/soc/davinci/Kconfig > +++ b/sound/soc/davinci/Kconfig > @@ -21,7 +21,7 @@ config SND_DAVINCI_SOC_EVM > > config SND_DAVINCI_SOC_SFFSDR > tristate "SoC Audio support for SFFSDR" > - depends on SND_DAVINCI_SOC && MACH_DAVINCI_SFFSDR > + depends on SND_DAVINCI_SOC && MACH_SFFSDR > select SND_DAVINCI_SOC_I2S > select SND_SOC_PCM3008 > select SFFSDR_FPGA > -- > 1.5.4.5 > > > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source(a)linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

1 0

Re: [alsa-devel] [PATCH 1/1] ALSA: ASoC: Davinci: Fix incorrect machine type for SFFSDR board
by Kevin Hilman 08 Mar '09

08 Mar '09

Hugo Villeneuve <hugo(a)hugovil.com> writes: > Signed-off-by: Hugo Villeneuve <hugo(a)hugovil.com> > --- > sound/soc/davinci/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig > index 7d3a85d..411a710 100644 > --- a/sound/soc/davinci/Kconfig > +++ b/sound/soc/davinci/Kconfig > @@ -21,7 +21,7 @@ config SND_DAVINCI_SOC_EVM > > config SND_DAVINCI_SOC_SFFSDR > tristate "SoC Audio support for SFFSDR" > - depends on SND_DAVINCI_SOC && MACH_DAVINCI_SFFSDR > + depends on SND_DAVINCI_SOC && MACH_SFFSDR > select SND_DAVINCI_SOC_I2S > select SND_SOC_PCM3008 > select SFFSDR_FPGA Thanks, pushed. Kevin

1 0

[alsa-devel] [PATCH 2.6.30] ASoC: Improve pause/unpause performance in Freescale 8610 drivers
by Timur Tabi 07 Mar '09

07 Mar '09

Add support for true pause and unpause. Without this, mplayer will drop some audio (less than one second, but still noticeable) when pausing playback. Remove support for PM suspend and resume from the trigger function, since the driver doesn't support PM anyway. Optimize the delay after starting capture. Instead of delaying 1ms, the driver now polls the hardware. The new delay is shorter by over 90% yet still effective. Signed-off-by: Timur Tabi <timur(a)freescale.com> --- sound/soc/fsl/fsl_dma.c | 3 ++- sound/soc/fsl/fsl_ssi.c | 23 ++++++++++++++--------- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index 58a3fa4..b3eb857 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -142,7 +142,8 @@ static const struct snd_pcm_hardware fsl_dma_hardware = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | - SNDRV_PCM_INFO_JOINT_DUPLEX, + SNDRV_PCM_INFO_JOINT_DUPLEX | + SNDRV_PCM_INFO_PAUSE, .formats = FSLDMA_PCM_FORMATS, .rates = FSLDMA_PCM_RATES, .rate_min = 5512, diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 8cb6bcf..b7733e6 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -464,28 +464,33 @@ static int fsl_ssi_trigger(struct snd_pcm_substream *substream, int cmd, switch (cmd) { case SNDRV_PCM_TRIGGER_START: - case SNDRV_PCM_TRIGGER_RESUME: + clrbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN); case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { - clrbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN); setbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE); } else { - clrbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN); + long timeout = jiffies + 10; + setbits32(&ssi->scr, CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_RE); - /* - * I think we need this delay to allow time for the SSI - * to put data into its FIFO. Without it, ALSA starts - * to complain about overruns. + /* Wait until the SSI has filled its FIFO. Without this + * delay, ALSA complains about overruns. When the FIFO + * is full, the DMA controller initiates its first + * transfer. Until then, however, the DMA's DAR + * register is zero, which translates to an + * out-of-bounds pointer. This makes ALSA think an + * overrun has occurred. */ - mdelay(1); + while (!(in_be32(&ssi->sisr) & CCSR_SSI_SISR_RFF0) && + (jiffies < timeout)); + if (!(in_be32(&ssi->sisr) & CCSR_SSI_SISR_RFF0)) + return -EIO; } break; case SNDRV_PCM_TRIGGER_STOP: - case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) clrbits32(&ssi->scr, CCSR_SSI_SCR_TE); -- 1.6.1.3

2 1

[alsa-devel] No headphone output on HT Omega Claro Halo
by Christopher J. Atherton 07 Mar '09

07 Mar '09

I have an HT Omega Claro Halo (CMI8878) card that is not entirely working. This card has two analog outputs, a pair of RCA connectors and also a separate headphone output (3.5mm jack). The RCA outputs work, but the headphone output, which notably passes a signal from a built in headphone amp, does not. Interestingly, when I turn up the master volume really high, I can hear pops/cracks on the headphone output. Thanks for any assistance. -- Kristoff

2 3

[alsa-devel] [PATCH 1/1] ALSA: ASoC: Davinci: Fix incorrect machine type for SFFSDR board
by Hugo Villeneuve 06 Mar '09

06 Mar '09

Signed-off-by: Hugo Villeneuve <hugo(a)hugovil.com> --- sound/soc/davinci/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig index 7d3a85d..411a710 100644 --- a/sound/soc/davinci/Kconfig +++ b/sound/soc/davinci/Kconfig @@ -21,7 +21,7 @@ config SND_DAVINCI_SOC_EVM config SND_DAVINCI_SOC_SFFSDR tristate "SoC Audio support for SFFSDR" - depends on SND_DAVINCI_SOC && MACH_DAVINCI_SFFSDR + depends on SND_DAVINCI_SOC && MACH_SFFSDR select SND_DAVINCI_SOC_I2S select SND_SOC_PCM3008 select SFFSDR_FPGA -- 1.5.4.5

2 1

[alsa-devel] ASoC updates for 2.6.30
by Mark Brown 06 Mar '09

06 Mar '09

The following changes since commit 5f2a9384a9291d898b4bf85c4fbf497eef582977: Philipp Zabel (1): ASoC: UDA1380: DATAI is slave only are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.30 Ben Dooks (6): S3C24XX: Move and update IIS headers S3C: Move <mach/audio.h> to <plat/audio.h> ASoC: Add JIVE audio support ASoC: Split s3c2412-i2s.c into core and SoC specific parts ASoC: Add s3c64xx-i2s support ASoC: Select DMA if I2S is configured Daniel Mack (2): ASoC: Fix name of register bit in pxa-ssp ASoC: add two more bitfields for PXA SSP Jonas Andersson (1): ASoC: wm8510 pll settings Lopez Cruz, Misael (3): ASoC: Add GPIO support for jack reporting interface ASoC: Add DAPM machine widgets to SDP3430 driver ASoC: Add headset jack detection for SDP3430 machine driver Mark Brown (5): ASoC: Refresh JIVE driver ASoC: Factor out DAPM widget power check into separate function ASoC: Fix memory allocation for snd_soc_dapm_switch names ASoC: Update Kconfig for Samsung CPUs to reflect S3C64xx support ASoC: Staticise workqueue function for GPIO jack detection Mike Frysinger (2): ASoC: Blackfin: move gpio_err behind the define that is only user of it ASoC: Blackfin: fix typo in MUTE definition Peter Ujfalusi (1): ASoC: TWL4030: Make the HS ramp delay configurable Timur Tabi (1): ASoC: add support for SSI asynchronous mode to the Freescale SSI drivers arch/arm/mach-pxa/include/mach/regs-ssp.h | 7 +- arch/arm/mach-s3c2410/dma.c | 2 +- arch/arm/mach-s3c2410/include/mach/hardware.h | 3 - arch/arm/mach-s3c2410/include/mach/io.h | 2 +- arch/arm/mach-s3c2412/dma.c | 4 +- arch/arm/mach-s3c2440/dma.c | 2 +- arch/arm/mach-s3c2443/dma.c | 2 +- arch/arm/mach-shark/include/mach/io.h | 2 +- .../include/mach => plat-s3c/include/plat}/audio.h | 0 .../arm/plat-s3c/include/plat}/regs-s3c2412-iis.h | 3 + arch/arm/plat-s3c24xx/clock-dclk.c | 1 + .../arm/plat-s3c24xx/include/plat}/regs-iis.h | 0 include/sound/soc.h | 32 + sound/soc/atmel/playpaq_wm8510.c | 24 +- sound/soc/blackfin/bf5xx-ac97.c | 2 +- sound/soc/codecs/ad73311.h | 2 +- sound/soc/codecs/twl4030.c | 18 +- sound/soc/codecs/wm8510.c | 4 +- sound/soc/fsl/fsl_ssi.c | 42 +- sound/soc/fsl/fsl_ssi.h | 2 + sound/soc/fsl/mpc8610_hpcd.c | 5 + sound/soc/omap/sdp3430.c | 105 ++++- sound/soc/pxa/pxa-ssp.c | 6 +- sound/soc/s3c24xx/Kconfig | 29 +- sound/soc/s3c24xx/Makefile | 6 + sound/soc/s3c24xx/jive_wm8750.c | 201 ++++++ sound/soc/s3c24xx/neo1973_wm8753.c | 4 +- sound/soc/s3c24xx/s3c-i2s-v2.c | 645 ++++++++++++++++++++ sound/soc/s3c24xx/s3c-i2s-v2.h | 90 +++ sound/soc/s3c24xx/s3c2412-i2s.c | 604 +------------------ sound/soc/s3c24xx/s3c2412-i2s.h | 17 +- sound/soc/s3c24xx/s3c2443-ac97.c | 2 +- sound/soc/s3c24xx/s3c24xx-i2s.c | 4 +- sound/soc/s3c24xx/s3c24xx-pcm.c | 2 +- sound/soc/s3c24xx/s3c24xx_uda134x.c | 2 +- sound/soc/s3c24xx/s3c64xx-i2s.c | 220 +++++++ sound/soc/s3c24xx/s3c64xx-i2s.h | 31 + sound/soc/soc-dapm.c | 265 +++++---- sound/soc/soc-jack.c | 129 ++++ 39 files changed, 1745 insertions(+), 776 deletions(-) rename arch/arm/{mach-s3c2410/include/mach => plat-s3c/include/plat}/audio.h (100%) rename {include/asm-arm/plat-s3c24xx => arch/arm/plat-s3c/include/plat}/regs-s3c2412-iis.h (96%) rename {include/asm-arm/plat-s3c24xx => arch/arm/plat-s3c24xx/include/plat}/regs-iis.h (100%) create mode 100644 sound/soc/s3c24xx/jive_wm8750.c create mode 100644 sound/soc/s3c24xx/s3c-i2s-v2.c create mode 100644 sound/soc/s3c24xx/s3c-i2s-v2.h create mode 100644 sound/soc/s3c24xx/s3c64xx-i2s.c create mode 100644 sound/soc/s3c24xx/s3c64xx-i2s.h

3 3

[alsa-devel] [PATCH] ASoC: add support for SSI asynchronous mode to the Freescale SSI drivers
by Timur Tabi 06 Mar '09

06 Mar '09

Add a new device tree property for the SSI node: "fsl,ssi-asynchronous". If defined, the SSI is programmed into asynchronous mode, otherwise it is programmed into synchronous mode. In asynchronous mode, pin SRCK must be connected to the same clock source as STFS, and pin SRFS must be connected to the same signal as STFS. Asynchronous mode allows playback and capture to use different sample sizes. It also technically allows different sample rates, but the driver does not support that. Signed-off-by: Timur Tabi <timur(a)freescale.com> --- sound/soc/fsl/fsl_ssi.c | 42 ++++++++++++++++++++++++++++++++---------- sound/soc/fsl/fsl_ssi.h | 2 ++ sound/soc/fsl/mpc8610_hpcd.c | 5 +++++ 3 files changed, 39 insertions(+), 10 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 6844009..8cb6bcf 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -72,6 +72,7 @@ * @dev: struct device pointer * @playback: the number of playback streams opened * @capture: the number of capture streams opened + * @asynchronous: 0=synchronous mode, 1=asynchronous mode * @cpu_dai: the CPU DAI for this device * @dev_attr: the sysfs device attribute structure * @stats: SSI statistics @@ -86,6 +87,7 @@ struct fsl_ssi_private { struct device *dev; unsigned int playback; unsigned int capture; + int asynchronous; struct snd_soc_dai cpu_dai; struct device_attribute dev_attr; @@ -301,9 +303,10 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream, * * FIXME: Little-endian samples require a different shift dir */ - clrsetbits_be32(&ssi->scr, CCSR_SSI_SCR_I2S_MODE_MASK, - CCSR_SSI_SCR_TFR_CLK_DIS | - CCSR_SSI_SCR_I2S_MODE_SLAVE | CCSR_SSI_SCR_SYN); + clrsetbits_be32(&ssi->scr, + CCSR_SSI_SCR_I2S_MODE_MASK | CCSR_SSI_SCR_SYN, + CCSR_SSI_SCR_TFR_CLK_DIS | CCSR_SSI_SCR_I2S_MODE_SLAVE + | (ssi_private->asynchronous ? 0 : CCSR_SSI_SCR_SYN)); out_be32(&ssi->stcr, CCSR_SSI_STCR_TXBIT0 | CCSR_SSI_STCR_TFEN0 | @@ -382,10 +385,15 @@ static int fsl_ssi_startup(struct snd_pcm_substream *substream, SNDRV_PCM_HW_PARAM_RATE, first_runtime->rate, first_runtime->rate); - snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_SAMPLE_BITS, - first_runtime->sample_bits, - first_runtime->sample_bits); + /* If we're in synchronous mode, then we need to constrain + * the sample size as well. We don't support independent sample + * rates in asynchronous mode. + */ + if (!ssi_private->asynchronous) + snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_SAMPLE_BITS, + first_runtime->sample_bits, + first_runtime->sample_bits); ssi_private->second_stream = substream; } @@ -421,13 +429,18 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream, struct ccsr_ssi __iomem *ssi = ssi_private->ssi; unsigned int sample_size = snd_pcm_format_width(params_format(hw_params)); - u32 wl; + u32 wl = CCSR_SSI_SxCCR_WL(sample_size); /* The SSI should always be disabled at this points (SSIEN=0) */ - wl = CCSR_SSI_SxCCR_WL(sample_size); /* In synchronous mode, the SSI uses STCCR for capture */ - clrsetbits_be32(&ssi->stccr, CCSR_SSI_SxCCR_WL_MASK, wl); + if ((substream->stream == SNDRV_PCM_STREAM_PLAYBACK) || + !ssi_private->asynchronous) + clrsetbits_be32(&ssi->stccr, + CCSR_SSI_SxCCR_WL_MASK, wl); + else + clrsetbits_be32(&ssi->srccr, + CCSR_SSI_SxCCR_WL_MASK, wl); } return 0; @@ -653,6 +666,7 @@ struct snd_soc_dai *fsl_ssi_create_dai(struct fsl_ssi_info *ssi_info) ssi_private->ssi_phys = ssi_info->ssi_phys; ssi_private->irq = ssi_info->irq; ssi_private->dev = ssi_info->dev; + ssi_private->asynchronous = ssi_info->asynchronous; ssi_private->dev->driver_data = fsl_ssi_dai; @@ -703,6 +717,14 @@ void fsl_ssi_destroy_dai(struct snd_soc_dai *fsl_ssi_dai) } EXPORT_SYMBOL_GPL(fsl_ssi_destroy_dai); +static int __init fsl_ssi_init(void) +{ + printk(KERN_INFO "Freescale Synchronous Serial Interface (SSI) ASoC Driver\n"); + + return 0; +} +module_init(fsl_ssi_init); + MODULE_AUTHOR("Timur Tabi <timur(a)freescale.com>"); MODULE_DESCRIPTION("Freescale Synchronous Serial Interface (SSI) ASoC Driver"); MODULE_LICENSE("GPL"); diff --git a/sound/soc/fsl/fsl_ssi.h b/sound/soc/fsl/fsl_ssi.h index 83b44d7..eade01f 100644 --- a/sound/soc/fsl/fsl_ssi.h +++ b/sound/soc/fsl/fsl_ssi.h @@ -208,6 +208,7 @@ struct ccsr_ssi { * ssi_phys: physical address of the SSI registers * irq: IRQ of this SSI * dev: struct device, used to create the sysfs statistics file + * asynchronous: 0=synchronous mode, 1=asynchronous mode */ struct fsl_ssi_info { unsigned int id; @@ -215,6 +216,7 @@ struct fsl_ssi_info { dma_addr_t ssi_phys; unsigned int irq; struct device *dev; + int asynchronous; }; struct snd_soc_dai *fsl_ssi_create_dai(struct fsl_ssi_info *ssi_info); diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index acf39a6..ef67d1c 100644 --- a/sound/soc/fsl/mpc8610_hpcd.c +++ b/sound/soc/fsl/mpc8610_hpcd.c @@ -353,6 +353,11 @@ static int mpc8610_hpcd_probe(struct of_device *ofdev, } ssi_info.irq = machine_data->ssi_irq; + /* Do we want to use asynchronous mode? */ + ssi_info.asynchronous = + of_find_property(np, "fsl,ssi-asynchronous", NULL) ? 1 : 0; + if (ssi_info.asynchronous) + dev_info(&ofdev->dev, "using asynchronous mode\n"); /* Map the global utilities registers. */ guts_np = of_find_compatible_node(NULL, NULL, "fsl,mpc8610-guts"); -- 1.6.1.3

2 1