November 2009 - Alsa-devel - mailman.alsa-project.org

Re: [alsa-devel] Artifacts present in AIC23 capture for 48 KHz sampling rate
by Aggarwal, Anuj 18 Nov '09

18 Nov '09

> -----Original Message----- > From: Aggarwal, Anuj > Sent: Friday, November 06, 2009 6:28 PM > To: alsa-devel(a)alsa-project.org; 'linux-omap(a)vger.kernel.org' > Subject: Artifacts present in AIC23 capture for 48 KHz sampling rate > > Hi, > > I am observing artifacts (sharp spikes at fixed intervals) while > capturing audio on AM3517 EVM and AIC23 codec. They are present only > in one of the channels when I am capturing at 48 KHz. All other > sampling rates are working fine with the above said combination. > > I have also attached the screenshot taken with the help of Audacity > utility. Here, I tried recording silence but artifacts were observed > on one channel. > > Has anyone also observed the similar behavior with AIC23 codec? Any > hints on what could be the root cause? [Aggarwal, Anuj] On further debugging, I found that the function find_rate() in sound/soc/codecs/tlv320aic23.c is not returning the correct value for capture in 48KHz sample rate. In USB mode (MCLK=12MHz), for 48KHz, it returns 0x7D (CLKOUT=0, CLKIN=1, SR[3:0]=0xF, BOSR=1, Normal=1) whereas as per the AIC23B spec, it should have been 0x5D (CLKOUT=0, CLKIN=1, SR[3:0]=0x7, BOSR=1, Normal=1). When I forcefully write the above said value to the Sample Rate Control register, things work fine for me for 48KHz capture. Is my understanding correct for this problem? Can someone help me understand how the function calculates the appropriate value? > > Regards, > Anuj Aggarwal

3 4

Re: [alsa-devel] [PATCH (for-next 2)] ASoC: Add support for IGEP v2
by Mike Rapoport 18 Nov '09

18 Nov '09

(adding ALSA mailing list to CC again :) ) Enric Balletbo i Serra wrote: > From: Enric Balletbo i Serra <eballetbo(a)iseebcn.com> > > > Signed-off-by: Enric Balletbo i Serra <eballetbo(a)iseebcn.com> > --- > sound/soc/omap/Kconfig | 7 ++ > sound/soc/omap/Makefile | 2 + > sound/soc/omap/igep0020.c | 148 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 157 insertions(+), 0 deletions(-) > create mode 100644 sound/soc/omap/igep0020.c > > diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig > index 653a362..5cc8a63 100644 > --- a/sound/soc/omap/Kconfig > +++ b/sound/soc/omap/Kconfig > @@ -99,3 +99,10 @@ config SND_OMAP_SOC_ZOOM2 > help > Say Y if you want to add support for Soc audio on Zoom2 board. > > +config SND_OMAP_SOC_IGEP0020 > + tristate "SoC Audio support for IGEP v2" > + depends on TWL4030_CORE && SND_OMAP_SOC && MACH_IGEP0020 > + select SND_OMAP_SOC_MCBSP > + select SND_SOC_TWL4030 > + help > + Say Y if you want to add support for Soc audio on IGEP v2 board. > diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile > index 02d6947..d4ed23a 100644 > --- a/sound/soc/omap/Makefile > +++ b/sound/soc/omap/Makefile > @@ -16,6 +16,7 @@ snd-soc-sdp3430-objs := sdp3430.o > snd-soc-omap3pandora-objs := omap3pandora.o > snd-soc-omap3beagle-objs := omap3beagle.o > snd-soc-zoom2-objs := zoom2.o > +snd-soc-igep0020-objs := igep0020.o > > obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o > obj-$(CONFIG_SND_OMAP_SOC_AMS_DELTA) += snd-soc-ams-delta.o > @@ -27,3 +28,4 @@ obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o > obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o > obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o > obj-$(CONFIG_SND_OMAP_SOC_ZOOM2) += snd-soc-zoom2.o > +obj-$(CONFIG_SND_OMAP_SOC_IGEP0020) += snd-soc-igep0020.o > diff --git a/sound/soc/omap/igep0020.c b/sound/soc/omap/igep0020.c > new file mode 100644 > index 0000000..3583c42 > --- /dev/null > +++ b/sound/soc/omap/igep0020.c > @@ -0,0 +1,148 @@ > +/* > + * igep0020.c -- SoC audio for IGEP v2 > + * > + * Based on sound/soc/omap/overo.c by Steve Sakoman > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA > + * > + */ > + > +#include <linux/clk.h> > +#include <linux/platform_device.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/soc.h> > +#include <sound/soc-dapm.h> > + > +#include <asm/mach-types.h> > +#include <mach/hardware.h> > +#include <mach/gpio.h> > +#include <plat/mcbsp.h> > + > +#include "omap-mcbsp.h" > +#include "omap-pcm.h" > +#include "../codecs/twl4030.h" > + > +static int igep2_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct snd_soc_dai *codec_dai = rtd->dai->codec_dai; > + struct snd_soc_dai *cpu_dai = rtd->dai->cpu_dai; > + int ret; > + > + /* Set codec DAI configuration */ > + ret = snd_soc_dai_set_fmt(codec_dai, > + SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_CBM_CFM); > + if (ret < 0) { > + printk(KERN_ERR "can't set codec DAI configuration\n"); > + return ret; > + } > + > + /* Set cpu DAI configuration */ > + ret = snd_soc_dai_set_fmt(cpu_dai, > + SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_CBM_CFM); > + if (ret < 0) { > + printk(KERN_ERR "can't set cpu DAI configuration\n"); > + return ret; > + } > + > + /* Set the codec system clock for DAC and ADC */ > + ret = snd_soc_dai_set_sysclk(codec_dai, 0, 26000000, > + SND_SOC_CLOCK_IN); > + if (ret < 0) { > + printk(KERN_ERR "can't set codec system clock\n"); > + return ret; > + } > + > + return 0; > +} > + > +static struct snd_soc_ops igep2_ops = { > + .hw_params = igep2_hw_params, > +}; > + > +/* Digital audio interface glue - connects codec <--> CPU */ > +static struct snd_soc_dai_link igep2_dai = { > + .name = "TWL4030", > + .stream_name = "TWL4030", > + .cpu_dai = &omap_mcbsp_dai[0], > + .codec_dai = &twl4030_dai[TWL4030_DAI_HIFI], > + .ops = &igep2_ops, > +}; > + > +/* Audio machine driver */ > +static struct snd_soc_card snd_soc_card_igep2 = { > + .name = "igep2", > + .platform = &omap_soc_platform, > + .dai_link = &igep2_dai, > + .num_links = 1, > +}; > + > +/* Audio subsystem */ > +static struct snd_soc_device igep2_snd_devdata = { > + .card = &snd_soc_card_igep2, > + .codec_dev = &soc_codec_dev_twl4030, > +}; > + > +static struct platform_device *igep2_snd_device; > + > +static int __init igep2_soc_init(void) > +{ > + int ret; > + > + if (!machine_is_igep0020()) { > + pr_debug("Not IGEP v2!\n"); > + return -ENODEV; > + } > + printk(KERN_INFO "IGEP v2 SoC init\n"); > + > + igep2_snd_device = platform_device_alloc("soc-audio", -1); > + if (!igep2_snd_device) { > + printk(KERN_ERR "Platform device allocation failed\n"); > + return -ENOMEM; > + } > + > + platform_set_drvdata(igep2_snd_device, &igep2_snd_devdata); > + igep2_snd_devdata.dev = &igep2_snd_device->dev; > + *(unsigned int *)igep2_dai.cpu_dai->private_data = 1; /* McBSP2 */ > + > + ret = platform_device_add(igep2_snd_device); > + if (ret) > + goto err1; > + > + return 0; > + > +err1: > + printk(KERN_ERR "Unable to add platform device\n"); > + platform_device_put(igep2_snd_device); > + > + return ret; > +} > +module_init(igep2_soc_init); > + > +static void __exit igep2_soc_exit(void) > +{ > + platform_device_unregister(igep2_snd_device); > +} > +module_exit(igep2_soc_exit); > + > +MODULE_AUTHOR("Enric Balletbo i Serra <eballetbo(a)iseebcn.com>"); > +MODULE_DESCRIPTION("ALSA SoC IGEP v2"); > +MODULE_LICENSE("GPL"); -- Sincerely yours, Mike.

2 1

[alsa-devel] [PATCH] ASoC: OMAP3 Pandora: update for TWL4030 codec changes
by Grazvydas Ignotas 18 Nov '09

18 Nov '09

A while ago TWL4030 had it's playback stream name changed, but pandora needs it for it's playback path. Update to correct stream name so that playback works again. Also mark VIBRA output as not connected. Signed-off-by: Grazvydas Ignotas <notasas(a)gmail.com> --- sound/soc/omap/omap3pandora.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c index ad219aa..0cd06f5 100644 --- a/sound/soc/omap/omap3pandora.c +++ b/sound/soc/omap/omap3pandora.c @@ -134,7 +134,7 @@ static int omap3pandora_hp_event(struct snd_soc_dapm_widget *w, * |P| <--- TWL4030 <--------- Line In and MICs */ static const struct snd_soc_dapm_widget omap3pandora_out_dapm_widgets[] = { - SND_SOC_DAPM_DAC("PCM DAC", "Playback", SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_DAC("PCM DAC", "HiFi Playback", SND_SOC_NOPM, 0, 0), SND_SOC_DAPM_PGA_E("Headphone Amplifier", SND_SOC_NOPM, 0, 0, NULL, 0, omap3pandora_hp_event, SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD), @@ -181,6 +181,7 @@ static int omap3pandora_out_init(struct snd_soc_codec *codec) snd_soc_dapm_nc_pin(codec, "CARKITR"); snd_soc_dapm_nc_pin(codec, "HFL"); snd_soc_dapm_nc_pin(codec, "HFR"); + snd_soc_dapm_nc_pin(codec, "VIBRA"); ret = snd_soc_dapm_new_controls(codec, omap3pandora_out_dapm_widgets, ARRAY_SIZE(omap3pandora_out_dapm_widgets)); -- 1.5.6.3

3 4

[alsa-devel] [PATCH 2/2] ASoC: Modifying the license string GPLv2 for OMAP3 EVM
by Anuj Aggarwal 18 Nov '09

18 Nov '09

Correcting the license string from GPLv2 -> GPL v2. Found the problem while building OMAP3 ASoC driver as module. Signed-off-by: Anuj Aggarwal <anuj.aggarwal(a)ti.com> --- sound/soc/omap/omap3evm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/omap/omap3evm.c b/sound/soc/omap/omap3evm.c index 41a91b5..627fadb 100644 --- a/sound/soc/omap/omap3evm.c +++ b/sound/soc/omap/omap3evm.c @@ -144,4 +144,4 @@ module_exit(omap3evm_soc_exit); MODULE_AUTHOR("Anuj Aggarwal <anuj.aggarwal(a)ti.com>"); MODULE_DESCRIPTION("ALSA SoC OMAP3 EVM"); -MODULE_LICENSE("GPLv2"); +MODULE_LICENSE("GPL v2"); -- 1.6.2.4

1 0

[alsa-devel] Status of ALSA support for MacBook Pro 5, 2 in kernel 2.6.32
by Adolf Winterer 18 Nov '09

18 Nov '09

Hello, there had been a lot of messages here on the list and in other internet sources about patches to snd-hda-intel regarding the sound support for MacBook Pro 5,1 and MacBook Pro 5,2. But the situation is far from being clear. Some sources stated that the patches for the MacBook Pro 5,1 would support the MacBook Pro 5,2 as well, others disagreed. Recently on this list I've seen efforts to integrate the current ALSA 1.0.21+x into kernel 2.6.32. Fact is that with kernel 2.6.30-2, which has ALSA 1.0.20, from Debian testing my MacBook Pro 5,2 is not working. There is no sound at all. Compilation of ALSA sources 1.0.21 using the module assistant fails with an error message regarding a missing curly bracket. There is a bug report in the Debian bug tracker regarding this, but no progress is visible. Compiling the sources directly using the 1.0.21 sources from the ALSA project page goes through, but the resulting modules do not load, give an error message about an unknown symbol. Therefore I was not able to find out if ALSA 1.0.21 supports the MacBook Pro 5,2. Please, can anyone of the development team help with a statement clearing up things by answering the following questions? * Will the support for the MacBook Pro 5,2 be part of the soon to be released kernel 2.6.32? * Or is it already present in kernel 2.6.31? * What is the correct parameter for the loading of the module? Is it just "auto" or "mb5"? Or anything else? Your help is greatly appreciated. Best regards, Adolf

2 1

[alsa-devel] [PATCH 00/10] Intel HDMI fixes v2
by Wu Fengguang 18 Nov '09

18 Nov '09

Takashi, Here are the updated Intel HDMI fixes. Thanks, Fengguang

2 14

Re: [alsa-devel] [PATCH (for-next)] ASoC: Add support for IGEP v2
by Mike Rapoport 18 Nov '09

18 Nov '09

(adding ALSA list to CC) Enric Balletbo i Serra wrote: > From: Enric Balletbo i Serra <eballetbo(a)iseebcn.com> > > > Signed-off-by: Enric Balletbo i Serra <eballetbo(a)iseebcn.com> > --- > arch/arm/mach-omap2/Kconfig | 2 +- > sound/soc/omap/Kconfig | 7 ++ > sound/soc/omap/Makefile | 2 + > sound/soc/omap/igep0020.c | 148 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 158 insertions(+), 1 deletions(-) > create mode 100644 sound/soc/omap/igep0020.c > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 68866f3..6922198 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -114,7 +114,7 @@ config MACH_OMAP_3630SDP > depends on ARCH_OMAP3 && ARCH_OMAP34XX > > config MACH_IGEP0020 > - bool "IGEP0020" > + bool "IGEP v2 board" > depends on ARCH_OMAP3 && ARCH_OMAP34XX > > config MACH_OMAP_4430SDP > diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig > index 653a362..5cc8a63 100644 > --- a/sound/soc/omap/Kconfig > +++ b/sound/soc/omap/Kconfig > @@ -99,3 +99,10 @@ config SND_OMAP_SOC_ZOOM2 > help > Say Y if you want to add support for Soc audio on Zoom2 board. > > +config SND_OMAP_SOC_IGEP0020 > + tristate "SoC Audio support for IGEP v2" > + depends on TWL4030_CORE && SND_OMAP_SOC && MACH_IGEP0020 > + select SND_OMAP_SOC_MCBSP > + select SND_SOC_TWL4030 > + help > + Say Y if you want to add support for Soc audio on IGEP v2 board. > diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile > index 02d6947..d4ed23a 100644 > --- a/sound/soc/omap/Makefile > +++ b/sound/soc/omap/Makefile > @@ -16,6 +16,7 @@ snd-soc-sdp3430-objs := sdp3430.o > snd-soc-omap3pandora-objs := omap3pandora.o > snd-soc-omap3beagle-objs := omap3beagle.o > snd-soc-zoom2-objs := zoom2.o > +snd-soc-igep0020-objs := igep0020.o > > obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o > obj-$(CONFIG_SND_OMAP_SOC_AMS_DELTA) += snd-soc-ams-delta.o > @@ -27,3 +28,4 @@ obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o > obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o > obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o > obj-$(CONFIG_SND_OMAP_SOC_ZOOM2) += snd-soc-zoom2.o > +obj-$(CONFIG_SND_OMAP_SOC_IGEP0020) += snd-soc-igep0020.o > diff --git a/sound/soc/omap/igep0020.c b/sound/soc/omap/igep0020.c > new file mode 100644 > index 0000000..3583c42 > --- /dev/null > +++ b/sound/soc/omap/igep0020.c > @@ -0,0 +1,148 @@ > +/* > + * igep0020.c -- SoC audio for IGEP v2 > + * > + * Based on sound/soc/omap/overo.c by Steve Sakoman > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA > + * > + */ > + > +#include <linux/clk.h> > +#include <linux/platform_device.h> > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/soc.h> > +#include <sound/soc-dapm.h> > + > +#include <asm/mach-types.h> > +#include <mach/hardware.h> > +#include <mach/gpio.h> > +#include <plat/mcbsp.h> > + > +#include "omap-mcbsp.h" > +#include "omap-pcm.h" > +#include "../codecs/twl4030.h" > + > +static int igep2_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params) > +{ > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > + struct snd_soc_dai *codec_dai = rtd->dai->codec_dai; > + struct snd_soc_dai *cpu_dai = rtd->dai->cpu_dai; > + int ret; > + > + /* Set codec DAI configuration */ > + ret = snd_soc_dai_set_fmt(codec_dai, > + SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_CBM_CFM); > + if (ret < 0) { > + printk(KERN_ERR "can't set codec DAI configuration\n"); > + return ret; > + } > + > + /* Set cpu DAI configuration */ > + ret = snd_soc_dai_set_fmt(cpu_dai, > + SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_CBM_CFM); > + if (ret < 0) { > + printk(KERN_ERR "can't set cpu DAI configuration\n"); > + return ret; > + } > + > + /* Set the codec system clock for DAC and ADC */ > + ret = snd_soc_dai_set_sysclk(codec_dai, 0, 26000000, > + SND_SOC_CLOCK_IN); > + if (ret < 0) { > + printk(KERN_ERR "can't set codec system clock\n"); > + return ret; > + } > + > + return 0; > +} > + > +static struct snd_soc_ops igep2_ops = { > + .hw_params = igep2_hw_params, > +}; > + > +/* Digital audio interface glue - connects codec <--> CPU */ > +static struct snd_soc_dai_link igep2_dai = { > + .name = "TWL4030", > + .stream_name = "TWL4030", > + .cpu_dai = &omap_mcbsp_dai[0], > + .codec_dai = &twl4030_dai[TWL4030_DAI_HIFI], > + .ops = &igep2_ops, > +}; > + > +/* Audio machine driver */ > +static struct snd_soc_card snd_soc_card_igep2 = { > + .name = "igep2", > + .platform = &omap_soc_platform, > + .dai_link = &igep2_dai, > + .num_links = 1, > +}; > + > +/* Audio subsystem */ > +static struct snd_soc_device igep2_snd_devdata = { > + .card = &snd_soc_card_igep2, > + .codec_dev = &soc_codec_dev_twl4030, > +}; > + > +static struct platform_device *igep2_snd_device; > + > +static int __init igep2_soc_init(void) > +{ > + int ret; > + > + if (!machine_is_igep0020()) { > + pr_debug("Not IGEP v2!\n"); > + return -ENODEV; > + } > + printk(KERN_INFO "IGEP v2 SoC init\n"); > + > + igep2_snd_device = platform_device_alloc("soc-audio", -1); > + if (!igep2_snd_device) { > + printk(KERN_ERR "Platform device allocation failed\n"); > + return -ENOMEM; > + } > + > + platform_set_drvdata(igep2_snd_device, &igep2_snd_devdata); > + igep2_snd_devdata.dev = &igep2_snd_device->dev; > + *(unsigned int *)igep2_dai.cpu_dai->private_data = 1; /* McBSP2 */ > + > + ret = platform_device_add(igep2_snd_device); > + if (ret) > + goto err1; > + > + return 0; > + > +err1: > + printk(KERN_ERR "Unable to add platform device\n"); > + platform_device_put(igep2_snd_device); > + > + return ret; > +} > +module_init(igep2_soc_init); > + > +static void __exit igep2_soc_exit(void) > +{ > + platform_device_unregister(igep2_snd_device); > +} > +module_exit(igep2_soc_exit); > + > +MODULE_AUTHOR("Enric Balletbo i Serra <eballetbo(a)iseebcn.com>"); > +MODULE_DESCRIPTION("ALSA SoC IGEP v2"); > +MODULE_LICENSE("GPL"); -- Sincerely yours, Mike.

3 2

[alsa-devel] [patch] remove unnecessary null check
by Dan Carpenter 18 Nov '09

18 Nov '09

This function is only called from snd_ctl_ioctl() and the file parameter can never be null so there is no need to check it here. We dereference file at the start of the function: struct snd_card *card = file->card; and it confuses static checkers to dereference a pointer before checking it. regards, dan carpenter Signed-off-by: Dan Carpenter <error27(a)gmail.com> --- orig/sound/core/control.c 2009-11-17 07:15:04.000000000 +0200 +++ devel/sound/core/control.c 2009-11-17 07:40:30.000000000 +0200 @@ -1120,7 +1120,7 @@ goto __kctl_end; } if (vd->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) { - if (file && vd->owner != NULL && vd->owner != file) { + if (vd->owner != NULL && vd->owner != file) { err = -EPERM; goto __kctl_end; }

2 1

[alsa-devel] [patch] move dereference after null check
by Dan Carpenter 18 Nov '09

18 Nov '09

The 'jack' variable was dereference before the NULL check so this patch moves the dereference later. regards, dan carpenter Signed-off-by: Dan Carpenter <error27(a)gmail.com> --- orig/sound/soc/soc-jack.c 2009-11-14 11:04:04.000000000 +0200 +++ devel/sound/soc/soc-jack.c 2009-11-14 11:05:01.000000000 +0200 @@ -58,7 +58,7 @@ */ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) { - struct snd_soc_codec *codec = jack->card->codec; + struct snd_soc_codec *codec; struct snd_soc_jack_pin *pin; int enable; int oldstatus; @@ -67,6 +67,7 @@ WARN_ON_ONCE(!jack); return; } + codec = jack->card->codec; mutex_lock(&codec->mutex);

4 4

[alsa-devel] [PATCH] opti-miro: use variables directly in the probe function
by Krzysztof Helt 18 Nov '09

18 Nov '09

From: Krzysztof Helt <krzysztof.h1(a)wp.pl> Use the fm_port and mpu_port variables directly in a probe function. This completely eliminates a need to copy the fm_port value to the snd_miro structure. Signed-off-by: Krzysztof Helt <krzysztof.h1(a)wp.pl> --- sound/isa/opti9xx/miro.c | 33 +++++++++++++++++---------------- 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/sound/isa/opti9xx/miro.c b/sound/isa/opti9xx/miro.c index 02e30d7..b8170ad 100644 --- a/sound/isa/opti9xx/miro.c +++ b/sound/isa/opti9xx/miro.c @@ -118,8 +118,6 @@ struct snd_miro { int dma1; int dma2; - long fm_port; - long mpu_port; int mpu_irq; @@ -757,7 +755,6 @@ static int __devinit snd_miro_init(struct snd_miro *chip, chip->irq = -1; chip->dma1 = -1; chip->dma2 = -1; - chip->fm_port = -1; chip->mpu_port = -1; chip->mpu_irq = -1; @@ -1261,7 +1258,6 @@ static int __devinit snd_miro_probe(struct device *devptr, unsigned int n) } miro->wss_base = port; - miro->fm_port = fm_port; miro->mpu_port = mpu_port; miro->irq = irq; miro->mpu_irq = mpu_irq; @@ -1276,11 +1272,12 @@ static int __devinit snd_miro_probe(struct device *devptr, unsigned int n) } } - if (miro->mpu_port == SNDRV_AUTO_PORT) { - if ((miro->mpu_port = snd_legacy_find_free_ioport(possible_mpu_ports, 2)) < 0) { + if (mpu_port == SNDRV_AUTO_PORT) { + mpu_port = snd_legacy_find_free_ioport(possible_mpu_ports, 2); + if (mpu_port < 0) { snd_card_free(card); snd_printk(KERN_ERR "unable to find a free MPU401 port\n"); - return -EBUSY; + return -EBUSY } } if (miro->irq == SNDRV_AUTO_IRQ) { @@ -1380,20 +1377,24 @@ static int __devinit snd_miro_probe(struct device *devptr, unsigned int n) card->shortname, miro->name, pcm->name, miro->wss_base + 4, miro->irq, miro->dma1, miro->dma2); - if (miro->mpu_port <= 0 || miro->mpu_port == SNDRV_AUTO_PORT) + if (mpu_port <= 0 || mpu_port == SNDRV_AUTO_PORT) rmidi = NULL; - else - if ((error = snd_mpu401_uart_new(card, 0, MPU401_HW_MPU401, - miro->mpu_port, 0, miro->mpu_irq, IRQF_DISABLED, - &rmidi))) - snd_printk(KERN_WARNING "no MPU-401 device at 0x%lx?\n", miro->mpu_port); + else { + error = snd_mpu401_uart_new(card, 0, MPU401_HW_MPU401, + mpu_port, 0, miro->mpu_irq, IRQF_DISABLED, + &rmidi); + if (error < 0) + snd_printk(KERN_WARNING "no MPU-401 device at 0x%lx?\n", + mpu_port); + } - if (miro->fm_port > 0 && miro->fm_port != SNDRV_AUTO_PORT) { + if (fm_port > 0 && fm_port != SNDRV_AUTO_PORT) { struct snd_opl3 *opl3 = NULL; struct snd_opl4 *opl4; - if (snd_opl4_create(card, miro->fm_port, miro->fm_port - 8, + if (snd_opl4_create(card, fm_port, fm_port - 8, 2, &opl3, &opl4) < 0) - snd_printk(KERN_WARNING "no OPL4 device at 0x%lx\n", miro->fm_port); + snd_printk(KERN_WARNING "no OPL4 device at 0x%lx\n", + fm_port); } if ((error = snd_set_aci_init_values(miro)) < 0) { -- 1.6.4 ---------------------------------------------------------------------- Internetowi nie placa! Otworz Konto Direct. Kliknij >> http://link.interia.pl/f2448

2 1