December 2008 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: Mark non-connected TWL4030 pins for pandora
by Grazvydas Ignotas 23 Dec '08

23 Dec '08

Pandora has all TWL4030 output pins floating, it uses external DAC for playback. Mark those outputs as not connected using DAPM calls. Signed-off-by: Grazvydas Ignotas <notasas(a)gmail.com> --- sound/soc/omap/omap3pandora.c | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c index bd91594..0ffb3de 100644 --- a/sound/soc/omap/omap3pandora.c +++ b/sound/soc/omap/omap3pandora.c @@ -180,6 +180,19 @@ static int omap3pandora_in_init(struct snd_soc_codec *codec) { int ret; + /* All TWL4030 output pins are floating */ + snd_soc_dapm_nc_pin(codec, "OUTL"), + snd_soc_dapm_nc_pin(codec, "OUTR"), + snd_soc_dapm_nc_pin(codec, "EARPIECE"), + snd_soc_dapm_nc_pin(codec, "PREDRIVEL"), + snd_soc_dapm_nc_pin(codec, "PREDRIVER"), + snd_soc_dapm_nc_pin(codec, "HSOL"), + snd_soc_dapm_nc_pin(codec, "HSOR"), + snd_soc_dapm_nc_pin(codec, "CARKITL"), + snd_soc_dapm_nc_pin(codec, "CARKITR"), + snd_soc_dapm_nc_pin(codec, "HFL"), + snd_soc_dapm_nc_pin(codec, "HFR"), + ret = snd_soc_dapm_new_controls(codec, omap3pandora_in_dapm_widgets, ARRAY_SIZE(omap3pandora_in_dapm_widgets)); if (ret < 0) -- 1.5.4.3

2 1

[alsa-devel] [topic/asoc][PATCH] ASoC: OMAP: Select OMAP pin multiplexing when using Nokia N810 ASoC drivers
by Jarkko Nikula 23 Dec '08

23 Dec '08

N810 bootloader muxes I2S pins for OMAP2420 EAC block while N810 ASoC drivers are using McBSP block so the kernel have to change configuration runtime. Author has not seen problems using kernel pin multiplexing on N810 but very many times unworking audio after forgotten to enable it and spending 15 minutes each time to figure it out again... This change makes it easier for other users as well. If problems arise, then they are better to find and fix in OMAP pin multiplexing framework. Signed-off-by: Jarkko Nikula <jarkko.nikula(a)nokia.com> --- sound/soc/omap/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index a7b1d77..4f7f040 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -10,6 +10,7 @@ config SND_OMAP_SOC_N810 tristate "SoC Audio support for Nokia N810" depends on SND_OMAP_SOC && MACH_NOKIA_N810 select SND_OMAP_SOC_MCBSP + select OMAP_MUX select SND_SOC_TLV320AIC3X help Say Y if you want to add support for SoC audio on Nokia N810. -- 1.5.6.5

2 1

[alsa-devel] [topic/asoc][PATCH]] ASoC: OMAP: Select OMAP pin multiplexing when using Nokia N810 ASoC drivers
by Jarkko Nikula 23 Dec '08

23 Dec '08

N810 bootloader muxes I2S pins for OMAP2420 EAC block while N810 ASoC drivers are using McBSP block so the kernel have to change configuration runtime. Author has not seen problems using kernel pin multiplexing on N810 but very many times unworking audio after forgotten to enable it and spending 15 minutes each time to figure it out again... This change makes it easier for other users as well. If problems arise, then they are better to find and fix in OMAP pin multiplexing framework. Signed-off-by: Jarkko Nikula <jarkko.nikula(a)nokia.com> --- sound/soc/omap/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index a7b1d77..4f7f040 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -10,6 +10,7 @@ config SND_OMAP_SOC_N810 tristate "SoC Audio support for Nokia N810" depends on SND_OMAP_SOC && MACH_NOKIA_N810 select SND_OMAP_SOC_MCBSP + select OMAP_MUX select SND_SOC_TLV320AIC3X help Say Y if you want to add support for SoC audio on Nokia N810. -- 1.5.6.5

1 1

Re: [alsa-devel] Additing a new Hardware Specific feature in the ALSA driver
by Eliot Blennerhassett 22 Dec '08

22 Dec '08

SUBHRANIL CHOUDHURY wrote: > Eliot, > Suppose i need to change the DAC gain, ADC gain of the audio codec and > also disable and enable AGC of the codec i need to put some IOCTLs in > the driver. > So, in case of ALSA how do i implement those IOCTLs in the driver and > also expose them to the application through the ALSA library. No! For this kind of control You just need to implement standard alsa controls in your driver. BOOLEAN: AGC ON/OFF INTEGER: DAC gain. See "writing an ALSA driver" for details, and study the source of any ALSA driver. http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/c843.htm -- Eliot

1 0

[alsa-devel] [topic/asoc][PATCH] ASoC: Fix DSP formats in SSM2602 audio codec
by Jarkko Nikula 22 Dec '08

22 Dec '08

Thanks to Troy Kisky <troy.kisky(a)boundarydevices.com> for noticing. - DSP_A format has 1-bit data delay which corresponds to SSM6202 submode 2 - DSP_B has 0-bit data delay which corresponds to submode 1 - Currently driver sets them opposite so swap the submode setting Signed-off-by: Jarkko Nikula <jarkko.nikula(a)nokia.com> Cc: Cliff Cai <cliff.cai(a)analog.com> --- sound/soc/codecs/ssm2602.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 2325aef..cac3736 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -454,10 +454,10 @@ static int ssm2602_set_dai_fmt(struct snd_soc_dai *codec_dai, iface |= 0x0001; break; case SND_SOC_DAIFMT_DSP_A: - iface |= 0x0003; + iface |= 0x0013; break; case SND_SOC_DAIFMT_DSP_B: - iface |= 0x0013; + iface |= 0x0003; break; default: return -EINVAL; -- 1.5.6.5

3 2

Re: [alsa-devel] [PATCH] ASoC: typo
by Liam Girdwood 22 Dec '08

22 Dec '08

On Mon, 2008-12-22 at 17:40 +0100, Roel Kluin wrote: > Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com> > --- > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > index acd68ef..227c865 100644 > --- a/sound/soc/omap/omap-pcm.c > +++ b/sound/soc/omap/omap-pcm.c > @@ -97,7 +97,7 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream, > prtd->dma_data = dma_data; > err = omap_request_dma(dma_data->dma_req, dma_data->name, > omap_pcm_dma_irq, substream, &prtd->dma_ch); > - if (!err & !cpu_is_omap1510()) { > + if (!err && !cpu_is_omap1510()) { > /* > * Link channel with itself so DMA doesn't need any > * reprogramming while looping the buffer Signed-off-by: Liam Girdwood <lrg(a)slimlogic.co.uk> Liam

2 1

[alsa-devel] ASoC updaets
by Mark Brown 22 Dec '08

22 Dec '08

The following changes since commit a31501d1041c9d0a6c3f520736ae2b2fa081493a: Takashi Iwai (1): ALSA: ASoC - Add missing __devexit annotation to wm8350.c are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-tiwai Jarkko Nikula (2): ASoC: Fix incorrect DSP format in OMAP McBSP DAI and affected drivers ASoC: Fix DSP formats in SSM2602 audio codec sound/soc/codecs/ssm2602.c | 4 ++-- sound/soc/codecs/tlv320aic23.c | 2 +- sound/soc/omap/omap-mcbsp.c | 4 ++-- sound/soc/omap/osk5912.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-)

2 1

[alsa-devel] [topic/asoc][PATCH 0/1] ASoC: Fix incorrect DSP format in OMAP McBSP DAI and affected drivers
by Jarkko Nikula 22 Dec '08

22 Dec '08

Hi This fix is generated against topic/asoc and don't apply against mainline. IMO this can go to next merge window with preceding patches since OSK5912 in mainline should work, just format is defined wrong and all new drivers where this affects should anyway go to the top of topic/asoc. -- Jarkko

3 3

[alsa-devel] patch 1/1: ASoC, DMA crash with application- resolved
by naveenkrishna.ch 22 Dec '08

22 Dec '08

Hi ALSA SOC, I am using a OMAP3 + TWL4030 combination with ASoC in the sound/soc/omap/omap-pcm.c DMA channels are being freed after unlinking in the omap_pcm_hw_free function Which is causing a crash during applications So, stopping the DMA channels before unlinking resolves the issue. here is the patch that solves the issue diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c index e9084fd..679e384 100644 --- a/sound/soc/omap/omap-pcm.c +++ b/sound/soc/omap/omap-pcm.c @@ -116,6 +116,7 @@ static int omap_pcm_hw_free(struct snd_pcm_substream *substream) if (prtd->dma_data == NULL) return 0; + omap_stop_dma(prtd->dma_ch); if (!cpu_is_omap1510()) omap_dma_unlink_lch(prtd->dma_ch, prtd->dma_ch); omap_free_dma(prtd->dma_ch); Is this ok or is there any better way out -- Thanks, (: Naveen Krishna Ch :)

4 7

Re: [alsa-devel] [PATCH 0/8]ALSA: ASoc: DaVinci: cleanup
by David Brownell 22 Dec '08

22 Dec '08

On Sunday 21 December 2008, Rajashekhara, Sudhakar wrote: > the existing meaning is correct w.r.t davinci McBSP. Not entirely. DaVinci doesn't have McBSP; it has ASP. Having all this code refer to a McBSP -- as found for example on OMAP chips -- is confusing and incorrect. - Dave

1 0