October 2008 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: Convert wm8580 to a new-style i2c driver
by Jean Delvare 16 Oct '08

16 Oct '08

Convert the wm8580 codec driver to the new (standard) device driver binding model. Signed-off-by: Jean Delvare <khali(a)linux-fr.org> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- Untested, no hardware. sound/soc/codecs/wm8580.c | 108 ++++++++++++++++++++++----------------------- sound/soc/codecs/wm8580.h | 1 2 files changed, 54 insertions(+), 55 deletions(-) --- linux-2.6.28-rc0.orig/sound/soc/codecs/wm8580.c 2008-10-15 15:14:34.000000000 +0200 +++ linux-2.6.28-rc0/sound/soc/codecs/wm8580.c 2008-10-15 17:26:13.000000000 +0200 @@ -900,85 +900,85 @@ static struct snd_soc_device *wm8580_soc * low = 0x1a * high = 0x1b */ -static unsigned short normal_i2c[] = { 0, I2C_CLIENT_END }; -/* Magic definition of all other variables and things */ -I2C_CLIENT_INSMOD; - -static struct i2c_driver wm8580_i2c_driver; -static struct i2c_client client_template; - -static int wm8580_codec_probe(struct i2c_adapter *adap, int addr, int kind) +static int wm8580_i2c_probe(struct i2c_client *i2c, + const struct i2c_device_id *id) { struct snd_soc_device *socdev = wm8580_socdev; - struct wm8580_setup_data *setup = socdev->codec_data; struct snd_soc_codec *codec = socdev->codec; - struct i2c_client *i2c; int ret; - if (addr != setup->i2c_address) - return -ENODEV; - - client_template.adapter = adap; - client_template.addr = addr; - - i2c = kmemdup(&client_template, sizeof(client_template), GFP_KERNEL); - if (i2c == NULL) { - kfree(codec); - return -ENOMEM; - } i2c_set_clientdata(i2c, codec); codec->control_data = i2c; - ret = i2c_attach_client(i2c); - if (ret < 0) { - dev_err(&i2c->dev, "failed to attach codec at addr %x\n", addr); - goto err; - } - ret = wm8580_init(socdev); - if (ret < 0) { + if (ret < 0) dev_err(&i2c->dev, "failed to initialise WM8580\n"); - goto err; - } - - return ret; - -err: - kfree(codec); - kfree(i2c); return ret; } -static int wm8580_i2c_detach(struct i2c_client *client) +static int wm8580_i2c_remove(struct i2c_client *client) { struct snd_soc_codec *codec = i2c_get_clientdata(client); - i2c_detach_client(client); kfree(codec->reg_cache); - kfree(client); return 0; } -static int wm8580_i2c_attach(struct i2c_adapter *adap) -{ - return i2c_probe(adap, &addr_data, wm8580_codec_probe); -} +static const struct i2c_device_id wm8580_i2c_id[] = { + { "wm8580", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, wm8580_i2c_id); -/* corgi i2c codec control layer */ static struct i2c_driver wm8580_i2c_driver = { .driver = { .name = "WM8580 I2C Codec", .owner = THIS_MODULE, }, - .attach_adapter = wm8580_i2c_attach, - .detach_client = wm8580_i2c_detach, - .command = NULL, + .probe = wm8580_i2c_probe, + .remove = wm8580_i2c_remove, + .id_table = wm8580_i2c_id, }; -static struct i2c_client client_template = { - .name = "WM8580", - .driver = &wm8580_i2c_driver, -}; +static int wm8580_add_i2c_device(struct platform_device *pdev, + const struct wm8580_setup_data *setup) +{ + struct i2c_board_info info; + struct i2c_adapter *adapter; + struct i2c_client *client; + int ret; + + ret = i2c_add_driver(&wm8580_i2c_driver); + if (ret != 0) { + dev_err(&pdev->dev, "can't add i2c driver\n"); + return ret; + } + + memset(&info, 0, sizeof(struct i2c_board_info)); + info.addr = setup->i2c_address; + strlcpy(info.type, "wm8580", I2C_NAME_SIZE); + + adapter = i2c_get_adapter(setup->i2c_bus); + if (!adapter) { + dev_err(&pdev->dev, "can't get i2c adapter %d\n", + setup->i2c_bus); + goto err_driver; + } + + client = i2c_new_device(adapter, &info); + i2c_put_adapter(adapter); + if (!client) { + dev_err(&pdev->dev, "can't add i2c device at 0x%x\n", + (unsigned int)info.addr); + goto err_driver; + } + + return 0; + +err_driver: + i2c_del_driver(&wm8580_i2c_driver); + return -ENODEV; +} #endif static int wm8580_probe(struct platform_device *pdev) @@ -1011,11 +1011,8 @@ static int wm8580_probe(struct platform_ #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) if (setup->i2c_address) { - normal_i2c[0] = setup->i2c_address; codec->hw_write = (hw_write_t)i2c_master_send; - ret = i2c_add_driver(&wm8580_i2c_driver); - if (ret != 0) - printk(KERN_ERR "can't add i2c driver"); + ret = wm8580_add_i2c_device(pdev, setup); } #else /* Add other interfaces here */ @@ -1034,6 +1031,7 @@ static int wm8580_remove(struct platform snd_soc_free_pcms(socdev); snd_soc_dapm_free(socdev); #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) + i2c_unregister_device(codec->control_data); i2c_del_driver(&wm8580_i2c_driver); #endif kfree(codec->private_data); --- linux-2.6.28-rc0.orig/sound/soc/codecs/wm8580.h 2008-10-15 15:14:34.000000000 +0200 +++ linux-2.6.28-rc0/sound/soc/codecs/wm8580.h 2008-10-15 17:51:18.000000000 +0200 @@ -29,6 +29,7 @@ #define WM8580_CLKSRC_NONE 5 struct wm8580_setup_data { + int i2c_bus; unsigned short i2c_address; }; -- Jean Delvare

3 2

[alsa-devel] [PATCH] ALSA: Handle NULL jacks in snd_jack_report()
by Mark Brown 16 Oct '08

16 Oct '08

Facilitate drivers that wish to carry on if they can't create a jack input device by handling attempts to report the state of a NULL jack, removing the need to check for initialisation before use. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/core/jack.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/sound/core/jack.c b/sound/core/jack.c index 8133a2b..bd2d9e6 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -147,6 +147,9 @@ EXPORT_SYMBOL(snd_jack_set_parent); */ void snd_jack_report(struct snd_jack *jack, int status) { + if (!jack) + return; + if (jack->type & SND_JACK_HEADPHONE) input_report_switch(jack->input_dev, SW_HEADPHONE_INSERT, status & SND_JACK_HEADPHONE); -- 1.5.6.5

2 1

[alsa-devel] [PATCH] port pcxhr driver do devres
by Rolf Eike Beer 15 Oct '08

15 Oct '08

Signed-off-by: Rolf Eike Beer <eike-kernel(a)sf-tec.de> --- I was a bit bored and ported the pcxhr driver to use devres to manage it's IRQ and PCI resources. This is completely untested as I don't have such a card but you might find it useful nevertheless. commit e7df0303a1517bdd0d2f0af5fbdf91acc0b7f426 tree 45fbf9c75c8ea51ae89f0409ed02138380b71624 parent 9824b8f11373b0df806c135a342da9319ef1d893 author Rolf Eike Beer <eike-kernel(a)sf-tec.de> Sun, 21 Sep 2008 17:26:28 +0200 committer Rolf Eike Beer <eike-kernel(a)sf-tec.de> Sun, 21 Sep 2008 17:26:28 +0200 sound/pci/pcxhr/pcxhr.c | 14 ++------------ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c index 2c7e253..676389e 100644 --- a/sound/pci/pcxhr/pcxhr.c +++ b/sound/pci/pcxhr/pcxhr.c @@ -1171,12 +1171,6 @@ static int pcxhr_free(struct pcxhr_mgr *mgr) snd_printdd("reset pcxhr !\n"); } - /* release irq */ - if (mgr->irq >= 0) - free_irq(mgr->irq, mgr); - - pci_release_regions(mgr->pci); - /* free hostport purgebuffer */ if (mgr->hostport.area) { snd_dma_free_pages(&mgr->hostport); @@ -1185,7 +1179,6 @@ static int pcxhr_free(struct pcxhr_mgr *mgr) kfree(mgr->prmh); - pci_disable_device(mgr->pci); kfree(mgr); return 0; } @@ -1210,21 +1203,19 @@ static int __devinit pcxhr_probe(struct pci_dev *pci, const struct pci_device_id } /* enable PCI device */ - if ((err = pci_enable_device(pci)) < 0) + if ((err = pcim_enable_device(pci)) < 0) return err; pci_set_master(pci); /* check if we can restrict PCI DMA transfers to 32 bits */ if (pci_set_dma_mask(pci, DMA_32BIT_MASK) < 0) { snd_printk(KERN_ERR "architecture does not support 32bit PCI busmaster DMA\n"); - pci_disable_device(pci); return -ENXIO; } /* alloc card manager */ mgr = kzalloc(sizeof(*mgr), GFP_KERNEL); if (! mgr) { - pci_disable_device(pci); return -ENOMEM; } @@ -1238,7 +1229,6 @@ static int __devinit pcxhr_probe(struct pci_dev *pci, const struct pci_device_id /* resource assignment */ if ((err = pci_request_regions(pci, card_name)) < 0) { kfree(mgr); - pci_disable_device(pci); return err; } for (i = 0; i < 3; i++) @@ -1247,7 +1237,7 @@ static int __devinit pcxhr_probe(struct pci_dev *pci, const struct pci_device_id mgr->pci = pci; mgr->irq = -1; - if (request_irq(pci->irq, pcxhr_interrupt, IRQF_SHARED, + if (devm_request_irq(&pci->dev, pci->irq, pcxhr_interrupt, IRQF_SHARED, card_name, mgr)) { snd_printk(KERN_ERR "unable to grab IRQ %d\n", pci->irq); pcxhr_free(mgr);

2 2

[alsa-devel] [PATCH] ASoC: Convert wm8900 to a new-style i2c driver
by Jean Delvare 15 Oct '08

15 Oct '08

Convert the wm8900 codec driver to the new (standard) device driver binding model. Signed-off-by: Jean Delvare <khali(a)linux-fr.org> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- Untested, no hardware. sound/soc/codecs/wm8900.c | 113 +++++++++++++++++++++------------------------ sound/soc/codecs/wm8900.h | 1 2 files changed, 55 insertions(+), 59 deletions(-) --- linux-2.6.28-rc0.orig/sound/soc/codecs/wm8900.c 2008-10-15 15:14:34.000000000 +0200 +++ linux-2.6.28-rc0/sound/soc/codecs/wm8900.c 2008-10-15 19:03:42.000000000 +0200 @@ -1387,89 +1387,86 @@ static struct snd_soc_device *wm8900_soc #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) -static unsigned short normal_i2c[] = { 0, I2C_CLIENT_END }; - -/* Magic definition of all other variables and things */ -I2C_CLIENT_INSMOD; - -static struct i2c_driver wm8900_i2c_driver; -static struct i2c_client client_template; - /* If the i2c layer weren't so broken, we could pass this kind of data around */ -static int wm8900_codec_probe(struct i2c_adapter *adap, int addr, int kind) +static int wm8900_i2c_probe(struct i2c_client *i2c, + const struct i2c_device_id *id) { struct snd_soc_device *socdev = wm8900_socdev; - struct wm8900_setup_data *setup = socdev->codec_data; struct snd_soc_codec *codec = socdev->codec; - struct i2c_client *i2c; int ret; - if (addr != setup->i2c_address) - return -ENODEV; - - dev_err(&adap->dev, "Probe on %x\n", addr); - - client_template.adapter = adap; - client_template.addr = addr; - - i2c = kmemdup(&client_template, sizeof(client_template), GFP_KERNEL); - if (i2c == NULL) { - kfree(codec); - return -ENOMEM; - } i2c_set_clientdata(i2c, codec); codec->control_data = i2c; - ret = i2c_attach_client(i2c); - if (ret < 0) { - dev_err(&adap->dev, - "failed to attach codec at addr %x\n", addr); - goto err; - } - ret = wm8900_init(socdev); - if (ret < 0) { - dev_err(&adap->dev, "failed to initialise WM8900\n"); - goto err; - } - return ret; - -err: - kfree(codec); - kfree(i2c); + if (ret < 0) + dev_err(&i2c->dev, "failed to initialise WM8900\n"); return ret; } -static int wm8900_i2c_detach(struct i2c_client *client) +static int wm8900_i2c_remove(struct i2c_client *client) { struct snd_soc_codec *codec = i2c_get_clientdata(client); - i2c_detach_client(client); kfree(codec->reg_cache); - kfree(client); return 0; } -static int wm8900_i2c_attach(struct i2c_adapter *adap) -{ - return i2c_probe(adap, &addr_data, wm8900_codec_probe); -} +static const struct i2c_device_id wm8900_i2c_id[] = { + { "wm8900", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, wm8900_i2c_id); -/* corgi i2c codec control layer */ static struct i2c_driver wm8900_i2c_driver = { .driver = { .name = "WM8900 I2C codec", .owner = THIS_MODULE, }, - .attach_adapter = wm8900_i2c_attach, - .detach_client = wm8900_i2c_detach, - .command = NULL, + .probe = wm8900_i2c_probe, + .remove = wm8900_i2c_remove, + .id_table = wm8900_i2c_id, }; -static struct i2c_client client_template = { - .name = "WM8900", - .driver = &wm8900_i2c_driver, -}; +static int wm8900_add_i2c_device(struct platform_device *pdev, + const struct wm8900_setup_data *setup) +{ + struct i2c_board_info info; + struct i2c_adapter *adapter; + struct i2c_client *client; + int ret; + + ret = i2c_add_driver(&wm8900_i2c_driver); + if (ret != 0) { + dev_err(&pdev->dev, "can't add i2c driver\n"); + return ret; + } + + memset(&info, 0, sizeof(struct i2c_board_info)); + info.addr = setup->i2c_address; + strlcpy(info.type, "wm8900", I2C_NAME_SIZE); + + adapter = i2c_get_adapter(setup->i2c_bus); + if (!adapter) { + dev_err(&pdev->dev, "can't get i2c adapter %d\n", + setup->i2c_bus); + goto err_driver; + } + + client = i2c_new_device(adapter, &info); + i2c_put_adapter(adapter); + if (!client) { + dev_err(&pdev->dev, "can't add i2c device at 0x%x\n", + (unsigned int)info.addr); + goto err_driver; + } + + return 0; + +err_driver: + i2c_del_driver(&wm8900_i2c_driver); + return -ENODEV; +} #endif static int wm8900_probe(struct platform_device *pdev) @@ -1497,11 +1494,8 @@ static int wm8900_probe(struct platform_ wm8900_socdev = socdev; #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) if (setup->i2c_address) { - normal_i2c[0] = setup->i2c_address; codec->hw_write = (hw_write_t)i2c_master_send; - ret = i2c_add_driver(&wm8900_i2c_driver); - if (ret != 0) - printk(KERN_ERR "can't add i2c driver"); + ret = wm8900_add_i2c_device(pdev, setup); } #else #error Non-I2C interfaces not yet supported @@ -1521,6 +1515,7 @@ static int wm8900_remove(struct platform snd_soc_free_pcms(socdev); snd_soc_dapm_free(socdev); #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) + i2c_unregister_device(codec->control_data); i2c_del_driver(&wm8900_i2c_driver); #endif kfree(codec); --- linux-2.6.28-rc0.orig/sound/soc/codecs/wm8900.h 2008-10-15 15:14:34.000000000 +0200 +++ linux-2.6.28-rc0/sound/soc/codecs/wm8900.h 2008-10-15 18:33:26.000000000 +0200 @@ -55,6 +55,7 @@ #define WM8900_ struct wm8900_setup_data { + int i2c_bus; unsigned short i2c_address; }; -- Jean Delvare

2 1

[alsa-devel] [PATCH] hda: add support for jack detection on IDT/Sigmatel
by Matthew Ranostay 15 Oct '08

15 Oct '08

Added support for jack detection reporting to userspace for IDT/Sigmatel codecs. Signed-off-by: Matthew Ranostay <mranostay(a)embeddedalley.com> --- diff --git a/core/jack.c b/core/jack.c index 8133a2b..7a5b07b 100644 --- a/core/jack.c +++ b/core/jack.c @@ -95,7 +95,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type, goto fail_input; } - jack->input_dev->phys = "ALSA"; + jack->input_dev->phys = "ALSA Jack Detection"; jack->type = type; diff --git a/pci/Kconfig b/pci/Kconfig index 7003711..7e40890 100644 --- a/pci/Kconfig +++ b/pci/Kconfig @@ -501,6 +501,7 @@ config SND_HDA_INTEL tristate "Intel HD Audio" select SND_PCM select SND_VMASTER + select SND_JACK if INPUT=y || INPUT=SND help Say Y here to include support for Intel "High Definition Audio" (Azalia) motherboard devices. diff --git a/pci/hda/hda_codec.h b/pci/hda/hda_codec.h index 60468f5..93dc961 100644 --- a/pci/hda/hda_codec.h +++ b/pci/hda/hda_codec.h @@ -729,6 +729,9 @@ struct hda_codec { struct snd_hwdep *hwdep; /* assigned hwdep device */ + /* jack detection */ + struct snd_jack *jack; + /* misc flags */ unsigned int spdif_status_reset :1; /* needs to toggle SPDIF for each * status change diff --git a/pci/hda/hda_proc.c b/pci/hda/hda_proc.c index 743d779..e07652a 100644 --- a/pci/hda/hda_proc.c +++ b/pci/hda/hda_proc.c @@ -425,6 +425,22 @@ static void print_unsol_cap(struct snd_info_buffer *buffer, (unsol & AC_UNSOL_ENABLED) ? 1 : 0); } +static void print_presence_cap(struct snd_info_buffer *buffer, + struct hda_codec *codec, hda_nid_t nid) +{ + int presence = snd_hda_codec_read(codec, nid, 0, + AC_VERB_GET_PIN_SENSE, 0); + int def_conf = snd_hda_codec_read(codec, nid, 0, + AC_VERB_GET_CONFIG_DEFAULT, 0x00); + def_conf = get_defcfg_connect(def_conf); + if (def_conf && def_conf != AC_JACK_PORT_FIXED) + return; + snd_iprintf(buffer, + " Jack Presence: %s\n", + (presence & AC_PINSENSE_PRESENCE) + ? "Plugged in" : "Unplugged"); +} + static void print_proc_caps(struct snd_info_buffer *buffer, struct hda_codec *codec, hda_nid_t nid) { @@ -552,6 +568,9 @@ static void print_codec_info(struct snd_info_entry *entry, AC_PAR_AUDIO_WIDGET_CAP); unsigned int wid_type = (wid_caps & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT; + unsigned int pincap = snd_hda_param_read(codec, nid, + AC_PAR_PIN_CAP); + hda_nid_t conn[HDA_MAX_CONNECTIONS]; int conn_len = 0; @@ -632,6 +651,9 @@ static void print_codec_info(struct snd_info_entry *entry, if (wid_caps & AC_WCAP_UNSOL_CAP) print_unsol_cap(buffer, codec, nid); + if (pincap & AC_PINCAP_PRES_DETECT) + print_presence_cap(buffer, codec, nid); + if (wid_caps & AC_WCAP_POWER) print_power_state(buffer, codec, nid); diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index a2ac720..a406fa7 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -30,6 +30,7 @@ #include <linux/pci.h> #include <sound/core.h> #include <sound/asoundef.h> +#include <sound/jack.h> #include "hda_codec.h" #include "hda_local.h" #include "hda_patch.h" @@ -3617,7 +3618,7 @@ static int stac92xx_init(struct hda_codec *codec) { struct sigmatel_spec *spec = codec->spec; struct auto_pin_cfg *cfg = &spec->autocfg; - int i; + int i, err; snd_hda_sequence_write(codec, spec->init); @@ -3639,6 +3640,12 @@ static int stac92xx_init(struct hda_codec *codec) stac92xx_auto_set_pinctl(codec, spec->autocfg.line_out_pins[0], AC_PINCTL_OUT_EN); stac92xx_auto_init_hp_out(codec); + /* jack detection */ + err = snd_jack_new(codec->bus->card, + "Headphone Jack Detection", + SND_JACK_HEADPHONE, &codec->jack); + if (err < 0) + return err; /* fake event to set up pins */ codec->patch_ops.unsol_event(codec, STAC_HP_EVENT << 26); } else { @@ -3797,6 +3804,10 @@ static void stac92xx_hp_detect(struct hda_codec *codec, unsigned int res) presence = get_hp_pin_presence(codec, cfg->hp_pins[i]); } + if (codec->jack) + snd_jack_report(codec->jack, + presence ? SND_JACK_HEADPHONE : 0); + if (presence) { /* disable lineouts, enable hp */ if (spec->hp_switch)

3 7

[alsa-devel] Possible regression on Sigmatel 9205
by Manuel Naranjo 15 Oct '08

15 Oct '08

Hello everyone, Sorry to interrupt you all, but I had been trying to get the digital mic of my Dell Inspiron 1521 for the last 5 days without any sucess. I'm running kernel 2.6.27 with included ALSA, I also tried GIT alsa, and the result is the same, the mic works, but the volume is so damn low that there's no way to hear it. I checked dell's windows drivers and my board belongs to the M4_8 line and not to the M4_2 as suggested in alsa source. I also did a diff between M4_2 and M4_8 and there are some differences, specially in GPIO. I don't know what else to do now, I had tried everything. Last working alsa was 1.15 if I'm not wrong, but I'm not able to backport 1.15 to the new kernel, for some reason it fails to compile. Any help would be appreciate. Thanks, Manuel

3 9

Re: [alsa-devel] Backported sbxfi driver (UNTESTED!)
by Takashi Iwai 15 Oct '08

15 Oct '08

At Wed, 15 Oct 2008 11:47:00 +0400, The Source wrote: > > Takashi Iwai пишет: > > At Wed, 15 Oct 2008 11:16:32 +0400, > > The Source wrote: > > > >> Takashi Iwai пишет: > >> > >>> At Tue, 14 Oct 2008 15:24:22 +0400, > >>> The Source wrote: > >>> > >>> > >>>> By the way, note, that not rate may cause oops but number of channles > >>>> for example (wav that causes oops has mono mode and the one that just > >>>> plays silently - stereo. Also the oops sample is 16bit, silent one is > >>>> 24bit). > >>>> > >>>> > >>> This is an important information. The driver basically supports only > >>> 16bit stereo samples natively. The others are covered by alsa-lib, > >>> and this involves with the mmap mode. > >>> > >>> But I still wonder why 16bit mode. > >>> > >>> OK, the below is *THE* test I'd like ask you guys to try first. > >>> > >>> - Build the driver with --with-debug=detect option > >>> - Load the driver with debug=2 module option > >>> - Prepare a WAV file with 96kHz 16bit stereo, e.g. converted via sox > >>> - Raise the Master volume to the max > >>> - Run "aplay this.wav" > >>> > >>> At *each* run, check your kernel message. If you get Oops, copy the > >>> whole log immediately. > >>> > >>> - If you get a DMA error or so in the kernel message, try to define > >>> XXX_SYSTEM_TIMER in sbxfi.c, rebuild and reinstall the driver. > >>> Run the same test. > >>> > >>> - If still any serious problem, load the module with debug=3 option, > >>> and get the whole kernel message with full register accesses. > >>> > >>> > >>> thanks, > >>> > >>> Takashi > >>> > >>> > >>> > >> I've done what you have asked. I've got no oopses or other things like > >> that. But again not sound. I've tried with debug=2 and debug=3. > >> Attaching the whole dmesg output. > >> > > > > Thanks. Judging from your logs, it seems that the timer IRQ isn't > > generated as expected, or the pointer (SRCCA register read) doesn't > > work, or all broken. > > > > Could you try with XXX_SYSTEM_TIMER? This eliminates, at least, the > > timer issue. > > > > > > Takashi > > > > > I can't use system timer. changing #undef XXX_SYSTEM_TIMER to #define > XXX_SYSTEM_TIMER causes this: > In file included from /mnt/e/temp/alsa-driver-unstable/pci/sbxfi/sbxfi.c:2: > /mnt/e/temp/alsa-driver-unstable/include/../alsa-kernel/pci/sbxfi/sbxfi.c: > In function ‘sbxfi_timer_handle’: > /mnt/e/temp/alsa-driver-unstable/include/../alsa-kernel/pci/sbxfi/sbxfi.c:252: > error: ‘status’ undeclared (first use in this function) > /mnt/e/temp/alsa-driver-unstable/include/../alsa-kernel/pci/sbxfi/sbxfi.c:252: > error: (Each undeclared identifier is reported only once > /mnt/e/temp/alsa-driver-unstable/include/../alsa-kernel/pci/sbxfi/sbxfi.c:252: > error: for each function it appears in.) > /mnt/e/temp/alsa-driver-unstable/include/../alsa-kernel/pci/sbxfi/sbxfi.c:252: > warning: too many arguments for format Try the patch below. In case you're using snapshot tarball, apply it with -p2 on alsa-kernel directory. Takashi diff --git a/sound/pci/sbxfi/sbxfi.c b/sound/pci/sbxfi/sbxfi.c index 9ff5fc4..d6b5b34 100644 --- a/sound/pci/sbxfi/sbxfi.c +++ b/sound/pci/sbxfi/sbxfi.c @@ -249,7 +249,7 @@ static void sbxfi_handle_timer_callback(struct sbxfi *chip); static void sbxfi_timer_handle(unsigned long data) { - LOG(2, "TIMER ISR\n", status); + LOG(2, "TIMER ISR\n"); sbxfi_handle_timer_callback((struct sbxfi *)data); }

3 3

[alsa-devel] [PATCH] Add quirk for Stanton ScratchAmp v1
by jean michel casa 15 Oct '08

15 Oct '08

Hallo, may i have this patch? TNX

2 1

[alsa-devel] define confusion
by John Kacur 14 Oct '08

14 Oct '08

Could someone explain this a little bit more pls? The comment at the top doesn't clarify it for me! Thanks in advance. /* * DAI hardware clock masters * This is wrt the codec, the inverse is true for the interface * i.e. if the codec is clk and frm master then the interface is * clk and frame slave. */ #define SND_SOC_DAIFMT_CBM_CFM (0 << 12) /* codec clk & frm master */ #define SND_SOC_DAIFMT_CBS_CFM (1 << 12) /* codec clk slave & frm master */ #define SND_SOC_DAIFMT_CBM_CFS (2 << 12) /* codec clk master & frame slave */ #define SND_SOC_DAIFMT_CBS_CFS (3 << 12) /* codec clk & frm slave */

2 6

[alsa-devel] (no subject)
by Philippe CARRIERE 14 Oct '08

14 Oct '08

Le mardi 14 octobre 2008 à 13:29 +0200, Karsten Wiese a écrit : Am Dienstag, 14. Oktober 2008 schrieb Philippe Carriere: > > Might this patch (the original one, without features yet implemented in > > 2.6.26, and an extremely slight modification to fit it) I use on Fedora > > kernel (the patch also applies as it stands to vanilla) save works and > > time ? > > maybe. > I guess the patch would have to fit what will become 2.6.28. > > > regards, > Karsten > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > Thus I can try to follow the next evolution of the kernel and send you new version of the patch, when required; would it be fruitful for you ? During that time, I will try to implement a module modification (presently, I propose a whole kernel which is not the right solution), but I have some things to learn about the method. A last question: you commented some lines in us122l.c which are concerned with the possible support of US-144 (which apparently has a very similar hardware): do you think support of US-144 would be possible - to be tested of course - with the same driver or do you think it would require more work ? Regards Phil

1 0

Re: [alsa-devel] [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver
by matthias.nyffenegger＠bluewin.ch 14 Oct '08

14 Oct '08

At 13.10.2008 12:32 tiwai(a)suse.de wrote: Hi Takashi, >[please stop top-posting] Ok, sorry for that. >I don't care in which direction, whether to merge yours into aw2 or >aw2 into yours. I just want to have a reasonable merge of two >works. > >Well, this is basically an option, and can be achieved later, too. >So, could you post the patches to ML for further reviews? Yes, I'll do that soon. >But before submitting patches, I recommend you to run once >scripts/checkpatch.pl (found in kernel tree) with your patches. >You'll find lots of coding style issues even by such a simple tool. >Then, check Documentation/CodingStyle and fix your codes again. > >And, please remove the debug trace stuff unless you really need it in >future. This decreases readability fairly much. I guess you refer to the 0.1 sourceforge release -> I actually did that before submitting aw-alsa-patch-0.2. Anyway, I'll post the patch again, this time in Mail body, following your recommendations. Thank you for helping. Regards, Matthias

1 0

[alsa-devel] [PATCH 1/1] [ALSA] Allow setting codec register with debugfs filesystem
by Troy Kisky 14 Oct '08

14 Oct '08

i.e. echo 6 59 >/sys/kernel/debug/soc-audio.0/codec_reg will set register 0x06 to a value of 0x59. Also, pop_time debugfs interface setup is moved so that it is setup in the same function as codec_reg Signed-off-by: Troy Kisky <troy.kisky(a)boundarydevices.com> diff --git a/include/sound/soc.h b/include/sound/soc.h index a1e0357..d33825d 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -425,6 +425,7 @@ struct snd_soc_codec { short reg_cache_step; /* dapm */ + u32 pop_time; struct list_head dapm_widgets; struct list_head dapm_paths; enum snd_soc_bias_level bias_level; @@ -516,6 +517,9 @@ struct snd_soc_device { struct delayed_work delayed_work; struct work_struct deferred_resume_work; void *codec_data; +#ifdef CONFIG_DEBUG_FS + struct dentry *debugfs_root; +#endif }; /* runtime channel data */ diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index ad38113..db720b1 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -27,6 +27,7 @@ #include <linux/delay.h> #include <linux/pm.h> #include <linux/bitops.h> +#include <linux/debugfs.h> #include <linux/platform_device.h> #include <sound/core.h> #include <sound/pcm.h> @@ -962,10 +963,8 @@ static int soc_new_pcm(struct snd_soc_device *socdev, } /* codec register dump */ -static ssize_t codec_reg_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t soc_codec_reg_show(struct snd_soc_device *devdata, char *buf) { - struct snd_soc_device *devdata = dev_get_drvdata(dev); struct snd_soc_codec *codec = devdata->codec; int i, step = 1, count = 0; @@ -1002,8 +1001,117 @@ static ssize_t codec_reg_show(struct device *dev, return count; } +static ssize_t codec_reg_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct snd_soc_device *devdata = dev_get_drvdata(dev); + return soc_codec_reg_show(devdata, buf); +} + static DEVICE_ATTR(codec_reg, 0444, codec_reg_show, NULL); +#ifdef CONFIG_DEBUG_FS +static int codec_reg_open_file(struct inode *inode, struct file *file) +{ + file->private_data = inode->i_private; + return 0; +} + +static ssize_t codec_reg_read_file(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + ssize_t ret; + struct snd_soc_device *devdata = file->private_data; + char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL); + if (!buf) + return -ENOMEM; + ret = soc_codec_reg_show(devdata, buf); + if (ret >= 0) + ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret); + kfree(buf); + return ret; +} + +static ssize_t codec_reg_write_file(struct file *file, + const char __user *user_buf, size_t count, loff_t *ppos) +{ + char buf[32]; + int buf_size; + char *start = buf; + unsigned long reg, value; + int step = 1; + struct snd_soc_device *devdata = file->private_data; + struct snd_soc_codec *codec = devdata->codec; + + buf_size = min(count, (sizeof(buf)-1)); + if (copy_from_user(buf, user_buf, buf_size)) + return -EFAULT; + buf[buf_size] = 0; + + if (codec->reg_cache_step) + step = codec->reg_cache_step; + + while (*start == ' ') + start++; + reg = simple_strtoul(start, &start, 16); + if ((reg >= codec->reg_cache_size) || (reg % step)) + return -EINVAL; + while (*start == ' ') + start++; + if (strict_strtoul(start, 16, &value)) + return -EINVAL; + codec->write(codec, reg, value); + return buf_size; +} + +static const struct file_operations codec_reg_fops = { + .open = codec_reg_open_file, + .read = codec_reg_read_file, + .write = codec_reg_write_file, +}; + +static void soc_init_debugfs(struct snd_soc_device *socdev) +{ + struct dentry *root, *file; + struct snd_soc_codec *codec = socdev->codec; + root = debugfs_create_dir(dev_name(socdev->dev), NULL); + if (IS_ERR(root) || !root) + goto exit1; + + file = debugfs_create_file("codec_reg", 0644, + root, socdev, &codec_reg_fops); + if (!file) + goto exit2; + + file = debugfs_create_u32("dapm_pop_time", 0744, + root, &codec->pop_time); + if (!file) + goto exit2; + socdev->debugfs_root = root; + return; +exit2: + debugfs_remove_recursive(root); +exit1: + dev_err(socdev->dev, "debugfs is not available\n"); +} + +static void soc_cleanup_debugfs(struct snd_soc_device *socdev) +{ + debugfs_remove_recursive(socdev->debugfs_root); + socdev->debugfs_root = NULL; +} + +#else + +static inline void soc_init_debugfs(struct snd_soc_device *socdev) +{ +} + +static inline void soc_cleanup_debugfs(struct snd_soc_device *socdev) +{ +} +#endif + /** * snd_soc_new_ac97_codec - initailise AC97 device * @codec: audio codec @@ -1217,6 +1325,7 @@ int snd_soc_register_card(struct snd_soc_device *socdev) if (err < 0) printk(KERN_WARNING "asoc: failed to add codec sysfs files\n"); + soc_init_debugfs(socdev); mutex_unlock(&codec->mutex); out: @@ -1240,6 +1349,7 @@ void snd_soc_free_pcms(struct snd_soc_device *socdev) #endif mutex_lock(&codec->mutex); + soc_cleanup_debugfs(socdev); #ifdef CONFIG_SND_SOC_AC97_BUS for (i = 0; i < codec->num_dai; i++) { codec_dai = &codec->dai[i]; diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 9ca9c08..1bd88ac 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -38,7 +38,6 @@ #include <linux/bitops.h> #include <linux/platform_device.h> #include <linux/jiffies.h> -#include <linux/debugfs.h> #include <sound/core.h> #include <sound/pcm.h> #include <sound/pcm_params.h> @@ -68,17 +67,13 @@ static int dapm_status = 1; module_param(dapm_status, int, 0); MODULE_PARM_DESC(dapm_status, "enable DPM sysfs entries"); -static struct dentry *asoc_debugfs; - -static u32 pop_time; - -static void pop_wait(void) +static void pop_wait(u32 pop_time) { if (pop_time) schedule_timeout_uninterruptible(msecs_to_jiffies(pop_time)); } -static void pop_dbg(const char *fmt, ...) +static void pop_dbg(u32 pop_time, const char *fmt, ...) { va_list args; @@ -86,7 +81,7 @@ static void pop_dbg(const char *fmt, ...) if (pop_time) { vprintk(fmt, args); - pop_wait(); + pop_wait(pop_time); } va_end(args); @@ -231,10 +226,11 @@ static int dapm_update_bits(struct snd_soc_dapm_widget *widget) change = old != new; if (change) { - pop_dbg("pop test %s : %s in %d ms\n", widget->name, - widget->power ? "on" : "off", pop_time); + pop_dbg(codec->pop_time, "pop test %s : %s in %d ms\n", + widget->name, widget->power ? "on" : "off", + codec->pop_time); snd_soc_write(codec, widget->reg, new); - pop_wait(); + pop_wait(codec->pop_time); } pr_debug("reg %x old %x new %x change %d\n", widget->reg, old, new, change); @@ -822,23 +818,9 @@ static DEVICE_ATTR(dapm_widget, 0444, dapm_widget_show, NULL); int snd_soc_dapm_sys_add(struct device *dev) { - int ret = 0; - if (!dapm_status) return 0; - - ret = device_create_file(dev, &dev_attr_dapm_widget); - if (ret != 0) - return ret; - - asoc_debugfs = debugfs_create_dir("asoc", NULL); - if (!IS_ERR(asoc_debugfs)) - debugfs_create_u32("dapm_pop_time", 0744, asoc_debugfs, - &pop_time); - else - asoc_debugfs = NULL; - - return 0; + return device_create_file(dev, &dev_attr_dapm_widget); } static void snd_soc_dapm_sys_remove(struct device *dev) @@ -846,9 +828,6 @@ static void snd_soc_dapm_sys_remove(struct device *dev) if (dapm_status) { device_remove_file(dev, &dev_attr_dapm_widget); } - - if (asoc_debugfs) - debugfs_remove_recursive(asoc_debugfs); } /* free all dapm widgets and resources */ -- 1.5.4.3

2 1

[alsa-devel] [PATCH] Fix pxa2xx-ac97-lib.c compilation
by Marc Zyngier 14 Oct '08

14 Oct '08

[This patch was posted to linux-arm-kernel ML yesterday, and reposted here in the hope that it will be merged soon] The last ALSA merge broke pxa2xx-ac97-lib.c, as it brought back references to cpu_is_pxa21x that Eric Miao removed in commit 0ffcbfd54ea81ca24c0749f55ca4fcf3e2bdc23e: [ARM] pxa: make cpu_is_pxa2* macros more consistent This patch gets rid of those references, and only keeps cpu_is_pxa25x(). Signed-off-by: Marc Zyngier <maz(a)misterjones.org> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Acked-by: Eric Miao <eric.miao(a)marvell.com> diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index 99026df..34c1d94 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -50,7 +50,7 @@ unsigned short pxa2xx_ac97_read(struct snd_ac97 *ac97, unsigned short reg) mutex_lock(&car_mutex); /* set up primary or secondary codec space */ - if ((cpu_is_pxa21x() || cpu_is_pxa25x()) && reg == AC97_GPIO_STATUS) + if (cpu_is_pxa25x() && reg == AC97_GPIO_STATUS) reg_addr = ac97->num ? &SMC_REG_BASE : &PMC_REG_BASE; else reg_addr = ac97->num ? &SAC_REG_BASE : &PAC_REG_BASE; @@ -90,7 +90,7 @@ void pxa2xx_ac97_write(struct snd_ac97 *ac97, unsigned short reg, mutex_lock(&car_mutex); /* set up primary or secondary codec space */ - if ((cpu_is_pxa21x() || cpu_is_pxa25x()) && reg == AC97_GPIO_STATUS) + if (cpu_is_pxa25x() && reg == AC97_GPIO_STATUS) reg_addr = ac97->num ? &SMC_REG_BASE : &PMC_REG_BASE; else reg_addr = ac97->num ? &SAC_REG_BASE : &PAC_REG_BASE; @@ -200,7 +200,7 @@ static inline void pxa_ac97_cold_pxa3xx(void) bool pxa2xx_ac97_try_warm_reset(struct snd_ac97 *ac97) { #ifdef CONFIG_PXA25x - if (cpu_is_pxa21x() || cpu_is_pxa25x()) + if (cpu_is_pxa25x()) pxa_ac97_warm_pxa25x(); else #endif @@ -230,7 +230,7 @@ EXPORT_SYMBOL_GPL(pxa2xx_ac97_try_warm_reset); bool pxa2xx_ac97_try_cold_reset(struct snd_ac97 *ac97) { #ifdef CONFIG_PXA25x - if (cpu_is_pxa21x() || cpu_is_pxa25x()) + if (cpu_is_pxa25x()) pxa_ac97_cold_pxa25x(); else #endif @@ -301,7 +301,7 @@ EXPORT_SYMBOL_GPL(pxa2xx_ac97_hw_suspend); int pxa2xx_ac97_hw_resume(void) { - if (cpu_is_pxa21x() || cpu_is_pxa25x() || cpu_is_pxa27x()) { + if (cpu_is_pxa25x() || cpu_is_pxa27x()) { pxa_gpio_mode(GPIO31_SYNC_AC97_MD); pxa_gpio_mode(GPIO30_SDATA_OUT_AC97_MD); pxa_gpio_mode(GPIO28_BITCLK_AC97_MD); @@ -325,7 +325,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct platform_device *dev) if (ret < 0) goto err; - if (cpu_is_pxa21x() || cpu_is_pxa25x() || cpu_is_pxa27x()) { + if (cpu_is_pxa25x() || cpu_is_pxa27x()) { pxa_gpio_mode(GPIO31_SYNC_AC97_MD); pxa_gpio_mode(GPIO30_SDATA_OUT_AC97_MD); pxa_gpio_mode(GPIO28_BITCLK_AC97_MD); -- A rat a day keeps the plague away.

2 1

[alsa-devel] [PATCH 2.6.28] Fix pxa2xx-ac97-lib.c compilation
by Mark Brown 14 Oct '08

14 Oct '08

From: Marc Zyngier <maz(a)misterjones.org> The last ALSA merge broke pxa2xx-ac97-lib.c, as it brought back references to cpu_is_pxa21x that Eric Miao removed in commit 0ffcbfd54ea81ca24c0749f55ca4fcf3e2bdc23e: [ARM] pxa: make cpu_is_pxa2* macros more consistent This patch gets rid of those references, and only keeps cpu_is_pxa25x(). Signed-off-by: Marc Zyngier <maz(a)misterjones.org> Acked-by: Eric Miao <eric.miao(a)marvell.com> Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- Please merge into 2.6.28 - this breaks the build on PXA platforms. sound/arm/pxa2xx-ac97-lib.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index 99026df..34c1d94 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -50,7 +50,7 @@ unsigned short pxa2xx_ac97_read(struct snd_ac97 *ac97, unsigned short reg) mutex_lock(&car_mutex); /* set up primary or secondary codec space */ - if ((cpu_is_pxa21x() || cpu_is_pxa25x()) && reg == AC97_GPIO_STATUS) + if (cpu_is_pxa25x() && reg == AC97_GPIO_STATUS) reg_addr = ac97->num ? &SMC_REG_BASE : &PMC_REG_BASE; else reg_addr = ac97->num ? &SAC_REG_BASE : &PAC_REG_BASE; @@ -90,7 +90,7 @@ void pxa2xx_ac97_write(struct snd_ac97 *ac97, unsigned short reg, mutex_lock(&car_mutex); /* set up primary or secondary codec space */ - if ((cpu_is_pxa21x() || cpu_is_pxa25x()) && reg == AC97_GPIO_STATUS) + if (cpu_is_pxa25x() && reg == AC97_GPIO_STATUS) reg_addr = ac97->num ? &SMC_REG_BASE : &PMC_REG_BASE; else reg_addr = ac97->num ? &SAC_REG_BASE : &PAC_REG_BASE; @@ -200,7 +200,7 @@ static inline void pxa_ac97_cold_pxa3xx(void) bool pxa2xx_ac97_try_warm_reset(struct snd_ac97 *ac97) { #ifdef CONFIG_PXA25x - if (cpu_is_pxa21x() || cpu_is_pxa25x()) + if (cpu_is_pxa25x()) pxa_ac97_warm_pxa25x(); else #endif @@ -230,7 +230,7 @@ EXPORT_SYMBOL_GPL(pxa2xx_ac97_try_warm_reset); bool pxa2xx_ac97_try_cold_reset(struct snd_ac97 *ac97) { #ifdef CONFIG_PXA25x - if (cpu_is_pxa21x() || cpu_is_pxa25x()) + if (cpu_is_pxa25x()) pxa_ac97_cold_pxa25x(); else #endif @@ -301,7 +301,7 @@ EXPORT_SYMBOL_GPL(pxa2xx_ac97_hw_suspend); int pxa2xx_ac97_hw_resume(void) { - if (cpu_is_pxa21x() || cpu_is_pxa25x() || cpu_is_pxa27x()) { + if (cpu_is_pxa25x() || cpu_is_pxa27x()) { pxa_gpio_mode(GPIO31_SYNC_AC97_MD); pxa_gpio_mode(GPIO30_SDATA_OUT_AC97_MD); pxa_gpio_mode(GPIO28_BITCLK_AC97_MD); @@ -325,7 +325,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct platform_device *dev) if (ret < 0) goto err; - if (cpu_is_pxa21x() || cpu_is_pxa25x() || cpu_is_pxa27x()) { + if (cpu_is_pxa25x() || cpu_is_pxa27x()) { pxa_gpio_mode(GPIO31_SYNC_AC97_MD); pxa_gpio_mode(GPIO30_SDATA_OUT_AC97_MD); pxa_gpio_mode(GPIO28_BITCLK_AC97_MD); -- 1.5.6.5

2 1

[alsa-devel] [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users
by Mark Brown 14 Oct '08

14 Oct '08

Since Kconfig ignores dependencies on select and other users should select SND_SOC_TLV320AIC26 we can add a dependency on the OpenFirmware helper to avoid exposing the menu entry to users who can't benefit from it. Thanks to Takashi for the suggestion. Signed-off-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/Kconfig | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 4975d85..9242889 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -70,6 +70,9 @@ config SND_SOC_TLV320AIC23 config SND_SOC_TLV320AIC26 tristate "TI TLV320AIC26 Codec support" depends on SPI + # Note the Kconfig doesn't enforce dependencies - this just + # prevents non-OF users seeing the tristate in menus. + depends on SND_SOC_OF_SIMPLE config SND_SOC_TLV320AIC3X tristate -- 1.5.6.5

3 6

[alsa-devel] OMAP3EVM ASOC TWL4030 Audio drivers
by naveen krishna ch 14 Oct '08

14 Oct '08

Hi All, I am using OMAP3 EVM + TWL4030 combination. The ASOC drivers this combination seems to work half way. My problem is when i do a aplay ***.wav it plays fine but when i try to record through the line in with arecord -c 2 -r 8000 -f 8000 -d 10 -t wav record.wav command it does not record any thing. I have used the Gumstix Overo sources as a reference for making the Asoc sources for this combination. Can any one tell me how can i solve this issue. -- Thanks, keep smiling... keep winning... (: Naveen Krishna Ch :)

1 0

[alsa-devel] [PATCH] hda: fix nid variable warning
by Matthew Ranostay 14 Oct '08

14 Oct '08

Fixed compiler warning with possible uninitialized variable 'nid'. CC [M] /home/mranostay/git/alsa-driver/pci/hda/patch_sigmatel.o /home/mranostay/git/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/patch_sigmatel.c: In function ‘stac92xx_parse_auto_config’: /home/mranostay/git/alsa-driver/pci/hda/../../alsa-kernel/pci/hda/patch_sigmatel.c:2815: warning: ‘nid’ may be used uninitialized in this function Signed-off-by: Matthew Ranostay <mranostay(a)embeddedalley.com> --- diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index c461baa..f8bfb4c 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -2812,7 +2812,7 @@ static int stac92xx_auto_create_multi_out_ctls(struct hda_codec *codec, static const char *chname[4] = { "Front", "Surround", NULL /*CLFE*/, "Side" }; - hda_nid_t nid; + hda_nid_t nid = 0; int i, err; struct sigmatel_spec *spec = codec->spec;

2 1

[alsa-devel] [PATCH] ALSA: ASoC: Fix compile-time warning for tlv320aic23.c
by Arun KS 13 Oct '08

13 Oct '08

Fixes this warning: sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_write': sound/soc/codecs/tlv320aic23.c:104: warning: passing argument 2 of 'codec->hw_write' makes pointer from integer without a cast Replaces i2c smbus write function with standard i2c write function Signed-off-by: Arun KS <arunks(a)mistralsolutions.com> --- sound/soc/codecs/tlv320aic23.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c index bac7815..44308da 100644 --- a/sound/soc/codecs/tlv320aic23.c +++ b/sound/soc/codecs/tlv320aic23.c @@ -84,7 +84,7 @@ static int tlv320aic23_write(struct snd_soc_codec *codec, unsigned int reg, unsigned int value) { - u8 data; + u8 data[2]; /* TLV320AIC23 has 7 bit address and 9 bits of data * so we need to switch one data bit into reg and rest @@ -96,12 +96,12 @@ static int tlv320aic23_write(struct snd_soc_codec *codec, unsigned int reg, return -1; } - data = (reg << 1) | (value >> 8 & 0x01); + data[0] = (reg << 1) | (value >> 8 & 0x01); + data[1] = value & 0xff; tlv320aic23_write_reg_cache(codec, reg, value); - if (codec->hw_write(codec->control_data, data, - (value & 0xff)) == 0) + if (codec->hw_write(codec->control_data, data, 2) == 2) return 0; printk(KERN_ERR "%s cannot write %03x to register R%d\n", __func__, @@ -674,7 +674,7 @@ static int tlv320aic23_probe(struct platform_device *pdev) tlv320aic23_socdev = socdev; #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) - codec->hw_write = (hw_write_t) i2c_smbus_write_byte_data; + codec->hw_write = (hw_write_t) i2c_master_send; codec->hw_read = NULL; ret = i2c_add_driver(&tlv320aic23_i2c_driver); if (ret != 0) -- 1.5.3.4

3 2

[alsa-devel] ASUS V1Sn can have digout
by asto 13 Oct '08

13 Oct '08

Regarding this change: http://git.alsa-project.org/?p=alsa-kernel.git;a=commit;h=2522d7359301efadf… (Added support for Asus V1Sn) This card can have digital output, and indeed does in my situation. The patch above added to patch_realtek.c: SND_PCI_QUIRK(0x1043, 0x1633, "Asus V1Sn", ALC861VD_LENOVO) However, ALC861VD_LENOVO definition has no digout Is it possible to have digital out for this device configured in auto-probe rather than map to lenovo ? For now, I add a definition for it based on the lenovo and 3stack-660-digout: to patch_realtek.c [ALC660VD_V1S] = { .mixers = { alc861vd_3st_mixer }, .init_verbs = { alc861vd_volume_init_verbs, alc861vd_3stack_init_verbs, alc861vd_eapd_verbs, alc861vd_lenovo_unsol_verbs }, .num_dacs = ARRAY_SIZE(alc660vd_dac_nids), .dac_nids = alc660vd_dac_nids, .dig_out_nid = ALC861VD_DIGOUT_NID, .num_channel_mode = ARRAY_SIZE(alc861vd_3stack_2ch_modes), .channel_mode = alc861vd_3stack_2ch_modes, .input_mux = &alc861vd_capture_source, .unsol_event = alc861vd_lenovo_unsol_event, .init_hook = alc861vd_lenovo_automute, },

2 1

[alsa-devel] missing subject in my previous email
by Philippe CARRIERE 13 Oct '08

13 Oct '08

Sorry, I realized I omitted the subject in my previous email. Read ehci-hcd patch required by snd-usb-us122l Regards Phil.

1 0

Re: [alsa-devel] [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver
by matthias.nyffenegger＠bluewin.ch 13 Oct '08

13 Oct '08

Hi Takashi, Thank you for your quick answer, I am not that fast ;-) >At the next time, it'd be appreciate if you post the patch itself, >then we can review and give comments on the code in a reply. >Even if it's too big, you can split to several pieces. Ok. >Just checking it now, and soon found out that many components look >similar as AW2. We have already AW2 driver (whose authors cc'ed). >Can you reuse the code? Hm, I'm afraid not at his point. The existing AW2 driver is IMHO a very straight-forward implementation - with focus on AW2 - and does not provide generic code parts (apart saa7146 register addr. definitions) for reuse. Maybe that's why it has its own directory not named after the chipset? Besides that I have put much emphasis on providing an abstraction-layer for saa7146 chipset audio functionality, on top of which the audiowerk specific stuff is built. Hence it does not make much sense to me trying to reuse code of the existing AW2 driver. I hope you see my point and would appreciate your opinion on this. regards, Matthias ----Ursprüngliche Nachricht---- Von: tiwai(a)suse.de Datum: 19.09.2008 17:55 An: <matthias.nyffenegger(a)bluewin.ch> Kopie: "Cedric Bregardis"<cedric.bregardis(a)free.fr>, "Jean-Christian Hassler"<jhassler(a)free.fr>, <alsa-devel@alsa- project.org> Betreff: Re: [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver At Fri, 19 Sep 2008 09:10:00 +0000 (GMT), matthias.nyffenegger(a)bluewin.ch wrote: > > From: Matthias Nyffenegger <matthias.nyffenegger(a)bluewin.ch> > > Low-level ALSA driver for Emagic Audiowerk8 sound card. > Project page: http://sourceforge.net/projects/aw8-alsa First off, thanks for your patch. At the next time, it'd be appreciate if you post the patch itself, then we can review and give comments on the code in a reply. Even if it's too big, you can split to several pieces. > Built and tested with Vanilla 2.6.25.16, ALSA 1.0.14a. > > Signed-off-by: Matthias Nyffenegger <matthias.nyffenegger(a)bluewin.ch> > --- > This is a request for submission to ALSA-tree. > URL: http://downloads.sourceforge.net/aw8-alsa/aw-alsa-patch-0.2 Just checking it now, and soon found out that many components look similar as AW2. We have already AW2 driver (whose authors cc'ed). Can you reuse the code? thanks, Takashi

2 1

Re: [alsa-devel] Backported sbxfi driver (UNTESTED!)
by Takashi Iwai 13 Oct '08

13 Oct '08

At Fri, 10 Oct 2008 20:39:48 +0400, The Source wrote: > > 2008/10/10 Takashi Iwai <tiwai(a)suse.de> > > At Fri, 10 Oct 2008 01:26:15 -0500, > Ted T. Logian wrote: > > > > > > > > On Fri, 2008-10-10 at 08:01 +0200, Takashi Iwai wrote: > > > At Thu, 09 Oct 2008 15:17:58 -0500, > > > Ted T. Logian wrote: > > > > > > > > Sorry for the multiple posts, but once I rmmod snd-sbxfi, running > mixer does > > > > fine. It seems if I have snd-sbxfi loaded and I run alsamixer, it > locks the > > > > entire system. > > > > > > So, do you mean loading the driver itself doesn't lock up? If so, > > > it's better than I expected. > > > > > > Did you run ever PCM playback/capture before that? This is more > > > dangerous :) > > > > > > Also, please give your hardware details, as there are different models > > > for X-Fi, and some are handled pretty differently. > > > > > > [BTW, please stop top-posting, and avoid HTML mails for ML. It's easy > > > to switch to normal (plain) mail mode on Gmail, just a click.] > > > > > > > > > thanks, > > > > > > Takashi > > > > > > I think perhaps from uninstalling pulseaudio I got further. I can use > > mixer now, and it even has a "Master" device, but nothing else... > > > > however, I do get a lock up later. > > > > I get this from running aplay, too, if this helps... > > Thanks! That's rather a stupid bug. > The patch is below. > > Takashi > > diff --git a/sound/pci/sbxfi/sbxfi.c b/sound/pci/sbxfi/sbxfi.c > index 8066bf4..8a0eea0 100644 > --- a/sound/pci/sbxfi/sbxfi.c > +++ b/sound/pci/sbxfi/sbxfi.c > @@ -831,7 +831,7 @@ static struct sbxfi_port *sbxfi_port_alloc(struct > sbxfi *chip, > port->src[0] = src; > port->src[1] = src + 1; > spin_lock_irq(&chip->port_lock); > - list_add(&chip->port_list, &port->list); > + list_add(&port->list, &chip->port_list); > spin_unlock_irq(&chip->port_lock); > return port; > } > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > Hello, I have tried the driver with the fix you provided, but I couldn't get > anything. Kernel panic on any attempt to use sound or mixer. Also kernel panic > several seconds after Xorg starts. Each crash causes either hang or reboot so > I couldn't get any error messages. If there are some logs left, please tell me > where they are and I'll send them to you. > My card is X-Fi Platinum Fatality Champion Series. For testing, first try without X but just use Linux console, so that you have a better chance to see Oops messages. It's pretty important to see whether it's an Oops or a panic. Also, double-check whether you really installed the corrected drivers. Often it's missing in the right place by stupid reasons. For first tests, don't use any sound server. Try with aplay like: % aplay -Dhw foo.wav Try first 96kHz samples, 48kHz samples, and then others. thanks, Takashi

5 9

[alsa-devel] Creative Sound Blaster 5.1vx
by Zhi Xiong 13 Oct '08

13 Oct '08

Hi, I own a creative sound blaster 5.1vx card, its model is sb1070, and its based on CA0106 and an ADC I believed to be a WM8772S(74AAWR2) chip, for the rest, my weak eyes can't really see it. I tested the driver on 2.6.20 and 2.6.26, both of them didn't work, so I believed this model is not yet "supported" by the driver, I added the lines below into ca0106_chip_details inside ca0106_main.c and the card works. { .serial = 0x10041102, .name = "Sound Blaster 5.1vx [SB1070]", .gpio_type = 1, .i2c_adc = 1, .spi_dac = 1 } , But I don't really know what gpio_type, .i2c_adc, .spi_dac . I do noticed that setting gpio_type to 1 or 2 will work and not setting it will have some performance issue. I wish can write the code more accurately to the specs and hopefully this few lines of code will get added to the next alsa release for others to use. So, can anyone please explain to me what the 3 parameters do? Thanks in advanced. -- Cheers, Zhi Xiong

2 1

[alsa-devel] Issue with onboard sound on Toshiba A110-225
by Travis Place 13 Oct '08

13 Oct '08

Hey all, When working out an issue for a person in #alsa, i found that the onboard sound in their laptop (A110-225) has the Subsystem IDs 1179:ff01 . The card has an ALC861 codec.. the issue (non-fatal thankfully) is that the above mentioned Subsystem IDs match in patch_realtek.c to 'dallas' which is for an ALC861VD codec.. SND_PCI_QUIRK(0x1179, 0xff01, "DALLAS", ALC861VD_DALLAS), The user was getting the non-fatal: hda_codec: Unknown model for ALC861, trying auto-probe from BIOS... in dmesg.. I had the user force the 'toshiba' model (which is valid for ALC861) and the warning went away, and sound continues to work as it should.. Just wanted to make sure this problem (even though non-fatal) is documented, and we are aware of it. Perhaps this laptop, and the 'Dallas' need to be matched on some other level. Thanks, Travis Place (wishie)

2 2

Re: [alsa-devel] Backported sbxfi driver (UNTESTED!)
by Takashi Iwai 13 Oct '08

13 Oct '08

At Sun, 12 Oct 2008 20:16:10 -0500, Christopher Lemire wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Sun, Oct 12, 2008 at 2:34 PM, Takashi Iwai wrote: > > At Sat, 11 Oct 2008 13:04:02 -0500, > > William Pitcock wrote: > >> > >> Hi, > >> > >> On Sat, 2008-10-11 at 19:41 +0200, Takashi Iwai wrote: > >> > Could you build with XXX_CONST_TIMER defined? This will disable the > >> > adaptive timer-resolution handling I added to the driver, which > >> > doesn't > >> > exist in OSS sbxfi code at all. > >> > >> No change in behaviour. It survives a little longer, but then the system > >> hardlocks... without me even touching the keyboard even. > > > > This can be a spin deadlock I fixed today. > > Could you try the latest sound-unstable GIT or snapshot tarball? > > > > Also, now the driver has "debug" module option. As default, it's 1, > > and the driver shows some debug messages. When it's 2, it shows more > > often, e.g. at each IRQ. When it's 3, it shows all register accesses. > > > > The debug option can be changed even dynamically via sysfs. Write > > /sys/modules/snd_sbxfi/parameters/debug file as root, > > # echo 3 > /sys/modules/..../debug > > > > Just a note before I go to bed :) > > > > Takashi > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel(a)alsa-project.org > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > > Would someone mind telling me how I can put my card in hda-intel mode > and use the snd-hda-intel driver with it? I read it was possible to do > that with the creative windows software but didn't see that anywhere. > Is there any reason I shouldn't do that? Do I really need any Xfi > driver when I can do that? My Xfi card is a newer one that should have > the hda-intel mode. It's Vista compatible (though I use it dual boot > with xp) and a newer PCIe model called Titanium. It's newer than the > Creative Linux beta driver, so it will not work with that or OSS4. I > just removed OSS4 and going back to Alsa to test that snd-sbxfi > because OSS4 would crash my computer with this sound card. I think the > OSS4 was written for older Xfi models, not this newer PCIe model I > have. Chances of me getting it to work in Linux aren't good, so I'll > probably be doing a RMA on it in the next few days before I run out of > time to do that and going back to using onboard audio. The sound-unstable tree contains the HD-audio X-Fi support, but right now it's disabled due to possible conflicts of drivers. Just uncomment the corresponding entries in PCI entries of sound/pci/hda_intel.c. Takashi

1 0