[alsa-devel] [PATCH 11/11] ASoC: wm8994: Mark expected switch fall-through
Gustavo A. R. Silva
gustavo at embeddedor.com
Fri Aug 3 20:24:20 CEST 2018
On 08/03/2018 12:55 PM, valdis.kletnieks at vt.edu wrote:
> On Fri, 03 Aug 2018 11:56:12 -0500, "Gustavo A. R. Silva" said:
>> On 08/03/2018 11:45 AM, Mark Brown wrote:
>>> Basically nobody ever uses OPCLK so I'd be susprised if anyone ever
>>> noticed.
>
> I wonder if nobody uses it because any attempts to do so get an error? :)
>
>> I see. I wonder what's the best approach in this case. Should that code be
>> removed instead of 'fixed'?
>
> I'm thinking that's a spot that needs a 'break;' added.
>
Yep. And I think the patch to fix this should be tagged for stable.
So, it seems we have two options:
1. Revert commit 2cea1542859bc812f1ec51ea71c06e927e5b922e and then apply a fix with the break statement.
or
2. Apply a fix with the break statement and then backport the fix to stable.
am I correct?
Thanks
--
Gustavo
More information about the Alsa-devel
mailing list