[alsa-devel] HP mute led for ALC286
Kailang
kailang at realtek.com
Fri Nov 21 08:56:29 CET 2014
Hi Takashi,
I'm sorry for that. Maybe I had not do git pull.
BR,
Kailang
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Thursday, November 20, 2014 6:06 PM
> To: Kailang
> Cc: (alsa-devel at alsa-project.org)
> Subject: Re: HP mute led for ALC286
>
> At Thu, 20 Nov 2014 07:04:01 +0000,
> Kailang wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai at suse.de]
> > > Sent: Wednesday, November 19, 2014 7:28 PM
> > > To: Kailang
> > > Cc: (alsa-devel at alsa-project.org)
> > > Subject: Re: HP mute led for ALC286
> > >
> > > At Wed, 19 Nov 2014 07:13:16 +0000,
> > > Kailang wrote:
> > > >
> > > > Hi Takashi,
> > > >
> > > > I had sent the discussion mail about the DMI string for HP.
> > > > But no body response.
> > > > So, I just send the patch to fix this issue.
> > >
> > > I'd like to avoid the duplicated open codes, so could you try the
> > > patch below and rewrite your patch to follow this? You'd
> just need
> > > to set like:
> > > spec->gpio_mute_led_mask = 0x02;
> > > spec->gpio_mic_led_mask = 0x20;
> > > pec->mute_led_polarity = 0;
> > > then you can use the existing alc_fixup_gpio_mute_hook and
> > > alc_fixup_gpio_mic_mute_hook.
> >
> > I modified as attach patch. ^^
>
> Oh, no, I meant an additional patch on top of my previous
> patch, not folding into that one.
>
> For your ease, I applied my patch to for-next branch now, so
> that you can rewrite the patch to be applicable to there.
>
>
> thanks,
>
> Takashi
>
> ------Please consider the environment before printing this e-mail.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-supported-HP-mute-led-alc286.patch
Type: application/octet-stream
Size: 2562 bytes
Desc: 0002-supported-HP-mute-led-alc286.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141121/22775509/attachment.obj>
More information about the Alsa-devel
mailing list