[alsa-devel] HP mute led for ALC286

Takashi Iwai tiwai at suse.de
Thu Nov 20 11:05:50 CET 2014


At Thu, 20 Nov 2014 07:04:01 +0000,
Kailang wrote:
> 
>  
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai at suse.de] 
> > Sent: Wednesday, November 19, 2014 7:28 PM
> > To: Kailang
> > Cc: (alsa-devel at alsa-project.org)
> > Subject: Re: HP mute led for ALC286
> > 
> > At Wed, 19 Nov 2014 07:13:16 +0000,
> > Kailang wrote:
> > > 
> > > Hi Takashi,
> > > 
> > > I had sent the discussion mail about the DMI string for HP.
> > > But no body response.
> > > So, I just send the patch to fix this issue.
> > 
> > I'd like to avoid the duplicated open codes, so could you try 
> > the patch below and rewrite your patch to follow this?  You'd 
> > just need to set like:
> >   spec->gpio_mute_led_mask = 0x02;
> >   spec->gpio_mic_led_mask = 0x20;
> >   pec->mute_led_polarity = 0;
> > then you can use the existing alc_fixup_gpio_mute_hook and 
> > alc_fixup_gpio_mic_mute_hook.
> 
> I modified as attach patch. ^^

Oh, no, I meant an additional patch on top of my previous patch, not
folding into that one.

For your ease, I applied my patch to for-next branch now, so that you
can rewrite the patch to be applicable to there.


thanks,

Takashi


More information about the Alsa-devel mailing list