August 2022 - Sound-open-firmware - mailman.alsa-project.org

[Sound-open-firmware] [PATCH v2 0/2] Introduce sof_of_machine_select
by Chunxu Li 02 Sep '22

02 Sep '22

From: "chunxu.li" <chunxu.li(a)mediatek.com> Change since v1: - remove the callback of_machine_select defined in sof-priv.h - move sof_of_machine_select to common code, and called in sof_machine_check - rename .board field to .compatible in structure snd_sof_of_mach In these patches, we introduce function sof_of_machine_select for SOF Chunxu Li (2): ASoC: SOF: Introduce function sof_of_machine_select ASoC: SOF: mediatek: Add sof_mt8186_machs for mt8186 include/sound/sof.h | 2 ++ sound/soc/sof/mediatek/mt8186/mt8186.c | 9 ++++++++ sound/soc/sof/pcm.c | 8 ++++++- sound/soc/sof/sof-audio.c | 30 ++++++++++++++++++++++++++ sound/soc/sof/sof-of-dev.h | 7 ++++++ 5 files changed, 55 insertions(+), 1 deletion(-) -- 2.25.1

3 4

[Sound-open-firmware] sof-logger status on SOF with Zephyr
by Daniel Baluta 29 Aug '22

29 Aug '22

Hi Liam, What is the plan for sof-logger with SOF-Zephyr? Is it working on Intel platforms? We are now planning on looking at it and we want to understand if it will be used in the future. For now on i.MX the logger is disabled. thanks, daniel.

3 2

[Sound-open-firmware] [PATCH 0/3] ASoC: SOF: mediatek: update SOF driver for mt8186
by Chunxu Li 25 Aug '22

25 Aug '22

In these patches, we update SOF driver for mt8186 Chunxu Li (3): ASoC: SOF: mediatek: Add dai driver for mt8186 ASoC: SOF: mediatek: add snd_sof_dsp_ops callbacks for pcm and mail box ASoC: SOF: mediatek: Use generic implementation for .ipc_msg_data field sound/soc/sof/mediatek/mt8186/mt8186.c | 49 ++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 7 deletions(-) -- 2.25.1

2 4

[Sound-open-firmware] [PATCH -next 1/2] ASoC: SOF: imx8ulp: change es8326_regmap_config to static
by Yang Yingliang 24 Aug '22

24 Aug '22

sof_imx8ulp_ops is only used in imx8ulp.c now, change it to static. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/sof/imx/imx8ulp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/imx/imx8ulp.c b/sound/soc/sof/imx/imx8ulp.c index 02b496165acc..afab7feab5fb 100644 --- a/sound/soc/sof/imx/imx8ulp.c +++ b/sound/soc/sof/imx/imx8ulp.c @@ -413,7 +413,7 @@ static int imx8ulp_dsp_set_power_state(struct snd_sof_dev *sdev, } /* i.MX8 ops */ -struct snd_sof_dsp_ops sof_imx8ulp_ops = { +static struct snd_sof_dsp_ops sof_imx8ulp_ops = { /* probe and remove */ .probe = imx8ulp_probe, .remove = imx8ulp_remove, -- 2.25.1

2 2

[Sound-open-firmware] Zephyr memory allocation from heap
by Daniel Baluta 23 Aug '22

23 Aug '22

Hi guys, Did you encountered any problems with memory allocations when switching to Zephyr? I'm facing a very strange issue with a playback pipeline with module adapter (MP3) where it looks like the DAI hits underruns as soon as I start the pipeline. With normal PCM playback everything works fine. I think it might be a problem in the sense Zephyr allocates memory and/or Cadence memory alignment requirements? Looks like as soon as I change this: -#define PLATFORM_DCACHE_ALIGN sizeof(void *) +#define PLATFORM_DCACHE_ALIGN 32 everything seems to work. But I cannot find any logical explanation.

6 8

[Sound-open-firmware] [linux-next:master] BUILD REGRESSION cc2986f4dc67df7e6209e0cd74145fffbd30d693
by kernel test robot 22 Aug '22

22 Aug '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: cc2986f4dc67df7e6209e0cd74145fffbd30d693 Add linux-next specific files for 20220822 Error/Warning: (recently discovered and may have been fixed) drivers/base/regmap/regmap-mmio.c:221:17: error: implicit declaration of function 'writesb'; did you mean 'writeb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:224:17: error: implicit declaration of function 'writesw'; did you mean 'writew'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:227:17: error: implicit declaration of function 'writesl'; did you mean 'writel'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writeq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writesl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:358:17: error: implicit declaration of function 'readsb'; did you mean 'readb'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:361:17: error: implicit declaration of function 'readsw'; did you mean 'readw'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:364:17: error: implicit declaration of function 'readsl'; did you mean 'readl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readsl'? [-Werror=implicit-function-declaration] drivers/platform/mellanox/mlxreg-lc.c:866 mlxreg_lc_probe() warn: passing zero to 'PTR_ERR' sound/soc/sof/compress.c:330:13: warning: variable 'dai_posn' set but not used [-Wunused-but-set-variable] Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allmodconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- alpha-allyesconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used |-- alpha-buildonly-randconfig-r001-20220822 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- alpha-buildonly-randconfig-r006-20220821 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- alpha-randconfig-r031-20220822 | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsw | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesb | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesl | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesw |-- arc-allyesconfig | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used |-- arm-allyesconfig | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used clang_recent_errors |-- hexagon-randconfig-r001-20220821 | |-- include-asm-generic-io.h:error:conflicting-types-for-insb | |-- include-asm-generic-io.h:error:conflicting-types-for-insl | |-- include-asm-generic-io.h:error:conflicting-types-for-insw | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_fromio | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_toio | |-- include-asm-generic-io.h:error:conflicting-types-for-outsb | |-- include-asm-generic-io.h:error:conflicting-types-for-outsl | |-- include-asm-generic-io.h:error:conflicting-types-for-outsw | |-- include-asm-generic-io.h:error:redefinition-of-memset_io | |-- include-asm-generic-io.h:error:redefinition-of-phys_to_virt | |-- include-asm-generic-io.h:error:redefinition-of-readb | |-- include-asm-generic-io.h:error:redefinition-of-readl | |-- include-asm-generic-io.h:error:redefinition-of-readw | |-- include-asm-generic-io.h:error:redefinition-of-virt_to_phys | |-- include-asm-generic-io.h:error:redefinition-of-writeb | |-- include-asm-generic-io.h:error:redefinition-of-writel | `-- include-asm-generic-io.h:error:redefinition-of-writew |-- hexagon-randconfig-r004-20220822 | |-- include-asm-generic-io.h:error:conflicting-types-for-insb | |-- include-asm-generic-io.h:error:conflicting-types-for-insl | |-- include-asm-generic-io.h:error:conflicting-types-for-insw | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_fromio | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_toio | |-- include-asm-generic-io.h:error:conflicting-types-for-outsb | |-- include-asm-generic-io.h:error:conflicting-types-for-outsl | |-- include-asm-generic-io.h:error:conflicting-types-for-outsw | |-- include-asm-generic-io.h:error:redefinition-of-memset_io | |-- include-asm-generic-io.h:error:redefinition-of-phys_to_virt | |-- include-asm-generic-io.h:error:redefinition-of-readb | |-- include-asm-generic-io.h:error:redefinition-of-readl | |-- include-asm-generic-io.h:error:redefinition-of-readw | |-- include-asm-generic-io.h:error:redefinition-of-virt_to_phys | |-- include-asm-generic-io.h:error:redefinition-of-writeb | |-- include-asm-generic-io.h:error:redefinition-of-writel | `-- include-asm-generic-io.h:error:redefinition-of-writew |-- hexagon-randconfig-r032-20220821 | |-- include-asm-generic-io.h:error:conflicting-types-for-insb | |-- include-asm-generic-io.h:error:conflicting-types-for-insl | |-- include-asm-generic-io.h:error:conflicting-types-for-insw | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_fromio | |-- include-asm-generic-io.h:error:conflicting-types-for-memcpy_toio | |-- include-asm-generic-io.h:error:conflicting-types-for-outsb | |-- include-asm-generic-io.h:error:conflicting-types-for-outsl | |-- include-asm-generic-io.h:error:conflicting-types-for-outsw | |-- include-asm-generic-io.h:error:redefinition-of-memset_io | |-- include-asm-generic-io.h:error:redefinition-of-phys_to_virt | |-- include-asm-generic-io.h:error:redefinition-of-readb | |-- include-asm-generic-io.h:error:redefinition-of-readl | |-- include-asm-generic-io.h:error:redefinition-of-readw elapsed time: 721m configs tested: 76 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig x86_64 randconfig-a012-20220822 x86_64 randconfig-a013-20220822 x86_64 randconfig-a011-20220822 i386 randconfig-a014-20220822 x86_64 defconfig i386 randconfig-a013-20220822 i386 randconfig-a011-20220822 csky allnoconfig x86_64 randconfig-a016-20220822 arc allnoconfig x86_64 randconfig-a014-20220822 i386 randconfig-a012-20220822 alpha allnoconfig x86_64 randconfig-a015-20220822 i386 defconfig i386 randconfig-a016-20220822 x86_64 rhel-8.3 arm defconfig riscv allnoconfig arc randconfig-r043-20220821 arm sama5_defconfig mips jazz_defconfig x86_64 allyesconfig i386 randconfig-a015-20220822 powerpc allnoconfig alpha allyesconfig m68k apollo_defconfig arc randconfig-r043-20220822 m68k allmodconfig arc allyesconfig arm lart_defconfig riscv randconfig-r042-20220822 sh se7724_defconfig m68k m5275evb_defconfig arm allyesconfig arm64 allyesconfig x86_64 rhel-8.3-func i386 allyesconfig x86_64 rhel-8.3-kunit s390 randconfig-r044-20220822 x86_64 rhel-8.3-kvm x86_64 rhel-8.3-kselftests sh allmodconfig x86_64 rhel-8.3-syz mips allyesconfig sh sh7770_generic_defconfig powerpc allmodconfig ia64 allmodconfig m68k allyesconfig clang tested configs: i386 randconfig-a001-20220822 i386 randconfig-a002-20220822 i386 randconfig-a003-20220822 i386 randconfig-a005-20220822 i386 randconfig-a004-20220822 i386 randconfig-a006-20220822 x86_64 randconfig-a002-20220822 x86_64 randconfig-a004-20220822 hexagon randconfig-r041-20220822 arm neponset_defconfig powerpc katmai_defconfig x86_64 randconfig-a003-20220822 mips maltaaprp_defconfig x86_64 randconfig-a001-20220822 x86_64 randconfig-a006-20220822 x86_64 randconfig-a005-20220822 hexagon randconfig-r045-20220822 hexagon randconfig-r045-20220821 hexagon randconfig-r041-20220821 s390 randconfig-r044-20220821 riscv randconfig-r042-20220821 mips bcm63xx_defconfig powerpc socrates_defconfig powerpc powernv_defconfig x86_64 rhel-8.3-rust -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[Sound-open-firmware] [RESEND PATCH v2 1/2] dt-bindings: dsp: fsl: Add SOF compatile string for i.MX8ULP
by Shengjiu Wang 20 Aug '22

20 Aug '22

Add SOF compatile string "fsl,imx8ulp-dsp" for supporting DSP device on i.MX8ULP platform. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> Acked-by: Rob Herring <robh(a)kernel.org> --- changes in v2 - add acked-by Rob Documentation/devicetree/bindings/dsp/fsl,dsp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index e66ef2da7879..9af40da5688e 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -20,6 +20,7 @@ properties: - fsl,imx8qxp-dsp - fsl,imx8qm-dsp - fsl,imx8mp-dsp + - fsl,imx8ulp-dsp - fsl,imx8qxp-hifi4 - fsl,imx8qm-hifi4 - fsl,imx8mp-hifi4 -- 2.34.1

3 4

[Sound-open-firmware] [linux-next:master] BUILD REGRESSION 8755ae45a9e8ae883fa7f4eb0162830c55aacf14
by kernel test robot 19 Aug '22

19 Aug '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 8755ae45a9e8ae883fa7f4eb0162830c55aacf14 Add linux-next specific files for 20220819 Error/Warning reports: https://lore.kernel.org/linux-doc/202208192207.a0rAM0nj-lkp@intel.com Error/Warning: (recently discovered and may have been fixed) Documentation/translations/zh_CN/process/5.Posting.rst:197: WARNING: undefined label: cn_email_clients (if the link has no caption the label must precede a section header) drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writeq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:231:17: error: implicit declaration of function 'writesq'; did you mean 'writesl'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readq'? [-Werror=implicit-function-declaration] drivers/base/regmap/regmap-mmio.c:368:17: error: implicit declaration of function 'readsq'; did you mean 'readsl'? [-Werror=implicit-function-declaration] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1046:5: warning: no previous prototype for 'fill_dc_scaling_info' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1222:6: warning: no previous prototype for 'handle_cursor_update' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:152:6: warning: no previous prototype for 'modifier_has_dcc' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1576:5: warning: no previous prototype for 'amdgpu_dm_plane_init' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:157:10: warning: no previous prototype for 'modifier_gfx9_swizzle_mode' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:752:5: warning: no previous prototype for 'fill_plane_buffer_attributes' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for 'amd_get_format_info' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:88:6: warning: no previous prototype for 'fill_blending_from_plane_state' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:992:5: warning: no previous prototype for 'dm_plane_helper_check_state' [-Wmissing-prototypes] drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:905:28: warning: variable 'top' set but not used [-Wunused-but-set-variable] drivers/platform/mellanox/mlxreg-lc.c:866 mlxreg_lc_probe() warn: passing zero to 'PTR_ERR' sound/soc/sof/compress.c:330:13: warning: variable 'dai_posn' set but not used [-Wunused-but-set-variable] sound/soc/sof/intel/hda-codec.c:216:17: error: too few arguments to function 'hda_codec_device_init' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allmodconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | `-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq |-- alpha-allyesconfig | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-readsq | |-- drivers-base-regmap-regmap-mmio.c:error:implicit-declaration-of-function-writesq | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amd_get_format_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amdgpu_dm_plane_init | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-dm_plane_helper_check_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_blending_from_plane_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_dc_scaling_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_plane_buffer_attributes | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-handle_cursor_update | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_gfx9_swizzle_mode | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_has_dcc | |-- drivers-gpu-drm-msm-disp-dpu1-dpu_kms.c:warning:variable-top-set-but-not-used | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used |-- alpha-randconfig-r002-20220819 | `-- sound-soc-sof-intel-hda-codec.c:error:too-few-arguments-to-function-hda_codec_device_init |-- arc-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amd_get_format_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amdgpu_dm_plane_init | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-dm_plane_helper_check_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_blending_from_plane_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_dc_scaling_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_plane_buffer_attributes | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-handle_cursor_update | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_gfx9_swizzle_mode | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_has_dcc | |-- drivers-gpu-drm-msm-disp-dpu1-dpu_kms.c:warning:variable-top-set-but-not-used | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used |-- arm-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amd_get_format_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amdgpu_dm_plane_init | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-dm_plane_helper_check_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_blending_from_plane_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_dc_scaling_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_plane_buffer_attributes | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-handle_cursor_update | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_gfx9_swizzle_mode | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-modifier_has_dcc | |-- drivers-gpu-drm-msm-disp-dpu1-dpu_kms.c:warning:variable-top-set-but-not-used | `-- sound-soc-sof-compress.c:warning:variable-dai_posn-set-but-not-used |-- arm-defconfig | `-- drivers-gpu-drm-msm-disp-dpu1-dpu_kms.c:warning:variable-top-set-but-not-used |-- arm64-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amd_get_format_info | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-amdgpu_dm_plane_init | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-dm_plane_helper_check_state | |-- drivers-gpu-drm-amd-amdgpu-..-display-amdgpu_dm-amdgpu_dm_plane.c:warning:no-previous-prototype-for-fill_blending_from_plane_state elapsed time: 723m configs tested: 66 configs skipped: 2 gcc tested configs: um i386_defconfig um x86_64_defconfig arc randconfig-r043-20220819 i386 defconfig i386 randconfig-a001 x86_64 randconfig-a013 x86_64 randconfig-a006 x86_64 defconfig x86_64 rhel-8.3-func arm defconfig x86_64 randconfig-a011 i386 randconfig-a003 x86_64 randconfig-a015 x86_64 rhel-8.3-kunit i386 randconfig-a014 i386 randconfig-a005 x86_64 rhel-8.3-kselftests i386 randconfig-a012 powerpc allnoconfig x86_64 rhel-8.3 powerpc allmodconfig sh allmodconfig mips allyesconfig i386 randconfig-a016 openrisc defconfig powerpc tqm8xx_defconfig x86_64 rhel-8.3-kvm x86_64 rhel-8.3-syz sh lboxre2_defconfig arm allyesconfig i386 allyesconfig arm64 allyesconfig m68k allmodconfig x86_64 allyesconfig arc allyesconfig alpha allyesconfig m68k allyesconfig arm viper_defconfig ia64 allmodconfig mips maltaup_xpa_defconfig sh ap325rxa_defconfig arc allnoconfig alpha allnoconfig riscv allnoconfig csky allnoconfig clang tested configs: hexagon randconfig-r045-20220819 hexagon randconfig-r041-20220819 x86_64 randconfig-a016 riscv randconfig-r042-20220819 s390 randconfig-r044-20220819 i386 randconfig-a013 x86_64 randconfig-a005 x86_64 randconfig-a012 i386 randconfig-a015 x86_64 randconfig-a014 i386 randconfig-a002 arm spitz_defconfig i386 randconfig-a011 i386 randconfig-a006 i386 randconfig-a004 mips maltaaprp_defconfig powerpc lite5200b_defconfig mips malta_kvm_defconfig powerpc tqm8540_defconfig powerpc mpc832x_mds_defconfig x86_64 rhel-8.3-rust -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[Sound-open-firmware] [PATCH -next] ASoC: SOF: ipc4-topology: fix wrong use of sizeof in sof_ipc4_widget_setup_comp_src()
by Yang Yingliang 18 Aug '22

18 Aug '22

It should be size of the struct sof_ipc4_src, not data pointer pass to sof_update_ipc_object(). Fixes: b85f4fc40d56 ("ASoC: SOF: add ipc4 SRC module support") Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/sof/ipc4-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index af072b484a60..c6abfaf5d532 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -771,7 +771,7 @@ static int sof_ipc4_widget_setup_comp_src(struct snd_sof_widget *swidget) goto err; ret = sof_update_ipc_object(scomp, src, SOF_SRC_TOKENS, swidget->tuples, - swidget->num_tuples, sizeof(src), 1); + swidget->num_tuples, sizeof(*src), 1); if (ret) { dev_err(scomp->dev, "Parsing SRC tokens failed\n"); goto err; -- 2.25.1

3 2

[Sound-open-firmware] [PATCH AUTOSEL 5.18 17/39] ASoC: SOF: Intel: hda: add sanity check on SSP index reported by NHLT
by Sasha Levin 14 Aug '22

14 Aug '22

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> [ Upstream commit e51699505042fb365df3a0ce68b850ccd9ad0108 ] We should have a limited trust in the BIOS and verify that the SSP index reported in NHLT is valid for each platform. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Link: https://lore.kernel.org/r/20220725195343.145603-2-pierre-louis.bossart@linu… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/hda.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c index 9c97c80a7f48..b688caa34774 100644 --- a/sound/soc/sof/intel/hda.c +++ b/sound/soc/sof/intel/hda.c @@ -1375,6 +1375,7 @@ struct snd_soc_acpi_mach *hda_machine_select(struct snd_sof_dev *sdev) if (mach->tplg_quirk_mask & SND_SOC_ACPI_TPLG_INTEL_SSP_NUMBER && mach->mach_params.i2s_link_mask) { + const struct sof_intel_dsp_desc *chip = get_chip_info(sdev->pdata); int ssp_num; if (hweight_long(mach->mach_params.i2s_link_mask) > 1 && @@ -1384,6 +1385,12 @@ struct snd_soc_acpi_mach *hda_machine_select(struct snd_sof_dev *sdev) /* fls returns 1-based results, SSPs indices are 0-based */ ssp_num = fls(mach->mach_params.i2s_link_mask) - 1; + if (ssp_num >= chip->ssp_count) { + dev_err(sdev->dev, "Invalid SSP %d, max on this platform is %d\n", + ssp_num, chip->ssp_count); + return NULL; + } + tplg_filename = devm_kasprintf(sdev->dev, GFP_KERNEL, "%s%s%d", sof_pdata->tplg_filename, -- 2.35.1

1 0

[Sound-open-firmware] [PATCH AUTOSEL 5.19 14/48] ASoC: SOF: sof-client-probes: Only load the driver if IPC3 is used
by Sasha Levin 14 Aug '22

14 Aug '22

From: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> [ Upstream commit 9b93eda355089b36482f7a2f134bdd24be70f907 ] The current implementation of probes only supports IPC3 and should not be loaded for other IPC implementation. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Link: https://lore.kernel.org/r/20220712131022.1124-1-peter.ujfalusi@linux.intel.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/sof-client-probes.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/sof/sof-client-probes.c b/sound/soc/sof/sof-client-probes.c index 34e6bd356e71..60e4250fac87 100644 --- a/sound/soc/sof/sof-client-probes.c +++ b/sound/soc/sof/sof-client-probes.c @@ -693,6 +693,10 @@ static int sof_probes_client_probe(struct auxiliary_device *auxdev, if (!sof_probes_enabled) return -ENXIO; + /* only ipc3 is supported */ + if (sof_client_get_ipc_type(cdev) != SOF_IPC) + return -ENXIO; + if (!dev->platform_data) { dev_err(dev, "missing platform data\n"); return -ENODEV; -- 2.35.1

1 0

[Sound-open-firmware] [PATCH AUTOSEL 5.19 13/48] ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware boot
by Sasha Levin 14 Aug '22

14 Aug '22

From: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> [ Upstream commit 499cc881b09c8283ab5e75b0d6d21cb427722161 ] It is not yet clear, but it is possible to create a firmware so broken that it will send a reply message before a FW_READY message (it is not yet clear if FW_READY will arrive later). Since the reply_data is allocated only after the FW_READY message, this will lead to a NULL pointer dereference if not filtered out. The issue was reported with IPC4 firmware but the same condition is present for IPC3. Reported-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20220712122357.31282-3-peter.ujfalusi@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/hda-ipc.c | 39 ++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/sound/soc/sof/intel/hda-ipc.c b/sound/soc/sof/intel/hda-ipc.c index f08011249955..65e688f749ea 100644 --- a/sound/soc/sof/intel/hda-ipc.c +++ b/sound/soc/sof/intel/hda-ipc.c @@ -148,17 +148,23 @@ irqreturn_t hda_dsp_ipc4_irq_thread(int irq, void *context) if (primary & SOF_IPC4_MSG_DIR_MASK) { /* Reply received */ - struct sof_ipc4_msg *data = sdev->ipc->msg.reply_data; + if (likely(sdev->fw_state == SOF_FW_BOOT_COMPLETE)) { + struct sof_ipc4_msg *data = sdev->ipc->msg.reply_data; - data->primary = primary; - data->extension = extension; + data->primary = primary; + data->extension = extension; - spin_lock_irq(&sdev->ipc_lock); + spin_lock_irq(&sdev->ipc_lock); - snd_sof_ipc_get_reply(sdev); - snd_sof_ipc_reply(sdev, data->primary); + snd_sof_ipc_get_reply(sdev); + snd_sof_ipc_reply(sdev, data->primary); - spin_unlock_irq(&sdev->ipc_lock); + spin_unlock_irq(&sdev->ipc_lock); + } else { + dev_dbg_ratelimited(sdev->dev, + "IPC reply before FW_READY: %#x|%#x\n", + primary, extension); + } } else { /* Notification received */ @@ -225,16 +231,21 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context) * place, the message might not yet be marked as expecting a * reply. */ - spin_lock_irq(&sdev->ipc_lock); + if (likely(sdev->fw_state == SOF_FW_BOOT_COMPLETE)) { + spin_lock_irq(&sdev->ipc_lock); - /* handle immediate reply from DSP core */ - hda_dsp_ipc_get_reply(sdev); - snd_sof_ipc_reply(sdev, msg); + /* handle immediate reply from DSP core */ + hda_dsp_ipc_get_reply(sdev); + snd_sof_ipc_reply(sdev, msg); - /* set the done bit */ - hda_dsp_ipc_dsp_done(sdev); + /* set the done bit */ + hda_dsp_ipc_dsp_done(sdev); - spin_unlock_irq(&sdev->ipc_lock); + spin_unlock_irq(&sdev->ipc_lock); + } else { + dev_dbg_ratelimited(sdev->dev, "IPC reply before FW_READY: %#x\n", + msg); + } ipc_irq = true; } -- 2.35.1

1 0

[Sound-open-firmware] [PATCH AUTOSEL 5.19 12/48] ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware boot
by Sasha Levin 14 Aug '22

14 Aug '22

From: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> [ Upstream commit acacd9eefd0def5a83244d88e5483b5f38ee7287 ] It is not yet clear, but it is possible to create a firmware so broken that it will send a reply message before a FW_READY message (it is not yet clear if FW_READY will arrive later). Since the reply_data is allocated only after the FW_READY message, this will lead to a NULL pointer dereference if not filtered out. The issue was reported with IPC4 firmware but the same condition is present for IPC3. Reported-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20220712122357.31282-2-peter.ujfalusi@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/cnl.c | 37 ++++++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/sound/soc/sof/intel/cnl.c b/sound/soc/sof/intel/cnl.c index cd6e5f8a5eb4..6c98f65635fc 100644 --- a/sound/soc/sof/intel/cnl.c +++ b/sound/soc/sof/intel/cnl.c @@ -60,17 +60,23 @@ irqreturn_t cnl_ipc4_irq_thread(int irq, void *context) if (primary & SOF_IPC4_MSG_DIR_MASK) { /* Reply received */ - struct sof_ipc4_msg *data = sdev->ipc->msg.reply_data; + if (likely(sdev->fw_state == SOF_FW_BOOT_COMPLETE)) { + struct sof_ipc4_msg *data = sdev->ipc->msg.reply_data; - data->primary = primary; - data->extension = extension; + data->primary = primary; + data->extension = extension; - spin_lock_irq(&sdev->ipc_lock); + spin_lock_irq(&sdev->ipc_lock); - snd_sof_ipc_get_reply(sdev); - snd_sof_ipc_reply(sdev, data->primary); + snd_sof_ipc_get_reply(sdev); + snd_sof_ipc_reply(sdev, data->primary); - spin_unlock_irq(&sdev->ipc_lock); + spin_unlock_irq(&sdev->ipc_lock); + } else { + dev_dbg_ratelimited(sdev->dev, + "IPC reply before FW_READY: %#x|%#x\n", + primary, extension); + } } else { /* Notification received */ notification_data.primary = primary; @@ -124,15 +130,20 @@ irqreturn_t cnl_ipc_irq_thread(int irq, void *context) CNL_DSP_REG_HIPCCTL, CNL_DSP_REG_HIPCCTL_DONE, 0); - spin_lock_irq(&sdev->ipc_lock); + if (likely(sdev->fw_state == SOF_FW_BOOT_COMPLETE)) { + spin_lock_irq(&sdev->ipc_lock); - /* handle immediate reply from DSP core */ - hda_dsp_ipc_get_reply(sdev); - snd_sof_ipc_reply(sdev, msg); + /* handle immediate reply from DSP core */ + hda_dsp_ipc_get_reply(sdev); + snd_sof_ipc_reply(sdev, msg); - cnl_ipc_dsp_done(sdev); + cnl_ipc_dsp_done(sdev); - spin_unlock_irq(&sdev->ipc_lock); + spin_unlock_irq(&sdev->ipc_lock); + } else { + dev_dbg_ratelimited(sdev->dev, "IPC reply before FW_READY: %#x\n", + msg); + } ipc_irq = true; } -- 2.35.1

1 0

[Sound-open-firmware] FYI: setup config was removed from codec adapter topologies
by Daniel Baluta 11 Aug '22

11 Aug '22

Hi Joe, I hope you are right person to direct this email to. Looking at commit: commit bfd5e61768713bf25fe85030268a2f860eb26cf4 Author: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Date: Fri Jan 14 13:18:48 2022 -0800 topology1: remove setup config info from all codec_adapter topologies Remove the setup config info from all initial config data in the codec_adapter kcontrol's. This is no longer needed. This removed setup config from config data. The only place which didn't get this seems to be the DTS codec file: topology/topology1/m4/dts_codec_adapter.m4 Did you notice any bugs in your tests?

1 0

[Sound-open-firmware] [PATCH resend] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning
by Justin Stitt 05 Aug '22

05 Aug '22

When building with Clang we encounter these warnings: | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ Use correct format specifier `%d` since args are of type int. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Reported-by: Nathan Chancellor <nathan(a)kernel.org> Suggested-by: Nathan Chancellor <nathan(a)kernel.org> Signed-off-by: Justin Stitt <justinstitt(a)google.com> --- Note: resending with the subject corrected, this patch fixes a build warning that will break the Clang build when CONFIG_WERROR=y. Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/ Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index b2cc046b9f60..65923e7a5976 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, } dev_info(scomp->dev, - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", man->priv.data[0], man->priv.data[1], man->priv.data[2], SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); -- 2.37.1.359.gd136c6c3e2-goog

4 3

Re: [Sound-open-firmware] [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186
by chunxu.li 04 Aug '22

04 Aug '22

On Thu, 2022-08-04 at 14:33 +0100, Mark Brown wrote: > On Thu, Aug 04, 2022 at 09:21:37PM +0800, chunxu.li wrote: > > On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote: > > > On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote: > > > > + .board = "mediatek,mt8186", > > > > + .sof_tplg_filename = "sof-mt8186.tplg", > > > The mediatek,mt8186 compatible looks like a SoC compatible not a > > > board > > > compatible... > > Our dts config as below: > > kingler board: > > compatible = "google,corsola", "google,kingler", "mediatek,mt8186"; > > krabby board: > > compatible = "google,corsola", "google,krabby", "mediatek,mt8186"; > > So the SoC is listed as a fallback for the board and things work out > fine. > > > Which of the two approaches do you prefer? > > I think it would be clearer to keep what's being matched the same but > rename the .board field to be .compatible, or possibly > .system_compatible > or something if it's unclear what's being matched. That'd be more > normal for specifying a compatible string anyway. Appreciated for you advice, I'll rename the .board to .compatible as following: + .compatible = "mediatek,mt8186", + .sof_tplg_filename = "sof-mt8186.tplg",

1 0

Re: [Sound-open-firmware] [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select
by chunxu.li 04 Aug '22

04 Aug '22

On Thu, 2022-08-04 at 14:17 +0100, Mark Brown wrote: > On Thu, Aug 04, 2022 at 05:13:58PM +0800, Chunxu Li wrote: > > > @@ -284,6 +284,7 @@ struct snd_sof_dsp_ops { > > void (*machine_unregister)(struct snd_sof_dev *sdev, > > void *pdata); /* optional */ > > struct snd_soc_acpi_mach * (*machine_select)(struct snd_sof_dev > > *sdev); /* > > optional */ > > + struct snd_sof_of_mach * (*of_machine_select)(struct > > snd_sof_dev *sdev); > > I don't understand why we pass this in as a function when as far as I > can see it should always be the standard operation provided by the > core > - why not just always call the function? We can tell at runtime if > the > system is using DT so there's no issue there and there shouldn't be > any > concerns with ACPI or other firmware interfaces. Thanks for you advice, I'll remove the callback function, and directly call sof_of_machine_select() in sof_machine_check() as following. int sof_machine_check(struct snd_sof_dev *sdev) { snip... const struct snd_sof_of_mach *of_mach; /* find machine */ mach = snd_sof_machine_select(sdev); if (mach) { sof_pdata->machine = mach; snd_sof_set_mach_params(mach, sdev); return 0; } + of_mach = sof_of_machine_select(sdev); + if (of_mach) { + sof_pdata->of_machine = of_mach; + return 0; + } snip ... }

1 0

Re: [Sound-open-firmware] [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186
by chunxu.li 04 Aug '22

04 Aug '22

On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote: > On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote: > > > +static struct snd_sof_of_mach sof_mt8186_machs[] = { > > + { > > + .board = "mediatek,mt8186", > > + .sof_tplg_filename = "sof-mt8186.tplg", > > The mediatek,mt8186 compatible looks like a SoC compatible not a > board > compatible... Our dts config as below: kingler board: compatible = "google,corsola", "google,kingler", "mediatek,mt8186"; krabby board: compatible = "google,corsola", "google,krabby", "mediatek,mt8186"; they all use the same sof_tplg_filename, so i use "mediatek,mt8186" to match these. The original code looks like the following: static struct snd_soc_acpi_mach sof_mt8186_machs[] = { { .board = "google,kingler", .sof_tplg_filename = "sof-mt8186.tplg", }, { .board = "google,krabby", .sof_tplg_filename = "sof-mt8186.tplg", }, {} }; Which of the two approaches do you prefer?

1 0

[Sound-open-firmware] [PATCH 0/2] ASoC: SOF: Introduce of_machine_select
by Chunxu Li 04 Aug '22

04 Aug '22

From: "chunxu.li" <chunxu.li(a)mediatek.com> In these patches, we introduce of_machine_select for SOF Chunxu Li (2): ASoC: SOF: Introduce optional callback of_machine_select ASoC: SOF: mediatek: Add .of_machine_select field for mt8186 include/sound/sof.h | 2 ++ sound/soc/sof/mediatek/mt8186/mt8186.c | 11 +++++++++++ sound/soc/sof/ops.h | 9 +++++++++ sound/soc/sof/pcm.c | 8 +++++++- sound/soc/sof/sof-audio.c | 7 +++++++ sound/soc/sof/sof-of-dev.c | 23 +++++++++++++++++++++++ sound/soc/sof/sof-of-dev.h | 8 ++++++++ sound/soc/sof/sof-priv.h | 1 + 8 files changed, 68 insertions(+), 1 deletion(-) -- 2.25.1

1 2

[Sound-open-firmware] change in west usage for SOF Zephyr builds
by Kai Vehmanen 04 Aug '22

04 Aug '22

Hi, just a heads up that the recent change to sof/scripts/xtensa-build-zephyr.py in commit "xtensa-build-zephyr.py: use west manifest", merged to SOF main yesterday, has been causing trouble to some users. The change adds a west manifest to SOF repository. This is now used to check out zephyr in a specific place in the work area, and most importantly, to have a version controlled way to specify which version of Zephyr (and other subprojects) to build against, when building SOF with Zephyr. Easiest way to recover is to check out a new work area to build SOF with Zephyr. Br, Kai

1 0

Re: [Sound-open-firmware] [PATCH] soc: sof: fix clang -Wformat warnings
by Nathan Chancellor 02 Aug '22

02 Aug '22

Hi all, On Thu, Jul 21, 2022 at 02:12:18PM -0700, Justin Stitt wrote: > When building with Clang we encounter these warnings: > | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type > | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] > | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); > | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ > > Use correct format specifier `%d` since args are of type int. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Reported-by: Nathan Chancellor <nathan(a)kernel.org> > Suggested-by: Nathan Chancellor <nathan(a)kernel.org> > Signed-off-by: Justin Stitt <justinstitt(a)google.com> > --- > Reported by Nathan here: > https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ > > sound/soc/sof/ipc3-topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c > index b2cc046b9f60..65923e7a5976 100644 > --- a/sound/soc/sof/ipc3-topology.c > +++ b/sound/soc/sof/ipc3-topology.c > @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, > } > > dev_info(scomp->dev, > - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", > + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", > man->priv.data[0], man->priv.data[1], man->priv.data[2], > SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); > > -- > 2.37.1.359.gd136c6c3e2-goog > > Is it too late for this patch to make 6.0? We are trying to enable -Wformat for clang in 6.0 and this instance of that warning was introduced this development cycle by commit 323aa1f093e6 ("ASoC: SOF: Add a new IPC op for parsing topology manifest"). If I am tracking all my patches correctly, this is the only instance of -Wformat that does not have a patch applied to a maintainer's tree so it would be really unfortunate if we could not sure it on for -rc1. We could probably route this via the Kbuild tree with an Ack along with the patch that enables -Wformat if it cannot go via Mark's or Takashi's ree. Cheers, Nathan

1 0