Hi all,

On Thu, Jul 21, 2022 at 02:12:18PM -0700, Justin Stitt wrote:

When building with Clang we encounter these warnings: | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~

Use correct format specifier `%d` since args are of type int.

Link: https://github.com/ClangBuiltLinux/linux/issues/378 Reported-by: Nathan Chancellor nathan@kernel.org Suggested-by: Nathan Chancellor nathan@kernel.org Signed-off-by: Justin Stitt justinstitt@google.com

---

Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/

sound/soc/sof/ipc3-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c index b2cc046b9f60..65923e7a5976 100644 --- a/sound/soc/sof/ipc3-topology.c +++ b/sound/soc/sof/ipc3-topology.c @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, }

dev_info(scomp->dev,

•  "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n",
  

•  "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n",
  

  man->priv.data[0], man->priv.data[1], man->priv.data[2], SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH);

-- 2.37.1.359.gd136c6c3e2-goog

Is it too late for this patch to make 6.0? We are trying to enable -Wformat for clang in 6.0 and this instance of that warning was introduced this development cycle by commit 323aa1f093e6 ("ASoC: SOF: Add a new IPC op for parsing topology manifest"). If I am tracking all my patches correctly, this is the only instance of -Wformat that does not have a patch applied to a maintainer's tree so it would be really unfortunate if we could not sure it on for -rc1.

We could probably route this via the Kbuild tree with an Ack along with the patch that enables -Wformat if it cannot go via Mark's or Takashi's ree.

Cheers, Nathan