[alsa-devel] [PATCH RESEND] ASoC: dont call dapm_sync while reporting jack always

[Patrick Lai]

On 10/22/2013 8:36 AM, Vinod Koul wrote:
> On Tue, Oct 22, 2013 at 09:32:23AM +0100, Mark Brown wrote:
>> On Mon, Oct 21, 2013 at 07:07:34PM +0530, Vinod Koul wrote:
>>> While reporting the jack status snd_soc_jack_report() invokes snd_soc_dapm_sync()
>>> always. This should be required when we have pins associated with jack and
>>> reporting enables or disables these.
>>> So add a check for this case
>>
>> Applied, thanks.  It'd be good when doing things like this to say what
>> the advantage is; with DAPM the general thing is that it gets called a
>> lot so it should be cheap enough to just call all the time.
> Okay, my thoughts were that it was obvious. We saw an issue when monkey testing
> with jack, bunch of dapm_sync's got triggered (insertion, reroute from usermode,
> removal, again reroute from usermode, and so on). The insertion and removal ones
> were quite not required for cases with no pins
>
We observed the same thing on our side and create another report API
which does not call snd_soc_dapm_sync() :)
Thanks for working out a better solution

Thanks
Patrick
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>


-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.