[alsa-devel] [PATCH RESEND] ASoC: dont call dapm_sync while reporting jack always

Vinod Koul vinod.koul at intel.com
Tue Oct 22 17:36:54 CEST 2013

On Tue, Oct 22, 2013 at 09:32:23AM +0100, Mark Brown wrote:
> On Mon, Oct 21, 2013 at 07:07:34PM +0530, Vinod Koul wrote:
> > While reporting the jack status snd_soc_jack_report() invokes snd_soc_dapm_sync()
> > always. This should be required when we have pins associated with jack and
> > reporting enables or disables these.
> > So add a check for this case
> Applied, thanks.  It'd be good when doing things like this to say what
> the advantage is; with DAPM the general thing is that it gets called a
> lot so it should be cheap enough to just call all the time.
Okay, my thoughts were that it was obvious. We saw an issue when monkey testing
with jack, bunch of dapm_sync's got triggered (insertion, reroute from usermode,
removal, again reroute from usermode, and so on). The insertion and removal ones
were quite not required for cases with no pins

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131022/85669540/attachment.sig>

More information about the Alsa-devel mailing list