[alsa-devel] [PATCH RESEND] ASoC: dont call dapm_sync while reporting jack always

Mark Brown broonie at kernel.org
Wed Oct 23 10:25:08 CEST 2013


On Tue, Oct 22, 2013 at 09:06:54PM +0530, Vinod Koul wrote:
> On Tue, Oct 22, 2013 at 09:32:23AM +0100, Mark Brown wrote:

> > Applied, thanks.  It'd be good when doing things like this to say what
> > the advantage is; with DAPM the general thing is that it gets called a
> > lot so it should be cheap enough to just call all the time.

> Okay, my thoughts were that it was obvious. We saw an issue when monkey testing
> with jack, bunch of dapm_sync's got triggered (insertion, reroute from usermode,
> removal, again reroute from usermode, and so on). The insertion and removal ones
> were quite not required for cases with no pins

It's obvious what it's saving but what's not obvious is what the benefit
of those savings is.  That's the bit it'd be good to cover.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131023/2a8a78cf/attachment.sig>


More information about the Alsa-devel mailing list