[alsa-devel] [PATCH] ASoC: WM8962: Enable start-up and normal bias after reset in runtime resume

Mark Brown broonie at kernel.org
Fri Jun 14 12:51:18 CEST 2013

On Fri, Jun 14, 2013 at 06:08:39PM +0800, Nicolin Chen wrote:

> I understand your point because I also found other wm89xx drivers do this way.
> But the truth is, originally this 8962 codec driver did put biases settings
> into set_bias_level() as the others. But after commit d23031a4d they're put
> into pm_resume().

Don't just quote commit IDs, use the subject lines as well so humans can
read your e-mails.  The commit you're referring to moves some code out
of set_bias_level() into runtime PM.

> As far as I can understand, I think these two approaches should be running
> into a same consequence, while I'm not sure which one's better.

> Sir, do you still think it's better to put them back into set_bias_level()?
> Could you please help me understand the reason?

So, if that's the case why are you changing this...  it may be that what
you need to do is to write a better commit message so it's clear why
you're making the change, your message just described what the code
change does but not why it's being done in that way.

That said the general concept is that runtime PM would be powering on
the device for digital operation (eg, for the GPIOs) and then
set_bias_level() powering up the analogue portions of the device.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130614/dc9655a5/attachment.sig>

More information about the Alsa-devel mailing list