[alsa-devel] [PATCH] ASoC: WM8962: Enable start-up and normal bias after reset in runtime resume

Nicolin Chen b42378 at freescale.com
Fri Jun 14 12:08:39 CEST 2013


On Fri, Jun 14, 2013 at 10:59:17AM +0100, Mark Brown wrote:
> The biases should be being managed using set_bias_level() which will get
> called automatically when audio is being started and stopped.

I understand your point because I also found other wm89xx drivers do this way.
But the truth is, originally this 8962 codec driver did put biases settings
into set_bias_level() as the others. But after commit d23031a4d they're put
into pm_resume().
So I can also see the point that it's reasonable to handle these settings in
pm_resume() since DAPM would call pm_runtime_get_sync(), so as snd_soc_open()
would though, pm_resume() would then finish the settings before the bias level
being set to STANDBY, according to dapm_pre_sequence_async() func.

As far as I can understand, I think these two approaches should be running
into a same consequence, while I'm not sure which one's better.

Sir, do you still think it's better to put them back into set_bias_level()?
Could you please help me understand the reason?

Thank you and looking forward to your reply.
Nicolin Chen

More information about the Alsa-devel mailing list