[alsa-devel] [PATCH] ASoC: WM8962: Enable start-up and normal bias after reset in runtime resume

Nicolin Chen b42378 at freescale.com
Fri Jun 14 13:07:43 CEST 2013

On Fri, Jun 14, 2013 at 11:51:18AM +0100, Mark Brown wrote:
> Don't just quote commit IDs, use the subject lines as well so humans can
> read your e-mails.  The commit you're referring to moves some code out
> of set_bias_level() into runtime PM.

I'm sorry, I'll obey the rule from now on.

> So, if that's the case why are you changing this...  it may be that what
> you need to do is to write a better commit message so it's clear why
> you're making the change, your message just described what the code
> change does but not why it's being done in that way.

You're right. I'll revise it.

> That said the general concept is that runtime PM would be powering on
> the device for digital operation (eg, for the GPIOs) and then
> set_bias_level() powering up the analogue portions of the device.

Understood. But I just tested the set_bias_level() way to handle BIAS,
it prompts "wm8962 0-001a: DC servo timed out" when I start to play a
wav file. There should be still some parts of code not right.
So I'm gonna just revise the comment to continue the resume() methods.
It should be appropriate since pm_suspend() is handling bias-off in
the current code.

If you still can't accept it, I will then trace the code next week.
It's Friday night here, and I'm starving now :(

Thank you,
Nicolin Chen

More information about the Alsa-devel mailing list