[alsa-devel] [PATCH v2]ASoC:blackfin:add ad73311 card driver name
broonie at opensource.wolfsonmicro.com
Thu Sep 15 12:00:37 CEST 2011
On Wed, Sep 14, 2011 at 11:27:28AM +0800, Scott Jiang wrote:
> 2011/9/13 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> > On Tue, Sep 13, 2011 at 02:59:26PM -0400, Scott Jiang wrote:
> > All my comments about the previous revision of the patch continue to
> > apply here. The changlog doesn't explain the issue well (the driver
> > should already end up with a unique name)
> in alsa lib snd_config_hook_load_for_all_cards(), use
> sndrv_ctl_card_info->driver to determine card config,
> not sndrv_ctl_card_info->name, though card name contains enough info.
So the issue isn't that the driver doesn't have a name, it's that you
don't like the name it was given. The changelog needs to explain this,
and also explain why this is an issue in this one driver.
> > and the name you've picked
> > is less distinctive than the existing name.
> I know the name is not good enough, but it is a historical result.
> Asoc copy codec name to card->driver before, cause all cards config
> file in alsa lib conf dir have this kind of name.
This sounds like you should fix userspace. It does go back to the issue
I regularly raise with the Blackfin code constantly assuming that there
can be a single driver which covers all combinations of a Blackfin CPU
with a given CODEC.
More information about the Alsa-devel