[alsa-devel] [PATCH v2]ASoC:blackfin:add ad73311 card driver name

Scott Jiang scott.jiang.linux at gmail.com
Wed Sep 14 05:27:28 CEST 2011


2011/9/13 Mark Brown <broonie at opensource.wolfsonmicro.com>:
> On Tue, Sep 13, 2011 at 02:59:26PM -0400, Scott Jiang wrote:
>
>> Add driver_name in snd_soc_card, asoc will copy this name to driver field of snd_card.
>> ALSA lib need this info to load the proper card config.
>
>>  static struct snd_soc_card bf5xx_ad73311 = {
>>       .name = "bfin-ad73311",
>> +     .driver_name = "AD73311",
>
> All my comments about the previous revision of the patch continue to
> apply here.  The changlog doesn't explain the issue well (the driver
> should already end up with a unique name)
>
in alsa lib snd_config_hook_load_for_all_cards(), use
sndrv_ctl_card_info->driver to determine card config,
not sndrv_ctl_card_info->name, though card name contains enough info.

> and the name you've picked
> is less distinctive than the existing name.
>
I know the name is not good enough, but it is a historical result.
Asoc copy codec name to card->driver before, cause all cards config
file in alsa lib conf dir have this kind of name.


More information about the Alsa-devel mailing list