[alsa-devel] [PATCHv4 17/18] ASoC: Samsung: Generalize Kconfig symbols
jassisinghbrar at gmail.com
Tue Nov 23 15:16:57 CET 2010
On Tue, Nov 23, 2010 at 11:12 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Mon, Nov 22, 2010 at 03:37:22PM +0900, Jassi Brar wrote:
>> SND_SOC_SMDK_SPDIF -> ASOC_SAMSUNG_SMDK_SPDIF
>> SND_SOC_SMDK_WM8580 -> ASOC_SAMSUNG_SMDK_WM8580
>> SND_SOC_SMDK_WM9713 -> ASOC_SAMSUNG_SMDK_WM9713
>> SND_SOC_GONI_AQUILA_WM8994 -> ASOC_GONI_AQUILA_WM8994
> Hrm. These ones I'm not entirely happy about - we're pretty
> consistently using SND_SOC_ rather than ASOC_ throughout the subsystem
> so changing to ASOC_ feels like churn. Is there any great reason for
> the rename? I don't mind the addition of SAMSUNG_ one way or the other,
> it's just the subsystem prefix.
If SND_SOC is to be used across all platforms, my changes are indeed
out of line.
Otherwise, ASOC represents SND_SOC better and compactly.
> I've applied this just now as the rename patch depends on it.
Ok, though I was/am willing to submit yet another revision.
More information about the Alsa-devel