[Sound-open-firmware] [External] Re: Whiskeylake support and kernel version

[Pierre-Louis Bossart]

On 9/13/19 4:55 PM, Mark Pearson wrote:
> Hi Pierre,
> 
> The issue I'm seeing in the 5.2.9 kernel seems to be related to suspend and resume (crash in sof_suspend).
> 
> Are there any particular commits you can point to that might address just that problem? If the crash doesn't happen (rare) then the audio works fine so if I can get it stable it will be good enough for now.

I can't think of any specific commit, it was quite dynamic in Q2 and we 
added quite a few patches. I would maybe look at the delta between 5.3 
and 5.2.9 in the sound/soc/sof directory and try to backport this minimum.

Alternatively the backport for a 5.0 product by the Ubuntu team might be 
also a solution. I don't know where their kernel is though, others would 
need to chime in.

> 
> Thanks!
> Mark
> 
>> -----Original Message-----
>> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>> Sent: Thursday, September 12, 2019 1:08 PM
>> To: Mark Pearson <mpearson at lenovo.com>; Kai Vehmanen
>> <kai.vehmanen at linux.intel.com>
>> Cc: sound-open-firmware at alsa-project.org
>> Subject: Re: [Sound-open-firmware] [External] Re: Whiskeylake support and
>> kernel version
>>
>>
>>
>> On 9/12/19 10:13 AM, Mark Pearson wrote:
>>> Hi,
>>>
>>> If I wanted to backport the latest SOF support back to 5.2.9 (for the customer
>> who wants that) - would that be a crazy thing to do? Any tips or pointers on
>> doing that? Just update sound/soc/sof, include/uapi/sound/soc and
>> include/sound/sof....maybe?
>>
>> We have a dumb script that detects all the changes upstream and tries to apply
>> them on top of whatever kernel version. It's dumb in the sense that it just picks
>> in arbitrary libraries and contributor names, but it can get a working config. It'd
>> have to be a custom build since we only take specific things and can't guarantee
>> that the same backported stuff will work on all platforms.
>>
>> The main problem is that there were a lot of reworks at the core level, with the
>> 'modern' dai style, so I see 226 patches if you do this blindly.
>>
>> # get all changes in broonie-next since last backport git log --oneline --reverse --
>> no-merges v5.2.9..broonie/for-next \
>>       > log_broonie.tmp
>>
>> # get log based on directory (can be edited at will) git log --oneline --reverse --
>> no-merges v5.2.9..broonie/for-next -- \
>>       include/sound/sof/*.h include/uapi/sound/sof/*.h \
>>       sound/pci/hda sound/hda \
>>       sound/soc/sof/ \
>>       > log_dir.tmp
>>
>> # get log from sound/ and include/sound based on authors from intel git log --
>> oneline --reverse --no-merges v5.2.9..broonie/for-next --author=intel.com --
>> sound/ include/sound > log_intel.tmp
>>
>> # merge SHA1s
>> cat log_intel.tmp log_dir.tmp | sort -u > list.tmp
>>
>> # extract the relevant SHA1s from the initial list grep -F -x -f list.tmp
>> log_broonie.tmp > gitlog.txt
>>
>> To apply the list (possibly edited), run this:
>> cat gitlog.txt    | awk '{print $1}' > log1.tmp
>> cat log1.tmp | git cherry-pick -x --stdin
>>
>> Disclaimer: backport support is beyond the scope of the SOF development team.
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
>