[Sound-open-firmware] [PATCH 1/2] uapi: ipc: Add lbm in sof_ipc_dai_config

[Liam Girdwood]

On Mon, 2018-06-04 at 16:58 +0800, Pan, Xiuli wrote:
> > > diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h
> > > index 9b1063f..06498fb 100644
> > > --- a/src/include/uapi/ipc.h
> > > +++ b/src/include/uapi/ipc.h
> > > @@ -345,7 +345,7 @@ struct sof_ipc_dai_config {
> > >    
> > >       /* physical protocol and clocking */
> > >       uint16_t format;        /* SOF_DAI_FMT_ */
> > > -    uint16_t reserved;      /* alignment */
> > > +    uint16_t lbm;           /* loopback mode*/
> > >    
> > > 
> > 
> > loopback is not tied to HW config, it can be enabled/disable at runtime so
> > hould use the standard IPC for component commands like volume.
> 
> OK, this is done by suggestion from Pierre to not use a kcontrol but a 
> static topology token,
> So if it is need to be runtime enable/disable. Then a kcontrol or a 
> debugfs should be used?

kcontrol is more flexible since we don't have to change topologies and they
should come as standard with all SSP topologies. 

> I tried to use kcontrol but did not know which widget to bind with in 
> the pipeline. The DAPM kcontrol has so many limit.
> What would you suggest to do with it?

SSp port is represented by AIF widget ? If so, add a kcontrol to it.

Liam