[Sound-open-firmware] [PATCH 1/2] uapi: ipc: Add lbm in sof_ipc_dai_config

[Pan, Xiuli]

On 6/4/2018 16:34, Liam Girdwood wrote:
> On Mon, 2018-06-04 at 14:38 +0800, Xiuli Pan wrote:
>> From: Pan Xiuli <xiuli.pan at linux.intel.com>
>>
>> Add loopback mode filed lbm in sof_ipc_dai_config to condif BE dai
>> loobback mode.
>>
>> Signed-off-by: Pan Xiuli <xiuli.pan at linux.intel.com>
>> ---
>> Work with patch set:
>> SOF-Kernel:
>>    ASoC: SOF: upai: ipc: Add lbm in sof_ipc_dai_config
>>    ASoC: SOF: uapi: topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    ASoC: SOF: topology: Add topology handler for dai config loopback mode
>> SOF:
>>    uapi: ipc: Add lbm in sof_ipc_dai_config
>>    IPC: Add IPC handler for dai config loopback mode
>> SOF-Tools:
>>    topology: Add SOF_TKN_DAI_LBM for ssp loopback mode
>>    topology: m4: Add option for loopback mode in DAI config
>>    topology: test: Add loopback topology
>>
>> test & santity test with:
>> Mininow max rt5651 and UP2 Hifiberry PRO and CNL nocodec
>> SOF master: 65ddcddfcc9a20f5b622cf3ba93dc326387a9d5d
>> SOF-Tool master: 07d290c8ac6026af28bada021ac2215e3453fa88
>> https://github.com/plbossart/sound/tree/topic/sof-v4.14:
>> 3ffd39334cb53aced88b8aba17cae3df9ee2736f
>>
>> ---
>>   src/include/uapi/ipc.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/include/uapi/ipc.h b/src/include/uapi/ipc.h
>> index 9b1063f..06498fb 100644
>> --- a/src/include/uapi/ipc.h
>> +++ b/src/include/uapi/ipc.h
>> @@ -345,7 +345,7 @@ struct sof_ipc_dai_config {
>>   
>>   	/* physical protocol and clocking */
>>   	uint16_t format;	/* SOF_DAI_FMT_ */
>> -	uint16_t reserved;	/* alignment */
>> +	uint16_t lbm;		/* loopback mode*/
>>   
>>
> loopback is not tied to HW config, it can be enabled/disable at runtime so
> hould use the standard IPC for component commands like volume.
OK, this is done by suggestion from Pierre to not use a kcontrol but a 
static topology token,
So if it is need to be runtime enable/disable. Then a kcontrol or a 
debugfs should be used?
I tried to use kcontrol but did not know which widget to bind with in 
the pipeline. The DAPM kcontrol has so many limit.
What would you suggest to do with it?

Thanks
Xiuli

> Liam
> _______________________________________________
> Sound-open-firmware mailing list
> Sound-open-firmware at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware