[PATCH 1/5] ASoC: soc-pcm: cleanup cppcheck warning at soc_pcm_apply_msb()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Jul 28 00:52:03 CEST 2021
Hi Pierre-Louis
Thank you for your feedback
> > sound/soc/soc-pcm.c:446:29: style: The scope of the variable 'pcm_codec' can be reduced. [variableScope]
> > struct snd_soc_pcm_stream *pcm_codec, *pcm_cpu;
> > ^
> > sound/soc/soc-pcm.c:446:41: style: The scope of the variable 'pcm_cpu' can be reduced. [variableScope]
> > struct snd_soc_pcm_stream *pcm_codec, *pcm_cpu;
> > ^
>
> I personally ignore those warnings, there are hundreds of them and it'd
> be a relatively marginal improvement in code quality.
>
> my scripts use the following options to focus on more important issues
> first.
Yes, these are not important and boring patch :)
But it will be indicated forever if no one fix it.
I can squash all soc-xxx.c related patches into 1 patch,
but it is not good for backporting (?)
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list