[PATCH 1/5] ASoC: soc-pcm: cleanup cppcheck warning at soc_pcm_apply_msb()

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Jul 27 15:33:05 CEST 2021



On 7/26/21 9:05 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> This patch cleanups below cppcheck warning.
> 
> sound/soc/soc-pcm.c:446:29: style: The scope of the variable 'pcm_codec' can be reduced. [variableScope]
>  struct snd_soc_pcm_stream *pcm_codec, *pcm_cpu;
>                             ^
> sound/soc/soc-pcm.c:446:41: style: The scope of the variable 'pcm_cpu' can be reduced. [variableScope]
>  struct snd_soc_pcm_stream *pcm_codec, *pcm_cpu;
>                                         ^

I personally ignore those warnings, there are hundreds of them and it'd
be a relatively marginal improvement in code quality.

my scripts use the following options to focus on more important issues
first.

--suppress=variableScope --suppress=shiftTooManyBitsSigned
--suppress=arithOperationsOnVoidPointer --suppress=bitwiseOnBoolean



More information about the Alsa-devel mailing list