License clarification of sound/soc/qcom/qdsp6/q6afe-clocks.c

Lukas Bulwahn lukas.bulwahn at gmail.com
Sat Sep 26 19:01:32 CEST 2020


Dear Srinivas,

with commit 520a1c396d19 ("ASoC: q6afe-clocks: add q6afe clock 
controller"), you have added the file sound/soc/qcom/qdsp6/q6afe-clocks.c 
with the SPDX-License-Identifier: GPL-1.0.

The use of 'GPL-1.0 only' is strongly not recommended as the Usage-Guide 
in ./LICENSES/deprecated/GPL-1.0 points out:

  The GNU General Public License (GPL) version 1 should not be used in new
  code. For existing kernel code the 'or any later version' option is
  required to be compatible with the general license of the project: GPLv2.

At the end of the file, you further state it licensed with GPL-2.0 with 
the following line:

MODULE_LICENSE("GPL v2");

So, is this just a typo in the SPDX-License-Identifier or do you really 
intend to license this file under GPL-1.0 only?


Best regards,

Lukas


More information about the Alsa-devel mailing list