[alsa-devel] [PATCH 08/12] ASoC: SOF: Generic probe compress operations

[Cezary Rojewski]

On 2020-01-24 20:41, Pierre-Louis Bossart wrote:
> 
>> +config SND_SOC_SOF_DEBUG_PROBES
>> +    bool "SOF enable data probing"
>> +    select SND_SOC_COMPRESS
>> +    help
>> +      This option enables the data probing feature that can be used to
>> +      gather data directly from specific points of the audio pipeline.
>> +      Say Y if you want to enable probes.
>> +      If unsure, select "N".
>> +
>>   endif ## SND_SOC_SOF_DEBUG
>>   endif ## SND_SOC_SOF_DEVELOPER_SUPPORT
> 
> This one is interesting.
> 
> Do we want to limit the PROBES to developers? Or do we want to enable 
> probes on production firmware as well - which could be really useful for 
> people tuning stuff on platform using production keys, i.e. without the 
> ability to re-generate the firmware on their own.
> 
> And if the firmware does not include support for probes, we should 
> detect it and I didn't see anything in this series that checks this 
> capability? And if the firmware does not report it then it's a miss in 
> the design.

The only config I cared about is: _DEBUG as probes are a debug feature. 
Since the _DEVELOPER_SUPPORT is a superset of debug and several other 
features, it's obvious it ended up as a requirement.

Czarek