[alsa-devel] [PATCH 08/12] ASoC: SOF: Generic probe compress operations
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Fri Jan 24 21:00:34 CET 2020
> +int sof_probe_compr_open(struct snd_compr_stream *cstream,
> + struct snd_soc_dai *dai)
> +{
> + struct snd_sof_dev *sdev =
> + snd_soc_component_get_drvdata(dai->component);
> + int ret;
> +
> + ret = snd_sof_probe_compr_assign(sdev, cstream, dai);
> + if (ret < 0) {
> + dev_err(dai->dev, "Failed to assign probe stream: %d\n", ret);
> + return ret;
> + }
> +
> + sdev->extractor = ret;
could you either rename the 'extractor' field to something meaningful or
add a comment on what is stored in this field? A stream tag? a device
number? It's only used once for the init.
More information about the Alsa-devel
mailing list