[alsa-devel] [PATCH 07/10] ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Fri Feb 14 01:08:33 CET 2020


Hi Ranjani

> > Below functions are doing very similar things, the difference is
> > only used state.
> > 
> > 	snd_soc_dpcm_can_be_free_stop()
> > 	snd_soc_dpcm_can_be_params()
> > 
> > This patch adds common snd_soc_dpcm_can_be(), and use it from
> > snd_soc_dpcm_can_be_free_stop() / snd_soc_dpcm_can_be_params().
> > This can reduce duplicate code.
> 
> Morimoto-san,
> 
> Only minor but does it make it a bit more intuitive to call this new
> function snd_soc_dpcm_check_state() or something equivalent maybe?

Thank you for pointing it.
I like understandable naming :)
Will fix it in v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list